ainur/metube
1
0
Fork 0
mirror of https://github.com/alexta69/metube.git synced 2026-09-21 13:35:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: stop stating the output file on every progress tick (#980)

Browse Source 
yt-dlp documents 'filename' as always present in a progress hook, so the
update_status branch that stats it ran on every forwarded tick: throttled
to one every 0.5s per download, times MAX_CONCURRENT_DOWNLOADS. Those are
blocking syscalls on the event loop, and when the filesystem is slow each
one freezes every other request the server is serving -- which is what a
bare GET timing out at >10s looks like from outside.

The call was also useless while it was expensive. Until the download
finishes the bytes live in tmpfilename; 'filename' is the destination,
which does not exist yet, so os.path.exists() returned False and size
stayed None. It only yields a real value on a terminal status, and the
Downloading table has no size column, so nothing displayed it before
completion either way.

Stat only when the status is 'finished'. That covers both moments a file
genuinely exists at that path: yt-dlp's own finished status, and the
MoveFiles postprocessor reporting the final merged name.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Alex Shnitman
2026-08-21 09:23:09 +02:00
parent 82e966caaf
commit 327e1eb4b8
2 changed files with 73 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/ytdl.py
+11 -1
View File
@@ -1027,7 +1027,17 @@ class Download:
if not rel_name.lower().endswith(allowed_caption_exts):
continue
self.info.filename = rel_name
self.info.size = os.path.getsize(fileName) if os.path.exists(fileName) else None
# Stat only on a terminal status. yt-dlp documents 'filename' as
# always present in a progress hook, but until the download
# finishes the bytes are in tmpfilename and 'filename' is a
# destination that does not exist yet -- so this was two
# blocking syscalls on the event loop, twice a second per
# active download, to arrive at None. A stat that takes seconds
# on a contended filesystem stalls every other request the
# server is serving. Nothing displays the size before
# completion: the Downloading table has no size column.
if status.get('status') == 'finished':
self.info.size = os.path.getsize(fileName) if os.path.exists(fileName) else None
if getattr(self.info, 'download_type', '') == 'thumbnail':
# The thumbnail convertor always emits a .jpg, but yt-dlp may
# report the pre-conversion media/thumbnail extension