From fd3aaea9d9de1f28cf166e9622d809b70c0ab863 Mon Sep 17 00:00:00 2001
From: ddmoney420 <ddmoney420@users.noreply.github.com>
Date: Sun, 1 Mar 2026 19:06:58 -0700
Subject: [PATCH] feat: expandable error details with copy-to-clipboard (closes
 #143)

---
 ui/src/app/app.html | 38 ++++++++++++++++++++++++++++++--------
 ui/src/app/app.ts   | 22 +++++++++++++++++++++-
 2 files changed, 51 insertions(+), 9 deletions(-)

diff --git a/ui/src/app/app.html b/ui/src/app/app.html
index db035b8..6244667 100644
--- a/ui/src/app/app.html
+++ b/ui/src/app/app.html
@@ -463,20 +463,42 @@
                   <fa-icon [icon]="faCheckCircle" class="text-success" />
                 }
                 @if (entry[1].status === 'error') {
-                  <fa-icon [icon]="faTimesCircle" class="text-danger" />
+                  <fa-icon [icon]="faTimesCircle" class="text-danger" style="cursor: pointer;" (click)="toggleErrorDetail(entry[0])" />
                 }
               </div>
               <span ngbTooltip="{{buildResultItemTooltip(entry[1])}}">@if (!!entry[1].filename) {
                 <a href="{{buildDownloadLink(entry[1])}}" target="_blank">{{ entry[1].title }}</a>
               } @else {
-                {{entry[1].title}}
-                @if (entry[1].msg) {
-                  <span><br>{{entry[1].msg}}</span>
-                }
-                @if (entry[1].error) {
-                  <span><br>Error: {{entry[1].error}}</span>
-                }
+                <span [style.cursor]="entry[1].status === 'error' ? 'pointer' : 'default'"
+                  (click)="entry[1].status === 'error' ? toggleErrorDetail(entry[0]) : null">
+                  {{entry[1].title}}
+                  @if (entry[1].status === 'error' && !isErrorExpanded(entry[0])) {
+                    <small class="text-danger ms-2">
+                      <fa-icon [icon]="faChevronRight" size="xs" class="me-1" />Click for details
+                    </small>
+                  }
+                </span>
               }</span>
+              @if (entry[1].status === 'error' && isErrorExpanded(entry[0])) {
+                <div class="alert alert-danger py-2 px-3 mt-2 mb-0 small" style="border-left: 4px solid var(--bs-danger);">
+                  <div class="d-flex justify-content-between align-items-start">
+                    <div class="flex-grow-1">
+                      @if (entry[1].msg) {
+                        <div class="mb-1"><strong>Message:</strong> {{entry[1].msg}}</div>
+                      }
+                      @if (entry[1].error) {
+                        <div class="mb-1"><strong>Error:</strong> {{entry[1].error}}</div>
+                      }
+                      <div class="text-muted" style="word-break: break-all;"><strong>URL:</strong> {{entry[1].url}}</div>
+                    </div>
+                    <button type="button" class="btn btn-sm btn-outline-danger ms-2 flex-shrink-0"
+                      (click)="copyErrorMessage(entry[1]); $event.stopPropagation()"
+                      ngbTooltip="Copy error details to clipboard">
+                      <fa-icon [icon]="faCopy" />
+                    </button>
+                  </div>
+                </div>
+              }
             </td>
             <td>
               @if (entry[1].size) {
diff --git a/ui/src/app/app.ts b/ui/src/app/app.ts
index 0933347..17281c6 100644
--- a/ui/src/app/app.ts
+++ b/ui/src/app/app.ts
@@ -6,7 +6,7 @@ import { FormsModule } from '@angular/forms';
 import { FontAwesomeModule } from '@fortawesome/angular-fontawesome';
 import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
 import { NgSelectModule } from '@ng-select/ng-select';  
-import { faTrashAlt, faCheckCircle, faTimesCircle, faRedoAlt, faSun, faMoon, faCheck, faCircleHalfStroke, faDownload, faExternalLinkAlt, faFileImport, faFileExport, faCopy, faClock, faTachometerAlt, faSortAmountDown, faSortAmountUp } from '@fortawesome/free-solid-svg-icons';
+import { faTrashAlt, faCheckCircle, faTimesCircle, faRedoAlt, faSun, faMoon, faCheck, faCircleHalfStroke, faDownload, faExternalLinkAlt, faFileImport, faFileExport, faCopy, faClock, faTachometerAlt, faSortAmountDown, faSortAmountUp, faChevronRight } from '@fortawesome/free-solid-svg-icons';
 import { faGithub } from '@fortawesome/free-brands-svg-icons';
 import { CookieService } from 'ngx-cookie-service';
 import { DownloadsService } from './services/downloads.service';
@@ -67,6 +67,7 @@ export class App implements AfterViewInit, OnInit {
   metubeVersion: string | null = null;
   isAdvancedOpen = false;
   sortAscending = false;
+  expandedErrors: Set<string> = new Set();
 
   // Download metrics
   activeDownloads = 0;
@@ -103,6 +104,7 @@ export class App implements AfterViewInit, OnInit {
   faTachometerAlt = faTachometerAlt;
   faSortAmountDown = faSortAmountDown;
   faSortAmountUp = faSortAmountUp;
+  faChevronRight = faChevronRight;
   subtitleFormats = [
     { id: 'srt', text: 'SRT' },
     { id: 'txt', text: 'TXT (Text only)' },
@@ -722,6 +724,24 @@ export class App implements AfterViewInit, OnInit {
     return result;
   }
 
+  toggleErrorDetail(id: string) {
+    if (this.expandedErrors.has(id)) this.expandedErrors.delete(id);
+    else this.expandedErrors.add(id);
+  }
+
+  copyErrorMessage(download: Download) {
+    const parts: string[] = [];
+    if (download.title) parts.push(`Title: ${download.title}`);
+    if (download.url) parts.push(`URL: ${download.url}`);
+    if (download.msg) parts.push(`Message: ${download.msg}`);
+    if (download.error) parts.push(`Error: ${download.error}`);
+    navigator.clipboard.writeText(parts.join('\n')).catch(() => {});
+  }
+
+  isErrorExpanded(id: string): boolean {
+    return this.expandedErrors.has(id);
+  }
+
   private updateMetrics() {
     this.activeDownloads = Array.from(this.downloads.queue.values()).filter(d => d.status === 'downloading' || d.status === 'preparing').length;
     this.queuedDownloads = Array.from(this.downloads.queue.values()).filter(d => d.status === 'pending').length;