Move code from check_epel_repo_required into the rpm branch of the if check on package_manager_detect(), adjust tests to accommodate
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
This commit is contained in:
@@ -1107,7 +1107,7 @@ def test_package_manager_has_installer_deps(host):
|
||||
install_dependent_packages ${INSTALLER_DEPS[@]}
|
||||
''')
|
||||
|
||||
assert 'No package' not in output.stdout # centos7 still exits 0...
|
||||
assert 'No package' not in output.stdout
|
||||
assert output.rc == 0
|
||||
|
||||
|
||||
@@ -1117,11 +1117,10 @@ def test_package_manager_has_pihole_deps(host):
|
||||
output = host.run('''
|
||||
source /opt/pihole/basic-install.sh
|
||||
package_manager_detect
|
||||
check_epel_repo_required
|
||||
install_dependent_packages ${PIHOLE_DEPS[@]}
|
||||
''')
|
||||
|
||||
assert 'No package' not in output.stdout # centos7 still exits 0...
|
||||
assert 'No package' not in output.stdout
|
||||
assert output.rc == 0
|
||||
|
||||
|
||||
@@ -1131,9 +1130,8 @@ def test_package_manager_has_web_deps(host):
|
||||
output = host.run('''
|
||||
source /opt/pihole/basic-install.sh
|
||||
package_manager_detect
|
||||
check_epel_repo_required
|
||||
install_dependent_packages ${PIHOLE_WEB_DEPS[@]}
|
||||
''')
|
||||
|
||||
assert 'No package' not in output.stdout # centos7 still exits 0...
|
||||
assert 'No package' not in output.stdout
|
||||
assert output.rc == 0
|
||||
|
||||
@@ -14,7 +14,6 @@ def test_enable_epel_repository_centos(host):
|
||||
package_manager_detect = host.run('''
|
||||
source /opt/pihole/basic-install.sh
|
||||
package_manager_detect
|
||||
check_epel_repo_required
|
||||
''')
|
||||
expected_stdout = info_box + (' Enabling EPEL package repository '
|
||||
'(https://fedoraproject.org/wiki/EPEL)')
|
||||
|
||||
@@ -6,11 +6,8 @@ def test_epel_and_remi_not_installed_fedora(host):
|
||||
package_manager_detect = host.run('''
|
||||
source /opt/pihole/basic-install.sh
|
||||
package_manager_detect
|
||||
check_epel_repo_required
|
||||
''')
|
||||
assert package_manager_detect.stdout == ''
|
||||
|
||||
epel_package = host.package('epel-release')
|
||||
assert not epel_package.is_installed
|
||||
remi_package = host.package('remi-release')
|
||||
assert not remi_package.is_installed
|
||||
|
||||
Reference in New Issue
Block a user