Review suggestions (and shellcheck complaints)

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2022-08-23 19:10:12 +01:00
parent 5421aad03e
commit a4b899c256
2 changed files with 10 additions and 24 deletions
@@ -89,13 +89,13 @@ getRemoteVersion(){
    local daemon="${1}"
    local version
    local cachedVersions
-    local arrCache
    cachedVersions="/etc/pihole/versions"

    #If the above file exists, then we can read from that. Prevents overuse of GitHub API
    if [[ -f "$cachedVersions" ]]; then

-        source "$cachedVersions"
+        # shellcheck disable=SC1090
+        . "$cachedVersions"

        case $daemon in
            "pi-hole"   )  echo "${GITHUB_CORE_VERSION}";;