From fd41801977746ee1b3845bd8908b4315784f384b Mon Sep 17 00:00:00 2001 From: Dan Schaper Date: Thu, 7 Jul 2022 12:12:53 -0700 Subject: [PATCH 1/3] Create new log directory Signed-off-by: Dan Schaper --- automated install/basic-install.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index 3f5c972f..86f8c6c6 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -2619,6 +2619,7 @@ main() { stop_service pihole-FTL &> /dev/null if [ -f /var/log/pihole.log ] && [ ! -L /var/log/pihole.log ]; then + mkdir -p /var/log/pihole/ mv /var/log/pihole*.* /var/log/pihole/ 2>/dev/null fi From 48d5d6bed2d1fe615ad42871b1b4315d261dd2bc Mon Sep 17 00:00:00 2001 From: Dan Schaper Date: Thu, 7 Jul 2022 13:23:13 -0700 Subject: [PATCH 2/3] Always create the log target directory before any movements Signed-off-by: Dan Schaper --- automated install/basic-install.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index 939f4b45..fa8934c4 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -2796,6 +2796,11 @@ main() { stop_service pihole-FTL &> /dev/null + if [ -d /var/log/pihole/ ]; then + mkdir /var/log/pihole/ + chmod 0775 /var/log/pihole/ + fi + # Special handling for pihole-FTL.log -> pihole/FTL.log if [ -f /var/log/pihole-FTL.log ] && [ ! -L /var/log/pihole-FTL.log ]; then # /var/log/pihole-FTL.log -> /var/log/pihole/FTL.log From 56a32047b8e08e7520fae6915dc20f837dead50b Mon Sep 17 00:00:00 2001 From: Dan Schaper Date: Thu, 7 Jul 2022 13:50:41 -0700 Subject: [PATCH 3/3] Logic fix Signed-off-by: Dan Schaper --- automated install/basic-install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index fa8934c4..a0a98b68 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -2796,7 +2796,7 @@ main() { stop_service pihole-FTL &> /dev/null - if [ -d /var/log/pihole/ ]; then + if [ ! -d /var/log/pihole/ ]; then mkdir /var/log/pihole/ chmod 0775 /var/log/pihole/ fi