59d2177271
In ./advanced/Scripts/database_migration/gravity-db.sh line 18:
...
piholeDir="${2}"
^-------^ SC2034 (warning): piholeDir appears unused. Verify use (or export if used externally).
Turns out it is _actually_ unused, the full path of the gravity database is passed to the function, so we'll tidy this up rather than supressing.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
a624d3be8d
In ./advanced/Scripts/utils.sh line 91:
...
if [[ $? -eq 5 ]]; then
^------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
6e06a93c31
functionise log rotation and flushing code to avoid dupliation
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 13:57:07 +01:00
bdcb6fc88c
Update update.sh, updatecheck.sh and uninstall.sh to honour pihole.to… ( #5981 )
2025-04-05 01:18:49 +01:00
f403468450
Add webserver log to piholeLogFlush.sh ( #6049 )
2025-04-05 00:33:18 +01:00
4108c817dc
Revert "source with source not dot ( #6137 )"
...
This reverts commit 8fd2ebd3d7557bc6f179
2025-04-04 19:12:57 +01:00
4efe4dfd4b
source with source not dot
...
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid >
2025-04-02 14:21:45 -05:00
0f482396ee
Update update.sh, updatecheck.sh and uninstall.sh to honour pihole.toml settings for webserver.paths.webroot and webserver.paths.webhome
...
When uninstalling, remove web interface parent directory empty check and possible removal.
Signed-off-by: James George <james.george@vigilantvoid.com >
2025-03-30 13:11:21 +08:00
71ec0a0244
Add ON DELETE CASCADE to FOREIGN KEY REFERENCES in gravity.db
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-03-27 13:10:53 +01:00
3f5c00919b
Remove WEB_CALL from COL_TABLE ( #6062 )
2025-03-10 06:14:47 +01:00
349544b24a
Create webserver.log on FTL startup ( #6051 )
2025-03-10 06:14:22 +01:00
80d63eca93
Add 2FA handling to api.sh ( #6065 )
2025-03-08 10:46:54 +01:00
9b4502a7a9
Add trailing / to directories
...
Signed-off-by: casperklein <casperklein@users.noreply.github.com >
2025-03-07 23:00:40 +01:00
5de9b6ae69
Add 2FA handling to api.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-07 13:43:41 +01:00
f3dc202e36
Remove WEB_CALL from COL_TABLE
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-07 10:16:25 +01:00
45cb722e50
version.sh: fix typo in comment
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2025-03-06 21:40:17 +02:00
e437e3a805
Create webserver.log on FTL startup
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-06 09:48:06 +01:00
4df5c0bb96
Add webserver log to piholeLogFlush.sh
...
Signed-off-by: Jack'lul <8418678+jacklul@users.noreply.github.com >
2025-03-05 22:25:33 +01:00
0130f7be74
Fix find command syntax, remove log dir from search
...
Signed-off-by: Jack'lul <8418678+jacklul@users.noreply.github.com >
2025-03-01 14:43:36 +01:00
821c953216
Remove 'reconfigure' option ( #5887 )
2025-02-28 21:14:18 +00:00
ad6a48b219
Add comment about TLS-related file permissions
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-26 20:59:32 +01:00
43ee724718
Improve alignment and add link to blog post
...
CodeQL / Analyze (pull_request) Has been cancelled
Test Supported Distributions / smoke-tests (pull_request) Has been cancelled
Test Supported Distributions / distro-test (centos_9) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (debian_11) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (debian_12) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (fedora_40) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (fedora_41) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Has been cancelled
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Has been cancelled
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-26 13:30:46 +01:00
83a38bb71d
Add comment about file permissions
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-26 12:26:50 +01:00
232d581916
Re-add comment about execute bit on directory
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-26 12:25:51 +01:00
4609f90860
Show an warning dialoge before performing an update
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-25 14:33:30 +01:00
0b380d671d
Follow symlinks with find
...
Incorporating https://github.com/pi-hole/pi-hole/pull/5997
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-24 17:37:01 +01:00
e70981d80f
Do not overwrite TLS cert/key mode
...
FTL correctly creates the cert and especially private key with 0600 mode. But the prestart scripts changes it to 0660.
After removing the dedicated webserver from Pi-hole setups, the pihole group has no purpose anymore, and files should not be writable to any other user than pihole itself, and the private TLS key not reasable to anyone else either.
Additionally, this commit consolidates the chmod calls, applying 0755 to all directories and 0640 to all files, but the TLS key and cert.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-24 17:29:58 +01:00
b59ab5852a
Add missing trailing / when setting permissions of /etc/pihole
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-24 15:59:11 +01:00
cadee26dba
Improve dig error handlin in api.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-22 13:48:55 +01:00
c9e58adc48
DHCP discover timeout was reduced by FTL
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-10 20:41:18 +01:00
d1639740d9
Fix database integrity check in debug log
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-10 20:29:05 +01:00
49cf5bb221
Remove 'reconfigure' option
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-06 21:57:05 +01:00
2ae78e02bd
Add call to os_check in the update script ( #5845 )
2025-02-04 17:35:15 +00:00
6d4d35e848
Merge branch 'development' into tweak/gravity_backup
2025-01-26 19:53:06 +01:00
254b67bca3
Using more user-friendly messages on git describe failure
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-13 20:11:41 -03:00
0ae50eab87
Suppress error message on git describe failure
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-12 20:25:32 -03:00
27fb2bbe3a
Replace some hardcoded paths with pihole.toml values
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:22 -03:00
c78be8a89d
No systemctl or service inside containers
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:22 -03:00
0590bbba2d
Skip some checks in docker container
...
These commands always fail in containers with "command not found" (as expected).
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:21 -03:00
733dce1c4c
If it's a docker container, consider the OS is supported
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:15 -03:00
bd9cc7cbb7
Clean up unused WEBCALL code
...
Debug Log is no longer available via web interface
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 17:15:12 -03:00
fab1ca3a40
Merge branch 'development' into tweak/gravity_backup
2025-01-01 18:46:33 +01:00
bd9cb00574
Perform os_check during update, in case the user has updated to an unsupported OS between Pi-hole updates.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-31 15:31:04 +00:00
3011d48b6f
Use tail instead of parameter expansion
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-22 23:44:31 +01:00
c777152c04
Only separat data and status when needed
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-22 21:57:47 +01:00
4dbf9a0bbb
Install dependencies by creating a meta package on-the-fly ( #5785 )
2024-12-14 08:33:15 +01:00
c380c23592
Merge branch 'development' into packages
2024-12-11 18:34:34 +01:00
764aa48c14
Remove no-longer-needed utils
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-11 17:22:49 +00:00
11e00e04b5
Fix ARP flush command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-07 11:22:58 +01:00
579dc07046
Merge branch 'development' into tweak/gravity_backup
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-26 21:08:09 +01:00
Adam Warner