ainur/pi-hole
1
0
Fork 0
Code Issues Pull Requests Actions 90 Packages Projects Releases Wiki Activity
7,071 Commits 10 Branches 126 Tags
ca06930a509366b496150ebe86b515656261a140
Commit Graph

32 Commits

Author SHA1 Message Date
Adam Warner
1d6b3cd894 Add log file path variables and ensure log files are created if missing (#6441) 2025-10-28 13:40:00 +00:00
Yannick7777
72e3699265 Add log file path variables and ensure log files are created if missing 
Signed-off-by: Yannick7777 <admin@eyer.life>
 2025-10-26 15:19:56 +01:00
casperklein
1818e7e59e Ensure 'versions' file exist on first start 
Signed-off-by: casperklein <casperklein@users.noreply.github.com>
 2025-10-26 12:05:13 +01:00
Christian König
5002ce8ba7 Source files relative to the repos root 
Signed-off-by: Christian König <github@yubiuser.dev>
 2025-04-07 14:10:01 +02:00
Christian König
ca1bab3c1b Fix more shellcheck warnings 
Signed-off-by: Christian König <github@yubiuser.dev>
 2025-04-07 10:52:57 +02:00
yubiuser
36e6c9921e Shellcheck Tweaks (#6147) 2025-04-07 10:08:25 +02:00
Christian König
9f5e18b1cd Make it 644 
Signed-off-by: Christian König <github@yubiuser.dev>
 2025-04-06 21:13:47 +02:00
Christian König
e579397f51 Allow all users to read the version file 
Signed-off-by: Christian König <github@yubiuser.dev>
 2025-04-06 20:52:57 +02:00
Adam Warner
2088601148 Add .shellcheckrc to configure shellcheck ignore SC1090-1 globally 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
 2025-04-06 18:46:47 +01:00
Adam Warner
4108c817dc Revert "source with source not dot (#6137)" 
This reverts commit 8fd2ebd3d7, reversing
changes made to 557bc6f179.
 2025-04-04 19:12:57 +01:00
Michael Woolweaver
4efe4dfd4b source with source not dot 
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid>
 2025-04-02 14:21:45 -05:00
yubiuser
349544b24a Create webserver.log on FTL startup (#6051) 2025-03-10 06:14:22 +01:00
casperklein
9b4502a7a9 Add trailing / to directories 
Signed-off-by: casperklein <casperklein@users.noreply.github.com>
 2025-03-07 23:00:40 +01:00
Christian König
e437e3a805 Create webserver.log on FTL startup 
Signed-off-by: Christian König <github@yubiuser.dev>
 2025-03-06 09:48:06 +01:00
Jack'lul
0130f7be74 Fix find command syntax, remove log dir from search 
Signed-off-by: Jack'lul <8418678+jacklul@users.noreply.github.com>
 2025-03-01 14:43:36 +01:00
MichaIng
ad6a48b219 Add comment about TLS-related file permissions 
Co-authored-by: Dominik <DL6ER@users.noreply.github.com>
Signed-off-by: MichaIng <micha@dietpi.com>
 2025-02-26 20:59:32 +01:00
MichaIng
83a38bb71d Add comment about file permissions 
Co-authored-by: Dominik <DL6ER@users.noreply.github.com>
Signed-off-by: MichaIng <micha@dietpi.com>
 2025-02-26 12:26:50 +01:00
MichaIng
232d581916 Re-add comment about execute bit on directory 
Co-authored-by: Dominik <DL6ER@users.noreply.github.com>
Signed-off-by: MichaIng <micha@dietpi.com>
 2025-02-26 12:25:51 +01:00
MichaIng
0b380d671d Follow symlinks with find 
Incorporating https://github.com/pi-hole/pi-hole/pull/5997

Signed-off-by: MichaIng <micha@dietpi.com>
 2025-02-24 17:37:01 +01:00
MichaIng
e70981d80f Do not overwrite TLS cert/key mode 
FTL correctly creates the cert and especially private key with 0600 mode. But the prestart scripts changes it to 0660.

After removing the dedicated webserver from Pi-hole setups, the pihole group has no purpose anymore, and files should not be writable to any other user than pihole itself, and the private TLS key not reasable to anyone else either.

Additionally, this commit consolidates the chmod calls, applying 0755 to all directories and 0640 to all files, but the TLS key and cert.

Signed-off-by: MichaIng <micha@dietpi.com>
 2025-02-24 17:29:58 +01:00
Christian König
b59ab5852a Add missing trailing / when setting permissions of /etc/pihole 
Signed-off-by: Christian König <github@yubiuser.dev>
 2025-02-24 15:59:11 +01:00
Christian König
1ed5994fa5 Remove temporal log file symlink code. It was introduced 2 years ago with v5.11 and always thought to be temporarily only 
Signed-off-by: Christian König <github@yubiuser.dev>
 2024-07-29 09:25:12 +02:00
Christian König
2c32d485bd Remove obsolet getFTLPIDFile() 
We can get the path of the PID file via getFTLConfigValue files.pid

Signed-off-by: Christian König <github@yubiuser.dev>
 2024-07-27 22:00:52 +02:00
Christian König
d77dbf736c Logrotate config file needs to be owned by root 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-10-18 22:09:38 +02:00
Christian König
40c75289b5 Allow pihole to access subdirs in /etc/pihole 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-10-13 20:07:25 +02:00
Christian König
3c693c1da5 Apply suggestions from code review 
Co-authored-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-08-06 12:04:55 +02:00
Christian König
7bb0ca59d1 Remove traces of /run/pihole 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-08-05 14:54:09 +02:00
Christian König
587a2a1c04 # allow all users to enter der directories 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-08-04 23:52:53 +02:00
Christian König
c360743d41 Re-add file/folder permissions 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-08-04 21:12:40 +02:00
Christian König
a3ea2cd8c3 User pihole should be allowed to edit all its files 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-08-04 19:32:19 +02:00
Christian König
5ae0405446 Ensure pihole-FTL can write custom.list 
Signed-off-by: Christian König <ckoenig@posteo.de>
 2023-08-03 20:46:01 +02:00
MichaIng
81927334f2 Add native systemd service 
Inspired by: https://github.com/pi-hole/pi-hole/pull/2112

A pre-start and a post-stop script are added to reduce doubled setup and cleanup code.

Since systemd services do not natively support dynamic users, test once whether capabilities are supported during install/update, and remove User=pihole otherwise.

Signed-off-by: MichaIng <micha@dietpi.com>
Co-authored-by: DL6ER <dl6er@dl6er.de>
 2022-10-30 19:40:33 +01:00