Commit Graph

  • 36e6c9921e Shellcheck Tweaks (#6147) yubiuser 2025-04-07 10:08:25 +02:00
  • 6c5bc1de39 versions file should readable by others (make pihole -v work for non-root users) (#6002) Dan Schaper 2025-04-06 12:58:16 -07:00
  • 9f5e18b1cd Make it 644 Christian König 2025-04-06 20:52:02 +02:00
  • d28e795266 Permissions on versions file should be 640 Christian König 2025-02-25 21:12:58 +01:00
  • e579397f51 Allow all users to read the version file Christian König 2025-02-24 20:03:44 +01:00
  • 2088601148 Add .shellcheckrc to configure shellcheck ignore SC1090-1 globally Adam Warner 2025-04-06 14:33:34 +01:00
  • 48c59cb6cf In ./automated install/uninstall.sh line 14: readonly ADMIN_INTERFACE_DIR=$(getFTLConfigValue "webserver.paths.webroot")$(getFTLConfigValue "webserver.paths.webhome") ^-----------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. Adam Warner 2025-04-06 14:18:52 +01:00
  • f01e8c70d9 Weirldly, GHA missed these minor warnings however have disabled them as they are due to variables either being used in or declared in basic-install,.sh Adam Warner 2025-04-04 23:54:34 +01:00
  • 3a9b9c027e In ./pihole line 20: source "${colfile}" ^----------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location. Adam Warner 2025-04-04 23:50:51 +01:00
  • f5dc337d1b In ./advanced/Scripts/piholeLogFlush.sh line 12: source ${colfile} ^--------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location. Adam Warner 2025-04-04 23:48:12 +01:00
  • 63623c4353 In ./advanced/Scripts/piholeCheckout.sh line 112: corebranches=($(get_available_branches "${PI_HOLE_FILES_DIR}")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). Adam Warner 2025-04-04 23:46:10 +01:00
  • 59d2177271 In ./advanced/Scripts/database_migration/gravity-db.sh line 18: piholeDir="${2}" ^-------^ SC2034 (warning): piholeDir appears unused. Verify use (or export if used externally). Adam Warner 2025-04-04 23:41:43 +01:00
  • a624d3be8d In ./advanced/Scripts/utils.sh line 91: if [[ $? -eq 5 ]]; then ^------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined. Adam Warner 2025-04-04 23:39:56 +01:00
  • 39f5115135 In ./automated install/basic-install.sh line 1753: local status=$(curl --head --silent "https://ftl.pi-hole.net/${1}" | head -n 1) ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. Adam Warner 2025-04-04 23:39:44 +01:00
  • e018a37a8c First things first - bump severity of shellcheck action from error to warning Adam Warner 2025-04-04 23:24:51 +01:00
  • 6e06a93c31 functionise log rotation and flushing code to avoid dupliation Adam Warner 2025-04-05 00:41:50 +01:00
  • 7e5d9db6b7 Remove no-longer-needed pihole sudoers file (#6143) Adam Warner 2025-04-06 13:52:37 +01:00
  • 5afab5e96c Move list parsing entirely into FTL (#6105) Dominik 2025-04-05 20:15:16 +02:00
  • ab8b8da9c3 Bump pytest-testinfra from 10.1.1 to 10.2.2 in /test (#6151) yubiuser 2025-04-05 12:11:16 +02:00
  • 07864032de Bump pytest-testinfra from 10.1.1 to 10.2.2 in /test dependabot[bot] 2025-04-05 10:05:08 +00:00
  • bdcb6fc88c Update update.sh, updatecheck.sh and uninstall.sh to honour pihole.to… (#5981) Adam Warner 2025-04-05 01:18:49 +01:00
  • f403468450 Add webserver log to piholeLogFlush.sh (#6049) Adam Warner 2025-04-05 00:33:18 +01:00
  • 097ac8336e Add recommended fields to the deb package (#6054) Adam Warner 2025-04-05 00:31:26 +01:00
  • fe2b22c570 Add recommended fields to the deb package Christian König 2025-03-06 19:19:07 +01:00
  • 2477d6b184 Revert #6137 (#6146) Adam Warner 2025-04-04 23:28:51 +01:00
  • f98b9520e4 v5 sudoers file that allowed www-data to run pihole command is no longer needed. "Fixes" #6066 Adam Warner 2025-04-04 23:19:14 +01:00
  • 65b42c1c8f Ensure gravity_Cleanup() checks the correct directory (#6131) yubiuser 2025-04-04 22:50:19 +02:00
  • e548ed043f ensure gravity_Cleanup() checks the correct directory for list data Michael Woolweaver 2025-03-31 22:18:32 -05:00
  • 4108c817dc Revert "source with source not dot (#6137)" Adam Warner 2025-04-04 19:12:57 +01:00
  • 8fd2ebd3d7 source with source not dot (#6137) Dan Schaper 2025-04-02 12:36:48 -07:00
  • 4efe4dfd4b source with source not dot Michael Woolweaver 2025-04-02 14:21:45 -05:00
  • 557bc6f179 Add CentOS 10 to test suite (#6126) Adam Warner 2025-04-02 18:24:36 +01:00
  • 8fce8f6149 build gravityDBfile_default like the other variables (#6133) Adam Warner 2025-04-02 17:12:21 +01:00
  • 3cb6ea503a build gravityDBfile_default like the other variables Michael Woolweaver 2025-04-01 23:57:56 -05:00
  • 7886cfc80b Add CentOS 10 to test suite Christian König 2025-03-31 12:13:34 +02:00
  • 8797a0df05 Sync master back into development (#6122) Adam Warner 2025-03-30 18:31:02 +01:00
  • 0f7803b775 Pi-hole Core v6.0.6 (#6118) v6.0.6 Adam Warner 2025-03-30 17:54:55 +01:00
  • 0f482396ee Update update.sh, updatecheck.sh and uninstall.sh to honour pihole.toml settings for webserver.paths.webroot and webserver.paths.webhome James George 2025-02-23 19:52:15 +08:00
  • 73074f1557 Bump tox from 4.24.2 to 4.25.0 in /test (#6116) yubiuser 2025-03-29 21:46:47 +01:00
  • bc23303788 Bump actions/setup-python from 5.4.0 to 5.5.0 (#6117) yubiuser 2025-03-29 21:43:58 +01:00
  • 49fbdc4c00 Bump actions/setup-python from 5.4.0 to 5.5.0 dependabot[bot] 2025-03-29 10:25:36 +00:00
  • 315528d740 Bump tox from 4.24.2 to 4.25.0 in /test dependabot[bot] 2025-03-29 10:25:08 +00:00
  • 71ec0a0244 Add ON DELETE CASCADE to FOREIGN KEY REFERENCES in gravity.db DL6ER 2025-03-27 13:05:09 +01:00
  • e5cb0efd61 revert #6030 in preparation for docker-pi-hole #1794 (#6086) Adam Warner 2025-03-25 17:06:01 +00:00
  • dec670a6d6 Move list parsing entirely into FTL DL6ER 2025-03-22 09:18:02 +01:00
  • 3a592471c6 revert pi-hole/pi-hole/pull/6030 Michael Woolweaver 2025-03-14 14:32:29 -05:00
  • 3f5c00919b Remove WEB_CALL from COL_TABLE (#6062) yubiuser 2025-03-10 06:14:47 +01:00
  • 349544b24a Create webserver.log on FTL startup (#6051) yubiuser 2025-03-10 06:14:22 +01:00
  • 387ec3a3c2 Bump pytest from 8.3.4 to 8.3.5 in /test (#6068) yubiuser 2025-03-08 11:50:40 +01:00
  • 6b873b2d7f Bump pytest from 8.3.4 to 8.3.5 in /test dependabot[bot] 2025-03-08 10:46:01 +00:00
  • 46e5b3b02e Bump tox from 4.24.1 to 4.24.2 in /test (#6067) yubiuser 2025-03-08 11:44:54 +01:00
  • 27aeed76f0 Bump tox from 4.24.1 to 4.24.2 in /test dependabot[bot] 2025-03-08 10:30:22 +00:00
  • 80d63eca93 Add 2FA handling to api.sh (#6065) yubiuser 2025-03-08 10:46:54 +01:00
  • 72404c983d Add trailing / when changing ownership of /etc/pihole (#6057) yubiuser 2025-03-07 23:08:04 +01:00
  • 9b4502a7a9 Add trailing / to directories casperklein 2025-03-07 23:00:40 +01:00
  • 5de9b6ae69 Add 2FA handling to api.sh Christian König 2025-03-07 13:43:41 +01:00
  • f3dc202e36 Remove WEB_CALL from COL_TABLE Christian König 2025-03-07 10:16:25 +01:00
  • 9050e47049 version.sh: fix typo in comment (#6056) yubiuser 2025-03-06 20:49:20 +01:00
  • 45cb722e50 version.sh: fix typo in comment XhmikosR 2025-03-06 21:40:17 +02:00
  • 98b17edfd7 README.md: switch to the SVG logo (#6052) yubiuser 2025-03-06 14:27:58 +01:00
  • d094b197e3 README.md: switch to the SVG logo XhmikosR 2025-03-06 15:06:34 +02:00
  • e437e3a805 Create webserver.log on FTL startup Christian König 2025-03-06 09:48:06 +01:00
  • 4df5c0bb96 Add webserver log to piholeLogFlush.sh Jack'lul 2025-03-05 22:25:33 +01:00
  • 411b9fcb6d Sync master back into development (#6046) Adam Warner 2025-03-04 19:46:03 +00:00
  • 9fe687bd62 Pi-hole Core v6.0.5 (#6042) v6.0.5 Adam Warner 2025-03-04 17:21:05 +00:00
  • bef8227cbd Use a more general method to determine whether systemd is the init system DL6ER 2025-03-03 20:16:07 +01:00
  • edf336067a Fix gravity.sh -- Alpine / Docker specific issue (#6030) Adam Warner 2025-03-03 17:44:45 +00:00
  • 196a84721f Fix find command syntax, remove log dir from search (#6035) Adam Warner 2025-03-03 17:40:12 +00:00
  • 978694f262 Improve update/fresh install detection (#6034) Adam Warner 2025-03-03 12:23:29 +00:00
  • 7eef780fbc Revert "Improve gravity on systems with low memory" (#6039) Dominik 2025-03-03 11:01:45 +01:00
  • df814ece91 Revert "Improve gravity on systems with low memory" Dominik 2025-03-03 09:00:17 +01:00
  • 9c7e02f213 Update gravity.sh Karol Kania 2025-03-02 12:05:42 +01:00
  • 0130f7be74 Fix find command syntax, remove log dir from search Jack'lul 2025-03-01 14:43:36 +01:00
  • f207385269 Removing kernel check based on discussion in Pi-Hole PR pi-hole#5957. (#6020) Dan Schaper 2025-02-28 20:00:00 -08:00
  • ce73691082 Juggle some code around: - Move random password generation block inside final "fresh install" if block, ensure password is ONLY generated on fresh installs. - Add additional check for fresh install around setting of PIHOLE_DNS1/2, QUERY_LOGGING, and PRIVACY_LEVEL - Remove dedicated displayFinalMessage function. Adam Warner 2025-02-28 22:20:17 +00:00
  • 8874757958 Start by renaming useUpdateVars to fresh_install and flipping the logic, the old name is not relevant any more Adam Warner 2025-02-28 21:29:33 +00:00
  • 821c953216 Remove 'reconfigure' option (#5887) Adam Warner 2025-02-28 21:14:18 +00:00
  • 53e241f057 Improve gravity on systems with low memory (#5977) Dominik 2025-02-28 17:02:56 +01:00
  • a9650ae287 Update gravity.sh Karol Kania 2025-02-28 12:52:07 +01:00
  • 7282aada25 Don't show a warning before the repair is done Christian König 2025-02-28 11:51:09 +01:00
  • c5d66c2162 Do not overwrite TLS cert/key mode (#5998) Dominik 2025-02-27 19:45:32 +01:00
  • 869411a514 Fixing whitespaces after removing lines. UltChowsk 2025-02-27 06:23:56 -05:00
  • d1b5f95aa7 Removing kernel check based on discussion in Pi-Hole PR pi-hole#5957. UltChowsk 2025-02-26 20:37:13 -05:00
  • ad6a48b219 Add comment about TLS-related file permissions MichaIng 2025-02-26 20:59:32 +01:00
  • 43ee724718 Improve alignment and add link to blog post Christian König 2025-02-26 13:30:46 +01:00
  • 83a38bb71d Add comment about file permissions MichaIng 2025-02-26 12:26:50 +01:00
  • 232d581916 Re-add comment about execute bit on directory MichaIng 2025-02-26 12:25:51 +01:00
  • 002536ae09 Do not hide error messages when dealing with services (#5983) Dan Schaper 2025-02-25 12:30:39 -08:00
  • 8a788ad755 Update README.md - Fix Text+URL for allowlisting/denylisting (#5993) yubiuser 2025-02-25 20:57:57 +01:00
  • 4609f90860 Show an warning dialoge before performing an update Christian König 2025-02-25 14:24:59 +01:00
  • 0b380d671d Follow symlinks with find MichaIng 2025-02-24 17:34:32 +01:00
  • 65bcb24d0e Fix test MichaIng 2025-02-24 17:28:33 +01:00
  • e70981d80f Do not overwrite TLS cert/key mode MichaIng 2025-02-24 17:01:17 +01:00
  • 9840b42847 Add missing trailing / when setting permissions of /etc/pihole (#5997) yubiuser 2025-02-24 17:24:10 +01:00
  • b59ab5852a Add missing trailing / when setting permissions of /etc/pihole Christian König 2025-02-24 15:59:11 +01:00
  • a0541dd7fb Update README.md Jeroen Habets 2025-02-24 10:45:17 +01:00
  • 48c4efd7b0 Improve dig error handlin in api.sh (#5965) Dominik 2025-02-23 20:15:31 +01:00
  • 729a44f82a Do not hide error messages when dealing with services MichaIng 2025-02-23 15:48:32 +01:00
  • 9c995962a5 If there are no files to change, don't print an error (#5953) Dominik 2025-02-23 09:04:16 +01:00
  • 5da5d0d4c1 Use temp_store = FILE to avoid memory exhaustion on build the tree for very large databases DL6ER 2025-02-23 08:50:08 +01:00