Commit Graph

1166 Commits

Author SHA1 Message Date
diginc 97c44042e1 Adding failing shellcheck test and results
Should be useful for showing others why other changes were made in the next commit.
2016-10-10 23:28:34 -05:00
diginc a03caea549 setupVar tests passing for debian & centos 2016-10-10 23:14:39 -05:00
Promofaux aa23fb1d56 choose* 2016-10-10 22:34:12 +01:00
Promofaux 4f35aac6dd transpose $ and " 2016-10-10 22:32:30 +01:00
Dan Schaper 4418ca9e9f Missing quote replacement. 2016-10-10 11:41:29 -07:00
Dan Schaper 570611fc09 CentOS Firewall fix 2016-10-10 11:30:15 -07:00
Dan Schaper 94dd5b1ebe More CentOS fixes. 2016-10-10 11:05:29 -07:00
Dan Schaper 74524e024d Always check PIHOLE_dependencies. 2016-10-10 10:36:19 -07:00
Dan Schaper e42b6dcc8e create_pihole_user update @diginc. 2016-10-10 09:21:28 -07:00
Dan Schaper d71b799e75 More cleanups, localize variables, clean formatting. 2016-10-10 08:23:14 -07:00
Dan Schaper 87e7121332 Gravity.sh checks for null value for variables, obliging that expectation. 2016-10-10 07:32:16 -07:00
Dan Schaper 94f6354c94 Spinner blocks set -e trying to get it in functions that won't crash out... 2016-10-10 07:25:43 -07:00
Dan Schaper b79059ebdb Start to add the spinner back in! 2016-10-10 06:46:30 -07:00
Dan Schaper 07b7e8a1a6 Track down a couple more variable name changes. 2016-10-10 06:33:56 -07:00
Dan Schaper 7ae2fc37c0 Match up descriptive variable names with setupVars.conf. Rectifies Ubuntu 16.04 gravity.list bug. 2016-10-10 06:23:17 -07:00
Dan Schaper 4f98c1bebb Boolean operators inside quotes don't work well... 2016-10-10 06:16:00 -07:00
Dan Schaper 2feec01e10 Add start_service and enable_service functions to handle restating services and setting services to start on reboot. 2016-10-10 06:06:34 -07:00
Dan Schaper 72b95e192e Fix logic bug in setup_user, update how setupVars are sourced so they will only be used if the user selects update and not if they select install. 2016-10-10 05:45:37 -07:00
Dan Schaper 47aad254d8 localized some more variables 2016-10-10 03:56:03 -07:00
Dan Schaper bc14074d2a Tighten up Update Whiptail appearance. 2016-10-10 03:39:32 -07:00
Dan Schaper 5ab5b1a190 Overhaul dnsmasq version 3 way handshake configuration files. 2016-10-10 03:23:52 -07:00
Dan Schaper b055f190f5 Factor out interfaces detection. 2016-10-10 03:16:22 -07:00
Dan Schaper 84b8953352 Remove quiet flags from package managment variables. Set quiets in functions by redirecting output. 2016-10-10 02:58:38 -07:00
Dan Schaper 93a591d487 Linting from ShellCheck 2016-10-10 02:57:04 -07:00
Dan Schaper e6c0f38a7c Monolithic changes in one commit again. 2016-10-10 02:24:03 -07:00
Dan Schaper d169305e5d Merge branch 'Fix/installerIssues' into development 2016-10-10 09:08:35 +00:00
Dan Schaper f107ae4f9b Merge conflict resolution 2016-10-10 09:08:25 +00:00
Dan Schaper bad7a08804 Refactor and rename create_pihole_user. Now to actually use the user created... 2016-10-10 01:51:19 -07:00
Dan Schaper 25cbf4cb35 Factor out legacy location script removal. 2016-10-10 01:43:10 -07:00
Dan Schaper 7f179f9a58 Remove sourcing bash completion, would fall off as soon as the subshell terminated. 2016-10-10 01:40:56 -07:00
Dan Schaper 5287ea8537 Refactor stopServices into stop_service and accept arguments for service to stop. Quiet output from a few other functions. 2016-10-10 01:25:11 -07:00
Dan Schaper 43e2aaebf0 rename updateDialogs to update_dialogs 2016-10-10 01:04:59 -07:00
Dan Schaper e60eb66283 UpdateDialogs are now a Whiptail Menu, self-explanatory. 2016-10-10 01:04:03 -07:00
Dan Schaper ca59b808d8 Git clone/update now occurs right after installer dependency checks. Allows for inclusion of installer source files in the repo. Passes set -e 2016-10-10 00:02:50 -07:00
Dan Schaper 8a15fd44d5 Update is_repo() to use git status for validity checks. 2016-10-09 23:53:18 -07:00
Dan Schaper dac2b8942e Typo fix to generate commit. 2016-10-09 22:38:00 -07:00
Dan Schaper 54a1c5b63a Revert inadvertent commits
IDLE keeps committing direct to development.
2016-10-09 22:35:14 -07:00
Dan Schaper 61b02bf6d3 Add OR TRUE to PKG_COUNT so that a 0 package to update doesn't grep -c to an exit value of 1. 2016-10-09 22:27:37 -07:00
Dan Schaper 9d048b2fdf Move Pi-hole dependency checks to main() and out of duplicated install and update functions. Bring them up a level in the subshells. 2016-10-09 22:24:13 -07:00
Dan Schaper d9e28a7422 factor out installer_dependencies 2016-10-09 22:05:06 -07:00
Dan Schaper 1fecdf42ca Move git to installer deps, refactor some functions. 2016-10-09 22:00:23 -07:00
Dan Schaper d4bf85b67c Self contain package_check into package_check_install. Passes set -e test. 2016-10-09 21:44:45 -07:00
Dan Schaper 7131ff27c3 Attempt to set -e 2016-10-09 21:32:25 -07:00
Dan Schaper a30f78c1c8 Oneliner php version check, passes set -e check. 2016-10-09 21:31:36 -07:00
Dan Schaper 7e0afffca8 Revert inadvertent commits 2016-10-09 19:41:32 -07:00
Dan Schaper 293c60fb9c Exit script on failure to install dependent package. 2016-10-09 13:52:36 -07:00
Dan Schaper f5be8b2a5e Single dependency package check function, will exit if any errors with message to update cache. 2016-10-09 13:43:01 -07:00
Dan Schaper 6772603c15 Relocate cache check to its own function 2016-10-09 12:34:53 -07:00
Jacob Salmela a22904f99b Merge pull request #769 from pi-hole/Fix/PackageCacheFresh
Fix/package cache fresh
2016-10-09 09:00:52 -05:00
Jacob Salmela 6710d2852f Merge pull request #770 from pi-hole/Fix/InstallerWrap
#admincrimes Fix/installer wrap
2016-10-09 08:41:47 -05:00