6167c9455c
Merge pull request 'Add trufflehog to testworkflow' ( #17 ) from trufflehog into master
...
CodeQL / Analyze (push) Waiting to run
Check for merge conflicts / main (push) Waiting to run
Sync Back to Development / Syncing branches (push) Waiting to run
Reviewed-on: #17
2026-03-18 14:12:12 +00:00
59ab4723cd
Merge branch 'master' into trufflehog
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:12:02 +00:00
683dd33827
Merge pull request 'Set versions in /etc/pihole/versions to null if script fails' ( #16 ) from fix/version_null into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #16
2026-03-18 14:11:40 +00:00
b3a8a719d8
Merge branch 'master' into fix/version_null
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:11:27 +00:00
2a987db4be
Merge pull request 'development' ( #15 ) from development into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #15
2026-03-18 14:11:08 +00:00
509c272ccb
Merge branch 'master' into development
CodeQL / Analyze (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Check for merge conflicts / main (push) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:10:58 +00:00
3b92ec05cc
Merge pull request 'tweak/update' ( #13 ) from tweak/update into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #13
2026-03-18 14:10:19 +00:00
d34d3f558a
Merge branch 'master' into tweak/update
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:10:10 +00:00
81496e044c
Merge pull request 'docker_disable_flush' ( #12 ) from docker_disable_flush into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #12
2026-03-18 14:09:43 +00:00
ca06930a50
Merge branch 'master' into docker_disable_flush
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:09:34 +00:00
a6f69a13f3
Merge pull request 'Replace sudo with doas on alpine' ( #11 ) from doas_alpine into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #11
2026-03-18 14:09:03 +00:00
3eacdc8872
Merge branch 'master' into doas_alpine
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:08:55 +00:00
87cb43cc85
Merge pull request 'Give FTL 120 seconds to shutdown' ( #10 ) from more_time into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #10
2026-03-18 14:08:37 +00:00
0a903feb12
Merge branch 'master' into more_time
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:08:30 +00:00
15874b002e
Merge pull request 'fix/version_file' ( #7 ) from fix/version_file into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #7
2026-03-18 14:06:44 +00:00
ca9de23ca5
Merge branch 'master' into fix/version_file
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:06:35 +00:00
d807c40ba5
Merge pull request 'Install ARMv7 binary even when we detect a 64bit (aarch64) CPU but the operating system is 32bit. See FTL#2494 for reference' ( #5 ) from tweak/32bitARM into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #5
2026-03-18 14:05:21 +00:00
6ee7eca1e5
Merge branch 'master' into tweak/32bitARM
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:05:15 +00:00
396f85614d
Merge pull request 'Fix permission for *.etag files after gravity run' ( #4 ) from fix/etag into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #4
2026-03-18 14:04:29 +00:00
c95094a6d3
Merge branch 'master' into fix/etag
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:04:22 +00:00
0159461cc0
Merge pull request 'fix/gravity_permission_check' ( #3 ) from fix/gravity_permission_check into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #3
2026-03-18 14:03:54 +00:00
8d24316758
Merge branch 'master' into fix/gravity_permission_check
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:03:46 +00:00
e972595170
Merge pull request 'unsupported/binary' ( #2 ) from unsupported/binary into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #2
2026-03-18 14:03:20 +00:00
ba86a1c23f
Merge branch 'master' into unsupported/binary
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:03:11 +00:00
1703f169ba
Merge pull request 'Move unattended check to the top of the script - exit early if /etc/pihole/pihole.toml file is not found,' ( #1 ) from tweak/6380 into master
...
CodeQL / Analyze (push) Has been cancelled
Check for merge conflicts / main (push) Has been cancelled
Sync Back to Development / Syncing branches (push) Has been cancelled
Reviewed-on: #1
2026-03-18 14:02:47 +00:00
fbb3798dc2
Merge branch 'master' into tweak/6380
Check for merge conflicts / main (push) Waiting to run
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Check for merge conflicts / main (pull_request_target) Waiting to run
2026-03-18 14:02:37 +00:00
yubiuser
cf7139bad8
Bump psf/black from 26.3.0 to 26.3.1 in the github-actions-dependencies group ( #6566 )
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
2026-03-14 14:49:24 +01:00
yubiuser
c7eff386e5
Bump tox from 4.49.0 to 4.49.1 in /test in the python-dependencies group ( #6567 )
2026-03-14 14:46:50 +01:00
dependabot[bot]
47de7d5913
Bump tox from 4.49.0 to 4.49.1 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.49.0 to 4.49.1
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.49.0...4.49.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.49.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-03-14 10:02:46 +00:00
dependabot[bot]
ed3f72958b
Bump psf/black in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [psf/black](https://github.com/psf/black ).
Updates `psf/black` from 26.3.0 to 26.3.1
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](35ea67920b...c6755bb741 )
---
updated-dependencies:
- dependency-name: psf/black
dependency-version: 26.3.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-03-14 10:02:24 +00:00
yubiuser
bdeb05b941
Bump tox from 4.46.3 to 4.49.0 in /test in the python-dependencies group ( #6560 )
2026-03-07 17:06:39 +01:00
yubiuser
2d99a95dfb
Bump the github-actions-dependencies group with 2 updates ( #6561 )
2026-03-07 17:05:35 +01:00
dependabot[bot]
8834b49fd3
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action ) and [psf/black](https://github.com/psf/black ).
Updates `github/codeql-action` from 4.32.4 to 4.32.6
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](89a39a4e59...0d579ffd05 )
Updates `psf/black` from 26.1.0 to 26.3.0
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](6305bf1ae6...35ea67920b )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.6
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: psf/black
dependency-version: 26.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-03-07 10:02:47 +00:00
dependabot[bot]
752273f400
Bump tox from 4.46.3 to 4.49.0 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.46.3 to 4.49.0
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.46.3...4.49.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.49.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-03-07 10:02:46 +00:00
Dominik
3d3be66685
Remove readonly from piholeNetworkFlush.sh to avoid error message ( #6554 )
2026-03-02 18:25:28 +01:00
RD WebDesign
36601eef3a
Remove readonly from piholeNetworkFlush.sh to avoid error message
...
This is a quick fix to avoid the error when api.sh tries to set the
variable again.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2026-03-01 17:29:19 -03:00
yubiuser
ec0ce92aaa
Bump tox from 4.44.0 to 4.46.3 in /test in the python-dependencies group ( #6552 )
2026-02-28 16:32:30 +01:00
dependabot[bot]
6dc67a48e9
Bump tox from 4.44.0 to 4.46.3 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.44.0 to 4.46.3
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.44.0...4.46.3 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.46.3
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-02-28 10:02:45 +00:00
yubiuser
cda392ac97
Remove additional ':' from debug log system time output ( #6551 )
2026-02-24 16:39:35 +01:00
yubiuser
08365b3795
Bump tox from 4.35.0 to 4.44.0 in /test in the python-dependencies group ( #6546 )
2026-02-24 09:19:51 +01:00
Christian König
f28233729c
Remove additional ':' from debug log system time output
...
Signed-off-by: Christian König <github@yubiuser.dev >
2026-02-24 08:51:07 +01:00
Christian König
ec8df55f0d
Set versions in /etc/pihole/versions to null if script fails
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2026-02-23 11:33:06 +01:00
yubiuser
2acb7098d8
Bump the github-actions-dependencies group with 2 updates ( #6547 )
2026-02-22 01:44:36 +01:00
dependabot[bot]
f2af7c8970
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action ) and [actions/stale](https://github.com/actions/stale ).
Updates `github/codeql-action` from 4.32.3 to 4.32.4
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](9e907b5e64...89a39a4e59 )
Updates `actions/stale` from 10.1.1 to 10.2.0
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](997185467f...b5d41d4e1d )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: actions/stale
dependency-version: 10.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-02-21 10:02:51 +00:00
dependabot[bot]
c8ff8b747f
Bump tox from 4.35.0 to 4.44.0 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.35.0 to 4.44.0
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.35.0...4.44.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.44.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-02-21 10:02:39 +00:00
Christian König
4125bcccdc
Files should be created before calling addOrEditKeyValPair
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2026-02-18 09:25:10 +01:00
Christian König
ac37014628
Truncate version file instead of removing and creating freshly
...
Signed-off-by: Christian König <github@yubiuser.dev >
2026-02-18 09:22:11 +01:00
Adam Warner
a393dd83f3
v6.4 ( #6536 )
2026-02-17 20:26:56 +00:00
Christian König
d765ce768f
Wipe version file before creating a new one
...
Signed-off-by: yubiuser <github@yubiuser.dev >
2026-02-16 20:11:17 +01:00
yubiuser
e929d799b8
Don't install unused /usr/local/share/man/man5 ( #6526 )
2026-02-14 20:36:17 +01:00
yubiuser
194d6e3565
Bump tox from 4.34.1 to 4.35.0 in /test in the python-dependencies group ( #6533 )
2026-02-14 13:13:51 +01:00
yubiuser
f90f456bcf
Bump github/codeql-action from 4.32.2 to 4.32.3 in the github-actions-dependencies group ( #6534 )
2026-02-14 12:50:03 +01:00
dependabot[bot]
75af6dc968
Bump github/codeql-action in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.32.2 to 4.32.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](45cbd0c69e...9e907b5e64 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-02-14 10:02:35 +00:00
dependabot[bot]
0b0cbdf7d0
Bump tox from 4.34.1 to 4.35.0 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.34.1 to 4.35.0
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.34.1...4.35.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.35.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-02-14 10:02:34 +00:00
yubiuser
6f54ce8c72
Bump github/codeql-action from 4.32.0 to 4.32.2 in the github-actions-dependencies group ( #6528 )
2026-02-07 11:12:58 +01:00
dependabot[bot]
a90df8072c
Bump github/codeql-action in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.32.0 to 4.32.2
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](b20883b0cd...45cbd0c69e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-02-07 10:02:40 +00:00
darkexplosiveqwx
3d5c832dbe
Remove /usr/local/share/man/man5 from tests
...
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2026-02-06 16:49:31 +01:00
darkexplosiveqwx
8c4778025a
Don't install unused /usr/local/share/man/man5
...
Last used before `pihole-FTL.conf.5` was removed with https://github.com/pi-hole/pi-hole/pull/4489
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2026-02-05 18:45:57 +01:00
yubiuser
8eb602bd2b
Bump github/codeql-action from 4.31.11 to 4.32.0 in the github-actions-dependencies group ( #6525 )
2026-01-31 11:51:05 +01:00
dependabot[bot]
19f80a1aa7
Bump github/codeql-action in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.31.11 to 4.32.0
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](19b2f06db2...b20883b0cd )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.32.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-01-31 10:02:46 +00:00
yubiuser
8abfc5ae1a
Bump the github-actions-dependencies group with 4 updates ( #6522 )
2026-01-28 09:02:56 +01:00
Christian König
03ee5b514d
Fix black formatting
...
Signed-off-by: Christian König <github@yubiuser.dev >
2026-01-28 08:56:25 +01:00
dependabot[bot]
f0bc920384
Bump the github-actions-dependencies group with 4 updates
...
Bumps the github-actions-dependencies group with 4 updates: [actions/checkout](https://github.com/actions/checkout ), [github/codeql-action](https://github.com/github/codeql-action ), [psf/black](https://github.com/psf/black ) and [actions/setup-python](https://github.com/actions/setup-python ).
Updates `actions/checkout` from 6.0.1 to 6.0.2
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](8e8c483db8...de0fac2e45 )
Updates `github/codeql-action` from 4.31.10 to 4.31.11
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](cdefb33c0f...19b2f06db2 )
Updates `psf/black` from 25.12.0 to 26.1.0
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](782e5605c8...6305bf1ae6 )
Updates `actions/setup-python` from 6.1.0 to 6.2.0
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](83679a892e...a309ff8b42 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: github/codeql-action
dependency-version: 4.31.11
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: psf/black
dependency-version: 26.1.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-dependencies
- dependency-name: actions/setup-python
dependency-version: 6.2.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-01-24 10:02:49 +00:00
yubiuser
441832a331
Bump github/codeql-action from 4.31.9 to 4.31.10 in the github-actions-dependencies group ( #6519 )
2026-01-17 11:26:18 +01:00
dependabot[bot]
887255f518
Bump github/codeql-action in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.31.9 to 4.31.10
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](5d4e8d1aca...cdefb33c0f )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.10
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-01-17 10:02:42 +00:00
yubiuser
0f4594c88e
Bump tox from 4.33.0 to 4.34.1 in /test in the python-dependencies group ( #6515 )
2026-01-10 11:05:42 +01:00
dependabot[bot]
ec6d3e2f83
Bump tox from 4.33.0 to 4.34.1 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.33.0 to 4.34.1
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.33.0...4.34.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.34.1
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-01-10 10:01:07 +00:00
Adam Warner
f6531d722b
Add missing -g to the message in gravity recovery command ( #6513 )
2026-01-08 17:46:38 +00:00
RD WebDesign
d0433cdb48
Add missing -g to the message in gravity recovery command
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2026-01-07 00:28:09 -03:00
Adam Warner
42ee5648cf
Use configured location for web repo when updating or repairing ( #6470 )
2026-01-04 13:08:33 +00:00
yubiuser
d9e10413c3
Bump tox from 4.32.0 to 4.33.0 in /test in the python-dependencies group ( #6510 )
2026-01-03 13:22:09 +01:00
dependabot[bot]
102bc6043d
Bump tox from 4.32.0 to 4.33.0 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.32.0 to 4.33.0
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.32.0...4.33.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.33.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2026-01-03 10:01:40 +00:00
yubiuser
25a9897c4e
Bump github/codeql-action from 4.31.8 to 4.31.9 in the github-actions-dependencies group ( #6502 )
2025-12-20 11:40:02 +01:00
dependabot[bot]
dd1e60b505
Bump github/codeql-action in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.31.8 to 4.31.9
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](1b168cd394...5d4e8d1aca )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.9
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-12-20 10:01:25 +00:00
yubiuser
88a23f8f14
Bump pytest from 9.0.1 to 9.0.2 in /test in the python-dependencies group ( #6500 )
2025-12-13 16:49:39 +01:00
yubiuser
a1520d2fa6
Bump the github-actions-dependencies group with 3 updates ( #6499 )
2025-12-13 16:35:19 +01:00
dependabot[bot]
3ddf4014af
Bump pytest in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [pytest](https://github.com/pytest-dev/pytest ).
Updates `pytest` from 9.0.1 to 9.0.2
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/9.0.1...9.0.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-version: 9.0.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-12-13 10:02:04 +00:00
dependabot[bot]
9f07e74eb8
Bump the github-actions-dependencies group with 3 updates
...
Bumps the github-actions-dependencies group with 3 updates: [github/codeql-action](https://github.com/github/codeql-action ), [redhat-plumbers-in-action/differential-shellcheck](https://github.com/redhat-plumbers-in-action/differential-shellcheck ) and [psf/black](https://github.com/psf/black ).
Updates `github/codeql-action` from 4.31.7 to 4.31.8
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](cf1bb45a27...1b168cd394 )
Updates `redhat-plumbers-in-action/differential-shellcheck` from 5.5.5 to 5.5.6
- [Release notes](https://github.com/redhat-plumbers-in-action/differential-shellcheck/releases )
- [Changelog](https://github.com/redhat-plumbers-in-action/differential-shellcheck/blob/main/docs/CHANGELOG.md )
- [Commits](0d9e5b2962...d965e66ec0 )
Updates `psf/black` from 25.11.0 to 25.12.0
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](05f0a8ce1f...782e5605c8 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.8
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: redhat-plumbers-in-action/differential-shellcheck
dependency-version: 5.5.6
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: psf/black
dependency-version: 25.12.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-12-13 10:01:35 +00:00
Christian König
7a352e61bc
Add trufflehog to testworkflow
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-12-07 17:55:39 +01:00
yubiuser
beda7a5e0a
Bump the github-actions-dependencies group with 3 updates ( #6490 )
2025-12-06 11:43:35 +01:00
dependabot[bot]
a5c6c2c12c
Bump the github-actions-dependencies group with 3 updates
...
Bumps the github-actions-dependencies group with 3 updates: [actions/checkout](https://github.com/actions/checkout ), [github/codeql-action](https://github.com/github/codeql-action ) and [actions/stale](https://github.com/actions/stale ).
Updates `actions/checkout` from 6.0.0 to 6.0.1
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](1af3b93b68...8e8c483db8 )
Updates `github/codeql-action` from 4.31.5 to 4.31.7
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](fdbfb4d275...cf1bb45a27 )
Updates `actions/stale` from 10.1.0 to 10.1.1
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](5f858e3efb...997185467f )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: github/codeql-action
dependency-version: 4.31.7
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: actions/stale
dependency-version: 10.1.1
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-12-06 10:01:25 +00:00
Dan Schaper
7442623f2f
Debug log - Add colors to gravity tables ( #6485 )
2025-12-04 12:52:07 -07:00
Dan Schaper
013abb2898
Add Alpine 3.23 to test suite ( #6488 )
2025-12-03 15:48:44 -07:00
Christian König
f5f74066fc
Add Alpine 3.23 to test suite
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-12-03 23:37:04 +01:00
Dan Schaper
6ce1707b55
Remove custom FTL FirewallD zone checks from debug log ( #6481 )
2025-11-30 16:54:03 -07:00
Dan Schaper
e103fbe1c8
Bump the github-actions-dependencies group with 2 updates ( #6483 )
2025-11-30 16:53:25 -07:00
RD WebDesign
1f4ed9b518
Replace some strings with their colored equivalents
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-11-30 18:43:40 -03:00
RD WebDesign
95ae51bbdb
Use more specific strings on the tables to match only desired text
...
- use `--no---` and `--yes---` to make sure the strings won't match user
comments or parts of domains
- also use `-ALLOW-` and `-BLOCK-`
Also reduce the domain column to 90 characters
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-11-30 18:42:02 -03:00
Dan Schaper
a1af212ec0
Remove wget from alpine dependencies ( #6484 )
2025-11-30 11:30:38 -07:00
darkexplosiveqwx
353105ec0f
remove wget from alpine dependencies
...
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2025-11-30 19:00:34 +01:00
dependabot[bot]
d77179a412
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action ) and [actions/setup-python](https://github.com/actions/setup-python ).
Updates `github/codeql-action` from 4.31.4 to 4.31.5
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](e12f017898...fdbfb4d275 )
Updates `actions/setup-python` from 6.0.0 to 6.1.0
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](e797f83bcb...83679a892e )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.5
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: actions/setup-python
dependency-version: 6.1.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-29 10:01:27 +00:00
Adam Warner
3a4c399982
Sync master back into development ( #6482 )
2025-11-27 23:21:18 +00:00
Adam Warner
5a23c9c366
Pi-hole Core v6.3 ( #6480 )
2025-11-27 18:10:51 +00:00
RD WebDesign
247b0c506b
Remove custom FTL FirewallD zone checks from debug log
...
Removed checks for custom FTL FirewallD zone in piholeDebug.sh.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-11-26 23:46:43 -03:00
Adam Warner
d4db2dca22
Improve gravity tables presentation on the debug log ( #6460 )
2025-11-25 18:59:04 +00:00
yubiuser
e93bcaf7a4
Bump the github-actions-dependencies group with 2 updates ( #6478 )
2025-11-22 21:49:24 +01:00
dependabot[bot]
4b824f931f
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [actions/checkout](https://github.com/actions/checkout ) and [github/codeql-action](https://github.com/github/codeql-action ).
Updates `actions/checkout` from 5.0.0 to 6.0.0
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](08c6903cd8...1af3b93b68 )
Updates `github/codeql-action` from 4.31.3 to 4.31.4
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](014f16e7ab...e12f017898 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-dependencies
- dependency-name: github/codeql-action
dependency-version: 4.31.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-22 10:01:26 +00:00
RD WebDesign
8c6bb3f8da
Use text colums instead of number codes on gravity tables
...
- Domains table ("type" column): replace 0, 1, 2 and 3 with
"exact-allow", "exact-deny", "regex-allow" and "regex-deny"
- All tables: use yes/no for "enabled" columns
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-11-20 16:46:38 -03:00
RD WebDesign
987a59f7e5
Show "Block" and "Allow" instead of 0 and 1
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-11-19 16:35:39 -03:00
yubiuser
de444407a9
Use port from dns.port in piholeDebug.sh ( #6475 )
2025-11-17 21:43:51 +01:00
darkexplosiveqwx
1dc8bfc950
Use port from dns.port in piholeDebug.sh
...
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2025-11-16 16:35:05 +01:00
yubiuser
bbd35045cf
Bump pytest from 8.4.2 to 9.0.1 in /test in the python-dependencies group ( #6474 )
2025-11-15 13:49:28 +01:00
yubiuser
da03d713a6
Bump the github-actions-dependencies group with 2 updates ( #6473 )
2025-11-15 13:41:22 +01:00
dependabot[bot]
17dd5b97f3
Bump pytest in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [pytest](https://github.com/pytest-dev/pytest ).
Updates `pytest` from 8.4.2 to 9.0.1
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.4.2...9.0.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-version: 9.0.1
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-15 10:02:08 +00:00
dependabot[bot]
5f977eb35f
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action ) and [psf/black](https://github.com/psf/black ).
Updates `github/codeql-action` from 4.31.2 to 4.31.3
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](0499de31b9...014f16e7ab )
Updates `psf/black` from 25.9.0 to 25.11.0
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](af0ba72a73...05f0a8ce1f )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: psf/black
dependency-version: 25.11.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-15 10:01:21 +00:00
yubiuser
1110f26329
debug - speed up processing and display of file contents and services ( #6469 )
2025-11-12 22:23:49 +01:00
Rob Gill
03fd486921
use configured value for web repo when updating or repairing
...
Instead of hardcoded web repo location, get the currently configured location.
Imports utils.sh to facilitate this
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-11-11 07:28:21 +10:00
Rob Gill
bf41c3dded
debug - speed up processing and display of file contents and services
...
Use bash-internal globs and parameter expasion in preference to
assignment from output of ls or basename per file/directory.
When displaying file contents, call sed once and preprocesses the entire
file (eg pihole.toml), rather than spawning a new sed process for every
line of the file.
When checking services, call awk once to extract all data for each ip:port
pair, rather than three times.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-11-10 14:33:07 +10:00
yubiuser
3d25d20e86
systemd service - don't use deprecated PermissionsStartOnly ( #6465 )
2025-11-09 10:44:21 +01:00
yubiuser
c9eb377fba
Bump codespell-project/actions-codespell from 2.1 to 2.2 in the github-actions-dependencies group ( #6466 )
2025-11-08 11:42:32 +01:00
dependabot[bot]
83f7b4089a
Bump codespell-project/actions-codespell
...
Bumps the github-actions-dependencies group with 1 update: [codespell-project/actions-codespell](https://github.com/codespell-project/actions-codespell ).
Updates `codespell-project/actions-codespell` from 2.1 to 2.2
- [Release notes](https://github.com/codespell-project/actions-codespell/releases )
- [Commits](406322ec52...8f01853be1 )
---
updated-dependencies:
- dependency-name: codespell-project/actions-codespell
dependency-version: '2.2'
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-08 10:01:11 +00:00
Rob Gill
7452c95080
systemd service - don't use deprecated PermissionsStartOnly
...
- elevate Prestart and Poststop script permissions using "+" prefix instead,
as per https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command%20lines
( PermissionsStartOnly was deprecated in systemd 241 and no longer appears in
documentation since 2018 https://github.com/systemd/systemd/pull/10802 )
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-11-08 15:35:10 +10:00
Christian König
7df117876f
Replace sudo with doas on alpine
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-11-03 22:23:12 +01:00
RD WebDesign
40aa986af1
Add list "type" (block/allow) to the debug log table
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-11-03 17:39:36 -03:00
yubiuser
ff75860de3
Fix libcap capabilities not being granted on OpenRC distros ( #6456 )
2025-11-02 16:43:36 +01:00
Sparronator9999
4ff250edac
Fix libcap capabilities not being granted on OpenRC distros
...
Created on behalf of @mgziminsky - see this issue comment: https://github.com/pi-hole/pi-hole/issues/6454#issuecomment-3476576177
Signed-off-by: Sparronator9999 <86388887+Sparronator9999@users.noreply.github.com >
2025-11-02 07:29:20 +11:00
yubiuser
2e24c2d805
Add Fedora 43 to test suite ( #6453 )
2025-11-01 12:26:46 +01:00
yubiuser
c7ebaece92
Bump github/codeql-action from 4.31.0 to 4.31.2 in the github-actions-dependencies group ( #6455 )
2025-11-01 11:33:37 +01:00
dependabot[bot]
766e61c52a
Bump github/codeql-action in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.31.0 to 4.31.2
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4e94bd11f7...0499de31b9 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-11-01 10:01:18 +00:00
Christian König
558f0c4bf7
Add Fedora 43 to test suite
...
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-10-31 18:54:42 +01:00
Adam Warner
23e48cf544
Sync master back into development ( #6448 )
2025-10-28 17:18:45 +00:00
Adam Warner
1837b754b9
v6.2.2 ( #6447 )
2025-10-28 17:07:28 +00:00
yubiuser
d0fd967734
Bump github/codeql-action from 4.30.9 to 4.31.0 in the github-actions-dependencies group across 1 directory ( #6446 )
2025-10-28 16:08:39 +01:00
dependabot[bot]
4247a6056b
Bump github/codeql-action
...
Bumps the github-actions-dependencies group with 1 update in the / directory: [github/codeql-action](https://github.com/github/codeql-action ).
Updates `github/codeql-action` from 4.30.9 to 4.31.0
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](16140ae1a1...4e94bd11f7 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.31.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-28 13:43:44 +00:00
Adam Warner
dff04eb822
Start using commented tags for editorconfig-checker ( #6443 )
2025-10-28 13:42:25 +00:00
Adam Warner
c5a2078ce7
Add bind9-dnsutils as dependency for APT based systems ( #6444 )
2025-10-28 13:41:55 +00:00
Adam Warner
1d6b3cd894
Add log file path variables and ensure log files are created if missing ( #6441 )
2025-10-28 13:40:00 +00:00
Adam Warner
91727fe284
Create version file, if not existing (on first Container start) ( #6440 )
2025-10-27 20:57:50 +00:00
Christian König
fc4c10dbe2
Add bind9-dnsutils as dependency for APT based systems
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-26 21:06:22 +01:00
yubiuser
0e46b9c83f
Bump tox from 4.31.0 to 4.32.0 in /test in the python-dependencies group ( #6433 )
2025-10-26 20:50:56 +01:00
Christian König
49099d017a
Start using commented tags for editorconfig-checker
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-26 20:30:34 +01:00
Yannick7777
72e3699265
Add log file path variables and ensure log files are created if missing
...
Signed-off-by: Yannick7777 <admin@eyer.life >
2025-10-26 15:19:56 +01:00
casperklein
1818e7e59e
Ensure 'versions' file exist on first start
...
Signed-off-by: casperklein <casperklein@users.noreply.github.com >
2025-10-26 12:05:13 +01:00
Adam Warner
770aa1f061
Sync master back into development ( #6434 )
2025-10-25 11:49:52 +01:00
Adam Warner
66a3c73d6c
Fix formatting in chooseInterface function ( #6435 )
2025-10-25 11:38:21 +01:00
Adam Warner
1ca693866c
Fix formatting in chooseInterface function to ensure proper variable expansion - with quotes, the dialog command throws the error:
...
Expected at least 20 tokens for --radi, have 5.
Use --help to list options.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-10-25 11:31:59 +01:00
Adam Warner
75d4082e57
Pi-hole Core v6.2 ( #6411 )
2025-10-25 11:11:45 +01:00
dependabot[bot]
77dd566a4f
Bump tox from 4.31.0 to 4.32.0 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.31.0 to 4.32.0
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.31.0...4.32.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.32.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-25 10:01:46 +00:00
yubiuser
527895a377
Fix indentation
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-10-24 21:07:12 +02:00
Christian König
11344c39f5
Prevent URLs like file:/./ to circumvent permission check
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-23 22:22:02 +02:00
Christian König
b2e56662c0
Loose requirements for local file access for gravity
...
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-10-23 22:21:36 +02:00
Christian König
12342682b4
Separate log flush from log rotate
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-21 20:47:53 +02:00
Christian König
a734733a87
Disable log flush on docker container
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-21 20:41:18 +02:00
yubiuser
c901aa1a2e
Fix gravity indention ( #6427 )
2025-10-21 19:49:08 +02:00
yubiuser
bfc263ac96
Apply suggestion from @rdwebdesign
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-10-20 09:22:21 +02:00
yubiuser
1f3a1c0676
Bump the github-actions-dependencies group with 2 updates ( #6426 )
2025-10-18 13:25:54 +02:00
Christian König
31cf4ed06d
Fix gravity indention
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-18 13:12:23 +02:00
dependabot[bot]
190b89483c
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action ) and [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker ).
Updates `github/codeql-action` from 4.30.8 to 4.30.9
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](f443b600d9...16140ae1a1 )
Updates `editorconfig-checker/action-editorconfig-checker` from 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 to 5ecdd656fe347c26f76b1b435b90e1d74fb5e787
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases )
- [Commits](1a41284d59...5ecdd656fe )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.30.9
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: github-actions-dependencies
- dependency-name: editorconfig-checker/action-editorconfig-checker
dependency-version: 5ecdd656fe347c26f76b1b435b90e1d74fb5e787
dependency-type: direct:production
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-18 10:01:21 +00:00
yubiuser
d0ce95c385
Tiny change to make prev2 also a local variable ( #6420 )
2025-10-15 05:54:57 +02:00
casperklein
9e8e360591
add missing local variable
...
Signed-off-by: casperklein <casperklein@users.noreply.github.com >
2025-10-15 04:37:19 +02:00
yubiuser
5b53661a79
Bump tox from 4.30.3 to 4.31.0 in /test in the python-dependencies group ( #6418 )
2025-10-11 12:13:53 +02:00
yubiuser
a626e7de48
Bump the github-actions-dependencies group with 2 updates ( #6417 )
2025-10-11 12:12:52 +02:00
dependabot[bot]
71dbf2715a
Bump tox from 4.30.3 to 4.31.0 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.30.3 to 4.31.0
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.30.3...4.31.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.31.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-11 10:01:51 +00:00
dependabot[bot]
08ce6499fc
Bump the github-actions-dependencies group with 2 updates
...
Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action ) and [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker ).
Updates `github/codeql-action` from 3.30.6 to 4.30.8
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](64d10c1313...f443b600d9 )
Updates `editorconfig-checker/action-editorconfig-checker` from f40bac9e7d9e7d298fbe36b83e1eff8f0de13fb8 to 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases )
- [Commits](f40bac9e7d...1a41284d59 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 4.30.8
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-dependencies
- dependency-name: editorconfig-checker/action-editorconfig-checker
dependency-version: 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4
dependency-type: direct:production
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-11 10:01:39 +00:00
Dominik
106b999054
Rename views, upgrade gravity database and bump gravity databae version ( #6386 )
2025-10-05 20:33:30 +02:00
yubiuser
564d917022
Bump the python-dependencies group across 1 directory with 3 updates ( #6407 )
2025-10-04 21:32:30 +02:00
yubiuser
a53dc8fa41
Bump the github-actions-dependencies group across 1 directory with 4 updates ( #6409 )
2025-10-04 21:30:30 +02:00
dependabot[bot]
37fc86410f
Bump the github-actions-dependencies group across 1 directory with 4 updates
...
Bumps the github-actions-dependencies group with 4 updates in the / directory: [github/codeql-action](https://github.com/github/codeql-action ), [actions/stale](https://github.com/actions/stale ), [psf/black](https://github.com/psf/black ) and [actions/setup-python](https://github.com/actions/setup-python ).
Updates `github/codeql-action` from 3.29.10 to 3.30.6
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](96f518a34f...64d10c1313 )
Updates `actions/stale` from 9.1.0 to 10.1.0
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](5bef64f19d...5f858e3efb )
Updates `psf/black` from 25.1.0 to 25.9.0
- [Release notes](https://github.com/psf/black/releases )
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md )
- [Commits](8a737e727a...af0ba72a73 )
Updates `actions/setup-python` from 5.6.0 to 6.0.0
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](a26af69be9...e797f83bcb )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-version: 3.30.6
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
- dependency-name: actions/stale
dependency-version: 10.1.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-dependencies
- dependency-name: psf/black
dependency-version: 25.9.0
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: github-actions-dependencies
- dependency-name: actions/setup-python
dependency-version: 6.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-04 19:26:34 +00:00
yubiuser
e0a9b06b8e
Use SHA to pin github actions ( #6392 )
2025-10-04 21:25:09 +02:00
Christian König
f8d14c398e
Use sha also fpr editor-config-checker without adding a specific tag commit
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-10-04 21:15:12 +02:00
dependabot[bot]
f5ce7b29e0
Bump the python-dependencies group across 1 directory with 3 updates
...
Bumps the python-dependencies group with 3 updates in the /test directory: [pyyaml](https://github.com/yaml/pyyaml ), [pytest](https://github.com/pytest-dev/pytest ) and [tox](https://github.com/tox-dev/tox ).
Updates `pyyaml` from 6.0.2 to 6.0.3
- [Release notes](https://github.com/yaml/pyyaml/releases )
- [Changelog](https://github.com/yaml/pyyaml/blob/6.0.3/CHANGES )
- [Commits](https://github.com/yaml/pyyaml/compare/6.0.2...6.0.3 )
Updates `pytest` from 8.4.1 to 8.4.2
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.4.1...8.4.2 )
Updates `tox` from 4.28.4 to 4.30.2
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.28.4...4.30.2 )
---
updated-dependencies:
- dependency-name: pyyaml
dependency-version: 6.0.3
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: python-dependencies
- dependency-name: pytest
dependency-version: 8.4.2
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: python-dependencies
- dependency-name: tox
dependency-version: 4.30.2
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-10-04 10:02:17 +00:00
Dominik
c0a05297e6
Adjust .shellcheckrc to 0.11 and enable some optional checks ( #6374 )
2025-10-04 09:11:48 +02:00
Dominik
e5112a9fb8
Add Debian 13 Trixie to the test suite ( #6382 )
2025-10-04 09:10:30 +02:00
yubiuser
c31bfb8d82
Fix typo found during install ( #6406 )
2025-09-24 18:06:55 +02:00
Jon Herron
59ccfd6d13
Fix typo found during install
...
Signed-off-by: Jon Herron <jon.herron@yahoo.com >
2025-09-24 08:43:25 -04:00
Adam Warner
950107503d
uninstall refactor and improvement ( #6339 )
2025-08-29 13:30:51 +01:00
Rob Gill
87f307f1d8
Uninstall refactor
...
Split removePiholeFiles into functions for each category.
Reorder execution so that:
Pihole-FTL is stopped and removed before shutdown scripts are removed.
User and group are removed before needed commands are removed.
Remove database and log files in user-specified non-default locations,
and use local directories from basic install.sh, falling back to defaults.
Remove use of sudo as the script already checks that it is called as root.
Advise user of location of crontab backup if is created
Make use of service control functions, command detection and default
directories from basic_install.sh
Align variable names with current basic-install.sh
Disable pihole-FTL service immediately, if systemctl is available
Call systemd daemon-reload after removing service files (on systemd systems)
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-08-29 08:47:00 +10:00
Adam Warner
0a837dd955
Alpine Linux Support and Tests ( #6275 )
2025-08-27 21:13:37 +01:00
Christian König
7140953500
Use SHA to pin github actions
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-27 21:02:18 +02:00
Michael Ziminsky (Z)
f50a4c1c89
Don't use hard-coded path for pihole user nologin shell
...
Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com >
2025-08-16 21:47:57 +00:00
Michael Ziminsky (Z)
3908be911c
Alpine: Switch cron service from busybox to cronie during install
...
Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com >
2025-08-16 21:47:56 +00:00
Michael Ziminsky (Z)
44f95a4f57
Alpine: Ensure community repo is enabled and handle dependency install errors
...
Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com >
2025-08-16 21:47:56 +00:00
Michael Ziminsky (Z)
4bf67a3c79
Alpine: Add some additional dependencies and minor script fixes
...
Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com >
2025-08-16 21:47:55 +00:00
Rob Gill
d75dae788d
Alpine Linux tests
...
Add Dockerfile and corresponding tox file to add alpine linux 3.21 & 3.22 to the test suite
Add apk as another package manager in the automated install tests
Use short switches for su command as busybox's su does not accept long switches here
Add Alpine test to github workflow
Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com >
2025-08-16 21:47:54 +00:00
Michael Ziminsky (Z)
0db48383ae
Add support for alpine
...
Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com >
2025-08-16 21:47:54 +00:00
Dominik
73521bb110
Add FTL bash autocomplete ( #6376 )
2025-08-16 21:02:42 +02:00
yubiuser
36c4193dc5
Bump actions/checkout from 4.2.2 to 5.0.0 in the github-actions-dependencies group ( #6387 )
2025-08-16 12:36:52 +02:00
dependabot[bot]
6e9e961d3c
Bump actions/checkout in the github-actions-dependencies group
...
Bumps the github-actions-dependencies group with 1 update: [actions/checkout](https://github.com/actions/checkout ).
Updates `actions/checkout` from 4.2.2 to 5.0.0
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.2.2...v5.0.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: 5.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-08-16 10:23:35 +00:00
DL6ER
9e258e7005
Rename views, upgrade gravity database and bump gravity databae version
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-08-15 19:39:21 +02:00
Christian König
ea274073b4
Add Debian 13 Trixie to the test suite
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-13 06:27:19 +02:00
Adam Warner
5ed52554d7
Move unattended check to the top of the script - exit early if /etc/pihole/pihole.toml file is not found,
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-08-11 14:55:39 +01:00
Christian König
94bbf5f429
Fix shellcheck warnings
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-07 19:44:26 +02:00
Christian König
4511daf560
Use pihole-FTL --complete to generate autocomplete suggestions
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-06 21:01:37 +02:00
Christian König
5d1ef6279f
Fix shellcheck warnings for pihole bash completion
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-06 13:05:48 +02:00
Christian König
340ffbe5e8
Add pihole-FTL bash completion
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-06 13:05:36 +02:00
Christian König
7baa9c5de0
Adjust .shellcheckrc to 0.11 and enable some optional checks
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-08-04 20:38:27 +02:00
yubiuser
75286a1626
Bump tox from 4.28.3 to 4.28.4 in /test in the python-dependencies group ( #6371 )
2025-08-02 12:56:30 +02:00
dependabot[bot]
9bc17a1f2b
Bump tox from 4.28.3 to 4.28.4 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.28.3 to 4.28.4
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.28.3...4.28.4 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.28.4
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-08-02 10:52:42 +00:00
yubiuser
86850e9020
Add "setpassword" to pihole Bash completion ( #6369 )
2025-07-31 19:06:45 +02:00
deHakkelaar
d4562a1deb
Add "setpassword" to pihole Bash completion
...
Its missing.
After:
```
$ sudo pihole
allow arpflush disable logging reloadlists tail version
allow-regex checkout enable query repair uninstall wildcard
allow-wild debug flush regex setpassword updateGravity
api deny help reloaddns status updatePihole
```
Signed-off-by: deHakkelaar <deHakkelaar@users.noreply.github.com >
2025-07-31 18:03:43 +02:00
Adam Warner
62ccfc77de
Explicitly check for the existence of FTL binary before attempting to stop it. Prevents warning message on fresh installs ( #6364 )
2025-07-28 15:56:42 +01:00
Dominik
0df3b41ca0
Do not call pihole-FTL --config interactively ( #6368 )
2025-07-27 20:25:31 +02:00
DL6ER
5cb601200c
Use non-interactive shell in utils.sh:getFTLConfigValue to avoid colored output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-07-26 21:54:25 +02:00
Adam Warner
342c8b693b
Revert "pihole api - use keepalive for curl queries" ( #6367 )
2025-07-26 19:12:46 +01:00
Adam Warner
24d8754033
Revert "pihole api - use keepalive for curl queries"
2025-07-26 12:35:02 +01:00
yubiuser
966e466c9e
Bump tox from 4.27.0 to 4.28.3 in /test in the python-dependencies group ( #6366 )
2025-07-26 12:43:27 +02:00
dependabot[bot]
37ec67e9a3
Bump tox from 4.27.0 to 4.28.3 in /test in the python-dependencies group
...
Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox ).
Updates `tox` from 4.27.0 to 4.28.3
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.27.0...4.28.3 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.28.3
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: python-dependencies
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-07-26 10:36:36 +00:00
Adam Warner
364ba99b1f
Update automated install/basic-install.sh
...
Co-authored-by: yubiuser <github@yubiuser.dev >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2025-07-26 10:56:21 +01:00
Adam Warner
9252e90bd6
Check for the existence of the FTL binary before stopping the service
...
This prevents errors on fresh installs where the FTL binary does not exist yet.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-07-26 10:31:58 +01:00
Adam Warner
ae0fef4626
pihole api - use keepalive for curl queries ( #6365 )
2025-07-26 10:22:16 +01:00
Rob Gill
5b4a7b8b74
pihole api - use keepalive for curl queries
...
Adds the keepalive header to all curl requests
This reduces session establishment time across the multiple
requests necessary to authenticate, obtain response and log out
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-07-26 18:48:32 +10:00
Dan Schaper
a9680db218
Use 'true'/'false' strings instead of 0/1 integers for boolean root user check in pihole command ( #6351 )
2025-07-23 09:16:15 -07:00
Christian König
7aa57e154e
Group functions
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-23 08:23:09 +02:00
Christian König
05f4ae7719
Invert need_root logic and check if set/unset
...
Signed-off-by: Christian König <github@yubiuser.dev >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2025-07-23 08:09:26 +02:00
Dan Schaper
29b6252935
Fix gravity user permission checking and fix error on pihole-FTL --config failures ( #6352 )
2025-07-22 15:27:07 -07:00
Dan Schaper
f324d4cc7d
Separate network flush and arp table flush functions ( #6319 )
...
This PR updates the function flushing the network tables and the ARP table. It separates the two, renaming the whole function to networkflush and makes flushing ARP optional by appending --arp. Deletion of the network table is now done via FTL's /action/flush/arp endpoint.
Documentation: https://github.com/pi-hole/docs/pull/1253
Related PR in the FTL repo: https://github.com/pi-hole/FTL/pull/2541
2025-07-22 15:20:50 -07:00
yubiuser
310f0711fa
Group evaluations
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-07-22 12:52:43 +02:00
Christian König
9580dc6560
Improve setFTLConfigValue function
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-22 12:50:42 +02:00
Christian König
70e317f373
Revert https://github.com/pi-hole/pi-hole/pull/6345
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-22 12:50:42 +02:00
Christian König
285b3c37f9
Tweak fluash ARP function
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-22 12:45:22 +02:00
Dan Schaper
41f6738e97
Update man page - remove "reconfigure" option ( #6361 )
2025-07-21 13:57:51 -07:00
RD WebDesign
22e6ff2cdf
Update man page - remove "reconfigure" option
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-07-21 16:15:25 -03:00
Dan Schaper
be36432f24
Speed up pihole api ( #6336 )
2025-07-21 10:51:25 -07:00
Christian König
a9e3d3b728
Use --skipFTL flag also for pihole repair and checkout
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-21 12:07:33 +02:00
Christian König
a8db4def9a
Use flag --skipFTL instead of env var PIHOLE_SKIP_FTL_CHECK
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-21 11:54:12 +02:00
Dan Schaper
4bea9a1d12
Use RTMIN value provided by FTL when possible ( #6358 )
...
In some cases `kill -RTMIN` can send incorrect signal value to the FTL causing it to terminate instead of performing lists reload.
https://github.com/pi-hole/FTL/issues/2573
2025-07-20 18:06:00 -07:00
Dan Schaper
35ce3580e5
Reduce pihole --query jq calls ( #6334 )
2025-07-20 18:02:45 -07:00
Dan Schaper
90eb5778ca
Re-order authentication errors in verbose mode ( #6338 )
2025-07-20 17:46:07 -07:00
Dan Schaper
c0539a4fb0
Remove netcat from the list of dependencies ( #6343 )
2025-07-20 17:44:04 -07:00
Jack'lul
da85a7a2a7
Use RTMIN value provided by FTL when possible
...
Signed-off-by: Jack'lul <jacklulcat@gmail.com >
2025-07-18 23:13:19 +02:00
Christian König
95021fce58
Fix permission for *.etag files after gravity run
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-16 21:00:05 +02:00
Christian König
3c52ce98d4
Revert https://github.com/pi-hole/pi-hole/pull/6312
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-16 13:50:37 +02:00
Dan Schaper
ae048201a2
Remove readonly from list.sh to avoid errors ( #6349 )
2025-07-14 21:10:53 -07:00
RD WebDesign
dad27f8d06
Remove readonly from list.sh to avoid errors
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-07-14 21:20:39 -03:00
Dan Schaper
c0b512be60
Sync master back into development ( #6348 )
2025-07-14 14:45:31 -07:00
Adam Warner
cef7fd4b02
Pi-hole core 6.1.4 ( #6347 )
2025-07-14 22:15:50 +01:00
Adam Warner
c09da77e2b
Fix pihole api command by not setting the some variabes as readonly ( #6346 )
2025-07-14 22:09:27 +01:00
Adam Warner
18e8396a44
Fix issue where web interface cannot run gravity ( #6345 )
2025-07-14 22:05:18 +01:00
Adam Warner
1bef0415db
bare minimum first past fix for pihoe api command not working due to attempting to re-set readony variabes PI_HOE_SCRIPT_DIR and utisfie.
...
Can't compain about them being readony if they're.. not.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-07-14 22:02:02 +01:00
Adam Warner
d6a83baf4f
Allow non-root access for updateGravity command
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-07-14 21:38:59 +01:00
Dan Schaper
605ff8183a
Sync master back into development ( #6341 )
2025-07-14 11:45:03 -07:00
darkexplosiveqwx
e231107e81
Remove netcat from the list of dependencies
...
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2025-07-14 20:18:18 +02:00
Dan Schaper
9494dc6061
Pi-hole Core v6.1.3 ( #6337 )
2025-07-14 07:14:43 -07:00
Christian König
71501e15e5
Re-order authentication errors in verbose mode
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-13 22:16:40 +02:00
Rob Gill
0187087da0
Speed up pihole --api
...
Get session authentication information via single jq operation,
setting defaults if no data returned.
Simplify jq test for valid JSON data
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-07-14 05:44:46 +10:00
Dan Schaper
9605ccc178
basic-install.sh listing interfaces ( #6269 )
2025-07-13 11:57:32 -07:00
deHakkelaar
86bdae0076
Update basic-install.sh
...
Added comments
2025-07-13 11:05:58 +02:00
Rob Gill
05ad3d7155
Update advanced/Scripts/query.sh
...
Co-authored-by: yubiuser <github@yubiuser.dev >
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-07-12 22:25:22 +00:00
Rob Gill
ea8272d7d4
speed up pihole --query
...
Count list and gravity matches using jq in a single step.
Use jq's map to simplify list processing, eliminating intermediate
jsons.
Eliminate while loop for each lists's final output and formatting.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-07-12 14:25:17 +10:00
Dan Schaper
1e88ce4975
piholeDebug - Get default route robustly ( #6303 )
2025-07-11 16:19:54 -07:00
Adam Warner
bb60e2e346
Sync master back into development ( #6332 )
2025-07-11 21:02:14 +01:00
Adam Warner
3977a312f0
Update release.yml
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-07-11 21:01:01 +01:00
Dan Schaper
b3d193b34c
Update Firewalld tests to match v6 ports ( #6307 )
2025-07-10 14:15:41 -07:00
Christian König
463086ef23
Skip FTL update check if $PIHOLE_SKIP_FTL_CHECK is set to true
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-10 21:57:38 +02:00
Christian König
f3e04117f6
Let users know we skipped the FTL checks
...
Co-authored-by: davygravy <davygravy@users.noreply.github.com >
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-10 21:56:52 +02:00
Christian König
f67a8e5110
Only set PIHOLE_SKIP_FTL_CHECK if not already set by env variable
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-10 21:56:52 +02:00
Christian König
3f7f6f0294
Allow uses to skip binary check and installing FTL in case the use a self-compiled binary
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-10 21:56:52 +02:00
Dan Schaper
0a36e9d949
update: abort if FTL branch does not exist ( #6329 )
2025-07-10 12:55:12 -07:00
MichaIng
6db6c68a4e
update: abort if FTL branch does not exist
...
Currently, if the FTL update check returns 404, hence the FTL branch does not seem to exist, an error message is printed, but the update continues, only the FTL update is skipped.
This can lead to setups with v5 FTL and v6 core/web, failing at config migration, where FTL is invoked with a v6-only command.
With this change, the update aborts immediately if the FTL branch is invalid, like it does in case of other FTL update check errors (other HTTP error codes than 404 or other curl errors). Hence it continues only if FTL is up-to-date already, or a new version from the given branch has been found.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-07-10 21:37:28 +02:00
Dan Schaper
5b5e02d492
Do not skip root check for pihole user ( #6312 )
2025-07-10 11:48:29 -07:00
Dan Schaper
a2dd0e2f50
Prevent gravity curl from using unset bash variable's empty string. ( #6191 )
2025-07-10 11:29:00 -07:00
Dan Schaper
3d75ea6df2
Only update the package cache on fresh installations ( #6282 )
2025-07-10 11:20:03 -07:00
Dan Schaper
080e1ccf8a
installer: exit if FTL update check fails ( #6316 )
2025-07-10 10:59:05 -07:00
Dan Schaper
24f32d48af
Fix pihole -q by setting PI_HOLE_SCRIPT_DIR in api.sh ( #6284 )
2025-07-10 10:51:20 -07:00
Dan Schaper
8486cfd95a
Update python version used in test to 3.13 ( #6321 )
2025-07-10 10:47:49 -07:00
yubiuser
c81d5019a3
Bump pytest-xdist from 3.7.0 to 3.8.0 in /test ( #6324 )
2025-07-05 23:07:49 +02:00
dependabot[bot]
c5c5116e53
Bump pytest-xdist from 3.7.0 to 3.8.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.7.0...v3.8.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-version: 3.8.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-07-05 10:28:30 +00:00
Christian König
2f9fa80d7a
Update python version used in test to 3.13
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-07-01 13:34:55 +02:00
Dominik
f2280eb330
taillog Prevent grep interpeting search term as an option ( #6318 )
2025-06-29 07:08:21 +02:00
Rob Gill
f24fc9573a
taillog Prevent grep interpeting search term as an option
...
Adds '--' indicating end of options before the user provided
search pattern.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-06-29 06:45:02 +10:00
MichaIng
3a35e589f2
installer: exit if FTL update check fails
...
The return code of `FTLdetect()` is used in the installer to know whether FTL has been installed or not.
The function however returns an error only, if the download of FTL fails, not if checking for a latest version/update of FTL fails. This way, installs and rapairs can continue without or with ourdated FTL until `pihole-FTL migrate v6`, which hangs endlessly, if it is a v5 FTL.
This commit handles the return code in `FTLdetect()`, and lets it return true only if FTL download succeeded, or if the update check succeeded and FTL is up-to-date. Else, it could neither be repaired, nor installed, and the error message should give a hint what went wrong, hence exit.
`FTLdetect()` is not called by any other script, hence this change has no surprising effect elsewhere.
Additionally, a syntax error in the `FTLcheckUpdate()` function itself is fixed, which masks the `check_download_exists()` return code, hence always leads to error code 4, if the FTL branch is not `master`.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-06-26 00:53:49 +02:00
Rob Gill
19d5943440
piholeDebug - Get default route robustly
...
Determine address and interface of default route by preceeding
'via' and 'dev' fields in json output instead of plain text
field position.
Log if unable to determine default gateway
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-06-25 05:10:12 +10:00
Dominik
f90677a1ff
Clean COL_TABLE and allow to send color codes when invoked by FTL (${FORCE_COLOR}) ( #6314 )
2025-06-24 19:24:40 +02:00
Christian König
daec6f8c02
Set color codes when FORCE_COLOR is true
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-24 19:03:24 +02:00
Christian König
a48665c7bb
Remove deprecated and unused colors
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-24 18:51:01 +02:00
Adam Warner
8a97a1433a
Fix dependabot ( #6297 )
2025-06-22 14:28:08 +02:00
Adam Warner
f94d9f2540
Add note about adding local user to pihole group to final dialog ( #6152 )
2025-06-22 14:13:46 +02:00
Christian König
830c4bc049
Do not skipp root check for pihole user
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-21 22:40:43 +02:00
yubiuser
1dbe425146
Bump pytest from 8.4.0 to 8.4.1 in /test ( #6311 )
2025-06-21 14:31:07 +02:00
yubiuser
fc2f7795e9
Bump tox from 4.26.0 to 4.27.0 in /test ( #6310 )
2025-06-21 14:30:38 +02:00
dependabot[bot]
0bc06ed204
Bump pytest from 8.4.0 to 8.4.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.4.0 to 8.4.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.4.0...8.4.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-version: 8.4.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-21 10:10:47 +00:00
dependabot[bot]
700c892dff
Bump tox from 4.26.0 to 4.27.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.26.0 to 4.27.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.26.0...4.27.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.27.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-21 10:10:43 +00:00
RD WebDesign
405053692a
Add HTTPS and NTP services to firewalld test
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-06-17 21:32:49 -03:00
RD WebDesign
04d9d32444
Remove test for port 4711
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-06-17 20:19:13 -03:00
Christian König
c19e907c0c
Fix dependabot
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-09 19:06:15 +02:00
Christian König
7a16024020
Run package update everytime before building the meta package when invoking from the install script
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-08 21:31:56 +02:00
Christian König
5777497f52
Separate package manager detection and cache update functions
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-08 21:25:43 +02:00
Adam Warner
404dc7cb88
Add 'never-stale' to the exempt issue labels of the stale workflow ( #6283 )
2025-06-08 15:06:33 +01:00
Adam Warner
2f3dfef862
Dependabot: group updates ( #6294 )
2025-06-07 18:36:35 +01:00
XhmikosR
b39c9956e8
Dependabot: group updates
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2025-06-07 18:27:46 +03:00
yubiuser
70bcb0bb2b
Bump pytest-xdist from 3.6.1 to 3.7.0 in /test ( #6254 )
2025-06-07 12:32:36 +02:00
dependabot[bot]
2c1032090d
Bump pytest-xdist from 3.6.1 to 3.7.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.6.1 to 3.7.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.6.1...v3.7.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-version: 3.7.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-07 10:07:56 +00:00
yubiuser
b5adc981c2
Bump pytest from 8.3.5 to 8.4.0 in /test ( #6293 )
2025-06-07 12:06:51 +02:00
dependabot[bot]
3933cb0575
Bump pytest from 8.3.5 to 8.4.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.3.5 to 8.4.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.5...8.4.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-version: 8.4.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-06-07 10:01:39 +00:00
Dan Schaper
6964cd124e
Sync master back into development ( #6291 )
2025-06-06 16:22:37 -07:00
DL6ER
082d74eeb1
Install ARMv7 binary even when we detect a 64bit (aarch64) CPU but the operating system is 32bit. See FTL#2494 for reference
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-06-06 06:44:17 +02:00
Christian König
d16c049768
Set PI_HOLE_SCRIPT_DIR in api.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-05 14:45:29 +02:00
Christian König
5ff4f000d5
Add 'never-stale' to the exempt issue labels of the stale workflow
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-05 14:16:27 +02:00
Christian König
93ecfb9504
We test a fresh installaton, so don't pretend this is not a fresh installation
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-05 13:09:03 +02:00
Christian König
ea61755881
Only update the package cache on fresh installations
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-06-05 12:50:10 +02:00
deHakkelaar
6130b800e3
basic-install.sh listing interfaces
...
Following up on below one:
https://github.com/pi-hole/pi-hole/pull/6236
And below poor attempt:
https://github.com/pi-hole/pi-hole/pull/6256
Signed-off-by: deHakkelaar <deHakkelaar@users.noreply.github.com >
2025-06-02 03:59:36 +02:00
Dan Schaper
ec892ec096
Pi-hole Core v6.1.1 ( #6267 )
2025-06-01 18:35:19 -07:00
Dan Schaper
4d4195ed4e
Revert "Use PID1 to determine which command to use when toggeling services" ( #6262 )
2025-06-01 09:45:48 -07:00
Dan Schaper
260fa5ea40
Sync master back into development ( #6253 )
2025-06-01 09:15:10 -07:00
yubiuser
03b3b69617
Make LOGFILE readonly after assignment ( #6261 )
2025-06-01 15:47:11 +02:00
Dan Schaper
8c81335004
Don't revert the package metadata
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2025-05-31 11:39:13 -07:00
Dan Schaper
e1b05028a7
Revert "Use PID1 to determine which command to use when toggeling services"
2025-05-31 09:14:08 -07:00
Dan Schaper
89c4976da4
Make LOGFILE readonly after assignment
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2025-05-31 08:23:24 -07:00
Adam Warner
4fed49c5e5
Pi-hole Core v6.1 ( #6221 )
2025-05-30 22:56:55 +01:00
yubiuser
cad0d0bf1f
Allow to get API URL from local.api.ftl even if DNS port has changed ( #6252 )
2025-05-30 21:57:23 +02:00
Dan Schaper
42aba32ceb
Use PID1 to determine which command to use when toggeling services ( #6245 )
2025-05-30 12:24:09 -07:00
Christian König
6f429d82b4
Allow to get API URL from local.api.ftl even if DNS port has changed
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-30 21:05:08 +02:00
Christian König
fd40fa6f39
Test need adjustment to long arument syntax
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-30 20:52:37 +02:00
yubiuser
d177c4c776
Add useful comment
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-05-30 19:03:12 +02:00
Christian König
888556278e
Add gwak to Fedorea 42 test image as other tests also rely on awk
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-28 20:47:55 +02:00
Christian König
69473a7b54
Add awk to meta package dependencie (is missing on Fedora 42 by default) and order dependencies alphabetically
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-28 19:54:44 +02:00
Christian König
f3166d7a78
Adjust test to mock PID1 to be systemd
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-27 23:52:46 +02:00
Christian König
137338e6a8
Use service wrappers in all scripts
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-27 21:23:56 +02:00
Christian König
b707890f10
Use PID1 to determine which command to use when toggeling services
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-27 20:09:59 +02:00
Dominik
822e677c5c
Use a more general method to determine whether systemd is the init system ( #6043 )
2025-05-27 19:33:57 +02:00
Christian König
1a3a23a867
Give FTL 120 seconds to shutdown
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-26 21:38:26 +02:00
yubiuser
5aadc5f475
Function gravity_CheckDNSResolutionAvailable() should return 0 if DNS resolution is available ( #6240 )
2025-05-21 07:44:04 +02:00
RD WebDesign
6ba6b0f015
Return 1 only if resolution fails
...
Function gravity_CheckDNSResolutionAvailable() should return 0 if DNS resolution is available
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-05-20 19:46:28 -03:00
yubiuser
5f60860a17
Bump tox from 4.25.0 to 4.26.0 in /test ( #6237 )
2025-05-17 13:13:30 +02:00
dependabot[bot]
86d9ac5f8f
Bump tox from 4.25.0 to 4.26.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.25.0 to 4.26.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.25.0...4.26.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-version: 4.26.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-05-17 10:02:13 +00:00
Dan Schaper
a04ed13d0a
Allow simple pihole api output, containing only the JSON payload ( #6096 )
2025-05-16 13:57:04 -07:00
Dan Schaper
04e52daaf3
Update get_available_interfaces() to correctly filter loopback device (lo) ( #6236 )
2025-05-15 08:43:12 -07:00
Piotr Tyrakowski
88934ec818
Update basic-install.sh
...
Signed-off-by: Piotr Tyrakowski <verscup@gmail.com >
2025-05-14 21:47:34 +02:00
Dan Schaper
9aa005ad4c
Revert "fix(get_available_interfaces): only drop the loopback device (‘lo’), don’t filter every “lo” substring" ( #6235 )
2025-05-14 09:53:07 -07:00
Dan Schaper
f6d477f228
Revert "fix(get_available_interfaces): only drop the loopback device (‘lo’), don’t filter every “lo” substring"
2025-05-14 09:51:47 -07:00
Dan Schaper
3c1d8690fa
fix(get_available_interfaces): only drop the loopback device (‘lo’), don’t filter every “lo” substring ( #6224 )
2025-05-14 09:05:21 -07:00
Dan Schaper
3314887e65
Change FTLcheckUpdate to use api.github.com and jq to retrieve tag_name ( #6229 )
2025-05-14 08:32:42 -07:00
Dan Schaper
c1a5b902fb
Use shell parameter expansion to split http_code and payload for api.sh ( #6230 )
2025-05-14 08:31:13 -07:00
Christian König
a590b77431
Link to documentation on how to add local user to pihole group
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-14 09:36:52 +02:00
RD WebDesign
dee44cb3da
Define "silent" as default option and include "verbose" to the man page
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-05-13 14:22:41 -03:00
Dan Schaper
de31858950
Use shell parameter expansion to split http_code and payload
...
Codespell
editorconfig
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2025-05-12 12:26:56 -07:00
Piotr Tyrakowski
13848f2da1
Update automated install/basic-install.sh
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Piotr Tyrakowski <verscup@gmail.com >
2025-05-12 21:13:01 +02:00
RD WebDesign
e01d49b3ee
Change FTLcheckUpdate to use api.github.com and jq to retrieve tag_name
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-05-12 15:53:12 -03:00
RD WebDesign
190798e572
Allow simple pihole api output, containing only the JSON payload
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-05-12 14:23:15 -03:00
Dan Schaper
1bdbc26a07
Give FTL 60 seconds for graceful shutdown ( #6187 )
2025-05-12 10:13:29 -07:00
Christian König
842afc2475
Give FTL 60 seconds for graceful shutdown
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-12 19:02:29 +02:00
Dan Schaper
398405c303
All gravity related files and dirs should be owned by pihole:pihole ( #6186 )
2025-05-12 08:48:27 -07:00
yubiuser
189da82614
&& chown
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-05-12 08:54:58 +02:00
Dan Schaper
99d00e0ed0
Do not try to upgrade gravity if it does not exist ( #6218 )
2025-05-11 08:47:46 -07:00
Dan Schaper
3c6c3d3a15
Fix API logic in api.sh ( #6193 )
2025-05-11 08:43:12 -07:00
Dan Schaper
3c0ff57660
Allow alternative cron daemons on Debian ( #6180 )
2025-05-11 08:12:29 -07:00
Piotr Tyrakowski
9f3e71b0b6
Update basic-install.sh
...
I have updated line 708
to use grep -v "loo"
instead of "lo"
the reason is with "lo" it cannot find "wlo1" interface
Signed-off-by: Piotr Tyrakowski <verscup@gmail.com >
2025-05-09 17:03:57 +02:00
Christian König
d45003a8ca
Do not try to upgrade gravity if it does not exist
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-05 17:27:53 +02:00
yubiuser
7aaaa49cf0
Set dns.interface during installation ( #6216 )
2025-05-05 08:39:23 +02:00
Christian König
fc103af050
Revert response code logic
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-04 21:45:44 +02:00
yubiuser
46fbd931b5
Use CODEOWNERS instead of deprecated dependbot/reviewers ( #6213 )
2025-05-04 20:56:09 +02:00
Christian König
96437dc913
Set dns.interface during installation
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-04 19:39:43 +02:00
yubiuser
cae558d5d4
Extend .gitignore ( #6215 )
2025-05-04 14:32:40 +02:00
darkexplosiveqwx
65fd0b099d
Extend .gitignore
...
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2025-05-04 14:22:02 +02:00
Christian König
95d27ac985
Merge branch 'development' into tweak/gravity_options
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-04 14:17:41 +02:00
yubiuser
744ac6ad88
Add Fedora 42 to tests ( #6177 )
2025-05-04 13:28:03 +02:00
darkexplosiveqwx
b82487ee6a
Add Fedora 42 to tests
...
Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com >
2025-05-04 12:02:15 +02:00
Dan Schaper
0a72e517b6
Remove reference to telnet and chronometer in README ( #6188 )
2025-05-03 13:38:29 -07:00
Dan Schaper
09368a77b4
Remove unused $target from gravity ( #6192 )
2025-05-03 13:37:45 -07:00
Dan Schaper
0e6439c6c0
Remove check for supported OS ( #6206 )
2025-05-03 13:17:56 -07:00
Christian König
0c533ec71b
Use CODEOWNERS instead of deprecated dependbot/reviewers
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-05-03 20:06:24 +02:00
Christian König
5355e9e084
Remove os_check from debug script
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-28 21:10:36 +02:00
Christian König
54c8dd3d77
Remove os_check from tests
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-28 21:06:05 +02:00
Christian König
d9f4ee7aaa
Remove os_check from update script
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-28 21:04:08 +02:00
Christian König
40da3a40ec
Remove os_check from install script
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-28 21:03:08 +02:00
yubiuser
3cbaee7b76
Fix gravity waiting forever for DNS ( #6196 )
2025-04-26 16:48:24 +02:00
yubiuser
3bd6a41795
Improve wording
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Signed-off-by: yubiuser <github@yubiuser.dev >
2025-04-26 15:36:22 +02:00
Christian König
4303a5868f
Only append dot
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-26 15:03:42 +02:00
Christian König
215003899d
(2+1)*40
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-26 15:03:01 +02:00
yubiuser
cf3b7d0d8e
Bump actions/setup-python from 5.5.0 to 5.6.0 ( #6199 )
2025-04-26 12:56:31 +02:00
dependabot[bot]
454f96d0ea
Bump actions/setup-python from 5.5.0 to 5.6.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.5.0...v5.6.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-version: 5.6.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-04-26 10:25:43 +00:00
Christian König
1bea6db50a
Fix API logic in api.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-25 21:16:52 +02:00
Christian König
72a52807d1
Fix gravity waiting forever for DNS
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-25 21:03:09 +02:00
Christian König
d7b6d6aa33
Remove unused $target from gravity
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-22 23:06:01 +02:00
Christian König
7a641f4c35
Use paramteter expansion to prevent adding literal '' if parameter is empty
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-22 22:52:33 +02:00
Rob Gill
ce0bdac1bd
Remove reference to telnet and chronometer in README
...
Replace with curl example and commandline example
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-04-23 06:41:16 +10:00
Christian König
13d76abff7
Set customUpstreamResolver empty
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-22 22:38:07 +02:00
Christian König
76e41aeefa
Add small note about modifiedOptions
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-22 22:03:54 +02:00
Christian König
774037834b
Rename cmd_ext
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-22 22:01:21 +02:00
Christian König
89c4248315
Use quotes for all substitutions
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-22 21:57:47 +02:00
Michael Woolweaver
6fc5bf83f4
don't mute SC2086
...
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid >
2025-04-22 21:56:21 +02:00
Christian König
4a1bcda6f1
All gravity related files and dirs should be owned by pihole:pihole
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-21 09:30:36 +02:00
yubiuser
60485fdc51
Remove duplicated code checking if adlist domain is blocked locally ( #6183 )
2025-04-21 09:17:39 +02:00
yubiuser
6fe77ebeed
Treat FTL return data as strings - part II ( #6184 )
2025-04-21 09:16:58 +02:00
Christian König
8733b429dd
Treat FTL return data as strings - part II
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-20 22:50:55 +02:00
Christian König
1432568d17
Remove duplicated code checking if adlist domain is blocked locally
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-20 20:14:41 +02:00
Ihor Urazov
cff7f40739
Allow alternative cron daemons on Debian
...
Add cron-daemon virtual package as an alternative dependency. This way
pihole-meta by default still depends on cron, but allows installation of
systemd-cron, which completely replaces cron daemon and package. With
systemd-cron functionality of crontab files and /etc/cron.* directories
works expected, as systemd-cron generates systemd timers from cron
files.
Signed-off-by: Ihor Urazov <iurazov@healthjoy.com >
2025-04-19 20:33:19 +03:00
yubiuser
248d25b8d0
Install on IPv6-only/DNS64/NAT64 system ( #6144 )
2025-04-15 17:33:09 +02:00
Dominik
95c1b1a542
Add ON DELETE CASCADE to FOREIGN KEY REFERENCES in gravity.db ( #6113 )
2025-04-15 06:24:52 +02:00
Rob Gill
9e62625f83
Install on IPv6-only/DNS64/NAT64 system
...
Alters the test for IPv4 route so the installer doesn't fail instantly on IPv6-only.
Gives user a dialog to proceed with IPv6 only installation
Switches DNS server options to only contain IPv6 addresses.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2025-04-15 14:13:43 +10:00
Dan Schaper
faeba69090
revert a change to gravity.sh that attempted to fix an SC2086 warning… ( #6162 )
2025-04-09 10:07:10 -07:00
Adam Warner
48272f3393
revert a change to gravity.sh that attempted to fix an SC2086 warning from shellcheck.
...
Fixes #6159
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-09 18:02:40 +01:00
Adam Warner
195e65855d
Fix more shellcheck warnings ( #6155 )
2025-04-08 17:27:07 +01:00
Christian König
0f511ad574
Remove token and use sarif-fmt for nicer CLI output
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-08 17:50:19 +02:00
Adam Warner
323dbbe5d9
Reduce code duplication in piholeLogFlush ( #6148 )
2025-04-08 12:44:30 +01:00
Christian König
bda81cb2f5
Remove debug SARIF upload
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-07 21:25:29 +02:00
Christian König
b271dbf606
Set shellcheck level to warning, can be lowered later
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-07 14:11:39 +02:00
Christian König
5002ce8ba7
Source files relative to the repos root
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-07 14:10:01 +02:00
Christian König
135b0cce14
Switch to Differential ShellCheck
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-07 11:54:35 +02:00
Christian König
23fc53c618
Set -x option for shellcheck GHA
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-07 11:32:14 +02:00
Adam Warner
3732ea7365
Remove shellcheck directives that no longer serve any purpose
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-07 10:24:53 +01:00
Christian König
ca1bab3c1b
Fix more shellcheck warnings
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-07 10:52:57 +02:00
yubiuser
36e6c9921e
Shellcheck Tweaks ( #6147 )
2025-04-07 10:08:25 +02:00
Dan Schaper
6c5bc1de39
versions file should readable by others (make pihole -v work for non-root users) ( #6002 )
2025-04-06 12:58:16 -07:00
Christian König
9f5e18b1cd
Make it 644
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-06 21:13:47 +02:00
Christian König
d28e795266
Permissions on versions file should be 640
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-06 21:12:58 +02:00
Christian König
e579397f51
Allow all users to read the version file
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-06 20:52:57 +02:00
Adam Warner
2088601148
Add .shellcheckrc to configure shellcheck ignore SC1090-1 globally
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 18:46:47 +01:00
Adam Warner
48c59cb6cf
In ./automated install/uninstall.sh line 14:
...
readonly ADMIN_INTERFACE_DIR=$(getFTLConfigValue "webserver.paths.webroot")$(getFTLConfigValue "webserver.paths.webhome")
^-----------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./advanced/Scripts/update.sh line 39:
readonly ADMIN_INTERFACE_DIR=$(getFTLConfigValue "webserver.paths.webroot")$(getFTLConfigValue "webserver.paths.webhome")
^-----------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./advanced/Scripts/updatecheck.sh line 45:
readonly ADMIN_INTERFACE_DIR=$(getFTLConfigValue "webserver.paths.webroot")$(getFTLConfigValue "webserver.paths.webhome")
^-----------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:20:51 +01:00
Adam Warner
f01e8c70d9
Weirldly, GHA missed these minor warnings however have disabled them as they are due to variables either being used in or declared in basic-install,.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
3a9b9c027e
In ./pihole line 20:
...
source "${colfile}"
^----------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ./pihole line 23:
source "${utilsfile}"
^------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ./pihole line 27:
source "${apifile}"
^----------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ./pihole line 34:
source "${versionsfile}"
^---------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ./pihole line 251:
local timer="$(echo "${data}"| jq --raw-output '.timer' )"
^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./pihole line 255:
local str="Pi-hole $(echo "${data}" | jq --raw-output '.blocking')${extra}"
^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./pihole line 378:
local logging_enabled=$(getFTLConfigValue dns.queryLogging)
^-------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./pihole line 385:
readonly LOGFILE=$(getFTLConfigValue files.log.dnsmasq)
^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
f5dc337d1b
In ./advanced/Scripts/piholeLogFlush.sh line 12:
...
source ${colfile}
^--------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
In ./advanced/Scripts/piholeLogFlush.sh line 16:
source "${utilsfile}"
^------------^ SC1090 (warning): ShellCheck can't follow non-constant source. Use a directive to specify location.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
63623c4353
In ./advanced/Scripts/piholeCheckout.sh line 112:
...
corebranches=($(get_available_branches "${PI_HOLE_FILES_DIR}"))
^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting).
In ./advanced/Scripts/piholeCheckout.sh line 139:
webbranches=($(get_available_branches "${webInterfaceDir}"))
^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting).
In ./advanced/Scripts/piholeCheckout.sh line 170:
ftlbranches=( $(git ls-remote https://github.com/pi-hole/ftl | grep "refs/heads" | cut -d'/' -f3- -) )
^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting).
In ./advanced/Scripts/piholeCheckout.sh line 218:
elif [ $? -eq 2 ]; then
^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
59d2177271
In ./advanced/Scripts/database_migration/gravity-db.sh line 18:
...
piholeDir="${2}"
^-------^ SC2034 (warning): piholeDir appears unused. Verify use (or export if used externally).
Turns out it is _actually_ unused, the full path of the gravity database is passed to the function, so we'll tidy this up rather than supressing.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
a624d3be8d
In ./advanced/Scripts/utils.sh line 91:
...
if [[ $? -eq 5 ]]; then
^------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
39f5115135
In ./automated install/basic-install.sh line 1753:
...
local status=$(curl --head --silent "https://ftl.pi-hole.net/${1} " | head -n 1)
^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
In ./automated install/basic-install.sh line 2076:
elif [ $? -eq 2 ]; then
^-- SC2319 (warning): This $? refers to a condition, not a command. Assign to a variable to avoid it being overwritten.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
e018a37a8c
First things first - bump severity of shellcheck action from error to warning
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 14:11:40 +01:00
Adam Warner
6e06a93c31
functionise log rotation and flushing code to avoid dupliation
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-06 13:57:07 +01:00
Adam Warner
7e5d9db6b7
Remove no-longer-needed pihole sudoers file ( #6143 )
2025-04-06 13:52:37 +01:00
Dominik
5afab5e96c
Move list parsing entirely into FTL ( #6105 )
2025-04-05 20:15:16 +02:00
yubiuser
ab8b8da9c3
Bump pytest-testinfra from 10.1.1 to 10.2.2 in /test ( #6151 )
2025-04-05 12:11:16 +02:00
dependabot[bot]
07864032de
Bump pytest-testinfra from 10.1.1 to 10.2.2 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 10.1.1 to 10.2.2.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/10.1.1...10.2.2 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-version: 10.2.2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-04-05 10:05:08 +00:00
Adam Warner
bdcb6fc88c
Update update.sh, updatecheck.sh and uninstall.sh to honour pihole.to… ( #5981 )
2025-04-05 01:18:49 +01:00
Adam Warner
f403468450
Add webserver log to piholeLogFlush.sh ( #6049 )
2025-04-05 00:33:18 +01:00
Adam Warner
097ac8336e
Add recommended fields to the deb package ( #6054 )
2025-04-05 00:31:26 +01:00
Christian König
fe2b22c570
Add recommended fields to the deb package
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-04-05 00:29:13 +01:00
Adam Warner
2477d6b184
Revert #6137 ( #6146 )
2025-04-04 23:28:51 +01:00
Adam Warner
f98b9520e4
v5 sudoers file that allowed www-data to run pihole command is no longer needed. "Fixes" #6066
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-04-04 23:19:14 +01:00
yubiuser
65b42c1c8f
Ensure gravity_Cleanup() checks the correct directory ( #6131 )
2025-04-04 22:50:19 +02:00
Michael Woolweaver
e548ed043f
ensure gravity_Cleanup() checks the correct directory for list data
...
also glob with * to ensure .etag & .sha1 are removed as well
should fix #6075
Co-authored-by: yubiuser <github@yubiuser.dev >
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid >
2025-04-04 15:15:51 -05:00
Adam Warner
4108c817dc
Revert "source with source not dot ( #6137 )"
...
This reverts commit 8fd2ebd3d7 , reversing
changes made to 557bc6f179 .
2025-04-04 19:12:57 +01:00
Dan Schaper
8fd2ebd3d7
source with source not dot ( #6137 )
2025-04-02 12:36:48 -07:00
Michael Woolweaver
4efe4dfd4b
source with source not dot
...
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid >
2025-04-02 14:21:45 -05:00
Adam Warner
557bc6f179
Add CentOS 10 to test suite ( #6126 )
2025-04-02 18:24:36 +01:00
Adam Warner
8fce8f6149
build gravityDBfile_default like the other variables ( #6133 )
2025-04-02 17:12:21 +01:00
Michael Woolweaver
3cb6ea503a
build gravityDBfile_default like the other variables
...
seems this one was forgotten
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid >
2025-04-01 23:57:56 -05:00
Christian König
7886cfc80b
Add CentOS 10 to test suite
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-31 12:13:34 +02:00
Adam Warner
8797a0df05
Sync master back into development ( #6122 )
2025-03-30 18:31:02 +01:00
Adam Warner
0f7803b775
Pi-hole Core v6.0.6 ( #6118 )
2025-03-30 17:54:55 +01:00
James George
0f482396ee
Update update.sh, updatecheck.sh and uninstall.sh to honour pihole.toml settings for webserver.paths.webroot and webserver.paths.webhome
...
When uninstalling, remove web interface parent directory empty check and possible removal.
Signed-off-by: James George <james.george@vigilantvoid.com >
2025-03-30 13:11:21 +08:00
yubiuser
73074f1557
Bump tox from 4.24.2 to 4.25.0 in /test ( #6116 )
2025-03-29 21:46:47 +01:00
yubiuser
bc23303788
Bump actions/setup-python from 5.4.0 to 5.5.0 ( #6117 )
2025-03-29 21:43:58 +01:00
dependabot[bot]
49fbdc4c00
Bump actions/setup-python from 5.4.0 to 5.5.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.4.0...v5.5.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-03-29 10:25:36 +00:00
dependabot[bot]
315528d740
Bump tox from 4.24.2 to 4.25.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.24.2 to 4.25.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.24.2...4.25.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-03-29 10:25:08 +00:00
DL6ER
71ec0a0244
Add ON DELETE CASCADE to FOREIGN KEY REFERENCES in gravity.db
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-03-27 13:10:53 +01:00
Adam Warner
e5cb0efd61
revert #6030 in preparation for docker-pi-hole #1794 ( #6086 )
2025-03-25 17:06:01 +00:00
DL6ER
dec670a6d6
Move list parsing entirely into FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-03-22 09:18:02 +01:00
Michael Woolweaver
3a592471c6
revert pi-hole/pi-hole/pull/6030
...
in preparation for pi-hole/docker-pi-hole/pull/1786
Signed-off-by: Michael Woolweaver <michael@woolweaver.bid >
2025-03-14 14:32:29 -05:00
yubiuser
3f5c00919b
Remove WEB_CALL from COL_TABLE ( #6062 )
2025-03-10 06:14:47 +01:00
yubiuser
349544b24a
Create webserver.log on FTL startup ( #6051 )
2025-03-10 06:14:22 +01:00
yubiuser
387ec3a3c2
Bump pytest from 8.3.4 to 8.3.5 in /test ( #6068 )
2025-03-08 11:50:40 +01:00
dependabot[bot]
6b873b2d7f
Bump pytest from 8.3.4 to 8.3.5 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.3.4 to 8.3.5.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.4...8.3.5 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-03-08 10:46:01 +00:00
yubiuser
46e5b3b02e
Bump tox from 4.24.1 to 4.24.2 in /test ( #6067 )
2025-03-08 11:44:54 +01:00
dependabot[bot]
27aeed76f0
Bump tox from 4.24.1 to 4.24.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.24.1 to 4.24.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.24.1...4.24.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-03-08 10:30:22 +00:00
yubiuser
80d63eca93
Add 2FA handling to api.sh ( #6065 )
2025-03-08 10:46:54 +01:00
yubiuser
72404c983d
Add trailing / when changing ownership of /etc/pihole ( #6057 )
2025-03-07 23:08:04 +01:00
casperklein
9b4502a7a9
Add trailing / to directories
...
Signed-off-by: casperklein <casperklein@users.noreply.github.com >
2025-03-07 23:00:40 +01:00
Christian König
5de9b6ae69
Add 2FA handling to api.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-07 13:43:41 +01:00
Christian König
f3dc202e36
Remove WEB_CALL from COL_TABLE
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-07 10:16:25 +01:00
yubiuser
9050e47049
version.sh: fix typo in comment ( #6056 )
2025-03-06 20:49:20 +01:00
XhmikosR
45cb722e50
version.sh: fix typo in comment
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2025-03-06 21:40:17 +02:00
yubiuser
98b17edfd7
README.md: switch to the SVG logo ( #6052 )
2025-03-06 14:27:58 +01:00
XhmikosR
d094b197e3
README.md: switch to the SVG logo
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2025-03-06 15:06:34 +02:00
Christian König
e437e3a805
Create webserver.log on FTL startup
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-03-06 09:48:06 +01:00
Jack'lul
4df5c0bb96
Add webserver log to piholeLogFlush.sh
...
Signed-off-by: Jack'lul <8418678+jacklul@users.noreply.github.com >
2025-03-05 22:25:33 +01:00
Adam Warner
411b9fcb6d
Sync master back into development ( #6046 )
2025-03-04 19:46:03 +00:00
Adam Warner
9fe687bd62
Pi-hole Core v6.0.5 ( #6042 )
2025-03-04 17:21:05 +00:00
DL6ER
bef8227cbd
Use a more general method to determine whether systemd is the init system
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-03-03 20:16:07 +01:00
Adam Warner
edf336067a
Fix gravity.sh -- Alpine / Docker specific issue ( #6030 )
2025-03-03 17:44:45 +00:00
Adam Warner
196a84721f
Fix find command syntax, remove log dir from search ( #6035 )
2025-03-03 17:40:12 +00:00
Adam Warner
978694f262
Improve update/fresh install detection ( #6034 )
2025-03-03 12:23:29 +00:00
Dominik
7eef780fbc
Revert "Improve gravity on systems with low memory" ( #6039 )
2025-03-03 11:01:45 +01:00
Dominik
df814ece91
Revert "Improve gravity on systems with low memory"
2025-03-03 09:00:17 +01:00
Karol Kania
9c7e02f213
Update gravity.sh
...
remove the left-over commented debug code
Signed-off-by: Karol Kania <44871508+karolkania@users.noreply.github.com >
2025-03-02 12:05:42 +01:00
Jack'lul
0130f7be74
Fix find command syntax, remove log dir from search
...
Signed-off-by: Jack'lul <8418678+jacklul@users.noreply.github.com >
2025-03-01 14:43:36 +01:00
Dan Schaper
f207385269
Removing kernel check based on discussion in Pi-Hole PR pi-hole#5957. ( #6020 )
2025-02-28 20:00:00 -08:00
Adam Warner
ce73691082
Juggle some code around:
...
- Move random password generation block inside final "fresh install" if block, ensure password is ONLY generated on fresh installs.
- Add additional check for fresh install around setting of PIHOLE_DNS1/2, QUERY_LOGGING, and PRIVACY_LEVEL
- Remove dedicated displayFinalMessage function.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-02-28 23:06:52 +00:00
Adam Warner
8874757958
Start by renaming useUpdateVars to fresh_install and flipping the logic, the old name is not relevant any more
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-02-28 21:29:33 +00:00
Adam Warner
821c953216
Remove 'reconfigure' option ( #5887 )
2025-02-28 21:14:18 +00:00
Dominik
53e241f057
Improve gravity on systems with low memory ( #5977 )
2025-02-28 17:02:56 +01:00
Karol Kania
a9650ae287
Update gravity.sh
...
fix the `if statement` that doesn't seem to work for neither of alpine's ash / bash - applying some workaround with the `stat` command
Signed-off-by: Karol Kania <44871508+karolkania@users.noreply.github.com >
2025-02-28 12:52:07 +01:00
Christian König
7282aada25
Don't show a warning before the repair is done
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-28 11:51:09 +01:00
Dominik
c5d66c2162
Do not overwrite TLS cert/key mode ( #5998 )
2025-02-27 19:45:32 +01:00
UltChowsk
869411a514
Fixing whitespaces after removing lines.
...
Signed-off-by: UltChowsk <ult@chowsk.net >
2025-02-27 06:24:13 -05:00
UltChowsk
d1b5f95aa7
Removing kernel check based on discussion in Pi-Hole PR pi-hole#5957.
...
Signed-off-by: UltChowsk <ult@chowsk.net >
2025-02-26 20:37:20 -05:00
MichaIng
ad6a48b219
Add comment about TLS-related file permissions
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-26 20:59:32 +01:00
Christian König
43ee724718
Improve alignment and add link to blog post
...
CodeQL / Analyze (pull_request) Waiting to run
Test Supported Distributions / smoke-tests (pull_request) Waiting to run
Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions
Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-26 13:30:46 +01:00
MichaIng
83a38bb71d
Add comment about file permissions
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-26 12:26:50 +01:00
MichaIng
232d581916
Re-add comment about execute bit on directory
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-26 12:25:51 +01:00
Dan Schaper
002536ae09
Do not hide error messages when dealing with services ( #5983 )
2025-02-25 12:30:39 -08:00
yubiuser
8a788ad755
Update README.md - Fix Text+URL for allowlisting/denylisting ( #5993 )
2025-02-25 20:57:57 +01:00
Christian König
4609f90860
Show an warning dialoge before performing an update
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-25 14:33:30 +01:00
MichaIng
0b380d671d
Follow symlinks with find
...
Incorporating https://github.com/pi-hole/pi-hole/pull/5997
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-24 17:37:01 +01:00
MichaIng
65bcb24d0e
Fix test
...
Do not check whether the pihole user can read /etc/pihole/logrotate. It needs to be readable by root only, which is always true.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-24 17:29:59 +01:00
MichaIng
e70981d80f
Do not overwrite TLS cert/key mode
...
FTL correctly creates the cert and especially private key with 0600 mode. But the prestart scripts changes it to 0660.
After removing the dedicated webserver from Pi-hole setups, the pihole group has no purpose anymore, and files should not be writable to any other user than pihole itself, and the private TLS key not reasable to anyone else either.
Additionally, this commit consolidates the chmod calls, applying 0755 to all directories and 0640 to all files, but the TLS key and cert.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-24 17:29:58 +01:00
yubiuser
9840b42847
Add missing trailing / when setting permissions of /etc/pihole ( #5997 )
2025-02-24 17:24:10 +01:00
Christian König
b59ab5852a
Add missing trailing / when setting permissions of /etc/pihole
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-24 15:59:11 +01:00
Jeroen Habets
a0541dd7fb
Update README.md
...
Fix Text+URL for allowlisting/denylisting. Keep former terms for when people search for them.
Signed-off-by: Jeroen Habets <jeroenhabets@users.noreply.github.com >
2025-02-24 10:45:17 +01:00
Dominik
48c4efd7b0
Improve dig error handlin in api.sh ( #5965 )
2025-02-23 20:15:31 +01:00
MichaIng
729a44f82a
Do not hide error messages when dealing with services
...
If service start/stop/restart/enable/disable fails, it help to debug the issue, if STDERR is not hidden, hence the error message can be seen. systemctl furthermore has the `-q` option to suppress non-error output. It works as well for "is-enabled", but until a certain systemd version still throws an error, if the checked service does not exist at all. Once Debian Bullseye support is dropped by Pi-hole, also STDERR form systemctl is-enabled does not need to be suppressed anymore.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-23 15:48:32 +01:00
Dominik
9c995962a5
If there are no files to change, don't print an error ( #5953 )
2025-02-23 09:04:16 +01:00
DL6ER
5da5d0d4c1
Use temp_store = FILE to avoid memory exhaustion on build the tree for very large databases
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-23 08:50:08 +01:00
Adam Warner
a7e414aca4
Sync master back into development ( #5976 )
2025-02-22 23:17:53 +00:00
Adam Warner
567bb724b1
Pi-hole Core v6.0.4 ( #5975 )
2025-02-22 23:14:13 +00:00
Adam Warner
bc3c78f4fa
Print a more helpful message on pihole checkout in docker containers ( #5963 )
2025-02-22 22:49:51 +00:00
yubiuser
ce18de3d6d
Assure that Lighttpd conf-enabled symlink is removed ( #5974 )
2025-02-22 23:31:47 +01:00
MichaIng
8e706e4a16
Assure that Lighttpd conf-enabled symlink is removed
...
`/etc/lighttpd/conf-enabled` usually contains symlinks to the actual files in `/etc/lighttpd/conf-available`, at least `lighty-enable-mod` does exactly this. If `/etc/lighttpd/conf-available/15-pihole-admin.conf` is removed first, `/etc/lighttpd/conf-enabled/15-pihole-admin.conf` hence points to nowhere, which makes the `-f` check return false. The orphaned symlink is hence not removed, if `lighty-disable-mod` is not available.
This PR changes the order, to remove the symlink first, and to be failsafe also if it is orphaned already, and the actual config afterwards.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-22 23:27:05 +01:00
Adam Warner
667a25574a
Fix dnsmasq v5 to v6 config migration ( #5968 )
2025-02-22 21:33:02 +00:00
MichaIng
8f5296536e
Fix dnsmasq v5 to v6 config migration
...
The dnsmasq config files were removed in `remove_old_dnsmasq_ftl_configs()`, before they were tried to be migrated via `migrate_dnsmasq_configs()`, and hence most settings were lost during v5 to v6 update.
This commit renames and adjussts `remove_old_dnsmasq_ftl_configs()` to move dnsmasq config files into the migration directory instead, to be picked up by `migrate_dnsmasq_configs()` later.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-22 21:43:49 +01:00
Adam Warner
da4048ba5d
Only run migration code if setupVars.conf exists. ( #5969 )
2025-02-22 20:30:46 +00:00
Adam Warner
1764f99333
decide migration based on existence of setupVars rather than pihole.toml
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2025-02-22 15:35:05 +00:00
Christian König
cadee26dba
Improve dig error handlin in api.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-22 13:48:55 +01:00
DL6ER
b64a54bba1
Print a more helpful message on pihole checkout in docker containers
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-22 11:53:16 +01:00
yubiuser
5d5bddc979
Don't set a random password on v5 -> v6 updates ( #5960 )
2025-02-22 11:21:17 +01:00
Christian König
bd3a0f4891
Don't set a random password on v5 -> v6 updates
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-22 07:16:28 +01:00
Christian König
cd269cbca1
If there are no files to change, don't print an error
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-21 22:02:03 +01:00
Adam Warner
8290e414ce
Sync master back into development ( #5944 )
2025-02-20 23:23:31 +00:00
Adam Warner
0e6d9e74d9
Pi-hole Core v6.0.2 ( #5939 )
2025-02-20 23:07:13 +00:00
Adam Warner
f38332409f
Fix empty password detection ( #5935 )
2025-02-20 22:43:52 +00:00
MichaIng
cd4efc3141
Fix empty password detection
...
The CLI skips double quotes in config output, hence the output is completely empty, if no password was applied yet, e.g. on a fresh install. This leads to an unprotected web interface. The check is corrected, to have a random password applied as intended.
Additionally, the logic to show an unchanged or unset password on the completion dialog is inverted to correctly show "unchanged" resp. "NOT SET" if the password has not been changed resp. is empty.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-20 19:12:59 +01:00
Adam Warner
99bd142dd5
Apply chosen upstream DNS on fresh install ( #5938 )
2025-02-20 17:59:37 +00:00
MichaIng
49bb6dc0da
Apply chosen upstream DNS on fresh install
...
While the dialog is shown to choose or enter an upstream DNS for Pi-hole, it is never applied. Hence fresh Pi-hole installs have no upstream DNS and cannot resolve queries.
It is now checked for the two generated variables PIHOLE_DNS_1 and PIHOLE_DNS_2, a TOML array generated and applied via pihole-FTL CLI.
Signed-off-by: MichaIng <micha@dietpi.com >
2025-02-20 18:28:38 +01:00
Dominik
6f82ec5121
Sync master back into development ( #5913 )
2025-02-19 17:30:40 +01:00
Dominik
9de976cbbd
Pi-hole Core 6.0.1 ( #5912 )
2025-02-19 17:17:57 +01:00
yubiuser
0890f67322
Fix i386 fallback download ( #5903 )
2025-02-19 10:12:29 +01:00
DL6ER
f7403e2ee6
Fix binary name in 32 bit x86 fallback case
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-19 08:42:32 +01:00
Dominik
51a9412c4b
Sync master back into development ( #5892 )
2025-02-18 19:22:47 +01:00
Adam Warner
2d81552f9f
Pi-hole core v6.0.0 ( #5842 )
2025-02-18 17:19:41 +00:00
yubiuser
2faad0b60a
Fix database integrity check in debug log ( #5889 )
2025-02-14 07:41:07 +01:00
Christian König
c9e58adc48
DHCP discover timeout was reduced by FTL
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-10 20:41:18 +01:00
Christian König
d1639740d9
Fix database integrity check in debug log
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-10 20:29:05 +01:00
Dominik
abb94cafe4
Amend warning on gravity tree build failure ( #5888 )
2025-02-09 19:07:57 +01:00
DL6ER
1bebeff720
Add further info message that building the tree may have failed because of too little RAM baing available. We have see this a few times, either with way too many domains on devices like a Pi Zero or, e.g., only 256 MB RAM being allocated to VMs
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-09 10:06:24 +01:00
Christian König
dfc2b32248
Use better function name
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-06 21:57:17 +01:00
Christian König
49cf5bb221
Remove 'reconfigure' option
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-06 21:57:05 +01:00
yubiuser
9d53ad7668
installer: use a drop-in to disable systemd-resolved stub listener ( #5885 )
2025-02-06 18:47:49 +01:00
Nick Rosbrook
8fb3ccc147
installer: use a drop-in to disable systemd-resolved stub listener
...
systemd-resolved supports drop-in config snippets, e.g. by placing .conf
files in /etc/systemd/resolved.conf.d. During install, use a drop-in
config to set DNSStubListener=no, instead of modifying the main config.
This is generally better practice, and also prevents conflicts when
distribution packages are upgraded, which may include new versions of
/etc/systemd/resolved.conf.
Signed-off-by: Nick Rosbrook <enr0n@ubuntu.com >
2025-02-04 16:18:04 -05:00
Dominik
9212a4a514
Decide if the content was changed *before* passing over to FTL ( #5872 )
2025-02-04 18:57:01 +01:00
Adam Warner
2ae78e02bd
Add call to os_check in the update script ( #5845 )
2025-02-04 17:35:15 +00:00
yubiuser
330698878a
Remove outdated dns-servers.conf ( #5883 )
2025-02-04 06:19:07 +01:00
Dominik
8e298df1e8
Show only enabled domains/regex in the final gravity message ( #5884 )
2025-02-03 20:37:49 +01:00
Dominik
894a9e157f
Move gravity list cache into dedicated directory ( #5869 )
2025-02-03 20:35:38 +01:00
DL6ER
88cfda7210
Show only enabled domains/regex in the final gravity message
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-03 19:16:24 +01:00
Christian König
0da97e762f
Remove outdated dns-servers.conf
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-03 08:31:33 +01:00
Christian König
94e772378e
Merge branch 'development' into new/listsCacheDir
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-02-03 08:09:37 +01:00
Dominik
7dbf408c26
Gravity: Use ETags ( #5867 )
2025-02-03 06:30:11 +01:00
Dominik
ec805f9543
Fix counting of domains in the gravity summary ( #5881 )
2025-02-02 21:07:52 +01:00
DL6ER
7162be18e2
Remove curl -V temp variable
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-02 20:57:13 +01:00
yubiuser
9cd32bf2b7
Bump actions/setup-python from 5.3.0 to 5.4.0 ( #5878 )
2025-02-02 13:34:16 +01:00
DL6ER
9da1e9ab88
Fix counting of domains at the end of pihole -g. The existing schme used the SQL VIEWs for simplicitly, however, they have the unintended side-effect of - when being queried without a GROUP BY clause - returning entries multiple times if they are assigned to several groups
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-01 19:42:25 +01:00
DL6ER
37718c65e9
Simplify cURL etag feature detection following discussion in #5873
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-02-01 19:36:56 +01:00
dependabot[bot]
aadea31e52
Bump actions/setup-python from 5.3.0 to 5.4.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.3.0...v5.4.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-02-01 10:14:46 +00:00
DL6ER
9faef22061
Decide if the content was changed *before* passing over to FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-31 16:46:12 +01:00
DL6ER
bf899fa57f
Migrate list's files (lists themselves, their SHA1 sum and, later, their ETags) into a dedicated directory /etc/pihole/listsCache in an attempt to clean up /etc/pihole
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-30 06:12:49 +01:00
DL6ER
68b03e114c
Merge branch 'development' into new/etags
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-29 19:24:31 +01:00
Dominik
e682f69a1d
Use a different method to identify if a gravity restore succeeded ( #5868 )
2025-01-29 19:23:40 +01:00
DL6ER
f50c696253
Use temp variable for curl -V output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-29 19:19:01 +01:00
DL6ER
6e0b16ed1a
Rename heisenbergCompensator -> modifiedOptions
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-29 19:17:04 +01:00
DL6ER
4322299c39
Drive-by fixing of errors reported by shellcheck for gravity.sh
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-29 17:53:33 +01:00
DL6ER
cee021c358
Use HTTP ETags in addition to the If-Modified-Since header if supported by curl to avoid downloading from servers not using the latter method (raw.githubcontent.com)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-29 17:53:33 +01:00
DL6ER
c381109dcd
Use a different method to identify if a gravity restore succeeded
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-29 17:52:39 +01:00
Dominik
9a3fcf2a85
Gravity database resilience ( #5818 )
2025-01-27 01:29:37 +01:00
DL6ER
6d4d35e848
Merge branch 'development' into tweak/gravity_backup
2025-01-26 19:53:06 +01:00
DL6ER
69bfb3ff3b
Store timestamp of the backup creation instead of the filename on restoring gravity.db
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-26 19:52:46 +01:00
yubiuser
f7727f98bd
Bump actions/stale from 9.0.0 to 9.1.0 ( #5863 )
2025-01-26 08:44:57 +01:00
yubiuser
05f8bb128c
Bump tox from 4.23.2 to 4.24.1 in /test ( #5864 )
2025-01-26 06:28:22 +01:00
dependabot[bot]
66757de3fb
Bump tox from 4.23.2 to 4.24.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.23.2 to 4.24.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.23.2...4.24.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-01-25 10:34:03 +00:00
dependabot[bot]
08e3257f37
Bump actions/stale from 9.0.0 to 9.1.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 9.0.0 to 9.1.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v9.0.0...v9.1.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-01-25 10:08:17 +00:00
Adam Warner
0f318027fc
Remove unused code from debug log and skip some tests inside containers ( #5854 )
2025-01-16 17:13:41 +00:00
RD WebDesign
254b67bca3
Using more user-friendly messages on git describe failure
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-13 20:11:41 -03:00
RD WebDesign
0ae50eab87
Suppress error message on git describe failure
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-12 20:25:32 -03:00
DL6ER
cc25ee940e
Fix unreachable code
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-12 13:42:51 +01:00
DL6ER
12927f8a3d
Put gravity backup files into dedicated directory for cleaness
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-12 13:41:27 +01:00
yubiuser
efaa0f4287
Bump eps1lon/actions-label-merge-conflict from 3.0.2 to 3.0.3 ( #5856 )
2025-01-11 15:04:52 +01:00
dependabot[bot]
83d464e85f
Bump eps1lon/actions-label-merge-conflict from 3.0.2 to 3.0.3
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v3.0.2...v3.0.3 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-01-11 10:54:32 +00:00
RD WebDesign
27fb2bbe3a
Replace some hardcoded paths with pihole.toml values
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:22 -03:00
RD WebDesign
c78be8a89d
No systemctl or service inside containers
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:22 -03:00
RD WebDesign
0590bbba2d
Skip some checks in docker container
...
These commands always fail in containers with "command not found" (as expected).
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:21 -03:00
RD WebDesign
733dce1c4c
If it's a docker container, consider the OS is supported
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 19:11:15 -03:00
RD WebDesign
bd9cc7cbb7
Clean up unused WEBCALL code
...
Debug Log is no longer available via web interface
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2025-01-09 17:15:12 -03:00
Dominik
4902c70063
Explicitly migrate from v5 to v6 ( #5830 )
2025-01-09 19:39:27 +01:00
Dominik
4be130971e
Update automated install/basic-install.sh
...
Co-authored-by: yubiuser <github@yubiuser.dev >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2025-01-09 18:32:04 +01:00
Dominik
211a881888
Apply suggestions from code review
...
Co-authored-by: yubiuser <github@yubiuser.dev >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2025-01-08 19:28:15 +01:00
DL6ER
4d23187f86
Add missing newline
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-07 17:49:57 +01:00
Christian König
b544b74f7a
Merge branch 'development' into fix/migration
2025-01-06 16:43:18 +01:00
Dominik
6e633e4cfd
Improve lighttpd disabling ( #5849 )
2025-01-02 15:05:00 +01:00
DL6ER
364281354c
Check if service is currently enabled when checking if lighttpd may need to be disabled
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-02 13:43:32 +01:00
yubiuser
4c5285e469
Remove now unused function test_dpkg_lock() ( #5848 )
2025-01-01 18:56:19 +01:00
DL6ER
79087fb252
SHow lighttpd disable dialog only once during v6 migration and when lighttpd is actually installed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2025-01-01 18:55:49 +01:00
DL6ER
fab1ca3a40
Merge branch 'development' into tweak/gravity_backup
2025-01-01 18:46:33 +01:00
Christian König
4fd77f57fa
Remove now unused function test_dpkg_lock()
...
Signed-off-by: Christian König <github@yubiuser.dev >
2025-01-01 12:20:50 +01:00
Adam Warner
bd9cb00574
Perform os_check during update, in case the user has updated to an unsupported OS between Pi-hole updates.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-31 15:31:04 +00:00
Dominik
b0e0bdc436
Disable lighttpd if found ( #5835 )
2024-12-30 17:01:04 +01:00
DL6ER
1835827371
Ensure Yes to keeping lighttpd doesn't trigger set -e during the upgrade
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-30 15:35:41 +01:00
Adam Warner
cb32a7f81c
Merge branch 'master' into development
2024-12-29 14:06:24 +00:00
Adam Warner
2cf046d559
Fix v5 for Fedora 41 ( #5839 )
2024-12-29 13:53:35 +00:00
Adam Warner
a1ccee6694
use rpm -q to check if packages are already installed, this is due to a change in the behaviour of dnf in Fedora 41
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-29 13:32:07 +00:00
Adam Warner
dff0c0105d
remove EOL OS from test suite
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-29 12:43:08 +00:00
Adam Warner
d972ffa53a
while v6 is still not released, update tests in master to NOT use development branch of FTL
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-29 12:35:32 +00:00
Adam Warner
22b6dc7dae
Add test scripts for fed 41 for v5
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-29 12:23:37 +00:00
Dominik
3406915917
Exit early when neither service nor systemctl commands are available ( #5834 )
2024-12-26 07:19:22 +01:00
Dominik
50645c2924
Apply suggestions from code review
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2024-12-24 02:19:37 +01:00
DL6ER
d14273f958
Add comment where setupVars.conf goes when v6 migration is done
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-24 02:17:50 +01:00
DL6ER
47d5a08565
Ask the user if they want to disable lighttpd
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-23 19:12:47 +01:00
DL6ER
e08f65d1c4
Disable lighttpd if found
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-23 09:30:37 +01:00
yubiuser
b964657b62
Speedup api response handling ( #5833 )
2024-12-23 09:14:47 +01:00
DL6ER
a2a22c4e13
Exit early when neither service nor systemctl commands are available
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-23 09:13:34 +01:00
DL6ER
8faa28d8a0
Explicitly log migration process
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-23 08:57:34 +01:00
Dominik
a9948304db
Fix v5 -> v6 update ( #5832 )
2024-12-23 08:54:26 +01:00
Christian König
3011d48b6f
Use tail instead of parameter expansion
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-22 23:44:31 +01:00
Christian König
c777152c04
Only separat data and status when needed
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-22 21:57:47 +01:00
Christian König
92a3c73f80
Fix v5 -> v6 update
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-22 21:46:32 +01:00
DL6ER
4f268ed193
Explicitly migrate from v5 to v6
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-21 07:10:46 +01:00
yubiuser
d80259ee8f
Improve dependency package output ( #5828 )
2024-12-16 17:22:12 +01:00
Christian König
83224e7729
Improve dependency package output
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-16 15:55:34 +01:00
yubiuser
6cca30ca45
Improve v6 user output ( #5829 )
2024-12-16 14:06:33 +01:00
Christian König
b2a5564685
FTL allows non-numieric port notation - we need to strip this
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-16 13:06:25 +01:00
Christian König
7dc542f3c2
Get WEBPORT from pihole.toml
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-16 12:54:39 +01:00
Christian König
3ac426b5d1
Update manpage
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-16 12:42:07 +01:00
Christian König
4d55bc1ae3
pihole -a is gone
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-16 12:08:16 +01:00
Christian König
26ef0be9d6
One check less
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-16 11:56:04 +01:00
yubiuser
d030492664
Fix rare case when apt and rpm package managers are found ( #5827 )
2024-12-15 07:19:53 +01:00
Christian König
cc01c110f1
Also check during installlation of the dependency package
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-14 22:31:02 +01:00
Christian König
fdda40994b
Fix rare case when apt and rpm package managers are found
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-12-14 22:26:05 +01:00
Dominik
4dbf9a0bbb
Install dependencies by creating a meta package on-the-fly ( #5785 )
2024-12-14 08:33:15 +01:00
Adam Warner
eb4b6ecf25
Remove no-longer-needed utils ( #5826 )
2024-12-11 17:36:21 +00:00
Christian König
c380c23592
Merge branch 'development' into packages
2024-12-11 18:34:34 +01:00
yubiuser
a41426474e
move the sourcing of utils.sh outside of installPihole ( #5825 )
2024-12-11 18:32:16 +01:00
Adam Warner
764aa48c14
Remove no-longer-needed utils
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-11 17:22:49 +00:00
Adam Warner
8f1fce8f4b
move the sourcing of utils.sh outside of installPihole
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-12-10 19:01:58 +00:00
Dominik
76a6b42075
Fix ARP flush command ( #5823 )
2024-12-07 13:37:34 +01:00
yubiuser
5c6b286a62
Bump pytest from 8.3.3 to 8.3.4 in /test ( #5824 )
2024-12-07 11:24:06 +01:00
DL6ER
11e00e04b5
Fix ARP flush command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-12-07 11:22:58 +01:00
dependabot[bot]
5ef4a5e8b0
Bump pytest from 8.3.3 to 8.3.4 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.3.3 to 8.3.4.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.3...8.3.4 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-12-07 10:09:54 +00:00
Dan Schaper
03932e8ca7
Remove Ubuntu 23 tests, it is EOL ( #5822 )
2024-11-26 13:31:46 -08:00
DL6ER
579dc07046
Merge branch 'development' into tweak/gravity_backup
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-26 21:08:09 +01:00
DL6ER
b23348916b
Remove Ubuntu 23 tests, it is EOL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-26 21:07:11 +01:00
Dominik
7d727555e2
Fix empty adlists ( #5821 )
2024-11-26 20:09:41 +01:00
DL6ER
1c4a48258f
Only set ownership/permissions once the file was created
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-26 18:16:15 +01:00
DL6ER
d9288b896e
Do not touch list files as this creates them. This causes issues down the line in the Heisenberg compensator
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-26 18:01:52 +01:00
Dominik
553c0f7f07
Fix possible gravity permissions issue ( #5819 )
2024-11-25 17:51:45 +01:00
DL6ER
531490397d
When new domains are added to gravity and users run the first time gravity in the terminal (not via web), the list.123.abc.com file is created as root and stays like that. This causes issues down the line when users later try to run gravity from the web interface where we do not have root capabilities. This commit checks for write permissions and suggests what to do on error. It always ensures ownership and permissions are correct
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-25 12:40:55 +01:00
DL6ER
633c971a44
Store failed gravity restoration status in message table
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-23 09:44:39 +01:00
Dominik
6b423f534c
Remove remaining traces of audit log ( #5817 )
2024-11-17 21:25:22 +01:00
Christian König
4137275f24
Merge branch 'development' into packages
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-11-17 21:13:16 +01:00
Dominik
9a9af719f0
Update gravity.sh
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2024-11-17 17:05:26 +01:00
Dominik
d2cbe1f712
Add Fedora 41 and remove Fedora 39 from tests ( #5813 )
2024-11-16 17:52:18 +01:00
DL6ER
62b63f87e0
Use rpm instead of dnf to check for installed package. dnf changed to returning success even for not-installed packages wit Fedora 41
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 12:46:43 +01:00
DL6ER
fdf44355d2
Keep up to 10 database backups
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 12:08:27 +01:00
DL6ER
a5cb07c76e
Attempt to restore from all possibly available gravity.db backups
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 11:52:31 +01:00
DL6ER
59e9bac794
Only try to obtain sources after possible database restore following a corruption
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 11:49:11 +01:00
DL6ER
b2ad878f4a
Try to restore from gravity backup on database preparation error (if backup is available)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 10:18:00 +01:00
DL6ER
6ff30f7294
Backup a stripped-down version of gravity.db after each pihole -g run
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 10:09:44 +01:00
DL6ER
2dc5bd15cc
Remove remaining traces of audit log
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-11-16 09:45:53 +01:00
RD WebDesign
7341f85c2d
Add Fedora 41 and remove Fedora 39 from tests
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2024-11-12 16:48:52 -03:00
Christian König
9478e35cb7
Create a random temp direcotry to build the packages and remove leftovers
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: yubiuser <ckoenig@posteo.de >
2024-11-06 20:12:09 +01:00
Christian König
cd7e5abe25
Add TRAP to the installer
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-11-06 20:12:09 +01:00
Christian König
c47f8c2cd6
Overhaul uninstall script
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-11-06 20:12:09 +01:00
Christian König
f08c54e166
Create dependency package on RPM distros
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-11-06 20:12:09 +01:00
Christian König
fd5b3be03f
Create meta package on the fly ... Debian
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-11-06 20:11:56 +01:00
yubiuser
112b961762
Fix errors on fresh installations while setting privacy levels and query logging due to absence of pihole.toml ( #5799 )
2024-10-28 18:04:46 +01:00
yubiuser
250fbd217f
Bump tox from 4.23.0 to 4.23.2 in /test ( #5809 )
2024-10-26 14:11:11 +02:00
yubiuser
0421e3784c
Bump actions/setup-python from 5.2.0 to 5.3.0 ( #5808 )
2024-10-26 14:10:27 +02:00
yubiuser
8ec7651075
Bump actions/checkout from 4.2.1 to 4.2.2 ( #5807 )
2024-10-26 14:10:06 +02:00
dependabot[bot]
6d8b4fdfc6
Bump tox from 4.23.0 to 4.23.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.23.0 to 4.23.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.23.0...4.23.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-10-26 10:22:13 +00:00
dependabot[bot]
9abb240105
Bump actions/setup-python from 5.2.0 to 5.3.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.2.0 to 5.3.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.2.0...v5.3.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-10-26 10:07:42 +00:00
dependabot[bot]
8acfa029d9
Bump actions/checkout from 4.2.1 to 4.2.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.2.1...v4.2.2 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-10-26 10:07:38 +00:00
yubiuser
16af216b80
Improved error message for invalid protocol in adlist download ( #5806 )
2024-10-24 21:02:40 +02:00
Sebastián Dinator
5589fa171c
Remove example from error message on invalid protocol
...
Signed-off-by: Sebastián Dinator <sdinator@alumnos.uai.cl >
2024-10-24 14:04:06 -03:00
Sebastian Dinator
0e7706ffa3
Improved error message for invalid protocol in adlist download
...
Signed-off-by: Sebastian Dinator <sdinator@alumnos.uai.cl >
Signed-off-by: Sebastián Dinator <sdinator@alumnos.uai.cl >
2024-10-24 14:04:06 -03:00
yubiuser
1a4870690b
Exit 1 on failure ( #5803 )
2024-10-21 06:15:58 +02:00
Christian König
8bf6480aed
Set exit code explicitly everywhere
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-20 09:36:28 +02:00
Christian König
7ae0b207fc
Exit 1 if update script failed
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-20 09:34:15 +02:00
yubiuser
fa194e0a0c
Do not print FTL update check details on pihole -up ( #5800 )
2024-10-19 14:39:24 +02:00
yubiuser
8fc0f1f26a
Bump tox from 4.21.2 to 4.23.0 in /test ( #5802 )
2024-10-19 12:35:17 +02:00
dependabot[bot]
8c39365db1
Bump tox from 4.21.2 to 4.23.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.21.2 to 4.23.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.21.2...4.23.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-10-19 10:32:25 +00:00
yubiuser
c3a762823d
Fix gavity version 19 ( #5801 )
2024-10-19 07:03:04 +02:00
Christian König
2fd51bd244
Fix gavity version 19
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-18 23:00:31 +02:00
Christian König
1ad135ad69
Do not print FTL update check details on pihole -up
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-18 22:30:22 +02:00
Christian König
6e905a7f80
Use setFTLConfigValue to set privacy level and logging. The function is sourced already at this point from utils.sh
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-18 20:22:13 +02:00
Christian König
3956ca49b6
Don't attempt writing to pihole.toml if file does not exit. FTL needs to be started first
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-18 20:19:02 +02:00
yubiuser
cd8d9ab84e
Use pihole.toml to decide if installer runs on an update ( #5790 )
2024-10-18 16:44:43 +02:00
Adam Warner
38c561ae41
Add color ( #5798 )
2024-10-13 22:11:44 +01:00
Christian König
fa45a4bec8
Add color
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-13 22:16:42 +02:00
yubiuser
1bec0d2c7e
Bump actions/checkout from 4.2.0 to 4.2.1 ( #5797 )
2024-10-12 14:28:32 +02:00
dependabot[bot]
aedb2f0a93
Bump actions/checkout from 4.2.0 to 4.2.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.2.0...v4.2.1 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-10-12 10:02:08 +00:00
yubiuser
8e5ac2dbac
Bump tox from 4.20.0 to 4.21.2 in /test ( #5793 )
2024-10-05 13:57:17 +02:00
dependabot[bot]
d4cf5d95a6
Bump tox from 4.20.0 to 4.21.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.20.0 to 4.21.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.20.0...4.21.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-10-05 10:39:29 +00:00
Adam Warner
5cef02e60d
Remove restartdns: Redux ( #5791 )
2024-10-03 09:07:43 +01:00
Adam Warner
afdf45031f
Missed a couple of references in the previous PR
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-10-02 21:51:56 +01:00
Adam Warner
7dd2eb20a2
Remove the restartdns functionality and promote the reloaddns functions ( #5780 )
2024-10-02 21:27:08 +01:00
Adam Warner
6645136f6b
Align the indentation for the case statement in the bottom part of pihole script
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-10-02 21:21:09 +01:00
Adam Warner
84a659dfac
Update pihole
...
Co-authored-by: yubiuser <github@yubiuser.dev >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2024-10-02 19:41:17 +01:00
Adam Warner
be00f3e723
Rename reloaddns-lists to reloadlists per suggestion
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2024-10-02 19:39:34 +01:00
Christian König
74e52675f1
Use pihole.toml to decide if installer runs on an update
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-10-02 13:50:33 +02:00
yubiuser
74d451a9c7
Show version information after an web only update ( #5788 )
2024-10-01 05:57:34 +02:00
yubiuser
ba058be236
Fix removing old man page ( #5789 )
2024-10-01 05:57:19 +02:00
Christian König
ada7d2bd31
Fix removing old man page
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-30 21:10:33 +02:00
Christian König
bcc3a7e35e
Show version information after an web only update
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-30 21:04:55 +02:00
yubiuser
c0e39087bc
Grouped common dependencies of distros ( #5762 )
2024-09-28 13:37:11 +02:00
yubiuser
c1a8607e54
Bump actions/checkout from 4.1.7 to 4.2.0 ( #5781 )
2024-09-28 12:15:11 +02:00
dependabot[bot]
8c56572d0b
Bump actions/checkout from 4.1.7 to 4.2.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.7...v4.2.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-28 10:12:44 +00:00
Wouter Servaes
e9fdfac569
Added common dependencies to uninstall script for removal
...
Signed-off-by: Wouter Servaes <wouterservaes@protonmail.com >
2024-09-27 19:09:09 +02:00
Wouter Servaes
5f1e4680f7
Grouped common dependencies of distros
...
Signed-off-by: Wouter Servaes <wouterservaes@protonmail.com >
2024-09-27 19:09:09 +02:00
Dominik
65806a905a
Add database optimization and gravity timing ( #5773 )
2024-09-25 03:25:02 -04:00
Adam Warner
cc476a49fe
remove the restartdns functionality and promote the reloaddns functions
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-09-24 14:15:15 +01:00
yubiuser
564957c203
Remove lines containing Adguard JavaScript rules from adlists ( #5754 )
2024-09-23 23:33:14 +02:00
yubiuser
8dbdae40e8
Add fallback option for OS check without hard-coded nameserver ( #5751 )
2024-09-23 22:59:56 +02:00
yubiuser
e3dc06708c
Bump tox from 4.18.1 to 4.20.0 in /test ( #5777 )
2024-09-21 12:22:24 +02:00
dependabot[bot]
885895e994
Bump tox from 4.18.1 to 4.20.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.18.1 to 4.20.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.18.1...4.20.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-21 10:10:37 +00:00
Dominik
0f4ad7734c
Update gravity.sh to use color with -t
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2024-09-18 16:13:35 -04:00
DL6ER
111dfc63ff
Add new option allowing timing the individual parts of gravity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-09-17 20:23:09 +02:00
DL6ER
73301da68f
Optimize the database by running ANALYZE after gravity finished
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-09-17 20:03:07 +02:00
yubiuser
0cf0b2ab76
Bump pytest from 8.3.2 to 8.3.3 in /test ( #5769 )
2024-09-14 12:47:09 +02:00
dependabot[bot]
05707c624d
Bump pytest from 8.3.2 to 8.3.3 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.3.2 to 8.3.3.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.2...8.3.3 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-14 10:36:07 +00:00
yubiuser
65d6f5d890
Bump tox from 4.18.0 to 4.18.1 in /test ( #5770 )
2024-09-14 12:35:25 +02:00
dependabot[bot]
20d20e116c
Bump tox from 4.18.0 to 4.18.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.18.0 to 4.18.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.18.0...4.18.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-14 10:25:32 +00:00
yubiuser
b1acea33a1
Revert "Return early during v6 migration if migration dir exists" ( #5768 )
2024-09-14 07:04:47 +02:00
Christian König
6888897999
Revert "Return early during v6 migration if migration dir exists"
...
This reverts commit 251f3295f3 .
2024-09-13 21:15:25 +02:00
yubiuser
3daaabfebd
Return early during v6 migration if migration dir exists ( #5766 )
2024-09-12 21:44:46 +02:00
Christian König
251f3295f3
Return early during v6 migration if migration dir exists
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-12 21:32:36 +02:00
Adam Warner
23f6c3069a
Sync master back into development ( #5764 )
2024-09-11 23:11:03 +01:00
Adam Warner
7128c18b4c
Make install command copyable ( #5763 )
2024-09-11 23:10:30 +01:00
Jim Bennett
3e8189e9ce
Make install command copyable
...
The instal command was in a header with inline markdown. This means there's no copy button on GitHub. Moving to a markdown block gives the copy button.
Signed-off-by: Jim Bennett <jimbobbennett@mac.com >
2024-09-11 15:00:57 -07:00
yubiuser
62ef2d1777
Add forgetting dash
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: yubiuser <ckoenig@posteo.de >
2024-09-11 18:44:17 +02:00
Christian König
ce5ef79a3a
Reduce code duplications and add check via IPv6 without hard-coded nameserver
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-11 13:43:57 +02:00
yubiuser
092891aeb4
Add /etc/pihole/dnsmasq.conf to debug log (stripped-down version) ( #5740 )
2024-09-09 21:41:30 +02:00
DL6ER
d60ad57cac
Add /etc/pihole/dnsmasq.conf to debug log (stripped-down version)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-09-09 21:37:34 +02:00
Dominik
53220cb5d6
Fix wrong message being displayed while waiting for the DNS ( #5757 )
2024-09-09 19:34:02 +02:00
Jack'lul
129272a695
Fix wrong message being displayed while waiting for DNS
...
Signed-off-by: Jack'lul <jacklulcat@gmail.com >
2024-09-09 19:08:47 +02:00
Christian König
f02162b021
Update comment
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-06 21:22:22 +02:00
yubiuser
0ad2a79624
Apply suggestions from code review
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Signed-off-by: yubiuser <ckoenig@posteo.de >
2024-09-06 21:20:36 +02:00
yubiuser
e291a9f7e0
It's Adguard not ABP
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Signed-off-by: yubiuser <ckoenig@posteo.de >
2024-09-05 13:42:10 +02:00
Christian König
cffb3117d4
Remove lines containing ABP JavaScript rules from adlists
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-04 22:32:03 +02:00
yubiuser
1789b1ce99
Account for renaming of devel branch on web repo ( #5753 )
2024-09-04 22:05:12 +02:00
Christian König
333764a7c1
Account for renaming of devel branch on web repo
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-04 21:59:43 +02:00
yubiuser
915352aefb
Fix risk of popd without a pushd ( #5701 )
2024-09-04 21:46:21 +02:00
yubiuser
c911bf30ab
Tweak/gravity dns ( #5752 )
2024-09-04 21:45:32 +02:00
SkyLined
fc73cee156
Fix risk of popd without a pushd
...
`pushd` was inside if, `popd` was outside; there was a risk of not doing a `pushd` and only doing a `popd`.
Signed-off-by: SkyLined <cojmpjum_github.com@sxd.be >
2024-09-04 20:33:54 +02:00
Dominik
59e25d0283
Wait after restarting FTL before trying to check version ( #5613 )
2024-09-04 20:17:15 +02:00
Christian König
f80efa51aa
Wait until DNS resolution is available
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-03 23:32:41 +02:00
Christian König
ba2d10c65e
DNS check in gravity should not check for FTL as it might not be the host's name server
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-03 23:03:59 +02:00
Christian König
a57d539098
Remove leftover DNS check via dig as it now only doubles what we already have with getent hosts
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-03 23:02:15 +02:00
Christian König
50dcd8d62f
Add fallback option for OS check without hard-coded nameserver
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-03 22:31:13 +02:00
yubiuser
a965afa249
Remove obsolet Debian 10 ( #5707 )
2024-09-02 23:56:07 +02:00
Christian König
cd7226d5e9
Remove obsolet Debian 10
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-02 23:52:14 +02:00
Adam Warner
f2cb6e35ed
Sync master back into development ( #5750 )
2024-09-02 22:28:41 +01:00
Adam Warner
3df0a6a996
remove development-v6 references from dependabot yml ( #5749 )
2024-09-02 22:26:11 +01:00
Adam Warner
76d7863270
remove development-v6 references from dependabot yml
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-09-02 22:22:24 +01:00
yubiuser
e566338a79
Bump actions/setup-python from 5.1.1 to 5.2.0 ( #5742 )
2024-09-02 22:34:06 +02:00
dependabot[bot]
f66707bd3e
Bump actions/setup-python from 5.1.1 to 5.2.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.1.1...v5.2.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-09-02 20:30:11 +00:00
Adam Warner
dcc057cd1f
Development v6 ( #5100 )
2024-09-02 21:04:41 +01:00
yubiuser
f277f5d202
Disable SELINUX on CentOS 9 test dockerfile v5 ( #5744 )
2024-09-02 20:15:40 +02:00
Dominik
80143325e8
Fix pihole status on not-ready states ( #5747 )
2024-09-02 19:18:05 +02:00
DL6ER
bcef4f0c97
pihole status should return (= exit) early on error instead of continuing the script
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-09-02 18:59:42 +02:00
Adam Warner
1d7071fb19
Merge branch 'development' into development-v6
2024-09-02 17:29:59 +01:00
DL6ER
b4444023a2
Wait after restarting FTL before trying to check version
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-09-02 15:54:27 +02:00
Dominik
4209e7dee8
Disable SELINUX on CentOS 9 test dockerfile ( #5743 )
2024-09-02 15:54:15 +02:00
Christian König
632d8af4b0
Disable SELINUX on CentOS 9 test dockerfile
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-01 22:35:23 +02:00
Christian König
5e69078ed1
Disable SELINUX on CentOS 9 test dockerfile
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-09-01 22:30:45 +02:00
yubiuser
bd9915105a
Update existing logrotate files to inlcude webserver.log ( #5738 )
2024-08-28 08:48:44 +02:00
Christian König
a21b4c5203
Update existing logrotate files to inlcude webserver.log
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-08-28 08:46:16 +02:00
Dominik
e3fc5cc8f2
Make the help text of "pihole checkout [what] [branch]" more colorful ( #5734 )
2024-08-28 08:43:11 +02:00
Dominik
c26b043c58
Add pihole api [endpoint] callback suitable for local API requests ( #5736 )
2024-08-28 08:36:39 +02:00
Adam Warner
8b078f67b8
Add missing creation of table antigravity in migration script 16 to 17 ( #5737 )
2024-08-27 16:30:09 +01:00
Adam Warner
cfbf3f61cd
Update advanced/Scripts/database_migration/gravity/16_to_17.sql
...
Co-authored-by: Dominik <DL6ER@users.noreply.github.com >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2024-08-26 21:30:12 +01:00
DL6ER
e8582f7740
Add pihole -h and autocompletion entry
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-08-26 19:44:42 +02:00
DL6ER
9e9c985245
FTL checkout: Check for availability of branches before trying to download from the webserver. Also, fix check_download_exists() possibly killing the script on non-availability of requested branches
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-08-26 06:11:42 +02:00
DL6ER
a302d7b5d7
Make the help text of "pihole checkout [what] [branch]" more colorful
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-08-26 05:22:15 +02:00
Adam Warner
72afa1073d
Add missing creation of table antigravity in migration script 16 to 17
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-08-25 21:47:07 +01:00
DL6ER
b304562c8e
Add session details to API command output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-08-24 10:39:12 +02:00
DL6ER
8e4fc27168
Add pihole api [endpoint] callback suitable for local API requests
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-08-24 10:06:48 +02:00
yubiuser
7206569b1d
Fix setting query logging and privacy level ( #5724 )
2024-08-20 07:18:15 +02:00
Christian König
fc156f521c
Fix setting query logging and privacy level
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-08-19 20:58:34 +02:00
yubiuser
4972cc6fdc
Bump tox from 4.17.1 to 4.18.0 in /test ( #5731 )
2024-08-17 12:41:32 +02:00
dependabot[bot]
f6681f75fb
Bump tox from 4.17.1 to 4.18.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.17.1 to 4.18.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.17.1...4.18.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-17 10:39:02 +00:00
yubiuser
c672b66eb4
Bump tox from 4.17.1 to 4.18.0 in /test ( #5730 )
2024-08-17 12:11:07 +02:00
dependabot[bot]
5024a98a4f
Bump tox from 4.17.1 to 4.18.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.17.1 to 4.18.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.17.1...4.18.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-17 10:06:35 +00:00
yubiuser
9564a6e92d
[fix] [v6] typo in bash-completion allow-regex option ( #5729 )
2024-08-15 06:53:56 +02:00
Allen
27fd80c01e
[fix] [v6] typo in bash-completion allow-regex option
...
also removes a space from double whitespace
Signed-off-by: Allen Dema <64094914+allendema@users.noreply.github.com >
Signed-off-by: Allen <64094914+allendema@users.noreply.github.com >
2024-08-15 02:31:33 +02:00
yubiuser
e89d93a5d3
Merge development > development-v6 ( #5725 )
2024-08-10 15:26:41 +02:00
Christian König
904a1a18b0
Merge branch 'development' into development-v6
2024-08-10 14:27:19 +02:00
yubiuser
a69c2df36e
Bump tox from 4.16.0 to 4.17.1 in /test ( #5723 )
2024-08-10 14:03:51 +02:00
dependabot[bot]
4f52c6afc0
Bump tox from 4.16.0 to 4.17.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.16.0 to 4.17.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.16.0...4.17.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-10 12:01:35 +00:00
yubiuser
bc54b5b2ff
Bump pyyaml from 6.0.1 to 6.0.2 in /test ( #5722 )
2024-08-10 14:00:52 +02:00
dependabot[bot]
c42890ad54
Bump pyyaml from 6.0.1 to 6.0.2 in /test
...
Bumps [pyyaml](https://github.com/yaml/pyyaml ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/yaml/pyyaml/releases )
- [Changelog](https://github.com/yaml/pyyaml/blob/main/CHANGES )
- [Commits](https://github.com/yaml/pyyaml/compare/6.0.1...6.0.2 )
---
updated-dependencies:
- dependency-name: pyyaml
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-10 10:56:14 +00:00
yubiuser
6bdb3cb87c
Bump pyyaml from 6.0.1 to 6.0.2 in /test ( #5721 )
2024-08-10 12:38:14 +02:00
yubiuser
9186e81a93
Bump tox from 4.16.0 to 4.17.1 in /test ( #5720 )
2024-08-10 12:37:47 +02:00
dependabot[bot]
21a9410242
Bump pyyaml from 6.0.1 to 6.0.2 in /test
...
Bumps [pyyaml](https://github.com/yaml/pyyaml ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/yaml/pyyaml/releases )
- [Changelog](https://github.com/yaml/pyyaml/blob/main/CHANGES )
- [Commits](https://github.com/yaml/pyyaml/compare/6.0.1...6.0.2 )
---
updated-dependencies:
- dependency-name: pyyaml
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-10 10:19:42 +00:00
dependabot[bot]
58a41641ab
Bump tox from 4.16.0 to 4.17.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.16.0 to 4.17.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.16.0...4.17.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-08-10 10:19:39 +00:00
yubiuser
a16e053b2a
Remove obsolet files and log file symlink code ( #5711 )
2024-07-29 09:36:24 +02:00
Christian König
1ed5994fa5
Remove temporal log file symlink code. It was introduced 2 years ago with v5.11 and always thought to be temporarily only
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-07-29 09:25:12 +02:00
Christian König
db1431a1ae
Remove obsolet files
...
Signed-off-by: Christian König <github@yubiuser.dev >
2024-07-29 09:25:12 +02:00
yubiuser
67de7be802
Remove obsolet getFTLPIDFile() ( #5710 )
2024-07-29 09:23:34 +02:00
Christian König
2c32d485bd
Remove obsolet getFTLPIDFile()
...
We can get the path of the PID file via getFTLConfigValue files.pid
Signed-off-by: Christian König <github@yubiuser.dev >
2024-07-27 22:00:52 +02:00
yubiuser
15d7fab2cb
Bump pytest from 8.2.2 to 8.3.2 in /test ( #5709 )
2024-07-27 13:45:00 +02:00
yubiuser
3ca6ca53a4
Bump pytest from 8.2.2 to 8.3.2 in /test ( #5708 )
2024-07-27 13:42:27 +02:00
dependabot[bot]
0980f9acf6
Bump pytest from 8.2.2 to 8.3.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.2.2 to 8.3.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.2.2...8.3.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-27 10:38:22 +00:00
dependabot[bot]
3cc1945942
Bump pytest from 8.2.2 to 8.3.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.2.2 to 8.3.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.2.2...8.3.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-27 10:08:11 +00:00
Dominik
7b980ed9ac
Finish core v6 implementation ( #5689 )
2024-07-23 18:04:41 +02:00
DL6ER
0614c3c7a0
Merge branch 'development-v6' into new/cli_pw
2024-07-16 11:01:03 +02:00
DL6ER
897e23089c
Implement pihole enable/disable using the API
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-07-16 10:56:37 +02:00
DL6ER
7ca4b59b34
Do not test API availability outside of LoginAPI
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-07-16 10:27:07 +02:00
yubiuser
7d82b0294b
Bump actions/setup-python from 5.1.0 to 5.1.1 ( #5706 )
2024-07-13 12:32:40 +02:00
yubiuser
b22731c613
Bump actions/setup-python from 5.1.0 to 5.1.1 ( #5705 )
2024-07-13 12:32:08 +02:00
dependabot[bot]
e90df12053
Bump actions/setup-python from 5.1.0 to 5.1.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-13 10:15:25 +00:00
dependabot[bot]
bdbec058e9
Bump actions/setup-python from 5.1.0 to 5.1.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-13 10:14:54 +00:00
yubiuser
bffffa4d1e
Fix minor spelling mistake ( #5704 )
2024-07-10 10:36:09 +02:00
Ikko Eltociear Ashimine
5cb740ef01
chore: update basic-install.sh
...
minor fix
Signed-off-by: Ikko Eltociear Ashimine <eltociear@gmail.com >
2024-07-10 14:29:40 +09:00
DL6ER
12fbf86f66
Merge branch 'development-v6' into new/cli_pw
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-07-08 19:18:21 +02:00
yubiuser
8b324741e0
Add protocol validation when downloading blocklist from URL ( #5698 )
2024-07-07 07:37:29 +02:00
DL6ER
6ffb20f09e
Add protocol validation when downloading blocklist from URL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-07-07 07:35:00 +02:00
yubiuser
5c670c21f2
Bump tox from 4.15.1 to 4.16.0 in /test ( #5697 )
2024-07-06 22:12:01 +02:00
dependabot[bot]
e8802173f5
Bump tox from 4.15.1 to 4.16.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.15.1 to 4.16.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.15.1...4.16.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-06 20:09:24 +00:00
Adam Warner
325c9fc0a2
Add pytest-clarity to test environment to improve error log output ( #5692 )
2024-07-06 21:08:41 +01:00
yubiuser
9c6d4ffa9b
Bump tox from 4.15.1 to 4.16.0 in /test ( #5696 )
2024-07-06 12:29:47 +02:00
dependabot[bot]
2b33a0494b
Bump tox from 4.15.1 to 4.16.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.15.1 to 4.16.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.15.1...4.16.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-06 10:12:06 +00:00
Adam Warner
19deafedae
Sync master back into development ( #5695 )
2024-07-05 19:18:26 +01:00
Adam Warner
be5a8dc51a
Pi-hole core v5.18.3 ( #5694 )
2024-07-05 19:12:15 +01:00
Adam Warner
4148f2cb5b
tabs->spaces for editorconfig (Not sure how this has nto been caught before...)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-07-05 19:03:40 +01:00
DL6ER
2c497a9a3e
Add protocol validation when downloading blocklist from URL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-07-05 18:35:19 +01:00
Christian König
fafd47ba75
Please editorconfig-checker
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-07-02 20:57:28 +02:00
Christian König
ddc289ca3e
Fix Dockerfile syntax ENV legacy warning
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-07-02 20:45:34 +02:00
Christian König
6b1d0e09d1
Set column width to 120
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-07-02 20:39:22 +02:00
Christian König
aa704a2e0e
Add pytest-clarity to test environment to improve error log output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-07-01 21:07:09 +02:00
DL6ER
21fb5dabe1
Use "remove" and "delete" instead of "not" to trigger listed domain removals
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-29 09:32:13 +02:00
DL6ER
c2ed30480d
Show when requested domains were not found on the list
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-25 14:10:35 +02:00
DL6ER
ccdbfd4130
Use natural langauge for list manipulations, like pihole allow example.com or pihole deny other.net. Also remove using pihole deny not bad.org
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-25 13:56:49 +02:00
dependabot[bot]
548e142406
Bump pytest from 8.2.1 to 8.2.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.2.1...8.2.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-22 22:54:49 +01:00
dependabot[bot]
bfc2cf69e5
Bump tox from 4.15.0 to 4.15.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.15.0 to 4.15.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.15.0...4.15.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-22 22:54:41 +01:00
DL6ER
fe8e63853c
Use concatenate of arguments instead of using the array directly
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-22 20:49:44 +02:00
DL6ER
b835fa06a6
Further black -> deny renaming
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-22 20:48:07 +02:00
DL6ER
424e825bd9
Do not auto-sudo in the pihole command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-22 20:42:22 +02:00
DL6ER
7e91b9ab47
Update help text
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-22 20:35:06 +02:00
Adam Warner
97324ae97e
remove centos8 tests from development to prevent build fails (yes, I know it's likely that we will merge development-v6 -> development" soon" but.. just in case)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-06-22 16:59:59 +01:00
DL6ER
5dfcd02c40
Improve pihole -f
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-22 10:31:03 +02:00
DL6ER
25f384a923
Do not use CLI password when no password is set at all
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-20 19:41:47 +02:00
DL6ER
bfc18f8329
Rewrite list functions to use the API
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 23:04:39 +02:00
DL6ER
92b15cf744
Modify pihole arpflush to stop FTL while performing the action and use the new TOML config values
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 22:49:11 +02:00
DL6ER
8f24e8aa5f
Modify pihole -t to use TOML config items
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 22:41:42 +02:00
DL6ER
5cb9f4faaa
Modify pihole -f to use TOML config items
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 22:28:14 +02:00
DL6ER
4df7cee6c2
Add partial matching hint if exact matching found nothing
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 22:21:43 +02:00
DL6ER
a2951cd3b8
Hide successful login/logout messages to avoid cluttering the terminal
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 22:19:54 +02:00
DL6ER
520641fa5e
Try to use the CLI password for logins (if enabled and readable by the current user)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-19 22:18:11 +02:00
yubiuser
ca9eaf9688
Bump actions/checkout from 4.1.6 to 4.1.7 ( #5687 )
2024-06-15 14:20:04 +02:00
yubiuser
1e6fe9c3f2
Bump actions/checkout from 4.1.6 to 4.1.7 ( #5686 )
2024-06-15 14:16:16 +02:00
dependabot[bot]
5d2cb552d3
Bump actions/checkout from 4.1.6 to 4.1.7
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...v4.1.7 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-15 10:25:08 +00:00
dependabot[bot]
fdd5b5ced0
Bump actions/checkout from 4.1.6 to 4.1.7
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.6 to 4.1.7.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.6...v4.1.7 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-15 10:14:34 +00:00
yubiuser
81e628a943
Remove CentOS8 from test suite ( #5682 )
2024-06-08 19:28:07 +02:00
yubiuser
4a1dd7f79e
Bump pytest from 8.2.1 to 8.2.2 in /test ( #5679 )
2024-06-08 14:34:09 +02:00
Christian König
cfc0d07173
Remove CentOS8 from test suite
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-06-08 12:57:45 +02:00
dependabot[bot]
0742c017a8
Bump pytest from 8.2.1 to 8.2.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.2.1...8.2.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-08 10:57:29 +00:00
yubiuser
c1d6bcbcc2
Bump tox from 4.15.0 to 4.15.1 in /test ( #5678 )
2024-06-08 12:56:45 +02:00
dependabot[bot]
2fdb6559dc
Bump tox from 4.15.0 to 4.15.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.15.0 to 4.15.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.15.0...4.15.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-08 10:15:56 +00:00
Dominik
dc5a7c4f16
Add CAP_SYS_TIME to FTL's ambient capabilities ( #5676 )
2024-06-08 11:00:31 +02:00
DL6ER
e232361b2d
Add CAP_SYS_TIME to FTL's ambient capabilities
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-06-07 19:02:43 +02:00
yubiuser
3cf538e307
Bump pytest-testinfra from 10.1.0 to 10.1.1 in /test ( #5672 )
2024-06-01 13:02:37 +02:00
yubiuser
159be01e0e
Bump pytest-testinfra from 10.1.0 to 10.1.1 in /test ( #5671 )
2024-06-01 13:01:08 +02:00
yubiuser
f6a3b0247d
Bump eps1lon/actions-label-merge-conflict from 3.0.1 to 3.0.2 ( #5670 )
2024-06-01 13:00:33 +02:00
dependabot[bot]
36f05cb20f
Bump pytest-testinfra from 10.1.0 to 10.1.1 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 10.1.0 to 10.1.1.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/10.1.0...10.1.1 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-01 10:29:56 +00:00
dependabot[bot]
628e1bbe41
Bump pytest-testinfra from 10.1.0 to 10.1.1 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 10.1.0 to 10.1.1.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/10.1.0...10.1.1 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-01 10:22:49 +00:00
dependabot[bot]
4add164d43
Bump eps1lon/actions-label-merge-conflict from 3.0.1 to 3.0.2
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v3.0.1...v3.0.2 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-01 10:20:46 +00:00
yubiuser
78bd872b41
Bump eps1lon/actions-label-merge-conflict from 3.0.1 to 3.0.2 ( #5669 )
2024-06-01 12:15:39 +02:00
dependabot[bot]
70376c24bd
Bump eps1lon/actions-label-merge-conflict from 3.0.1 to 3.0.2
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v3.0.1...v3.0.2 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-01 10:01:49 +00:00
Jack'lul
7b19b650d4
Fix version check for release Docker images
...
Signed-off-by: Jack'lul <jacklulcat@gmail.com >
2024-05-27 23:04:53 +01:00
yubiuser
741b9e1b3e
Bump pytest from 8.2.0 to 8.2.1 in /test ( #5665 )
2024-05-25 21:54:01 +02:00
yubiuser
8a924867c9
Bump pytest from 8.2.0 to 8.2.1 in /test ( #5666 )
2024-05-25 21:50:24 +02:00
Christian König
d15beff4ba
Fix codespell
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-05-25 21:49:24 +02:00
dependabot[bot]
d30a7612ab
Bump pytest from 8.2.0 to 8.2.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.2.0 to 8.2.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.2.0...8.2.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-25 11:02:34 +00:00
dependabot[bot]
01e0c60959
Bump pytest from 8.2.0 to 8.2.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.2.0 to 8.2.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.2.0...8.2.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-25 10:38:28 +00:00
yubiuser
250a44ca9d
Bump actions/checkout from 4.1.5 to 4.1.6 ( #5662 )
2024-05-22 21:34:44 +02:00
yubiuser
dd64cf7872
Bump actions/checkout from 4.1.5 to 4.1.6 ( #5661 )
2024-05-22 21:29:54 +02:00
dependabot[bot]
5270336679
Bump actions/checkout from 4.1.5 to 4.1.6
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.5 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.5...v4.1.6 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-18 10:56:18 +00:00
dependabot[bot]
443c5e8243
Bump actions/checkout from 4.1.5 to 4.1.6
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.5 to 4.1.6.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.5...v4.1.6 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-18 10:31:36 +00:00
Dominik
dd2c1c69dd
Migrate dnsmasq config files ( #5479 )
2024-05-12 18:53:07 +02:00
DL6ER
7bf97cf02a
Merge branch 'development-v6' into new/migrate_dnsmasq_conf
2024-05-12 09:51:55 +02:00
Dominik
3abd2c04ce
Also check for IPv6 address for configured DNS servers ( #5560 )
2024-05-12 09:33:08 +02:00
yubiuser
99e72f61d8
Bump actions/checkout from 4.1.4 to 4.1.5 ( #5656 )
2024-05-11 22:40:58 +02:00
dependabot[bot]
f478913dee
Bump actions/checkout from 4.1.4 to 4.1.5
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.4...v4.1.5 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-11 20:36:33 +00:00
yubiuser
1812d9c358
Bump eps1lon/actions-label-merge-conflict from 3.0.0 to 3.0.1 ( #5655 )
2024-05-11 22:35:46 +02:00
dependabot[bot]
7426076297
Bump eps1lon/actions-label-merge-conflict from 3.0.0 to 3.0.1
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v3.0.0...v3.0.1 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-11 20:32:20 +00:00
Christian König
c0cc9bac35
Add Ubuntu 24.04 and Fedora 40, remove Fedora 38
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-05-11 21:21:18 +01:00
yubiuser
8886232faa
Bump actions/checkout from 4.1.4 to 4.1.5 ( #5654 )
2024-05-11 17:53:22 +02:00
yubiuser
8141fdd003
Bump eps1lon/actions-label-merge-conflict from 3.0.0 to 3.0.1 ( #5653 )
2024-05-11 17:47:48 +02:00
dependabot[bot]
3ad90c1006
Bump actions/checkout from 4.1.4 to 4.1.5
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.4 to 4.1.5.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.4...v4.1.5 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-11 15:47:44 +00:00
dependabot[bot]
f4c9278b86
Bump eps1lon/actions-label-merge-conflict from 3.0.0 to 3.0.1
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v3.0.0...v3.0.1 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-11 15:45:15 +00:00
Christian König
cd30772c43
Add Ubuntu 24.04 and Fedora 40, remove Fedora 38
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-05-11 15:57:21 +01:00
Adam Warner
200a82acfb
Merge development into development-v6
2024-05-08 21:25:26 +01:00
yubiuser
2371f43609
Bump pytest from 8.1.2 to 8.2.0 in /test ( #5648 )
2024-05-04 13:11:13 +02:00
yubiuser
6ce747c935
Bump pytest-xdist from 3.5.0 to 3.6.1 in /test ( #5646 )
2024-05-04 12:57:33 +02:00
dependabot[bot]
9f7cd050e9
Bump pytest from 8.1.2 to 8.2.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.1.2 to 8.2.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.1.2...8.2.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-04 10:56:23 +00:00
yubiuser
976dc1c32d
Bump pytest-xdist from 3.5.0 to 3.6.1 in /test ( #5647 )
2024-05-04 12:55:40 +02:00
dependabot[bot]
24ade13c02
Bump pytest-xdist from 3.5.0 to 3.6.1 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.5.0 to 3.6.1.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.5.0...v3.6.1 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-04 10:52:00 +00:00
yubiuser
7ec20d867b
Bump pytest from 8.1.2 to 8.2.0 in /test ( #5645 )
2024-05-04 12:51:15 +02:00
dependabot[bot]
29d4ed1134
Bump pytest-xdist from 3.5.0 to 3.6.1 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.5.0 to 3.6.1.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.5.0...v3.6.1 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-04 10:15:49 +00:00
dependabot[bot]
bf0c3c0e0f
Bump pytest from 8.1.2 to 8.2.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.1.2 to 8.2.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.1.2...8.2.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-05-04 10:04:20 +00:00
yubiuser
cb30943c2d
Bump tox from 4.14.2 to 4.15.0 in /test ( #5642 )
2024-04-27 13:34:41 +02:00
yubiuser
c19bfb912f
Bump pytest from 8.1.1 to 8.1.2 in /test ( #5641 )
2024-04-27 13:34:01 +02:00
yubiuser
e6c15c3d9f
Bump actions/checkout from 4.1.3 to 4.1.4 ( #5640 )
2024-04-27 13:33:28 +02:00
yubiuser
448b1f4d6c
Bump pytest from 8.1.1 to 8.1.2 in /test ( #5639 )
2024-04-27 13:03:40 +02:00
dependabot[bot]
78c755b538
Bump pytest from 8.1.1 to 8.1.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.1.1 to 8.1.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.1.1...8.1.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-27 11:03:12 +00:00
yubiuser
4474268ae8
Bump tox from 4.14.2 to 4.15.0 in /test ( #5638 )
2024-04-27 13:02:33 +02:00
yubiuser
2955737782
Bump actions/checkout from 4.1.3 to 4.1.4 ( #5637 )
2024-04-27 12:55:34 +02:00
dependabot[bot]
b33bbd7e28
Bump tox from 4.14.2 to 4.15.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.14.2 to 4.15.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.14.2...4.15.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-27 10:53:28 +00:00
dependabot[bot]
b5a7567f3b
Bump pytest from 8.1.1 to 8.1.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.1.1 to 8.1.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.1.1...8.1.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-27 10:53:24 +00:00
dependabot[bot]
3cebb3f060
Bump actions/checkout from 4.1.3 to 4.1.4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.3 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.3...v4.1.4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-27 10:46:03 +00:00
dependabot[bot]
09ce000340
Bump tox from 4.14.2 to 4.15.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.14.2 to 4.15.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.14.2...4.15.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-27 10:28:36 +00:00
dependabot[bot]
91d95e2c8a
Bump actions/checkout from 4.1.3 to 4.1.4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.3 to 4.1.4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.3...v4.1.4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-27 10:21:11 +00:00
dependabot[bot]
091a6891eb
Bump actions/setup-python from 5.0.0 to 5.1.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-21 20:18:50 +01:00
dependabot[bot]
5d77c2b362
Bump actions/checkout from 4.1.2 to 4.1.3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.2...v4.1.3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-21 17:23:44 +01:00
dependabot[bot]
44703bbbc6
Bump actions/checkout from 4.1.2 to 4.1.3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.2...v4.1.3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-21 17:23:40 +01:00
Adam Warner
26132faf46
Bump eps1lon/actions-label-merge-conflict from 2.1.0 to 3.0.0 ( #5626 )
2024-04-01 14:23:05 +01:00
Adam Warner
32ab5aa50b
Bump eps1lon/actions-label-merge-conflict from 2.1.0 to 3.0.0 ( #5625 )
2024-04-01 14:22:47 +01:00
Adam Warner
5391513fe7
Bump actions/setup-python from 5.0.0 to 5.1.0 ( #5624 )
2024-04-01 14:22:24 +01:00
Adam Warner
b32f778654
Bump tox from 4.14.1 to 4.14.2 in /test ( #5611 )
2024-04-01 14:17:30 +01:00
dependabot[bot]
f01362caf1
Bump actions/setup-python from 5.0.0 to 5.1.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 5.0.0 to 5.1.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v5.0.0...v5.1.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-01 13:17:20 +00:00
Adam Warner
c69e0eb254
Bump pytest from 8.0.2 to 8.1.1 in /test ( #5607 )
2024-04-01 14:17:03 +01:00
Adam Warner
48a4693a5a
Bump actions/checkout from 4.1.1 to 4.1.2 ( #5606 )
2024-04-01 14:16:43 +01:00
Adam Warner
db07cc9070
Bump pytest from 8.0.2 to 8.1.1 in /test ( #5605 )
2024-04-01 13:13:38 +01:00
Adam Warner
9f5d4f0eb0
Sync master back into development ( #5630 )
2024-03-31 21:59:44 +01:00
Adam Warner
5490a6ea6d
Release 5.18.2 ( #5629 )
2024-03-31 19:46:24 +01:00
Dominik
80db52691b
Only use local files (file://) when they have explicit permissions a+r ( #5622 )
2024-03-30 20:14:55 +01:00
Dominik
91e0d668e0
Code style: Use explicit form of CLI arguments
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Dominik <DL6ER@users.noreply.github.com >
2024-03-30 20:03:15 +01:00
dependabot[bot]
81ad1a76e6
Bump eps1lon/actions-label-merge-conflict from 2.1.0 to 3.0.0
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 2.1.0 to 3.0.0.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v2.1.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-30 10:50:22 +00:00
dependabot[bot]
67ddb64bcc
Bump eps1lon/actions-label-merge-conflict from 2.1.0 to 3.0.0
...
Bumps [eps1lon/actions-label-merge-conflict](https://github.com/eps1lon/actions-label-merge-conflict ) from 2.1.0 to 3.0.0.
- [Release notes](https://github.com/eps1lon/actions-label-merge-conflict/releases )
- [Changelog](https://github.com/eps1lon/actions-label-merge-conflict/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eps1lon/actions-label-merge-conflict/compare/v2.1.0...v3.0.0 )
---
updated-dependencies:
- dependency-name: eps1lon/actions-label-merge-conflict
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-30 10:10:21 +00:00
Dominik
c7d60295d9
Improve changed binary message during update process ( #5621 )
2024-03-28 18:51:40 +01:00
Dan Schaper
8cfccf9d1f
More checks when downloading from file:// scheme ( #5620 )
2024-03-28 09:44:51 -07:00
DL6ER
b595b3b5f4
Port most recent changes of PRs #5615 , #5618 amd #5620 to v6
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-28 15:41:45 +01:00
DL6ER
398f90f7f4
Non-matching checksums are not always corruption. Actually, they will instead be caused by binaries updated on the remote branch. This is most seen with frequently channging branchs such as development-v6 at this time.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-28 09:12:51 +01:00
Dan Schaper
47998e1c8a
Bump actions/checkout from 4.1.1 to 4.1.2 ( #5604 )
2024-03-27 16:31:40 -07:00
Orazio
d80fcf2e62
More checks when downloading from file:// scheme
...
Signed-off-by: Orazio <22700499+orazioedoardo@users.noreply.github.com >
2024-03-27 22:10:12 +01:00
dependabot[bot]
9f9e5dffc2
Bump pytest from 8.0.2 to 8.1.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.0.2 to 8.1.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.0.2...8.1.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-27 20:27:30 +00:00
Adam Warner
fcb98d7e4a
Bump tox from 4.14.1 to 4.14.2 in /test ( #5612 )
2024-03-27 20:26:39 +00:00
Adam Warner
7879f07011
Sync master back into development ( #5619 )
2024-03-27 20:15:28 +00:00
Adam Warner
74a44cad7a
v5.18.1 ( #5618 )
2024-03-27 19:18:09 +00:00
Adam Warner
32c640e838
Remove double quotes that prevented _any_ local files from being read by gravity ( #5617 )
2024-03-27 19:16:25 +00:00
Adam Warner
eb7daf4d2c
Fix file permission check in gravity.sh. Remove quotes that were added after complaints from shellcheck, this stopped the comparisson from working
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-03-27 19:12:59 +00:00
Adam Warner
7442454d32
Sync master back into development ( #5616 )
2024-03-27 18:25:47 +00:00
Adam Warner
3c7a6ce535
Release 5.18 ( #5615 )
2024-03-27 18:11:12 +00:00
Adam Warner
f3af03174e
Merge pull request from GHSA-95g6-7q26-mp9x
...
Only use local files (file://) when they have explicit permissions a+r
2024-03-27 18:02:44 +00:00
dependabot[bot]
472602ffb9
Bump tox from 4.14.1 to 4.14.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.14.1 to 4.14.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.14.1...4.14.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-23 10:52:31 +00:00
dependabot[bot]
7aab7d9849
Bump tox from 4.14.1 to 4.14.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.14.1 to 4.14.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.14.1...4.14.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-23 10:34:48 +00:00
dependabot[bot]
08dd321f73
Bump pytest from 8.0.2 to 8.1.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.0.2 to 8.1.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.0.2...8.1.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-16 10:44:52 +00:00
dependabot[bot]
58a1e85826
Bump actions/checkout from 4.1.1 to 4.1.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...v4.1.2 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-16 10:21:49 +00:00
dependabot[bot]
eb23fbf879
Bump actions/checkout from 4.1.1 to 4.1.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.1...v4.1.2 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-16 10:08:27 +00:00
Dominik
206cf9c4ea
Fix edge-case where an adlist domain is blocked ( #5571 )
2024-03-16 09:08:03 +01:00
Dominik
71b17294bc
Verify remote FTL checksum ( #5603 )
2024-03-11 19:14:20 +01:00
DL6ER
82a83c497d
Reduce code-duplication
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-10 21:18:13 +01:00
DL6ER
2fd0de4743
Verify that we actually downloaded a valid checksum before comparing it to the local one. This covers situations where downloading the checksum from remote might have failed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-10 08:43:37 +01:00
Dominik
dedaf5432e
Highlight "### CHANGED" strings in the debug log of pihole.toml ( #5601 )
2024-03-09 21:49:29 +01:00
DL6ER
c02401b81e
Highlight "### CHANGED" strings in the debug log of pihole.toml
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-09 16:57:28 +01:00
yubiuser
eaa878e7a4
Bump tox from 4.13.0 to 4.14.1 in /test ( #5602 )
2024-03-09 12:03:35 +01:00
dependabot[bot]
8042d9e3fd
Bump tox from 4.13.0 to 4.14.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.13.0 to 4.14.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.13.0...4.14.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-09 10:21:53 +00:00
yubiuser
cb4f6d4159
Bump tox from 4.13.0 to 4.14.1 in /test ( #5600 )
2024-03-09 11:12:22 +01:00
dependabot[bot]
bfd8b572cb
Bump tox from 4.13.0 to 4.14.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.13.0 to 4.14.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.13.0...4.14.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-09 10:07:37 +00:00
DL6ER
8fb3a594eb
Merge branch 'development-v6' into fix/gravity_domain
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-09 07:47:32 +01:00
DL6ER
9dd138b033
Only use local files (file://) when they have explicit permissions a+r
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-03-04 19:38:13 +01:00
Dominik
0635ea7455
Allow adlist duplicates ( #5572 )
2024-03-02 18:28:47 +01:00
yubiuser
0597128de8
Bump pytest-testinfra from 10.0.0 to 10.1.0 in /test ( #5579 )
2024-03-02 12:56:52 +01:00
dependabot[bot]
0fdd959c7f
Bump pytest-testinfra from 10.0.0 to 10.1.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 10.0.0 to 10.1.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/10.0.0...10.1.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-02 11:52:21 +00:00
yubiuser
e03ddf5d41
Bump pytest from 8.0.0 to 8.0.2 in /test ( #5598 )
2024-03-02 12:51:31 +01:00
dependabot[bot]
cb3e448b38
Bump pytest from 8.0.0 to 8.0.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.0.0 to 8.0.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.0.0...8.0.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-02 10:18:47 +00:00
yubiuser
6bb7d10a6d
Bump pytest from 8.0.1 to 8.0.2 in /test ( #5597 )
2024-03-02 11:09:20 +01:00
dependabot[bot]
fd1372df3e
Bump pytest from 8.0.1 to 8.0.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.0.1 to 8.0.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.0.1...8.0.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-02 10:01:31 +00:00
yubiuser
760f903d12
Bump pytest-testinfra from 10.0.0 to 10.1.0 in /test ( #5583 )
2024-02-24 13:53:55 +01:00
dependabot[bot]
07e6c0d250
Bump pytest-testinfra from 10.0.0 to 10.1.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 10.0.0 to 10.1.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/10.0.0...10.1.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-24 12:49:07 +00:00
yubiuser
48c1d5a3d2
Bump pytest from 8.0.0 to 8.0.1 in /test ( #5582 )
2024-02-24 13:48:06 +01:00
dependabot[bot]
3ed29f494b
Bump pytest from 8.0.0 to 8.0.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/8.0.0...8.0.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-24 12:45:22 +00:00
yubiuser
b57cf27103
Bump tox from 4.12.1 to 4.13.0 in /test ( #5581 )
2024-02-24 13:44:20 +01:00
yubiuser
f5e6364f98
Bump tox from 4.12.1 to 4.13.0 in /test ( #5584 )
2024-02-24 13:43:34 +01:00
DL6ER
ed1a6278b7
Merge branch 'development-v6' into new/migrate_dnsmasq_conf
2024-02-19 21:29:11 +01:00
dependabot[bot]
b322f1e98b
Bump tox from 4.12.1 to 4.13.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.12.1 to 4.13.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.12.1...4.13.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-17 10:50:41 +00:00
dependabot[bot]
5b75cb1950
Bump tox from 4.12.1 to 4.13.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.12.1 to 4.13.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.12.1...4.13.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-17 10:29:46 +00:00
DL6ER
9ff43040ec
Add list type in pihole -q
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 09:58:29 +01:00
DL6ER
75fadb9b55
Adlists need to be grouped by both address and type to differentiate between anti-/gravity lists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-13 08:55:26 +01:00
DL6ER
1a59b407e0
Merge branch 'development-v6' into tweak/allow_adlist_dups
2024-02-13 07:47:30 +01:00
Dominik
c771739f68
Fix gravity ( #5573 )
2024-02-12 06:42:04 +01:00
DL6ER
bcb712b6e3
Fix accidential double -ni from one of the last PRs
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-11 21:07:15 +01:00
Adam Warner
bb095bb209
Merge development into development-v6 (with merge conflicts resolved) ( #5570 )
2024-02-11 17:11:04 +00:00
DL6ER
b5ab8ac198
Change UNIQUEness constraint from (address) to (address, type) in the adlist table. This will allow certain adlists to be associated to different groups. A possible scenario is an adlist meant to block a specific service (e.g. Twitter, Youtube, etc.). It can then either be used to ensure these services are really blocked on the devices of group A but will never be blocked on devices of group B.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-11 16:54:22 +01:00
DL6ER
8b3469cabc
Merge branch 'development-v6' into development-v6-merge-development
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-02-11 16:41:41 +01:00
yubiuser
aca7b31b83
Remove local.list and openVPN traces ( #5480 )
2024-02-10 06:16:00 +01:00
Dominik
8f36fdf11c
Make IDs of anti-/gravity lists available in vw_(anti)gravity ( #5526 )
2024-02-09 20:52:29 +01:00
Adam Warner
f193edd428
Merge branch 'development' into development-v6-merge-development (resolved conflicts)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-02-09 19:22:53 +00:00
yubiuser
3ba6ab5ec7
Bump pytest from 7.4.4 to 8.0.0 in /test ( #5566 )
2024-02-05 13:53:45 +01:00
dependabot[bot]
f0878c0890
Bump pytest from 7.4.4 to 8.0.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.4 to 8.0.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.4...8.0.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-04 21:39:17 +00:00
Adam Warner
2009fa85ec
Fedora ( #5568 )
2024-02-04 21:36:37 +00:00
Christian König
7b6f0d1596
Also remove Fedora 37
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-02-04 16:41:20 +01:00
Christian König
f8bfd59f11
Drop Fedora 36 and add Fedora 39 to the test suite
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-02-04 16:40:12 +01:00
yubiuser
499ba9785f
Bump pytest from 7.4.4 to 8.0.0 in /test ( #5567 )
2024-02-04 16:22:41 +01:00
dependabot[bot]
6e946f76d6
Bump pytest from 7.4.4 to 8.0.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.4 to 8.0.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.4...8.0.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-02-03 10:21:48 +00:00
Dominik
92e741fd5a
Test ftl.pi-hole.net availability ( #5563 )
2024-02-02 19:02:54 +01:00
DL6ER
31a8f150b2
Add checking for availability of ftl.pi-hole.net when using FTL from a custom branch. If the server is down (or the user is offline, cannot resolve the domain, etc.), we fail early and hard instead of possibly corrupting the installation
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-01-31 08:00:28 +01:00
DL6ER
07b448d784
Also check for IPv6 address for configured DNS servers
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-01-30 19:24:33 +01:00
Adam Warner
9a3affd81e
Drop Fedora 36 and add Fedora 39 to the test suite ( #5482 )
2024-01-29 18:21:16 +00:00
Christian König
935a4ce0b3
Also remove Fedora 37
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-01-28 16:56:57 +01:00
yubiuser
cc8f9fe057
Use 204 return code for deleted sessions ( #5541 )
2024-01-27 22:05:09 +01:00
yubiuser
e1c41fe4d5
Bump tox from 4.12.0 to 4.12.1 in /test ( #5556 )
2024-01-20 12:25:01 +01:00
yubiuser
37c6b353b3
Bump tox from 4.12.0 to 4.12.1 in /test ( #5555 )
2024-01-20 12:23:35 +01:00
dependabot[bot]
60de50bb73
Bump tox from 4.12.0 to 4.12.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.12.0 to 4.12.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.12.0...4.12.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-20 10:49:27 +00:00
dependabot[bot]
ba2682c907
Bump tox from 4.12.0 to 4.12.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.12.0 to 4.12.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.12.0...4.12.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-20 10:38:21 +00:00
Dominik
d6dbb40ef1
Do not store remote version in versions file if on custom branch ( #5549 )
2024-01-15 22:09:29 +01:00
DL6ER
47f06dfd71
Do not store remote version in versions file if on custom branch. It's always wrong here
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2024-01-15 20:53:34 +01:00
yubiuser
e773d0399f
Bump tox from 4.11.4 to 4.12.0 in /test ( #5547 )
2024-01-13 20:42:30 +01:00
yubiuser
ebb0db0a3b
Bump tox from 4.11.4 to 4.12.0 in /test ( #5548 )
2024-01-13 20:40:53 +01:00
dependabot[bot]
b662fd6f01
Bump tox from 4.11.4 to 4.12.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.11.4 to 4.12.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.11.4...4.12.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-13 10:43:13 +00:00
dependabot[bot]
9eb47319f5
Bump tox from 4.11.4 to 4.12.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.11.4 to 4.12.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.11.4...4.12.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-13 10:32:36 +00:00
Christian König
debab10792
Use 204
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2024-01-11 20:42:32 +01:00
Adam Warner
b756262ebe
Fix failing tests in development-v6 branch ( #5542 )
2024-01-10 11:14:50 +00:00
Dominik
e781311f23
pihole -d: Fix gateway ping if it is a LL address ( #5527 )
2024-01-09 19:19:32 +01:00
Adam Warner
df9c60e351
Reduce code duplication in FTL arch detect tests.
...
Use parametrize to run the same test with different parameters for each arch we need to test.
Also include detection of unusupported in this test.
Create FTL_BRANCH constant to be used in functions (less places to remember to change it)
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-01-08 18:26:59 +00:00
Adam Warner
aa4ceb4198
Sync master back into development ( #5537 )
2024-01-07 21:17:15 +00:00
Adam Warner
220c0675ef
As we do in other tests, specify development-v6 branch of FTL is downloaded for the tests. We need to change this to develoment once v6 is released
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2024-01-07 21:03:48 +00:00
Adam Warner
19bfa08b83
Pi-hole core v5.17.3 ( #5520 )
2024-01-06 16:53:38 +00:00
yubiuser
7eb69a5cc8
Bump pytest from 7.4.3 to 7.4.4 in /test ( #5536 )
2024-01-06 11:14:52 +01:00
yubiuser
e14792bc48
Bump pytest from 7.4.3 to 7.4.4 in /test ( #5535 )
2024-01-06 11:14:28 +01:00
dependabot[bot]
05e7d0ee92
Bump pytest from 7.4.3 to 7.4.4 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.3 to 7.4.4.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.3...7.4.4 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-06 10:10:22 +00:00
dependabot[bot]
9c3578856f
Bump pytest from 7.4.3 to 7.4.4 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.3 to 7.4.4.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.3...7.4.4 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-01-06 10:02:39 +00:00
DL6ER
d2828310f2
Modify DELETE triggers to delete BEFORE instead of AFTER to prevent possible foreign key constraint violations
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-28 11:12:20 +01:00
DL6ER
00340136bd
Extend %iface logic to the dig test. Also fix intentation in this function
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-26 21:35:24 +01:00
DL6ER
0c6363572b
Append the interface to the gateway address if it is a link-local address
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-25 22:00:49 +01:00
DL6ER
1b87ec067e
Exit early if the database does not exist (e.g. in some CI tests)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-25 06:12:18 +01:00
DL6ER
8e8c7ecad2
Run gravity upgrade on checkout/update
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-25 05:59:41 +01:00
DL6ER
0066c6fbff
Make IDs of anti-/gravity lists available in vw_(anti)gravity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-25 05:29:29 +01:00
yubiuser
6e8029f69f
Bump github/codeql-action from 2 to 3 ( #5521 )
2023-12-16 17:42:03 +01:00
yubiuser
12c6dd5dff
Bump github/codeql-action from 2 to 3 ( #5522 )
2023-12-16 17:38:44 +01:00
dependabot[bot]
c6049d4002
Bump github/codeql-action from 2 to 3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-16 10:30:20 +00:00
dependabot[bot]
0cfcdc4b50
Bump github/codeql-action from 2 to 3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-16 10:08:32 +00:00
Dominik
2ae79f2443
Add "-ni" to all sqlite3 invocations (v5) ( #5519 )
2023-12-10 18:02:23 +01:00
DL6ER
e8338d0590
Install FTL's development branch to get the latest features during tests
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-10 11:06:48 +01:00
Dominik
719ce801f5
Add "-ni" to all sqlite3 invocations ( #5518 )
2023-12-10 10:17:48 +01:00
yubiuser
13676c40ca
Simplify pihole -v ( #5517 )
2023-12-09 23:21:52 +01:00
Christian König
c3c31a1a60
Print version details automatically if not on master
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 23:14:58 +01:00
Christian König
b333e30162
Remove version options from bash completion
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 23:14:58 +01:00
Christian König
fe4d934a40
Simplify pihole -v
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 23:13:04 +01:00
yubiuser
a6c0d279b6
Remove obsolete sudo file ( #5514 )
2023-12-09 23:11:04 +01:00
DL6ER
3f7413d538
Add "-ni" to all sqlite3 invocations
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-09 23:07:35 +01:00
DL6ER
c90a27c509
Add "-ni" to all sqlite3 invocations
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-09 23:06:50 +01:00
yubiuser
ac86ae1e4c
Bash completion ( #5516 )
2023-12-09 23:02:29 +01:00
Christian König
6d02d4056f
Rename option --admin to --web in version function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 22:01:30 +01:00
Christian König
fe7299323c
Update bash_completion
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 21:40:32 +01:00
Christian König
274d4c263c
Add bash-completion to PIHOLE_DEPS
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 21:23:39 +01:00
Christian König
54186a63ee
Remove test for sudo file as well
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 21:04:56 +01:00
Christian König
a87d1bbc4f
Remove pihole.sudo
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-09 21:04:56 +01:00
yubiuser
750fb66a8c
Bump actions/setup-python from 4.7.1 to 5.0.0 ( #5510 )
2023-12-09 18:46:19 +01:00
yubiuser
0b23b9b268
Bump actions/stale from 8.0.0 to 9.0.0 ( #5511 )
2023-12-09 18:45:25 +01:00
dependabot[bot]
e49d7fa5f1
Bump actions/setup-python from 4.7.1 to 5.0.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.1 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.7.1...v5.0.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-09 17:39:42 +00:00
dependabot[bot]
8a71e4253e
Bump actions/stale from 8.0.0 to 9.0.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v8.0.0...v9.0.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-09 17:39:18 +00:00
yubiuser
2529fbeacd
Treat FTL return data as strings ( #5509 )
2023-12-09 18:35:14 +01:00
yubiuser
63b2a1f44a
Bump actions/setup-python from 4.7.1 to 5.0.0 ( #5512 )
2023-12-09 12:43:52 +01:00
yubiuser
c6756b1678
Bump actions/stale from 8.0.0 to 9.0.0 ( #5513 )
2023-12-09 12:42:36 +01:00
dependabot[bot]
c34464d1e8
Bump actions/stale from 8.0.0 to 9.0.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v8.0.0...v9.0.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-09 10:36:49 +00:00
dependabot[bot]
16180e4b23
Bump actions/setup-python from 4.7.1 to 5.0.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.1 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.7.1...v5.0.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-09 10:36:44 +00:00
Dominik
03637e9081
Use files.gravity_tmp as temporary directory for the intermediate lists ( #5504 )
2023-12-09 09:30:28 +01:00
Christian König
159817b7e2
Use development-v6 as ftl branch for binary test
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-06 20:35:26 +01:00
Christian König
2681835f94
Treat FTL return data as strings
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-12-06 00:23:15 +01:00
Dominik
7f7ec13c82
Support special webserver.port ports ending in "s" (secure) and "r" (redirect) ( #5499 )
2023-12-04 23:48:08 +01:00
DL6ER
32a741b5c7
We do not follow 308 but FTL also doesn't suggest it
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-02 22:42:36 +01:00
yubiuser
bbbb4609d2
Bump tox from 4.11.3 to 4.11.4 in /test ( #5506 )
2023-12-02 14:23:13 +01:00
yubiuser
e364349901
Bump tox from 4.11.3 to 4.11.4 in /test ( #5507 )
2023-12-02 14:22:53 +01:00
dependabot[bot]
f5fe550a2e
Bump tox from 4.11.3 to 4.11.4 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.11.3 to 4.11.4.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.11.3...4.11.4 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-02 10:35:21 +00:00
dependabot[bot]
bfc824f2ff
Bump tox from 4.11.3 to 4.11.4 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.11.3 to 4.11.4.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.11.3...4.11.4 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-12-02 10:04:50 +00:00
DL6ER
29d010dc2c
Use files.gravity_tmp as temporary directory for the intermediate lists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-01 10:21:13 +01:00
DL6ER
96bf07863f
Use CHAOS TXT local.api.txt instead of trying to parse pihole-FTL --config webserver.ports
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-12-01 09:10:06 +01:00
yubiuser
62f9694aa4
Bump pytest-xdist from 3.4.0 to 3.5.0 in /test ( #5500 )
2023-12-01 00:15:20 +01:00
yubiuser
4523f078bb
Bump pytest-xdist from 3.4.0 to 3.5.0 in /test ( #5501 )
2023-12-01 00:13:41 +01:00
DL6ER
6016131280
Ensure we also check the last port
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-28 22:59:49 +01:00
DL6ER
974fea592d
Iterate over ports, skip redirected ports
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-28 00:05:55 +01:00
dependabot[bot]
9d57f64937
Bump pytest-xdist from 3.4.0 to 3.5.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-25 10:58:21 +00:00
dependabot[bot]
1276242a4e
Bump pytest-xdist from 3.4.0 to 3.5.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.4.0...v3.5.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-25 10:16:35 +00:00
DL6ER
a6565bf9a1
Support special webserver.port ports ending in "s" (secure) and "r" (redirect)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-23 22:07:31 +01:00
DL6ER
c785667efe
Trim leading and trailing spaces and tabs in upstream servers (if any)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-23 09:56:43 +01:00
DL6ER
cc333f79cc
Check if this domain is blocked by Pi-hole but only if the domain is not a local file or empty
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-22 21:10:22 +01:00
DL6ER
df7633bd1b
Add missing value for ${gravityDBfile_default}
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-22 21:08:06 +01:00
DL6ER
4efcdf1189
Add missing double quotes to prevent globbing and word splitting
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-22 21:06:09 +01:00
DL6ER
f16cf71781
${PIHOLE_DNS_1} is gone, use the first server from pihole-FTL --config dns.upstreams instead
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-22 21:04:46 +01:00
DL6ER
19d3489bcb
gravity_DownloadBlocklistFromUrl needs ${domain} but it was declared local before and was not passed as argument, making gravity currently depend on undefined behavior. It seems to be working well in the vast majority of cases, however, it seems we have at least one report where it is not working.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-22 20:56:23 +01:00
yubiuser
2338c9e916
Bump pytest-xdist from 3.3.1 to 3.4.0 in /test ( #5490 )
2023-11-18 12:31:11 +01:00
yubiuser
536d170009
Bump pytest-testinfra from 9.0.0 to 10.0.0 in /test ( #5492 )
2023-11-18 12:30:21 +01:00
dependabot[bot]
f4b67065cc
Bump pytest-xdist from 3.3.1 to 3.4.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.3.1 to 3.4.0.
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.3.1...v3.4.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-18 10:55:51 +00:00
yubiuser
2b79abb948
Bump pytest-testinfra from 9.0.0 to 10.0.0 in /test ( #5491 )
2023-11-18 11:55:06 +01:00
dependabot[bot]
2e73eb36ef
Bump pytest-testinfra from 9.0.0 to 10.0.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 9.0.0 to 10.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/9.0.0...10.0.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-18 10:54:16 +00:00
yubiuser
271884c4bb
Bump pytest-xdist from 3.3.1 to 3.4.0 in /test ( #5493 )
2023-11-18 11:53:28 +01:00
dependabot[bot]
3c4f217876
Bump pytest-xdist from 3.3.1 to 3.4.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.3.1 to 3.4.0.
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.3.1...v3.4.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-18 10:27:10 +00:00
dependabot[bot]
ab09233753
Bump pytest-testinfra from 9.0.0 to 10.0.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 9.0.0 to 10.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/9.0.0...10.0.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-18 10:17:34 +00:00
yubiuser
af9b8df118
Improve v6 debug log and remove leftovers ( #5481 )
2023-11-14 00:04:16 +01:00
Christian König
b61e8be3b4
Address reviewer's comment
...
Co-authored-by: DL6ER <dl6er@dl6er.de >
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 23:04:44 +01:00
Christian König
54ab71d817
Don't use hardcoded ports to check for
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 23:04:44 +01:00
Christian König
e7c89ce25f
No need to pass a default value to get_ftl_conf_value()
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 23:04:44 +01:00
Christian König
d3813c4be5
Update check for required ports
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 23:04:44 +01:00
Christian König
d854eb1a97
Add lshw to Pi-hole deps
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 23:04:44 +01:00
Christian König
86aa6b1df6
Improve v6 debug log and remove leftovers
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 23:04:44 +01:00
yubiuser
1da36bd4e7
Move custom.list to /hosts/custom.list ( #5488 )
2023-11-13 22:58:16 +01:00
Christian König
f65b126433
Move custom.list to /hosts/custom.list
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-13 21:37:41 +01:00
Christian König
766cb26af5
Drop Fedora 36 and add Fedora 39 to the test suite
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-07 22:24:34 +01:00
DL6ER
e8884083ef
Apply suggestions from code review
...
Signed-off-by: DL6ER <DL6ER@users.noreply.github.com >
2023-11-07 08:58:31 +01:00
DL6ER
e3c6f162d8
Apply suggestions from code review
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: DL6ER <DL6ER@users.noreply.github.com >
2023-11-07 08:57:56 +01:00
Christian König
de6e61705e
Remove local.list and openVPN traces
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-06 21:40:32 +01:00
DL6ER
834e52f15d
pihole -d: Include pihole.toml only once ( #5478 )
2023-11-06 19:46:33 +01:00
DL6ER
0b4131189d
Migrate Pi-hole created files out of /etc/dnsmasq.d into a pihole owned directory
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-06 14:55:34 +01:00
DL6ER
72c972175d
Remove left-over parts of setupVars processing and only include pihole.toml once
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-11-06 13:53:08 +01:00
yubiuser
2746ee3ae9
Tweak help text of pihole setpassword ( #5476 )
2023-11-05 23:24:31 +01:00
Christian König
bc96d3b0a9
Tweak help text of pihole setpassword
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-05 21:18:46 +01:00
DL6ER
395110f92f
When setting a blank password, use webserver.api.password instead of webserver.api.pwhash ( #5465 )
2023-11-04 17:43:09 +01:00
yubiuser
758ace57c0
Check for valid OS via IPv4 and IPv6 ( #5305 )
2023-11-04 08:02:38 +01:00
yubiuser
4c129afb10
Start counting at postion 1 ( #5470 )
2023-11-02 07:00:23 +01:00
Christian König
ced1c5d50b
Start counting at postion 1
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-11-01 21:57:36 +01:00
yubiuser
ce21b4c731
Remove idn2 as punycode conversion is handled by FTL ( #5468 )
2023-11-01 21:06:02 +01:00
Christian König
480a8c8d7f
Remove idn2 as punycode conversion is handled by FTL
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-31 21:02:26 +01:00
DL6ER
0a193f98a4
Tweak Pi-hole's debug facility for v6 ( #5461 )
2023-10-29 06:13:22 +01:00
Adam Warner
4c4a2ad5bd
Use suffixed temp file ( #5457 )
2023-10-28 22:20:33 +01:00
Adam Warner
ab3b6dfa67
No need to >/dev/null because setFTLConfigValue already does this
...
adjust output of setFTLConfigValue to test for the exit code of `pihole-FTL --config`
2023-10-28 19:46:45 +01:00
Adam Warner
6292e65b37
When setting a blank password, use webserver.api.password instead of webserver.api.pwhash (fixed in https://github.com/pi-hole/FTL/pull/1702 )
...
This prevents the password from being blanked out on the command line when it has been set by an environment variable
2023-10-28 17:56:37 +01:00
yubiuser
300a4e2299
Bump pytest from 7.4.2 to 7.4.3 in /test ( #5463 )
2023-10-28 14:03:52 +02:00
yubiuser
ed5d794008
Bump pytest from 7.4.2 to 7.4.3 in /test ( #5462 )
2023-10-28 14:02:35 +02:00
dependabot[bot]
ec86124997
Bump pytest from 7.4.2 to 7.4.3 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.2 to 7.4.3.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.2...7.4.3 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-28 10:32:55 +00:00
dependabot[bot]
2e9e579bba
Bump pytest from 7.4.2 to 7.4.3 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.2 to 7.4.3.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.2...7.4.3 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-28 10:31:54 +00:00
DL6ER
d377cfbc3e
Extract the first entry in the answer section from dig's output, replacing any multiple spaces and tabs with a single space
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:34:30 +02:00
DL6ER
15be8eeffa
Remove lighttpd config test
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:21:08 +02:00
DL6ER
635b4e952f
Add NOERROR/NXDOMAIN support in the DNS resolution test
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:20:31 +02:00
DL6ER
c86e7b3f96
Generalize CPU check to a short hardware information output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:13:31 +02:00
DL6ER
dcc7e96d2f
Remove detection of addresses of PIHOLE_INTERFACE as it is gone, too
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:07:11 +02:00
DL6ER
ccd8c470a5
check_x_headers is no more
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:03:37 +02:00
DL6ER
00d7e998b4
setupVars.conf and pihole-FTL.conf are no more - use pihole.toml instead
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-28 08:03:09 +02:00
Christian König
fd8fdd3513
Use suffixed temp file
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-23 21:36:18 +02:00
DL6ER
a44e51bf76
Fix and simplify binary download ( #5451 )
2023-10-22 23:03:42 +02:00
DL6ER
91c5967b27
Fix gravity swapping ( #5455 )
2023-10-22 23:03:30 +02:00
DL6ER
842a9d7778
Address review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-22 08:33:56 +02:00
DL6ER
7523c49f62
Swapping the databases must be the last step before the cleanup. Otherwise, FTL may be reloading from an only partially completed database causing spurious errors and/or warnings.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-22 08:14:11 +02:00
DL6ER
369ccf13a8
Move FTL binary availability check after the supported OS check
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-21 21:40:21 +02:00
DL6ER
38ecc1693f
Further simplify the ARMv6 test
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-21 20:39:32 +02:00
DL6ER
30bfc7cc9f
Add binutils tot he OS check dependencies as we need it to check if the local system is abel to run any of our precompiled FTL binaries
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-21 19:15:10 +02:00
DL6ER
45687d675b
Fix the binary detection for ARMv6 and simplify the router overall
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-21 19:13:45 +02:00
DL6ER
ca7836bf71
Remove now obsolete GLIBC version check
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-21 19:05:45 +02:00
DL6ER
8bcd1d4c54
*BREAKING* Drop support for ancient ARMv4 and ARMv5 ( #5445 )
2023-10-21 18:27:42 +02:00
yubiuser
19e081b8ac
Bump actions/checkout from 4.1.0 to 4.1.1 ( #5448 )
2023-10-21 13:51:37 +02:00
DL6ER
ba61ee284b
Bump actions/checkout from 4.1.0 to 4.1.1 ( #5449 )
2023-10-21 13:02:30 +02:00
dependabot[bot]
2a72012ca1
Bump actions/checkout from 4.1.0 to 4.1.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-21 10:55:06 +00:00
dependabot[bot]
79ebbacc4a
Bump actions/checkout from 4.1.0 to 4.1.1
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.0...v4.1.1 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-21 10:27:01 +00:00
yubiuser
6cf39d9b92
Remove temp dir created when downloading FTL ( #5429 )
2023-10-20 09:25:10 +02:00
DL6ER
c571d8d37d
Drop support for ancient ARMv4 and ARMv5, the Debian binaries turn out to cause unresolvable SIGFPE on ARMv6 and lower. Fortunately, we can still use the Alpine binaries on all Raspberry Pi models (even the oldest ones)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-10-19 22:13:44 +02:00
yubiuser
33a41391b5
Logrotate config file needs to be owned by root ( #5444 )
2023-10-18 23:00:47 +02:00
Christian König
d77dbf736c
Logrotate config file needs to be owned by root
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-18 22:09:38 +02:00
yubiuser
2deadb2e4a
Avoid printing getFTLConfigValue return in statusFunc() ( #5442 )
2023-10-18 13:19:02 +02:00
RD WebDesign
2c7fa4a7b3
Avoid printing getFTLConfigValue return in statusFunc()
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-10-18 02:07:06 -03:00
DL6ER
ed0dfa8b77
Add a final message to gravity ( #5441 )
2023-10-16 23:00:12 +02:00
RD WebDesign
27522fbc18
Add a final message to gravity
...
The terminal version doesn't really need a final message, but this will be
read by the web interface to show a success message
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-10-16 17:19:44 -03:00
yubiuser
aaa9acc0b9
Update query.sh to use FTL's API instead of directly interacting with the database ( #5361 )
2023-10-16 21:00:42 +02:00
Christian König
123ba1f154
Remove temp dir created when downloading FTL
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-15 22:15:11 +02:00
Christian König
2005d04625
Exact search is the new default
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-14 21:50:57 +02:00
yubiuser
2841a33b81
Set owner of gravity output files to pihole ( #5419 )
2023-10-14 19:40:27 +02:00
yubiuser
539f379cb4
Remove Chronometer ( #5423 )
2023-10-14 19:40:02 +02:00
Christian König
ec83d6b793
No help for gone functions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-14 14:06:47 +02:00
Christian König
f7ba059b94
Query directly and authenticate only if required
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-14 14:03:56 +02:00
Christian König
e374950915
Merge branch 'development-v6' into query_list_v6
2023-10-13 21:49:09 +02:00
yubiuser
6ae713eaf5
Allow pihole to access subdirs in /etc/pihole ( #5427 )
2023-10-13 20:29:38 +02:00
Christian König
40c75289b5
Allow pihole to access subdirs in /etc/pihole
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-13 20:07:25 +02:00
Christian König
188b2b858a
PADD is fine, really!
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-12 13:48:01 +02:00
Christian König
46ff257344
Remove Chronometer
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-12 13:44:51 +02:00
Christian König
2061f3a70e
Set owner/permissions at the right place
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-11 21:22:12 +02:00
Adam Warner
51de1dcfcd
Sync master back into development ( #5422 )
2023-10-11 10:42:31 +01:00
Adam Warner
60b6a1016c
v5.17.2 ( #5421 )
2023-10-11 10:41:25 +01:00
Christian König
22863845a0
Set owner/group of /etc/pihole to pihole
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-09 22:05:01 +02:00
Christian König
679aab10d0
Run gravity as user pihole
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-09 21:53:37 +02:00
Christian König
6001fe34ec
Set owner of gravity output files to pihole
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-08 23:03:33 +02:00
Adam Warner
96640ea2c8
Update references to web repo ( #5417 )
2023-10-08 19:51:42 +01:00
Adam Warner
1fa5cb84db
Update references to web repo ( #5418 )
2023-10-08 19:51:39 +01:00
Adam Warner
9622265c8d
Disable checkout function for (official) docker containers ( #5416 )
2023-10-08 16:08:36 +01:00
Adam Warner
71357ecae7
adminlte->web
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-10-08 14:12:02 +01:00
Adam Warner
7886dc0172
adminlte->web
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-10-08 14:09:47 +01:00
Adam Warner
044e856e6b
Disable checkout function for (official) docker containers
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-10-08 13:23:44 +01:00
yubiuser
0385b1d076
Bump actions/setup-python from 4.7.0 to 4.7.1 ( #5412 )
2023-10-07 16:45:34 +02:00
yubiuser
e87d03a5ef
Bump actions/setup-python from 4.7.0 to 4.7.1 ( #5413 )
2023-10-07 13:21:54 +02:00
dependabot[bot]
70547755d6
Bump actions/setup-python from 4.7.0 to 4.7.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.7.0...v4.7.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-07 10:39:32 +00:00
dependabot[bot]
f52b2b9863
Bump actions/setup-python from 4.7.0 to 4.7.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.7.0...v4.7.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-10-07 10:23:00 +00:00
yubiuser
bef5d85e6b
Yu vs uh ( #5411 )
2023-10-07 06:09:23 +02:00
Christian König
afa688e3a0
Yu vs uh
...
(https://www.theguardian.com/guardian-observer-style-guide-r#:~:text=re/re%2D,re%2Dsign/resign )
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-07 00:21:06 +02:00
yubiuser
f5885c8f64
Fix spellcheck errors ( #5410 )
2023-10-07 00:15:11 +02:00
Christian König
edf0060acf
Fix spellcheck errors
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-10-06 22:26:08 +02:00
Adam Warner
7b341cc005
Some verbiage change to outputs (plus a couple of comments) ( #5406 )
2023-10-04 19:49:48 +01:00
Adam Warner
885b626a68
Some unrelated spelling mistakes that spellcheck is grumbling about
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-10-04 16:22:01 +01:00
Adam Warner
aba41b45b0
Some verbiage change to outputs
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-10-04 16:20:38 +01:00
Adam Warner
69a264a3c2
Add antigravity support to gravity ( #5330 )
2023-09-29 19:09:24 +01:00
DL6ER
43ddfcf2ca
Ensure pihole-FTL can write to all files in /etc/pihole, /run/pihole and /var/log/pihole ( #5356 )
2023-09-26 19:59:56 +02:00
Adam Warner
0bf33edda1
Ignore ABP style entries in debug log dig test ( #5382 )
2023-09-26 17:35:25 +01:00
yubiuser
fc72902029
Bump actions/checkout from 4.0.0 to 4.1.0 ( #5397 )
2023-09-23 13:31:14 +02:00
yubiuser
3f4e2105b3
Bump actions/checkout from 4.0.0 to 4.1.0 ( #5396 )
2023-09-23 13:17:29 +02:00
dependabot[bot]
ec9d84692f
Bump actions/checkout from 4.0.0 to 4.1.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-23 10:45:09 +00:00
dependabot[bot]
c3d1f366ec
Bump actions/checkout from 4.0.0 to 4.1.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.0.0...v4.1.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-23 10:39:24 +00:00
DL6ER
ea23c8364d
Move antigravity-related changed to gravits database migration step 16->17
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-09-16 10:04:29 +02:00
DL6ER
df92b8ac14
Add missing creation of view vw_antigravity as well as schema change to vw_adlist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-09-12 20:43:34 +02:00
DL6ER
f19a56cf87
Merge branch 'development-v6' into new/antigravity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-09-11 11:43:56 +02:00
yubiuser
4955c52af7
Remove fake user agent when downloading adlists ( #5366 )
2023-09-10 21:20:14 +02:00
yubiuser
20a35936ca
Remove fake user agent when downloading adlist ( #5367 )
2023-09-10 21:19:27 +02:00
Adam Warner
d6a018a3f8
Sync master back into development ( #5391 )
2023-09-10 16:22:32 +01:00
Adam Warner
fef2861eae
Do not try to remove stale label on PRs ( #5292 )
2023-09-10 12:52:27 +01:00
yubiuser
babe7a7798
Bump actions/checkout from 3.6.0 to 4.0.0 ( #5388 )
2023-09-09 20:52:29 +02:00
yubiuser
7fbc7d458b
Bump tox from 4.11.1 to 4.11.3 in /test ( #5389 )
2023-09-09 19:54:45 +02:00
yubiuser
c46a06b522
Bump pytest from 7.4.0 to 7.4.2 in /test ( #5390 )
2023-09-09 19:54:05 +02:00
yubiuser
0ff736fadd
Bump pytest from 7.4.0 to 7.4.2 in /test ( #5386 )
2023-09-09 19:53:19 +02:00
yubiuser
3f6e41e8f4
Bump actions/checkout from 3.6.0 to 4.0.0 ( #5387 )
2023-09-09 17:08:51 +02:00
dependabot[bot]
dc73ace7c4
Bump pytest from 7.4.0 to 7.4.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.0 to 7.4.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.0...7.4.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-09 15:07:06 +00:00
yubiuser
76d978144f
Bump tox from 4.11.1 to 4.11.3 in /test ( #5385 )
2023-09-09 17:06:26 +02:00
dependabot[bot]
55f72ac925
Bump pytest from 7.4.0 to 7.4.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.4.0 to 7.4.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.4.0...7.4.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-09 10:58:32 +00:00
dependabot[bot]
047eac6d9c
Bump tox from 4.11.1 to 4.11.3 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.11.1 to 4.11.3.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.11.1...4.11.3 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-09 10:58:28 +00:00
dependabot[bot]
16ea50ad55
Bump actions/checkout from 3.6.0 to 4.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.6.0 to 4.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.6.0...v4.0.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-09 10:17:15 +00:00
dependabot[bot]
1f241a3d45
Bump actions/checkout from 3.6.0 to 4.0.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.6.0 to 4.0.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.6.0...v4.0.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-09 10:08:40 +00:00
dependabot[bot]
a229a623bb
Bump tox from 4.11.1 to 4.11.3 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.11.1 to 4.11.3.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.11.1...4.11.3 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-09 10:05:32 +00:00
yubiuser
f035687fca
Ignore ABP style entries in debug log dig test ( #5381 )
2023-09-07 22:49:57 +02:00
Christian König
52268f0155
Ignore ABP style entries in debug log dig test
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-09-07 22:32:09 +02:00
Christian König
843f57399c
Ignore ABP style entries in debug log dig test
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-09-07 22:27:49 +02:00
Christian König
cdc1c1ace1
Remove user agent when downloading adlists
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-09-03 23:40:58 +02:00
yubiuser
ff72650b8d
Bump tox from 4.10.0 to 4.11.1 in /test ( #5379 )
2023-09-02 18:14:39 +02:00
yubiuser
a74887db20
Bump tox from 4.10.0 to 4.11.1 in /test ( #5378 )
2023-09-02 14:54:27 +02:00
dependabot[bot]
9084b170cb
Bump tox from 4.10.0 to 4.11.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.10.0 to 4.11.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.10.0...4.11.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-02 10:35:16 +00:00
dependabot[bot]
ff2c2290c7
Bump tox from 4.10.0 to 4.11.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.10.0 to 4.11.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.10.0...4.11.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-02 10:27:10 +00:00
Christian König
c33963b250
Check for valid OS via IPv4 and IPv6
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-27 15:11:47 +02:00
Christian König
eca84e0986
Remove user agent when downloading adlists
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-27 14:59:47 +02:00
yubiuser
fb831b5f48
Bump actions/checkout from 3.5.3 to 3.6.0 ( #5372 )
2023-08-27 14:41:25 +02:00
yubiuser
2878c1ba84
Bump tox from 4.9.0 to 4.10.0 in /test ( #5371 )
2023-08-27 14:34:14 +02:00
dependabot[bot]
9b68fa0b27
Bump tox from 4.9.0 to 4.10.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.9.0...4.10.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-27 12:28:54 +00:00
yubiuser
a7ed968ee2
Bump pytest-testinfra from 8.1.0 to 9.0.0 in /test ( #5370 )
2023-08-27 14:28:17 +02:00
yubiuser
487a64abec
Bump tox from 4.9.0 to 4.10.0 in /test ( #5374 )
2023-08-26 14:44:00 +02:00
yubiuser
1330aa8f1c
Bump actions/checkout from 3.5.3 to 3.6.0 ( #5375 )
2023-08-26 14:43:21 +02:00
dependabot[bot]
53e8127781
Bump actions/checkout from 3.5.3 to 3.6.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.5.3...v3.6.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-26 11:33:09 +00:00
dependabot[bot]
e65b171aea
Bump tox from 4.9.0 to 4.10.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.9.0...4.10.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-26 11:24:09 +00:00
yubiuser
268a5dac40
Bump pytest-testinfra from 8.1.0 to 9.0.0 in /test ( #5373 )
2023-08-26 13:23:31 +02:00
dependabot[bot]
1afc96c055
Bump pytest-testinfra from 8.1.0 to 9.0.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 8.1.0 to 9.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/8.1.0...9.0.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-26 10:46:28 +00:00
dependabot[bot]
924f8b8844
Bump actions/checkout from 3.5.3 to 3.6.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.5.3...v3.6.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-26 10:20:12 +00:00
dependabot[bot]
1c6919cf07
Bump pytest-testinfra from 8.1.0 to 9.0.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 8.1.0 to 9.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/8.1.0...9.0.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-26 10:08:08 +00:00
yubiuser
996234ad66
Bump tox from 4.7.0 to 4.9.0 in /test ( #5365 )
2023-08-19 18:14:20 +02:00
yubiuser
18c9ae64b4
Bump tox from 4.7.0 to 4.9.0 in /test ( #5364 )
2023-08-19 15:33:31 +02:00
dependabot[bot]
272ca8c55d
Bump tox from 4.7.0 to 4.9.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.7.0 to 4.9.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.7.0...4.9.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-19 10:48:18 +00:00
dependabot[bot]
43882693a5
Bump tox from 4.7.0 to 4.9.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.7.0 to 4.9.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.7.0...4.9.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-19 10:19:26 +00:00
Christian König
ee4eb8db20
chmod +x
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-13 22:26:44 +02:00
Christian König
8e0a40e717
Use api.sh within query.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-13 22:24:05 +02:00
yubiuser
9fc01263e6
Bump tox from 4.6.4 to 4.7.0 in /test ( #5360 )
2023-08-12 13:32:41 +02:00
yubiuser
052f9763b5
Bump tox from 4.6.4 to 4.7.0 in /test ( #5359 )
2023-08-12 13:24:30 +02:00
dependabot[bot]
7747cd2232
Bump tox from 4.6.4 to 4.7.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.6.4 to 4.7.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.6.4...4.7.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-12 10:52:02 +00:00
dependabot[bot]
bd55b2e566
Bump tox from 4.6.4 to 4.7.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.6.4 to 4.7.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.6.4...4.7.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-08-12 10:25:00 +00:00
Christian König
2227a2c569
Add API functions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-09 21:25:50 +02:00
yubiuser
48dd045d91
Remove webpage.sh ( #5357 )
2023-08-07 23:17:41 +02:00
Christian König
3c693c1da5
Apply suggestions from code review
...
Co-authored-by: DL6ER <dl6er@dl6er.de >
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-06 12:04:55 +02:00
Christian König
7bb0ca59d1
Remove traces of /run/pihole
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-05 14:54:09 +02:00
Christian König
587a2a1c04
# allow all users to enter der directories
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-04 23:52:53 +02:00
Christian König
c360743d41
Re-add file/folder permissions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-04 21:12:40 +02:00
Christian König
8ef8a27583
Remove webpage.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-04 20:04:45 +02:00
Christian König
a3ea2cd8c3
User pihole should be allowed to edit all its files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-04 19:32:19 +02:00
Christian König
5ae0405446
Ensure pihole-FTL can write custom.list
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-08-03 20:46:01 +02:00
Adam Warner
eda83a4141
If ${USER} variable is blank, then populate it with whoami ( #5341 )
2023-07-18 09:12:25 +01:00
Adam Warner
03a1f4370a
Merge development -> development-v6 ( #5345 )
2023-07-18 09:11:55 +01:00
Adam Warner
f270642d67
Merge branch 'development' into development-v6-merge-dev
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-18 08:15:40 +01:00
DL6ER
2a03671fb9
Reinstall gravity cleanup on error
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-07-18 08:13:36 +01:00
DL6ER
375d4d9bc1
Add type as new field of view vw_adlist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-07-18 08:13:36 +01:00
DL6ER
35512c4dc9
Fix adlist.list migration step failing during tests
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-07-18 08:13:36 +01:00
DL6ER
00cbb8bc8a
Add antigravity support to gravity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-07-18 08:13:36 +01:00
Adam Warner
98c7d877ec
Update test dependencies (v5) ( #5343 )
2023-07-18 08:12:34 +01:00
Adam Warner
6edd6a4d55
if ${USER} variable is blank, then populate it with whoami
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-18 08:11:48 +01:00
Adam Warner
aec852fa51
Update test dependencies (v6) ( #5344 )
2023-07-18 08:11:37 +01:00
Adam Warner
e42c692ec7
Drop docker-compose from requirements.txt, it's not used. This was the only thing preventing us from using pyyaml 6.0.1 which fixes issues we were seeing with tests not running ( https://github.com/yaml/pyyaml/pull/702 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-18 08:04:33 +01:00
Adam Warner
7e240251d5
Drop docker-compose from requirements.txt, it's not used. This was the only thing preventing us from using pyyaml 6.0.1 which fixes issues we were seeing with tests not running ( https://github.com/yaml/pyyaml/pull/702 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-18 08:03:05 +01:00
Adam Warner
ab2aea7bbf
Bump tox from 4.6.2 to 4.6.4 in /test ( #5339 )
2023-07-16 22:52:26 +01:00
dependabot[bot]
8dd8f989ab
Bump tox from 4.6.2 to 4.6.4 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.6.2 to 4.6.4.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.6.2...4.6.4 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-16 21:44:31 +00:00
Adam Warner
762256a71b
Bump pytest from 7.3.2 to 7.4.0 in /test ( #5340 )
2023-07-16 22:43:43 +01:00
Adam Warner
78cd440a61
Bump actions/setup-python from 4.6.1 to 4.7.0 ( #5338 )
2023-07-16 22:42:53 +01:00
Adam Warner
30661fedcb
Sync master back into development ( #5337 )
2023-07-16 22:36:32 +01:00
dependabot[bot]
a3955a7ebb
Bump pytest from 7.3.2 to 7.4.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.3.2 to 7.4.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.3.2...7.4.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-16 21:36:15 +00:00
dependabot[bot]
e295997d51
Bump actions/setup-python from 4.6.1 to 4.7.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.6.1 to 4.7.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.6.1...v4.7.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-16 21:36:02 +00:00
Adam Warner
8495565a6f
Update dependabot.yml ( #5334 )
2023-07-16 22:35:34 +01:00
Adam Warner
cefbfdf2a4
Bump actions/setup-python from 4.6.1 to 4.7.0 ( #5336 )
2023-07-16 22:24:01 +01:00
dependabot[bot]
91dabc574d
Bump actions/setup-python from 4.6.1 to 4.7.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.6.1 to 4.7.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.6.1...v4.7.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-15 10:30:37 +00:00
Adam Warner
80091232a7
Add missing env:, tweak conditional
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-13 17:43:48 +01:00
Adam Warner
924de1d9ed
Update dependabot.yml
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-11 23:51:28 +01:00
yubiuser
60a7c50120
Bump tox from 4.6.3 to 4.6.4 in /test ( #5332 )
2023-07-08 14:55:31 +02:00
dependabot[bot]
a01d31e25d
Bump tox from 4.6.3 to 4.6.4 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.6.3 to 4.6.4.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.6.3...4.6.4 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-07-08 10:15:54 +00:00
DL6ER
2d4d9078c4
Add /var/log/pihole/webserver.log to the logrotate scripts ( #5329 )
2023-07-06 19:27:49 +02:00
DL6ER
64319fa96e
Add /var/log/pihole/webserver.log to the logrotate scripts. While it may be empty for most, it can grow quickly if either API or TLS debugging is enabled (it can quickly reach several hundreds of MB per day when debugging TLS)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-07-05 22:11:56 +01:00
Adam Warner
047017dc6a
Set new gravity database version to 16 ( #5328 )
2023-07-04 08:32:50 +01:00
Adam Warner
c557f29db2
Set new gravity database version to 16, which was missed in 5459daa
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-07-03 23:01:27 +01:00
yubiuser
1eb4ad8238
Bump pytest from 7.3.2 to 7.4.0 in /test ( #5325 )
2023-06-25 11:46:08 +02:00
dependabot[bot]
5490625d8d
Bump pytest from 7.3.2 to 7.4.0 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.3.2 to 7.4.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.3.2...7.4.0 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-24 16:03:56 +00:00
yubiuser
5389ef1a70
Bump tox from 4.6.2 to 4.6.3 in /test ( #5324 )
2023-06-24 18:03:17 +02:00
dependabot[bot]
198ca65f7d
Bump tox from 4.6.2 to 4.6.3 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.6.2 to 4.6.3.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.6.2...4.6.3 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-24 10:57:28 +00:00
Adam Warner
04c3f7a603
Development -> development-v6 ( #5321 )
2023-06-18 22:21:11 +01:00
Adam Warner
85d256d53c
Switch to new branch name for FTL v6 development ( #5319 )
2023-06-18 22:17:39 +01:00
Adam Warner
ca66c1ea9c
Switch to new branch name for FTL v6 development
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-06-18 22:05:18 +01:00
Adam Warner
0fa5c62450
Add code to remove old lighttpd config files left over from v5. ( #5314 )
2023-06-18 21:53:07 +01:00
Adam Warner
a3bb3872bf
adlist table now contains 11 columns, not 10.
...
Co-authored-by: Christian König <ckoenig@posteo.de >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-06-18 21:10:12 +01:00
Adam Warner
d637d2a7a5
Simplify nested if statements.
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-06-18 21:10:06 +01:00
Adam Warner
001f2012a2
Update automated install/basic-install.sh
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2023-06-18 15:45:30 +01:00
Adam Warner
c39cb8cfe0
Escape the sed command for removing a line in fed/centos lighttpd.conf
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-06-18 15:45:30 +01:00
Adam Warner
d5013bfd6c
Add code to remove old lighttpd config files left over from v5. Web config is all dealt with by FTL now
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-06-18 15:45:30 +01:00
yubiuser
7bc1126978
Bump tox from 4.6.0 to 4.6.2 in /test ( #5317 )
2023-06-17 19:46:04 +02:00
dependabot[bot]
7a66083e68
Bump tox from 4.6.0 to 4.6.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.6.0 to 4.6.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.6.0...4.6.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-17 11:35:38 +00:00
yubiuser
17fffa4e49
Bump pytest from 7.3.1 to 7.3.2 in /test ( #5318 )
2023-06-17 13:35:00 +02:00
dependabot[bot]
3fd7b4ee24
Bump pytest from 7.3.1 to 7.3.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.3.1 to 7.3.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.3.1...7.3.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-17 10:59:42 +00:00
DL6ER
5459daa03d
Add abp_entries column (default 0) to the adlist table for newly created gravity databases. This updates the gravity database version to 16
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-06-15 09:36:17 +02:00
DL6ER
306df56203
Add tests for Debian 12 ( #5312 )
2023-06-11 08:46:59 +02:00
Christian König
117c15319d
Add tests for Debian 12
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-10 23:03:43 +02:00
yubiuser
b8419ba3c5
Bump tox from 4.5.2 to 4.6.0 in /test ( #5311 )
2023-06-10 14:14:59 +02:00
yubiuser
8347de1cc6
Bump actions/checkout from 3.5.2 to 3.5.3 ( #5310 )
2023-06-10 14:06:32 +02:00
dependabot[bot]
8e481e27da
Bump tox from 4.5.2 to 4.6.0 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.5.2 to 4.6.0.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.5.2...4.6.0 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-10 11:00:35 +00:00
dependabot[bot]
7d3f354dd7
Bump actions/checkout from 3.5.2 to 3.5.3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.5.2...v3.5.3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-10 10:57:12 +00:00
DL6ER
e0d7e5df85
Install binutils as installer deps (needed to pick correct architecture for FTL)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-06-09 19:30:28 +02:00
DL6ER
913be6c349
Print detected CPU arch
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-06-09 19:01:14 +02:00
DL6ER
1c4e58efe3
Use exact architecture matching binaries where appropriate
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-06-09 15:53:02 +02:00
DL6ER
9c27e4766d
Decide which FTL architecture to pick by by installed architectures rather than by detected processor (this may be wrong in an emulated Docker environment)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-06-08 22:17:14 +02:00
Adam Warner
eb0bd026d7
Sync master back into development ( #5296 )
2023-06-04 22:16:58 +01:00
Adam Warner
7e95371fe8
Do not remove -all|exact when not surrounded by space in query.sh ( #5300 )
2023-06-04 22:16:35 +01:00
Adam Warner
499998c537
Remove option to set static IP address if DHCPCD is installed ( #5111 )
2023-06-04 22:09:04 +01:00
Christian König
8bf4ab0cd6
Remove option to set static IP address if DHCPCD is installed
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-04 22:59:44 +02:00
Christian König
088b2c2920
Do not remove -all|excat when not sourrounded by space in query.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-04 22:57:31 +02:00
yubiuser
34a261e522
Bump tox from 4.5.1 to 4.5.2 in /test ( #5304 )
2023-06-04 22:15:36 +02:00
Christian König
ba3e290915
Fix shellcheck errors
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-04 21:21:48 +02:00
Christian König
53fb7ae0ef
Use shellcheck in smoke-tests. RIP stickler
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-04 21:06:44 +02:00
Christian König
366345e87e
Fix no_installs
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-04 20:31:48 +02:00
DL6ER
667418c71d
Use new FTL binary names
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-06-04 20:02:38 +02:00
dependabot[bot]
b0fa3795e9
Bump tox from 4.5.1 to 4.5.2 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.5.1 to 4.5.2.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.5.1...4.5.2 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-06-03 10:58:23 +00:00
Christian König
ec82aec55f
centos_common_support.py was removed
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-02 00:13:57 +02:00
Christian König
7da57c6acd
Don't check and install old FTL config file
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-02 00:08:50 +02:00
Christian König
0becc7615a
Run prestart
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-01 23:51:03 +02:00
Christian König
a4322c624f
Fix gravity in tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-01 22:00:40 +02:00
Christian König
001024b4da
Fix Tests No2
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-01 20:41:54 +02:00
Adam Warner
792b0d419b
Test fixes
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-06-01 19:29:47 +01:00
Christian König
7351a4d3b1
Merge branch 'development' into development-v6
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-01 15:45:05 +02:00
Christian König
364537b324
Use env variable
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-01 15:15:49 +02:00
Christian König
b2c73f8325
Do not try to remove stale lables on PRs
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-06-01 15:15:49 +02:00
Christian König
f7b9d70054
Remove man page for pihole-FTL
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-30 21:39:10 +02:00
Adam Warner
6a45c6a8e0
v5.17.1 ( #5295 )
2023-05-30 19:27:52 +01:00
DL6ER
c1335c6852
Fix gravity adlist status not being updated ( #5294 )
2023-05-30 19:02:07 +02:00
DL6ER
6c302c9bc8
Adlist properties need to be stored in the new ("temp") database rather than the old.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-05-30 17:01:58 +02:00
yubiuser
fc67de8c19
Fix Faulty Regex pattern in custom DNS domain validation ( #5291 )
2023-05-29 09:13:33 +02:00
Adam Warner
494734bf27
Add in a test case
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-28 23:48:16 +01:00
Adam Warner
11679a5188
@MrDuck2742 dropped a ] on the floor without me seeing. I picked it up and put it back again
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-28 23:31:51 +01:00
Adam Warner
aa9b4530c8
Sync master back into development ( #5289 )
2023-05-28 13:08:25 +01:00
Adam Warner
bea63f9d2d
Pi-hole v5.17 ( #5288 )
2023-05-28 12:01:25 +01:00
DL6ER
137e6dc184
Remove all the undocumented now useless stuff from pihole -a
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-05-28 09:01:02 +02:00
DL6ER
de5e6e4163
Add support for RISC-V 64-bit installs ( #5196 )
2023-05-28 07:44:06 +02:00
DL6ER
350c9e02ea
Add Ubuntu 23 to test suite ( #5284 )
2023-05-28 07:39:34 +02:00
yubiuser
f59610081e
remove outdated comments ( #5227 )
2023-05-27 22:41:11 +02:00
yubiuser
50d67dce73
Bump actions/setup-python from 4.6.0 to 4.6.1 ( #5286 )
2023-05-27 15:22:47 +02:00
yubiuser
43ba31f402
Bump pytest-testinfra from 8.0.0 to 8.1.0 in /test ( #5287 )
2023-05-27 14:45:28 +02:00
dependabot[bot]
3ae72114c7
Bump pytest-testinfra from 8.0.0 to 8.1.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 8.0.0 to 8.1.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/8.0.0...8.1.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-27 10:59:32 +00:00
dependabot[bot]
783f9e5569
Bump actions/setup-python from 4.6.0 to 4.6.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.6.0...v4.6.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-27 10:56:41 +00:00
Christian König
b5800ef718
Remove getFTLAPIPort() function and fix pihole status
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-27 11:53:00 +01:00
Christian König
44bfb8ebf0
Remove the ability to reboot/shutdown via webpage.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-27 11:53:00 +01:00
Adam Warner
ea748822ef
REVISIT: I don't _think_ this line is nessacery. Why should gravity restart FTL if it is offline? It might be offline on purpose.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:53:00 +01:00
Adam Warner
c0e352094d
REVISIT: Remove some references to setupVars (some files can probably go entirely...)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
a91eb48d48
Remove some code from gravity that gets values from setupVars.conf / pihole-FTL.conf - use getFTLConfigValue from utils.sh instead
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
6b1c8a7fff
@DL6ER changed the config key names...
...
Remove superfluous test
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
7cbe713873
REVISIT: Don't rely on existence of setupVars.conf
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
0e8f285f4f
Always assume that the web interface will be installed.
...
We could revist this again in future if we decide that there should still be a choice to install the interface or not
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
cd17040f95
setupVars.conf not existing is no longer a critical error
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
2784b267ec
pihole command: read values from pihole-FTL instead of setupvars.conf
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
dbc6b814b2
Should not need to reloadDNS manually any more as FTL will detect that it needs to reload by itself
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
0568a69d83
Use WEBPORT instead of PRIVACY_LEVEL to set the web port...
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Christian König
3cb3adc5ca
Fix setting webpassword via pihole -a -p
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-27 11:51:16 +01:00
DL6ER
3695610300
Allow running pihole -g without root (run as user pihole)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-05-27 11:51:16 +01:00
Adam Warner
bf16fe4a37
Remove the EPEL related tests on centos/fedora - no longer neccasery
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
9bf372ef43
[REVISIT] Remove test_installPihole_fresh_install_readableBlockpage for now. We may be able to recylcle it later, but I have my doubts
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
414df5b372
Remove no longer required checks in test_installPihole_fresh_install_readableFiles
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
5e431210fd
[REVISIT] Remove test_setupVars_saved_to_file for now - it may no longer be needed as we move towards getting rid of the file.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
8f7c828407
No need for test_installPiholeWeb_fresh_install_no_errors
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
b8acccde90
Update comments on the move of /etc/dnsmasq.old -> /etc/dnsmasq.old to better reflect why we are doing it
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
019be067d9
Convert SetWebPassword to use new FTL config
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
632aead691
add wrappers to utils.sh for setting FTL config & add tests
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:16 +01:00
Adam Warner
e3ffec5762
Change when old configs are removed
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:15 +01:00
Adam Warner
0e558e4c36
Remove some code that installs the blockpage/sets up web directories
...
Remove some code that disables dnsmasq if it is running
Create dnsmasq.d directory if it does not exist
2023-05-27 11:51:15 +01:00
Adam Warner
31f16510e2
Clear out some no longer needed ftl/dnsmasq config code
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:15 +01:00
Adam Warner
d2d1195928
Needs tweaking, offer chance to change web interface port
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:15 +01:00
Adam Warner
c520b29326
some more lighttpd refs (tests can come later)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:15 +01:00
Adam Warner
31ee15200d
gut the install script of references to web server/lighttpd
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:15 +01:00
Adam Warner
9f31ab8a6f
Debug log does not need to check php/lighttpd
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-05-27 11:51:15 +01:00
DL6ER
23f2db01bb
Use list parsing functionality of FTL ( #5275 )
2023-05-27 12:48:26 +02:00
Adam Warner
82b60b09d4
Fix issue with Adding Local DNS Records does not add to /etc/pihole/custom.list when using grep 3.10 ( #5269 )
2023-05-27 11:28:19 +01:00
Christian König
5bdb089b7f
Add Ubuntu 23 to test suite
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-24 22:54:47 +02:00
DL6ER
c92826c152
Do not copy info table during pihole -g
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2023-05-24 21:32:34 +02:00
yubiuser
85e7fc5a0e
Bump pytest-testinfra from 7.0.0 to 8.0.0 in /test ( #5279 )
2023-05-20 17:05:33 +02:00
dependabot[bot]
10fe85933b
Bump pytest-testinfra from 7.0.0 to 8.0.0 in /test
...
Bumps [pytest-testinfra](https://github.com/pytest-dev/pytest-testinfra ) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-testinfra/releases )
- [Changelog](https://github.com/pytest-dev/pytest-testinfra/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-testinfra/compare/7.0.0...8.0.0 )
---
updated-dependencies:
- dependency-name: pytest-testinfra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-20 13:41:46 +00:00
yubiuser
412079a798
Bump pytest-xdist from 3.3.0 to 3.3.1 in /test ( #5278 )
2023-05-20 15:41:00 +02:00
dependabot[bot]
f9b29cfb62
Bump pytest-xdist from 3.3.0 to 3.3.1 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.3.0 to 3.3.1.
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.3.0...v3.3.1 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-20 11:02:15 +00:00
DL6ER
73733308ba
Use parseList function offered by pihole-FTL
2023-05-15 19:25:56 +02:00
yubiuser
614554f26f
Bump pytest-xdist from 3.2.1 to 3.3.0 in /test ( #5274 )
2023-05-13 14:01:05 +02:00
dependabot[bot]
8d91ca874b
Bump pytest-xdist from 3.2.1 to 3.3.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.2.1 to 3.3.0.
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.2.1...v3.3.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-13 11:01:21 +00:00
yubiuser
b075e25ab9
Remove forgotten variables ( #5273 )
2023-05-12 09:56:33 +02:00
Christian König
eaded9fdb1
Remove forgotten variables
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-11 22:16:21 +02:00
yubiuser
19d50b9669
Don't source the install script in webpage.sh ( #5270 )
2023-05-10 19:55:51 +02:00
yubiuser
8e5467de70
Remove unused code from query.sh ( #5266 )
2023-05-10 19:54:57 +02:00
yubiuser
fe1618d697
Don't use '--suffix' in mktemp ( #5272 )
2023-05-10 08:07:59 +02:00
Christian König
a3e610dbf2
Don't use '--suffix' in mktemp
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-10 06:52:51 +02:00
MrDuck2742
b8c3f6d999
Adding Local DNS Records does not add to /etc/pihole/custom.list
...
Fixes #5268
Signed-off-by: MrDuck2742 <jim@datachord.co.uk >
2023-05-08 04:41:53 +01:00
Christian König
e6ae2e98cc
Don't source the install script in webpage.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-07 13:21:23 +02:00
Adam Warner
654e111038
Sync master back into development ( #5221 )
2023-05-06 11:14:50 +01:00
yubiuser
cd638b102f
Filter ABP CSS selectors ( #5247 )
2023-05-04 12:01:20 +02:00
MichaIng
b74c6d5120
Add support for RISC-V 64-bit installs
...
Signed-off-by: MichaIng <micha@dietpi.com >
2023-05-03 20:52:28 +02:00
Christian König
fd4e8766e4
Remove unused code from query.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-05-02 22:50:51 +02:00
yubiuser
c95d34389b
Bump tox from 4.4.12 to 4.5.1 in /test ( #5264 )
2023-04-29 18:33:35 +02:00
dependabot[bot]
83afff953f
Bump tox from 4.4.12 to 4.5.1 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.4.12 to 4.5.1.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.4.12...4.5.1 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-29 10:57:31 +00:00
yubiuser
b8ffd2700c
Bump actions/checkout from 3.4.0 to 3.5.2 ( #5261 )
2023-04-23 07:31:05 +02:00
dependabot[bot]
9bcb323568
Bump actions/checkout from 3.4.0 to 3.5.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.4.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.4.0...v3.5.2 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-22 13:37:35 +00:00
yubiuser
e9e0aa37f4
Bump actions/setup-python from 4.5.0 to 4.6.0 ( #5260 )
2023-04-22 15:36:15 +02:00
dependabot[bot]
0df06dc2fb
Bump actions/setup-python from 4.5.0 to 4.6.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.5.0...v4.6.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-22 10:56:37 +00:00
Dan Schaper
53d09417dd
Add Fedora 38 to the test suite ( #5257 )
2023-04-19 14:01:17 -07:00
Christian König
eed4b70512
Add Fedora 38 to the test suite
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-19 21:03:12 +02:00
Dan Schaper
8fbad01d45
Trigger stale workflow on issue comments to remove stale label immediately ( #5252 )
2023-04-17 12:53:23 -07:00
Christian König
1a9dbec83c
Use env variable
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-17 20:52:51 +02:00
Christian König
5985d506f1
Run seperate job to trigger removal on comments
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-16 15:04:26 +02:00
yubiuser
fc706b6cbb
Bump actions/stale from 7.0.0 to 8.0.0 ( #5231 )
2023-04-15 14:52:16 +02:00
yubiuser
7eeedf1b5f
Bump pytest from 7.2.2 to 7.3.1 in /test ( #5253 )
2023-04-15 14:51:54 +02:00
dependabot[bot]
364fd38996
Bump pytest from 7.2.2 to 7.3.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.2.2 to 7.3.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.2.2...7.3.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-15 12:34:19 +00:00
yubiuser
b412e88b02
Bump tox from 4.4.7 to 4.4.12 in /test ( #5254 )
2023-04-15 14:33:42 +02:00
yubiuser
11725a0999
Bump actions/checkout from 3.4.0 to 3.5.2 ( #5255 )
2023-04-15 14:32:41 +02:00
dependabot[bot]
d065afdbb1
Bump actions/checkout from 3.4.0 to 3.5.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.4.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.4.0...v3.5.2 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-15 10:57:41 +00:00
dependabot[bot]
c36d0257ec
Bump tox from 4.4.7 to 4.4.12 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.4.7 to 4.4.12.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.4.7...4.4.12 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-15 10:57:39 +00:00
Christian König
87a612f884
Trigger stale workflow on issue comments to remove stale label immediately
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-15 10:28:39 +02:00
Christian König
dd3a7a4edb
Only delete lines containing separator when preceded by a letter to reduce false positiv (deleting valid comments)
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-08 14:59:26 +02:00
Christian König
d10d59303e
There is no ! but an $ rule
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-07 21:44:49 +02:00
Adam Warner
b9cf2d9959
Remove special handling of pgl.yoyo.org ( #5249 )
2023-04-07 12:46:19 +01:00
Christian König
aaf828117d
Remove unecessary $cmd_ext
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-07 12:36:50 +02:00
Christian König
9c4e74ffa7
Remove special handling of pgl.yoyo.org
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-07 12:23:11 +02:00
Christian König
2a0f720153
Don't delete lines containing / as they should count as invalid
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-07 10:25:25 +02:00
Christian König
cc17fe18a9
Remove lines with ABP extended CSS selector
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-07 10:14:59 +02:00
Christian König
61ff5b2c76
Unifiy sed commands
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-04-07 09:44:31 +02:00
Adam Warner
56eae4afbe
Allow TLD blocking using ABP style ( #5240 )
2023-03-29 21:48:15 +01:00
RD WebDesign
66bfa606a7
Using a better text for the comment
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-29 14:17:41 -03:00
RD WebDesign
32fb2e69ff
Spliting the regex into TLD_pattern and subdomain_pattern
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-29 00:05:01 -03:00
RD WebDesign
c71460e4b6
Allow TLD blocking using ABP style
...
This validates patterns without dots (only for abp style), allowing TLDs to be blocked
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-28 17:21:50 -03:00
Dan Schaper
d885e92674
Hotfix Core v5.16.2 ( #5235 )
2023-03-25 12:02:26 -07:00
Dan Schaper
9d4a69c1d0
Fix for gravity's unchecked resource consumption. ( #5234 )
2023-03-25 11:39:49 -07:00
Adam Warner
0656ceb149
Speed things up a bit with some humble greps. Consolodate regexes and remove the need for so many mapfile/arrays
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Use temp files for parsing and remove when done.
Always rm the non-domains temp file.
exit 1 if gravity database creation fails.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Co-authored-by: DL6ER <dl6er@dl6er.de >
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2023-03-25 11:19:23 -07:00
dependabot[bot]
95b12bad34
Bump actions/stale from 7.0.0 to 8.0.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 7.0.0 to 8.0.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v7.0.0...v8.0.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-25 10:56:35 +00:00
ipitio
fa116389c2
remove old comments
...
Signed-off-by: ipitio <21136719+ipitio@users.noreply.github.com >
2023-03-23 01:23:35 +00:00
Adam Warner
8ca5788561
Release v5.16.1 ( #5226 )
2023-03-22 22:19:00 +00:00
Adam Warner
1dc33129e5
Fix getting 'privacylevel' ( #5224 )
2023-03-22 22:11:50 +00:00
Christian König
c96463bda2
Fix getting 'privacylevel'
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-03-22 23:00:10 +01:00
Dan Schaper
edbaf6d697
Revert "Ignore commented lines when reading PRIVACYLEVEL from config file" ( #5223 )
2023-03-22 14:59:09 -07:00
Adam Warner
58275ecd13
Revert "Ignore commented lines when reading PRIVACYLEVEL from config file"
2023-03-22 21:52:39 +00:00
Adam Warner
c6d1137eb0
Release v5.16 ( #5220 )
2023-03-22 21:33:03 +00:00
Dan Schaper
fb032ea6e7
Ignore commented lines when reading PRIVACYLEVEL from config file ( #5177 )
2023-03-22 12:23:40 -07:00
Dan Schaper
536b3497c9
Remove ftl systemd service and optionally service override files in uninstall script ( #5183 )
2023-03-22 12:07:55 -07:00
Dan Schaper
8f09a1d837
Add configurable GRAVITY_TMPDIR variable into setupVars ( #5216 )
2023-03-22 12:05:22 -07:00
Dan Schaper
c255082ef5
Declaring all local variables under the function declaration line ( #5219 )
2023-03-22 11:01:52 -07:00
kot0dama
76b7453f90
Add configurable GRAVITY_TMPDIR variable into setupVars
...
Signed-off-by: Loïc Gomez <89980752+kot0dama@users.noreply.github.com >
2023-03-22 19:40:24 +09:00
RD WebDesign
66ed7c9ea3
Declaring all local variables under the function declaration line
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-21 16:34:50 -03:00
Adam Warner
ac2f13adef
Allow pihole -q to match subdomains using ABP style domains ( #5210 )
2023-03-21 15:39:11 +00:00
RD WebDesign
6b919f3a2e
Removing unnecessary commas
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-21 12:27:20 -03:00
Adam Warner
4d21bae669
Fix addKey to handle substrings of existing keys ( #5211 )
2023-03-21 12:31:01 +00:00
yubiuser
7ea0bbb85c
Bump tox from 4.4.6 to 4.4.7 in /test ( #5215 )
2023-03-18 13:58:43 +01:00
yubiuser
3ddec99f4a
Bump pytest-xdist from 3.2.0 to 3.2.1 in /test ( #5214 )
2023-03-18 13:57:49 +01:00
yubiuser
e1f12668fa
Bump actions/checkout from 3.3.0 to 3.4.0 ( #5213 )
2023-03-18 13:53:15 +01:00
dependabot[bot]
686da5a948
Bump tox from 4.4.6 to 4.4.7 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.4.6 to 4.4.7.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.4.6...4.4.7 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-18 10:58:57 +00:00
dependabot[bot]
8a2829de87
Bump pytest-xdist from 3.2.0 to 3.2.1 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.2.0 to 3.2.1.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.2.0...v3.2.1 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-18 10:58:49 +00:00
dependabot[bot]
3a592e56ba
Bump actions/checkout from 3.3.0 to 3.4.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.3.0...v3.4.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-18 10:56:52 +00:00
William Blew
3c91b6558d
restore the addKey comment, reworded for anchors
...
Per @dschaper, restore the addKey clarifying comment. It has
been reworded to describe the use of anchors where before it
referenced using grep's 'match only an entire line' argument.
Signed-off-by: William Blew <william@kulian.org >
2023-03-17 11:50:53 -07:00
William Blew
b9a6970bfd
Fix addKey to handle substrings of existing keys
...
Fix addKey to handle the case where a key is being added, and that key
is the leading substring of an already existing key within that file.
For example: add "server=192.168.1.1", when "server=192.168.1.178"
already exists within the /etc/dnsmasq.d/01-pihole.conf file.
Check pihole docker with PIHOLE_DNS="192.168.1.178;192.168.1.1". Its
/etc/dnsmasq/01-pihole.conf will be missing its second server= entry.
Add the test_key_addition_substr, to test addKey when
its adding a substring key of an existing key in the file.
Signed-off-by: William Blew <william@kulian.org >
2023-03-17 11:50:52 -07:00
RD WebDesign
20f8c6af3c
Search for ABP entries only if they exist in gravity.db
...
and use `abp_domains` property.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-17 14:17:53 -03:00
RD WebDesign
c35ed68051
Allow pihole -q matching ABP subdomains
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-03-14 17:31:39 -03:00
Dan Schaper
75a32d22a3
Allow limited parsing of ABP style adlists ( #5179 )
2023-03-14 13:23:03 -07:00
Christian König
71e262c37f
Revert "Allow final dot (root zone)"
...
This reverts commit 0b5da9f0da .
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-03-14 19:50:53 +01:00
Dan Schaper
04b909c837
Convert domain to lowercase in pihole -q ( #5200 )
2023-03-07 17:49:51 -08:00
Christian König
309ee78903
Use distinct variabled
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-03-07 20:40:16 +01:00
Christian König
d6f5552ccf
Convert domain to lowercase in pihole -q
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-03-06 21:52:54 +01:00
yubiuser
67a973a17d
Bump pytest from 7.2.1 to 7.2.2 in /test ( #5194 )
2023-03-04 13:44:43 +01:00
dependabot[bot]
0b60601f86
Bump pytest from 7.2.1 to 7.2.2 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.2.1 to 7.2.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.2.1...7.2.2 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-03-04 10:57:42 +00:00
Christian König
0b5da9f0da
Allow final dot (root zone)
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-03-04 10:36:07 +01:00
Dan Schaper
0589641bf0
GitHub Workflows security hardening ( #5053 )
2023-03-02 14:36:00 -08:00
Alex
ddf972cede
build: harden workflow permissions
...
Signed-off-by: Alex <aleksandrosansan@gmail.com >
2023-03-02 22:18:00 +01:00
MichaIng
73de49323c
Remove systemd service and optionally override configs on uninstall
...
This has been forgotten when adding the new native systemd service.
Signed-off-by: MichaIng <micha@dietpi.com >
2023-02-27 16:51:32 +01:00
Christian König
16385af3ef
Use dedicated pattern variable to make RegEx reusable
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-26 21:16:45 +01:00
Christian König
6cb0be82ca
Add flag abp_domains into info table to signal if abp domains have been found
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-26 10:34:17 +01:00
yubiuser
2dd31ce6ee
Bump tox from 4.4.5 to 4.4.6 in /test ( #5187 )
2023-02-25 14:25:05 +01:00
dependabot[bot]
31a9e18997
Bump tox from 4.4.5 to 4.4.6 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.4.5 to 4.4.6.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.4.5...4.4.6 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-25 10:57:18 +00:00
Christian König
821c7dc190
Add info when list cotains ABP style domains
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-24 22:18:41 +01:00
Christian König
eedd93d782
Remove temporary files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-24 21:55:22 +01:00
Adam Warner
c5faf3d174
Use ',' as the separator char in query rather than the default '|' as we now expect some valid results to contain '|'
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-02-22 21:21:38 +01:00
Adam Warner
1f3f849106
Remove lines starting with ! or [ to account for ABP style comments and header
...
Also splits the piped "one-liner" in ParseFileIntoDomains into individually commented commands (makes for easier reading and debugging)
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-02-22 21:21:38 +01:00
Christian König
ca74152d1d
Allow adding ABP style blocklists
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-22 21:21:13 +01:00
Christian König
4fd0f15d90
Ignore commented lines when reding PRIVACYLEVEL from config file
...
Create dedicated getVal function in utils.sh as it might be useful somewhere else
Account for tailing comments and $key not being on the first line
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-21 21:03:55 +01:00
Adam Warner
b9f19fc357
Sync master back into development ( #5166 )
2023-02-21 20:03:27 +00:00
Dan Schaper
2380359270
Bump pytest-xdist from 3.1.0 to 3.2.0 in /test ( #5170 )
2023-02-21 11:40:13 -08:00
Dan Schaper
d75adb49f4
Use buildx to create docker test images ( #5178 )
2023-02-16 13:55:00 -08:00
Christian König
90da155053
Use buildx to create docker test images
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-16 21:43:30 +01:00
yubiuser
2a61a03bdf
Don't use intermediate strings to filter false positives in gravity ( #5176 )
2023-02-16 19:02:43 +01:00
Christian König
a4bdf2454b
Don't use intermediate strings to filter false positives in gravity
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-16 10:39:21 +01:00
Christian König
4b503a080b
Revert "Use new worksteal distribution algorithm"
...
This reverts commit 46fe37b4da .
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-14 22:14:29 +01:00
Christian König
46fe37b4da
Use new worksteal distribution algorithm
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-14 21:12:12 +01:00
dependabot[bot]
d6275cdd7c
Bump pytest-xdist from 3.1.0 to 3.2.0 in /test
...
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases )
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: pytest-xdist
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-13 09:04:19 +00:00
yubiuser
45cab12392
Bump tox from 4.4.4 to 4.4.5 in /test ( #5169 )
2023-02-13 10:01:34 +01:00
dependabot[bot]
5ecdfb53c2
Bump tox from 4.4.4 to 4.4.5 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.4.4 to 4.4.5.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.4.4...4.4.5 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-11 10:57:20 +00:00
Adam Warner
d86b325dfe
Only search for "OVERWRITTEN BY PI-HOLE" when checking inside lighttpd.conf ( #5167 )
2023-02-10 20:57:03 +00:00
Adam Warner
c65ea9c47c
Adam does not always think things through completly. He will go and sit on the naughty step now.
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-02-10 20:49:58 +00:00
Adam Warner
741717aa38
Pi-hole core v5.15.4 ( #5165 )
2023-02-10 18:59:18 +00:00
Adam Warner
2d13cd2f1d
Bump tox from 4.3.5 to 4.4.4 in /test ( #5159 )
2023-02-09 18:35:28 +00:00
Adam Warner
788e7cc777
Add pihole-admin.conf to debug log ( #5144 )
2023-02-09 18:35:02 +00:00
Adam Warner
0ac89ac2e3
Only source versions file if the file exits ( #5157 )
2023-02-09 18:34:09 +00:00
dependabot[bot]
e5ea361b53
Bump tox from 4.3.5 to 4.4.4 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.3.5 to 4.4.4.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.3.5...4.4.4 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-02-04 10:01:16 +00:00
yubiuser
df0155abe1
Tweak old pihole lighttpd config warning message to better reflect it's usage ( #5154 )
2023-02-03 00:37:28 +01:00
Christian König
ca00ffa101
Only source versions file if the file exits
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-02-02 11:58:58 +01:00
Adam Warner
3ad8965959
Tweak old pihole lighttpd config warning message to better reflect the consequences of making changes to the file
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-02-01 17:38:21 +00:00
Adam Warner
460f83580e
Sync master back into development ( #5151 )
2023-01-25 21:33:39 +00:00
Adam Warner
c7ad7113d7
Hotfix v5.15.3 ( #5150 )
2023-01-25 21:25:30 +00:00
Adam Warner
0a6ebadb52
Change lighttpd options min_procs value to 1 ( #5149 )
2023-01-25 18:43:32 +00:00
RD WebDesign
b9e401aaa3
Change min_procs value to 1
...
The original configuration used the default `min_procs=<max_procs_value>`.
A recent change set this value to zero, but a lot of systems started to
receive error messages about the socket file and in some systems lighttpd
wasn't able to restart the PHP process, returning HTTP error 503.
Setting this to 1 fixed those errors.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-01-25 14:35:57 -03:00
Christian König
18ab94135f
Show all files (not their content) of the lighttpd config dirs
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-24 23:02:38 +01:00
Christian König
be0efa2332
Add lighttpd selftest
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-24 22:19:24 +01:00
Christian König
9bde5de601
Use conf-enabled instead of conf-available
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-24 21:59:13 +01:00
Adam Warner
db42ed1e4f
Sync master back into development ( #5148 )
2023-01-23 18:18:22 +00:00
Adam Warner
262ffe458b
Hotfix release ( #5147 )
2023-01-23 17:17:16 +00:00
Christian König
e59f5db145
Add pihole-admin.conf to debug log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-22 22:37:19 +01:00
Adam Warner
362c604744
Ensure that the directory /run/lighttpd exists, and that it is owned by www-data ( #5143 )
2023-01-22 19:19:19 +00:00
Adam Warner
68a03cc877
Ensure that /run/lighttpd exists and is owned by lighttpd user. It is likely that new installs will fail currently
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-22 18:05:05 +00:00
Adam Warner
671da760d3
Sync master back into development ( #5142 )
2023-01-22 17:15:05 +00:00
Adam Warner
3c3d913934
v5.15.1 ( #5141 )
2023-01-22 17:08:16 +00:00
Adam Warner
50be36400c
Always set lighttpd config dir permissions ( #5038 )
2023-01-22 15:56:29 +00:00
Adam Warner
5f9523afa6
Change php socket path back to /run/lighttpd/ from /tmp ( #5139 )
2023-01-22 11:08:56 +00:00
Adam Warner
81a31b9e7b
Reduce number of false positives when gravity unable to import domains - change the wording of the output ( #5128 )
2023-01-22 11:06:45 +00:00
yubiuser
d0affcb376
Cleanup if startup failed ( #5052 )
2023-01-22 09:30:17 +01:00
Adam Warner
9939cf1d77
Rename some of the variables to hopefully make the process a little clearer
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-21 23:57:49 +00:00
Adam Warner
ce7f926e92
Only remove the server.modules+= from new config if lighttpd version is < 1.4.56 ( #5133 )
2023-01-21 23:26:11 +00:00
Adam Warner
6b4f77bdfe
change socket path back to /run/lighttpd/* - possibly causing issues https://github.com/pi-hole/pi-hole/issues/5131
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-21 17:42:32 +00:00
Adam Warner
267792aa1e
Bump tox from 4.2.8 to 4.3.5 in /test ( #5138 )
2023-01-21 15:53:48 +00:00
Adam Warner
9331cbff4b
remove the access log configuration from lighttpd.conf.debian and .conf.fedora to prevent issues on upgrades (this is defined in pihole-admin.conf)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-21 14:25:06 +00:00
Adam Warner
d30a5f1b95
Get the lighttpd version from dpkg-query instead
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-21 13:53:56 +00:00
dependabot[bot]
d6e25403ee
Bump tox from 4.2.8 to 4.3.5 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.2.8 to 4.3.5.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.2.8...4.3.5 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-21 10:01:41 +00:00
Adam Warner
79f4a7cef0
Maintain a list of valid hostnames (taken from the top of StevenBlack's host file), and discount them when calculating the number of "invalid" domains in a given list
...
Soften the output message when reporting on unsuable domains
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-20 18:52:14 +00:00
Adam Warner
9ed3ede0d9
Run updatechecker after gravity ( #5137 )
2023-01-19 22:23:13 +00:00
Christian König
771b7cfcc7
Run updatechecker after gravity
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-19 21:41:32 +01:00
Adam Warner
7bb86e4118
Add a check for the version number of lighttpd. Only remove the server.modules += section of the new pihole-admin config if the version number is not greater than or equal to 1.4.56
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-18 22:12:29 +00:00
yubiuser
c992fd48b0
Remove leftover Fedora 35 tox file ( #5124 )
2023-01-16 22:28:47 +01:00
Christian König
afc8241c2c
Remove leftover Fedora 35 tox file
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-16 21:59:21 +01:00
Adam Warner
6cae37e720
Include mod_accesslog with new config ( #5121 )
2023-01-16 20:08:42 +00:00
Adam Warner
d604aec9f1
Remove fed 35 from test suite ( #5122 )
2023-01-16 20:08:22 +00:00
Adam Warner
bb4698429f
Remove fed 35 from test suite
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-16 13:54:38 +00:00
Adam Warner
634e3b0e46
mod_accesslog was ommited from the list of server modules, which causes a warning to be flashed up in the error log. Enabling this
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2023-01-16 13:36:11 +00:00
Adam Warner
21c7c8a008
Sync master back into development ( #5119 )
2023-01-15 20:07:20 +00:00
Adam Warner
9048429bbb
v5.15 ( #5082 )
2023-01-15 20:02:04 +00:00
Adam Warner
9c33fcb32a
Bump pytest from 7.2.0 to 7.2.1 in /test ( #5117 )
2023-01-14 18:24:58 +00:00
dependabot[bot]
eb1f2ac01c
Bump pytest from 7.2.0 to 7.2.1 in /test
...
Bumps [pytest](https://github.com/pytest-dev/pytest ) from 7.2.0 to 7.2.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases )
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst )
- [Commits](https://github.com/pytest-dev/pytest/compare/7.2.0...7.2.1 )
---
updated-dependencies:
- dependency-name: pytest
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-14 18:08:40 +00:00
Adam Warner
d88e940a57
Bump tox from 4.0.17 to 4.2.8 in /test ( #5116 )
2023-01-14 18:04:53 +00:00
Adam Warner
f27f796b34
Adjusting fastcgi.server config ( #5103 )
2023-01-14 18:04:25 +00:00
dependabot[bot]
318ee3b7d3
Bump tox from 4.0.17 to 4.2.8 in /test
...
Bumps [tox](https://github.com/tox-dev/tox ) from 4.0.17 to 4.2.8.
- [Release notes](https://github.com/tox-dev/tox/releases )
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst )
- [Commits](https://github.com/tox-dev/tox/compare/4.0.17...4.2.8 )
---
updated-dependencies:
- dependency-name: tox
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-14 17:54:02 +00:00
Adam Warner
f894585a2e
Sync master back into development ( #5115 )
2023-01-14 17:53:59 +00:00
Adam Warner
ac2f63b138
Add pip ecosystem to dependabot ( #5093 )
2023-01-14 17:53:28 +00:00
RD WebDesign
be8f25f8b8
Adding errorlog and accesslog options
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-01-14 14:44:27 -03:00
RD WebDesign
c85e4227cf
Remove duplicated fastcgi.server config
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-01-14 14:44:16 -03:00
Adam Warner
c9042704d5
Add action to close stale PR ( #5098 )
2023-01-14 17:22:13 +00:00
Adam Warner
57f29a2c5d
Tweak get_directories_recursive ( #5105 )
2023-01-14 17:21:24 +00:00
Adam Warner
142e9f4a1a
Remove leftover from query.sh ( #5112 )
2023-01-14 17:19:35 +00:00
Adam Warner
0c65c27e0c
Bump actions/setup-python from 4.4.0 to 4.5.0 ( #5114 )
2023-01-14 13:23:22 +00:00
dependabot[bot]
4a53e56bd2
Bump actions/setup-python from 4.4.0 to 4.5.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.4.0...v4.5.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-14 10:00:35 +00:00
Christian König
d349a4640f
Remoce leftover from query.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-12 20:24:08 +01:00
Adam Warner
dfcdb1a747
Bump actions/checkout from 3.2.0 to 3.3.0 ( #5110 )
2023-01-07 13:48:10 +00:00
dependabot[bot]
e05ef73011
Bump actions/checkout from 3.2.0 to 3.3.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.2.0...v3.3.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-01-07 10:00:41 +00:00
RD WebDesign
2c29b25782
More detailed comments
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2023-01-06 19:00:55 -03:00
Christian König
d87cad76fb
Tweak get_directories_recursive
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-04 12:41:53 +01:00
Christian König
9e47b61c8f
Apply suggestions from code review
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2023-01-03 21:20:22 +01:00
RD WebDesign
4413224a31
Add action to close stale PR
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-12-30 17:46:36 -03:00
Adam Warner
d882652a85
Create versions file before sourcing it ( #5097 )
2022-12-30 17:54:01 +00:00
Christian König
f73b965fcd
Create versions file before sourcing it
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-29 21:59:23 +01:00
yubiuser
fe598a05f6
Add pihole tail [arg] to man page ( #5095 )
2022-12-29 20:13:59 +01:00
Christian König
09977fdfec
Add pihole tail [arg] to man page
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-28 14:33:36 +01:00
Christian König
b9ebb05246
Set permission after we know the user wants to install the web server
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-28 13:42:57 +01:00
Adam Warner
955e36a955
Improve detection of incorrect lines during gravity ( #5009 )
2022-12-27 12:32:31 +00:00
Adam Warner
972591fe39
Update and set test suite python dependencies ( #5092 )
2022-12-27 12:17:55 +00:00
Christian König
14db88d6bb
Add pip ecosystem to dependabot
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-26 12:18:03 +01:00
Christian König
64d0621d2b
Update and set test suite python dependencies
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-26 12:15:16 +01:00
DL6ER
5dabdfe354
Bump actions/stale from 6.0.1 to 7.0.0 ( #5087 )
2022-12-24 19:00:30 +01:00
DL6ER
e7c0ca47b4
Bump actions/setup-python from 4.3.1 to 4.4.0 ( #5088 )
2022-12-24 19:00:13 +01:00
dependabot[bot]
2bb7c05ed1
Bump actions/setup-python from 4.3.1 to 4.4.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.3.1...v4.4.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-24 10:00:47 +00:00
dependabot[bot]
20ad03fe15
Bump actions/stale from 6.0.1 to 7.0.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 6.0.1 to 7.0.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v6.0.1...v7.0.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-24 10:00:43 +00:00
DL6ER
58231e55df
Shorten no merge conflict message ( #5085 )
2022-12-22 23:07:50 +01:00
Christian König
12674c0824
Shorten no merge conflict message
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-22 22:27:03 +01:00
Christian König
c59e11a332
Always set lighttpd config dir permissions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-22 12:54:15 +01:00
Adam Warner
ec1d4c5500
lighttpd: do not overwrite /etc/lighttpd/lighttpd.conf (On new installs) ( #5075 )
2022-12-19 23:36:23 +00:00
Glenn Strauss
34f45d011d
lighttpd: do not install obsolete 404 handler
...
(/var/www/html/pihole/ dir and contents are still removed in uninstall)
(/var/www/html/index.lighttpd.orig is still removed in uninstall)
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-19 17:53:20 -05:00
Glenn Strauss
539f9d4da0
lighttpd: remove pihole block page error handler
...
remove obsolete pihole block page error handler
x-ref:
Remove the advanced functionality of the 404 page (Blockpage)
https://github.com/pi-hole/pi-hole/pull/3910
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-19 17:53:14 -05:00
Glenn Strauss
c6342ed84c
lighttpd: do not overwrite /etc/lighttpd/lighttpd.conf
...
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-19 16:19:03 -05:00
Adam Warner
9072a6a7f0
add Fedora 37 to distro-test in .github/workflows/test.yml ( #5067 )
2022-12-19 20:08:11 +00:00
Adam Warner
3b5d10d087
Sync master back into development ( #5078 )
2022-12-19 20:07:27 +00:00
Glenn Strauss
0d5d3a1b22
lighttpd: remove obsolete exclusion of letsencrypt.conf
...
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-19 14:56:27 -05:00
Adam Warner
8d2e023ec0
Add merge-conflict workflow ( #5071 )
2022-12-19 19:53:19 +00:00
Adam Warner
4a1473aee9
Create new lighttpd pihole-admin.conf for admin interface ( #5065 )
2022-12-19 19:52:28 +00:00
Glenn Strauss
78f9e38425
lighttpd: test for /etc/lighttpd/conf*/pihole-admin.conf
...
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-19 02:34:53 -05:00
Glenn Strauss
08c7691d1e
lighttpd pihole-admin.conf for admin interface
...
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-19 02:34:29 -05:00
Glenn Strauss
62bf9957dc
lighttpd conf: collect ^/admin/ conditions
...
move a sub-condition to be a nested condition under ^/admin/
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-18 12:53:05 -05:00
Glenn Strauss
dafc9983f5
lighttpd include external.conf using file glob
...
lighttpd 1.4.40 and later support 'include' using file glob
(The prior code for compatibility was presumably for Debian Jessie
and earlier, now obsolete. Debian Stretch -- currently oldstable --
ships with lighttpd 1.4.45)
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-18 12:52:58 -05:00
Adam Warner
a44b8e4bfc
Set fixed version requirement for tox ( #5074 )
2022-12-18 13:50:18 +00:00
Christian König
c8e69c6139
Set testenv explicitly
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-18 14:41:18 +01:00
Christian König
da8893f477
Try bandaid
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-18 12:45:14 +01:00
Christian König
7562376373
Add merge-conflict workflow
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-17 21:14:20 +01:00
Dan Schaper
619cebb62c
Bump actions/checkout from 3.1.0 to 3.2.0 ( #5070 )
2022-12-17 11:55:03 -08:00
Dan Schaper
6a2200a8e6
Set X-XSS-Protection headers to 0 in lighttpd.conf ( #5069 )
2022-12-17 11:34:02 -08:00
dependabot[bot]
661433c115
Bump actions/checkout from 3.1.0 to 3.2.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.1.0...v3.2.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-17 10:00:40 +00:00
Glenn Strauss
e7e7a817bb
add Fedora 37 to distro-test
...
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2022-12-17 04:18:38 -05:00
Neill Wolf
d245226053
set X-XSS-Protection headers to 0 in lighttpd.conf
...
Signed-off-by: Neill Wolf <neillawolf@gmail.com >
2022-12-16 16:01:35 -06:00
Adam Warner
a5d10a6256
Sync master back into development ( #5068 )
2022-12-15 20:44:01 +00:00
Adam Warner
c32761e786
Use github cli to sync master back to development ( #5063 )
2022-12-15 20:19:35 +00:00
Christian König
095696ec04
Use github cli to sync master back to development
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-13 23:01:35 +01:00
Adam Warner
7971cf0adc
Only compare OS versions if dig was successful ( #5056 )
2022-12-11 18:00:54 +00:00
Adam Warner
fc83883934
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2022-12-11 17:48:45 +00:00
RD WebDesign
1550f29f06
Use GREEN if dig was successful
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-12-11 14:42:47 -03:00
RD WebDesign
a206980242
Fix parenthesis color
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-12-11 14:42:47 -03:00
RD WebDesign
8c2f56b0e6
Imporving the output from os_check() function
...
- add red color to dig errors
- reorder some output lines
- add "Distro and version supported" on success
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-12-11 14:42:46 -03:00
RD WebDesign
b4349b41ce
Use the correct variable digReturnCode
...
also use INFO instead of CROSS, because it's not an error.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-12-11 14:42:46 -03:00
RD WebDesign
67f04787d6
Only compare OS versions if dig was successful
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-12-11 14:42:35 -03:00
Adam Warner
1ee922d16c
Disable a few commands if installed in (official) docker containers ( #5018 )
2022-12-11 17:31:58 +00:00
Christian König
14ab586603
Start counting with 1
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-11 15:12:28 +01:00
Christian König
372070ab39
Improve detection of incorrecr lines during gravity
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-11 15:12:28 +01:00
Christian König
4004a93d1a
Don't double check for lines containing no domains in gravity
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-11 15:12:28 +01:00
Adam Warner
c2bb190dce
Explicitly create group pihole on installation ( #5039 )
2022-12-11 14:05:24 +00:00
Adam Warner
b8eae60fcc
Disable a few commands for Docker. Currently this is done by monkeypatching the the pihole file on Docker install, however if someone was to run pihole checkout, these patches are removed.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-12-11 11:39:11 +00:00
Dan Schaper
c86ff5d084
Bump actions/setup-python from 4.3.0 to 4.3.1 ( #5054 )
2022-12-10 12:39:11 -08:00
dependabot[bot]
126da094bd
Bump actions/setup-python from 4.3.0 to 4.3.1
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.3.0...v4.3.1 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-12-10 10:00:58 +00:00
Christian König
f713b14ba0
Cleanup if startup failed
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-08 09:49:02 +01:00
Dan Schaper
a4e20f79a3
Install wheel before other python packages in Action ( #5048 )
2022-12-05 15:32:04 -08:00
Christian König
6b146ed2d1
Use two-step approach
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-05 23:13:24 +01:00
Christian König
e0e0baf076
Install wheel before other python packages
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-12-04 09:32:23 +01:00
Dan Schaper
95e799ed6e
Do not require man pages to be present in test script ( #5037 )
...
Skip manpage tests when the manpage directory does not exist.
2022-11-28 13:27:30 -08:00
DL6ER
202aa25c09
Do not setcap FTL binary when systemd is used ( #5043 )
...
All bets on `AmbientCapabilities`
2022-11-28 22:00:27 +01:00
MichaIng
06de172952
Skip setcap on installs with systemd
...
since the systemd unit uses "AmbientCapabilities" to grant capabilities.
Signed-off-by: MichaIng <micha@dietpi.com >
Signed-off-by: MichaIng <micha@dietpi.com >
2022-11-28 21:27:57 +01:00
Adam Warner
ff5ee29566
Add native systemd service ( #4924 )
2022-11-27 21:41:35 +00:00
Adam Warner
d393497641
sync: master to development ( #5041 )
2022-11-27 21:40:52 +00:00
Adam Warner
0034538794
v5.14.2 ( #5040 )
2022-11-27 21:31:19 +00:00
Christian König
33d2163f19
Explicitly create group pihole on installation
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-11-24 22:06:04 +01:00
Christian König
ea26171c18
Do not require man pages to be present in test script
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-11-24 20:39:02 +01:00
Dan Schaper
82dfcbcd83
Fix pihole updatecheck reboot ( #5035 )
2022-11-23 11:08:46 -08:00
RD WebDesign
233453267e
Using shift to allow passing multiple arguments
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-11-23 15:33:49 -03:00
RD WebDesign
f3c27f706f
Pass only the correct argument
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-11-23 14:07:30 -03:00
Dan Schaper
983d79b3e6
Don't install which ( #5028 )
2022-11-18 17:40:12 -08:00
Christian König
6d8abc2e30
Don't install which
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-11-18 23:50:34 +01:00
Adam Warner
38775cffdf
Ensure local hash is always of length 8, for consistency.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-11-14 22:51:39 +00:00
Adam Warner
b13a75a223
sync: master to development ( #5017 )
2022-11-14 22:46:26 +00:00
Adam Warner
21026d9414
Fix odd behaviour introduced into new version checking script ( #5016 )
2022-11-14 22:21:16 +00:00
Adam Warner
ba74051502
Grab local FTL hash correctly from FTL's own version output, and grab one digit less for remote hashes (also in debug log)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-11-14 22:09:26 +00:00
Adam Warner
cdbe4c9b86
Get only the precise tag number when getting local version, do not show branch name when on master branch(es)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-11-14 20:39:34 +00:00
Adam Warner
ca04c13315
sync: master to development ( #5013 )
2022-11-14 19:03:11 +00:00
Adam Warner
3c86af0e59
Pi-hole core v5.14 ( #5012 )
2022-11-14 19:00:40 +00:00
Adam Warner
ddaa1bf0d4
Correctly identify process status in debug script on docker ( #5011 )
2022-11-14 18:15:57 +00:00
Adam Warner
6b8ba3c15e
Replace deprecated shell commands ( #4907 )
2022-11-14 17:52:31 +00:00
Christian König
7536c312ee
Correctly identify process status in debug script on docker
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-11-13 21:53:59 +01:00
Adam Warner
a8b6eb9b70
Touch files before addKey or addOrEditKeyValPair ( #4999 )
2022-11-09 23:37:30 +00:00
Christian König
67385b7ed4
Touch files before addKey or addOrEditKeyValPair
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-11-09 21:25:09 +01:00
Adam Warner
64e61aac4a
Simplify versions.sh ( #4959 )
2022-11-09 17:15:51 +00:00
Christian König
2fd5b944ad
Touch setupVars before writing to it
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-11-03 22:09:12 +01:00
Dan Schaper
f91606bb17
Fix static IP not set because of in-line comment in dhcpcd.conf ( #4998 )
2022-11-02 15:17:36 -07:00
Stephan Pillhofer
122bc6b927
Fix static IP not set because of in-line comment
...
Signed-off-by: Stephan Pillhofer <43667664+StephanPillhofer@users.noreply.github.com >
2022-11-02 22:35:39 +01:00
Dan Schaper
3491dbfd04
Check versions file on the debug log ( #4977 )
2022-10-31 13:25:15 -07:00
Dan Schaper
871067acd8
Fix static IP not set if IP is already present in any way inside dhcpcd.conf ( #4995 )
...
Use grep and regex to find uncommented use of `static ip_address` with IP.
2022-10-31 13:23:35 -07:00
Stephan Pillhofer
06cf7afbc2
Fix static IP not set
...
Signed-off-by: Stephan Pillhofer <43667664+StephanPillhofer@users.noreply.github.com >
2022-10-30 20:19:38 +01:00
MichaIng
81927334f2
Add native systemd service
...
Inspired by: https://github.com/pi-hole/pi-hole/pull/2112
A pre-start and a post-stop script are added to reduce doubled setup and cleanup code.
Since systemd services do not natively support dynamic users, test once whether capabilities are supported during install/update, and remove User=pihole otherwise.
Signed-off-by: MichaIng <micha@dietpi.com >
Co-authored-by: DL6ER <dl6er@dl6er.de >
2022-10-30 19:40:33 +01:00
yubiuser
01bf9ca42a
Prevent CNAME loop ( #4988 )
2022-10-29 15:44:03 +02:00
Christian König
c8c6533440
Add small explanation.
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-29 15:09:14 +02:00
Dan Schaper
f1b15f7e92
Remove check for latest component version in debug log ( #4973 )
2022-10-28 17:27:05 -07:00
DL6ER
e0c351f0e4
Remove unused possibility to obfuscate pihole.log in debug log ( #4974 )
2022-10-28 13:16:30 -04:00
DL6ER
7957acf42f
Remove unused old code from gravity.sh ( #4985 )
2022-10-28 13:15:02 -04:00
Dan Schaper
c3e8d76d63
Escape dots in local DNS records/CNAMES before removing them ( #4990 )
2022-10-24 13:21:07 -07:00
Christian König
128a3ab1be
Go POSIX
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-22 22:39:42 +02:00
Christian König
df3e9e5f51
Disable shellcheck as it suggests a bashism
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-22 22:25:40 +02:00
Christian König
c322458dcb
Escape dots in local DNS records/CNAMES before removing them
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-21 13:02:21 +02:00
Christian König
21be1bd58e
Prevent CNAME loop
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-20 07:29:14 +02:00
Adam Warner
469a267150
Adding CentOS Stream 9 tests ( #4984 )
2022-10-19 19:14:00 +01:00
RD WebDesign
090727b1d3
Remove unnecessary return
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-10-17 15:24:49 -03:00
RD WebDesign
85ffbcf05e
Allow replacing conflicting existing packages from testing image
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-10-17 14:58:42 -03:00
RD WebDesign
528abc9c97
Adding CentOS Stream 9 tests
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-10-16 19:36:56 -03:00
RD WebDesign
8b98fd06ed
Remove unused old code
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-10-16 15:54:24 -03:00
Adam Warner
bc6fb0c934
sync: master to development ( #4981 )
2022-10-15 15:46:53 +01:00
Adam Warner
e773e3302c
Bump actions/setup-python from 4.2.0 to 4.3.0 ( #4980 )
2022-10-15 15:45:44 +01:00
Adam Warner
0cf59cf0fa
Bump actions/setup-python from 4.2.0 to 4.3.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.2.0 to 4.3.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](actions/setup-python@v4.2.0...v4.3.0)
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-10-15 15:36:20 +01:00
Adam Warner
bc471cb0bd
Fix errors in README.md ( #4818 )
2022-10-15 15:06:06 +01:00
Adam Warner
429510e168
Update README.md
...
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2022-10-15 15:03:35 +01:00
Christian König
4c9401175c
Remove check for latest version
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-15 09:06:57 +02:00
Christian König
235673dac8
Remove unused possibility to obfuscate pihole.log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-15 08:58:12 +02:00
RD WebDesign
d737948f64
Add versions file to the REQUIRED_FILES list
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-10-14 14:11:19 -03:00
Christian König
52283478c8
Run pihole updatechecker if versions file is not found
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-14 13:26:06 +02:00
Christian König
c84be5de61
Reorganize by component rather then source
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-14 13:18:12 +02:00
Christian König
d85982dc51
Use versions file instead of github api to get latest version
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-14 10:29:14 +02:00
Christian König
5c61f6cb65
Remove checkout hint
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-14 08:43:39 +02:00
Christian König
4c0a94d2b9
Don't rely on pihole -v output but query github to get the lastest versions in debug script
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-13 14:44:13 +02:00
MichaIng
5c090d25e1
Fix ldd sh mock in tests
...
Since "command" is a shell internal, it cannot be mocked, done via /usr/local/bin override. Since Debian containers ship without /bin => /usr/bin symlink, while all other containers do, the "ldd" mock needs to be applied for both paths, then.
Signed-off-by: MichaIng <micha@dietpi.com >
2022-10-12 12:49:50 +02:00
Adam Warner
89c0706abc
master -> dev ( #4970 )
2022-10-12 11:32:30 +01:00
a1346054
e5695f862f
test_any_automated_install.py: Use command -v instead of which
...
Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com >
2022-10-11 14:36:26 +00:00
a1346054
e3db5fc601
basic-install.sh: Use command -v instead of which
...
`command -v` is the standardized version of `which` and doesn't require
any extra packages
Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com >
2022-10-11 14:33:30 +00:00
a1346054
9c51050283
basic-install.sh: Use grep -E instead of egrep
...
Signed-off-by: a1346054 <36859588+a1346054@users.noreply.github.com >
2022-10-11 14:33:30 +00:00
Adam Warner
17779bad94
Pi-hole v5.13 ( #4960 )
2022-10-10 22:00:47 +01:00
Dan Schaper
fed58f03bf
Fix pihole -r dialog exit ( #4965 )
2022-10-09 21:10:23 -07:00
RD WebDesign
c5b3b8dd68
Fix pihole -r dialog exit
...
- if an option is selected: Get option (repair/reconfigure);
- if exit or ESC: Get exit code (1/255)
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-10-10 00:27:03 -03:00
Adam Warner
46986714d4
Bump actions/stale from 6.0.0 to 6.0.1 ( #4963 )
2022-10-09 20:03:21 +01:00
Adam Warner
4f3debcb5b
Bump actions/checkout from 3.0.2 to 3.1.0 ( #4964 )
2022-10-09 20:03:10 +01:00
dependabot[bot]
223ef72250
Bump actions/checkout from 3.0.2 to 3.1.0
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.0.2 to 3.1.0.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3.0.2...v3.1.0 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-09 18:46:02 +00:00
dependabot[bot]
cf467db61d
Bump actions/stale from 6.0.0 to 6.0.1
...
Bumps [actions/stale](https://github.com/actions/stale ) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v6.0.0...v6.0.1 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-10-09 18:45:54 +00:00
Adam Warner
fae1d13892
Add initscripts to CentOS8 dockerfile ( #4966 )
2022-10-09 19:45:13 +01:00
Christian König
4265bcb178
Add initscripts to CentOS8 dockerfile
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-08 22:08:39 +02:00
Christian König
9471c69882
Fix spelling
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-07 09:34:05 +02:00
Christian König
79c0b446e1
Set missing data to N/A
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 21:55:49 +02:00
Christian König
a478f2460b
POSIX
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 21:50:07 +02:00
Christian König
2dc599f266
Simplify version.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 17:58:58 +02:00
Christian König
d7f7ef9965
Only create VERSION_FILE if it does not exist
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 14:37:56 +02:00
Christian König
888e44e53d
Add hash functions to updatecheck
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 14:34:34 +02:00
Christian König
18d28533eb
Update local and remote versions at the same time
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 12:36:17 +02:00
Christian König
56527e5dd9
Add get_remote_version() to updatechecker
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-06 12:03:12 +02:00
Adam Warner
997a771dc8
Fix Deepsource.io warning message for index.php file ( #4953 )
2022-10-01 22:57:32 +01:00
Adam Warner
77f0012f6b
Fix default DHCPv4 leasetime value ( #4956 )
2022-10-01 22:50:39 +01:00
Adam Warner
b7b5ffa8dd
remove old code per review from @yubiuser and @dschaper
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-10-01 22:31:03 +01:00
Adam Warner
34b66002e9
leasetime (local) should have an h after it to signify 24h lease, else it will be read as two minutes (minimum integer value)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-10-01 22:31:00 +01:00
Dan Schaper
71b560667b
Add Fedora 35 and 36, remove 34 to/from the test suite ( #4952 )
2022-10-01 13:43:13 -07:00
Adam Warner
9dd51b79b5
Remove pihole-FTL.port file ( #4945 )
2022-10-01 14:30:23 +01:00
Adam Warner
7fd062c4d8
Update Amazon support URL to HTTPS in README ( #4954 )
2022-10-01 14:28:26 +01:00
Christian König
3731b65bd5
Remoce Fedora 34 from tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-01 10:04:26 +02:00
Christian König
6057b134ae
Add initscripts to Fedora 35 and 36 dockerfile
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-10-01 10:03:13 +02:00
David Beitey
0749de3d1f
Update Amazon support URL to HTTPS in README
...
Signed-off-by: David Beitey <david@davidjb.com >
2022-10-01 09:39:04 +10:00
RD WebDesign
d48c557134
Fix Deepsource warning message for index.php file
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-09-30 17:13:08 -03:00
Christian König
a705fbca73
Add Fedora 35 and 36 to the test suite
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-29 19:13:23 +02:00
Christian König
276c480f50
Return default port if non-numeric characters are set in pihole-FTL.conf for FTLPORT. FTL does the same in such case and provide the API on 4711
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-26 23:40:09 +02:00
Christian König
25ba68104b
Remove last traces
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-26 22:55:34 +02:00
Christian König
3d01e4d0cf
No detour - use pihole-FTL.conf to get the API port number
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-26 22:55:30 +02:00
Adam Warner
1b0b0ca445
Update python tests and add black code formatter action ( #4926 )
2022-09-26 20:00:27 +01:00
Christian König
e1a2591c4d
Format test.yml
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-26 10:40:39 +02:00
Dan Schaper
f8a12917e2
Handle more than one default gateway in debug script ( #4934 )
2022-09-25 11:09:26 -07:00
Dan Schaper
37b45d411d
Read docker tag from file in root, not the previously set environment variable ( #4929 )
2022-09-25 11:05:08 -07:00
Christian König
22ebf21487
Use POSIX
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-25 18:20:01 +02:00
Christian König
bf5fffaca7
Better wording and test with color
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-25 18:03:44 +02:00
Adam Warner
9debd22179
If, after reading /pihole.docker.tag into DOCKER_TAG, it does not match an expected pattern, unset it - this should prevent arbitary code from being run
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-25 15:51:09 +01:00
Dan Schaper
a8ce1354c8
Set connection timeout for curl ( #4884 )
2022-09-24 18:19:15 -07:00
Adam Warner
0a780a959a
Fix issue in #4872 missed in review ( #4940 )
2022-09-24 16:18:49 +01:00
Peter Russell
951b4ed002
Remove cronjob that checks local versions every 10 minutes - only check when required ( #4939 )
...
* eliminate updatechecker local from pihole cron job
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
* resolving stickler-ci items
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
* undo changes to updatecheck.sh (request from PromoFaux)
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
* applied recommendation from PromoFaux
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
* Indent the code inside the function
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
* removed unnecessary updatecheck for core
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
* eliminate updatechecker local from pihole cron job
Co-authored-by: jpgpi250 <jpgpi250@gmail.com >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2022-09-24 16:14:44 +01:00
Adam Warner
755ec8bf2f
$$ != $
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-24 16:08:45 +01:00
Adam Warner
1c1407e083
Use utils.sh in install script ( #4872 )
2022-09-24 14:00:22 +01:00
Adam Warner
9463c3c69f
Change wording in chronometer ( #4910 )
2022-09-24 13:53:08 +01:00
Adam Warner
54bcf5626f
Bump actions/stale from 5.2.0 to 6.0.0 ( #4938 )
2022-09-24 13:07:51 +01:00
dependabot[bot]
ba8a50c829
Bump actions/stale from 5.2.0 to 6.0.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 5.2.0 to 6.0.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v5.2.0...v6.0.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-24 10:08:26 +00:00
Christian König
bb57a9e616
Handle more than one default gateway in debug script
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-22 22:33:11 +02:00
yubiuser
4f4dfe3ac0
Fix tabs in dialog boxes ( #4932 )
2022-09-22 22:02:45 +02:00
Christian König
d4ce5b1c2a
Fix tabs in dialog boxes
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-22 14:49:25 +02:00
Adam Warner
b6d1bd7335
Read docker tag from file in root, not the previously set environment variable
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-19 22:01:05 +01:00
Christian König
17ec88d96f
Remove installed_binary variable which was leftover from https://github.com/pi-hole/pi-hole/pull/4893
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-19 14:50:35 +02:00
Christian König
0df38cd64e
Format all /test files with black
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-19 14:50:35 +02:00
Christian König
0932c5c498
Add black python code formatter action
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-19 14:50:35 +02:00
Christian König
73ca4ebdbc
Update test requirements
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-19 14:50:35 +02:00
Adam Warner
da6596e516
Master -> Dev ( #4925 )
2022-09-19 11:15:59 +01:00
Adam Warner
d88629e23f
v5.12.2 ( #4922 )
2022-09-19 11:00:09 +01:00
yubiuser
d581401f4e
Fix gravity database integrity check ( #4921 )
2022-09-18 13:35:03 +02:00
Christian König
60c35cb93c
Remove unused check_database_integrity()
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-18 13:08:44 +02:00
Christian König
2c3fea321b
Remove FAQ_ULA as it is unused in core
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-18 09:10:24 +02:00
Christian König
40f00c6f0b
Fix gravity database integrity check
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-18 09:01:22 +02:00
Christian König
00e51f32b5
Blcked => Block
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-17 16:46:31 +02:00
Christian König
f90fb8b946
Change wording in chronometer
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-17 16:24:31 +02:00
yubiuser
2ff1fa1b85
Merge branch 'development' into use_utils
2022-09-17 16:14:31 +02:00
yubiuser
7eff36b3bb
Update workflow python to 3.10 and allow any python3 version in tests ( #4914 )
2022-09-17 16:13:48 +02:00
yubiuser
5332b31b92
Add comment in lighttpd.conf how to change the server port ( #4917 )
2022-09-17 14:05:13 +02:00
yubiuser
16640ee174
Bump actions/stale from 5.1.1 to 5.2.0 ( #4918 )
2022-09-17 14:04:25 +02:00
dependabot[bot]
5fe170666a
Bump actions/stale from 5.1.1 to 5.2.0
...
Bumps [actions/stale](https://github.com/actions/stale ) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v5.1.1...v5.2.0 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-09-17 10:08:40 +00:00
Christian König
7e6f81f814
Add comment in lighttpd.conf how to change the server port
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-17 12:00:33 +02:00
yubiuser
80c770357c
Fixing texts forgotten after Blocking Page removal ( #4915 )
2022-09-16 08:25:15 +02:00
RD WebDesign
5cc317de5b
Change texts after Block Page removal
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-09-16 03:16:54 -03:00
Adam Warner
515e5f8c8a
Store docker version in versions file (If PIHOLE_DOCKER_TAG variable is set) ( #4913 )
2022-09-15 18:05:42 +01:00
Adam Warner
3d53bda121
Update advanced/Scripts/updatecheck.sh
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2022-09-15 17:54:54 +01:00
Christian König
8bc5b16527
Set tox envlist to py3
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-15 13:55:45 +02:00
Christian König
c1a927fff1
Run test workflows on python 3.10
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-15 13:55:45 +02:00
Adam Warner
760325eb76
Update piholeDebug to source versions file for DOCKER_VERSION instead of reading PIHOLE_DOCKER_TAG
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-14 22:49:37 +01:00
Adam Warner
bf256aa5a7
If docker version env var is set, store it in /etc/pihole/versions file for later use
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-14 22:38:41 +01:00
Adam Warner
8dbe6fc0b7
master-> Dev ( #4912 )
2022-09-14 22:08:15 +01:00
Adam Warner
fe8b0e98ab
v5.12.1 ( #4908 )
2022-09-14 21:28:44 +01:00
yubiuser
ef45578af3
Fix 4898 ( #4899 )
2022-09-06 19:43:24 +02:00
Christian König
89b88416b3
Fix 4898
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-09-06 17:09:52 +02:00
Adam Warner
5d913ad192
Release 5.12 ( #4889 ) ( #4897 )
2022-09-05 08:48:37 +01:00
yubiuser
711035fd8f
Update FTL Binary test to ensure we catch incompatibility issues early ( #4893 )
2022-09-03 14:44:16 +02:00
Adam Warner
0f74165c9d
Drop Ubuntu 18 tests
...
Tweek version_check to only output 1st char of the reported version
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-03 12:55:17 +01:00
Adam Warner
46e1a87e9e
Tweak FTL test to ensure we don't get false positives on incompatible OS (Will remote Ub18 in a separate commit)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-09-03 12:09:37 +01:00
Adam Warner
f998eee467
Release 5.12 ( #4889 )
2022-09-02 18:39:03 +01:00
Christian König
230d6a435f
Semi hardcode the connection_timeout value
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-31 21:41:57 +02:00
Christian König
53c0982c8b
Set connection timeout for curl
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-31 14:43:20 +02:00
yubiuser
d6cfa57ef3
Add jq as dependency and remove json_extract ( #4878 )
...
**What does this PR aim to accomplish?:**
Adds `jq` as dependency and removes the now obsolete `json_extract` function.
`jq` is a small dependency and adds powerfull json abilities. With `FTL v6` we will have a whole new json-based API where `jq` might be needed anyway. Also for `PADD` to interact with `FTL v6`, `jq` will be a requirement: https://github.com/pi-hole/PADD/pull/247
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/ ), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1 )
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html ))
---
- [x] I have read the above and my PR is ready for review. _Check this box to confirm_
2022-08-26 10:09:42 +02:00
Christian König
49b9dc8888
Remove json_extract function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-25 09:55:47 +02:00
Christian König
1335c44deb
Add jq to dependencies
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-25 09:55:42 +02:00
Christian König
9b5ea13a33
Use utils.sh in install script
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-24 08:49:20 +02:00
yubiuser
66eeee5548
Remove the email function ( #4870 )
...
- **What does this PR aim to accomplish?:**
We offered to set an administrator email which was shown on the blockpage. With the removal of the blockpage (https://github.com/pi-hole/pi-hole/pull/3910 ) this function is not needed anymore.
Corresponding web interface PR: https://github.com/pi-hole/AdminLTE/pull/2301
2022-08-24 07:21:04 +02:00
Adam Warner
597c045f9e
Merge pull request #4875 from pi-hole/tweak/version-file
...
Store versions as key/value pairs rather than space delimeted values
2022-08-23 19:23:44 +01:00
Adam Warner
a4b899c256
Review suggestions (and shellcheck complaints)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-23 19:10:12 +01:00
Adam Warner
5421aad03e
Store versions as key/value pairs rather than space delimeted values
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-22 19:11:27 +01:00
Christian König
eeccfb27f8
Remove it also from index.php together with more unused variables
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-20 23:07:38 +02:00
yubiuser
4cf3280500
Merge pull request #4862 from pi-hole/tweak/lighttpd_headers
...
Add security-related headers to Pi-hole web interface
2022-08-18 13:37:28 +02:00
Christian König
8c4a9aa6e3
Remove the email function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-17 23:14:56 +02:00
Adam Warner
9ab566884d
Merge pull request #3910 from pi-hole/removeblockpagefunctionality
...
Remove the advanced functionality of the 404 page (Blockpage)
2022-08-17 21:22:01 +01:00
yubiuser
37102e5a01
Merge branch 'development' into removeblockpagefunctionality
2022-08-17 21:29:58 +02:00
yubiuser
5a98fa1f76
Merge pull request #4843 from MichaIng/patch-1
...
Skip web server dialog if --disable-install-webserver has been passed
2022-08-17 21:27:59 +02:00
Adam Warner
114f562758
Merge branch 'development' into removeblockpagefunctionality
2022-08-17 20:25:03 +01:00
MichaIng
b3c8045b52
Skip web server dialog if --disable-install-webserver has been passed
...
Prior to https://github.com/pi-hole/pi-hole/pull/4772 , the web server dialog was skipped if --disable-install-webserver was passed (INSTALL_WEB_SERVER=false). This commit restores this behaviour.
Signed-off-by: MichaIng <micha@dietpi.com >
2022-08-17 20:48:11 +02:00
yubiuser
a0419bc1f0
Merge pull request #4864 from pi-hole/debug_FTL_branch
...
Extend FTL information in debug log
2022-08-08 21:25:56 +02:00
Adam Warner
e35a9da921
Remove the blockpage-focussed customisations to query.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-08 18:57:55 +01:00
Christian König
97447b2f3b
Do not remove blockingpage.css from existing installations as some users might use them for custom.php
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 18:20:49 +01:00
yubiuser
c67f313ee8
Apply reviewers suggestion for inline CSS
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: yubiuser <ckoenig@posteo.de >
2022-08-08 17:21:29 +01:00
Christian König
49a9f6f2db
Reproduce blockpage.css for $splashPage
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 17:21:29 +01:00
Christian König
e6683803ed
Use absolut asset paths
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 17:21:29 +01:00
Christian König
27fa284eda
Fix missing PI_HOLE_BLOCKPAGE_DIR
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 17:21:29 +01:00
Christian König
b98e331375
Only do one curl call in debug when checking the X-Header
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 17:20:41 +01:00
Christian König
6c9bd7a632
Remove blockingpage.css
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 17:20:13 +01:00
Adam Warner
5816f495f4
Fix test_installPiholeWeb_fresh_install_no_errors and test_installPihole_fresh_install_readableBlockpage
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-08 17:12:16 +01:00
Adam Warner
5d5a85b7b6
X-Pi-hole removed from blocking page...
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-08 17:12:16 +01:00
Adam Warner
c78cf82fc6
no need to declare $viewPort
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-08 17:12:09 +01:00
Christian König
d77677312c
Extend FTL information in debug log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-08 13:52:20 +02:00
yubiuser
d38fcb0549
Merge pull request #4863 from pi-hole/fix/git_indention
...
Fix git indention
2022-08-07 20:25:42 +02:00
Christian König
c7410b0be9
Always indent
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-07 15:50:05 +02:00
Dan Schaper
20c561c83c
Merge pull request #4857 from pi-hole/4856-init-script-ftl
...
Exit init script with error result code if FTL fails to start
2022-08-06 13:15:10 -07:00
Christian König
7320c10dd3
Fix git indention
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-06 21:44:19 +02:00
DL6ER
f418481b9f
Add security-related headers to Pi-hole web interface
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-08-06 15:35:01 +02:00
Adam Warner
a3516474e8
Merge pull request #4859 from pi-hole/dependabot/github_actions/development/actions-ecosystem/action-add-labels-1.1.3
...
Bump actions-ecosystem/action-add-labels from 1.1.0 to 1.1.3
2022-08-06 11:23:15 +01:00
dependabot[bot]
9e2e0019fb
Bump actions-ecosystem/action-add-labels from 1.1.0 to 1.1.3
...
Bumps [actions-ecosystem/action-add-labels](https://github.com/actions-ecosystem/action-add-labels ) from 1.1.0 to 1.1.3.
- [Release notes](https://github.com/actions-ecosystem/action-add-labels/releases )
- [Commits](https://github.com/actions-ecosystem/action-add-labels/compare/v1.1.0...v1.1.3 )
---
updated-dependencies:
- dependency-name: actions-ecosystem/action-add-labels
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-06 10:22:39 +00:00
Adam Warner
aef3d89814
Merge pull request #4860 from pi-hole/dependabot/github_actions/development/actions/stale-5.1.1
...
Bump actions/stale from 5.1.0 to 5.1.1
2022-08-06 11:20:38 +01:00
Adam Warner
f2641fb0e5
Merge pull request #4861 from pi-hole/dependabot/github_actions/development/actions/setup-python-4.2.0
...
Bump actions/setup-python from 4.1.0 to 4.2.0
2022-08-06 11:20:21 +01:00
dependabot[bot]
e50438dc11
Bump actions/setup-python from 4.1.0 to 4.2.0
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4.1.0...v4.2.0 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-06 10:07:31 +00:00
dependabot[bot]
6062df0923
Bump actions/stale from 5.1.0 to 5.1.1
...
Bumps [actions/stale](https://github.com/actions/stale ) from 5.1.0 to 5.1.1.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/v5.1.1/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v5.1.0...v5.1.1 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-08-06 10:07:28 +00:00
Dan Schaper
989c52ef24
Exit with return code if ftl does not start
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-08-04 17:20:39 -07:00
yubiuser
4a589286b7
Merge pull request #4855 from pi-hole/fix/dir_not_exist
...
Ensure user defined FTL_PID_FILE and FTL_PORT_FILE dirs are created on startup
2022-08-04 22:27:08 +02:00
Christian König
3327df8d9c
Ensure user defined FTL_PID_FILE and FTL_PORT_FILE dirs are created on startup
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-08-04 14:47:43 +02:00
yubiuser
3cdaad060b
Merge pull request #4851 from pi-hole/keywords
...
Dont use bash keywords/programs as variable names
2022-08-01 22:07:21 +02:00
Adam Warner
0b81dd387b
type -> list_type per @yubiuser suggestion
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-01 20:56:37 +01:00
Adam Warner
64dc002c3f
Same per @rdwebdesign suggestion.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-08-01 20:38:31 +01:00
Adam Warner
6c7a28a7b5
Dont use bash keywords/programs as variable names
2022-08-01 18:38:15 +01:00
Adam Warner
21158cb6bc
Merge pull request #4833 from pi-hole/workflow_versions
...
Explicit set minor and patch version on used actions
2022-08-01 17:20:05 +01:00
Adam Warner
71bc237639
Merge pull request #4828 from pi-hole/centos7-can-do-one
...
Drop explicit support for CentOS 7 from the install script
2022-07-31 19:15:41 +01:00
Adam Warner
c6da627b7d
Move release version check inside the else block
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-31 18:55:05 +01:00
Christian König
a3ac1caac6
Update actions to latest versions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-31 09:46:51 +02:00
Christian König
8f3e6f1a50
CodeQl does not use .minor.patch version
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-31 09:46:50 +02:00
Christian König
99b7f996e2
Explicite set minor and patch version on used actions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-31 09:46:47 +02:00
yubiuser
aa0a9e2976
Merge pull request #4839 from pi-hole/move_getFTLPIDFile
...
Move FTL port and PID functions to utils.sh
2022-07-30 21:01:21 +02:00
Adam Warner
9028898ba7
Move code from check_epel_repo_required into the rpm branch of the if check on package_manager_detect(), adjust tests to accommodate
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-30 19:27:00 +01:00
Adam Warner
0e8c1ec023
Flip logic on epel check - if _not_ fedora, then (try to, depending on supported OS) install EPEL.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-30 19:03:46 +01:00
Adam Warner
313c0ddf28
Update automated install/basic-install.sh
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Adam Warner <github@adamwarner.co.uk >
2022-07-30 18:59:57 +01:00
yubiuser
2c38de26b7
Merge pull request #4847 from pi-hole/remove/unused_files
...
Remove unused and outdated files and scripts
2022-07-30 18:34:58 +02:00
Adam Warner
fc2a564cc0
remove tests no longer needed
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-30 16:27:31 +01:00
Adam Warner
b613758419
rename select_rpm_php and simplify it to remove code no longer needed (discussed internally removing the unsupported dialog here to match behaviour on non rpm distros)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-30 16:27:31 +01:00
Adam Warner
9c03915cb0
Remove special Centos7 hand holds. Move the unsupported dialog out to a further if block so that a user may still continue to install on centos7 (provided they have the pre-requisites installed)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-30 16:27:31 +01:00
Adam Warner
e29aa4e205
First things first...
2022-07-30 16:27:29 +01:00
yubiuser
a45c9f9f50
Merge pull request #4848 from pi-hole/indent_update
...
Indent installation/update complete message
2022-07-30 07:41:04 +02:00
yubiuser
b3ba17bfd4
Merge pull request #4846 from pi-hole/uninstall
...
Add OS_CHECK_DEPS to uninstall script
2022-07-29 23:43:37 +02:00
Christian König
2610739624
Indent installation/update complete message
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-29 23:43:20 +02:00
Christian König
567a915336
Remove unused and outdated files and scripts
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-29 23:21:38 +02:00
Christian König
68eddd2377
Add OS_CHECK_DEPS to uninstall script
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-29 22:47:40 +02:00
yubiuser
aeb92416c8
Merge pull request #4832 from pi-hole/fix/msg
...
Fix spaces in dialog msg
2022-07-26 23:57:50 +02:00
yubiuser
cca5c49eaa
Merge pull request #4838 from pi-hole/tweak/readme_logo
...
Use prefers-color-scheme for theme based logo
2022-07-26 23:44:33 +02:00
Christian König
8c778c14dc
Move linebreaks
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 23:43:49 +02:00
yubiuser
d5c798d1a9
Apply reviewers suggestion
...
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
Signed-off-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 23:39:02 +02:00
Christian König
14e1eea22d
Fix spaces in dialog msg
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 23:39:02 +02:00
Christian König
ab6b37bdcf
Fix stickler and codefactor complaints
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 19:33:38 +02:00
Christian König
c8c4eb59b7
Add getFTLPID() tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 17:34:42 +02:00
Christian König
2651abbe6c
Add tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 16:57:06 +02:00
Christian König
7b77d991df
Move FTL port and PID functions to utils.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 14:38:03 +02:00
Christian König
64465510de
prefers-color-scheme for logo
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-26 13:33:00 +02:00
yubiuser
f59749b1c3
Merge pull request #4834 from pi-hole/fix/spinner
...
Only execute spinner function if there is a tty
2022-07-26 09:29:55 +02:00
yubiuser
27ef7e5538
Merge branch 'development' into fix/spinner
2022-07-26 09:21:24 +02:00
Adam Warner
a7a467a167
Merge pull request #4837 from pi-hole/dont-fail-fast
...
Dont fail fast on tests
2022-07-25 22:44:00 +01:00
Adam Warner
21af75a2d2
Ubuntu 21 tests are failing entirely. apt-update does not work on an impish vm, either
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-25 22:27:56 +01:00
Adam Warner
2bd3366bb1
Disable fail fast, allowing tests to run despite failures on a particular distro - it is easier to retry failed tests these day
2022-07-25 21:57:30 +01:00
RD WebDesign
d89720330f
Address revision requests:
...
- replace `local var` with `_var` (POSIX style);
- move inline comments
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-07-24 20:15:20 -03:00
RD WebDesign
8d1f286f30
Only execute spinner function if there is a tty
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-07-24 17:52:17 -03:00
yubiuser
c7108a632c
Merge pull request #4824 from pi-hole/Alam_Rocky
...
Don't fail if Alma or Rocky are detected
2022-07-16 09:59:22 +02:00
yubiuser
b025cfeea9
Merge pull request #4825 from pi-hole/shellcheck_install
...
Fix shellcheck warnings
2022-07-16 09:59:08 +02:00
Christian König
bc8fcc744c
Fix shellcheck warnings
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-15 20:43:42 +02:00
Christian König
a3f1317add
Don't fail if Alma or Rocky is detected
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-15 20:04:37 +02:00
Rauf Shimarov
c90d8284ef
Update README.md
...
Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com >
2022-07-12 16:20:17 -07:00
Rauf Shimarov
7ab9664255
Update README.md
...
Co-authored-by: Adam Warner <github@adamwarner.co.uk >
Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com >
2022-07-11 14:55:15 -07:00
Rauf Shimarov
3a22657645
Update README.md
...
Co-authored-by: Adam Warner <github@adamwarner.co.uk >
Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com >
2022-07-11 14:54:19 -07:00
yubiuser
64d75c012e
Merge pull request #4815 from pi-hole/debug_spinner
...
Add spinner for long processes running during debug log
2022-07-11 22:29:06 +02:00
Rauf Shimarov
4567f264b4
Fix errors in README.md
...
Signed-off-by: Rauf Shimarov <55862995+Rauf00@users.noreply.github.com >
2022-07-11 11:45:09 -07:00
RD WebDesign
cbcd12631d
Adding the spinner for foreign_key_check too
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-07-11 01:53:30 -03:00
RD WebDesign
c4f9a475f3
Debug log - add spinner for long processes
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-07-11 01:34:51 -03:00
yubiuser
71d310c50f
Merge pull request #4745 from pi-hole/tweak/debug
...
Add optional health check to Pi-hole databases in debug script
2022-07-10 23:41:42 +02:00
Christian König
b486786041
Add database healthy checks to debug script
...
Fix health check output comparison in gravity script as well
Add note about waiting time
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-10 23:32:47 +02:00
Adam Warner
3dd26b500d
Merge pull request #4813 from pi-hole/master
...
sync: master to development
2022-07-10 13:56:30 +01:00
Adam Warner
aefbe1f5b6
Merge pull request #4812 from pi-hole/development
...
Pi-hole core 5.11.4
2022-07-10 13:52:38 +01:00
Adam Warner
13135498c1
Merge pull request #4811 from pi-hole/CAPS
...
Print all SELINUX output in lowercase
2022-07-10 13:43:29 +01:00
Christian König
9f918972d2
Adjust tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-10 14:33:43 +02:00
Christian König
b25805348f
Print all SELINUX output in lowercase
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-10 14:33:24 +02:00
yubiuser
d6c48f80f4
Merge pull request #4810 from pi-hole/tweak/logrotate
...
Fix broken logrotate config by updating old paths in existing file if they exist
2022-07-10 13:25:45 +02:00
Adam Warner
59dab6a568
Simplifications per @yubiuser's suggestion
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-10 11:50:09 +01:00
Adam Warner
ecfb96d339
If old log paths exist in logrotate file, replace them with new ones
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-10 10:06:55 +01:00
Adam Warner
e0baf4c7ec
Merge pull request #4808 from pi-hole/cure/cancer
...
Fixes "Set static IP using custom values results in error" (#4807 )
2022-07-09 19:12:33 +01:00
Adam Warner
e4444ae6a5
fixes "Set static IP using custom values results in error" ( #4807 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-09 19:02:40 +01:00
yubiuser
8e4adb6e39
Merge pull request #4788 from pi-hole/SKIP_INSTALL
...
Rename PH_TEST to SKIP_INSTALL
2022-07-09 00:01:48 +02:00
yubiuser
6aaa446354
Merge pull request #4802 from pi-hole/codespell
...
Fix spelling mistakes
2022-07-08 23:51:20 +02:00
yubiuser
7d5f6c8331
Merge pull request #4804 from pi-hole/mkdir
...
Clean consecutive mkdir
2022-07-08 23:38:53 +02:00
Christian König
3d8672bc59
Clean consecutive mkdir
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-08 23:20:30 +02:00
Christian König
b49db58ec2
Fix spelling mistakes
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-08 22:00:36 +02:00
yubiuser
edc808ee89
Merge pull request #4791 from pi-hole/master
...
sync: master to development
2022-07-08 00:02:05 +02:00
Dan Schaper
a28d691387
Merge pull request #4795 from pi-hole/fix/mkdir_always
...
Logic fix for hotfix
2022-07-07 14:01:18 -07:00
Dan Schaper
56a32047b8
Logic fix
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-07 13:50:41 -07:00
Dan Schaper
ef71ca05a9
Merge pull request #4794 from pi-hole/fix/mkdir_always
...
Always create log directory if it doesn't exist
2022-07-07 13:41:45 -07:00
Dan Schaper
48d5d6bed2
Always create the log target directory before any movements
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-07 13:23:13 -07:00
Adam Warner
04abc4dacd
Merge pull request #4792 from pi-hole/fix/mkdir_logs
...
Create new log directory
2022-07-07 20:18:18 +01:00
Dan Schaper
fd41801977
Create new log directory
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-07 12:12:53 -07:00
Adam Warner
1be082a0e1
Merge pull request #4789 from pi-hole/development
...
v5.11 Release
2022-07-07 19:48:32 +01:00
Adam Warner
6204698e05
Merge pull request #4790 from pi-hole/reformat-yml
...
[Meta] Reformat yml files
2022-07-07 19:16:03 +01:00
Adam Warner
edba325a3e
Disable line length rule for yamllint - fix indentation in stale.yml
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-07 19:11:23 +01:00
Christian König
518cbd10e0
Rename also in docker files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-06 22:58:14 +02:00
Christian König
0a8761ee68
Rename PH_TEST to SKIP_INSTALL
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-06 22:53:09 +02:00
yubiuser
3d4476c9fb
Merge pull request #4786 from pi-hole/regex_lenght
...
Do not restrict RegEx added from CLI by length
2022-07-06 21:23:23 +02:00
Adam Warner
e05b64b56b
Merge pull request #4782 from pi-hole/fix/stale_reason
...
Fix close-issue-reason
2022-07-06 18:28:48 +01:00
Adam Warner
4150826211
Merge pull request #4784 from pi-hole/space
...
Fix indention in install script output
2022-07-06 18:28:32 +01:00
Christian König
469776afd6
Do not restrict RegEx added from CLI by length
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-06 19:27:33 +02:00
Christian König
5c564e53ca
Fix indention in install script output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-06 12:29:03 +02:00
Dan Schaper
853cd9670a
Merge pull request #4772 from pi-hole/tweak/dialog
...
Convert installer whiptail to dialog
2022-07-05 20:56:02 -07:00
Dan Schaper
cfbc731eab
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-05 20:25:27 -07:00
Dan Schaper
46f991f578
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-05 20:11:00 -07:00
RD WebDesign
ad70ece73e
Fixing dialog line breaks
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-07-05 23:10:40 -03:00
Dan Schaper
39cb1029e9
Clarify button labels
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-05 14:23:59 -07:00
Christian König
c058a511e6
Fix close-issue-reason
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-05 10:15:18 +02:00
Dan Schaper
a39c470f2d
Requested changes.
...
Co-authored-by: MichaIng <micha@dietpi.com >
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-05 00:06:12 -07:00
Dan Schaper
72fcdb128a
Rework cenos7 functions
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-04 23:14:02 -07:00
Dan Schaper
44667b5ffb
Add dialog to RPM installer requirements.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-04 12:35:08 -07:00
yubiuser
696d1c4ec3
Merge pull request #4777 from pi-hole/tweak/default_log_path
...
Change default FTL log file path to /var/log/pihole/FTL.log
2022-07-03 22:19:14 +02:00
Dan Schaper
0b10c50a0b
Merge branch 'development' into tweak/dialog
2022-07-03 11:58:45 -07:00
Dan Schaper
c78aac3051
Merge pull request #4778 from pi-hole/fix/epel_mirrors
...
Fix for epel mirror timeouts
2022-07-03 11:57:21 -07:00
Dan Schaper
6efb3a3372
Fix for epel mirror timeouts
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-03 11:48:12 -07:00
Dan Schaper
2845c72bde
Add testing dependencies for CentOS7 and dialog
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-03 11:08:56 -07:00
Dan Schaper
a650641da4
Change tests to mock dialog
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-03 11:08:56 -07:00
Dan Schaper
1ed5ff306d
Align dialog texts.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-03 11:08:56 -07:00
Dan Schaper
bf57a786e6
Convert whiptail to dialog.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-03 11:08:56 -07:00
yubiuser
37889f27de
Merge pull request #4775 from pi-hole/fix/centos_epel
...
Directly download CentOS 7 epel-release
2022-07-03 20:08:21 +02:00
Dan Schaper
80bef5f6b6
Direct pull for epel-release
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-07-03 10:47:05 -07:00
DL6ER
bd8288d6ef
Special renaming for pihole-FTL.* to pihole/FTL.log.*
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-07-03 18:54:13 +02:00
DL6ER
98c238064e
Change FTL's default log file path from /var/log/pihole/pihole-FTL.log to /var/log/pihole/FTL.log
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-07-03 18:43:45 +02:00
DL6ER
312fa6d134
Merge pull request #4776 from pi-hole/less_stale
...
Run stale workflow at 8:00 once per day
2022-07-03 16:30:12 +02:00
Christian König
a783da823e
Run stale workflow at 8:00 once per day
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-03 14:40:03 +02:00
yubiuser
17485023a2
Merge pull request #4713 from pi-hole/new/code-spell
...
Add code-spell action / Move editorconfig-checker action to smoke-tests
2022-07-02 17:26:50 +02:00
Adam Warner
0be987239e
Adds spellcheck action to the smoke-tests (also moves editorconfig-checker to smoketests away from it's own action)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-07-02 14:04:08 +01:00
Adam Warner
75f40e7160
Merge pull request #4771 from pi-hole/action/ediorconfig-checker
...
Action/editorconfig checker
2022-07-02 13:24:41 +01:00
Christian König
73d5902bed
Add editorconfig-checker workflow
...
Add yml style to editorconfig
Add markdown styling to editorconfig
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-07-02 09:36:52 +02:00
yubiuser
eb045a0dea
Merge pull request #4773 from pi-hole/yamllint_and_mkdownlint
...
Add mkdown and yaml linters to stickler
2022-07-01 11:46:54 +02:00
Christian König
b70b895fc5
Add mkdown and yaml linters to stickler
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-29 20:07:43 +02:00
yubiuser
46331e415c
Merge pull request #4762 from pi-hole/drop_fedora
...
Update test to reflect currently supported OS
2022-06-28 21:45:50 +02:00
Dan Schaper
dcea3cf2c6
Merge branch 'development' into drop_fedora
2022-06-27 11:48:26 -07:00
yubiuser
e02c7ff249
Merge pull request #4760 from pi-hole/hands_off
...
Remove read permission for others on sensible log files
2022-06-27 00:27:24 +02:00
Adam Warner
f3d062aaf4
Merge pull request #4770 from pi-hole/master
...
sync: master to development
2022-06-26 13:20:18 +01:00
Adam Warner
bacb98be32
Merge pull request #4767 from pi-hole/stale_reason
...
Add stale-issue-reason: not planned
2022-06-26 13:19:47 +01:00
Adam Warner
7ef7719b6b
Merge pull request #4761 from pi-hole/re_sudo
...
Require sudo for pihole -t
2022-06-26 13:18:07 +01:00
Christian König
f740e0fefb
Ubt22 is jammy not impish
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-25 23:11:16 +02:00
Christian König
a33f71289d
Re-add centos_7
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-25 23:09:10 +02:00
Christian König
8c498acd4c
Re-add Ubuntu21 tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-25 23:04:16 +02:00
yubiuser
3d773beff2
Merge pull request #4769 from pi-hole/tweak/editorconfig
...
Remove unnecessary file types from editorconfig
2022-06-25 22:35:55 +02:00
Christian König
d88ab2ca60
Remove unnecassry file types from editorconfig
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-24 19:57:44 +02:00
Christian König
287d5d37b1
Add stale-issue-reason: not planned
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-24 08:33:21 +02:00
Christian König
f9d1893f96
Update test to reflect currently supported OS
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-20 10:34:32 +02:00
Christian König
2c5907a8b1
Requiere sudo for pihole -t
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-19 23:25:53 +02:00
Christian König
954a0c2a14
Remove read permission for others on senible log files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-19 23:09:05 +02:00
yubiuser
b20aa865b9
Merge pull request #4757 from pi-hole/4751-unable-to-locate-php00-common
...
Exit installer if no valid PHP version is found
2022-06-15 06:45:05 +02:00
Christian König
ed8c6c04d4
Use PHP_VERSION
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-14 23:04:31 +02:00
Christian König
4b674ecfe3
Fix first install
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-14 00:58:10 +02:00
Christian König
5818f3f997
Check for validity first
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-14 00:05:27 +02:00
Christian König
7d731870e5
Fix stickler
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-13 16:06:59 +02:00
Christian König
1f26e85399
Exit installer if no valid PHP version is found
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-13 15:50:51 +02:00
Adam Warner
de02220a12
Merge pull request #4756 from pi-hole/PromoFaux-patch-1
...
Update dependabot.yml
2022-06-12 13:25:47 +01:00
Adam Warner
4d24fa6c15
Merge pull request #4755 from pi-hole/dependabot/github_actions/development/actions/setup-python-4
...
Bump actions/setup-python from 3 to 4
2022-06-12 13:12:26 +01:00
dependabot[bot]
50d14fb6db
Bump actions/setup-python from 3 to 4
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 3 to 4.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-06-12 11:35:59 +00:00
Adam Warner
b6cc845caf
Merge pull request #4733 from pi-hole/dependabot/github_actions/development/github/codeql-action-2
...
Bump github/codeql-action from 1 to 2
2022-06-12 12:35:25 +01:00
Adam Warner
635b67dbf3
Merge pull request #4732 from pi-hole/dependabot/github_actions/development/actions/stale-5
...
Bump actions/stale from 4 to 5
2022-06-12 12:35:04 +01:00
Adam Warner
e7289563df
Merge pull request #4731 from pi-hole/dependabot/github_actions/development/actions/checkout-3
...
Bump actions/checkout from 2 to 3
2022-06-12 12:33:57 +01:00
Adam Warner
d501b676e9
Merge pull request #4730 from pi-hole/master
...
sync: master to development
2022-06-12 12:31:27 +01:00
Adam Warner
fbc0b57dd1
Update dependabot.yml
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-06-12 12:30:29 +01:00
yubiuser
cf0fcf3ad7
Merge pull request #4356 from yubiuser/remove_IPvX_setupVars
...
Remove IPv4 and IPv6 adresses from setupVars.conf
2022-06-12 13:23:55 +02:00
DL6ER
e2e803f76c
Merge pull request #4508 from Omoeba/fix-ipv6
...
Fix IPv6 support when Pi-hole is a router
2022-06-06 14:20:07 +02:00
Christian König
2c07d27ad7
Forgot two places
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-04 22:42:41 +02:00
Christian König
0b9d4a47ad
Remove IPv4 and IPv6 adresses from setupVars.conf
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-06-04 22:38:00 +02:00
Dan Schaper
67f5f16f84
Merge branch 'development' into fix-ipv6
2022-06-02 12:24:01 -07:00
yubiuser
ae9d16baf2
Merge pull request #3732 from pi-hole/tweak/moveloglocation
...
Utilise /var/log/pihole/ for log storage
2022-05-31 22:59:32 +02:00
Dan Schaper
fe51a4f8d0
Merge pull request #4749 from pi-hole/webroot
...
Do not hardcode webroot dir for teleporter
2022-05-31 11:46:58 -07:00
Christian König
300c7b1518
Do not hardcode webroot dir for teleporter
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-31 14:11:39 +02:00
yubiuser
5241c1c704
Merge pull request #4747 from pi-hole/lighttpd_logs
...
Change lighttpd log file names
2022-05-30 21:51:19 +02:00
Christian König
dae96e7384
Change lighttpd log file names
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-29 21:04:18 +02:00
yubiuser
3fa8f76d99
Combine mkdir in service file
...
Co-authored-by: MichaIng <micha@dietpi.com >
2022-05-29 16:15:18 +02:00
Christian König
52c3df1a8e
lighttpd log dir is now different than Pi-hole log dir
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-28 21:21:48 +02:00
yubiuser
477df86ff1
Merge pull request #4738 from pi-hole/tweak/service_file
...
Always install pihole-FTL.service file
2022-05-21 06:46:56 +02:00
Christian König
b7742ddb9b
Always install pihole-FTL.service file
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-19 06:17:46 +02:00
Christian König
ce8731b746
no-dereference
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-18 22:19:19 +02:00
Christian König
08faf21b2e
Set file owner and permission to symlinks
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-18 22:06:36 +02:00
Christian König
60615e60aa
Make sure FTL is stopped before old logfiles are moved
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-18 21:11:38 +02:00
Christian König
2dd08f070e
Fix copy&paste error
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-15 23:30:02 +02:00
Christian König
110e752552
Move existing log files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-15 22:30:17 +02:00
Christian König
0961103933
Add backward compatibility to FTL service by creating symlinks
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-15 22:10:40 +02:00
Christian König
0fa94e0946
Remove unused test which was commented since 5 years by PR 1244
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-15 20:26:25 +02:00
Christian König
9b9acfd4a7
Remove log files from new location during uninstalling
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-05-15 20:22:06 +02:00
Adam Warner
82695aba7d
update LOG_DIRECTORY variable in debug script
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-05-15 07:09:27 +02:00
Adam Warner
36dd533ef3
use directory /var/log/pihole/ for log storage
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-05-15 06:46:23 +02:00
Dan Schaper
2735481da8
Logo for light and dark modes. ( #4735 )
...
* Logo for light and dark modes.
2022-05-14 14:25:57 -07:00
dependabot[bot]
edec1220fc
Bump github/codeql-action from 1 to 2
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/github/codeql-action/compare/v1...v2 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-12 07:24:06 +00:00
dependabot[bot]
c5b3f6c27a
Bump actions/stale from 4 to 5
...
Bumps [actions/stale](https://github.com/actions/stale ) from 4 to 5.
- [Release notes](https://github.com/actions/stale/releases )
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/stale/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: actions/stale
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-12 07:24:01 +00:00
dependabot[bot]
1d033ef441
Bump actions/checkout from 2 to 3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-05-12 07:23:57 +00:00
Dan Schaper
83ac2c5005
Merge pull request #4729 from pi-hole/fix/dependabot_action_yaml
...
Typo fix on dependabot yaml.
2022-05-12 00:23:29 -07:00
yubiuser
0decc1252b
Respect user configurable path for pid and port file in pihole-FTL.service ( #4680 )
...
* Use pid file in pihole-FTL.service
Signed-off-by: Christian König <ckoenig@posteo.de >
Co-authored-by: MichaIng <micha@dietpi.com >
2022-05-11 16:03:44 -07:00
Dan Schaper
f2e1cc9dae
Typo fix on dependabot yaml.
2022-05-11 12:28:32 -07:00
Omoeba
f7c800863e
Remove DHCPv6, use leasetime from interface ( #4507 )
...
Signed-off-by: Omoeba <38597972+Omoeba@users.noreply.github.com >
2022-05-11 11:57:42 -07:00
yubiuser
6d73454942
Merge pull request #4718 from sed-i/patch-1
...
Add example for custom DNS server with port number
2022-05-09 17:24:26 +02:00
yubiuser
2e2a3aa048
Add port info to explanation text
2022-05-09 17:14:16 +02:00
Leon
e23e291dd4
Merge branch 'development' into patch-1
2022-04-25 19:47:01 -04:00
Leon
6a0c6c4a9b
Add example for custom DNS server with port number
...
Signed-off-by: sed-i <82407168+sed-i@users.noreply.github.com >
2022-04-25 19:00:01 -04:00
yubiuser
94cb0d0a7e
Merge pull request #4709 from pi-hole/follow-my-own-rules
...
[Housekeeping] Remove alphabetical rule from utils.sh
2022-04-21 21:07:08 +02:00
Adam Warner
d78c689e55
no more alphabetical order
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-04-21 19:56:21 +01:00
Adam Warner
3915efbfd5
Merge pull request #4706 from pi-hole/master
...
sync: master to development
2022-04-20 19:43:29 +01:00
Adam Warner
853f6b7da2
Merge pull request #4705 from pi-hole/development
...
v5.10 Release
2022-04-20 19:41:17 +01:00
Adam Warner
73aa43611f
Merge pull request #4700 from spmfox/4697-centos8-container-ftl-arch
...
Changed ldd binary check for better compatibility
2022-04-20 19:27:45 +01:00
Dan Schaper
c19788dd18
Mock which sh to reutrn /bin/sh.
...
Check for `/bin/sh` library
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-20 11:22:58 -07:00
Dan Schaper
71072b4beb
Stickler quoting
2022-04-20 10:21:24 -07:00
yubiuser
c9383eab99
Merge pull request #4704 from jpgpi250/remove_trailing_periods
...
Update gravity.sh
2022-04-20 17:35:24 +02:00
Peter Russell
052a1f294e
Update gravity.sh
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
2022-04-20 10:44:05 +02:00
Peter Russell
325f20d5c2
Update gravity.sh
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
2022-04-20 10:43:56 +02:00
Peter Russell
1c28da7bbd
Update gravity.sh
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
2022-04-20 10:43:39 +02:00
jpgpi250
aba5e884eb
Update gravity.sh
...
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
2022-04-20 10:19:44 +02:00
Adam Warner
9ac5690a7d
Merge pull request #4698 from pi-hole/fix-utils-redux
...
[utils.sh] Split `addOrEditKeyValuePair` to do `addKey` in a separate function
2022-04-19 19:00:06 +01:00
Adam Warner
8de814ab34
Split the tests, too. Enhance the descriptions
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-04-19 18:35:56 +01:00
yubiuser
7929a6c133
Merge pull request #4694 from MichaIng/patch-1
...
Do not pass whole environment for PIHOLE_SKIP_OS_CHECK=true
2022-04-19 19:34:22 +02:00
spmfox
9840148ba9
Update automated install/basic-install.sh
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-17 14:52:05 -04:00
Adam Warner
7e223a2a10
Merge pull request #4699 from turrisxyz/setup-permissions
...
Set permissions for GitHub actions
2022-04-17 13:43:35 +01:00
Adam Warner
c9e76c978e
Update advanced/Scripts/webpage.sh
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
2022-04-17 13:39:55 +01:00
spmfox
2601162243
Changed ldd binary check from /bin/ls to /usr/bin/bash
...
Signed-off-by: spmfox <spmfox@foxwd.com >
2022-04-16 16:46:07 -04:00
naveensrinivasan
37cef84643
Set permissions for GitHub actions
...
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ )
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com >
2022-04-15 21:26:56 -05:00
Adam Warner
23e6fa1ec5
Replace wrapper function calls with direct utils.sh calls. Leave warpper functions until next release as docker currently uses them, and new changes to utils.sh need to be in the master branch before docker can use them
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-04-15 09:50:40 +01:00
Adam Warner
db116971ce
I tried to do too many things in one function, vastly overcomplicating what should have been _this_ all along
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-04-14 22:53:38 +01:00
MichaIng
2b124b1c69
Do not pass whole environment for PIHOLE_SKIP_OS_CHECK=true
...
With `sudo -E`, the whole environment is passed to the root shell, which is a potential security and/or privacy issue when command overrides/functions, PATH or private user info are passed. To pass `PIHOLE_SKIP_OS_CHECK=true`, it can be passed alone to the bash/script call within the sudo session, so the `-E` flag can be omitted.
Signed-off-by: MichaIng <micha@dietpi.com >
2022-04-13 21:30:12 +02:00
yubiuser
9356d7bbb1
Remove unnecessary case in uninstall script ( #4692 )
...
* Remove unnecessary case in uninstall script
* Better answer
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-04-12 11:36:49 -07:00
Adam Warner
29a867d5ae
Merge pull request #4690 from pi-hole/utils-sourcing
...
Prevent issues cause by declaring `utilsfile` as `readonly`
2022-04-12 19:17:37 +01:00
Adam Warner
86dd612882
remove readonly directive from declaration of utilsfile, it is unnecassery
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-04-12 17:13:50 +01:00
yubiuser
42d3368955
Merge pull request #4663 from pi-hole/no_root
...
Only use sudo power if needed
2022-04-10 12:34:05 +02:00
yubiuser
21ae81ffdb
Merge pull request #4682 from pi-hole/loop
...
Exit installer if dpkg lock is held for more then 30 seconds
2022-04-07 15:26:27 +02:00
yubiuser
b33434d02a
Let uses know how long they need to wait (max)
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2022-04-07 09:11:53 +02:00
yubiuser
d3e94cbceb
Merge pull request #4653 from pi-hole/refactor-utils-redux
...
Tweaks to functions in utils.sh and refactored usages in webpage.sh
2022-04-04 23:25:54 +02:00
yubiuser
9b4f6c84cd
Minor review comments
2022-04-04 23:14:10 +02:00
Adam Warner
4d31d5ee11
Address review comments
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-04-04 22:02:26 +01:00
Adam Warner
9878477896
Merge pull request #4681 from pi-hole/adlist
...
Rename block lists to adlists within the query list functions
2022-04-04 16:42:43 +01:00
Christian König
c0a2ab7b77
Fix indention
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-04-04 16:59:13 +02:00
Christian König
30ba79f6a0
Let users know what's going on
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-04-04 16:48:34 +02:00
Christian König
cd3c97f113
Exit installer if dpkg lock is held for more then 30 seconds
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-04-04 16:38:30 +02:00
Christian König
e4a1f3a175
Rename block lists to adlists within the query list functions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-04-04 13:52:26 +02:00
yubiuser
6121c162ff
Fix typo
...
Co-authored-by: Marius Hanl <66004280+Maran23@users.noreply.github.com >
2022-04-03 13:49:43 +02:00
Adam Warner
0d74b27101
Merge pull request #4646 from pi-hole/tweak/debug_message
...
Pool identical messages in debug output
2022-04-02 13:14:44 +01:00
Adam Warner
7fa8cdd03e
Address:
...
- Review Comments
- Stickler Complaints
2022-04-02 12:46:07 +01:00
Adam Warner
fe9031b26f
Merge pull request #4669 from pi-hole/master
...
sync: master to development
2022-04-02 00:05:49 +01:00
Dan Schaper
326cd6a1f8
Merge pull request #4665 from pi-hole/fix/touch_guard
...
Wrap touch calls with if/then guards for Buster docker.
2022-04-01 15:25:41 -07:00
Adam Warner
063f92f8f4
Merge pull request #4667 from pi-hole/test/hirsute_eol
...
Hirsute buildpack EOL upstream. Adding impish.
2022-04-01 23:23:35 +01:00
Adam Warner
be6a73f102
Merge pull request #4668 from pi-hole/test/python_3.8
...
Bump to python action v3. v2 has many changes.
2022-04-01 23:23:24 +01:00
Dan Schaper
b714c4598a
Found it.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-01 14:49:30 -07:00
Dan Schaper
0f192998eb
Create empty files.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-01 14:17:57 -07:00
Dan Schaper
8a5c7dec71
Ensure existing files are proper owner and mode.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
co-authored-by: RD WebDesign <github@rdwebdesign.com.br >
2022-04-01 14:08:09 -07:00
Dan Schaper
69e4e9a2ae
Bump to python action v3. v2 has many changes.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-01 12:53:43 -07:00
Dan Schaper
4230be0c80
Hirsute buildpack EOL upstream. Adding impish.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-01 12:00:14 -07:00
Dan Schaper
d45c9fc522
Final touch to install fix.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-04-01 11:08:26 -07:00
yubiuser
efa99a177e
Merge pull request #4664 from rdwebdesign/fix/docker_1015
...
Remove `@` and following character from interface name
2022-04-01 07:47:43 +02:00
Dan Schaper
c2384ecc6f
Change touch that would always fire to install.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-03-31 14:23:39 -07:00
Dan Schaper
2f38452565
Wrap touch calls with if/then guards for Buster docker.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2022-03-31 12:03:17 -07:00
RD WebDesign
5cebceadda
Remove @ and following character from interface name
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-03-30 21:32:18 -03:00
Christian König
722a716de3
Add exit code to status function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-03-30 22:40:14 +02:00
Christian König
614d18cd3d
Debug need sudo
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-03-30 21:24:51 +02:00
Christian König
54ce8c2622
Only use sudo power if needed
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-03-30 21:04:36 +02:00
yubiuser
329c161054
Merge pull request #4659 from rdwebdesign/fix4656_part2
...
Select the protocol on the blocking page
2022-03-29 21:59:39 +02:00
RD WebDesign
f8e84b3c3f
Fix stickler
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-03-23 18:45:18 -03:00
RD WebDesign
c9809371ab
Selecting the protocol
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-03-23 18:33:15 -03:00
yubiuser
a48750e257
Merge pull request #4657 from rdwebdesign/fix4656
...
Add check to avoid error in PHP 8 on the blocking page
2022-03-22 00:37:57 +01:00
RD WebDesign
0d4c69cc6f
Add check to avoid error in PHP 8
...
and return some information about the unexpected value
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-03-21 18:59:46 -03:00
yubiuser
479b2bc075
Merge pull request #4655 from y0ngb1n/fix-wrong-words
...
Fixed wrong words in `README.md`
2022-03-17 13:46:27 +01:00
Yang Bin
2ade05d60f
Fixed wrong words in README.md
...
Signed-off-by: Yang Bin <y0ngb1n@163.com >
2022-03-17 18:58:37 +08:00
Adam Warner
59fc3804be
Make utils.sh posix compatible per request
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-03-16 20:40:25 +00:00
Adam Warner
48138d32b6
Adjust addOrEditKeyValPair to optionally take two or three arguments (adjust test to suit)
...
Add a removeKey function with test
update webpage.sh to reference functions in utils.sh (this can likely be abstracted/refactored further)
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-03-16 17:42:01 +00:00
yubiuser
ff5e788889
Merge pull request #4652 from rdwebdesign/debuglog_improvements
...
Improving debug log
2022-03-16 07:00:59 +01:00
RD WebDesign
ab7d83384f
Allow lighttpd to stream responses to browser
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-03-15 15:33:56 -03:00
Christian König
48136c5bbc
Add last timestamp
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-03-14 19:54:46 +01:00
Christian König
0219e5dfe0
Pool identical messages in debug output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-03-12 21:00:48 +01:00
Adam Warner
0631cb4984
Merge pull request #4645 from rdwebdesign/color_debug_web
...
Generate colorful debug logs to web interface
2022-03-12 18:02:49 +00:00
RD WebDesign
40b96e673b
Allows colorful debug logs via web interface
...
Note: needs the AdminLTE code changes to work.
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br >
2022-03-12 02:58:46 -03:00
Adam Warner
36ca858668
Merge pull request #4641 from pi-hole/master
...
sync: master to development
2022-03-05 15:57:30 +00:00
Adam Warner
899cac0aac
Ignore Documentation Needed label
2022-03-05 15:49:54 +00:00
Adam Warner
16b732fe8a
Merge pull request #4629 from pi-hole/tweak/api_port
...
Tweak/api port
2022-03-05 15:47:35 +00:00
DL6ER
1bf2f8d0b7
Merge pull request #4635 from pi-hole/procps
...
Add procps to dependencies
2022-03-01 21:11:04 +01:00
Christian König
c756bcb9d1
Add procps to dependencies
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-03-01 09:07:51 +01:00
Christian König
42424b515b
Add getFTLAPIPort function
...
Add ftl_api_port function
Signed-off-by: Christian König <ckoenig@posteo.de >
Use getFTLAPIPort in pihole
Signed-off-by: Christian König <ckoenig@posteo.de >
Use default portfile as fallback
Signed-off-by: Christian König <ckoenig@posteo.de >
Fix stickler
Signed-off-by: Christian König <ckoenig@posteo.de >
Correct variables
Signed-off-by: Christian König <ckoenig@posteo.de >
Apply suggestions from code review
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
Add test getFTLAPIPort returing default port
Signed-off-by: Christian König <ckoenig@posteo.de >
Remove unused code from test_key_val_replacement_works
Signed-off-by: Christian König <ckoenig@posteo.de >
Add getFTLAPIPort_custom test
Signed-off-by: Christian König <ckoenig@posteo.de >
Fix output format
Signed-off-by: Christian König <ckoenig@posteo.de >
Add debugging
Signed-off-by: Christian König <ckoenig@posteo.de >
Remove debugging and fix function
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-02-27 18:16:53 +01:00
Adam Warner
bd956b5f16
Merge pull request #4625 from pi-hole/master
...
sync: master to development
2022-02-20 12:42:21 +00:00
Adam Warner
9be5199f7c
remove the CONTENT_COMPARISON setting (defaults to false)
2022-02-20 12:39:58 +00:00
yubiuser
9db19c5e96
Merge pull request #4621 from pi-hole/new/set_rate_limit
...
Add backend option to set rate-limit from the dashboard
2022-02-19 21:19:57 +01:00
DL6ER
91b4233d3a
Add backend option to set rate-limit from the dashboard
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-02-19 14:46:32 +01:00
Adam Warner
0b905c28c1
Merge pull request #4609 from pi-hole/fix/flush
...
Fix log flush with new query database schema
2022-02-13 00:38:28 +00:00
Christian König
f4286a4d12
Fix log flush with new query database schema
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-02-12 23:33:19 +01:00
Adam Warner
6ffa2ba1b2
Merge pull request #4547 from pi-hole/development
...
Pi-hole Core v5.9
2022-02-12 20:04:20 +00:00
Adam Warner
e9250d62c5
Merge pull request #4598 from pi-hole/alt-4597
...
Use case insensitive deletion when removing custom CNAME/DNS records
2022-02-04 21:26:33 +00:00
Adam Warner
08999bf315
Use case insensitive deletion when removing custom CNAME/DNS records in case of manual entries with mixed case having been added
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-02-04 21:16:02 +00:00
Adam Warner
2bd670a3dd
Merge pull request #4582 from lschloetterer/patch-1
...
add parameter to set filename for teleporter
2022-02-04 20:44:49 +00:00
Adam Warner
f342b2c9f6
Merge pull request #4489 from pi-hole/tweak/manpages
...
Remove pihole-FTL.conf manpage
2022-02-04 20:36:32 +00:00
Lukas Schlötterer
2a0bb5b9ee
Create second entry for teleporter and adjust spacing
...
Signed-off-by: Lukas Schlötterer <80917404+lschloetterer@users.noreply.github.com >
2022-02-04 21:29:23 +01:00
yubiuser
c3c5342b48
Fix reviewer's comment
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2022-02-04 21:11:54 +01:00
Christian König
d7d8e9730b
Remove pihole-FTL.conf.5 from automated tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-02-04 20:43:47 +01:00
Christian König
7c60ee8df1
Remove pihole-FTL.conf man page
...
Signed-off-by: Christian König <ckoenig@posteo.de >
Remove double https://
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-02-04 20:43:47 +01:00
Adam Warner
ee9f4856a2
Merge pull request #4596 from pi-hole/long-live-centos8-stream
...
Switch from centos8 to centos8:stream base image for centos 8 tests
2022-02-03 19:05:16 +00:00
Adam Warner
444526ad58
Switch from centos8 to centos8:stream base image for centos 8 tests
2022-02-03 18:43:19 +00:00
DL6ER
844c4dcdc8
Merge pull request #4584 from pi-hole/fix/gravity_internal_sqlite3
...
Replace calls to sqlite3 by calls to pihole-FTL sqlite3
2022-02-03 05:45:04 +01:00
Lukas Schlötterer
881d92632c
add hint for custom teleporter filename to help function
...
Signed-off-by: Lukas Schlötterer <80917404+lschloetterer@users.noreply.github.com >
2022-02-01 09:41:57 +01:00
DL6ER
76d4e1209f
Merge pull request #4585 from pi-hole/tweak/sed-add-if-not-exists
...
Replace value for BLOCKING_ENABLED, add if it does not already exist
2022-02-01 07:45:34 +01:00
DL6ER
d956498c8c
Merge pull request #4575 from pi-hole/fix/tag_update
...
Fix updating based on tags on older git versions by doing a full fetch
2022-02-01 07:44:23 +01:00
DL6ER
e09dd56807
Remove RPM package sqlite as well
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-02-01 07:38:57 +01:00
DL6ER
30ec1c94cc
Merge pull request #4593 from pi-hole/master
...
sync: master to development
2022-02-01 07:37:47 +01:00
Adam Warner
5d68dac90e
Merge pull request #4588 from pi-hole/stale
...
Fix stale label to stale
2022-01-31 19:25:28 +00:00
Adam Warner
77e5121d43
Split new function out into a separte utility script and add a test for it. Can be used in future to organise re/commonly-used code
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-01-30 23:05:28 +00:00
DL6ER
74d7d10554
Orphans need to be deleted in the old database
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-30 21:09:24 +01:00
Christian König
2f4c4d9176
Fix stale label to stale
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-30 20:13:10 +01:00
Adam Warner
1dd9d55d82
Replace value for BLOCKING_ENABLED (and QUERY_LOGGING, for consistency) and if value that we are trying to replace does not exist, add it to the end of the file.
...
Co-authored-by: MichaIng <micha@dietpi.com >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-01-30 15:53:03 +00:00
DL6ER
8cbffa179d
Replace remaining sqlite3 calls by calls to our embedded pihole-FTL sqlite3 engine and remove sqlite3 as dependency in the installer.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-30 11:18:17 +01:00
DL6ER
5bb79de70b
Clean possible leftovers in domainlist_by_group, adlist_by_group, and client_by_group before copying from database base to avoid foreign key violations.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-30 10:38:24 +01:00
DL6ER
534f9a63bf
Copy database tables earlier into the new gravity database to avoid foreign key contraint violations when adding gravity entries refering to an empty adlist table
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-30 10:36:20 +01:00
DL6ER
f0f5cc52d9
Use internal SQLite3 engine in more places in gravity.sh
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-29 22:39:45 +01:00
Lukas Schlötterer
bad6d8a59e
add parameter to set filename for teleporter
...
Make it possible to write pihole -a -t myname.tar.gz to configure the filename however you want
Signed-off-by: Lukas Schlötterer <80917404+lschloetterer@users.noreply.github.com >
2022-01-28 16:26:57 +01:00
Christian König
7aa28e4a3a
Do a full fetch
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-22 22:09:15 +01:00
Adam Warner
e80a7731c9
Merge pull request #4568 from pi-hole/master
...
sync: master to development
2022-01-16 16:26:50 +00:00
Adam Warner
3cd662eaeb
Merge pull request #4558 from pi-hole/stale
...
Change the exemption issue label pinned to internal for stale issues
2022-01-16 14:59:17 +00:00
RD WebDesign
6ead24b315
Move space into variable ( #4562 )
...
Signed-off-by: rdwebdesign <github@rdwebdesign.com.br >
2022-01-14 17:00:34 +01:00
Christian König
cdde832ed3
Some use uppercase some don't...
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-13 09:16:31 +01:00
Christian König
57ba60ce54
Change the exemption issue label pinned to internal for stale issues
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-13 09:13:40 +01:00
Lukas Schlötterer
ed6b85241b
use sed substitute instead of delete and append ( #4555 )
...
* use sed substitute instead of delete and append
doesn't move the line to the end of the file, instead keeps the order of the lines in setupVars.conf intact
Signed-off-by: Lukas Schlötterer <80917404+lschloetterer@users.noreply.github.com >
* Match start of line
as suggested in the review
Signed-off-by: Lukas Schlötterer <80917404+lschloetterer@users.noreply.github.com >
Co-authored-by: yubiuser <ckoenig@posteo.de >
Co-authored-by: yubiuser <ckoenig@posteo.de >
2022-01-12 09:23:13 +01:00
Adam Warner
918f7a504c
Merge pull request #4554 from pi-hole/master
...
sync: master to development
2022-01-11 19:20:18 +00:00
Adam Warner
3260cb40b5
ops per run -> 300 for stale
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-01-11 19:17:29 +00:00
Adam Warner
a79c1159a9
Merge pull request #4550 from pi-hole/master
...
sync: master to development
2022-01-11 09:11:51 +00:00
Adam Warner
65a04246cd
Merge pull request #4548 from pi-hole/actions/sync-to-dev
...
[Maintenance] Sync Master back to Dev when code is pushed to master
2022-01-11 09:10:59 +00:00
Adam Warner
f1245685dc
Add action to automatically sync master to dev when code is pushed to master
...
Add in a release.yml to ignore github-actions author when auto-generating release notes
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-01-11 08:53:35 +00:00
DL6ER
ec3a5c2989
Merge pull request #4543 from pi-hole/tweak/debug_ipaddr
...
Include ip addr show and ip route show in debug log
2022-01-09 12:53:37 +01:00
DL6ER
b20b38d44f
Include ip addr show and ip route show for us to help with local-service issues (where hops-away is measured)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-09 12:38:22 +01:00
DL6ER
d5253f26f4
Merge pull request #4542 from pi-hole/remove_oneline
...
Remove oneline from ss call
2022-01-09 11:39:33 +01:00
Christian König
a65a841c56
Remove oneline from ss call
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-09 07:13:51 +01:00
Adam Warner
1b0b24daf5
Merge pull request #4539 from pi-hole/master
...
Sync Master -> Dev
2022-01-08 22:35:46 +00:00
Adam Warner
7010ed454c
Merge pull request #4532 from MichaIng/patch-1
...
Install netcat-openbsd as dependency explicitly
2022-01-08 15:17:01 +00:00
DL6ER
ce86157067
Fix gravity in case there are no adlists at all or all are disabled ( #4535 )
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-08 14:15:26 +01:00
Adam Warner
3097c8fbdc
Skip the required ports check if installed in docker container. Unpriv'ed containers do not have access to the information required to resolve the service name listening - and the container should not start if there was a port conflict anyway ( #4536 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-01-08 13:57:49 +01:00
Adam Warner
363e2f10bb
Merge pull request #4534 from pi-hole/meta/enable_stale
...
Enable Stale Action for live use
2022-01-08 11:42:48 +00:00
Dan Schaper
bfd9fe80ef
Remove debug from Stale
...
Put Stale in to action.
2022-01-08 01:42:35 -08:00
MichaIng
c2080324b7
Install netcat-openbsd as dependency explicitly
...
Since Debian Stretch and Ubuntu Bionic, the "netcat" package is a transitional dummy package which pulls in "netcat-traditional" on Debian Stretch+Buster and Ubuntu Bionic, and "netcat-openbsd" on Debian Bullseye, Ubuntu Focal and up.
On Debian Bookworm (testing), however, the "netcat" package has been removed during the last 3 days at time or writing, so that it fails do be installed. While "netcat-traditional" and "netcat-openbsd" both "Provides: netcat", since it's two alternatives, APT does not automatically pick one but aborts, and the only solution is to install one explicitly.
While this is likely a temporary state of the Debian testing suite, having a closer look at the two alternatives shows that "netcat-openbsd" is a much more actively maintained newer version with additional support for IPv6, proxies, and UNIX sockets, which is likely the reason for the gradual transition via meta package from "netcat-traditional" to "netcat-openbsd". This commit hence consequently follows this aim by skipping the transitional dummy package and installing "netcat-openbsd" explicitly as dependency, to avoid any possible errors like the one which occurs currently on Bookworm.
Both packages can be installed concurrently and do no conflict, but are managed via dpkg's "update-alternatives".
For reference:
- https://packages.debian.org/netcat
- https://packages.ubuntu.com/netcat
Signed-off-by: MichaIng <micha@dietpi.com >
2022-01-07 18:55:15 +01:00
Adam Warner
875ad04fde
Merge pull request #4522 from pi-hole/development
...
v5.8.1
2022-01-05 23:00:01 +00:00
Adam Warner
0124e491d0
Merge pull request #4521 from pi-hole/fix/chronometer
...
Fix/chronometer
2022-01-05 22:51:43 +00:00
Christian König
81698ef1ed
Fix Pi-hole status in chronometer
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-05 21:09:57 +01:00
Adam Warner
2ff10fcd0a
Merge pull request #4514 from pi-hole/development
...
Pi-hole core v5.8
2022-01-05 18:24:21 +00:00
DL6ER
5823f5e254
Use ss instead of lsof ( #4518 )
...
* Use ss instead of lsof for pihole status checks
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Use ss FILTER instead of piping into bash
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Use ss in debug log generation
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Remove lsof from dependencies
Signed-off-by: DL6ER <dl6er@dl6er.de >
2022-01-05 16:41:46 +00:00
Adam Warner
7807a93e10
If PIHOLE_DOCKER_TAG is set, then include that info in the debug run ( #4515 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2022-01-04 21:46:06 +00:00
yubiuser
c6a2a6f739
Install pihole-FTL.conf template on fresh installation ( #4496 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-04 19:09:30 +00:00
yubiuser
241e53ed45
Skip debug upload question if called from web interface ( #4494 )
...
* Skip debug upload question if called from web interface
Signed-off-by: Christian König <ckoenig@posteo.de >
* Suppress upload error if users opt-out from uploading from web interface
Signed-off-by: Christian König <ckoenig@posteo.de >
* Fix and reverse logic
Signed-off-by: Christian König <ckoenig@posteo.de >
* Remove addtional space
Signed-off-by: Christian König <ckoenig@posteo.de >
* Include reviewer's comment :D
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2022-01-04 19:06:41 +00:00
Adam Warner
d605b4b8f9
Merge pull request #4513 from pi-hole/master
...
master->development
2022-01-04 16:57:33 +00:00
yubiuser
0e359a6321
Set dnsmasq interface listening by default to local ( #4509 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2022-01-04 09:40:07 +01:00
Omoeba
5b84cd0a61
Fix IPv6 support when Pi-hole is a router
...
Signed-off-by: Omoeba <38597972+Omoeba@users.noreply.github.com >
2022-01-03 04:02:01 -08:00
WaLLy3K
5bd7cc9c9d
Replace which with command -v ( #4499 )
...
Signed-off-by: WaLLy3K WaLLy3K@users.noreply.github.com
2022-01-01 18:02:20 +00:00
DL6ER
886f0c7df3
Merge pull request #4485 from pi-hole/tweak/web_status
...
Return the port FTL is listening on in pihole status function
2021-12-29 11:13:12 +01:00
Christian König
3989cc19e9
Remove double text output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-28 19:55:42 +01:00
Christian König
bcb59159ed
Analyse port also on ports other than 53
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-28 19:52:11 +01:00
Christian König
2b52f92647
Inlcude port also in cli output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-28 19:36:32 +01:00
Matthew Nickson
71ed842dfd
Fixed path to 404 file when using custom.php ( #4488 )
...
Signed-off-by: Computroniks <mnickson@sidingsmedia.com >
2021-12-28 19:32:06 +01:00
Christian König
f45248df80
Use FTL's new dns-port API endpoint
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-28 13:42:19 +01:00
Christian König
5729f64ddc
Fix missing fi
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-28 12:21:31 +01:00
Christian König
2a869419b4
Add netcat to dependencies
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-28 12:18:39 +01:00
yubiuser
4a2f4c1bce
Fix indention_2
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2021-12-28 12:11:46 +01:00
yubiuser
5ef731fc57
Fix indention
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2021-12-28 12:11:26 +01:00
Christian König
71ebd64f4e
mend
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-26 18:13:14 +01:00
Christian König
9f0e0dbd37
Fix analyse ports
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-26 18:10:36 +01:00
Christian König
ef30a85afb
Include port in status function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-26 17:10:48 +01:00
Adam Warner
1b809e4e8e
Merge pull request #4480 from pi-hole/development
...
Pi-hole Core v5.7
2021-12-22 20:24:59 +00:00
DL6ER
3d3bb45a46
Merge pull request #4288 from pi-hole/new/gravity_repair
...
Implement fully-automated gravity database recovery method
2021-12-22 21:08:01 +01:00
DL6ER
d2a98ae954
Document -r recover force case
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-12-22 19:53:52 +01:00
DL6ER
2e1ce7fc87
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de >
2021-12-22 19:52:08 +01:00
yubiuser
920cf6de14
Check for updates on master based on tags not commits ( #4475 )
...
* Check for updates on master based on tags not commits
Signed-off-by: Christian König <ckoenig@posteo.de >
* Fix stickler
Signed-off-by: Christian König <ckoenig@posteo.de >
* Address reviewer's comments
Signed-off-by: Christian König <ckoenig@posteo.de >
* Fix stickler again
Signed-off-by: Christian König <ckoenig@posteo.de >
* Use local git instead of relying on github
Signed-off-by: Christian König <ckoenig@posteo.de >
* Add --tags
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2021-12-22 18:21:44 +00:00
DL6ER
1eb31174a5
Merge pull request #4455 from pi-hole/comment
...
Add comment help text to list function
2021-12-21 22:26:05 +01:00
yubiuser
ff4487ff74
Escape quotes
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2021-12-21 22:10:56 +01:00
DL6ER
54c58327f1
Merge pull request #4450 from pi-hole/unblock_NODATA
...
Unblock adlist domain during gravity run in NODATA mode
2021-12-21 22:08:14 +01:00
yubiuser
db5e94b14a
use +short and omit obsolet awk
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2021-12-21 22:01:34 +01:00
DL6ER
7167e6d5e4
Apply suggestions from code review
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-12-21 16:20:02 +01:00
yubiuser
39a66b608b
Replace Contributing Guide by link to docs.pi-hole.net ( #4433 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-21 14:00:47 +01:00
DL6ER
b06efb6ab7
Declare variables local
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-12-21 14:00:46 +01:00
DL6ER
ab4bce4787
Allow users to force recovery even when checks are okay using "pihole -g -r recover force"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-12-21 13:57:03 +01:00
DL6ER
469c179b32
Return early from recovery routine when integrity checks didn't show any database errors.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-12-21 13:57:03 +01:00
DL6ER
190ab79606
Implement fully-automated gravity database recovery method.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-12-21 13:57:03 +01:00
yubiuser
669f1b0f4a
Address reviewer's comment
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2021-12-21 12:58:39 +01:00
DL6ER
31de661bbb
Merge pull request #4414 from pi-hole/debug/custom.list
...
Add custom.list (Local DNS Records) to debug log
2021-12-21 12:37:11 +01:00
DL6ER
3a67d1cf8d
Merge pull request #4461 from pi-hole/qr_iframe
...
Companion to pi-hole/adminlte #1996
2021-12-20 21:51:05 +01:00
DL6ER
c0f454ddfa
Add new interface listening option "bind" ( #4476 )
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-12-20 21:36:19 +01:00
DL6ER
ef0a22f9ec
Merge pull request #4478 from pi-hole/fix/db_permission
...
Gravity database handling improvements
2021-12-20 21:28:09 +01:00
Dan Schaper
533a77d6d5
Add database function failure guards.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-12-20 11:36:55 -08:00
Dan Schaper
76ae75689c
Check for DNS before run.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-12-20 11:09:11 -08:00
Dan Schaper
a780fc59e2
Set DBFile permissions on creation.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-12-20 10:56:42 -08:00
Christian König
28085cf7d8
Merge iFrame exceptions
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-17 10:08:16 +01:00
Dan Schaper
a3cc5df317
Configure stale action ( #4269 )
...
* Configure stale action
* [skip ci] Update .github/workflows/stale.yml
* Update .github/workflows/stale.yml
2021-12-16 20:19:11 +01:00
Christian König
2eff53b2bb
Allow qr code iframe
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-10 07:17:53 +01:00
Christian König
8d6ce78c65
Allow qr code iframe
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-10 07:09:42 +01:00
Christian König
b52a3a021d
Add comment help text to list function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-06 20:30:37 +01:00
yubiuser
ae39e338fe
Use exec to run gravity script ( #4449 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-04 10:50:21 +01:00
Christian König
e243c562c2
Unblock adlist domain during gravity run in NODATA mode
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-03 09:17:19 +01:00
DL6ER
4c267f7732
Merge pull request #4445 from pi-hole/fix/counting
...
Fix number of invalid domains
2021-12-03 08:56:54 +01:00
Christian König
647ba6ec9d
Rename variables to improve comprehensibility
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-02 23:13:01 +01:00
Subhaditya Nath
ba6d700e7e
Fix pihole -v output if WebAdmin not installed ( #4370 )
...
* Fix https://github.com/pi-hole/pi-hole/issues/4279
Signed-off-by: Subhaditya Nath <sn03.general@gmail.com >
* Don't ignore exit code of version.sh
If it exits with a non-zero return code, that means some error occurred,
and so it shouldn't be ignored.
Signed-off-by: Subhaditya Nath <sn03.general@gmail.com >
* Implement changes suggested by @Michalng
Signed-off-by: Subhaditya Nath <sn03.general@gmail.com >
* Implement changes suggested by @PromoFaux
Signed-off-by: Subhaditya Nath <sn03.general@gmail.com >
* Always source /etc/pihole/setupVars.conf
https://github.com/pi-hole/pi-hole/pull/4370#issuecomment-978149567
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2021-12-02 20:46:11 +00:00
Chiller Dragon
e485a7b9bb
Some shellchecks in basic-install.sh ( #4088 )
...
* Some shellchecks in basic-install.sh
Signed-off-by: ChillerDragon <ChillerDragon@gmail.com >
* Use more explicit grep (thanks to @MichaIng)
Signed-off-by: ChillerDragon <ChillerDragon@gmail.com >
2021-12-02 14:44:50 +01:00
Christian König
bfda52ed79
Fix number of invalid domains
...
Co-authored-by: abesnier <besnier_antoine@yahoo.fr >
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-12-01 11:07:17 +01:00
yubiuser
941f90d5c1
Merge pull request #4443 from MichaIng/patch-1
...
Fix generated /etc/os-release file in OS check test
2021-11-30 13:05:34 +01:00
MichaIng
14a379d448
Fix generated /etc/os-release file in OS check test
...
Signed-off-by: MichaIng <micha@dietpi.com >
2021-11-30 02:57:44 +01:00
yubiuser
671fcaffc3
Merge pull request #4085 from jbzdarkid/patch-3
...
Clean up bash script formatting
2021-11-26 09:23:31 +01:00
jbzdarkid
bc8150adfa
Clean up bash script formatting
...
Done with the help of beautysh (a python-based bash formatter)
Signed-off-by: jbzdarkid <jbzdarkid@gmail.com >
2021-11-25 14:12:09 -08:00
yubiuser
b750b01acc
Merge pull request #4434 from MichaIng/patch-1
...
Use a fixed list height for network interface selection
2021-11-22 16:37:58 +01:00
MichaIng
996a2c74fa
Use a fixed list height for network interface selection
...
This solves the issue reported here: https://github.com/pi-hole/pi-hole/issues/4196
It replaces the other suggested solution here: https://github.com/pi-hole/pi-hole/pull/4197
The benefit of using a fixed/limited list height, compared to allowing larger whiptail/dialogue dimension, is that it works on small screens as well, where the screen or console size itself is too small to hold the interface list + text above + whiptail frame.
It the amount of list elements exceeds the defined list height, automatically a visual scroll bar is added and the list can be scrolled with up/down pageup/pagedown buttons, hence it is generally not required to adjust a list height based on the amount of elements. The fixed height of "6" is chosen since all other "--radiolist" calls use this fixed height as well, it fits and looks good within a 20 rows high whiptail dialogue, and in the common Pi-hole use cases there are no more than 6 network interfaces.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-11-22 13:25:13 +01:00
DL6ER
d85fee27a9
Merge pull request #4420 from pi-hole/clean/webpage.sh
...
Remove unused code from webpage.sh
2021-11-20 21:13:50 +01:00
Adam Warner
cdd4d9ea9e
Update the tests ( #4427 )
...
* unpin the requirements and update all to latest available - needs more work still. see notes in `def host()`
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
* fix py3 monkey patch of testinfra docker using bash
Signed-off-by: Adam Hill <adam@diginc.us >
* update the other test files to use `host` instead of `Pihole`
Address some sticklr and codefactor
update python version from 3.7 to 3.8
preload `git` onto the centos/fedora test images, and switch which with command -v in the passthrough mock
testinfra is deprecated, use pytest-testinfra
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: Adam Hill <adam@diginc.us >
2021-11-18 01:03:37 +00:00
pvogt09
cedd1a2591
unit test for umask problems in #3177 and #2730 ( #3191 )
...
* add test for file permissions of $webroot
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* changes sudo to su for running command as user www-data
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* installs PIHOLE_WEB_DEPS to create LIGHTTPD_USER
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* changes stdout to rc
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* use installPihole instead of installPiholeWeb in test
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* try installation process with main
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* mock systemctl
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* removes stickler errors
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* start lighttpd and make webpage test optional
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* test all files and directories in $webroot
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* fix stickler and codefactor warnings
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* set permission for /var/cache if it did not exist before
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* add test case for pihole files
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* fix stickler errors
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* revert "set permission for /var/cache if it did not exist before" and make lighttpd start work
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* add --add-cap=NET_ADMIN to enable FTL start
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* specify DNS server for cURL
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* check files created by FTL
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* reorder code and change nameserver in /etc/resolv.conf
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* resolve with dig instead of relying on /etc/resolv.conf
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* set IP to 127.0.0.1 in setupVars.conf for blockpage tests
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* resolve domain with dig and remove debug output
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* fix stickler errors
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* no git pull in Github Action runs for pull requests
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* --cap-add=ALL test
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* fix stickler errors
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* remove debug code
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* update_repo patch for CentOS 7 in Github Actions
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* removes TODOs and stickler warnings
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* adds trailing slash to domain
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* use only first result from dig
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* domain name resolution does not work reliably in docker container
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* repair executable permission
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
* Create mock_command_passthrough that allows intercepting of specific arguments - everything else is passed through to the proper command. Use this new command instead of making changes in basic-install.sh to make the tests pass.
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2021-11-11 16:44:57 +00:00
yubiuser
ac4a975be5
Allow users to skip setting static IP adress ( #4419 )
...
* Allow users to skip setting static IP adresss
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-11-06 20:32:03 +00:00
yubiuser
996f8fff28
Recommend apt instead of apt-get if updating the package cache failed ( #4421 )
...
* Only change the recommendation to use apt
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-11-04 15:55:16 -07:00
Christian König
e733553295
Remove unused code from webpage.sh
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-11-02 21:22:14 +01:00
yubiuser
0c4e1b51ab
Merge pull request #4417 from aviddiviner/fix-rfc-config-docs
...
Fix documentation; add some missing zones
2021-10-28 20:13:42 +02:00
David Irvine
c6da1a3918
Fix documentation; add some missing zones
...
Signed-off-by: David Irvine <aviddiviner@gmail.com >
2021-10-28 12:09:34 +02:00
Christian König
c1eb35a35e
Add custom.list (Local DNS Records) to debug log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-26 22:46:52 +02:00
Adam Warner
b5e0f142cc
Merge pull request #4405 from pi-hole/development
...
Pi-hole v5.6
2021-10-23 20:01:27 +01:00
Blayne Campbell
8713135b01
update tests: remove fedora 32, add fedora 34 ( #4403 )
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2021-10-23 19:43:20 +01:00
DL6ER
7cdd8871e5
Merge pull request #4384 from pi-hole/tweak/local_dns_cname
...
Tweak local DNS record and CNAME
2021-10-23 16:38:52 +02:00
Christian König
596689b4c9
Validate host/domain of Local DNS records as well
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-19 21:34:16 +02:00
Christian König
a872fabe7d
Validate on removal as well
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-17 20:56:08 +02:00
Christian König
bc21a7155d
Add option to not reload
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-12 19:53:59 +02:00
Christian König
b7bba6a689
Validate when adding not when removing
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-12 19:32:55 +02:00
MichaIng
04f9e92bff
Fix PHP8.0 detection ( #4383 )
...
The phpInsNewer variable is not set anymore, so that the JSON module is now always tried to be installed. Instead of checking for phpInsNewer to derive whether PHP was installed already, phpInsMajor is now checked. If it is set, PHP is installed already, and only if the major version is lower than 8, the JSON module can be installed.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-10-11 20:43:12 +01:00
DL6ER
16fb6665ec
Merge pull request #4380 from pi-hole/df
...
Include df -h in debug log
2021-10-11 19:09:22 +02:00
Christian König
d84da71310
Only show lines not containing sensitive keywords
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-11 18:02:47 +02:00
Christian König
77a30ac0c2
Use mapfile
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-11 17:31:03 +02:00
yubiuser
56fb954d64
Merge pull request #4321 from pi-hole/tweak/finalwhiptail
...
Tweak final whiptail dialog
2021-10-11 10:04:25 +02:00
Adam Warner
99981b5e66
now that whiptail size is fixed, lose a couple of lines from the final whiptail output
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-10-11 09:55:56 +02:00
DL6ER
19ae9d3ee6
Merge pull request #4375 from pi-hole/companion/adminlte-1231
...
Companion to pi-hole/adminlte #1231
2021-10-10 19:03:59 +02:00
DL6ER
d03aa0c0c7
Merge pull request #4379 from pi-hole/tweak/vw_adlist
...
Simplify vw_adlist
2021-10-10 07:11:05 +02:00
yubiuser
3c41ec08a3
Set file permission for querie database in pihole-FTL.service ( #4328 )
...
* Set file permission for querie database in pihole-FTL.service
Signed-off-by: Christian König <ckoenig@posteo.de >
* Use -f flag for chmod of the macvendor.db
Signed-off-by: Christian König <ckoenig@posteo.de >
* Fix missing space
Signed-off-by: Christian König <ckoenig@posteo.de >
* Fix spelling
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-08 22:54:23 +01:00
Christian König
fdc4cf9869
Fix stickler
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-08 21:54:50 +02:00
Christian König
a0ecfcc1dc
Include df -h in debug log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-08 21:50:46 +02:00
Christian König
b30d729aa4
Simplify vw_adlist
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-08 21:08:10 +02:00
Adam Warner
f8af1a1baa
Allow iFrame for teleporter.php, see https://github.com/pi-hole/AdminLTE/pull/1231
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-10-07 00:16:07 +01:00
Adam Warner
ab27a3bd45
Dependabot config tweak
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-10-06 23:30:29 +01:00
yubiuser
f3acc7c839
Make debug log file size human readable ( #4350 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-06 15:19:25 -07:00
DL6ER
6f6b54ea05
Merge pull request #4373 from friederbluemle/rm-idea
...
Remove .idea/
2021-10-06 20:07:27 +02:00
Frieder Bluemle
3cad8e4c5b
Remove .idea/
...
Signed-off-by: Frieder Bluemle <frieder.bluemle@gmail.com >
2021-10-06 13:38:21 +02:00
yubiuser
9535e2fd6d
Merge pull request #4363 from xanoni/update-upstream-dns-capabilities
...
Update upstream DNS server capability descriptions
2021-10-06 07:18:14 +02:00
Adam Warner
0ea7344c30
add --no-rebase to the git pull command(s) to squelch hint message in newer versions of git ( #4226 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-10-06 01:19:28 +01:00
Adam Warner
55dce14655
Add execution bit accidentally dropped in #4106 ( #4368 )
...
Add some smoke tests for the repository.
- Add x bit to piholeCheckout.sh. Possibly not needed, but consistency is no bad thing
- Ensure all files in script directorys have executable bit set
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-10-05 19:34:51 +01:00
Jauder Ho
5bf35dc687
Add Dependabot and CodeQL support ( #4286 )
...
Signed-off-by: Jauder Ho <jauderho@users.noreply.github.com >
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2021-10-05 18:22:46 +01:00
MichaIng
c5828df198
Consequently use defined file path variables ( #4105 )
...
The script defines variables for the most important file paths which are not always used to call the file paths. "lighttpdConfig" was never used in the script itself, so that a shellcheck exception needed to be used. With this change, the defined variables are consequently used, which makes the shellcheck exception obsolete as well.
Additionally the assigned strings are quoted, which is not necessary here but aligns with the coding standard and highlights the strings in most editors and development platforms for developer convenience.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-10-05 16:40:12 +01:00
Adam Warner
77e322afa6
(docs) update README.md ( #4371 )
...
- correct grammar
- correct punctuation
- correct pronoun usage
Co-authored-by: Vladislav Doster <mvdoster@gmail.com >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: Vladislav Doster <mvdoster@gmail.com >
2021-10-05 16:25:29 +01:00
Andras Tim
541257849d
List fix: no reload ( #3981 )
...
* scripts/list: Fixed --noreload options
We should differentiate the ability and the needings.
Signed-off-by: Andras Tim <andras.tim@gmail.com >
* scripts/list: Removed unnecessary tailing whitespaces
Signed-off-by: Andras Tim <andras.tim@gmail.com >
* Update advanced/Scripts/list.sh
Signed-off-by: Andras Tim <andras.tim@gmail.com >
* Merge bash conditions according to MichaIng suggestion
Co-authored-by: micha@dietpi.com
Signed-off-by: Andras Tim <andras.tim@gmail.com >
2021-10-05 15:52:51 +01:00
yubiuser
80560d4a4a
Do not export DNS_FQDN_REQUIRED and DNS_BOGUS_PRIV unconditionally ( #4354 )
...
* Do not export unconditionally
Signed-off-by: Christian König <ckoenig@posteo.de >
* Check if variable is unset instead of grep for it
Signed-off-by: Christian König <ckoenig@posteo.de >
* Use bash's buld in word syntax
Signed-off-by: Christian König <ckoenig@posteo.de >
* Move export back to their brothers
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-05 14:36:00 +01:00
yubiuser
38bb4a4908
Remove unused wildcard_regex_converter.sh ( #4369 )
...
* Remove unused wildcard_regex_converter.sh
Signed-off-by: Christian König <ckoenig@posteo.de >
* Remove regexconverter
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-05 13:09:16 +01:00
yubiuser
2b74b47b4a
Remove netcat from dependencies ( #4346 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-05 01:47:18 +01:00
yubiuser
109340033e
Do not account for refactor anymore ( #4355 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-05 01:22:27 +01:00
xanoni
0f246b8df5
Update upstream DNS server capability descriptions
...
Mention that the below 3 upstream DNS support DNSSEC:
- Cloudflare (see https://developers.cloudflare.com/1.1.1.1/faq#how-does-1111-work-with-dnssec )
- DNS.WATCH (see https://dns.watch/index )
- Google (see https://developers.google.com/speed/public-dns/faq#dnssec )
- Quad9 (see https://www.quad9.net/support/faq/#dnssec )
Other providers and capabilities (e.g., ECS) were not checked.
Signed-off-by: xanoni <77220130+xanoni@users.noreply.github.com >
2021-10-04 13:55:20 -04:00
Adam Warner
5b03160295
Install script comment tweaks ( #4361 )
2021-10-04 11:40:53 +01:00
DL6ER
7b0513d1e6
Merge pull request #4357 from yubiuser/remove_whiptail
...
Do not let the user select if they want to blocking via IPv4 and/or IPv6
2021-10-03 07:42:19 +02:00
Christian König
466520366d
Fogot to save...
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-02 23:47:13 +02:00
Christian König
9dbcbdbe66
Adjust tests
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-02 23:43:08 +02:00
Christian König
a9b9718ffa
Do not let the user select if they want to blocking via IPv4 and/or IPv6
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-10-02 23:29:23 +02:00
Adam Warner
fb073373d6
Merge pull request #4106 from MichaIng/patch-2
...
Remove obsolete DEB package name checks
2021-10-01 15:26:15 +01:00
MichaIng
fd050693a2
Remove obsolete DEB package name checks
...
The installer contains three checks for specific DEB package names, which did change in past Debian/Ubuntu versions. These checks are obsolete with the current set of supported distro versions:
iproute vs iproute2: All distro versions down to Debian Jessie and Ubuntu Xenial ship the iproute2 package:
- https://packages.debian.org/search?keywords=iproute
- https://packages.ubuntu.com/search?suite=all&keywords=iproute
php5 vs php: None of the Ubuntu version down to Xenial and only Debian Jessie ships the php5 package:
- https://packages.debian.org/search?keywords=php5
- https://packages.ubuntu.com/search?suite=all&keywords=php5
Moreover, installs with PHP5 would fail anyway for a longer time, due to the added php-xml module package, which became a dedicated package with PHP7.0 while being part of the core package with PHP5:
- https://packages.debian.org/search?keywords=php5-xml
php-sqlite vs php-sqlite3: With PHP7, the SQLite module package name changed to sqlite3 prefix:
- https://packages.debian.org/search?keywords=php-sqlite
- https://packages.ubuntu.com/search?suite=all&keywords=php-sqlite
Additionally the code comment about minimal apt-get call output was moved to the actual apt-get install call section, as if refers to issues with package installs that require interactive action and hence output about it to the console. The package cache update as well requires an interactive confirmation when the underlying suite code name changes, e.g. when "buster" becomes "oldstable" and "bullseye" becomes "stable". But that is not what the referred issue was about.
The comments around the installer and Pi-hole package dependencies have been aligned with the current v6 branch as attempt to resolve merge conflicts in the first place.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-10-01 16:12:06 +02:00
Adam Warner
dad6247cb0
Merge pull request #4347 from pi-hole/development
...
Pi-hole core v5.5
2021-09-29 21:45:58 +01:00
yubiuser
841222fa21
Add to INSTALLER_DEPS ( #4343 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-09-26 10:50:03 -07:00
DL6ER
0576810438
Merge pull request #4339 from pi-hole/tweak/local_ttl
...
Remove local-ttl from set of default dnsmasq options
2021-09-25 21:57:49 +02:00
DL6ER
b755330f4c
Remove local-ttl from set of default dnsmasq options.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-09-24 11:34:05 +02:00
DL6ER
cf59f35a4e
Merge pull request #4324 from jpgpi250/fix_#4322
...
Fix for gravity syntax error (see #4322 )
2021-09-14 09:23:14 +02:00
DL6ER
2131a1fe7f
Merge pull request #4327 from yubiuser/export_nfqdn_bogus
...
Export DNS_FQDN_REQUIRED and DNS_BOGUS_PRIV to setupVars.conf during installation
2021-09-13 08:55:54 +02:00
Christian König
a88a94c4f1
Export DNS_FQDN_REQUIRED and DNS_BOGUS_PRIV to setupVars.conf during installation
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-09-13 08:06:19 +02:00
yubiuser
1c286c7bc4
Select proper PHP version on RPM based OS after INSTALLER_DEPS have been installed ( #4325 )
...
* Select proper PHP version on RPM based OS after INSTALLER_DEPS have been installed
* Remove check for unsupported RPM distros as it is checked in os_check already
* Add select_rpm_php function to tox tests
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-09-12 13:40:37 -07:00
yubiuser
6d670991c3
Perform a check of required packages befor updating pihole ( #4326 )
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-09-12 13:38:55 -07:00
jpgpi250
3439045228
fix Pi-hole v5.4 update - syntax error #4322
...
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
2021-09-12 18:24:15 +02:00
Adam Warner
b710e107d6
Merge pull request #4320 from pi-hole/master
...
Sync master back to dev
2021-09-11 22:39:50 +01:00
Adam Warner
2673c2c072
Merge pull request #4318 from pi-hole/release/v5.4
...
Pi-hole core v5.4
2021-09-11 22:17:43 +01:00
Adam Warner
e393048488
Merge pull request #4229 from MichaIng/patch-3
...
Hardcode whiptail dimensions to 20 rows and 70 chars width
2021-09-11 21:37:14 +01:00
Adam Warner
2feea70311
Merge pull request #4319 from pi-hole/development
...
Sync Dev -> release/v5.4
2021-09-11 21:36:08 +01:00
Adam Warner
62f29ba3fa
Merge branch 'release/v5.4' into development
2021-09-11 21:35:11 +01:00
DL6ER
89b1cfcd85
Merge pull request #4243 from yubiuser/debug_dnsmasq
...
Include all files in the dnsmasq config dir in the debug output
2021-09-11 22:20:00 +02:00
Adam Warner
89e187947e
Merge pull request #4282 from pi-hole/new/RFC6761
...
Install RFC6761 config file
2021-09-11 20:44:46 +01:00
Adam Warner
d2faa93241
Merge pull request #4314 from pi-hole/fix/capabilities
...
Add possibly missing capabilities
2021-09-11 20:44:24 +01:00
DL6ER
0df099a6a5
Merge pull request #4312 from yubiuser/debug_dnsmasq.conf
...
Add content of /etc/dnsmasq.conf to debug output
2021-09-11 21:42:36 +02:00
DL6ER
482ac12c9b
Merge pull request #4275 from MichaIng/patch-4
...
Remove ineffective Access-Control-Allow-Origin header
2021-09-11 21:41:49 +02:00
DL6ER
b2592f5d31
Merge pull request #4317 from pi-hole/tweak/UQDN_forwarding
...
Forward unqualified names to the CF target only when the "Never forward non-FQDN" option is NOT ticked
2021-09-11 21:40:14 +02:00
DL6ER
d0e8b0c962
Forward unqualified names to the CF target only when the "Never forward non-FQDN" option is NOT ticked
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-09-09 20:28:33 +02:00
Dan Schaper
d48d3aba69
Merge pull request #4305 from pi-hole/tweak/debug_curl
...
Use --no-progress-meter instead of --silent so error reasons are printed
2021-09-07 09:33:25 -07:00
DL6ER
cbc99d45c6
Small style change to finished debug upload display
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-09-07 11:21:34 +02:00
DL6ER
be68a5339c
Apply same improvement to pihole tricorder feature
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-09-07 11:16:40 +02:00
DL6ER
606b05eec1
Ensure curl is either storing a valid token or a meaningful error message
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-09-07 11:13:09 +02:00
DL6ER
a1ee7d92a9
Add possibly missing capabilities
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-09-06 22:38:16 +02:00
Christian König
6941155572
Add content of /etc/dnsmasq.conf to debug output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-09-06 17:16:36 +02:00
DL6ER
b6d73ac081
Merge pull request #4311 from yubiuser/debug_resolv
...
Add content of /etc/resolv.conf to debug output
2021-09-06 10:56:21 +02:00
Christian König
6fec4acd82
Add content of /etc/resolv.conf to debug output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-09-05 20:44:39 +02:00
DL6ER
b241a19e87
Use --no-progress-meter instead of --silent so error reasons are printed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-30 21:19:47 +02:00
Dan Schaper
a7ba55ffb0
Merge pull request #4304 from pi-hole/fix/tricorder
...
Fix pipe to pihole tricorder
2021-08-30 11:49:36 -07:00
DL6ER
115e3eeda9
Use --no-progress-meter instead of --silent so error reasons are printed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-30 20:20:45 +02:00
DL6ER
21897d7fbd
Add warning if curl failed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-30 15:55:42 +02:00
DL6ER
31c7c019cb
Fix piping to pihole tricorder
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-30 14:04:48 +02:00
DL6ER
b97f76e678
Merge pull request #4292 from yubiuser/sudo_apt
...
Add sudo to apt-get recommendation
2021-08-29 12:55:22 +02:00
Christian König
839a70cc37
Add sudo to apt-get recommendation
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-08-27 19:16:15 +02:00
DL6ER
a068567926
Merge pull request #4287 from pi-hole/tweak/conditional_forwarding_unqualified_domains
...
Conditional forwarding: Also forward unqualified host names
2021-08-23 22:02:43 +02:00
DL6ER
06fd8123c3
Also remove "rev-server" lines when rewriting 01-pihole.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-20 16:26:17 +02:00
DL6ER
c2f3477a82
Ensure conditional forwarding will forward unqualified host names if we have no local answer for them.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-20 15:54:25 +02:00
DL6ER
ff64d8cf4d
Use variable in user output, too
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-16 09:57:12 +02:00
DL6ER
e8e8104b36
Remove server=/local/ because of https://github.com/pi-hole/pi-hole/pull/4282#discussion_r689112972
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-15 18:37:12 +02:00
MichaIng
e1dca46423
Hardcode whiptail dimensions to 20 rows and 70 chars width
...
With the suggested way to call the installer via "curl -sSL https://install.pi-hole.net | bash", STDIN is no terminal, but overridden by the curl output, hence in most cases, the minimum dimensions were applied, even on larger screens. All whiptail calls are hence assured to work fine with those dimensions, aside of one case, making the calculations obsolete.
This commit hardcodes the whiptail dimensions to the prior minimum and removes the calculations. This also helps with testing, as it does not matter anymore how the script is called, and developers have a clearly defined space to make dialogs look nice, including line breaks, menu and list heights.
The only case which does not fit the 70 character width, the second menu entry of the "pihole -r" dialog, has been shortened accordingly. This was not an issue before, as "pihole -r" does not override the scripts STDIN and hence did allow larger dimensions based on the now removed calculations.
See the following discussions for reference:
- https://github.com/pi-hole/pi-hole/issues/3323
- https://github.com/pi-hole/pi-hole/pull/4197#issuecomment-876702380
Signed-off-by: MichaIng <micha@dietpi.com >
2021-08-15 18:04:11 +02:00
DL6ER
ea5a3bf0b2
Install RFC6761 config file
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-08-15 11:21:24 +02:00
DL6ER
98867d8d71
Merge pull request #4276 from pi-hole/dev-release5.4
...
Sync release/v5.4 back into development
2021-08-13 23:37:53 +02:00
Adam Warner
c88c943cda
Merge branch 'release/v5.4' into dev-release5.4
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-13 20:24:35 +01:00
MichaIng
3ef90a9e47
Remove ineffective Access-Control-Allow-Origin header
...
The Access-Control-Allow-Origin header has only relevance, when a resource is loaded from an external host, so one that does not match the host of the primary loaded website. As the fonts are reasonably loaded via local URLs without hostname or scheme from the blocking page style sheet, they are never seen as external resources, regardless whether the blocking page is shown to the browser from a blocked domain or from the Pi-hole domain/IP.
For reference: https://github.com/pi-hole/pi-hole/issues/3462
Signed-off-by: MichaIng <micha@dietpi.com >
2021-08-13 20:42:51 +02:00
DL6ER
58a21bee07
Merge pull request #4271 from yubiuser/fix_splash
...
Fix Splashpage not appearing properly on non-root directories
2021-08-12 17:32:18 +02:00
Christian König
676b7e60f3
Fix Splashpage not appearing properly on non-root directories
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-08-12 13:55:40 +02:00
DL6ER
43b88cd628
Merge pull request #4236 from MichaIng/patch-4
...
Update pihole-FTL.service
2021-08-10 16:09:41 +02:00
DL6ER
e163ed449d
Merge pull request #4264 from yubiuser/tweak_enable
...
On enabling/disabeling only reload-lists instead of reload
2021-08-09 18:26:24 +02:00
yubiuser
ee749f700f
Add switching 'to...from' message to ftl checkout output ( #4266 )
...
* Add switching 'to...from' message to ftl checkout output
Signed-off-by: Christian König <ckoenig@posteo.de >
* Add quotes
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-08-07 20:07:45 +02:00
yubiuser
bb7c7cdf33
Add uptime to debug log ( #4265 )
...
* Add uptime to debug log
Signed-off-by: Christian König <ckoenig@posteo.de >
* Address github comments
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-08-07 20:07:14 +02:00
Christian König
ffe45e8b76
On enabling/disabeling only reload-lists instead of reload
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-08-06 20:51:48 +02:00
Adam Warner
f86ef0128e
Merge pull request #4260 from pi-hole/tweak/installorder-butwithoutdhcpcd5-option1
...
Some tweaks to how packages are installed, plus removal of dhcpd5 dependency (Option 1)
2021-08-05 19:26:56 +01:00
Adam Warner
bdab701470
Remove dhcpcd5 dependency, however still help the user set the static IP if dhcpd5 is already installed (i.e on raspbian)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:37 +01:00
Adam Warner
1ecb9165ee
Remove weird global counter
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:37 +01:00
Adam Warner
2ff3b95117
put FTL Install back to where it was
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:37 +01:00
Adam Warner
3ad5097b12
Change initial install script order:
...
1. Ensure we have a compatible package manager
2. Install required packages for os_check to run (we need dnsutils and grep for this
3. Try to install FTL
4. FTL installed? Install installer dependencies and continue as normal - no other dependencies are installed until user has gone through all whiptails
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:37 +01:00
Adam Warner
d68a2ffaf3
Install only minimal requiered package before performing os_check
...
Co-authored-by: Christian König <ckoenig@posteo.de >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:36 +01:00
Adam Warner
913dcead7f
move chmod/chown of macvendor.db to pihole-FTL.service
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:36 +01:00
Adam Warner
1358209a9a
rename distro_check to package_manager_detect, as it is more in keeping with what the function actually does
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-08-05 19:02:36 +01:00
Dan Schaper
b729a44209
Merge pull request #4246 from pi-hole/tweak/debug_noipcheck
...
Remove comparison of IP addresses with setupVars.conf
2021-08-05 09:34:08 -07:00
Adam Warner
5a55fa5e48
Merge pull request #4263 from pi-hole/tweak/debugports
...
Update debug for new back end.
2021-08-05 17:12:37 +01:00
Adam Warner
d419eaf463
Merge branch 'development' into release/v5.4
2021-08-05 17:05:12 +01:00
Dan Schaper
a8deebde4d
Merge pull request #4225 from duxovni/fix-logrotate-conflict
...
Give pihole its own logrotate state file
2021-08-05 09:03:47 -07:00
Dan Schaper
2ec4e84db4
Merge branch 'development' into fix-logrotate-conflict
2021-08-05 07:45:31 -07:00
Dan Schaper
075b3f6468
Remove ports, nc option and fix wording.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-08-04 20:57:09 -07:00
DL6ER
7911841355
Merge pull request #4262 from yubiuser/tweak_debug
...
Increase width of ID column in adlist and domain table in debug script
2021-08-04 20:26:49 +02:00
Christian König
d2c75a33d5
Increase width of ID column in adlist and domain table in debug script
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-08-04 20:13:41 +02:00
Adam Warner
15dfd19f58
Merge pull request #4248 from pi-hole/tweak/debugscript
...
Fix error on checking interfaces that are not dual-stack
2021-08-03 12:29:36 +01:00
DL6ER
9ae6b40818
Merge pull request #4247 from pi-hole/tweak/installLogrotateFail
...
Remove extra failure display when installation of logrotate file is skipped because the file already exists
2021-07-30 07:44:34 +02:00
Christian König
aa2da80768
Remove traces of unused files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-28 23:06:01 +02:00
Christian König
b05fc5bb2b
Remove specific dnsmasq config files from requiered files
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-28 23:01:18 +02:00
Christian König
c99c86af7f
Make all dir list output human readable
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-28 22:53:30 +02:00
Christian König
f552173be3
Resolve merge conflict
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-28 22:51:04 +02:00
DL6ER
d02aa3ced1
Fix error on checking interfaces that are not dual-stack
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-07-28 22:34:55 +02:00
DL6ER
d0eb0d5037
Remove extra failure display when installation of logrotate file is skipped because the file already exists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-07-28 21:18:02 +02:00
DL6ER
fbfec961d5
Remove comparison of IP addresses with setupVars.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-07-28 21:16:19 +02:00
DL6ER
fba7517cc6
Merge pull request #4244 from yubiuser/debug_shm
...
Make output of SHM dir human readable
2021-07-28 06:20:31 +02:00
Christian König
0c125eba2c
Make output of SHM dir human readable
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-27 22:04:30 +02:00
DL6ER
7f4bb24fd3
Merge pull request #4242 from pi-hole/fix/guard_logrotate
...
Guard for logrotate func non-zero return
2021-07-27 19:43:52 +02:00
Dan Schaper
b1ea60484e
Guard for logrotate func non-zero return
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-07-26 13:22:26 -07:00
MichaIng
57c40cbd09
Update pihole-FTL.service
...
Make this script a bourne shell script, which requires the removal of only a single bashism, the "{n..m}" expansion. Furthermore, since POSIX echo has no reliable command line options, switch to printf when line breaks shall be omitted. On most distros/setups "sh" calls a much lighter bourne shell like dash, which inits and runs much faster than bash.
Remove unused PIDFILE variable, remove the single case of FTLUSER call and remove it as well. Using variables here might give the wrong impression that there is a change these can be varied. But both are hardcoded in many places throughout Pi-hole, so in this service script.
Consolidate and merge the commands to pre-create and set permissions for required files and directories. The /var/log/pihole directory is and was never used, the touch, chmod and chown call can be merged into one each to reduce overhead. Use "-f" option to to fail on missing database files instead of redirecting STDERR, which is otherwise helpful to debug other possible errors, like missing or corrupted commands, filesystem errors and such.
Do not use "which pihole-FTL" when setting capabilities when the hardcoded path /usr/bin/pihole-FTL is used for the actual daemon call. It makes sense to use the full path here, as the Pi-hole installer and updater installs it explicitly there, and so we prevent users from e.g. overriding it via /usr/local/bin/pihole-FTL too easily.
On pgrep and pkill calls, add the "-x" flag to assure that only "pihole-FTL" is matched and not "foo-pihole-FTL" or "pihole-FTL-bar".
Do not remove possible leftovers from previous pihole-FTL processes on start, but on stop instead. Since "start" includes a proceeding "stop" as well, on service start nothing changes, but on service stop, some resources are now freed.
Remove leading "$" from usage message. In bash this was omitted, as $'...' is a special syntax for escape sequence expansion, which is not applicable here. In dash it would be printed literally. To keep previous behaviour, it is hence removed.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-07-24 14:55:54 +02:00
Dan Schaper
95d1464e36
Merge pull request #4233 from kthchew/teleporter
...
Add `-t` (teleporter) option to Admin Console help dialog
2021-07-21 10:08:31 -07:00
Kenneth Chew
092e533a30
Add -t option to Admin Console help dialog
...
Signed-off-by: Kenneth Chew <kenneth.c0@protonmail.com >
2021-07-18 14:31:37 -04:00
DL6ER
18c6ef8aac
Merge pull request #4230 from yubiuser/fix_coloring
...
Fix coloring of pihole -t
2021-07-17 10:00:31 +02:00
Christian König
6be647a85f
Fix coloring of pihole -t
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-16 21:52:12 +02:00
Adam Warner
6f7edbc92e
Merge pull request #4228 from pi-hole/PromoFaux-patch-1
...
Delete supportedos.txt - it is not actually used anywhere can can cause confusion
2021-07-16 09:45:03 +01:00
Adam Warner
9beb3a9b6c
Delete supportedos.txt - it is not actually used anywhere can can cause confusion
2021-07-16 09:17:23 +01:00
Adam Warner
3b6e6317b8
Merge pull request #4126 from lightswitch05/feature/support-and-test-debian-bullseye
...
Support and test Debian Bullsye (11) and Ubuntu 21.04
2021-07-15 19:11:26 +01:00
Daniel
a9b5fcd923
Add Ubuntu 21 to supportedos.txt, and github actions tests
...
Signed-off-by: Daniel <daniel@developerdan.com >
2021-07-15 13:49:59 +00:00
Adam Warner
38d4b2a883
add OS_CHECK_DOMAIN_NAME override to all the dockerfiles
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-07-14 22:41:17 +01:00
Adam Warner
e2e7d0a6aa
add tests for ubuntu 21
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-07-14 22:36:02 +01:00
Faye Duxovni
aa5c15a728
give pihole its own logrotate state file
...
Signed-off-by: Faye Duxovni <duxovni@duxovni.org >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-07-09 20:00:10 -04:00
Adam Warner
7dea5012ce
Merge pull request #4222 from pi-hole/tweak/lighttpd-config-fedora
...
Remove mod_compress from lighttpd config on fedora/centos
2021-07-07 22:01:23 +01:00
Daniel
fdca19e66d
Support and test Debian Bullsye (11)
...
Signed-off-by: Daniel <daniel@developerdan.com >
2021-07-07 19:09:54 +00:00
Adam Warner
c9e341b5d4
Same change as with #4221 , but on fedora config too
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-07-07 19:20:14 +01:00
Adam Warner
012d1e4b3d
Merge pull request #4221 from lightswitch05/bugfix/remove-lighttpd-mod-compress
...
Remove mod_compress (mod_deflate) from lighttpd to provide backwards compatible support for Debian Bullseye (11)
2021-07-07 19:09:22 +01:00
Daniel
31a096dec2
Remove mod_compress (mod_deflate) from lighttpd to provide backwards compatible support for Debian Bullseye (11)
...
Signed-off-by: Daniel <daniel@developerdan.com >
2021-07-07 13:31:59 +00:00
DL6ER
a52a5e7ef2
Merge pull request #4217 from pi-hole/new/canary_domain_handling
...
Move Mozilla canary domain handling into FTL's namespace
2021-07-04 15:36:23 +02:00
DL6ER
a0d74d1e9d
Canary domain handling is now happening in FTL where we have much finer control over it.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-07-04 13:55:47 +02:00
Adam Warner
0cbf77eb9f
Merge pull request #4131 from pi-hole/fix/gravity_no_locallist
...
Handle pi.hole and hostname in FTL instead of local.list
2021-07-04 11:52:30 +01:00
Adam Warner
36470eb138
Merge pull request #4216 from pi-hole/fix/debugpiholelog
...
Debug Log bugfix
2021-07-04 01:53:49 +01:00
Adam Warner
e80e54a61a
head_line -> line
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-07-04 01:18:46 +01:00
Adam Warner
118c0d209d
Merge pull request #4162 from yubiuser/debug_tail_log
...
Add tail of pihole.log to debug output
2021-07-04 01:10:31 +01:00
Adam Warner
9b9e907013
Merge branch 'development' into debug_tail_log
2021-07-04 00:53:14 +01:00
Adam Warner
4ac4bc5c18
Merge branch 'development' into fix/gravity_no_locallist
2021-07-04 00:48:09 +01:00
Adam Warner
8c926d6af6
Merge pull request #4158 from MichaIng/patch-2
...
Remove false statement about dependency removal on Raspbian
2021-07-04 00:43:09 +01:00
Adam Warner
a1d85155fd
Merge pull request #4178 from pi-hole/fix/custom_dns_removal
...
Add missing sed anchors when deleting lines.
2021-07-04 00:35:00 +01:00
Adam Warner
2d0619afec
Merge pull request #4191 from yubiuser/fiter_pihole_t
...
Filter pihole -t
2021-07-04 00:31:57 +01:00
Adam Warner
ab9d589995
Merge pull request #4215 from pi-hole/new/packagecheck
...
Add new tests to ensure dependencies are available to the OS
2021-07-03 16:27:33 +01:00
Christian König
4fb5157719
Squashed commits
...
Add simple grep function to pihole -t
Signed-off-by: Christian König <ckoenig@posteo.de >
Add help info
Signed-off-by: Christian König <ckoenig@posteo.de >
Improve help info
Signed-off-by: Christian König <ckoenig@posteo.de >
Fix details
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-07-03 17:13:19 +02:00
DL6ER
641eb7821b
Merge pull request #4202 from jpgpi250/keep_old_database
...
Update gravity.sh
2021-07-03 09:14:05 +02:00
Adam Warner
87f2ae82cd
Stickler gonna stickle...
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-07-03 00:07:37 +01:00
Adam Warner
469b715442
Add three new tests (one for each dependecy array) to check packages are available in supported OS package repos
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-07-03 00:00:54 +01:00
Adam Warner
04ffd22b4d
Merge pull request #4214 from pi-hole/revert-4212-feature/include-lighttpd-mod-deflate
...
Revert "Include lighttpd-mod-deflate since it is no longer provided by default in Bullsye"
2021-07-02 22:23:10 +01:00
Adam Warner
c120f8a8d8
Revert "Include lighttpd-mod-deflate since it is no longer provided by default in Bullsye"
2021-07-02 22:09:41 +01:00
Adam Warner
0a5eee4d99
Merge pull request #4212 from lightswitch05/feature/include-lighttpd-mod-deflate
...
Include lighttpd-mod-deflate since it is no longer provided by default in Bullsye
2021-07-01 08:37:23 +01:00
Daniel
2b49988013
Include lighttpd-mod-deflate in the PIHOLE_WEB_DEPS list since it is no longer provided by default in Debian Bullseye
...
Signed-off-by: Daniel <daniel@developerdan.com >
2021-07-01 02:20:22 +00:00
Adam Warner
954b3e784f
Merge pull request #4199 from wgyt/patch-1
...
Fix typo
2021-06-30 22:38:47 +01:00
Dan Schaper
0612685fac
Merge pull request #4207 from pi-hole/fix/existing_logrotate
...
Don't overwrite existing logrotate
2021-06-21 08:23:23 -07:00
DL6ER
e3a22dcbfa
Merge pull request #4206 from pi-hole/fix/dhcpv6
...
Be explicit in IPv6 RA values.
2021-06-21 05:10:33 +02:00
Dan Schaper
4f660966d0
Shellchecker
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-06-20 11:19:19 -07:00
Dan Schaper
7df22cd8e0
Check for logroate script existing first.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-06-20 11:18:33 -07:00
Dan Schaper
01764cc581
Explicity declare values for the RA packet.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-06-20 10:28:25 -07:00
Christian König
08cf9aa5a7
Declare and assign 'logging_enabled' separately
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-06-19 12:25:38 +02:00
Christian König
1ae67e1de8
Only inform user about disabled logging, don't skipp printing pihole.log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-06-19 12:25:38 +02:00
Christian König
f2cba6cad1
Skip analyze_pihole_log if query logging has been disabled
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-06-19 12:25:38 +02:00
Christian König
df3c46349a
Add tail of pihole.log to debug output
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-06-19 12:25:38 +02:00
jpgpi250
a2d5b8050a
Update gravity.sh
...
Signed-off-by: jpgpi250 <jpgpi250@gmail.com >
2021-06-14 20:27:10 +02:00
William Horning
01c310a78f
Fix typo
...
Signed-off-by: William Horning <williamhorning@wgyt.tk >
2021-06-10 19:23:58 -04:00
DL6ER
a9e761ec13
Add missing sed anchors when deleting lines.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-05-23 12:11:04 +02:00
Adam Warner
761c1cd305
Merge pull request #4175 from ashuio/development
...
Added docker to README
2021-05-20 18:49:01 +01:00
Ashutosh Verma
6f60555f79
Added install Method 3
...
Signed-off-by: Ashutosh Verma <mail@ashu.io >
2021-05-20 22:34:19 +05:30
MichaIng
c901443676
Remove false statement about dependency removal on Raspbian
...
The statement "All dependencies are safe to remove on Raspbian" has been added at a time where a much smaller list of dependencies were installed, all indeed relatively safe to purge. Nowadays this list has grown and includes important system packages, like iproute2, psmisc, sudo, curl and others, which are often again dependencies of other packages, like network stacks (ifupdown) and others, so that inexperienced users, following that statement, may break their systems network capabilities and more.
This message has hence been removed.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-05-02 13:29:28 +02:00
Adam Warner
a51be7d498
Merge pull request #4153 from MichaIng/patch-2
...
Re-remove wget from dependencies
2021-05-01 00:09:19 +01:00
MichaIng
f3ceebbe06
Re-remove wget from dependencies
...
The dependency has been removed here: https://github.com/pi-hole/pi-hole/pull/3185
But accidentally re-added here: 982c1b0059 (diff-595630a29a855f6d667a84ca0662042e826bf3ec56322ef61d4a6ef149147d23)
wget is still not used in any Pi-hole script, hence it can be removed safely from dependencies.
Signed-off-by: MichaIng <micha@dietpi.com >
2021-04-30 20:48:12 +02:00
Adam Warner
57d9b96b53
Merge pull request #4143 from pi-hole/version-fullstops
...
Cosmetic change to pihole -v -c output
2021-04-25 17:47:40 +01:00
Adam Warner
5895690b58
this has been annoying me for months
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-04-24 15:38:27 +01:00
DL6ER
d26f8dd665
Merge pull request #4135 from MichaIng/patch-1
...
Enable PHP8 support for Debian/Ubuntu
2021-04-21 20:19:25 +02:00
MichaIng
2ba350984f
Enable PHP8 support for Debian/Ubuntu
...
Since PHP8.0, the JSON extension is a core PHP extension and hence the php8.0-json package does not exist and is not required:
- https://www.php.net/manual/json.installation.php
- https://packages.debian.org/php8.0-json
Solves: https://discourse.pi-hole.net/t/php-8-packages-not-found/46286
Signed-off-by: MichaIng <micha@dietpi.com >
2021-04-18 15:33:05 +02:00
DL6ER
60513f93a3
Don't set IPV{4,6}_ADDRESS in conftest.py
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-04-18 09:26:23 +02:00
DL6ER
3b574096b8
Remove duplicated lo test
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-04-16 12:28:00 +02:00
DL6ER
58905a1188
Modify debugger to test name resolution on all available interfaces
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-04-16 12:14:05 +02:00
DL6ER
aa88be335e
Acknowledge that IPV{4,6}_ADDRESS may not exist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-04-16 11:44:54 +02:00
DL6ER
f90dffbf1a
Do not put hostname and pi.hole into local.list - this will be handled by FTL after FTL#1111 has been merged
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-04-16 11:41:26 +02:00
Dan Schaper
1fb6366c41
Merge pull request #4123 from pi-hole/master
...
Master v5.3.1 to development
2021-04-14 14:30:30 -07:00
Dan Schaper
4736e03108
Merge pull request #4122 from pi-hole/release/v5.3.1
...
HotFix release v5.3.1
2021-04-14 14:10:21 -07:00
Dan Schaper
18bedc0493
Merge pull request #4121 from pi-hole/fix/port_hash
...
Fix port separator in IPv4 address validation code
2021-04-14 13:59:52 -07:00
DL6ER
74948ae5c1
The correct port separator is '#' not ':' in dnsmasq style. This should not have been changed in #4083 in the first place.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-04-14 22:53:12 +02:00
Dan Schaper
9b57f7fa33
Merge pull request #4120 from pi-hole/fix/splashPage
...
Add missing closing single quote
2021-04-14 13:50:45 -07:00
Dan Schaper
866045968d
Add missing closing single quote
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-04-14 12:27:36 -07:00
Dan Schaper
f2e0cf8a92
Merge pull request #4117 from pi-hole/master
...
v5.8 master to dev
2021-04-14 12:24:08 -07:00
Adam Warner
4c39edbeb9
Merge pull request #4113 from pi-hole/release/v5.3
...
Pi-hole Core v5.3
2021-04-14 19:04:03 +01:00
Adam Warner
b388ac5bb5
Merge pull request from GHSA-3597-244c-wrpj
...
Add some validation to passed arguments before running the values through `sed`
2021-04-14 18:16:46 +01:00
Adam Warner
7855859726
Merge pull request #4116 from pi-hole/fix/update-readme
...
Update README
2021-04-14 17:57:47 +01:00
DL6ER
5df7ed2f32
Obtain FTL's PID from the PID file ( #4103 )
...
* Try to obtain FTL's PID from the PID file. If this fails, try to identify the main process using pgrep --oldest (instead of relying on pkill finding the right one by itself). This allows the script to work in even when FTL is running inside the memory checker valgrind.
* Rename FTL_PID -> FTL_PID_FILE
* Remove the pgrep fallback after discussions about that it should be more obvious to users if something strange happened to their PID file. Also, simplify the routine using a bashism in the end.
* Shorten if [[ regex ]]
* Use unset instead of emptying the PID variable
Signed-off-by: DL6ER <dl6er@dl6er.de >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-04-14 09:33:10 -07:00
Dan Schaper
25ded79190
Update README
2021-04-14 09:26:52 -07:00
Adam Warner
d3e00f038b
Merge pull request #4004 from pi-hole/fedora_33_support
...
Fedora 33 Support
2021-04-13 08:41:56 +01:00
bcambl
d5f13018a7
Merge branch 'release/v5.3' into fedora_33_support
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2021-04-12 20:06:11 -06:00
Adam Warner
c6e3805bbb
Merge pull request #4083 from jbzdarkid/patch-2
...
Improve regexes for IPv4 matching
2021-04-12 21:12:20 +01:00
Adam Warner
ea451e3c22
Merge pull request #4095 from jbaez/ft-3896
...
Fix error trying to access undefined variables on splash page.
2021-04-12 20:41:25 +01:00
DL6ER
b97f890a8c
Merge pull request #4086 from pi-hole/fix/GRAVITDB_in_pihole-g
...
pihole -g should respose GRAVITYDB in pihole-FTL.conf
2021-04-11 05:18:09 +02:00
Jaime Baez
6198165df8
Fix error trying to access undefined variables on splash page.
...
Signed-off-by: Jaime Baez <j.baezcastillo@gmail.com >
2021-03-26 23:42:11 +01:00
jbzdarkid
8090071eff
Update regex to disallow leading zeros
...
Also updated a comment to point to a non-experimental RFC.
Signed-off-by: jbzdarkid <jbzdarkid@gmail.com >
2021-03-21 16:27:08 -07:00
Joseph Blackman
89c80947df
Improve regexes for ipv4 matching
...
Signed-off-by: jbzdarkid <jbzdarkid@gmail.com >
2021-03-21 16:24:35 -07:00
Adam Warner
b51751e892
Merge pull request #4084 from jbzdarkid/patch-1
...
Improve comments in basic-install.sh
2021-03-21 23:14:59 +00:00
Adam Warner
45d4ab4c22
Add some validation to passed arguments before running the values through sed
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2021-03-19 18:39:43 +00:00
DL6ER
f536718aaa
Use possibly custom gravity.db location in the copying SQL script
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-03-18 16:46:59 +01:00
DL6ER
f1740da9ff
Update gravity path in query.sh
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-03-18 09:58:19 +01:00
DL6ER
9bdbe88a66
Update gravity path in list.sh
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-03-18 09:58:19 +01:00
DL6ER
d25240fe9f
pihole -g should respose GRAVITYDB in pihole-FTL.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-03-18 09:00:27 +01:00
jbzdarkid
20b6f9cceb
Improve comments in basic-install.sh
...
Signed-off-by: jbzdarkid <jbzdarkid@gmail.com >
2021-03-17 18:37:18 -07:00
Dan Schaper
f27fd9f899
Merge pull request #3982 from andras-tim/list-fix-same-wildcard-regex
...
Fix list: User same wildcard regex that the UI use
2021-03-17 11:20:12 -07:00
Dany
13cf0c1288
Aligned pihole logo to center, Fixed responsive issue ( #4036 )
...
* Aligned pihole logo to center, Fixed responsive issue
* removed duplicate instance of #splashpage
Signed-off-by: Dany Gauthier <danygauthier57@yahoo.ca >
2021-03-17 11:18:50 -07:00
Adam Warner
ae762574e5
Merge pull request #4070 from pi-hole/fix/pihole-g-r
...
Fix `pihole -g -r`
2021-03-03 14:43:42 +00:00
DL6ER
126b9ae381
Add missing three new columns to pihole -g -r
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2021-03-02 20:08:09 +01:00
DL6ER
57fe3b6621
Merge pull request #3951 from pi-hole/new/gravity_adlist_infos
...
Store gravity details in gravity.db adlist table
2021-02-28 17:01:19 +01:00
Adam Warner
56fa9714b5
Merge pull request #4010 from mtzfederico/master
...
Updates lighttpd config to allow a persistent port change on IPv6
2021-02-28 14:42:21 +00:00
Dan Schaper
03a8ca5c1b
Merge pull request #4049 from yubiuser/tewak/teleporter_cli
...
Add hostname to teleporter backup file if called from cli
2021-02-16 08:02:49 -08:00
Christian König
78027bd2bf
Add default noname if hostname is empty
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-02-12 20:25:01 +01:00
Christian König
7dc7cbb80e
Add hostname to teleporter backup file if called from cli
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2021-02-11 19:45:32 +01:00
Dan Schaper
debc9a69c5
Merge pull request #4021 from Flashbang007/patch-3
...
Fix issue with multipe default gateways when running the debug
2021-01-27 08:45:22 -08:00
Alexander Schmitz
1ab193fa9d
Update piholeDebug.sh
...
Signed-off-by: Alexander Schmitz <Flashbang007@gmail.com >
2021-01-27 11:00:43 +01:00
Adam Warner
9ec012289f
Merge pull request #4017 from mwoolweaver/patch-2
...
fix suspected typo in comment
2021-01-26 08:48:05 +00:00
Michael Woolweaver
c42b97ddb2
fix typo in comment
...
Signed-off-by: Michael Woolweaver <m.woolweaver@icloud.com >
2021-01-26 01:04:37 -06:00
mtzfederico
e5bfafefb9
Moved where external.conf is included
...
Signed-off-by: mtzfederico <fm@mtzfederico.com >
2021-01-22 15:53:40 -06:00
bcambl
b62495d89e
update tests to fedora 33
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2021-01-21 20:20:07 -06:00
bcambl
c6810a0124
touch sysconfig network script when absent
...
sysconfig network scripts are missing on pure NetworkManager installs.
This commit touches a placeholder to allow the network configuration to
be generated and loaded via NetworkManager.
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2021-01-19 23:06:39 -06:00
Adam Warner
8e7670db41
Merge pull request #4002 from freddii/master
...
fixed typos
2021-01-19 18:46:55 +00:00
freddii
7c0c30fb0b
fixed typos
2021-01-19 19:33:38 +01:00
Adam Warner
cbfb58f7a2
Merge pull request #4000 from pi-hole/release/v5.2.4
...
Pi-hole Core v5.2.4
2021-01-19 12:29:01 +00:00
Adam Warner
0c45d23c22
Merge pull request #3997 from pi-hole/revert-3537-patch-2
...
Revert "Further failsafe check for available APT packages"
2021-01-19 08:19:46 +00:00
Dan Schaper
3f8fedfb16
Revert "Further failsafe check for available APT packages"
2021-01-17 11:10:24 -08:00
Adam Warner
cbc3fbdfe6
Merge pull request #3989 from pi-hole/release/v5.2.3
...
Pi-hole Core v5.2.3
2021-01-15 19:45:55 +00:00
Dan Schaper
020b6b8064
Merge pull request #3987 from pi-hole/fix/GitHubAPI
...
Use the 'Location:' header only for latest FTL tag API check.
2021-01-13 09:38:09 -08:00
Dan Schaper
523f650157
Use the 'Location:' header only.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2021-01-12 13:42:51 -08:00
Andras Tim
bfee230c79
scripts/list: User same wildcard regex that the UI use
...
The CLI and the UI should do the same to be able to add/remove the same
records via any supported interface.
Signed-off-by: Andras Tim <andras.tim@gmail.com >
2021-01-11 17:05:17 +01:00
DL6ER
c5ed8f8bed
Merge pull request #3537 from MichaIng/patch-2
...
Further failsafe check for available APT packages
2021-01-07 11:56:52 +01:00
Dan Schaper
66dfa5fc1e
Merge pull request #3958 from pi-hole/Fix/centos_stream
...
Fix release check for centos stream
2021-01-06 10:59:27 -08:00
DL6ER
1791fe22f6
Merge pull request #3912 from mdujava/basic_auth
...
Fix validation of adlist url
2020-12-31 12:19:32 +01:00
bcambl
a5422dbdf6
fix release check for centos stream
...
fixes #3947 #3953
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-12-30 19:45:51 -06:00
DL6ER
a2625df5e2
Remove "The list is new" comment because it is superfluous
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-30 11:27:34 +01:00
DL6ER
7507d533ac
Merge pull request #3954 from pi-hole/fix/chronometer_connection_reset
...
Fix connection mechanism between Chronometer and FTL
2020-12-30 11:13:05 +01:00
DL6ER
0944807491
Actually store correct number of domains for the individual lists (and not the sum of the so far collected number of domains)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-29 20:36:49 +01:00
DL6ER
a216848c1d
Only update time of last list change when we see a list for the first time or when it really changed content
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-29 20:28:09 +01:00
DL6ER
e033ee6664
Fix connection mechanism between Chronometer and FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-29 10:29:02 +01:00
DL6ER
8c56f54a1e
Compare checksum of downloaded list against older checksums to see if the list content changed since the last download
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-29 09:54:25 +01:00
DL6ER
6b33b8b4c0
Store status of downloaded list (downloaded, using cache, some error, ...) and number of (in-)valid domains on this list in the gravity database. This updates the gravity databaes to version 14.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-28 08:08:49 +01:00
DL6ER
ae1a59285d
Merge pull request #3943 from yubiuser/fix/whiptail
...
Change wording in whiptail for adlist selection
2020-12-25 09:05:49 +01:00
Christian König
0d710fc9e3
Change wording in whiptail for adlist selection
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-12-24 21:19:14 +01:00
Adam Warner
eb86a5e3b0
Merge pull request #3937 from yubiuser/remove_malwaredomains
...
Remove deprecated malwaredomains list
2020-12-24 15:24:48 +00:00
DL6ER
667e938954
Merge pull request #3942 from pi-hole/master
...
Sync dev with master
2020-12-24 13:33:57 +01:00
Adam Warner
41bdb741b7
Merge pull request #3941 from pi-hole/release/v5.2.2
...
Pi-hole Core v5.2.2
2020-12-24 11:07:36 +00:00
DL6ER
a139af8184
Merge pull request #3940 from pi-hole/fix/i386-arch
...
Add fallback for arch detection on i386/x86_64
2020-12-24 08:38:53 +01:00
Dan Schaper
60fa93ab47
Add fallback for arch detection on i386/x86_64
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-12-23 14:59:28 -08:00
Christian König
b4102547ac
Remove deprecated malwaredomains list
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-12-21 13:11:59 +01:00
Matej Dujava
ef0bdf6470
Fix validation of adlist url
...
Already existing regex validation will be used on url after removing @ (in case
its in separating userinfo and host).
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Fixes: https://github.com/pi-hole/pi-hole/issues/3911
Fixes: 7d19ee1b : validate blocklist URL before adding to the database (#3237 )
2020-12-21 12:50:02 +01:00
Adam Warner
87cf9add8c
Merge pull request #3934 from mwoolweaver/patch-1
...
Fix typo found by #3933
2020-12-20 15:31:02 +00:00
Michael Woolweaver
3a05ac27a2
Fix typo found by #3933
...
Signed-off-by: Michael Woolweaver <m.woolweaver@icloud.com >
2020-12-19 17:37:17 -06:00
MichaIng
eb5661b553
Further failsafe check for available APT packages
...
- "apt-cache show package" succeeds as well if package is listed as (optional) dependency or conflict by another package, hence is not a 100% reliable measure.
- There is no command which explicitly checks which package/name can be selected by apt-get for install. An install simulation/dry-run is possible as it was before Pi-hole v5.1, or the whole package cache can be scraped, which is still the less time consuming solution.
- Allow to succeed if another package "provides" it, like "php7.3-apcu" provided by "php-apcu" or "awk" provided by "mawk" and "gawk", in which case the non-virtual package is selected automatically by apt-get.
For reference: 066b89fa41
Signed-off-by: MichaIng <micha@dietpi.com >
2020-12-18 23:20:24 +01:00
DL6ER
41479524f8
Merge pull request #3900 from ganto/fix/chrono-non-lte
...
Fix chronometer output if web interface is not installed
2020-12-12 10:08:05 +01:00
Adam Warner
357b6702ec
Update advanced/Scripts/chronometer.sh
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2020-12-11 12:30:52 +00:00
DL6ER
dfe64d9f51
Merge pull request #3909 from onegreydot/fix/gravity_date_updated
...
Adding comma to the adlist table format
2020-12-10 23:02:22 +01:00
DL6ER
78cdd34992
Merge pull request #3904 from ganto/fix/debug-non-web-2
...
piholeDebug: Diagnose output if (Web) git directory is not found
2020-12-10 23:00:45 +01:00
DL6ER
16fb914855
Merge pull request #3902 from ganto/fix/debug-non-web
...
piholeDebug: Fix warning if lighttpd/php are not installed
2020-12-10 23:00:02 +01:00
Reto Gantenbein
20faa1bd1c
Update pihole-FTL man-pages ( #3883 )
...
Extend latest options and adjust ordering to Web documentation
Ensure that all configuration options currently recognized by FTL 5.3.1
are properly documented in the man page of the configuration file.
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch >
2020-12-10 22:58:07 +01:00
user
922f795fe6
Adding comma to the adlist table format
...
To account for the Date Updated column in the adlist table adding a comma to the adlist to be imported into the database. This was causing intermittent failures on updates and therefore no domains would be blocked.
Signed-off-by: user <user@fedbrew.home >
Date: Sun Dec 6 06:03:30 2020 -0500
Committer: user <user@fedbrew.home >
On branch fix/gravity_date_updated
Your branch and 'origin/fix/gravity_date_updated' have diverged,
and have 1 and 1 different commits each, respectively.
(use "git pull" to merge the remote branch into yours)
Changes to be committed:
modified: gravity.sh
Signed-off-by: user <user@fedbrew.home >
2020-12-06 06:08:30 -05:00
Reto Gantenbein
9dc539c98b
piholeDebug: More detailed diagnostics if Web interface is not found
...
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch >
2020-12-05 18:46:11 +01:00
Reto Gantenbein
18e4eb460c
piholeDebug: Fix version check if lighttpd/php are not installed
...
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch >
2020-12-05 14:11:53 +01:00
Reto Gantenbein
e841347057
Fix chronometer output if web interface is not installed
...
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch >
2020-12-05 02:55:55 +01:00
DL6ER
6deac6dfce
Merge pull request #3894 from pi-hole/master
...
Update development from Core v5.2.1 release
2020-12-02 23:10:43 +01:00
Adam Warner
0d8ece1be2
Merge pull request #3889 from pi-hole/release/v5.2.1
...
Pi-hole Core release v5.2.1
2020-12-02 21:37:42 +00:00
Adam Warner
8443262214
Merge pull request #3890 from ganto/fix/x86-64-arch
...
Ensure x86_64 processor architecture is listed as supported
2020-12-02 21:12:18 +00:00
Dan Schaper
6993a24224
Merge pull request #3888 from pi-hole/new/github-actions-test
...
Migrate from Travis to Github Actions
2020-12-02 13:06:36 -08:00
Adam Warner
d59eab9a6e
Merge pull request #3893 from pi-hole/tweak/dontdelete
...
Exit installer if directory already exists when trying to clone one of our repos into it
2020-12-02 20:51:16 +00:00
Adam Warner
e47eb30a6e
Update automated install/basic-install.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-12-02 20:49:07 +00:00
Adam Warner
641951b3a0
add some meaningful outputSigned-off-by: Adam Warner <me@adamwarner.co.uk>
2020-12-02 20:40:51 +00:00
DL6ER
db231ded91
Merge pull request #3892 from pi-hole/fix/debug_strip_comments
...
Fix debugger stripping content it shouldn't
2020-12-02 21:23:26 +01:00
Adam Warner
61f13a334d
Don't delete an existing directory and clone our repo in its place. TODO: Something more robust
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-12-02 20:19:59 +00:00
DL6ER
36937b1913
Strip such lines starting with a #. Do not silently truncate lines if they have a # somewhere in between (like server=127.0.0.1#5353)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-02 20:52:39 +01:00
Reto Gantenbein
d0af1a950b
Ensure x86_64 processor architecture is listed as supported
...
Signed-off-by: Reto Gantenbein <reto.gantenbein@linuxmonk.ch >
2020-12-02 20:44:11 +01:00
DL6ER
a217c75134
Merge pull request #3882 from pi-hole/tweak/conditional_transforms
...
Fix processing of CONDITIONAL_FORWARDING_REVERSE
2020-12-01 18:46:54 +01:00
Adam Warner
454c9a411c
Update advanced/Scripts/webpage.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2020-12-01 17:27:36 +00:00
Adam Warner
f44b2f6aa3
Update advanced/Scripts/webpage.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2020-12-01 17:27:21 +00:00
Adam Warner
d1539335bc
appease stickler-ci
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-12-01 10:13:36 +00:00
Adam Warner
44d020a54c
Appease codefactor.io
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-12-01 10:09:16 +00:00
Adam Warner
3e73782f0e
Remove Travis CI config
...
Create Github Actions config
Split tox ini into one per supported distro so they can be run seperately
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-12-01 10:02:31 +00:00
Adam Warner
13cb0c1785
Merge pull request #3887 from pi-hole/fix/non-FQDN-checkbox
...
Fix "Never forward non-FQDNs" checkbox
2020-12-01 09:43:13 +00:00
DL6ER
49810262db
When there is a Pi-hole domain set and "Never forward non-FQDNs" is ticked, we add to tell FTL that this domain is purely local and FTL may answer queries from /etc/hosts or DHCP but should never forward queries on that domain to any upstream servers
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-12-01 09:16:50 +01:00
Adam Warner
58bc98ca44
Update advanced/Scripts/webpage.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-30 22:30:59 +00:00
Adam Warner
4093959d3e
Appease stickler
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-30 21:55:07 +00:00
Adam Warner
06c5fe2a89
Set REV_SERVER_CIDR in the else condition if it is not in-addr.arpa
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-30 21:29:54 +00:00
Adam Warner
6cb8f3f403
Add some comments
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-30 21:18:25 +00:00
Adam Warner
e004d27b28
Fix processing of CONDITIONAL_FORWARDING_REVERSE
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-30 18:58:23 +00:00
DL6ER
e432fae956
Merge pull request #3877 from yubiuser/fix/lsof
...
Add lsof to dependencies for non Debian OS
2020-11-30 11:39:27 +01:00
Christian König
0ecb8bf5e9
Add lsof to dependencies for non Debian OS
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-11-29 21:05:40 +01:00
DL6ER
2c689e8642
Merge pull request #3875 from pi-hole/master
...
Merge Pi-hole Core v5.2 tag into development
2020-11-29 17:29:06 +01:00
Adam Warner
c2fb907490
Merge pull request #3874 from pi-hole/fix/PIHOLE_DNS_truncation
...
Don't delete entries including and greater than `PIHOLE_DNS_10` on update/repair
2020-11-29 15:56:30 +00:00
Adam Warner
a8e97257d7
Ensure entries of PIHOLE_DNS_10 and above are not deleted when removing PIHOLE_DNS_1 and PIHOLE_DNS_2
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-29 15:08:46 +00:00
Adam Warner
fee1b8b736
Merge pull request #3867 from pi-hole/release/v5.2
...
Pi-hole Core v5.2
2020-11-28 19:05:01 +00:00
Adam Warner
f13e0dacde
Merge pull request #3866 from pi-hole/revert-3810-patch-5
...
Revert "Enable DNS forwarding loop detection"
2020-11-28 17:36:44 +00:00
DL6ER
0711f4d63a
Revert "Enable DNS forwarding loop detection"
2020-11-28 18:29:32 +01:00
Adam Warner
d2e9a20d96
Merge pull request #3859 from yubiuser/tweak/debug_pihole-FTL_status
...
Add systemctl status --full --no-pager pihole-FTL.service to the debug log
2020-11-28 16:58:23 +00:00
Adam Warner
40ae29f5bf
Merge pull request #3862 from pi-hole/tweak/debugger_message
...
Include the raw messages from the Pi-hole diagnosis systems in debug logs
2020-11-28 16:51:03 +00:00
Dan Schaper
31909098f8
Merge pull request #3863 from yubiuser/tweak/OpenDNS_decription
...
Add DNSSEC info to OpenDNS description
2020-11-24 12:42:39 -08:00
Christian König
065e5cb1fe
Add DNSSEC to OpenDNS description
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-11-24 21:02:53 +01:00
DL6ER
d4c33e5188
Include the raw messages from the Pi-hole diagnosis systems in debug logs
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-11-24 16:06:45 +01:00
Christian König
70c48afc04
Add else statement
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-11-24 06:02:18 +01:00
Christian König
ec5183b553
Rename function
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-11-24 05:57:13 +01:00
Christian König
50316ee617
Add systemctl status --full --no-pager pihole-FTL.service to the debug log
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-11-23 21:09:35 +01:00
Adam Warner
c4c8e1e5e1
Merge pull request #3854 from pi-hole/tweak/buildContainersTests
...
Nothing to see here. I just forgot a page.
2020-11-19 11:08:30 +00:00
Adam Warner
2a82e1fec1
Nothing to see here. I just forgot a page.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-18 23:29:08 +00:00
Adam Warner
be7bfb2cb4
Merge pull request #3851 from pi-hole/tullo-x86/fix/quad9-missing-upstream
...
Include secondary upstream DNS for Quad9+Filter+ECS
2020-11-18 23:24:12 +00:00
Adam Warner
8bdcb8ff0d
Merge pull request #3849 from pi-hole/tweak/testOsNames
...
-remove duplicate OS dockerfiles
2020-11-18 22:54:39 +00:00
Adam Warner
541b53229c
Include secondary upstream DNS for Quad9+Filter+ECS
...
Co-authored-by: Daniel Tulleman <github@be-lumino.us >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-18 22:06:03 +00:00
Adam Warner
1c2c10c4a5
Merge pull request #3761 from BastiG/development
...
read REV_SERVER_CIDR from environment
2020-11-18 21:56:08 +00:00
Adam Warner
e03585e0bb
Merge pull request #3810 from deHakkelaar/patch-5
...
Enable DNS forwarding loop detection
2020-11-18 21:54:30 +00:00
Adam Warner
03b15dae35
Merge pull request #3848 from chubchubsancho/fix/unattended_install
...
Fix/unattended install
2020-11-18 21:51:44 +00:00
Adam Warner
c64b96e2a8
Merge pull request #3847 from pi-hole/fix/nuke
...
Add some output to the --nuke command
2020-11-17 09:26:26 +00:00
Adam Warner
cd8120d33f
Add some output to the --nuke command
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-16 23:31:35 +00:00
Adam Warner
809e4bdb1d
Set max line length for flake8 to be an (arbitary) 120 chars
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-16 23:06:02 +00:00
Adam Warner
f7982dfbe1
-remove duplicate OS dockerfiles
...
+rename centos->centos_8, centos7 -> centos_7
+update centos/fedora test script
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-11-16 22:39:50 +00:00
Grégory Sanchez
e26472756f
Merge branch 'development' into fix/unattended_install
2020-11-16 23:33:07 +01:00
Grégory Sanchez
6826d9f316
fix(basic-install): unattended install should finish without interaction
...
Fixes: https://github.com/pi-hole/pi-hole/issues/3617
Signed-off-by: Grégory Sanchez <gregory.sanchez@icloud.com >
2020-11-16 23:15:02 +01:00
Adam Warner
bd982c6f94
Merge pull request #3818 from pvogt09/feature/test_all_supported
...
Add test cases for all supported OS
2020-11-15 20:50:26 +00:00
Adam Warner
bd6ca0ad62
Merge pull request #3825 from yubiuser/tweak/cross
...
Change icon from cross to [i] for root user check
2020-11-15 20:42:05 +00:00
Adam Warner
be03f29a9e
Merge pull request #3827 from hvnsweeting/development
...
Re-run the script as root instead of piping to bash
2020-11-15 20:39:25 +00:00
Adam Warner
354c6aab8f
Merge pull request #3828 from hvnsweeting/fix-dco-link
...
Fix dco link
2020-11-15 20:38:02 +00:00
Adam Warner
a7c6eaca5f
Merge pull request #3843 from yubiuser/tweak/debug_decscription
...
Be more specific about what pihole -d -a does
2020-11-15 20:15:21 +00:00
Christian König
e7d937c412
Be more specific what pihole -d -a does
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-11-15 20:31:47 +01:00
pvogt09
b375dd2c81
Update test/ubuntu_20.Dockerfile
...
Co-authored-by: Adam Warner <github@adamwarner.co.uk >
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-11-15 20:13:43 +01:00
Adam Warner
4abd8196ae
Merge pull request #3349 from Forceflow/development
...
Fix for pihole -w --nuke displaying help info even if command is exec…
2020-11-08 16:10:47 +00:00
Viet Hung Nguyen
ae4e41eaaa
Re-run the script as root instead of piping to bash
...
Signed-off-by: Viet Hung Nguyen <hvn@familug.org >
2020-10-30 23:53:31 +07:00
Viet Hung Nguyen
5d2be124a2
Replace the wiki link which now points to this file - a loop
...
Signed-off-by: Viet Hung Nguyen <hvn@familug.org >
2020-10-30 23:13:14 +07:00
Adam Warner
89d94ac3d1
Merge pull request #3819 from craigmayhew/landing-page-security
...
Fixed potential security issue with $landPage receiving variables
2020-10-30 11:44:07 +00:00
Christian König
0ae020ef82
Change icon from cross to [i]# for root user check
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-10-29 20:37:08 +01:00
Craig Mayhew
95a28ae125
unset() now also occurs for $splashPage
...
After some email discussion with Adam, there is a preference to also prevent $splashPage from using variables
Signed-off-by: craigmayhew <craig@mayhew.io >
2020-10-28 18:32:46 +00:00
Craig Mayhew
e5c7549f8f
Fixed potential security issue with $landPage receiving variables
...
Signed-off-by: craigmayhew <craig@mayhew.io >
2020-10-27 14:49:46 +00:00
pvogt09
4386cc4f22
Revert "add test case for installation of dependencies for installer, core and web"
...
This reverts commit 60a4814ac1 .
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-27 12:44:57 +01:00
pvogt09
cb49ce38f5
fix stickler errors
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-27 12:32:23 +01:00
pvogt09
3128d14d1f
update images to versions supported by pi-hole 5
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-27 12:02:57 +01:00
pvogt09
bef9cd3bc2
mock whiptail to add universe repo
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-27 11:35:49 +01:00
pvogt09
60a4814ac1
add test case for installation of dependencies for installer, core and web
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-27 11:35:48 +01:00
pvogt09
fec1595183
add docker containers for debian 9 and 10, ubuntu 16 and 18, fedora 28 and 29
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-27 11:34:27 +01:00
Adam Warner
3e79e0b1ab
Merge pull request #3625 from pi-hole/new/tests
...
Update Test suite
2020-10-26 21:32:48 +00:00
Adam Warner
c80f0766c5
drop debian/fedora container versions to lowest supported
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-26 17:56:17 +00:00
Adam Warner
fb454ebe14
fix stickler complaints
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-23 23:09:07 +01:00
Adam Warner
ee556088b5
Fake OS details in /etc/os-release and confirm install fails
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-23 23:05:41 +01:00
bcambl
660c17814d
E128 continuation line under-indented for visual indent
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-10-23 22:20:37 +01:00
bcambl
a7c58e7112
E302 expected 2 blank lines, found 1
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-10-23 22:20:36 +01:00
bcambl
05b6717187
test PHP optin/optout separately for CentOS 7 & 8
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-10-23 22:20:36 +01:00
bcambl
2c461460db
test with both centos7 and centos8 images
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-10-23 22:20:36 +01:00
Adam Warner
5aab68ab41
Update test/test_automated_install.py
...
Co-authored-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-10-23 22:20:36 +01:00
Adam Warner
5648ad6b61
[Experiment] up python to 3.7
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-23 22:20:36 +01:00
Adam Warner
c9edcfa335
add test to check "os_check" works
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-23 22:18:42 +01:00
Adam Warner
33e5735053
Change base images for test containers to latest supported version
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-23 22:18:42 +01:00
deHakkelaar
ad39ba30bd
Enable DNS forwarding loop detection
...
Found below by accident:
```
pi@ph5:~ $ man dnsmasq
[..]
--dns-loop-detect
Enable code to detect DNS forwarding loops; ie the situa‐
tion where a query sent to one of the upstream server
eventually returns as a new query to the dnsmasq instance.
The process works by generating TXT queries of the form
<hex>.test and sending them to each upstream server. The
hex is a UID which encodes the instance of dnsmasq sending
the query and the upstream server to which it was sent. If
the query returns to the server which sent it, then the
upstream server through which it was sent is disabled and
this event is logged. Each time the set of upstream
servers changes, the test is re-run on all of them, in‐
cluding ones which were previously disabled.
```
Seems to work just fine if I point my router 10.0.0.1 back to Pi-hole in the WAN DNS settings:
```
pi@ph5:~ $ grep server= -R /etc/dnsmasq.*
/etc/dnsmasq.d/01-pihole.conf:server=9.9.9.10
/etc/dnsmasq.d/01-pihole.conf:server=149.112.112.10
/etc/dnsmasq.d/01-pihole.conf:server=10.0.0.1
/etc/dnsmasq.d/01-pihole.conf:rev-server=10.0.0.0/24,10.0.0.2
/etc/dnsmasq.d/01-pihole.conf:server=/dehakkelaar.nl/10.0.0.2
/etc/dnsmasq.d/01-pihole.conf:server=/use-application-dns.net/
```
```
pi@ph5:~ $ sudo tee /etc/dnsmasq.d/99-my-settings.conf <<< $'dns-loop-detect'
dns-loop-detect
```
```
pi@ph5:~ $ pihole restartdns
[✓] Restarting DNS server
```
```
pi@ph5:~ $ tail -F /var/log/pihole.log
[..]
Oct 22 18:17:41 dnsmasq[17301]: using nameserver 10.0.0.2#53 for domain dehakkelaar.nl
Oct 22 18:17:41 dnsmasq[17301]: using nameserver 10.0.0.2#53 for domain 0.0.10.in-addr.arpa
Oct 22 18:17:41 dnsmasq[17301]: NOT using nameserver 10.0.0.1#53 - query loop detected
Oct 22 18:17:41 dnsmasq[17301]: using nameserver 149.112.112.10#53
Oct 22 18:17:41 dnsmasq[17301]: using nameserver 9.9.9.10#53
```
2020-10-22 18:54:04 +02:00
DL6ER
50100017a5
Merge pull request #3794 from pi-hole/security/non_FQDNs_locality
...
Security enhancement for the "never forward non-FQDNs" feature
2020-10-21 21:09:05 +02:00
Adam Warner
de02bcc8a0
Merge pull request #3787 from pi-hole/verdantfire
...
fixed small grammatical error
2020-10-19 10:53:41 +01:00
DL6ER
83f2e2d85a
Merge pull request #3801 from pi-hole/new/armv4_armv5_armv8
...
Add native ARMv4T, ARMv5TE and ARMv8-A support
2020-10-18 19:53:56 +02:00
DL6ER
01c9bbd3ca
Improve processor detection to use the new dedicated ARMv4T, ARMv5TE and ARMv8-A binaries we provide for FTL.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-10-14 20:31:22 +02:00
DL6ER
e93d7ad8ff
Merge pull request #3803 from pi-hole/privacylevel
...
Remove references to privacy level 4 (no longer functional)
2020-10-14 14:05:20 +09:00
Adam Warner
59b0a6af6f
Remove references to privacy level 4 (no longer functional)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-13 23:53:23 +01:00
Dan Schaper
326168509c
Merge pull request #3798 from bcambl/debug_firewalld
...
add FirewallD configuration checks to debug script
2020-10-12 12:37:20 -07:00
bcambl
47aa1644a8
add debug checking for firewalld
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-10-11 22:20:31 -06:00
DL6ER
08a84e51d6
Only add local=/<domain>/ when the "only forward FQDN queries" function is enabled to prevent unintended side-effects of this change
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-10-10 11:23:55 +02:00
DL6ER
d631cd8b04
Security enhancement for the "never forward non-FQDNs" feature. This should prevent all local queries from being forwarded (will show up as blocked by regex) as well as any hostname without a domain (for example one word searches from the address bar in browsers). This fixes #3303
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-10-10 11:01:01 +02:00
Adam Warner
0445559610
Accidentally a number ( #3788 )
...
Co-authored-by: MichaIng <micha@dietpi.com >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: MichaIng <micha@dietpi.com >
2020-10-09 17:24:42 +02:00
MichaIng
615b19c3d6
web server question enhancements ( #3225 )
...
+ Do not ask to install the web server, if the web interface has been deselected before.
+ Add additional info, that PHP modules need to be installed manually, when web server is deselected and the web server user needs to be member of the "pihole" group.
+ Consequently use webroot variable instead of /var/www/html
Signed-off-by: MichaIng <micha@dietpi.com >
2020-10-09 16:12:21 +02:00
Adam Warner
948337dd8e
Merge pull request #3740 from pi-hole/new/adlist_date_updated
...
Add date_updated field to adlist table
2020-10-09 14:04:13 +01:00
Adam Warner
fe463f15b3
Merge pull request #3741 from pi-hole/new/debug_scan_dhcp
...
Discover active DHCP servers during debugger run
2020-10-09 14:00:57 +01:00
Adam Warner
716e981a79
Merge pull request #3776 from yubiuser/tweak/Debug
...
Print tail of logs in /var/log/lighttpd in debug run as well
2020-10-09 13:50:46 +01:00
verdantfire
b88efd2527
fixed small grammatical error
...
Co-authored-by: Himanshu Ruhela <himanshuruhela013@gmail.com >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-10-09 13:46:25 +01:00
Christian König
568ebd67ca
Update comment
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-10-03 16:17:37 +02:00
Christian König
c628c970ae
Print tail of logs in /var/log/lighttpd in debug run as well
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-10-02 21:04:27 +02:00
Adam Warner
fa0815fb1d
Merge pull request #3763 from yubiuser/cleanup
...
Remove traces of previous default adlists
2020-09-28 08:53:08 +01:00
Christian König
e9796d5671
Remove traces of previous default adlists
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-09-28 06:15:46 +02:00
Sebastian Gmeiner
8041bbf443
read REV_SERVER_CIDR from environment
...
Signed-off-by: Sebastian Gmeiner <sebastian@gmeiners.net >
2020-09-25 15:26:43 +02:00
Adam Warner
d6c4f0696f
Merge pull request #3698 from yubiuser/remove/FreeSpaceCheck
...
Remove check for free disk space and associated variables
2020-09-21 08:47:41 +01:00
DirkJanIT
b88510d89a
Add CACHE_SIZE to setupVars ( #3170 )
...
* Update 01-pihole.conf
Signed-off-by: DoubleOhmSeven <57564379+DoubleOhmSeven@users.noreply.github.com >
* Update basic-install.sh
Signed-off-by: DoubleOhmSeven <57564379+DoubleOhmSeven@users.noreply.github.com >
Co-authored-by: DoubleOhmSeven <57564379+DoubleOhmSeven@users.noreply.github.com >
2020-09-17 23:13:40 +02:00
Blayne Campbell
4d98e156b6
Merge pull request #3607 from cgzones/selinux
...
basic-install: document how to continue after SELinux check
2020-09-16 23:54:05 -06:00
DL6ER
5db45aed8b
Merge pull request #3178 from jlagermann/wormhole
...
added instructions for forking and rebase
2020-09-08 22:58:43 +02:00
Dan Schaper
b865fa7c0a
Merge pull request #3739 from pi-hole/tweak/remove_gravity_optimization
...
Remove extra gravity optimization flag
2020-09-07 14:23:54 -07:00
DL6ER
41e899260f
Discover active DHCP servers during debugger run
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-09-07 23:17:50 +02:00
DL6ER
12b9748c43
Fine-tune adlist:adte_modified trigger and don't default new date_updated column to now but use NULL instead
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-09-07 21:11:57 +02:00
DL6ER
4fd412d7c3
Add date_updated field in adlist table set when a list changes.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-09-07 20:59:23 +02:00
DL6ER
aa7c3b6852
Remove gravity optimization. Further investigations have shown that it is useless because the standard gravity run already produces an optimal database.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-09-07 20:50:11 +02:00
Adam Warner
17ed5398e6
Merge pull request #3737 from michi-zuri/patch-2
...
Update index.php
2020-09-06 13:00:01 +01:00
Michael Paul Killian
5eabf4255b
Sign-off for DCO
...
Signed-off-by: Michael Paul Killian <spammyreset-github@gmail.com >
2020-09-06 13:53:03 +02:00
Michael Paul Killian
538827397c
Update index.php
...
See #3736
2020-09-06 11:51:33 +02:00
DL6ER
b81cbaa088
Merge pull request #3702 from pi-hole/tweak/os_check_output
...
Display more meaningful exit message if `dig` command fails during os_check
2020-08-23 16:08:56 +02:00
Adam Warner
e02cf6fac5
further tweaks, plus a spelling mistake correction
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-08-23 14:50:04 +01:00
Adam Warner
b8cd238fa1
Update advanced/Scripts/piholeDebug.sh
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2020-08-23 14:35:02 +01:00
Adam Warner
8e219cb799
Make output more meaningful in case of dig failure.
...
Include dig return code and response in debug run
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-08-23 10:48:15 +01:00
Christian König
65786ba5d6
Remove check for free disk space and associated variables
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-08-18 20:16:35 +02:00
Adam Warner
42f55f5202
Merge pull request #3688 from pi-hole/tweak/os-check
...
Tweaks to os_check() Redux
2020-08-17 17:31:58 +01:00
Adam Warner
725f02f442
Merge pull request #3673 from yubiuser/fix/double_check_adlist_not_selected
...
Revert "fix #3336 by creating adlist file even if no list was selecte…
2020-08-17 17:30:31 +01:00
Dan Schaper
ebdb68a47a
display_warning fixes
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-08-15 10:54:31 -07:00
Dan Schaper
623ce1fe18
Tabs and debug.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-08-14 14:37:58 -07:00
Dan Schaper
57e65dd5c0
Use fewer subshells and descriptive variables.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-08-14 11:42:54 -07:00
Adam Warner
bb1a6243d6
Merge pull request #3669 from pi-hole/release/v5.1.2
...
Release/v5.1.2 to development
2020-08-14 16:28:53 +01:00
Dan Schaper
ad9b981e8b
Merge pull request #3678 from yubiuser/fix/brokenVideoLink
...
Removes broken youtube link
2020-08-11 15:06:49 -07:00
Christian König
5b1eaa7e38
Removes broken youtube link
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-08-11 22:35:33 +02:00
Christian König
5c72ff75d9
Revert "fix #3336 by creating adlist file even if no list was selected by user"
...
This reverts commit 3c6ea2612d .
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-08-10 23:52:53 +02:00
Dan Schaper
cd4072fbf8
Merge pull request #3665 from scboucher/fix_Pi-hole_temp_unit_default_value
...
Change default value of temp_unit to 'C'
2020-08-09 17:10:11 -07:00
Adam Warner
6b536b7428
Merge pull request #3564 from pi-hole/release/v5.1.2
...
Pi-hole Core v5.1.2
2020-08-09 22:22:16 +01:00
Samuel Boucher
d4dd446ba3
Update advanced/Scripts/chronometer.sh
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Samuel Boucher <scboucher@users.noreply.github.com >
2020-08-09 17:12:20 -04:00
Samuel Boucher
8b4921405a
Upercase the temp_unit
...
Signed-off-by: Samuel Boucher <scboucher@users.noreply.github.com >
2020-08-09 15:09:49 -04:00
DL6ER
492a0317b0
Merge pull request #3654 from pi-hole/fix/ipv6_localhost_validator
...
Allow IPv6 loopback address to be added
2020-08-04 22:21:35 +02:00
DL6ER
b5983a3fc1
Do not require first element to be a hex value at any costs. It may also be a : in the valid address ::1
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-08-04 22:11:32 +02:00
Adam Warner
4bef49e2eb
Merge pull request #3646 from yubiuser/tweak/compression
...
Check for compression only once and print result
2020-08-03 22:20:37 +01:00
Christian König
27399a762a
Check for compression onyl once and print result
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-08-03 22:46:14 +02:00
DL6ER
83ecaa0fc9
Merge pull request #3636 from pi-hole/meta/remove_templates
...
Remove respository templates.
2020-08-03 20:44:51 +02:00
DL6ER
79ff21a2fe
Merge pull request #3641 from pi-hole/new/compressed_curl
...
Use compression (if available) when downloading the ad lists.
2020-08-02 19:21:16 +02:00
DL6ER
87da9084e6
Use compression (if available) when downloading the ad lists.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-08-02 16:21:58 +01:00
Dan Schaper
72df833b8e
Merge pull request #3639 from nfriend/nfriend-fix-about-pi-hole-link
...
Update "About Pi-hole" link on "Website Blocked" page
2020-08-01 18:26:24 -07:00
Nathan Friend
5a48478196
Update "About Pi-hole" link
...
Signed-off-by: Nathan Friend <nathan@gitlab.com >
2020-08-01 20:00:49 -05:00
Dan Schaper
8fa9096508
Remove respository templates.
...
Use org templates instead.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-08-01 01:34:38 -07:00
DL6ER
319b8eef75
Merge pull request #3527 from MichaIng/patch-1
...
Add default locations to PATH to assure that all basic commands are available
2020-07-31 18:14:45 +02:00
Aiden Mitchell
7c53b97004
Updating FAQ_HARDWARE_REQUIREMENTS and FAQ_HARDWARE_REQUIREMENTS_PORTS ( #3632 )
...
Signed-off-by: Aiden Mitchell <aiden@bcyouthcouncil.ca >
Co-authored-by: Adam Warner <me@adamwarner.co.uk >
2020-07-30 12:57:19 -07:00
Dan Schaper
18fc45c006
Merge pull request #3634 from pi-hole/new/move_travis
...
.travis.yml is now a stub.
2020-07-30 11:46:37 -07:00
Dan Schaper
fa574cfd08
Set non-master to point to latest.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-07-30 10:05:27 -07:00
Dan Schaper
932cdd3329
Use the .github repository.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-07-30 09:38:50 -07:00
Dan Schaper
dc2781d1f9
.travis.yml is now a stub.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-07-30 09:26:04 -07:00
Adam Warner
48820d181c
Merge pull request #3620 from yubiuser/tweak/dig_supportedOS
...
Report and exit if dig supportedOS returns nothing
2020-07-30 17:00:01 +01:00
Christian Göttsche
51daeaa6ab
basic-install: document how to continue after SELinux check
...
Signed-off-by: Christian Göttsche <cgzones@googlemail.com >
2020-07-30 14:50:42 +02:00
Dan Schaper
514dc013df
Merge pull request #3597 from yubiuser/tweak/OS_detection
...
Adds OS and version to output if unsupported OS is detected
2020-07-28 07:42:41 -07:00
Dan Schaper
548ad6375d
Merge pull request #3524 from pi-hole/fix/status_checking
...
Fix pihole status to not rely on a TCP port test
2020-07-28 07:24:34 -07:00
Christian König
6fc7dc28a2
Count elements of array instead
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-28 10:25:57 +02:00
Christian König
b207ceeab2
Report and exit if dig supportedOS returns nothing
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-28 09:51:31 +02:00
Christian König
8380112129
Resolve conflicts
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-28 09:40:45 +02:00
Dan Schaper
dffb58ae8f
Merge pull request #3596 from pi-hole/tweak/wherecheck
...
Wrap entire function in the check for the ENVVAR, add `ns1.pi-hole.net` to `dig` check.
2020-07-27 10:01:14 -07:00
Adam Warner
0ff32c3629
Use ns1.pi-hole.net to resolve versions.pi-hole.net so that we do not see DNS cookie issues
...
Co-Authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-27 17:44:22 +01:00
Dan Schaper
dfd331c5b7
Merge pull request #3608 from yubiuser/fix/customDNSfile
...
Create custom.list during install/update if it doesn't exist
2020-07-26 12:51:19 -07:00
Dan Schaper
0a81d687e8
Update automated install/basic-install.sh
2020-07-26 12:31:11 -07:00
Christian König
dfcdfd4b0a
Remove empty line
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-26 12:27:55 +02:00
Christian König
ec9f490fcc
Remove separate install function, move to installConfigs(), use pihole syntax
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-24 20:32:32 +02:00
Christian König
331502e14c
Add variable that got lost
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-23 20:52:21 +02:00
Christian König
18c24d985f
Create custom.list during install/update if it doesn't exist
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-23 20:43:12 +02:00
Adam Warner
ddb36c013d
it helps if the echo goes variable set goes in the right place
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-22 22:39:03 +01:00
Adam Warner
98dc51869e
accidentally missed \\n
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-22 22:30:51 +01:00
Adam Warner
510b646736
change up the verbiage with something that works (tested)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-22 22:29:38 +01:00
James Lagermann
da6b78f4c5
Merge branch 'development' into wormhole
...
changed console to bash
clone to fork
Signed-off-by: James Lagermann <james.lagermann@corelight.com >
Update CONTRIBUTING.md
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-07-22 11:32:10 -05:00
DL6ER
61616b8c86
Merge pull request #3599 from pi-hole/fix/gravity_cronjob
...
Fix for gravity cronjob
2020-07-21 23:11:29 +02:00
James Lagermann
be14000778
added blanks-around-fences to correct lint errors
...
Signed-off-by: James Lagermann <james.lagermann@corelight.com >
2020-07-21 15:41:50 -05:00
James Lagermann
93c1a62998
Update CONTRIBUTING.md
...
Co-authored-by: jrschat <54955683+jrschat@users.noreply.github.com >
signed-off-by: James Lagermann <james.lagermann@corelight.com >
2020-07-21 15:41:14 -05:00
DL6ER
527fc3c5cf
Also pidof -> pgrep in gravity.sh
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-07-21 22:03:54 +02:00
DL6ER
8f7f0881c6
Add /usr/sbin to cronjob PATH
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-07-21 21:21:24 +02:00
DL6ER
17aabf26f7
Also use pkill/pgrep in the FTL service script
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-07-21 21:21:17 +02:00
DL6ER
6ee6eea1fb
Use pkill instead of the somewhat fragile combination of kill + pidof. This solves some issues especially when there are many TCP workers floating around.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-07-21 21:13:40 +02:00
Adam Warner
ea22774d16
Wrap entire function in the check for the ENVVAR
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-21 18:47:13 +01:00
James Lagermann
5c9fbd7d1f
Merge pull request #3 from pi-hole/development
...
Development
2020-07-20 16:50:17 -05:00
Dan Schaper
b0ea043b6a
Merge pull request #3581 from jokajak/patch-1
...
chore(README.md): Grammar fix
2020-07-20 13:06:29 -07:00
Josh
27366fe9f0
chore(README.md): Grammar fix
...
Fix small grammar issue in README.md
Signed-off-by: Jokajak <jokajak@gmail.com >
2020-07-20 15:50:27 -04:00
MichaIng
25b873cf7b
Add default locations to PATH to assure that all basic commands are available
...
Signed-off-by: MichaIng <micha@dietpi.com >
2020-07-18 17:30:27 +02:00
Adam Warner
643d2c0f3e
add missing port number validation section to valid_ip6
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-16 21:31:45 +01:00
Adam Warner
533e5dddd0
clarify examples in case of unsupported OS
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-16 18:33:53 +01:00
Adam Warner
60f0ab51c9
Merge pull request #3555 from pi-hole/release/v5.1.1
...
Release/v5.1.1 -> development
2020-07-16 18:29:00 +01:00
Adam Warner
56cd7c4d59
Merge pull request #3549 from pi-hole/release/v5.1.1
...
Pi-hole core v5.1.1
2020-07-15 23:56:47 +01:00
Adam Warner
f50cff54de
*innocent whistling*
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-15 23:49:17 +01:00
Adam Warner
acfb092e4b
fix minor bug in 5.1
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-15 23:38:08 +01:00
Adam Warner
e9b039139c
Merge pull request #3531 from pi-hole/release/v5.1
...
Pi-hole Core v5.1
2020-07-15 22:35:12 +01:00
Dan Schaper
e4b2d29552
Merge pull request #3548 from pi-hole/tweak/supportedos.txt
...
add one
2020-07-15 14:14:32 -07:00
Adam Warner
b4ca13b3ad
add one
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-15 22:03:07 +01:00
Adam Warner
b9b7d5f8eb
Merge pull request #3547 from pi-hole/fix/debug20.04
...
fallback to NC if curl fails on uploadgit checkout
2020-07-15 22:01:36 +01:00
Adam Warner
849139176e
fallback to NC if curl fails on uploadgit checkout
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-15 21:54:45 +01:00
Adam Warner
ae0d1de188
Merge pull request #3545 from pi-hole/tweak/debugoutput
...
Add additional information about local debug log location
2020-07-15 21:25:59 +01:00
Adam Warner
b8bba7951f
Just one more newline, give it to me.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-15 20:49:18 +01:00
Adam Warner
76ce5ec66b
Add additional information about local debug log location
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-07-15 20:45:02 +01:00
Adam Warner
7b41b99549
Merge pull request #2887 from tlk/fix/reenable
...
Prevent "pihole disable $timeout" from messing up future state changes
2020-07-15 20:23:33 +01:00
DL6ER
0cc999ea1f
Merge pull request #3543 from pi-hole/tweak/readme
...
Update README.md
2020-07-14 05:36:12 +02:00
Dan Schaper
a99eac9d10
Update README.md
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-07-13 14:29:45 -07:00
DL6ER
e76f0119b4
Merge pull request #3534 from yubiuser/tweak/saveLocation
...
Use gravity's adlist_id in filename when saving downloaded adlist locally
2020-07-06 15:13:05 +02:00
Adam Warner
a3ae47023f
Merge pull request #3533 from pi-hole/release/v5.1
...
Release/v5.1
2020-07-05 13:38:54 +01:00
Adam Warner
6ff0926f4a
Merge pull request #3532 from pi-hole/XhmikosR-patch-1
...
Fix minor typo
2020-07-05 13:36:41 +01:00
Christian König
73963fecda
Use gravity's adlist_id in filename when saving downloaded adlist locally
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-07-05 14:32:33 +02:00
XhmikosR
d8822b70cf
Fix minor typo
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-07-05 15:12:02 +03:00
Adam Warner
f50d59fe94
Merge pull request #3425 from XhmikosR/lighttpd
...
Tweak lighttpd configs
2020-07-02 10:53:56 +01:00
XhmikosR
cf1c1e2e7e
Tweak lighttpd configs
...
* Compress more types
* Add charset=utf-8 in more text types
* Use proper media types
* Add default expire header
* Use consistent indentation
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-07-02 12:28:26 +03:00
Adam Warner
f5a5f68a1a
Merge pull request #3403 from XhmikosR/XhmikosR-patch-1
...
Fix/tweak blocking page
2020-07-02 10:27:16 +01:00
DL6ER
94cd7f59d4
Make verbose output the default.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-07-01 18:49:31 +02:00
DL6ER
6009e86947
Fix pihole status to not rely on a TCP port test. The current test can fail even when there is no error i case the max. number of TCP workers is reached.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-07-01 18:39:28 +02:00
Dan Schaper
56e0549c7a
Merge pull request #3420 from XhmikosR/XhmikosR-patch-4
...
Markdown tweaks
2020-06-30 13:20:29 -07:00
Adam Warner
49f099e382
Merge pull request #3510 from pi-hole/fix/ip_validation_setdns
...
Also validate IPV6 in the `setdns` function
2020-06-25 17:58:55 +01:00
Adam Warner
3205606fc3
Also validate IPV6 in the setdns function
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-23 20:38:18 +01:00
Dan Schaper
3aaf9d89b3
Merge pull request #3260 from pi-hole/new/rev-server
...
Improve conditional forwarding
2020-06-21 13:26:07 -07:00
DL6ER
2c3aa9ab00
Merge pull request #3491 from pi-hole/fix_ip_address_section
...
Fix fresh install on dev branch not working
2020-06-21 21:58:36 +02:00
DL6ER
bf392d7a60
Merge pull request #3489 from pi-hole/ip_validation
...
Improve IP validation function
2020-06-21 21:56:30 +02:00
DL6ER
9bf0f2a161
Reduce handholding when trying to foresee the intentions of the user. The code does now preserve legacy behavior and users can open up the subnet manually if they like.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-06-21 21:47:30 +02:00
Adam Warner
bbfbf67fcf
further simplify the function, per @dl6er's suggestion
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-15 22:52:24 +01:00
Adam Warner
fe30ce10d3
simpler regex suggested by @MichaIng
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-15 21:21:40 +01:00
Dan Schaper
3136d239df
Merge pull request #3492 from pi-hole/fix/man-restartdns
...
Improve man pihole restartdns section
2020-06-15 10:05:05 -07:00
DL6ER
c9350fa76d
Improve man pihole restartdns section.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-06-14 21:59:20 +02:00
Adam Warner
b96ce13085
Merge pull request #3490 from pi-hole/fix_os_check
...
Fix new os_check
2020-06-14 00:24:33 +01:00
Adam Warner
7ea6d7b92b
remove ; so IFS changes don't stick
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-14 00:17:51 +01:00
Adam Warner
011fa8c6ea
fix sticklr complaint
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-13 21:47:00 +01:00
Adam Warner
1ebf0785b6
move dnsutils/bind-utils to installed deps and only check OS is supported after installing installer deps
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-13 21:33:03 +01:00
Adam Warner
0320d85028
Additionally source the install script in webpage.sh to validate IP entered on pihole -a setdns
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-13 20:57:57 +01:00
Adam Warner
95f4c632f7
expand valid_ip to allow for custom ports
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-13 20:30:03 +01:00
Dan Schaper
4b59287683
Merge pull request #3441 from pi-hole/new/os_check
...
Display warning if unsupported OS is detected
2020-06-05 13:39:39 -07:00
Dan Schaper
5f9dac8d2b
Merge pull request #3434 from pi-hole/new/os_detect
...
Change OS Detection in debug script
2020-06-05 13:38:50 -07:00
Adam Warner
9844a3288f
Same change as 03a8cff
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-05 21:06:25 +01:00
Adam Warner
03a8cff55e
read > mapfile as suggested by @dschaper
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-05 21:01:53 +01:00
Dan Schaper
c9dd3ee2e9
Merge pull request #3470 from pi-hole/fix/escape_where_should_be_none
...
Replace possible "\#" by "#" to fix AdminLTE#1427
2020-06-05 12:25:53 -07:00
XhmikosR
52cb389d94
Markdown tweaks
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-06-04 16:19:21 +03:00
DL6ER
2b1bc6a46e
Replace possible "\#" by "#". This fixes AdminLTE#1427
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-06-04 09:32:40 +02:00
DL6ER
6160eb6894
This regex is too complex for bash's own replacement. Add ignore for the shellcheck rule.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-06-04 09:22:40 +02:00
DL6ER
318ca75269
Merge branch 'development' into new/rev-server
2020-06-04 08:56:08 +02:00
Adam Warner
13a49b0753
Merge pull request #3466 from pi-hole/tweak/improve_unique_domains
...
Allow certain domain duplicates
2020-06-03 21:41:20 +01:00
Adam Warner
58724a38a9
Improve detection and display of supported/unsupported OS in debug script
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-06-03 17:57:22 +01:00
Adam Warner
8fef35be0f
Update README.md
...
remove dead link to gitter
2020-06-03 16:11:09 +01:00
DL6ER
202ba055ea
Change UNIQUEness constraint from (domain) to (domain, type) in the domainlist table. This will allow duplicates which can be associated to different groups.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-06-02 10:49:35 +02:00
Adam Warner
5488fb0caf
Merge pull request #3463 from jesterchen/patch-1
...
Patch 1
2020-06-01 11:29:17 +01:00
jesterchen
0a47140239
Merge branch 'patch-1' of github.com:jesterchen/pi-hole into patch-1
2020-06-01 12:06:38 +02:00
jesterchen
7248d1a504
Ensure that adlistFile is created before chmodding
...
If an user installs Pi-hole without selecting any adlists, the installer emits a warning and exits. By touching the file this is prevented.
Signed-off-by: jesterchen <github@jesterweb.de >
2020-06-01 12:06:02 +02:00
jesterchen
7934a9bcb4
Ensure that adlistFile is created before chmodding
...
If an user installs Pi-hole without selecting any adlists, the installer emits a warning and exits. By touching the file this is prevented.
2020-06-01 12:00:29 +02:00
XhmikosR
d90313fe4d
Fix/tweak blocking page
...
* fix favicon
* add meta charset
* add html lang
* add a page title
* remove unneeded html end tags
* fix viewport tag to allow zooming
* compress the "blocked by Pi-hole" SVG
* remove trailing spaces
* switch to double colon pseudo elements (works from IE9 and newer)
* add missing vendor prefixes
* other minor tweaks
* add `Access-Control-Allow-Origin` header to all font types
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-05-31 15:54:11 +03:00
Dan Schaper
c73001f392
Merge pull request #3412 from XhmikosR/links
...
Update links
2020-05-30 12:45:15 -07:00
XhmikosR
7579ab178a
Update links
...
* use https when possible
* replace coverage with a link to the docs page in README.md
* remove obsolete affiliate link in README.md
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-05-30 21:50:16 +03:00
Thomas L. Kjeldsen
903808a477
Improved explanation of why this script is needed
...
Signed-off-by: Thomas L. Kjeldsen <tlk@closureconsulting.com >
2020-05-30 03:14:03 +02:00
Thomas L. Kjeldsen
005da06b3d
Use PI_HOLE_BIN_DIR as introduced in PR #2886
...
Signed-off-by: Thomas L. Kjeldsen <tlk@closureconsulting.com >
2020-05-30 03:13:51 +02:00
Thomas L. Kjeldsen
852f6b95f5
Prevent "pihole disable $timeout" from messing up future state changes
...
Signed-off-by: Thomas L. Kjeldsen <tlk@closureconsulting.com >
2020-05-30 02:58:27 +02:00
DL6ER
5dc7ec0fa0
Merge pull request #3455 from pi-hole/tweak/FTL_niceness
...
Add CAP_SYS_NICE to FTL's capabilities
2020-05-28 22:00:49 +02:00
DL6ER
de8976da7a
Add CAP_SYS_NICE to FTL's capabilities so it can control its own niceness.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-05-28 21:18:31 +02:00
Adam Warner
e43450f56e
Merge pull request #3451 from pi-hole/its-getting-awful-quiet-in-here
...
Remove deprecated Disconnect lists from "defaults"
2020-05-27 08:46:32 +01:00
Adam Warner
4f7bb7b811
Remove deprecated Disconnect lists from "defaults"
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-26 21:23:44 +01:00
Adam Warner
01ab82b869
Merge pull request #3446 from pgl/development
...
Updated gravity.sh to allow semicolons in URLs
2020-05-26 15:26:28 +01:00
Peter Lowe
dd205c55c1
Updated gravity.sh to allow semicolons
...
Signed-off-by: Peter Lowe <pgl@yoyo.org >
2020-05-26 15:53:10 +02:00
DL6ER
b60ec8a48f
Merge pull request #3248 from MichaIng/patch-8
...
Start pihole-FTL after network
2020-05-25 21:27:27 +02:00
Adam Warner
acf2879057
Address sticklr complaints
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-25 17:49:19 +01:00
DL6ER
27f0fd2372
Merge pull request #3415 from fhriley/reload_privacy
...
Reload the lists, which will cause the cached privacy level to be upd…
2020-05-25 18:47:44 +02:00
Adam Warner
af1129fc28
Add a check at the top of the script to determine if the script is being run on a supported OS
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-25 17:40:20 +01:00
Adam Warner
ee172cd6e9
Merge pull request #3423 from pi-hole/debug-extras
...
Debug extras
2020-05-22 07:53:06 +01:00
Adam Warner
d0e250a616
Ensure pihole-FTL.conf is parsed, as well as external.conf for lighttpd, to rule out any custom modifications.
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-21 22:25:00 +01:00
Adam Warner
b2ba55c27b
Show details of any remotes on the git repositories
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-21 21:23:26 +01:00
Dan Schaper
3f83c314b6
Merge pull request #3419 from XhmikosR/XhmikosR-patch-3
...
Remove csslint from Strickler CI
2020-05-21 10:11:53 -07:00
XhmikosR
5094fab491
Remove csslint from Strickler CI
...
There's only one CSS file and the page where it's used has become obsolete.
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2020-05-21 17:44:32 +03:00
Frank Riley
9d04c517e6
Reload the lists, which will cause the cached privacy level to be updated.
...
Signed-off-by: Frank Riley <fhriley@gmail.com >
2020-05-20 15:47:53 -07:00
DL6ER
b421e422c2
Merge pull request #3351 from marank/development
...
Added support for CNAME record add/remove
2020-05-20 09:13:54 +02:00
Adam Warner
60afebfd03
Merge pull request #3406 from pi-hole/tweak/words
...
Use `toggle` instead of `select`
2020-05-19 07:46:40 +01:00
Adam Warner
414ab53d9a
Use toggle instead of select to remove any hint of a doubt that the option already selected by default can be deselected
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-18 22:29:36 +01:00
MichaIng
5c17e41cf1
Start pihole-FTL after network
...
"$network" on a systemd-driven OS leads to "After=network-online.target" in the generated systemd unit.
This target is no guarantee that all network interfaces have been fully configured, as it depends on the related network services types, but at least it reduces the risk that those have not fully finished their job when pihole-FTL starts. If this is the case, certain issues can occur:
- https://github.com/pi-hole/pi-hole/issues/2924
- https://discourse.pi-hole.net/t/have-to-pihole-restartdns-after-reboot/28772
Runtime files are now consistently created in "/run" instead of "/var/run". The second is a symlink to the first for backwards compatibility but on none-ancient distro versions one should use "/run", systemd even prints a warnings if service files use "/var/run". The service file used "/run" and "/var/run" both, in cases for the same files/directories before, which does not directly cause issues currently, due to the symlink, but is inconsistent at best.
Signed-off-by: MichaIng <micha@dietpi.com >
2020-05-16 13:38:18 +02:00
Adam Warner
5ce8791693
Merge pull request #3388 from pvogt09/fix/no_adlist_selected
...
fix #3336 by creating adlist file even if no list was selected by user
2020-05-15 23:22:35 +01:00
pvogt09
3c6ea2612d
fix #3336 by creating adlist file even if no list was selected by user
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-05-15 17:52:57 +02:00
Dan Schaper
10addc5923
Merge pull request #3218 from JulienOrain/patch-1
...
fix typo
2020-05-14 09:48:59 -07:00
Dan Schaper
9ee37cb503
Merge pull request #3369 from a-p-o/remove-shop-link
...
Remove store/shop link from README
2020-05-14 09:46:21 -07:00
Alex Ordonez
e1b1512183
Remove store/shop link from README
...
According to @dschaper, the store is no longer open:
https://www.reddit.com/r/pihole/comments/cmywyi/pi_hole_store/ew5m33s/
Signed-off-by: Alex Ordonez <me@ordonezalex.com >
2020-05-13 19:24:54 -07:00
Dan Schaper
c76435883b
Merge pull request #3360 from dnicolson/fix-github-capitalisation
...
Fix GitHub capitalisation
2020-05-13 16:56:36 -07:00
Dan Schaper
2ede032de5
Merge pull request #3359 from dnicolson/patch-1
...
Update documentation links
2020-05-13 16:40:51 -07:00
Dave Nicolson
8dc8c350be
Update documentation links
...
Signed-off-by: Dave Nicolson <david.nicolson@gmail.com >
2020-05-13 13:22:09 +02:00
Dave Nicolson
ab753e88a2
Fix GitHub capitalisation
...
Signed-off-by: Dave Nicolson <david.nicolson@gmail.com >
2020-05-13 12:55:00 +02:00
Adam Warner
d524f9a73b
Merge pull request #3353 from MichaIng/patch-1
...
Only check SELinux states if "getenforce" command exists
2020-05-13 00:39:32 +01:00
MichaIng
7d79cf5cce
Only check SELinux states if "getenforce" command exists
...
- Currently, if the SELinux config file exists, installed SELinux is assumed.
- But removing e.g. an APT package via "apt-get remove" leaves config files in place, or they could be present for other reasons.
- If the getenforce command is not present but the config file is, currently the installer exists without error message when calling getenforce due to "set -e".
- With this change, the presence of getenforce command is checked first. If it is not present, selinux-utils is not installed, which is a core part of SELinux, pulled in by selinux-basics as well. So it can be assumed that no SELinux is active if this command is missing.
Signed-off-by: MichaIng <micha@dietpi.com >
2020-05-12 23:45:56 +02:00
Adam Warner
be25b4d9c4
Merge pull request #3352 from pi-hole/merge-master-dev
...
Merge master dev
2020-05-12 22:27:24 +01:00
DL6ER
a1e913de7a
Merge pull request #3327 from pi-hole/new/dark
...
Implement backend support for theming
2020-05-12 23:19:35 +02:00
Adam Warner
9e96ff37de
Fix merge conflicts
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-12 22:16:43 +01:00
DL6ER
a9c66c7b45
Implement pihole -a theme option
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-05-12 23:03:49 +02:00
Matthias Rank
2b9898e9ca
Fixed indentation
...
Signed-off-by: Matthias Rank <development@m-rank.de >
2020-05-12 21:04:30 +02:00
Matthias Rank
0add5eb291
Added support for CNAME record add/remvoe
...
Signed-off-by: Matthias Rank <development@m-rank.de >
2020-05-12 21:02:29 +02:00
Jeroen Baert
4cf241b42b
Fix for pihole -w --nuke displaying help info even if command is executed correctly
...
Signed-off-by: Jeroen Baert <3607063+Forceflow@users.noreply.github.com >
2020-05-12 19:59:19 +02:00
Adam Warner
1b41a5d59a
Merge pull request #3347 from pi-hole/tweak/binary_detection
...
Minor bugfix for Binary detection
2020-05-12 17:31:29 +01:00
Adam Warner
987ae3810d
binary, here, should be l_binary
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-05-11 22:03:33 +01:00
Adam Warner
4d25f69526
Merge pull request #3321 from pi-hole/release/v5.0
...
Pi-hole core v5.0
2020-05-10 19:07:53 +01:00
DL6ER
e728d7f761
Merge pull request #3318 from pi-hole/tweak/default_group
...
Rename default group to ... well ... "Default"
2020-05-07 19:24:04 +02:00
DL6ER
7cc35d3b04
Add update to gravity database version 12, renaming the Unassociated group to Default group.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-05-07 18:01:37 +02:00
DL6ER
78469ee58d
Merge pull request #3255 from pi-hole/tweak/emailregex
...
Enhanced email validation regex
2020-05-06 09:48:26 +02:00
Adam Warner
369288cc48
Update advanced/Scripts/webpage.sh
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com >
2020-05-06 08:40:54 +01:00
Dan Schaper
742d802940
Merge pull request #3027 from XhmikosR/patch-1
...
Serve JS files with utf-8 charset too
2020-05-05 12:29:27 -07:00
DL6ER
fdaf815f42
Merge pull request #3203 from MichaIng/patch-1
...
Failsafe checks for available APT package
2020-05-05 10:27:08 +02:00
DL6ER
988b1ff02f
Merge pull request #3204 from MichaIng/patch-3
...
Revert using hardcoded php-intl meta package
2020-05-05 10:24:56 +02:00
Dan Schaper
df13b9c32a
Merge pull request #3283 from pi-hole/tweak/remove_firewall_config
...
Remove configureFirewall function, the call to it, and related tests
2020-05-02 10:06:31 -07:00
Adam Warner
4710963ccf
Merge pull request #3312 from subdavis/development
...
Remove dead code
2020-05-01 16:43:34 +01:00
Brandon Davis
1540e5bfda
Remove dead code
...
Signed-off-by: Brandon Davis <git@subdavis.com >
2020-05-01 07:52:33 -04:00
Dan Schaper
017d405b28
Merge pull request #3307 from pi-hole/tweak/debugger_type_display
...
Improve debugger database table printing
2020-04-29 11:48:47 -07:00
DL6ER
ddb354f78b
Add enable indentation for the domainlist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-29 06:23:29 +02:00
Dan Schaper
393c7730ec
Merge pull request #3299 from pi-hole/tweak/allow_()_in_urls
...
Allow ( and ) in adlist URLs.
2020-04-28 11:38:08 -07:00
DL6ER
4f0e47e927
Merge pull request #3296 from pi-hole/fix/remove_hostrecord
...
Remove pihole -a hostrecord
2020-04-28 20:06:49 +02:00
DL6ER
f4965d8493
Merge pull request #3135 from pvogt09/development
...
Move permission change behind git reset
2020-04-28 19:44:58 +02:00
DL6ER
c0cf8dba87
Merge pull request #3226 from MichaIng/patch-6
...
Do not add pihole user to web server group
2020-04-28 19:39:55 +02:00
DL6ER
a9136d752a
Merge pull request #3246 from pvogt09/fix/user_exists
...
fixes #3217 by checking for existing pihole group
2020-04-28 19:38:12 +02:00
MichaIng
d7bac21149
Dot not add pihole user to web server group
...
This is and was never required and the pihole user does in fact not get any additional permissions through that group.
Signed-off-by: MichaIng <micha@dietpi.com >
2020-04-26 15:45:29 +02:00
MichaIng
dc6c53b6a3
Revert using hardcoded php-intl meta package
...
Using the meta package causes several issues:
- Install on Debian prior to Jessie and Ubuntu prior to Xenial is broken, since those do not serve the meta packages but php5-* packages instead.
- If $phpVer != "php", then multiple conflicting PHP versions can be installed.
- If "${phpVer}-intl" does not pull the correct package, then inherently "${phpVer}-xml" etc are wrong, too. This is theoretically possible, e.g. if PHP7.4 was installed while the webserver uses a concurrently installed PHP7.3 instance. Then the "php" shell command output can differ from what the webserver uses. This theoretical issue would need a different approach to derive $phpVer, not based on the shell command output but by asking the webserver somehow in the first place. But using $phpVer for some modules and hardcoded meta for the others can only lead to inconsistencies and issues.
Signed-off-by: MichaIng <micha@dietpi.com >
2020-04-26 15:44:13 +02:00
MichaIng
86d4c9b1e0
Failsafe checks for available APT package
...
When checking for available packages in APT repository, running a dry-run install can fail for other reasons, even if the package is available. Currently, in such case, wrong fallback packages are selected: https://github.com/pi-hole/pi-hole/issues/2888
"apt-cache show <pkg>" is a quicker method to check for available packages. This is now done as well to check if the fallbacks are available. If none is found, the installer exits with meaningful error message and exit code.
In rare cases, the APT list files can be missing when the installer is started. E.g. this could be on a fresh system, APT lists could have been moved to RAM or removed as a cleanup step. "apt-cache" calls will then fail, same as dry-run installs were. To assure that current package lists are checked, update the package cache directly after the Ubuntu universe repo has been added, only in the Debian/Ubuntu block. This renders the variable handling in RH/Fedora block obsolete.
Signed-off-by: MichaIng <micha@dietpi.com >
2020-04-26 15:42:43 +02:00
DL6ER
288d487fc0
Allow ( and ) in adlist URLs.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-26 09:33:09 +02:00
pvogt09
462457fe7f
Merge branch 'development' into development
2020-04-24 12:09:49 +02:00
DL6ER
20ef5e0264
Show associated group IDs in domains/clients/adlists listing. We get the data through a LEFT JOIN followed by a GROUPing by the left list ID and finialized through a GROUP_CONCATenation.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-24 10:33:46 +02:00
DL6ER
ad5802715e
enabled field: Center 0, right-align 1
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-23 15:16:48 +02:00
DL6ER
989bbad37e
Remove pihole -a hostrecord
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-23 13:20:15 +02:00
DL6ER
63f6c6a894
Add indentation for enabled and type fields
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-23 10:01:22 +02:00
Adam Warner
d42785a3bf
Merge pull request #3271 from pi-hole/tweak/version
...
Add branch name to pihole -v
2020-04-21 16:07:27 +01:00
DL6ER
401c029dc4
Improve else condition of branch determination
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-21 16:08:32 +02:00
DL6ER
ed9d74593d
Merge pull request #3289 from pi-hole/tweak/boldify_uniques
...
Gravity: Boldify number of unique domains
2020-04-21 10:18:23 +02:00
Adam Warner
9286965ee2
Merge pull request #3287 from pi-hole/tweak/remove-deprecated-list
...
Remove Deprecated cameleon list
2020-04-21 08:32:24 +01:00
DL6ER
fa57c457f3
Boldify number of unique domains as this is the actually interesting number
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-21 09:10:21 +02:00
DL6ER
0343171703
Add correct displaying for detached HEAD state.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-21 08:54:28 +02:00
DL6ER
176fbaf83b
Ask pihole-FTL for the branch it was compiled from instead of trusting the checkout file to be present.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-21 08:51:17 +02:00
Adam Warner
94a4f844a8
Remove deprecated list
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-20 21:31:20 +01:00
Adam Warner
d18a8b1b8a
Merge pull request #3205 from MichaIng/patch-5
...
Reduce apt-get install verbosity
2020-04-19 15:28:48 +01:00
Adam Warner
a37dba2c81
remove configureFirewall function, the call to it, and related tests
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-19 14:52:01 +01:00
Adam Warner
471006676c
Merge pull request #3227 from pi-hole/new/CLI_domain_comments
...
Add option --comment "whatever" for adding comments for new domains through the CLI interface.
2020-04-19 14:39:05 +01:00
Adam Warner
0155d42650
Merge pull request #3252 from yubiuser/patch-1
...
add [options] for 'pihole restart' to manpage and cli help output
2020-04-19 14:35:24 +01:00
Adam Warner
e80990c27a
Merge pull request #3282 from pi-hole/revert-3276-feature/support_for_new_cloudflare_dns_for_families
...
Revert "- Support for Cloudflare's new DNS for Families"
2020-04-19 14:32:32 +01:00
Adam Warner
e6dcccc7bd
Revert "- Added 2 new DNS entries for the new Cloudflare DNS for families, which comes in 2 flavors ( #3276 )"
...
This reverts commit 7e1a8c1ceb .
2020-04-18 20:05:54 +01:00
Adam Warner
3cc9ba4ee8
stickler Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2020-04-18 12:57:06 +01:00
Adam Warner
6dc85c3527
Don't display branch name if it is on master.
...
Prefer cached remote version over github API
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-18 12:51:04 +01:00
Mohammed Swillam
7e1a8c1ceb
- Added 2 new DNS entries for the new Cloudflare DNS for families, which comes in 2 flavors ( #3276 )
...
1- 1.1.1.2 (No Malware)
2- 1.1.1.3 (No Malware or Adult Content)
This would allow parents to have more control over the safety of their family's network.
Signed-off-by: Mohammed-Swillam <moh.sayed@hotmail.com >
2020-04-18 11:49:01 +01:00
Dan Schaper
4f01daf5bc
Merge pull request #3244 from atenart/remove-hosts-file-ads-list
...
basic_install: remove remaining references to hosts-file.net
2020-04-16 13:33:34 -07:00
Dan Schaper
0f20470a38
Merge pull request #3269 from pi-hole/tweak/hosts-comments
...
Add support for comments in HOSTS-like files
2020-04-15 11:11:10 -07:00
Adam Warner
851947bbf2
Add branch name to version output
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-13 20:58:46 +01:00
Dan Schaper
413fa94e98
Merge pull request #3263 from mschoettle/fix/broken-blocking-landing-page-v5.0
...
Fixes broken blocking page and landing page when changing server port or host name (v5.0)
2020-04-10 20:50:26 -07:00
Matthias Schoettle
308eb5eda5
Fixes broken blocking page and landing page when changing server port and/or hostname.
...
See issues #2195 and #2720 .
Signed-off-by: Matthias Schoettle <git@mattsch.com >
2020-04-10 12:29:01 -04:00
DL6ER
093054a1eb
Automatically convert legacy IP range to Class C network
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-09 09:49:07 +02:00
DL6ER
4130af0aab
Retain rev-server settings when the feature gets disabled.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-09 09:05:50 +02:00
DL6ER
90a5a13197
Convert CONDITIONAL_FORWARDING to REV_SERVER settings. Try to detect intended CIDR range automatically.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-08 15:35:35 +02:00
DL6ER
1632632668
Merge pull request #3259 from pi-hole/update_devel
...
Update development from release/v5.0
2020-04-08 12:28:29 +02:00
DL6ER
982c1b0059
Merge branch 'release/v5.0' into development
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-08 12:02:53 +02:00
Adam Warner
26f71e4dbe
accidentally a space
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-05 12:34:14 +01:00
Adam Warner
b6ac1585ec
add regex attribution
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-05 12:29:45 +01:00
Adam Warner
a9b19df4ec
expand email validation regex to catch more valid emails see comments on PR #3254
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-04-05 12:28:33 +01:00
yubiuser
d27a565d39
Apply suggestions from code review
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-04-05 11:46:41 +02:00
M4x
2de5362adc
Sanitize email address in case of security issues ( #3254 )
...
* Sanitize email address in case of security issues
Signed-off-by: bash-c <aboultraman@gmail.com >
2020-04-05 10:20:35 +01:00
Christian König
de42669bb7
fix typo in pihole help
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-04-05 08:56:10 +02:00
Christian König
3095fd4dd6
add restart [options] to cli help
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-04-05 08:49:35 +02:00
yubiuser
ebbb7168a4
add [options] for pihole restartdns
...
Signed-off-by: Christian König <ckoenig@posteo.de >
2020-04-04 22:47:14 +02:00
pvogt09
40ac3e7eb7
remove pihole group during uninstall
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-04-04 19:22:37 +02:00
pvogt09
25c5661c1b
fix stickler errors
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-04-03 19:22:30 +02:00
pvogt09
a993b8b34d
fixes #3217 by checking for existing pihole group
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-04-03 13:18:32 +02:00
Antoine Tenart
16f664cdb4
basic_install: remove remaining references to hosts-file.net
...
Commit dc35709a1b ("Remove hosts-file.net from default lists") left a
few references to hosts-file.net. Removes them.
Signed-off-by: Antoine Tenart <antoine.tenart@ack.tf >
2020-04-02 21:23:55 +02:00
DL6ER
a2d2639ee8
Merge pull request #3242 from pi-hole/fix/do_not_flush_neigh_cache
...
Do not flush neigh cache
2020-04-01 20:50:28 +02:00
DL6ER
d1caad76d8
Do not flush neigh cache as this is known to create a number of issues. The better aproach to this is to manually flush the ARP cache by either restarting or calling "ip neigh flush all".
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-04-01 17:19:32 +00:00
DL6ER
fff7adfb20
Merge pull request #3236 from pi-hole/PromoFaux-patch-1
...
Remove hosts-file.net from default lists
2020-03-31 23:23:19 +02:00
Adam Warner
7d19ee1b25
validate blocklist URL before adding to the database ( #3237 )
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Co-authored-by: DL6ER <dl6er@dl6er.de >
2020-03-31 21:48:10 +01:00
DL6ER
7b15a88dc4
Strip comments from downloaded lists instead of discarding lines with comments altogether
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-03-31 18:36:40 +00:00
Adam Warner
dc35709a1b
Remove hosts-file.net from default lists
2020-03-31 17:39:21 +01:00
DL6ER
0fad979206
Merge pull request #3230 from pi-hole/fix/remove-19036
...
Remove 19036 trust anchor
2020-03-27 19:57:41 +01:00
DL6ER
277179f150
Remove 19036 trust anchor, now expired: https://www.icann.org/resources/pages/ksk-rollover
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-03-27 19:34:41 +01:00
DL6ER
15a9d662ac
Add option --comment "whatever" for adding comments for new domains through the CLI interface.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-03-27 08:45:04 +01:00
Adam Warner
1b35eebad8
Merge pull request #3207 from pi-hole/tweak/resolvconf
...
Remove resolvconf dependency
2020-03-24 13:11:22 +00:00
Julien Orain
6d4844a0b3
docs(typo): fix typo
...
Signed-off-by: Julien Orain <julien.orain@gmail.com >
2020-03-18 21:41:54 +01:00
Adam Warner
4994da5170
Update automated install/basic-install.sh
2020-03-12 18:48:40 +00:00
Adam Warner
175d32c5f6
Set nameservers to be that which have been chosen by the user in the whiptail
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-03-11 18:55:43 +00:00
Adam Warner
1481cc583f
Don't set nameserver in dhcpcd.conf
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-03-11 18:48:40 +00:00
Adam Warner
dbc54b3063
remove resolvconf dep
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-03-11 18:47:59 +00:00
MichaIng
bb936f4fdb
Reduce apt-get install verbosity
...
The new version of the installer moved from debconf-apt-progress to raw apt-get output on installs to solve issues with interactive config file choices. This lead to a largely increases amount of output lines of the installer. To reduce the apt-get output to a minimum, while sustaining interactive input in case of config files, the "-qq" option can be used, which inherits "--yes":
- https://manpages.debian.org/buster/apt/apt-get.8.en.html#OPTIONS
- https://manpages.ubuntu.com/manpages/bionic/man8/apt-get.8.html#options
Signed-off-by: MichaIng <micha@dietpi.com >
2020-03-11 11:01:28 +01:00
XhmikosR
7b8611ced0
Assorted typo fixes. ( #3126 )
...
* Assorted typo fixes.
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-03-08 16:53:14 -07:00
DL6ER
497bfd80a5
Update development from release/v5.0 ( #3200 )
...
* Use bash regex instead of awk.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* Fix incorrect type description. (#3201 )
Signed-off-by: DL6ER <dl6er@dl6er.de >
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-03-08 16:38:53 -07:00
DL6ER
22ce5c0d70
Fix incorrect type description. ( #3201 )
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-03-08 16:32:37 -07:00
jnozsc
4a711340ef
use py3 instead py2 ( #3153 )
...
* use py3 instead py2
Signed-off-by: jnozsc <jnozsc@gmail.com >
* use python 3.6
Signed-off-by: jnozsc <jnozsc@gmail.com >
2020-03-02 23:30:44 -08:00
Dan Schaper
f617ed2f44
Merge pull request #3186 from pi-hole/fix/awkInQuery
...
Malformed wildcard blocking doesn't crash awk.
2020-03-02 12:39:26 -08:00
Dan Schaper
bf4fada3b7
Don't quote inside backticks, use unquoted variable.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-03-02 09:52:06 -08:00
Dan Schaper
360d0e4e6b
Loop through array of lists.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-03-02 08:07:10 -08:00
Dan Schaper
4f390ce801
Use bash regex instead of awk.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-03-02 05:39:21 -08:00
Adam Warner
027b97cbfa
Merge pull request #3185 from msamendinger/removewget
...
Remove wget from PIHOLE_DEPS
2020-03-01 21:15:32 +00:00
msamendinger
d16b472592
Remove wget from PIHOLE_DEPS
...
All external calls have been moved to curl, wget no longer needed as
dependency
Signed-off-by: msamendinger <git@samendinger.de >
2020-03-01 22:06:37 +01:00
James Lagermann
6e67124770
Merge branch 'development' of https://github.com/pi-hole/pi-hole
2020-02-28 17:16:44 -06:00
Adam Warner
e6bfb0fe17
Merge pull request #3152 from pi-hole/release/v5.0
...
Update development with latest release/v5.0 changes
2020-02-28 22:50:15 +00:00
Adam Warner
dc8ae4f0ab
Merge pull request #3127 from pi-hole/fix/removeFunding
...
Delete FUNDING.yml
2020-02-28 22:47:20 +00:00
Adam Warner
d2a8b4d2b9
Merge pull request #3180 from pi-hole/release/v4.4
...
Tidying up
2020-02-28 22:34:41 +00:00
Adam Warner
c07d86b9f9
Merge branch 'release/v5.0' into release/v4.4
2020-02-28 22:24:11 +00:00
Adam Warner
9e490775ff
Merge pull request #3166 from pi-hole/release/v4.4
...
Add use-application-dns.net = NXDOMAIN in ProcessDNSSettings rather t…
2020-02-25 20:59:35 +00:00
Adam Warner
58785020bd
Merge pull request #3161 from pi-hole/cherry-pick-4.3.5
...
cherry pick 4.3.5 into 5.0
2020-02-25 20:42:39 +00:00
DL6ER
1c74b41869
Add use-application-dns.net = NXDOMAIN in ProcessDNSSettings rather than in the template so we can ensure that it will survive config-renewals.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-25 20:41:35 +00:00
Adam Warner
6104d81622
Safeguard against colour output in grep commandadd -i to grep to make search for "Location" case-insensitive
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-24 20:36:45 +00:00
Adam Warner
121c93e822
Merge pull request #3160 from pi-hole/release/v4.3.5
...
Hotfix 4.3.5
2020-02-24 20:16:54 +00:00
Adam Warner
b4c2bf678f
Safeguard against colour output in grep commandadd -i to grep to make search for "Location" case-insensitive
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-24 20:02:48 +00:00
Adam Warner
14944b0283
Merge pull request #3157 from pi-hole/release/v4.3.4
...
Release v4.3.4
2020-02-24 18:48:03 +00:00
Adam Warner
8ecaaba247
Compare daemons to expected results. ( #3158 ) ( #3159 )
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
Co-authored-by: Dan Schaper <dan@glacialmagma.com >
2020-02-24 18:00:19 +00:00
Dan Schaper
0fbcc6d8b5
Compare daemons to expected results. ( #3158 )
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-02-24 17:38:37 +00:00
Adam Warner
707e21b927
:dominik: Detect binary name before calling FTLcheckUpdate in update.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-24 12:10:36 +00:00
DL6ER
f4a1cc6dec
Merge pull request #3150 from pi-hole/tweak/database_warnings_inspection
...
Gravity: Check suitablility of sourced lists
2020-02-24 10:18:00 +01:00
DL6ER
3dd05606ca
Call it the received number of domains instead of the imported number as importing does only happen a bit later. Only show the number of invalid domains if there are invalid domains.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-24 07:06:15 +01:00
DL6ER
1e8bfd33f5
Improve output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-23 22:50:06 +01:00
Adam Warner
545b6605bc
4.3.3 ( #3154 )
...
* Backport ee7090b8fc to v4 to prevent failures in FTL download
* update tests to reflect changes to FTL download URL
* backport `tbd` fix
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-23 21:34:12 +00:00
DL6ER
8131b5961c
Add comments to the code describing the changes.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-22 15:22:29 +01:00
DL6ER
81d4531e10
Implement performant list checking routine.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-22 13:01:55 +01:00
DL6ER
050e2963c7
Remove redundant code.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-21 22:28:53 +01:00
DL6ER
3c09cd4a3a
Experimental output of matching line from shown warnings.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-21 21:47:56 +01:00
DL6ER
839fe32042
Fix issue with missing newline at the end of adlists ( #3144 )
...
* Also display non-fatal warnings during the database importing. Previously, we have only show warnings when there were also errors (errors are always fatal).
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Ensure there is always a newline on the last line.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Stickler linting
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* Move sed command into subroutine to avoid code duplication.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Also unify comments.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Also unify comments.
Signed-off-by: DL6ER <dl6er@dl6er.de >
Co-authored-by: Dan Schaper <dan@glacialmagma.com >
2020-02-21 18:56:48 +00:00
Adam Warner
85c15a7167
Merge pull request #3147 from pi-hole/tweak/forcelocalversions
...
force `updatchecker.sh` run if any of the three components are updated
2020-02-20 18:57:56 +00:00
DL6ER
b73580fa93
Merge pull request #3132 from pi-hole/fix/pihole-tail
...
Fix pihole -t sed instructions
2020-02-19 19:07:38 +01:00
Adam Warner
4a5f344b09
then
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-19 17:46:45 +00:00
Adam Warner
af95e8c250
force updatchecker.sh run if any of the three components are updated
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-19 17:41:53 +00:00
Adam Warner
ee7090b8fc
Merge pull request #3140 from pi-hole/tweak/whocaresaboutthelatesttaganyway
...
No need to determine the latest tag, we can just go direct.
2020-02-17 21:39:48 +00:00
Adam Warner
7be019ff52
No need to determine the latest tag, we can just go direct
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-17 21:29:25 +00:00
DL6ER
d14ee26d6a
Merge pull request #3139 from pi-hole/fix/count_before_calling_FTL
...
Fix wrong number of blocking domains shown on the dashboard
2020-02-17 21:32:45 +01:00
DL6ER
52398052e9
Compute number of domains (and store it in the database) BEFORE calling FTL to re-read said value.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-17 21:07:48 +01:00
DL6ER
ddbd57f459
Merge pull request #3131 from pi-hole/tweak/debugger_performance
...
Tweaks and fixes for the debugger
2020-02-17 06:23:20 +01:00
DL6ER
601f9048cd
Merge pull request #3130 from pi-hole/fix/gravity_updated_timestamp
...
Store gravity update timestamp only after database swapping
2020-02-17 06:07:05 +01:00
Dan Schaper
c5c414a7a2
Stickler Lint - quote to prevent splitting
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2020-02-16 19:24:05 -08:00
Dan Schaper
bc91be6c08
Merge branch 'tweak/debugger_performance' of https://github.com/pi-hole/pi-hole into tweak/debugger_performance
2020-02-16 17:44:16 -08:00
DL6ER
d0e29ab7b0
Add human-readable output of time of the last gravity run.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-16 17:43:54 -08:00
DL6ER
714a79ffce
Migrate debugger to domainlist and add printing of client table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-16 17:43:54 -08:00
DL6ER
cd3ad0bdc7
Show info table instead of counting domains to speed up the debugging process on low-end hardware drastically.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-16 17:43:54 -08:00
DL6ER
a8db753493
Merge pull request #3138 from pi-hole/fix/php-intl
...
Install php-intl meta package.
2020-02-16 21:51:14 +01:00
DL6ER
75633f0950
Install php-intl and trust the system to install the right extension. We've seen reports that just installing php5-intl or php7-intl isn't sufficient and that we need the meta package as well.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-16 21:24:32 +01:00
Adam Warner
082cfb2f1c
Merge pull request #3137 from pi-hole/tweak/apilatest
...
Change to use API instead of the Location Header
2020-02-16 12:19:31 +00:00
Adam Warner
1072078e26
Change to use API instead of the Location Header
...
(some trailing whitespace removed)
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2020-02-16 11:47:42 +00:00
pvogt09
b0f1333657
Move permission change behind git reset (like in update_repo()) and remove whitespace at end of line
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2020-02-14 20:43:36 +01:00
DL6ER
f10a151469
Fix pihole -t sed instructions.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-12 21:05:02 +01:00
DL6ER
eadd82761c
Add human-readable output of time of the last gravity run.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-12 19:51:40 +01:00
DL6ER
00f4393f48
Merge branch 'release/v5.0' into tweak/debugger_performance
2020-02-12 19:44:56 +01:00
DL6ER
50f6fffbdc
Migrate debugger to domainlist and add printing of client table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-12 19:43:55 +01:00
DL6ER
baf5340dc0
Show info table instead of counting domains to speed up the debugging process on low-end hardware drastically.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-12 19:39:12 +01:00
DL6ER
e528903488
Merge pull request #3107 from pi-hole/new/client_comments
...
Add timestamps and comment fields to clients table
2020-02-12 19:35:01 +01:00
DL6ER
dc2fce8e1d
Store gravity update timestamp only after database swapping.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-12 19:26:25 +01:00
Dan Schaper
c4005c4a31
Delete FUNDING.yml
...
Organization-wide FUNDING now set up.
2020-02-11 09:56:28 -08:00
Adam Warner
0a70bbd255
Merge pull request #3120 from canihavesomecoffee/patch-1
...
Update Cameleon blacklist url to use https
2020-02-08 17:25:49 +00:00
Willem
c91d9cc0b6
Update Cameleon blacklist url to use https
...
Switches from http to https for the Cameleon (sysctl.org) blacklist.
Signed-off-by: canihavesomecoffee <canihavesomecoffee@users.noreply.github.com >
2020-02-08 17:06:03 +01:00
DL6ER
8e10c22356
Merge pull request #3106 from pi-hole/fix/group_assignments
...
DROP and reCREATE TRIGGERs during gravity swapping.
2020-02-07 17:40:34 +01:00
DL6ER
37a44c0773
Merge pull request #3115 from pi-hole/tweak/gravity_count
...
Store number of distinct gravity domains in database after counting
2020-02-05 23:25:36 +01:00
DL6ER
2a5cf221fa
Store number of distinct gravity domains in database after counting.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-02-02 23:46:33 +01:00
DL6ER
92aa510bda
Add timestamps and comment fields to clients. This updates the gravity database to version 11.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-27 10:36:16 +00:00
DL6ER
6b04997fc3
DROP and reCREATE TRIGGERs during gravity swapping.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-27 10:12:05 +00:00
Dan Schaper
e0b3405a4d
Merge pull request #3098 from pi-hole/fix/pihole-t
...
Update blocked strings for pihole -t
2020-01-25 12:27:20 -08:00
DL6ER
10c2dad48a
Improve gravity performance ( #3100 )
...
* Gravity performance improvements.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Do not move downloaded lists into migration_backup directory.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Do not (strictly) sort domains. Random-leaf access is faster than always-last-leaf access (on average).
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Append instead of overwrite gravity_new collection list.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Rename table gravity_new to gravity_temp to clarify that this is only an intermediate table.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Add timers for each of the calls to compute intense parts. They are to be removed before this finally hits the release/v5.0 branch.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Fix legacy list files import. It currently doesn't work when the gravity database has already been updated to using the single domainlist table.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Simplify database_table_from_file(), remove all to this function for gravity lost downloads.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Update gravity.db.sql to version 10 to have newle created databases already reflect the most recent state.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Create second gravity database and swap them on success. This has a number of advantages such as instantaneous gravity updates (as seen from FTL) and always available gravity blocking. Furthermore, this saves disk space as the old database is removed on completion.
* Add timing output for the database swapping SQLite3 call.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Explicitly generate index as a separate process.
Signed-off-by: DL6ER <dl6er@dl6er.de >
* Remove time measurements.
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-24 09:39:13 -08:00
Dan Schaper
52e2a2610e
Merge pull request #3089 from pi-hole/tweak/gravity_db_10
...
Add gravity database 9->10 update script
2020-01-24 09:23:34 -08:00
DL6ER
a809624356
Update blocked strings for pihole -t.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-23 19:19:44 +01:00
DL6ER
29f06a4444
Merge pull request #3090 from pi-hole/tweak/debug_group_humanreadable_timestamps
...
Print human-readable timestamps in the debugger's gravity output
2020-01-20 20:20:51 +01:00
DL6ER
3f9e79f152
Print human-readable timestamps in the debugger's gravity output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-20 20:13:44 +01:00
DL6ER
633e56e8a9
Add gravity database 9->10 update script.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-20 17:59:24 +01:00
DL6ER
bf01f725f7
Merge pull request #3087 from pi-hole/fix/blocking_page
...
Remove dead code causing failure from the blocking page
2020-01-19 21:50:41 +01:00
DL6ER
276b191845
Remove dead code causing failure from the blocking page.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-19 21:39:49 +01:00
DL6ER
c7bc58e94b
Merge pull request #3082 from pi-hole/tweak/gravity_database_locked
...
Add timeout to gravity database writing
2020-01-14 20:55:12 +01:00
DL6ER
8f22203d24
Wait 30 seconds for obtaining a database lock instead of immediately failing if the database is busy.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-14 20:02:00 +01:00
DL6ER
782fec841e
Merge pull request #3076 from pi-hole/new/intl_domains
...
Add package php-intl for AdminLTE#1130
2020-01-13 17:19:49 +01:00
DL6ER
cfa909a93d
Add package php-intl for AdminLTE#1130.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2020-01-12 14:09:14 +01:00
Adam Warner
e0fde41d87
Merge pull request #3066 from pi-hole/centos8_support
...
Update installer to support CentOS 8
2020-01-05 14:39:24 +00:00
Adam Warner
574f7c1a1f
Merge pull request #2962 from bcambl/remove_debconf-apt-progress
...
Remove debconf apt progress
2020-01-04 16:04:50 +00:00
bcambl
ec8f4050d0
Update installer to support CentOS 8
...
PHP dependency php-json is now required for both the latest Fedora and CentOS.
Package php-json will now be a default web dependency and removed from PIHOLE_WEB_DEPS when installing on CentOS7.
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-01-02 06:52:23 -06:00
bcambl
60c51886e0
remove unused debian deps (apt-utils debconf)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-01-01 13:24:02 -06:00
bcambl
cbb1461010
add stdout horizontal rule to install_dependent_packages()
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-01-01 13:23:31 -06:00
bcambl
07cc5b501c
replace debconf-apt-progress with apt-get in install_dependent_packages()
...
Removes the need for conditional debconf-apt-progress dependency checking
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-01-01 13:11:41 -06:00
bcambl
ebb1a730c1
remove unused fedora/centos dependency: dialog
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2020-01-01 13:11:41 -06:00
MichaIng
9dff55b212
Installer | Remove "dialog" from Debian/Ubuntu installer deps
...
+ The installer uses `whiptail`, thus `dialog` is not required.
Signed-off-by: MichaIng <micha@dietpi.com >
2020-01-01 13:11:41 -06:00
DL6ER
8ae03b64d7
Merge pull request #3060 from pi-hole/propsed_8_to_9
...
Add a new migration script to fix the previous one
2019-12-30 11:58:57 +01:00
DL6ER
bb30c818ab
Update database version during migration.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-30 09:21:30 +00:00
Adam Warner
c944f6a320
Add a new migration script to fix the previous one
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-12-29 23:32:31 +00:00
DL6ER
62ec7de963
Merge pull request #3058 from pi-hole/tweak/7_to_8
...
Don't create trigger with duplicate name until after old table is del…
2019-12-29 23:05:46 +01:00
Adam Warner
aa4c0ff329
Don't create trigger with duplicate name until after old table is deleted
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-12-29 20:35:11 +00:00
DL6ER
37217ece73
Merge pull request #3049 from pi-hole/tweak/unique_group_name
...
Group table enhancements
2019-12-28 14:19:04 +01:00
DL6ER
28d4f4b142
Merge pull request #3045 from pi-hole/tweak/gravity.db_permissions
...
Set permissions and ownership of gravity.db on pihole -g
2019-12-28 14:17:50 +01:00
DL6ER
8d5d423adb
Merge pull request #3052 from pi-hole/revert/76460f0
...
Revert "Change the regex used for domain validation"
2019-12-21 13:16:12 +01:00
DL6ER
cda0133dd1
Revert "Change the regex used for domain validation"
...
This reverts commit 76460f01e9 .
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-21 11:15:18 +00:00
DL6ER
eda7f40fef
Reinstall trigger that prevents group zero from being deleted.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-20 00:42:59 +00:00
DL6ER
e589e665a7
Also add date_added and date_modified fields to group table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-20 00:21:25 +00:00
DL6ER
b32b5ad6e9
Update gravity database to version 8. This enforces uniqueness on the group name.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-20 00:09:10 +00:00
DL6ER
e2de199f47
Merge pull request #3037 from pi-hole/new/group_zero
...
Add special group zero to gravity database
2019-12-18 22:36:43 +01:00
DL6ER
948f4a8827
Ensure permissions and ownership of gravity.db are correctly set on each run of pihole -g. This would have prevented https://github.com/pi-hole/AdminLTE/issues/1077
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-16 09:55:46 +00:00
DL6ER
a1633123aa
Merge pull request #3035 from pi-hole/fix/query_gravity
...
pihole -q should also scan gravity table
2019-12-16 01:45:10 +01:00
DL6ER
2444296348
Again, Mr. Stickler
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-15 11:55:19 +00:00
DL6ER
4be7ebe61f
Scan domainlist instead of view to also catch disabled domains.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-15 11:47:53 +00:00
DL6ER
a720fe1789
Add client trigger.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 22:49:21 +00:00
DL6ER
2cec9eaf65
Merge pull request #3033 from pi-hole/fix/duplicates_in_adlists
...
Remove duplicates from adlists before importing
2019-12-12 21:37:26 +01:00
DL6ER
313f999af4
Merge pull request #3034 from pi-hole/tweak/gravity_url_displaying
...
Show full URL during gravity download
2019-12-12 21:37:20 +01:00
DL6ER
0b0ec43bf5
Merge pull request #3036 from pi-hole/fix/reload-lists
...
Improve list reloading
2019-12-12 21:37:09 +01:00
DL6ER
f0439c8d12
Add special group zero to gravity database.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 16:39:02 +00:00
DL6ER
40e8657137
Please Mr. Stickler
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 11:18:46 +00:00
DL6ER
52dd72dfa5
Ensure output is always correct and also display if domain has been found but is disabled
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 11:08:19 +00:00
DL6ER
922ce7359c
pihole -q should also scan gravity table
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 10:58:41 +00:00
DL6ER
779fe670f7
Show full URL during gravity download instead of only domain and file
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 10:29:44 +00:00
DL6ER
570a7a5c11
Use sort -u instead of uniq as it is guaranteed to be safe when doing inline file operations.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 10:17:59 +00:00
DL6ER
bd1b004d94
Remove possible duplicates found in lower-quality adlists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-12 10:13:51 +00:00
DL6ER
5457b2c6ea
Merge pull request #2935 from pi-hole/new/internal-blocking
...
Per-client blocking changes
2019-12-12 09:49:02 +01:00
Adam Warner
02f3316710
Merge pull request #3031 from pi-hole/fix/do_not_force_local_resolver
...
Do not force nameserver 127.0.0.1 through resolvconf
2019-12-11 22:11:44 +00:00
DL6ER
69a909fc4c
On modification of lists, we should send real-time signal 0 instead of SIGHUP. This also preserves the DNS cache of not-blocked domains.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-11 21:47:46 +00:00
Adam Warner
ec09b5843c
Merge branch 'development' into fix/do_not_force_local_resolver
2019-12-11 19:09:02 +00:00
Adam Warner
078e7e1686
Merge pull request #3030 from pi-hole/fix/database-service-script
...
Ensure database permissions are set up correctly by the service script
2019-12-11 19:07:29 +00:00
Adam Warner
d29947ba32
optimise gravity list inserts
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-12-09 22:30:41 +00:00
Adam Warner
1f03faddef
shell check recomends
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-12-09 21:35:54 +00:00
Adam Warner
d1bce7e685
Merge pull request #2995 from pi-hole/tweak/NoFurtherThanLatestTag
...
Don't allow repo to go further than latest tag on master
2019-12-09 20:41:29 +00:00
Dan Schaper
880352ea65
Merge pull request #3013 from Jason-Cooke/patch-2
...
docs: fix typo
2019-12-09 10:59:04 -08:00
DL6ER
3231e5c3ba
Address stickler requests.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-09 16:52:03 +00:00
DL6ER
f482156cca
Merge branch 'development' into new/internal-blocking
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-09 16:49:16 +00:00
DL6ER
620e1e9c73
Do not force nameserver 127.0.0.1 through resolvconf in pihole-FTL.service
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-09 12:23:42 +00:00
DL6ER
8a119d72e2
Ensure database permissions are set up correctly by the service script.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-09 12:17:55 +00:00
DL6ER
807a5cfb23
Merge pull request #3015 from pi-hole/tweak/domainlist_table
...
Unite four domain tables into a single domainlist table.
2019-12-08 16:50:22 +01:00
XhmikosR
54d0b9a1b8
Serve JS files with utf-8 charset too
...
Signed-off-by: XhmikosR <xhmikosr@gmail.com >
2019-12-07 13:48:25 +02:00
Adam Warner
ca7a5bc0fe
Merge pull request #3024 from pi-hole/fix/3003
...
Get binary name in update.sh
2019-12-04 21:23:13 +00:00
DL6ER
0c5185f8ba
Also display how many unique domains we have caught in the event horizon.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-04 21:02:46 +00:00
Adam Warner
eaf1244932
:dominik: Detect binary name before calling FTLcheckUpdate in update.sh
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-12-04 20:10:46 +00:00
Adam Warner
7c2bbf840a
Merge pull request #2993 from MichaIng/patch-3
...
Minor installer output enhancements
2019-12-04 18:53:58 +00:00
MichaIng
85673b8273
Print name of chosen upstream DNS as well
...
Signed-off-by: MichaIng <micha@dietpi.com >
2019-12-04 18:59:25 +01:00
DL6ER
b6cd7b8e3d
Use more descriptive names instead of directly using the IDs in list.sh
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-12-02 17:27:32 +00:00
Adam Warner
869473172c
remove _ from regex descibers
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-12-01 12:50:24 +00:00
Adam Warner
63e407cfdc
Update advanced/Scripts/list.sh
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
2019-12-01 12:45:22 +00:00
Adam Warner
0251117c77
Update advanced/Scripts/list.sh
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
2019-12-01 12:45:06 +00:00
Adam Warner
44e1455b12
Update advanced/Scripts/list.sh
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
2019-12-01 12:44:48 +00:00
Adam Warner
76460f01e9
Change the regex used for domain validation
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-30 17:45:07 +00:00
Adam Warner
4b8a72fda7
functionise parameter discovery
...
Rename HandleOther to ValidateDomain
Capital letters on the new functions
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-30 16:26:26 +00:00
Adam Warner
edaee4e962
remove redundant function and comments
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-30 16:02:50 +00:00
Adam Warner
77bfb3fb67
tidy up variable usage in list.sh Remove some that are redundant
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-30 14:18:12 +00:00
Adam Warner
6a881545b0
tweak wording Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2019-11-30 13:25:32 +00:00
Adam Warner
d0de5fda30
Simplify removal of domain from one list when it is requested for another
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-30 13:13:26 +00:00
DL6ER
a1f120b2ff
Address stickler's complaint
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-11-30 12:43:07 +00:00
DL6ER
185319d560
Unite four domain tables into a single domainlist table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-11-30 12:33:51 +00:00
DL6ER
5c6dd3f6f4
Merge pull request #2978 from Mograine/patch-1
...
Add commands to add/remove custom DNS records
2019-11-29 13:25:09 +01:00
Jason Cooke
8e5abc1f15
docs: fix typo
2019-11-29 13:46:05 +13:00
Adam Warner
9248c92b5c
Merge pull request #2984 from diginc/development
...
Adding docker+arm detection & FTL download
2019-11-27 21:25:41 +00:00
Adam Warner
583ea4d17a
Merge branch 'development' into development
2019-11-27 21:17:05 +00:00
Adam Warner
edcdf9f619
Merge pull request #3003 from pi-hole/fix/tbd
...
FTL always determined.
2019-11-27 09:46:17 +00:00
Mograine
c809c34024
Add user feedback
...
Signed-off-by: Mograine <ghiot.pierre@gmail.com >
2019-11-27 00:28:44 +01:00
DL6ER
037d52104a
New command "pihole -g -r" recreates gravity.db based on files backed up in /etc/pihole/migration_update. This is useful to restore a working version of the database when the user destroyed the original database. Also, update gravity.db to version 5 because of a fix we needed to implement.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-11-26 10:58:39 +01:00
Adam Warner
1fb70c977c
Merge pull request #3002 from pi-hole/tweak/output-format
...
add a double space to the beginning of some outputs
2019-11-25 19:41:58 +00:00
Adam Warner
eeb26e3975
Merge pull request #2990 from chrunchyjesus/unix-compliance
...
make some shebangs comply to posix standard
2019-11-16 12:26:49 +00:00
Adam Warner
12817c09bb
(Squashed commits)
...
Always ensure we have the correct machine arch by storing to/reading from a file rather than depending on global variable that for some reason is not always populated...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
no need for global variable
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Use a file in the temporary FTL download directory
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
Local binary variable named to l_binary. Disambiguate from global binary.
Allow 'binary' to be shadowed for testing.
Use ./ftlbinary in all operations.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
Revert shadow ability on binary variable.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
Remove unused tests, binary variable can not be overridden.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
This should work here, too
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
binary name is passed through from pihole checkout
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Add comments
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
OK, let's try it this way again
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
we might be getting somewhere.. squash after this I think!
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
This is a test to see if it fixes the aarch64 test (we are definitely squashing these commits
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
fix the rest of the tests
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
Remove trailing whitespace in the files we've touched here
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-15 19:49:09 +00:00
Adam Warner
4840bdb031
add a double space to the beginning of some outputs
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-14 19:06:23 +00:00
Adam Warner
a85e7a2a43
Merge pull request #2999 from pi-hole:fix/api_utf8_encoding
...
Add php-xml package as new dependency
2019-11-13 19:03:53 +00:00
Mograine
b93628acb3
Merge branch 'development' of https://github.com/Mograine/pi-hole into patch-1
2019-11-13 09:44:48 +01:00
DL6ER
7f7b9d089c
Merge pull request #2965 from pi-hole/tweak/BackendChangesForAdlistComments
...
backend changes to allow comment when adding new adlist
2019-11-12 21:50:19 +01:00
DL6ER
61d233f069
Merge pull request #2964 from bcambl/selinux_enforcing
...
Exit installation when SELinux in unsupported state
2019-11-12 21:48:15 +01:00
DL6ER
d457d40e0b
Add php-xml package as new dependency.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-11-12 20:49:46 +01:00
Adam Warner
6571a63ffa
Add --tags to descibe command
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-11 20:36:51 +00:00
Adam Warner
a7e81c8ea0
remove extra space
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-11-11 20:12:31 +00:00
Adam Warner
73d9abae3e
And finally, we please stickler
...
Signed-off-by: Adam Warner <adamw@rner.email >
2019-11-08 20:58:42 +00:00
Adam Warner
c8b9e42649
Please Codefactor.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2019-11-08 19:18:35 +00:00
Adam Warner
62c00ae1d8
pushd/popd instead of juggling with a variable
...
Signed-off-by: Adam Warner <adamw@rner.email >
2019-11-08 19:11:55 +00:00
MichaIng
ea67c828cd
Minor installer output enhancements
...
+ Print restart hint after setting IPv4 address on a separate line with [i] prefix to not break text alignment
+ Print final upstream DNS choice as a single printf call and by this fix missing info and linebreak on "Custom" choices.
+ Minor if/then/else code alignment
Signed-off-by: MichaIng <micha@dietpi.com >
2019-11-07 13:59:44 +01:00
chrunchyjesus
476975540a
make some shebangs comply to posix standard
2019-11-05 22:33:00 +01:00
Adam Hill
3fbb0ac8dd
Adding docker+arm detection & FTL download
...
Signed-off-by: Adam Hill <adam@diginc.us >
2019-10-29 22:26:46 -05:00
Adam Warner
71903eb27f
Add in checks to reset cloned repo to the lastest available release
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-10-28 22:35:01 +00:00
Mograine
193ff38ab3
Allow more precise deletion by passing ip as parameter
...
Signed-off-by: Mograine <ghiot.pierre@gmail.com >
2019-10-28 13:21:05 +01:00
Pierre Ghiot
bb8dbe9da5
Update 01-pihole.conf
...
Signed-off-by: Mograine <ghiot.pierre@gmail.com >
2019-10-27 16:55:54 +01:00
Pierre Ghiot
f9d16c2b15
Update webpage.sh
...
Signed-off-by: Mograine <ghiot.pierre@gmail.com >
2019-10-27 16:55:54 +01:00
Adam Warner
29bad2fe9b
Merge pull request #2963 from bcambl/fedora_pkg_check_stdout
...
Fix dependency check stdout on Fedora/CentOS
2019-10-16 19:57:23 +01:00
Adam Warner
f4aca3f21d
Merge pull request #2966 from Asuza/minor-typo
...
Minor typo
2019-10-16 19:34:56 +01:00
John Krull
c6f9fe3af2
Fix spelling of the word "permitting"
...
Signed-off-by: John Krull <john.a.krull@gmail.com >
2019-10-15 21:29:55 -05:00
bcambl
612d408034
replace echo with printf in install_dependent_packages()
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-10-14 20:16:40 -06:00
bcambl
a86f578139
replace echo with printf in checkSelinux()
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-10-14 20:06:23 -06:00
Adam Warner
5bac1ad58b
backend changes to allow comment when adding new adlist
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-10-14 22:59:58 +01:00
bcambl
cf2b021502
linting: E302 expected 2 blank lines, found 1
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-10-14 13:29:43 -06:00
bcambl
cd9b1fcb8c
update tests for SELinux changes
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-10-14 13:02:44 -06:00
bcambl
81ca78e7f4
exit installer if SELinux is enforcing
...
The Pi-hole project does not ship a custom SELinux policy as the required policy would lower the overall system security.
Users who require SELinux to be enforcing are encouraged to create an custom policy on a case-by-case basis.
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-10-14 12:25:24 -06:00
bcambl
fc0899b2ad
fix fedora dependency check/install stdout
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-10-13 14:35:38 -06:00
Adam Warner
2e138eb99f
Merge pull request #2954 from pi-hole/reetP-Patch
...
Update pihole
2019-10-06 19:10:05 +01:00
John Crisp
4f21f67775
Update pihole
...
Fix spelling typos
2019-10-06 15:09:14 +01:00
DL6ER
d883854aad
Use constant for long path.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-10-03 12:12:32 +02:00
DL6ER
756c99653e
Merge branch 'development' into new/internal-blocking
2019-10-03 12:01:27 +02:00
Mark Drobnak
3269c63f89
Merge pull request #2948 from pi-hole/fix/restart_lighttpd
...
Do not create empty regex.list file
2019-09-29 12:27:25 -04:00
DL6ER
149fb0c216
Do not install a blank regex file.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-29 18:03:37 +02:00
DL6ER
d244a018d0
Merge pull request #2944 from pi-hole/fix/vw_gravity_creation_v1
...
Fix gravity database table creation order
2019-09-26 14:27:05 +02:00
DL6ER
2e0370367c
Print when we upgrade gravity database version. This will make possibly failed upgrades easier to debug.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-26 14:02:20 +02:00
DL6ER
3cb4f6d9d4
We cannot create vw_gravity before having created vw_whitelist as the former depends onthe later. This commit changes the order in which the tables are created.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-26 13:50:54 +02:00
Mark Drobnak
ae3b8be4d4
Merge pull request #2938 from pi-hole/release/v4.3.2
...
Release v4.3.2 merge to development for update.
2019-09-21 20:40:38 -04:00
Adam Warner
61a40c1b43
merge devel into 4.3.2 And Resolve merge conflicts
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-09-22 01:16:44 +01:00
DL6ER
a27c7b1398
regex white- and blacklist views need to be re-created as well as we need the ID for storing internally whether or not we try to match a given regex for a specific client.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-18 20:58:44 +02:00
DL6ER
a71f35d263
Merge pull request #2932 from pi-hole/fix/no-backup-no-error
...
Fix cross where there is no error
2019-09-17 23:51:46 +02:00
Adam Warner
9a6deb5a1a
Fix tests
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-09-17 21:16:49 +01:00
DL6ER
f582344b9a
"No default index.lighttpd.html file found... not backing up" is not an error.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-17 21:59:48 +02:00
Dan Schaper
e41c4b5bb6
Merge pull request #2881 from pi-hole/release/v4.3.2
...
Pi-hole Core v4.3.2
2019-09-15 08:52:21 -07:00
DL6ER
7b48431917
Add client_by_group table like we have for the other lists. It stores associations between individual clients and list groups.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-09 00:03:57 +02:00
Mark Drobnak
847c4f26aa
Merge pull request #2916 from pi-hole/fix/disable-firefox-doh
...
Improve #2915
2019-09-07 17:58:02 -04:00
DL6ER
1f36ec48e3
Add use-application-dns.net = NXDOMAIN in ProcessDNSSettings rather than in the template so we can ensure that it will survive config-renewals.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-07 23:11:20 +02:00
DL6ER
ff08add7c0
Update vw_whitelist and vw_blacklist to return group_id alongside domain so we can filter if the current client wants to get this domain blocked or not.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-07 13:01:36 +02:00
DL6ER
b4131ae817
Merge pull request #2915 from pi-hole/new/disable-firefox-doh
...
Prevent Firefox from automatically switching over to DNS-over-HTTPS
2019-09-07 12:24:01 +02:00
DL6ER
ffc91a6c81
Update view vw_gravity to only return domains from enabled adlists.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-07 11:17:53 +02:00
DL6ER
525ec8cd01
Signal to Firefox that the local network is unsuitable for DNS-over-HTTPS
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-07 08:44:03 +02:00
Dan Schaper
b209629579
Merge pull request #2909 from pi-hole/fix/domains_in_comment
...
Print messages only after removing possible matches in comments
2019-09-05 21:30:34 -07:00
DL6ER
a8af2e1837
Store domains without sorting and unifying them first. This allows us to preserve the relationship of the individual domains to the lists they came from.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-04 23:14:29 +02:00
Mark Drobnak
93ecc046ea
Merge pull request #2912 from pi-hole/tweak/RemoveAdblockSupport
...
Remove adblock list style support
2019-09-03 20:51:09 -04:00
Adam Warner
8bef5dc805
remove n from -ne
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-09-03 23:56:23 +01:00
Adam Warner
ad41bcca5a
Remove support for adblock style lists to prevent false positives
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-09-03 23:43:11 +01:00
DL6ER
aed2e35bc0
Print messages only after removing possible matches in comments.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-02 22:39:28 +02:00
DL6ER
ab90ff565a
Merge pull request #2903 from pi-hole/tweak/store-gravity-timestamp
...
Store timestamp when the gravity table was last updated successfully
2019-09-01 19:05:46 +02:00
DL6ER
ca8982494b
Store timestamp when the gravity table was last updated successfully. This fixes https://github.com/pi-hole/AdminLTE/issues/989
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-09-01 14:42:07 +02:00
DL6ER
a7b44426cd
Merge pull request #2838 from pi-hole/new/whitelist-regex-support
...
Whitelist regex support
2019-09-01 14:23:37 +02:00
Mark Drobnak
e7af42a9f8
Merge pull request #2897 from pi-hole/fix/readOnlyBin
...
Remove readonly attribute of the PI_HOLE_BIN_DIR declaration in pihole
2019-08-31 14:07:58 -04:00
Dan Schaper
b9fed8fca6
Merge pull request #2891 from niklasea/development
...
Restore 'pihole -q' hosts format support and improve matching in edge cases
2019-08-30 20:56:52 -07:00
Adam Warner
79b8dac0fa
Remove readonly attribute of the PI_HOLE_BIN_DIR declaration in pihole
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-08-30 22:06:14 +01:00
DL6ER
d8eee47ca4
Add dhcp-ignore-names option when enabling DHCP service. We currently remove anything that starts with "dhcp-" to have a clean configuration and removed these lines without noticing when enabling the DHCP server.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-28 22:10:26 -07:00
Niklas Elmose Andersen
a3e32d9a15
Properly escape domain regex
...
Dots in domain names should not match any character.
Signed-off-by: Niklas Elmose Andersen <mail@niklasea.dk >
2019-08-27 12:13:28 +02:00
Niklas Elmose Andersen
989d1aff60
Restore and improve 'pihole -q' matching
...
Removes regex lookaround which 'grep -E' does not support.
Restores support for blocklists in hosts format.
Simplifies domain match cleanup logic by eliminating an if-condition.
Improves domain matching by eliminating commented domain names,
eliminating false positives in a few edge cases.
Signed-off-by: Niklas Elmose Andersen <mail@niklasea.dk >
2019-08-26 20:39:56 +02:00
Mark Drobnak
95b2560a08
Merge pull request #2874 from snapsl/tweak/webpage-shellcheck
...
tweaked webpage.sh
2019-08-26 10:56:38 -04:00
Dan Schaper
76133074d1
Merge pull request #2886 from pi-hole/fix/fullpath
...
Call 'pihole' with full path in install and cronjobs.
2019-08-25 15:38:19 -07:00
Dan Schaper
4cfe463dfa
Add back dropped binary call.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-08-24 04:57:23 -07:00
Dan Schaper
03c65dd0e9
Convert hardcoded /usr/local/bin to variable
...
Update pihole script with full path to 'pihole'
Variable for webpage.sh 'pihole' call.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-08-24 04:49:14 -07:00
DL6ER
6faddfcd3d
Print timestamps in local time zone of the Pi-hole.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-23 10:09:52 +02:00
DL6ER
1820c2c598
Merge branch 'development' into new/whitelist-regex-support
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-22 14:19:51 +02:00
DL6ER
23b688287f
Fix indentation in query.sh. No functional change in this commit.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-22 14:12:58 +02:00
DL6ER
42ccc1ef24
Add support for regex whitelist in "pihole -q".
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-22 14:06:42 +02:00
DL6ER
aef7892de6
Add missing hyphens.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-22 13:57:01 +02:00
DL6ER
cc40c18f49
Wrap upgrade script commands in a transaction.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-22 13:54:46 +02:00
DL6ER
b1838512b2
Explicitly select columns (and their order) when listing the databaes tables. Print timestamps translated to strings instead of printing the integer timestamps.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-22 13:39:58 +02:00
Dan Schaper
1c50caa8ca
Merge pull request #2882 from pi-hole/fix/FTL-latest-tag-not-found
...
Fix error when getting latest FTL tag
2019-08-21 15:31:04 -07:00
Mcat12
febdbceab1
Fix error when getting latest FTL tag
...
The headers containing the latest FTL tag were not properly input to the
command (`<` vs `<<<`). This caused Bash to try and open the file named
after the header string, which does not exist.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 10:03:54 -04:00
Mark Drobnak
597b4bfcca
Merge pull request #2873 from pi-hole/fix/pihole_restartdns
...
Simplify restarting code for "pihole restartdns"
2019-08-21 08:57:44 -04:00
Dan Schaper
5c65006a66
Merge base branch changes
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-08-21 05:20:10 -07:00
David Haguenauer
34727c00c6
Drop indirection from install_dependent_packages
...
Previously, install_dependent_packages would receive an array variable
name as its single parameter, and would use variable indirection to
access it; this change simplifies that function so that it instead
receives the expanded array.
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-08-21 04:41:45 -07:00
Andreas Kurth
352146ef92
Fix pihole manpage to match code.
...
The dry-run argument to pihole -up is "--check-only", not "--checkonly".
Signed-off-by: Andreas Kurth <github@akurth.de >
2019-08-21 04:39:13 -07:00
Mcat12
b107ae2ab9
Use the filtered IPv6 OpenDNS servers
...
The ones we were using previously were not filtered. See
https://support.opendns.com/hc/en-us/articles/227986667-Does-OpenDNS-Support-IPv6-
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:39:10 -07:00
Mcat12
d5d1a607ad
Fix PKG_REMOVE array usage
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:39:07 -07:00
Mcat12
2594164772
Use an array for PKG_REMOVE
...
Fixes shellcheck warning.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:39:05 -07:00
Mcat12
209555c42e
Fix uninstall causing 403 errors and not removing packages
...
The 403 lighttpd errors were caused by removing the lighttpd config
directory and not removing lighttpd itself. This caused a subsequent
Pi-hole reinstall to not have all of the required lighttpd config files.
The error while removing packages was caused by combining arguments into
a string instead of listing each argument.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:39:01 -07:00
DL6ER
e27f50b8e5
Try to obtain PID from PIDFILE. If this fails (file does not exist or is empty), fall back to using pidof + awk
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-21 04:38:58 -07:00
DL6ER
484f618685
Use last PID in case pidof returns multiple PIDs for pihole-FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-21 04:38:55 -07:00
Mcat12
da398c3d9c
Print an error message if the FTL release metadata download fails
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:38:51 -07:00
Mcat12
4e0ad52001
Fix ShellCheck issue by refactoring a bit
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:38:24 -07:00
Mcat12
c9829dd3e4
Fix pihole -up showing FTL update when network is down
...
Fixes #1877
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-21 04:38:04 -07:00
Dan Schaper
35cf863f4b
Create FUNDING.yml
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-08-21 04:38:01 -07:00
Andreas
c53be459c6
quick fix for when dig also returns a CNAME
...
Signed-off-by: Andreas <ryrun@online.de >
2019-08-21 04:37:06 -07:00
B. Olausson
ab1ea5a366
This change fixes issue #145 "stty: standard input: Inappropriate ioctl for device ".It checks if a real terminal exist, if not it sets the screen size to a fixed value. This helps to avoid nasty and unnecessary logs when running "pihole -up" via e.g. cron.
...
Signed-off-by: B. Olausson <contactme@olausson.de >
2019-08-20 14:48:03 -07:00
bcambl
97e11bd94e
ensure installation dependencies for FTL tests which rely on /etc/init.d
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-08-20 11:42:12 -07:00
bcambl
10de7f649b
add chkconfig to INSTALLER_DEPS (CentOS/Fedora)
...
chkconfig is a dependency of spawn-fcgi which is a dependency of lighttpd which is installed via PIHOLE_WEB_DEPS in phase 2
adding chkconfig to INSTALLER_DEPS to ensure /etc/init.d is present during the installation prompts (phase 1)
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-08-20 11:42:09 -07:00
bcambl
d793ef1ab8
Merge conflict Fedora Dockerfile for tests pinned to 30
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-08-20 11:40:18 -07:00
Jeroen Baert
d3d45a8776
Fix 404 error when browsing to pi.hole (without /admin) (for fedora)
...
Signed-off-by: Jeroen Baert <3607063+Forceflow@users.noreply.github.com >
2019-08-20 11:29:20 -07:00
Jeroen Baert
9f86fd0cb4
Fix for 404 error when browsing to pi.hole (without /admin)
...
Signed-off-by: Jeroen Baert <3607063+Forceflow@users.noreply.github.com >
2019-08-20 11:29:17 -07:00
Mcat12
71d5b42726
Remove the ZeusTracker blocklist from the defaults
...
It is no longer served. Fixes #2843 .
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-08-20 11:05:06 -07:00
DL6ER
3e78ed95d4
Fix displaying options for table "group" in the debugger.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-17 15:04:04 +02:00
snapsl
20a839fef5
fixed local declaration before assignment
...
Signed-off-by: snapsl <chris.baller@gmx.de >
2019-08-15 11:20:55 +02:00
snapsl
b2d8c4374b
tweaked code style of webpage.sh
...
Signed-off-by: snapsl <chris.baller@gmx.de >
2019-08-14 23:28:13 +02:00
DL6ER
251c9fee98
Simplify restarting code for "pihole restartdns". This fixes #2869 .
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-14 21:14:55 +02:00
Mark Drobnak
9f77810ca8
Merge pull request #2774 from pi-hole/meta/funding
...
Create FUNDING.yml
2019-08-12 10:30:33 -04:00
DL6ER
dc93462d42
Group table has only two columns
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-06 20:28:00 +02:00
DL6ER
4371c9ba03
Ensure proper permissions are set for gravity.db after creation.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-05 21:20:07 +02:00
DL6ER
6e2e825a5f
Rename options "pihole --whiteregex" to "pihole --white-regex" for the sake of readability. The same applied for "whitewild" -> "white-wild"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-05 21:10:52 +02:00
DL6ER
af754e3fc4
Rearrange group tables directly next to the tables they refer to.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-05 21:08:36 +02:00
DL6ER
06860ed5b4
Group tables have only two columns.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-05 21:07:39 +02:00
DL6ER
09190c1735
Only check once for if this is a regex list or not.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-05 21:03:47 +02:00
DL6ER
a95b473417
Rearranage if statements to ensure the proper output is shown for wildcard-style filters.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-08-05 20:56:01 +02:00
Mark Drobnak
56e3565a9e
Merge pull request #2865 from ryrun/patch-1
...
quick fix for when dig also returns a CNAME
2019-08-05 10:58:27 -04:00
Andreas
63230cb72d
quick fix for when dig also returns a CNAME
...
Signed-off-by: ryrun <ryrun@online.de >
2019-08-04 21:21:08 +02:00
Mark Drobnak
f81e57d5b8
Merge pull request #2862 from bolausson/mybranch
...
Check if TTY exist before we get screen size - Second PR try
2019-07-30 14:58:56 -04:00
B. Olausson
ecd6817aaf
This change fixes issue #145 "stty: standard input: Inappropriate ioctl for device ".It checks if a real terminal exist, if not it sets the screen size to a fixed value. This helps to avoid nasty and unnecessary logs when running "pihole -up" via e.g. cron.
...
Signed-off-by: B. Olausson <contactme@olausson.de >
2019-07-29 19:48:56 +01:00
DL6ER
6f58d58cae
Add --whitewild to help texts and man pages.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-22 22:26:27 +02:00
DL6ER
40d0caa70b
Add undocumented --whitewild option that does the same --wild does for the whitelist.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-22 21:15:28 +02:00
DL6ER
0692be9bae
Fix small mistake in 2->3 upgrade script.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-22 20:59:52 +02:00
DL6ER
0d28dce326
Print group table contents in debug log.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-22 20:18:15 +02:00
DL6ER
96031214c6
Add support for whitelist regex filter management via CLI.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-22 19:36:11 +02:00
Mark Drobnak
3420439f31
Merge pull request #2820 from pi-hole/fix/ftl-update-no-network
...
Fix pihole -up showing FTL update when network is down
2019-07-20 14:55:48 -04:00
Mark Drobnak
ab3f6dfcc6
Merge pull request #2831 from pi-hole/fix/block-page-adlists
...
Fix block page errors due to gravity DB and changes to queryAds
2019-07-20 14:55:37 -04:00
Mcat12
3ebd43ebf0
Remove outdated adlists.list check and fix empty adlists error message
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-19 17:39:00 -07:00
Mcat12
38ff343134
Print an error message if the FTL release metadata download fails
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-19 17:35:21 -07:00
Mark Drobnak
6a8d3100d2
Merge pull request #2846 from pi-hole/fix/zeus-dead-adlist
...
Remove the ZeusTracker blocklist from the defaults
2019-07-18 13:43:57 -04:00
Mcat12
c3ec2e68ad
Remove the ZeusTracker blocklist from the defaults
...
It is no longer served. Fixes #2843 .
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-12 20:03:36 -07:00
Mark Drobnak
bfe714e985
Merge pull request #2840 from pi-hole/fix/valid_ip-quote-error
...
Fix error when checking if IP address is valid
2019-07-11 23:06:39 -04:00
Mcat12
1d5755a4c2
Add tests for valid_ip
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-10 21:18:58 -07:00
Mark Drobnak
445127accc
Merge pull request #2832 from pi-hole/new/audit_database
...
Migrate audit list to gravity.db database table
2019-07-10 22:55:48 -04:00
Mcat12
c156af020c
Use suggested array creation to fix linter error
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-10 19:52:17 -07:00
Mark Drobnak
fa8751f9ad
Fix error when checking if IP address is valid
...
During install in `valid_ip`, we split up the IP address into octets to verify it is valid (each is <= 255).
This validation was broken in #2743 when a variable usage was quoted where it should have stayed unquoted:
```
./automated install/basic-install.sh: line 942: [[: 192.241.211.120: syntax error: invalid arithmetic operator (error token is ".241.211.120")
```
Due to this error, `127.0.0.1` would be used instead of the requested IP address. Also, this prevented the user from entering a custom DNS server as it would be marked as an invalid IP address.
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2019-07-10 19:42:51 -07:00
DL6ER
420f60b5c7
Add timeout to migration script (1->2).
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-10 12:02:07 +02:00
DL6ER
65fdbc85d5
Add timeout to migration script (2->3).
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-10 12:01:38 +02:00
DL6ER
87f75c737a
Review comments.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-10 12:00:38 +02:00
DL6ER
5ff9052200
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-09 11:41:44 +02:00
DL6ER
9641e268ea
Merge pull request #2837 from pi-hole/fix/debug-use-FTL-file-locations
...
Get file locations of FTL files from the config
2019-07-09 07:54:57 +02:00
Mcat12
b154dd5f07
Quote calls to read FTL config
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-08 19:48:50 -07:00
DL6ER
0683842ec3
Fix typo in 2->3 migration script.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-08 21:43:49 +02:00
DL6ER
f5121c64be
We should still add the regex lines (initially) to the regex table as the renaming will happen only after the importing.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-08 21:39:30 +02:00
DL6ER
054c7a2c05
Create new table + view regex_whitelist + rename old regex table to regex_blacklist. This updates the gravity.db version to 3.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-08 21:35:31 +02:00
DL6ER
3d3fc2947e
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-08 19:22:35 +02:00
Mcat12
e8e5d4afda
Get file locations of FTL files from the config
...
Instead of hardcoding the location of certain FTL files (`gravity.db`,
`pihole-FTL.log`), read the configured location from FTL's config. The
default location is used if no custom location has been configured.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-07 18:10:39 -07:00
DL6ER
8382f4d727
Rename table to domain_audit and simplify subroutine addAudit().
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-07 21:21:56 +02:00
DL6ER
be3e198f9a
Address linting errors.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-07 10:46:20 +02:00
DL6ER
acc50b709e
Only migrate files once (domain and adlist lists druing initial creation of gravity.db auditlog.list on database upgrade from version 1 to 2.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-07 10:33:08 +02:00
Mark Drobnak
5a6763f90d
Merge pull request #2833 from bcambl/fedora30_tests
...
Fedora 30 tests
2019-07-06 19:27:02 -04:00
bcambl
218476fab0
ensure installation dependencies for FTL tests which rely on /etc/init.d
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-07-06 11:06:08 -06:00
bcambl
ec850dc820
add chkconfig to INSTALLER_DEPS (CentOS/Fedora)
...
chkconfig is a dependency of spawn-fcgi which is a dependency of lighttpd which is installed via PIHOLE_WEB_DEPS in phase 2
adding chkconfig to INSTALLER_DEPS to ensure /etc/init.d is present during the installation prompts (phase 1)
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-07-06 10:58:19 -06:00
bcambl
c48b03584f
update Fedora Dockerfile to 30
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-07-06 10:57:57 -06:00
DL6ER
efe8216445
Fix further stickler complaint.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-06 09:45:07 +02:00
DL6ER
0405aaa3da
Review comments and fixing stickler complaints.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-06 09:32:41 +02:00
Mark Drobnak
6bb213e56f
Merge pull request #2826 from Forceflow/development
...
Fix for 404 error when browsing to pi.hole (without /admin)
2019-07-05 17:18:50 -04:00
DL6ER
2fb4256f84
Rename table to "auditlist"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-05 16:28:36 +02:00
DL6ER
82476138c1
Instead of calling sqlite3 multiple times within a loop, we use the ability to add multiple rows within one INSERT clause. This is supported since sqlite3 3.7.11 (2012-03-20) and should be available on all systems.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-05 16:09:13 +02:00
DL6ER
5293beeb77
Update audit script to store domains in new database table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-05 14:10:33 +02:00
DL6ER
0c8f5f1221
Remove comment field from audit table
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-05 14:06:05 +02:00
DL6ER
4f4a12bb40
Upgrade database if necessary and store audit domains therein.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-05 14:03:57 +02:00
DL6ER
1dbe6c83c3
Add database upgrading mechanism for adding the audit table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-05 13:54:18 +02:00
Mcat12
2b5033e732
Add missing spaces found by linter
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-04 13:49:39 -07:00
Mcat12
8d9ff550d4
Fix blockpage error if whitelisted, blacklisted, or regex filtered
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-04 13:44:14 -07:00
Mcat12
f1733f9c5d
Fetch adlists for the block page from gravity.db
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-07-04 13:11:46 -07:00
Mark Drobnak
92c3c86be4
Merge pull request #2769 from pi-hole/new/arp-flush
...
Add new "pihole arpflush" command
2019-07-04 14:00:16 -04:00
Mark Drobnak
ada8b53423
Merge pull request #2803 from pi-hole/new/gravity.db_domain_groups
...
Implement groups for lists
2019-07-04 13:52:52 -04:00
DL6ER
7a1b6fd205
Merge branch 'development' into new/gravity.db_domain_groups
2019-07-03 19:21:55 +02:00
DL6ER
b78cbb98d8
Merge pull request #2830 from mmotti/fix/regexp_query
...
Fix potential invalid result for pihole -q
2019-07-03 19:16:04 +02:00
MMotti
04abcb71f6
Fix potential invalid result for pihole -q
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-07-03 13:04:57 +01:00
DL6ER
1fe3507bc5
Adlists table was renamed to Adlist. Adapt further places in the code to match the new name.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-03 07:56:10 +02:00
Jeroen Baert
9fedafed15
Fix 404 error when browsing to pi.hole (without /admin) (for fedora)
...
Signed-off-by: Jeroen Baert <3607063+Forceflow@users.noreply.github.com >
2019-07-03 04:28:44 +02:00
DL6ER
23b3a9a650
Add DISTINCT to the view\'s SELECT queries to avoid domain duplication in case they are enabled in multiple groups at the same time.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-07-01 09:44:20 +02:00
Jeroen Baert
7b2ac25a52
Fix for 404 error when browsing to pi.hole (without /admin)
...
Signed-off-by: Jeroen Baert <3607063+Forceflow@users.noreply.github.com >
2019-07-01 03:42:02 +02:00
DL6ER
f91421418a
Rename adlists -> adlist table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 23:21:10 +02:00
DL6ER
3a14e8b013
Check whitelist_by_group.group_id instead of group.enabled against NULL.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 23:20:13 +02:00
DL6ER
ad97e95f2f
Add required name column in group table.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 23:06:15 +02:00
DL6ER
5b01facd73
Fix logix on the views: AND ( OR )
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 20:03:22 +02:00
DL6ER
6fe637b9ee
Rename groups -> group
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 19:43:18 +02:00
DL6ER
94d83dbb2d
Unify the two group tables into a single "groups" table. This allows managing adlists and domains together.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 19:33:02 +02:00
Mark Drobnak
c9a843b417
Merge pull request #2823 from pi-hole/fix/lighttpd-mime
...
Update with v4.3.1 changes
2019-06-30 13:27:55 -04:00
Mark Drobnak
b986c5585d
Merge pull request #2822 from akurth/development
...
Fix pihole manpage to match code.
2019-06-30 13:11:20 -04:00
DL6ER
87c115fc86
Change implementation to use linking tables (domain_groups, adlists_groups). This allows adding domains to multiple lists conveniently.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-30 19:04:38 +02:00
Andreas Kurth
acee97916e
Fix pihole manpage to match code.
...
The dry-run argument to pihole -up is "--check-only", not "--checkonly".
Signed-off-by: Andreas Kurth <github@akurth.de >
2019-06-30 08:02:51 +02:00
Mark Drobnak
1a741f696e
Merge pull request #2816 from RamSet/hotfix/lighttpdMime
...
Fix lighttpd mime
2019-06-29 15:45:33 -04:00
Mcat12
37e7cd5211
Fix ShellCheck issue by refactoring a bit
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-28 21:19:07 -07:00
Mcat12
91a2d052a7
Fix pihole -up showing FTL update when network is down
...
Fixes #1877
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-28 20:49:56 -07:00
Mark Drobnak
06134d3ffc
Merge pull request #2817 from pi-hole/tweak/gravity_db_timeout
...
Add timeout to sqlite3 command
2019-06-27 17:34:34 -04:00
Mark Drobnak
092957c14a
Merge pull request #2808 from pi-hole/fix/uninstall
...
Fix uninstall causing 403 errors and not removing packages
2019-06-27 12:51:07 -04:00
DL6ER
d5e8f1a781
Add 10 seconds timeout to the sqlite3 command that writes tables to the gravity database. This prevents gravity from failing when the database file is locked for a short time.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-26 18:20:36 +02:00
RamSet
b5af125be6
Removed line
...
Signed-off-by: RamSet <RamSet@gmail.com >
2019-06-25 15:45:01 -06:00
RamSet
ecc49318f0
Fixed MIME related issue present in lighttpd/1.4.53
...
Signed-off-by: RamSet <RamSet@gmail.com >
2019-06-25 15:45:01 -06:00
Mcat12
974bba4a45
Fix PKG_REMOVE array usage
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-17 16:30:26 -07:00
Mcat12
951732fc1b
Use an array for PKG_REMOVE
...
Fixes shellcheck warning.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-17 16:28:55 -07:00
Mcat12
b6700924b2
Fix uninstall causing 403 errors and not removing packages
...
The 403 lighttpd errors were caused by removing the lighttpd config
directory and not removing lighttpd itself. This caused a subsequent
Pi-hole reinstall to not have all of the required lighttpd config files.
The error while removing packages was caused by combining arguments into
a string instead of listing each argument.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-17 16:13:31 -07:00
DL6ER
5d43639e93
Merge branch 'development' into new/arp-flush
2019-06-16 20:21:03 +02:00
DL6ER
27e4208631
Merge branch 'development' into new/gravity.db_domain_groups
2019-06-16 20:20:27 +02:00
DL6ER
b505ad22e6
Merge pull request #2806 from pi-hole/fix/fedora-ci-tests
...
Pin the Fedora test docker container to 29
2019-06-16 20:19:44 +02:00
Mcat12
d67122dffc
Pin the Fedora test docker container to 29
...
The tests are currently failing due to a change in Fedora 30, which we
are not currently supporting.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-16 11:13:23 -07:00
DL6ER
0774c4e5ca
vw_gravity should actually filter using vw_whitelist.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-16 18:52:23 +02:00
DL6ER
01850c2128
Automatically recreate standard group after deletion to avoid violating foreign key constraints even if foreign key enforcing is disabled (SQLite's default behavior)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-16 17:15:36 +02:00
DL6ER
cbc210b014
Add adlist_groups and mark group_id columns as NOT NULL.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-16 17:05:33 +02:00
DL6ER
c53ee4202b
Add filtering by domain groups to gravity database.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-16 16:50:51 +02:00
DL6ER
f2be12f97b
Merge pull request #2796 from pi-hole/tweak/opendns-ipv6
...
Use the filtered IPv6 OpenDNS servers
2019-06-16 14:56:00 +02:00
DL6ER
6996ffa451
Also flush network_addresses table
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-15 09:15:12 +02:00
DL6ER
435a5fb3ad
Add pihole arpflush to man page.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-15 09:12:44 +02:00
DL6ER
4947350ca5
Add arpflush to help and bash autocompletion
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-06-15 09:08:33 +02:00
DL6ER
c1495b0fa8
Merge branch 'development' into new/arp-flush
2019-06-15 09:04:30 +02:00
Mark Drobnak
67dda9c8bb
Merge pull request #2790 from mmotti/tidy/query
...
Small changes to regexp querying
2019-06-13 20:32:42 -04:00
Mcat12
c8987e20c2
Use the filtered IPv6 OpenDNS servers
...
The ones we were using previously were not filtered. See
https://support.opendns.com/hc/en-us/articles/227986667-Does-OpenDNS-Support-IPv6-
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-06-12 19:13:29 -07:00
MMotti
bcf03647ef
Add comment and remove blankspace
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-12 16:02:59 +01:00
MMotti
a9d0690f4d
Change the case of some variables
...
Just for consistency
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-10 18:50:52 +01:00
MMotti
10fbed50f3
Shellcheck
...
Suggesting to use parameter expansion but we need to be able to identify the start of each line
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-10 18:10:25 +01:00
MMotti
785f1fedd9
Tidy regexp queries
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-10 17:52:58 +01:00
Mark Drobnak
b0c5dcf42f
Merge pull request #2780 from mmotti/fix/regexp_query
...
Fix for regexp queries through pihole -q
2019-06-05 13:19:39 -04:00
MMotti
cf21efa103
Minor grammar changes
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-05 14:36:43 +01:00
MMotti
7613e94ef6
Minor tweaks
...
Mainly for consistency
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-04 06:06:17 +01:00
MMotti
b49c702f33
Consistency tweak
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-04 00:03:37 +01:00
MMotti
09532638d5
Read from DB instead of regex.list
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-04 00:00:25 +01:00
MMotti
97df6d7415
Stickler fix
...
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-03 19:56:10 +01:00
MMotti
54bfaa28c1
Fix for regexp queries through pihole -q
...
Taking inspiration from: https://github.com/pi-hole/pi-hole/pull/2346
We will use awk to iterate through each regexp and print any that match the domain query.
Signed-off-by: MMotti <matthew.w.motti@gmail.com >
2019-06-03 19:32:59 +01:00
Dan Schaper
a09f92f9cc
Create FUNDING.yml
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-05-31 22:12:54 -07:00
Mark Drobnak
afd28fab03
Merge pull request #2767 from pi-hole/fix/multiple_pihole-FTL_PIDs
...
Improve PID detection in pihole-FTL.service
2019-06-01 01:03:55 -04:00
Mark Drobnak
d92ced6fb6
Merge pull request #2734 from pi-hole/fix/query_black_and_whitelists_database
...
Query black and whitelists database
2019-06-01 00:55:05 -04:00
DL6ER
ae98fde321
Try to obtain PID from PIDFILE. If this fails (file does not exist or is empty), fall back to using pidof + awk
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-31 09:18:12 +02:00
DL6ER
9ddce88092
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-31 08:42:22 +02:00
DL6ER
44f8fcb600
We can print the table name without any extra check as we already returned early in case there are no results.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-31 08:39:18 +02:00
Mark Drobnak
814fdcf9b6
Merge pull request #2768 from pi-hole/fix/dhcp-ignore-names
...
Add dhcp-ignore-names option when enabling DHCP service
2019-05-30 22:35:52 -04:00
DL6ER
5060605626
Print table name before entering the loop for the sake of simplicity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 21:44:59 +02:00
DL6ER
453ba14cbd
Merge pull request #2758 from pi-hole/fix/debug-log-gravity-database
...
Update debug script with gravity DB changes
2019-05-30 21:37:49 +02:00
DL6ER
285e6fe090
Address lint complaints
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 21:32:35 +02:00
DL6ER
c3023fe681
Add new "pihole arpflush" command to flush both the ARP cache as well as the network table in pihole-FTL.db
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 21:25:10 +02:00
DL6ER
c5df104a66
Add dhcp-ignore-names option when enabling DHCP service. We currently remove anything that starts with "dhcp-" to have a clean configuration and removed these lines without noticing when enabling the DHCP server.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 16:41:37 +02:00
DL6ER
f6213d4f4d
Use last PID in case pidof returns multiple PIDs for pihole-FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-30 15:26:27 +02:00
Mark Drobnak
ca2ea388b7
Merge pull request #2763 from chrisys/development
...
Handle an empty local.list
2019-05-27 16:06:25 -04:00
Chris Crocker-White
69dba022c4
Handle an empty local.list
...
Handle the case of an empty local.list file which would otherwise prevent the system from starting
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io >
2019-05-27 10:27:28 -07:00
Mcat12
bfb99c361c
Note that the gravity size does not include the blacklist entries
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-21 17:12:47 -07:00
Mcat12
5796054305
Increase ID column width to 4
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:59:18 -07:00
Mcat12
a3e1473ac1
Set explicit column widths to prevent text from getting cut off
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:33:09 -07:00
Mcat12
7b5fc60e00
Improve table formatting
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:20:38 -07:00
Mcat12
807ce0af4e
Show whitelist, blacklist, and regexlist details
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:15:22 -07:00
Mcat12
3f05efd60f
Add extra newline
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 21:02:31 -07:00
Mcat12
03d93aa19a
Update debug script with gravity DB changes
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-20 20:58:57 -07:00
DL6ER
cad9386ff6
Merge pull request #2750 from pi-hole/release/v4.3
...
Update Dev with v4.3 fixes
2019-05-19 19:42:29 +02:00
Dan Schaper
7de6bbca61
Merge branch 'development' into release/v4.3
2019-05-18 13:18:14 -07:00
Mark Drobnak
1d43c0a2fa
Merge pull request #2693 from pi-hole/release/v4.3
...
Pi-hole Core v4.3
2019-05-18 16:08:49 -04:00
Mark Drobnak
c8d32e0dd3
Merge pull request #2743 from haguenau/fix/shellcheck-install-script
...
Clean up basic install script
2019-05-16 23:22:01 -04:00
David Haguenauer
be3a21ae07
Put quotes at ends of strings
...
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-05-14 15:20:28 -04:00
David Haguenauer
69081a9175
Drop indirection from install_dependent_packages
...
Previously, install_dependent_packages would receive an array variable
name as its single parameter, and would use variable indirection to
access it; this change simplifies that function so that it instead
receives the expanded array.
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-05-14 15:20:28 -04:00
David Haguenauer
ab2f8a0c09
Quote variables in basic-install.sh
...
This greatly reduces the number of warnings emitted by ShellCheck, and
in turn should make it more likely that errors are caught in the
future.
Signed-off-by: David Haguenauer <ml@kurokatta.org >
2019-05-14 15:20:28 -04:00
Mark Drobnak
b961a501bb
Merge pull request #2611 from pi-hole/new/gravitydb
...
Store blocking domains in a database
2019-05-12 18:46:47 -04:00
Mcat12
8e1bf6e3d4
Merge branch 'development' into new/gravitydb
...
# Conflicts:
# advanced/Scripts/list.sh
# gravity.sh
# pihole
2019-05-12 15:20:52 -07:00
Mark Drobnak
d6756eb46b
Merge pull request #2730 from pvogt09/development
...
Adds world readable attribute to files created by Pi-hole to circumve…
2019-05-12 15:44:20 -04:00
pvogt09
efbd42f7b5
Moves creation of pihole user before FTL installation
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-12 11:27:25 +02:00
pvogt09
3f90261520
Moves chmod after every creation of ${destination} instead of end of function
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-12 11:25:48 +02:00
Mark Drobnak
ff5894d772
Merge pull request #2744 from pi-hole/fix/cron-job-errors-untagged
...
Fix for preventing git error message in cron logs
2019-05-11 22:59:32 -04:00
pvogt09
225285cb97
Removes chmod for ${source} and superfluous chmod for ${destination}
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-11 11:14:07 +02:00
mpiederiet
3220e2b978
Fix for preventing git error message in cron logs
...
Fix to prevent "fatal: No names found, cannot describe anything" git message during scheduled update checks
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-11 10:57:44 +02:00
DL6ER
54ae458b61
Merge pull request #2733 from pi-hole/fix/debug-curl
...
Pi-hole Debug - tricorder upload function calls
2019-05-11 10:54:30 +02:00
pvogt09
e076db5a4e
Changes ownership of macvendor.db to pihole
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-10 11:19:28 +02:00
pvogt09
a3d2a1062f
Makes blocklists world readable
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-10 11:13:19 +02:00
pvogt09
2e6198077d
chmod 644 adlists.list
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-09 12:23:44 +02:00
Mark Drobnak
55ab3b2dc7
Merge pull request #2739 from pi-hole/new/stickermule_reflink
...
README StickerMule URL
2019-05-07 23:26:20 -04:00
Mark Drobnak
bdc8cf2bc8
Merge pull request #2738 from pi-hole/fix/untagged_version_fresh_install
...
Fix Untagged display on new installs
2019-05-07 23:25:33 -04:00
Dan Schaper
74836bebe4
README StickerMule URL
...
Change StickerMule reflink to Team Pi-hole link.
2019-05-07 11:10:51 -07:00
DL6ER
95150a5d85
Clone twenty instead of only one commit when installing Pi-hole. This ensures that we clone at least one tagged commit in case we need to push changes to master.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-07 19:42:11 +02:00
pvogt09
4d23b3267f
Adds X to chmod for git operations
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-07 10:46:16 +02:00
pvogt09
e19adccd9c
Moves chmod for /var/www/html into INSTALL_WEB_SERVER block
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-05 22:34:13 +02:00
pvogt09
a25f331e83
Adds chmod 644 for /var/www and /var/www/html
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-05 09:20:49 +02:00
pvogt09
69c06ba6fe
Sets permissions for dnsmaq.conf
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-05 00:32:10 +02:00
DL6ER
8abeb2204b
Merge pull request #2735 from pi-hole/fix/gravity-blocked-domain
...
Fix incorrect adlist query when an adlist is blocked during gravity
2019-05-04 23:14:49 +02:00
Mcat12
ec06fd0ad4
Fix incorrect adlist query when an adlist is blocked during gravity
...
hosts-file.net was hard-coded as the domain to check instead of the
actual domain.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-05-04 11:35:21 -07:00
DL6ER
a904c183df
Use printf to escape domain content. This prevents possible SQL injection issues
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-04 18:25:11 +02:00
DL6ER
5246b3e496
Explicitly escape backslash in ESCAPE clause. This has been suggested by Stickler bot.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-04 13:24:36 +02:00
DL6ER
f80fdd7e83
Improve comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-04 13:19:50 +02:00
DL6ER
6ba58896d2
Simplify code
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-04 13:15:30 +02:00
DL6ER
3aa838bbe4
Implement black- and whitelist searching with SQL statements. We use the ESCAPE clause in the LIKE query as the underscore "_" wildcard matches any single character but we want to suppress this behavior (underscores can be legitimate part of domains)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-04 13:02:14 +02:00
pvogt09
2c3a27e9c7
Replaces cp chmod with install and add read permission to repository files after checkout and pull
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-03 12:27:56 +02:00
Dan Schaper
5532df24e4
Pi-hole Debug - tricorder upload function calls
...
Fix tricorder upload function calls to use new curl function.
2019-05-03 02:46:27 -07:00
Dan Schaper
b3898b9b2a
Merge pull request #2732 from pi-hole/dschaper-patch-1
...
Update cryptocoin addresses
2019-05-03 02:42:41 -07:00
Dan Schaper
9ce84714cd
Update cryptocoin addresses
...
We no longer have access to the old coinbase account. Updating to new Coinbase Commerce account.
2019-05-02 18:08:10 -07:00
DL6ER
0bc112ce52
Query only those columns we actually use when showing domains on the CLI. Show date of last modification instead of addition date for domains.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-02 17:11:39 +02:00
DL6ER
d46ff1d2d7
Remove UNIQUE on gravity table as the only column is already PRIMARY KEY. Primary keys must contain UNIQUE values, and cannot contain NULL values
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 22:08:30 +02:00
DL6ER
0cfecd31d3
Invert logic to reduce nesting
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 22:07:14 +02:00
DL6ER
008e88b84b
Only migrate legacy list files when we create gravity.db in the same gravity run
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 18:04:31 +02:00
DL6ER
2f698904e4
Use PRIMARY KEY instead of NOT NULL also in gravity and info tables
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 18:03:35 +02:00
DL6ER
106f079afc
Improve indentation (single tab) in SQLite template
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 17:57:23 +02:00
DL6ER
6c1e3a17f7
Remove NOT NULL constraint on list ids as this is implied by PRIMARY KEY (even though most, if not all, examples on the web still use both attributes at the same time)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 17:54:29 +02:00
DL6ER
540c57f755
Add comment for automigrated list entries
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 17:51:25 +02:00
DL6ER
5e26e8245b
Order results of queries to list views by id key
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 17:51:10 +02:00
DL6ER
983117d788
Add id (primary key, autoincrement) field to lists tables
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 17:47:15 +02:00
DL6ER
b372f808dd
Fix lint errors
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 17:06:14 +02:00
DL6ER
bc9b623638
Modify query.sh to use the gravity database
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 16:56:16 +02:00
DL6ER
d5781fb110
Fix extra space in front on END statement in CREATE TRIGGER commands
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 16:38:41 +02:00
DL6ER
487718512d
Remove DISTINCT attribute from views. They are not needed as the corresponding data is obtained from fields with UNIQUE attribute so duplications are already prevented at domain insertion. The elimination of the duplication check on imort through the views slightly reduces the load during import (I observed about 8 percent time saved on my NanoPi NEO).
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-05-01 16:37:23 +02:00
pvogt09
8a92fb24c4
Incorporates changes requested by @Mcat12
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-05-01 11:20:26 +02:00
pvogt09
5c575e73c7
Adds world readable attribute to files created by Pi-hole to circumvent #2724
...
Signed-off-by: pvogt09 <50047961+pvogt09@users.noreply.github.com >
2019-04-30 22:41:12 +02:00
DL6ER
2180531a84
Add trigger for automatic updates of the date_modified column and improve formating in the gravity.db template
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-29 19:43:35 +02:00
Mark Drobnak
6812e8880e
Merge pull request #2705 from pi-hole/fix/chronometer-refresh-arg
...
Fix chronometer refresh incorrectly reading the long argument sleep time
2019-04-29 11:43:07 -04:00
DL6ER
a932209143
Set default for date_modified to be the current time
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-29 17:21:59 +02:00
DL6ER
4946b5907b
Move migrated files to backup directory instead of deleting them. This has the benefit that gravity.db can be recreated at any time by: 1. deleting gravity.db, 2. copying all files from the migration_backup directory back to /etc/pihole, 3. running pihole -g again.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-28 22:15:47 +02:00
DL6ER
efeba594ae
Add support for manipulating adlists from the CLI
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-28 21:39:06 +02:00
Mark Drobnak
b27e4c3dc3
Merge pull request #2725 from pi-hole/fix/get-ip-similar-subnets
...
Fix getting IP address in the presence of similar subnets
2019-04-28 14:24:47 -04:00
DL6ER
5e1241acd2
Merge branch 'new/gravitydb' of github.com:pi-hole/pi-hole into new/gravitydb
2019-04-28 14:44:34 +02:00
DL6ER
126f7101ff
Add (optional) date_modified field and use vw_whitelist view in vw_blacklist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-28 14:44:03 +02:00
Mcat12
b320e74921
Improve argument handling
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-04-27 14:05:04 -07:00
Mcat12
add5e4ca5e
Explicitly allow only -r and --refresh in argument handler
...
It is already checked, but this make the code explicit.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-04-27 13:39:44 -07:00
Mcat12
466fd79c66
Fix getting IP address in the presence of similar subnets
...
Change was suggested by @computergeek125 in #2387
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-04-27 12:39:45 -07:00
Mark Drobnak
4596d9a577
Merge branch 'development' into new/gravitydb
2019-04-26 23:40:28 -04:00
DL6ER
b4ae142149
Remove printf escaping (we will realize it differently) and ensure we're using single quotes for strings (although double quotes are possible, too)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 20:54:01 +02:00
DL6ER
3fe43ce1d9
Rely on default value (database provided) for date_added when adding a new domain
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 18:16:04 +02:00
DL6ER
8524aecfed
Don't set gravity database permissions
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:56:11 +02:00
DL6ER
e04dc9d2bb
Remove sqlitekey variable as the first column of the regex table is now called domain as well
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:44:42 +02:00
DL6ER
3dcb9722d3
Remove global haveSourceUrls variable and just skip downloading and processing adlists if there aren't any to be downloaded
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:39:35 +02:00
DL6ER
bd0215524b
Add vw_adlists view which returns only enabled adlists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:36:00 +02:00
DL6ER
53e3ff2b24
Only add non-empty lines when moving file content into database tables
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:32:05 +02:00
DL6ER
5bb8163674
Change type of whitelist, blacklist, regex, and adlists time column to INTEGER and insert a DEFAULT clause that returns the current Unix time as such an integer
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:26:15 +02:00
DL6ER
a891d64395
We should always exit after displaying a list, even if it is empty
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:13:36 +02:00
DL6ER
6b1d2523e8
Also print datetime a domain was added when listing the domains on the CLI
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:07:16 +02:00
DL6ER
08ee9526ad
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 17:06:01 +02:00
DL6ER
0efc46260f
Use both old and new strings for detecting whether this is a Pi-hole dnsmasq config file
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-26 16:16:30 +02:00
DL6ER
6a01a1257f
Merge pull request #2597 from xCh12i5/RegEx-Fix
...
Solves RegEx issue.
2019-04-25 15:27:35 +02:00
DL6ER
a2a7e80007
Add --web for sending a confirmation string when executed from the web interface. This is necessary as the "Reloading DNS service" message does not always propagate through to the web interface when reloading pihole-FTL takes a while.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 15:01:13 +02:00
DL6ER
cce66a13b6
Fix output in list.sh when adding a domain that is already present in the target list
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 14:54:41 +02:00
DL6ER
43bced7997
Add more comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 12:45:08 +02:00
DL6ER
788cd78321
Reduce code duplication and add special handling of | character as it might appear in regex filter string
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 12:30:38 +02:00
DL6ER
e5d1cb5a2e
Rewrite list.sh to operate on database-based lists
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 12:10:42 +02:00
DL6ER
d94bbfca7f
Finish migrating gravity.db to using our new gravity database. This removes the --skip-download, --blacklist-only, --whitelist-only, and --wildcard-only options as it is not necessary to run gravity when modifying them from now on (gravity really only builds the gravity database and the local.list file).
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 11:23:06 +02:00
DL6ER
465a39427b
Source adlists from gravity database
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 10:46:18 +02:00
DL6ER
2664ac0efc
Improve error reporting
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 10:18:37 +02:00
DL6ER
c1277705d8
Copy existing whitelist.txt, blacklist.txt, regex.list, and adlists.list to the database. We remove the files afterwards as the content lives in the database now
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-25 10:14:45 +02:00
DL6ER
61cfd2f9f9
Add adlists table
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 19:48:06 +02:00
DL6ER
ee4dabeca6
Merge branch 'development' into new/gravitydb
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 19:12:19 +02:00
DL6ER
e57d0fb93c
Remove the empty templates gravity.list, white.list, black.list. The old source files whitelist.txt, blacklist.txt, and regex.list still exist and need to be removed in a follow-up commit
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 19:05:08 +02:00
DL6ER
ee20164207
Remove detect_pihole_blocking_status() as we can modify the database at any time
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 19:01:31 +02:00
DL6ER
d7ee44960e
Remove moving around of the gravity and blacklist files as we do not use them any longer
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 18:57:38 +02:00
DL6ER
c13ebd3a9d
Replace Pi-hole ID string with another line we intend to keep
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 18:55:25 +02:00
DL6ER
6594a0a6e7
Fix detection of blocked query in pihole -t
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 18:53:20 +02:00
DL6ER
de44563301
Remove addn-hosts from 01-pihole.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-24 18:51:38 +02:00
DL6ER
e3d9cf0ac1
Merge pull request #2718 from Piskvor/basic-install-package-manager-typo
...
Show $UPDATE_PKG_CACHE content in error message.
2019-04-24 10:17:23 +02:00
Mark Drobnak
bd572d8843
Merge pull request #2717 from pi-hole/fix/teleporter-extension
...
Fix teleporter backup file extension
2019-04-23 13:23:43 -04:00
Jan Piskvor Martinec
037737d653
Show $UPDATE_PKG_CACHE content in error message.
...
Fixes the typo in update_package_cache(), where the error message
contained the color code twice, instead of the $UPDATE_PKG_CACHE text.
Signed-off-by: Jan Piskvor Martinec <github@piskvor.org >
2019-04-23 16:02:25 +02:00
Mark Drobnak
d2c7c426de
Fix teleporter backup file extension
...
Fixes #2714
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2019-04-22 19:43:26 -07:00
Mark Drobnak
1d09c6e47d
Merge pull request #2709 from pi-hole/fix/checkout_indentation
...
Fix pihole checkout indentation
2019-04-16 22:51:01 -04:00
DL6ER
84244b7cd5
Fix indentation in display of branches available during pihole checkout
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-04-16 18:30:04 +02:00
Mcat12
422680ee9f
Fix chronometer refresh incorrectly reading the long argument sleep time
...
`-r` worked, but `--refresh` did not.
Fixes #2703
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-04-14 13:03:25 -07:00
Mark Drobnak
42c7653e99
Merge pull request #2696 from pi-hole/tweak/FTL-privacy-doc-link
...
Add a link to the documentation on FTL privacy levels during install
2019-04-07 15:12:10 -04:00
Mcat12
78c0c58946
Add a link to the documentation on FTL privacy levels during install
...
Closes #2695
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-04-07 12:00:43 -07:00
Mark Drobnak
cae61614f4
Merge pull request #2688 from pi-hole/fix/2687
...
Add Check to `pihole -q -exact` to ensure there is no `#` char preceding a space before the domain
2019-03-28 23:20:41 -04:00
Adam Warner
a7f6c9b3a0
Ignore matches that start # using negative lookbehind
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk >
2019-03-29 00:08:04 +00:00
Mark Drobnak
5950b4bb78
Merge pull request #2646 from pi-hole/fix/FTL_arch_detect_rpm
...
Don't fail when trying to detect OS architecture on RPM-based systems
2019-03-24 15:23:05 -04:00
DL6ER
817b19888f
Merge branch 'development' into fix/FTL_arch_detect_rpm
2019-03-23 08:55:46 +01:00
Mark Drobnak
b64fb578fc
Merge pull request #2674 from NiGhTTraX/development
...
Fix uninstalling lighttpd when it's not installed
2019-03-15 22:11:34 -04:00
Andrei Picus
e9e92368b0
Fix uninstalling lighttpd when it's not installed
...
Signed-off-by: Andrei Picus <NiGhTTraX@users.noreply.github.com >
2019-03-15 15:05:58 +01:00
Dan Schaper
ffcb173a7f
Merge pull request #2672 from pi-hole/fix/test-version-pinning
...
Pin Python package versions to the versions in the last successful build
2019-03-15 07:04:40 -07:00
Mcat12
b9c9c2797f
Pin Python package versions to the versions in the last successful build
...
The last successful build was
https://travis-ci.org/pi-hole/pi-hole/builds/500825408
When `testinfra` became `2.0.0`, it removed the deprecated features that
the tests currently use.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-03-13 20:14:21 -07:00
Mark Drobnak
204a4e459b
Merge pull request #2637 from TheNoim/patch-1
...
Support pi hole behind a reverse proxy with ssl
2019-03-13 22:12:00 -04:00
DL6ER
0a53e966ea
Merge pull request #2659 from pi-hole/tweak/warn_if_FTL_not_on_master
...
Warn user during update if FTL is on a custom branch
2019-03-03 09:34:11 +01:00
DL6ER
2e17c23333
Don't warn if user is on development as this branch is constantly updated
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-03-02 16:40:59 +01:00
DL6ER
63f3381a2b
Warn user if FTL is not on branch master
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-03-02 16:36:49 +01:00
Mark Drobnak
2292720fed
Merge pull request #2650 from mmphego/patch-1
...
Update README.md
2019-03-01 13:19:31 -05:00
Mpho Mphego
b77efa521f
Update README.md
...
Removed the extra double quote.
Signed-off-by: Mpho Mphego <mpho112@gmail.com >
2019-03-01 09:38:36 +02:00
Mpho Mphego
cfe221706b
Update README.md
...
Changed badges from HTML code to markdown for consistency
Signed-off-by: Mpho Mphego <mpho112@gmail.com >
2019-02-27 09:57:23 +02:00
Dan Schaper
54ae9d83b0
Stickler-lints
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-02-23 13:42:15 -08:00
Dan Schaper
293e2a8e80
Merge pull request #2647 from pi-hole/feature/curl_debug
...
Use `curl` instead of `openssl` for debug upload.
2019-02-23 09:11:02 -08:00
Dan Schaper
71cd6c137b
Use curl instead of openssl for transmission of unmodified
...
log file. We want ansi color codes to be sent.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2019-02-23 04:13:44 -08:00
DL6ER
0e14d11a20
Merge branch 'development' into new/gravitydb
2019-02-22 23:06:17 +01:00
DL6ER
bbc392caeb
More review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-22 22:49:02 +01:00
DL6ER
61840edb30
Fill comment field with NULL (default) instead of empty string and use a variable for the timestamp instead of periodically calling date
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-22 22:46:19 +01:00
DL6ER
9867b7fccf
Don't fail when trying to detect OS architecture on RPM-based systems
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-22 18:41:01 +01:00
Mark Drobnak
58f198626a
Merge pull request #2640 from pi-hole/new/DebugAdditions
...
Add git status/diff to debug log
2019-02-18 19:28:21 -05:00
Adam Warner
a145f1d931
Be more verbose with debug script output
...
If output of `git status -s` is non-null display changes
if output of `git diff` is non-null, display diff
Signed-off-by: Adam Warner <adamw@rner.email >
2019-02-18 22:32:53 +00:00
Mark Drobnak
9748f19172
Merge pull request #2639 from pi-hole/hotfix/v4.2.2
...
Update development from hotfix/v4.2.2
2019-02-18 13:54:08 -05:00
DL6ER
ba1e94d3d9
Merge pull request #2626 from pi-hole/hotfix/v4.2.2
...
Pi-hole Core v4.2.2
2019-02-18 18:36:13 +01:00
Nils Bergmann
cd9fadbc44
Remove protocol determination
...
No protocol determination is neede, if you just use double slash.
Signed-off-by: Nils Bergmann <nilsbergmann@noim.io >
2019-02-16 15:32:56 +01:00
Mark Drobnak
062a180a1c
Merge pull request #2621 from cryptomilk/development-fix
...
A bunch of fixes for basic-install.sh
2019-02-10 20:06:26 -05:00
Andreas Schneider
860ec1a7c4
basic_install: Use install for sudoers
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-10 08:45:03 +01:00
DL6ER
5ca1bfc11c
Delete /dev/shm/FTL-* files on (re)start of pihole-FTL
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-08 15:00:35 +01:00
Andreas Schneider
2f189cd076
basic_install: There is no pihole group, remove it
...
Only a user has been created beforehand. Only some distributions create
a group with the same name based on their configuration. We cannot
assume this is always the default.
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-08 08:06:12 +01:00
Andreas Schneider
2f0e6a6dda
basic_install: Make sure the PI_HOLE_CONFIG_DIR exists
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-08 08:06:12 +01:00
Andreas Schneider
f187b42a98
basic_install: Define webroot globally as a variable
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-08 08:06:02 +01:00
DL6ER
f9250d91a5
Explictly escape the escape.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-06 19:17:13 +01:00
DL6ER
491c828661
Improved code, ensure that gravity.sh passes shellcheck as a whole
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-06 19:09:09 +01:00
DL6ER
644ec36e64
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-06 18:57:48 +01:00
Andreas Schneider
838e1b19ec
basic_install: Set permissons for PI_HOLE_DASHBOARD_DIR
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-06 10:41:37 +01:00
Andreas Schneider
d5bbb2b640
basic_install: Use a varibale for the pihole dashboard dir
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-06 10:40:47 +01:00
Andreas Schneider
dc91d4b1f9
basic_install: If a static interface is already set up we are done
...
Signed-off-by: Andreas Schneider <asn@cryptomilk.org >
2019-02-06 07:50:21 +01:00
DL6ER
9984647ebb
After renaming column in regex, it also needs to be renamed in vw_regex
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:41:11 +01:00
DL6ER
ec5b16ef85
Fix incomplete comment
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:08:08 +01:00
DL6ER
c3c60e10f1
Rename regex field from domain to filter because this described better what it is
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:07:12 +01:00
DL6ER
8a2363621d
Rename fields from DateAdded to dateadded
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:06:46 +01:00
DL6ER
dbbf21071b
Invert logic to use ENABLED instead of DISABLED. We make sure to set "enabled = 1 WHERE enabled IS NULL" in gravity_store_in_database()
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-05 19:05:11 +01:00
Dan Schaper
e967fe2266
Merge pull request #2612 from pi-hole/hotfix/v4.2.1
...
Remove user/group from dnsmasq config
2019-02-03 11:36:57 -08:00
Dan Schaper
b5c7657e01
Merge pull request #2614 from pi-hole/hotfix/v4.2.1
...
Merge v4.2.1 hotfix to dev
2019-02-03 11:36:00 -08:00
Mcat12
680d6e2d31
Merge branch 'release/v4.2' into development
...
# Conflicts:
# automated install/basic-install.sh
2019-02-03 11:14:09 -08:00
Mcat12
7a19d24058
Remove user/group from dnsmasq config
...
In the case that FTL is started under root, dnsmasq changes the user to
pihole due to this setting. The shared memory is created before this
switch, and may cause issues such as failing to delete or reallocate
the shared memory.
These config lines were necessary before dnsmasq became part of FTL, but
now since dnsmasq runs under FTL, we can configure the user/group
through FTL.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-02-03 10:55:18 -08:00
Dan Schaper
995ee41d6b
Merge pull request #2600 from pi-hole/release/v4.2
...
Release v4.2
2019-02-03 08:52:07 -08:00
DL6ER
b2f4385232
Avoid infinity loop if gravity optimization fails
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 17:05:00 +01:00
DL6ER
1f9a7d0b0c
Only run VACUUM on "pihole -g -o"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 17:01:38 +01:00
DL6ER
d5feffa117
Do not backup the database
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 16:45:19 +01:00
DL6ER
fc62cf7e2f
Only run VACUUM on "full" gravity runs
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 16:45:06 +01:00
DL6ER
93f1859bab
Store regex in gravity.db as well
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 15:13:18 +01:00
DL6ER
dcf0a605cf
Use views for all tables and set disabled column to false for those tables that support it
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 14:14:14 +01:00
DL6ER
710036adae
Add DISABLED field to white- and blacklist defaulting to false. The two views respect the DISABLED fields for both lists.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 13:34:08 +01:00
DL6ER
8a91fe6992
Store domains in gravit tables: gravity, whitelist, blacklist
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 13:21:26 +01:00
DL6ER
09c4c88a6d
Create and fill gravity.db during pihole -g
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-03 13:04:31 +01:00
Mark Drobnak
69919ac85c
Merge pull request #2610 from pi-hole/fix/dev-shm
...
Change /var/run/shm to /dev/shm
2019-02-02 13:44:39 -05:00
Mcat12
26f2410fe6
Change /var/run/shm to /dev/shm
...
The /var directory may not exist (does not exist on Fedora 29), and is
simply a symlink to /dev/shm.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-02-02 10:37:12 -08:00
Adam Warner
d43c32e9e8
Merge pull request #2609 from pi-hole/fix/start-service-ftl-checkout
...
Fix missed start_service -> restart_service call
2019-02-02 18:27:09 +00:00
Mcat12
5c4ee23795
Fix missed start_service -> restart_service call
...
start_service was changed to restart_service.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2019-02-02 10:19:44 -08:00
Dan Schaper
fb3d871553
Merge pull request #2602 from pi-hole/fix/download_FTL_earlier
...
Download FTL earlier in the installer
2019-02-02 06:43:16 -08:00
Adam Warner
ae654730c4
Update automated install/basic-install.sh
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
2019-02-02 08:00:58 +01:00
DL6ER
ec79e86bee
We should really use stop_service as it also includes some nice output
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-01 18:06:57 +01:00
DL6ER
e8dabc71af
Don't try to start pihole-FTL after it has been installed. This will be done a few moments later when gravity is invoked.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-01 17:54:21 +01:00
DL6ER
9c0de0f731
Try to stop pihole-FTL before and (re)start pihole-FTL after the install command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-02-01 17:39:12 +01:00
DL6ER
4948862dce
Fail hard if FTL binary could not be installed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-31 20:10:52 +01:00
DL6ER
7479485d45
Add test for the case the binary variable is unset (defaults to "tbd" in this case)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-31 20:00:26 +01:00
Mark Drobnak
1e284f69ea
Merge pull request #2587 from pi-hole/new/network-table
...
Download macvendor database
2019-01-28 20:27:13 -05:00
DL6ER
516ed83638
Add "|| true" to the curl command as a failed download is no show-stopper for the overall install process.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-28 20:48:30 +01:00
Mark Drobnak
26361883b4
Merge pull request #2601 from pi-hole/fix/double_disable_kills_gravity
...
Prevent double disabling/enabling
2019-01-27 13:54:33 -05:00
DL6ER
d26f2dcb2c
Use global binary variable in tests for automated install
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:47:28 +01:00
DL6ER
cc657c0c26
Rename subroutine start_service() to restart_service() because this is what it does
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:37:03 +01:00
DL6ER
d90d7b6927
Call FTL download/installation early on in the installation process.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:36:27 +01:00
DL6ER
de6dc90575
Don't diable pihole-FTL before calling install. root should be able to overwrite the binary in any case. The binary has already been downloaded and hash-verified here so we don't expect any errors in this binary.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:32:33 +01:00
DL6ER
3cdd6204c5
Move dnsmasq disabling and config file rewriting into a dedicated subroutine
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:31:02 +01:00
DL6ER
d996e9c9ee
Fix inconsistent handling of binary variable. get_binary_variable() stores the result into a global variable we pass later on as argument to FTLinstall() and define a local variable with the same name. This is fixed by only using the globa variable in all places not. This is still not a very elegant solution but it is also not subject of the current PR.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:28:09 +01:00
DL6ER
a4ba8d4b8f
Prevent double disabling/enabling by checking BLOCKING_ENABLED value in setupVars.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-24 09:16:24 +01:00
xch12i5
cd8a423b32
Solves RegEx issue and updates documentation.
...
Signed-off-by: xch12i5 <40517505+xCh12i5@users.noreply.github.com >
2019-01-20 16:09:25 +01:00
Mark Drobnak
f7ca74cf1d
Merge pull request #2598 from pi-hole/fix/remove-norton
...
Remove Norton DNS
2019-01-19 20:52:37 -05:00
Mark Drobnak
ebba32e1c4
Remove Norton DNS
...
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2019-01-19 20:45:19 -05:00
xch12i5
e02da90faa
Replaces double quotes by single quotes and updates documentation.
...
Signed-off-by: xch12i5 <40517505+xCh12i5@users.noreply.github.com >
2019-01-19 17:52:28 +01:00
xch12i5
0de5132e2b
Solves RegEx issue.
...
Signed-off-by: xch12i5 <40517505+xCh12i5@users.noreply.github.com >
2019-01-19 17:07:27 +01:00
Mark Drobnak
7d2507527a
Merge pull request #2593 from TheLastProject/feature/standardized-dns-list
...
Standardize DNS list and write to file for AdminLTE
2019-01-13 11:10:45 -08:00
Sylvia van Os
97decb3a73
Standardize DNS list and write to file for AdminLTE
...
Signed-off-by: Sylvia van Os <sylvia@hackerchick.me >
2019-01-13 19:38:04 +01:00
DL6ER
f360959efc
Download macvendor database from ftl.pi-hole.net when downloading a new FTL binary. Users who want to update the database more frequently than on each FTL release can use the python script from the FTL repository to generate the database themselves. The macvendor database is an optional component so a failing download is no reason to interrupt the installer.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-09 19:26:19 +01:00
Mark Drobnak
465589c0fd
Merge pull request #2575 from LudovicRousseau/fix2
...
Do not ask admin password just for help documentation
2019-01-07 00:07:53 -05:00
Mark Drobnak
9fcf7a2610
Merge pull request #2581 from bcambl/remove_bc_dep
...
remove unused dependency (bc)
2019-01-04 19:01:31 -05:00
bcambl
3035fbf468
remove unused dependency (bc)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2019-01-04 17:17:42 -06:00
DL6ER
c4c354bc4b
Merge pull request #2578 from pi-hole/new/libcap-dev
...
Add libcap as dependency
2019-01-03 16:08:45 +01:00
DL6ER
c5da1bb952
Add libcap as Fedora dependency
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-03 10:39:46 +01:00
DL6ER
486c41a69a
Add Debain dependency libcap2 needed for FTL's capability check on startup
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-03 10:39:10 +01:00
DL6ER
87800a3659
Merge pull request #2570 from pi-hole/tweak/wpad
...
Add wpad vulnerability fix as suggested by dnsmasq.conf.example
2019-01-03 00:10:31 +01:00
Ludovic Rousseau
d5fbe1b629
Do not ask admin password just for help documentation
...
It is not a good idea to ask for an admin password just to get the
command documentation.
"pihole -h" should return the arguments documentation with no need to
enter a password.
Without the patch I get:
$ ./pihole -h
Password:
It is easy to reproduce by invalidating the sudo password using
"sudo -k" before running pihole again.
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2019-01-02 23:54:30 +01:00
Mark Drobnak
a3cee67a61
Merge pull request #2571 from pi-hole/tweak/debug/shm
...
List content of /var/run/shm in debugger
2019-01-02 15:12:54 -05:00
DL6ER
5ffc8c7443
List content of /var/run/shm in debugger
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-01 17:56:02 +01:00
DL6ER
04fd296ffe
Add wpad vulnerability fix as suggested by dnsmasq.conf.example
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2019-01-01 17:13:43 +01:00
Mark Drobnak
262d5eea22
Merge pull request #2547 from pi-hole/fix/version-command-no-web
...
Don't show web version in pihole -v output if not installed
2018-12-27 23:20:16 -05:00
Mark Drobnak
ed5869646f
Use source instead of dot for setupVars
...
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2018-12-27 16:37:10 -05:00
Dan Schaper
b984fc4e0e
Merge pull request #2564 from floek/development
...
Add a blank after printf to avoid 'Command not found' error
2018-12-25 00:12:50 -08:00
Florian Freund
0ef4901e48
Add a blank after printf to avoid 'Command not found' error
...
> curl -L https://install.pi-hole.net | bash /dev/stdin --i_do_not_follow_recommendations
...
/dev/stdin: Zeile 2449: printf %b Skipping free disk space verification\n: Command not found.
Signed-off-by: Florian Freund <mail@floek.net >
2018-12-25 09:02:12 +01:00
Dan Schaper
8d85d46c1a
Merge pull request #2556 from pi-hole/release/v4.1.1
...
Release v.4.1.1
2018-12-21 09:06:19 -08:00
bcambl
eca975a370
add sqlite3 dependency for fedora
...
`sqlite3` is provided by the `sqlite` package on CentOS & Fedora
Signed-off-by: bcambl <blayne@blaynecampbell.com >
(cherry picked from commit 724afc000f )
2018-12-19 10:20:47 -08:00
Mark Drobnak
3bb94d469d
Merge pull request #2554 from bcambl/add_sqlite_dep
...
add sqlite3 dependency for fedora (#2552 )
2018-12-18 12:03:26 -05:00
bcambl
724afc000f
add sqlite3 dependency for fedora
...
`sqlite3` is provided by the `sqlite` package on CentOS & Fedora
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-12-17 21:03:54 -06:00
Mcat12
be2d494fcf
Don't show web version in pihole -v output if not installed
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-12-12 14:55:09 -05:00
Mark Drobnak
a36734db66
Merge pull request #2543 from pi-hole/fix/privacy-level-4
...
Add privacy level 4 to all privacy level code
2018-12-10 11:48:25 -05:00
Mcat12
1cad069050
Add privacy level 4 to all privacy level code
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-12-10 10:18:25 -05:00
Mark Drobnak
d24e0a6060
Merge pull request #2540 from pi-hole/release/v4.1
...
Update development with final v4.1 changes
2018-12-09 22:24:42 -05:00
Jacob Salmela
f65f793a0d
Merge pull request #2496 from pi-hole/release/v4.1
...
Release v4.1
2018-12-09 14:33:58 -06:00
Dan Schaper
f7ad489805
Merge pull request #2504 from bcambl/ifcfg_con_name
...
configure ifcfg network files by connection name when required
2018-12-08 10:44:45 -08:00
Dan Schaper
62459c4f00
Merge pull request #2532 from pi-hole/update/agent-string-12-2018
...
Update user agent string
2018-12-06 10:17:49 -08:00
DL6ER
05bd88b4d8
Update agent string: the selected string is the most abundant one on 06 Dec 2018 with a percentage of almost 10%
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-12-06 18:04:17 +01:00
Dan Schaper
0546fff1ce
Merge pull request #2531 from pi-hole/fix/duplicate_dont_destroy
...
Don't `mv` `preEventHorizon`, copy it.
2018-12-06 08:40:02 -08:00
Adam Warner
83f7bd66e6
Don't mv preEventHorizon, copy it.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-12-05 22:29:01 +00:00
bcambl
14ebb2fb93
remove 'System' from NetworkManager connection name
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-12-01 12:08:48 -06:00
Dan Schaper
916b2920be
Merge pull request #2525 from pi-hole/release/v4.1
...
Release/v4.1 to Development
2018-11-29 08:46:05 -08:00
Dan Schaper
a20963889c
Merge pull request #2512 from kefnab/development
...
Added check for universe repo on ubuntu bionic.
2018-11-27 03:35:28 -08:00
Dan Schaper
4b77475807
Merge pull request #2520 from pi-hole/new/rfc4039
...
Backend changes for DHCPv4 rapid commit support
2018-11-27 03:34:54 -08:00
Dan Schaper
9f672593bc
Update advanced/Scripts/webpage.sh
...
Co-Authored-By: DL6ER <DL6ER@users.noreply.github.com >
2018-11-26 20:01:41 +01:00
DL6ER
a285ae65fb
Backend changes for DHCPv4 rapid commit support
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-11-25 08:39:58 +01:00
Dan Schaper
917a0239a9
Merge pull request #2514 from pi-hole/fix/suppress_warnings_initd
...
Suppress warning if Pi-hole is not used as DHCP server
2018-11-21 13:47:16 -08:00
Clayton Dobbs
3261c2e273
Added check for universe repo on ubuntu bionic with user prompts.
...
Signed-off-by: Clayton Dobbs <clayton.dobbs@gmail.com >
2018-11-20 21:39:01 -07:00
DL6ER
d0125d5aad
Suppress warning if Pi-hole is not used as DHCP server (/etc/pihole/dhcp.leases is not present in this case)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-11-19 17:38:19 +01:00
Dan Schaper
65a3da92f1
Merge pull request #2505 from pi-hole/fix/DNS_with_hash
...
Account for non-standard ports in DNS server addresses.
2018-11-13 02:53:51 -08:00
Dan Schaper
5c621fa253
Lints
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-12 17:21:34 -08:00
Dan Schaper
f9e71bee0a
Account for port, or lack of, in PIHOLE_DNS_1
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-12 17:15:24 -08:00
bcambl
c3804877ed
linting: Double quote to prevent globbing and word splitting.
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-11-11 14:48:16 -06:00
Dan Schaper
35e53ab9c7
Merge pull request #2501 from pi-hole/fix/restart-dns-error-on-success
...
Fix restartDNS returning code 1 even when it worked
2018-11-10 10:10:49 -08:00
Dan Schaper
053987b9e1
Merge pull request #2500 from pi-hole/fix/debug-remove-dnsmasq
...
Remove dnsmasq checks from debugger
2018-11-10 10:10:05 -08:00
bcambl
c0bc93c7c4
break dhcpcd and ifcfg network configurations into separate functions
...
- move some logic from setStaticIPv4 to setDHCPCD
- breakout ifcfg configuration into separate function which takes a config path as an argument
- setStaticIPv4 now checks for configs and calls the appropriate function accordingly
- add logic to check ifcfg file by _connection name_ if file is not found by _interface name_
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-11-09 15:20:51 -06:00
Dan Schaper
1f596eb2bc
Merge pull request #2502 from pi-hole/release/v4.1
...
Release/v4.1 backports to development
2018-11-09 12:49:32 -08:00
Mcat12
3f59b51be1
Fix restartDNS returning code 1 even when it worked
...
If stdout was not a terminal (the `-t 1` check), `restartDNS` would
return code 1 in the success case. This caused the API to fail whenever
it tried to restart the DNS server.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-11-08 22:00:13 -05:00
Mcat12
9d59da8974
Remove dnsmasq checks from debugger
...
This also fixes an issue where the port checks weren't running
(`compare_port_to_service_assigned`).
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-11-08 21:51:21 -05:00
DL6ER
51218bd1ad
Merge pull request #2497 from pi-hole/fix/adlists.list_not_created
...
Bugfix for #2354
2018-11-08 20:37:28 +01:00
DL6ER
e1c3c53058
Merge branch 'release/v4.1' into fix/adlists.list_not_created
2018-11-08 20:29:07 +01:00
DL6ER
9fa497b056
Merge pull request #2498 from pi-hole/fix/IPv6_string
...
Change field from digit to string for printf
2018-11-08 20:28:24 +01:00
Dan Schaper
057fbfc2b9
Change field from digit to string for printf
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-08 11:10:09 -08:00
DL6ER
33156071cd
Fix literal "choice" being passed to appendToListsFile()
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-11-08 19:43:35 +01:00
Mark Drobnak
bbb759c684
Merge pull request #2477 from bcambl/debug_init_service_check
...
fix debug service check via sysvinit
2018-11-07 17:50:32 -05:00
Mark Drobnak
f1a7bc9ecd
Merge pull request #2481 from pi-hole/revert-2468-lighttpd-conf-enhancements
...
Revert "lighttpd conf enhancements"
2018-11-07 17:49:25 -05:00
Mark Drobnak
d514608f91
Merge pull request #2492 from pi-hole/fix/IPv4_detection
...
IPv4 detection improvements.
2018-11-07 17:48:34 -05:00
Dan Schaper
e8c2e26358
Override shellcheck with explanations.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-03 13:39:43 -07:00
Dan Schaper
61c67849d7
Support multiple distributions and release versions in find_IPv4_information().
...
Add basic sanity check to function, remove unused variable.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-03 13:20:40 -07:00
Mark Drobnak
2cdbb34763
Merge pull request #2488 from pi-hole/feature/command_function
...
Moved `command -v` calls to function in installer.
2018-11-02 22:16:44 -04:00
Dan Schaper
538ba918c1
Merge pull request #2490 from sadsfae/add_blog_guide_hobohouse
...
Add hobohouse blog/guide to coverage links.
2018-11-02 13:00:24 -07:00
Will Foster
c330df9700
Add hobohouse blog/guide to coverage links.
...
This is a link to an updated guide on setting up
Pi-hole on Raspberry Pi. It also covers using the Tomato
router firmware and running things in a docker container
along with some tips, blocklist recommendations and usage.
Signed-off-by: Will Foster <sadsfae@funcamp.net >
2018-11-02 19:50:39 +00:00
Mark Drobnak
1789a2db29
Merge pull request #2384 from pi-hole/feature/install-privacy-level
...
Set FTL Privacy Level During Install
2018-11-01 15:16:11 -04:00
Dan Schaper
c270b83341
Use printf instead of echo
...
Co-Authored-By: Mcat12 <mark.drobnak@gmail.com >
2018-11-01 15:14:26 -04:00
Dan Schaper
02f0788033
Moved command -v calls to function.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-01 12:00:08 -07:00
Dan Schaper
a2ea6e8d47
Merge pull request #2486 from pi-hole/feature/install_printf
...
Beginning steps to installer overhaul. Echos to Printf test.
2018-11-01 10:16:57 -07:00
Dan Schaper
a986f53134
Merge pull request #2436 from pi-hole/fix/password-read-error
...
Fix error when reading in new password
2018-11-01 07:05:27 -07:00
Dan Schaper
9d2d45b473
Query php directly for major and minor version id strings.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-11-01 05:59:14 -07:00
Dan Schaper
0c892e6b3a
Addressed Stickler ShellCheck lints
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-10-31 14:35:55 -07:00
Dan Schaper
a0fc38d6a2
All terminal echo commands changed to printf.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-10-31 11:14:05 -07:00
Mcat12
28cbf45d1d
Add explanatory comment for include_shell
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-10-30 21:52:42 -04:00
Dan Schaper
72829be281
Remove shellcheck overrides
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-10-26 12:14:10 -07:00
Adam Warner
d57f9906bd
read -r -a, not read -a -r
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-10-26 19:24:43 +01:00
Adam Warner
3d4fea6510
Move -r to before the -p
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-10-26 19:17:49 +01:00
Adam Warner
f670644954
Revert "lighttpd conf enhancements"
2018-10-26 19:12:11 +01:00
Mark Drobnak
dd6821814a
Merge pull request #2479 from pi-hole/fix/referral-readme
...
update broken link, add coverage, and fix formatting
2018-10-25 17:09:30 -04:00
Jacob Salmela
f33584511c
update broken link, add coverage, and fix formatting
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-10-25 05:58:17 -05:00
bcambl
3ec84553ef
fix debug service check via sysvinit
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-10-24 10:06:11 -06:00
Mark Drobnak
a301d4381f
Merge pull request #2472 from pi-hole/fix-webpwexpansion
...
Prevent BASH from expanding Web Password
2018-10-22 22:18:32 -04:00
Mark Drobnak
49b8ad7e94
Merge pull request #2470 from jeremysherriff/patch-1
...
Silence updateGravity cron job unless errors occur
2018-10-21 14:04:39 -04:00
WaLLy3K
180d29c7b3
Prevent BASH from expanding Web Password
...
* Resolves issue #2471
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2018-10-21 11:08:22 +11:00
Mark Drobnak
a23ba91681
Merge pull request #2468 from gstrauss/lighttpd-conf-enhancements
...
lighttpd conf enhancements
2018-10-20 16:43:03 -04:00
jeremysherriff
d986da63a5
Pass gravity exit code back to caller to allow for cron error handling
...
Signed-off-by: jeremysherriff <jeremysherriff@gmail.com >
2018-10-19 19:10:37 +13:00
jeremysherriff
d3ac8bb6f8
Silence updateGravity job unless errors occur
...
No need for append/logrotate as we are only interested in the latest output
Signed-off-by: jeremysherriff <jeremysherriff@gmail.com >
2018-10-19 19:10:13 +13:00
Mark Drobnak
f87f3b9199
Merge pull request #2467 from pi-hole/fix/dnsmasq-license
...
Update dnsmasq config license
2018-10-17 11:56:41 -04:00
Glenn Strauss
67bdcbcf19
lighttpd: slightly more efficient sample config
...
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2018-10-17 06:54:54 -04:00
Glenn Strauss
69b2a5a876
lighttpd: use file glob for optional external.conf
...
lighttpd 1.4.50 config parse will error if include_shell exits non-zero
and pi-hole sample config: include_shell "cat external.conf 2>/dev/null"
is an error if external.conf does not exist
Replace with: include "external*.conf"
file glob supported since lighttpd 1.4.40 and is not an error if there
is no file which matches the file glob
Signed-off-by: Glenn Strauss <gstrauss@gluelogic.com >
2018-10-17 06:54:43 -04:00
Mark Drobnak
a79dff3d98
Merge pull request #2466 from pi-hole/readme-newcoverage
...
Update coverage links
2018-10-16 22:42:34 -04:00
Dan Schaper
c859a23136
Merge pull request #2462 from pi-hole/fix/updatecheck-curl-silent
...
Use curl -s instead of -q
2018-10-16 18:46:45 -07:00
WaLLy3K
7f92671765
Update dnsmasq config license
...
* Also updated "separate config" text
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2018-10-17 11:01:28 +11:00
WaLLy3K
ec38105b08
Update coverage links
...
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2018-10-17 10:46:56 +11:00
Mark Drobnak
85dceb12a1
Use curl -s instead of -q
...
See #2416
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2018-10-12 23:53:21 -04:00
Mark Drobnak
5126c37c1e
Merge pull request #2460 from bcambl/fix_create_pihole_user
...
fix pihole user creation function
2018-10-12 22:47:56 -04:00
bcambl
e7e03e36de
fix pihole user creation function
...
- fix stdout newlines
- catch failed user creation
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-10-12 11:05:44 -06:00
Mark Drobnak
13c393fc9d
Merge pull request #2451 from pi-hole/fix/2450
...
fix for #2450
2018-10-07 21:02:39 -04:00
Adam Warner
cc2f375b13
fix for #2450
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-10-07 11:51:36 +01:00
Mark Drobnak
49d5109c96
Merge pull request #2446 from AndreasElia/development
...
Readme grammar fixes
2018-10-02 21:59:35 -04:00
Andreas Elia
e5c8f5e2fa
Readme grammar fixes
...
Signed-off-by: Andreas Elia <andreaselia@live.co.uk >
2018-10-02 17:43:13 +01:00
Mark Drobnak
ff925a7578
Merge pull request #2437 from pi-hole/fix/version-files-overwritten
...
Append versions (after the first) instead of overwriting in updatecheck
2018-10-01 11:21:29 -04:00
Mark Drobnak
33939a30ea
Merge pull request #2347 from Gusher123/patch-1
...
Don't let one blocklist block an other blocklist
2018-09-30 21:24:45 -04:00
Mark Drobnak
308b296285
Merge pull request #2401 from pi-hole/fix/checkout-readonly
...
Fix checkout error due to readonly variable
2018-09-30 21:05:11 -04:00
Mcat12
d55012f724
Append versions (after the first) instead of overwriting in updatecheck
...
Fixes an issue brought up in #2435
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-09-30 20:56:44 -04:00
Mcat12
7c6eecc9c8
Ignore shellcheck warning
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-09-30 18:16:08 -04:00
Mcat12
e4cbf5023a
Fix error when reading in new password
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-09-30 18:09:59 -04:00
Mark Drobnak
46356d3027
Merge pull request #2434 from pi-hole/fix/2200
...
Only check web versions if web interface is installed
2018-09-30 17:57:54 -04:00
Mark Drobnak
958a263437
Merge pull request #2431 from pi-hole/fix/use_PHP_comments_in_pihole-FTL.conf_template
...
Improve pihole-FTL.conf template
2018-09-30 17:24:36 -04:00
Mark Drobnak
a89ae82270
Merge pull request #2430 from pi-hole/chrono-lc-all
...
Fix invalid numbers in Chronometer
2018-09-30 17:23:06 -04:00
Mark Drobnak
cedc39bf09
Merge pull request #2426 from mrmajik45/master
...
Read without -r will mangle backslashes. (Fix)
2018-09-30 17:19:56 -04:00
Adam Warner
0131055ec9
Submission stale, addressing @mcat12's comments
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-09-30 20:00:06 +01:00
Adam Warner
0627e68078
Shellcheck is not a fan of sourcing scripts it does not know about. Add Directive to stop shellcheck from checking this.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-09-30 19:45:04 +01:00
Adam Warner
7d78f6314a
Source Setupvars file and only check local/remote Web branch/version if the web interface is installed.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-09-30 19:41:04 +01:00
mrmajik45
0f509f4a34
Update piholeDebug.sh
2018-09-28 17:22:31 -04:00
DL6ER
b043000044
Improve template by removing it. PHP cannot digest comments starting in "#" as of v7.0.0
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-09-28 12:08:39 +02:00
DL6ER
c338eab3c6
According to the PHP documentation, PHP 7.0.0+ does not longer recognize hash marks (#) as comments. As FTL has been trained to understand PHP-style (comment lines start with ";") as well, we switch to using them.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-09-28 11:11:30 +02:00
WaLLy3K
24e1dc92ba
Resolve issue #2428
...
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2018-09-28 10:34:49 +10:00
mrmajik45
00f98543ad
read without -r will mangle backslashes.
2018-09-26 10:32:22 -04:00
mrmajik45
8684356b44
read without -r will mangle backslashes.
2018-09-26 10:31:44 -04:00
Mark Drobnak
a89615365e
Merge pull request #2410 from stuartskelton/norton_dns_EOL_2018_11_15
...
Remove Norton Connect Safe as its EOL 2018-11-15
2018-09-10 17:52:09 -04:00
Stuart Skelton
3c36c22ca8
Remove Norton Connect Safe as its EOL 2018-11-15
...
Signed-off-by: Stuart Skelton <stuarts@broadbean.com >
2018-09-10 22:37:45 +01:00
Mark Drobnak
7a2f5f43f9
Merge pull request #2408 from pi-hole/fix/2299
...
Only get the first gateway for chronometer
2018-09-09 16:38:05 -04:00
Mark Drobnak
dac27f1f18
Only get the first gateway for chronometer
...
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2018-09-09 15:12:48 -04:00
Mark Drobnak
6f276ae4bb
Merge pull request #2299 from nullr0ute/net-tools
...
Use ip route rather than old net-tools route in chronometer.sh
2018-09-09 15:11:19 -04:00
Mark Drobnak
537e288758
Merge pull request #2407 from pi-hole/fix/lighttpd-external-conf
...
Fix lighttpd v1.4.50 crashing on startup
2018-09-07 12:55:21 -04:00
Mark Drobnak
3cea1bd423
Fix lighttpd v1.4.50 crashing on startup
...
It has a bug/regression causing it to fail if external.conf does not exist,
so touch external.conf when installing lighttpd config
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2018-09-07 12:09:37 -04:00
Mark Drobnak
c976bbcfd2
Fix checkout error due to readonly variable
...
Signed-off-by: Mark Drobnak <mark.drobnak@gmail.com >
2018-09-01 22:11:45 -04:00
Mark Drobnak
ec29829550
Merge pull request #2388 from Sh4d1/ipv6_brackets
...
Remove external Ipv6 brackets in servername if any
2018-09-01 19:44:29 -04:00
Mark Drobnak
cf7180af5b
Merge pull request #2398 from pi-hole/rpm_distro_checks
...
WIP: Update RPM distro checks
2018-08-31 12:54:55 -04:00
bcambl
c58e3acc78
add unsupported RPM distro warnings
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-08-31 10:04:52 -06:00
DL6ER
b78aef1e7e
Merge pull request #2356 from pi-hole/tweak/reload_on_enable_disable
...
Change the enable/disable method
2018-08-30 22:37:57 +02:00
DL6ER
f20e4ddf3b
Change message for unknown state to something more useful
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-30 22:28:15 +02:00
DL6ER
40656641b6
Merge branch 'development' into tweak/reload_on_enable_disable
2018-08-30 22:26:57 +02:00
bcambl
6f8e8e98bb
update centos version check test
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-08-29 22:16:11 -06:00
bcambl
24b4aabae9
allow installer to continue with additional rpm based distros
...
- FedBerry (Fedora based ARM image)
- Scientific Linux (CentOS based)
- Add prompt to continue installing on unsupported RPM based distros
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-08-29 20:49:06 -06:00
Mark Drobnak
a9c6d79cda
Merge pull request #2394 from pi-hole/fix/pihole-FTL_owner_group
...
Ensure proper unprivileged user if pihole-FTL is started as root
2018-08-29 11:17:39 -04:00
DL6ER
45bf4b02e7
Ensure that when pihole-FTL is launched as user root, it will drop permissions as soon as this is possible. We tell pihole-FTL to change UID/GID to pihole:pihole instead of the default nobody:nogroup. This default causes conflicts with our SQLite3 database. See that corresponding pull request for further details.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-27 16:51:33 +02:00
Mark Drobnak
667c5138cc
Merge pull request #2381 from pi-hole/fix/existing_dnsmasq.conf
...
Improve /etc/dnsmasq.conf handling
2018-08-25 18:55:12 -05:00
Patrik Cyvoct
85cf98888d
Merge remote-tracking branch 'origin/development' into ipv6_brackets
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io >
2018-08-22 09:31:54 +02:00
Patrik Cyvoct
048e5bb9a2
Remove external ipv6 brackets if any in servername
...
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io >
2018-08-22 09:11:55 +02:00
DL6ER
b9d47d0dd2
Merge pull request #2378 from pi-hole/fix/pihole-FTL-no-caps
...
Start pihole-FTL as root if capabilities are not supported by the system
2018-08-21 14:11:24 +02:00
DL6ER
1813c25117
If config file was backed up: Print info message
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-21 13:07:23 +02:00
DL6ER
940c9c3bae
Merge pull request #2383 from pi-hole/feature/privacy-level-4
...
Add support for privacy level 4
2018-08-21 13:03:41 +02:00
Mcat12
5d0d7336ff
Echo with newline when setting privacy level
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-08-20 20:21:03 -04:00
Mcat12
6a26a05dbf
Fix privacy level whiptail option format
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-08-20 19:40:43 -04:00
Mcat12
c22e94c9c7
Update test to include empty FTL config
...
The installer ensures that an FTL config will exist, and creates an
empty file if it doesn't.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-08-20 19:33:15 -04:00
Mcat12
4aafa8cf47
Set the FTL privacy level during install
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-08-20 19:20:29 -04:00
Mark Drobnak
9235a11d5f
Merge pull request #2382 from pi-hole/tweak/no-extra-logging
...
Don't use extra query logging
2018-08-20 18:33:42 -04:00
Mcat12
f141b9f778
Add support for privacy level 4
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-08-20 17:36:16 -04:00
DL6ER
1dca1efbc6
Don't use extra query logging
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-20 23:11:23 +02:00
DL6ER
28c6b1393f
Backup existing /etc/dnsmasq.conf if present and ensure that /etc/dnsmasq.conf contains only "conf-dir=/etc/dnsmasq.d"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-20 22:52:22 +02:00
DL6ER
6c97b8b875
Merge pull request #2377 from pi-hole/fix/service-touch-leases
...
Touch dhcp.leases to ensure it exists
2018-08-20 11:24:44 +02:00
DL6ER
ec2426b24d
Add clarifying comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-19 19:55:47 +02:00
DL6ER
5cd3b11391
Start pihole-FTL as root if capabilities are not supported by the system
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-19 14:32:19 +02:00
DL6ER
d30b565d98
Touch dhcp.leases to ensure it exists. There are some systems out there where the installer didn't finish on the first run and some users don't have this file being created. Although /etc/pihole should be owned by pihole:pihole, pihole-FTL sometimes fails to open this file and - if this is the case and DHCP is enabled - refuses to start altogether.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-19 13:53:34 +02:00
Mark Drobnak
74008d28a7
Merge pull request #2367 from realtebo/fix-enabling-ftl
...
Fix to enable pihole-FTL service before starting it
2018-08-16 16:15:46 -04:00
Realtebo
0d1b3cee4f
Enable FTL service before starting it
...
Signed-off-by: Realtebo <mirkotebaldi@yahoo.it >
2018-08-16 17:52:47 +02:00
Realtebo
0b44cb4426
Merge branch 'development' of https://github.com/pi-hole/pi-hole into development
2018-08-16 17:48:35 +02:00
Mark Drobnak
eb8e4496b2
Merge pull request #2354 from realtebo/development
...
Create adlist file while running unattended setup
2018-08-16 11:26:07 -04:00
Realtebo
30f45d4df7
Merge branch 'development' of https://github.com/pi-hole/pi-hole into development
2018-08-16 16:52:18 +02:00
Mark Drobnak
24e1c78d52
Merge pull request #2358 from pi-hole/fix/restart_FTl_on_logflush
...
Restart pihole-FTL after log flushing
2018-08-16 10:34:25 -04:00
Mirko Tebaldi
476fecbcf5
Fixed typos as suggestes
...
Signed-off-by: Realtebo <mirkotebaldi@yahoo.it >
2018-08-14 15:04:42 +02:00
Mirko Tebaldi
327b58fa03
Merge pull request #1 from pi-hole/development
...
Merge with current main development branch
2018-08-14 14:55:18 +02:00
DL6ER
d3eea9404d
Merge pull request #2331 from pi-hole/tweak/improve_FTL_download_errormsg
...
Improve error message when downloading FTL failed
2018-08-14 13:20:47 +02:00
DL6ER
ca309d3b28
Restart pihole-FTL after log flushing to force reloading history. Fixes #2339
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-14 13:16:17 +02:00
DL6ER
0ebd68f17f
Review comments
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-14 09:55:16 +02:00
Mark Drobnak
3696373609
Merge pull request #2345 from pi-hole/NXDOMAIN-tail
...
Fix colour tail for use with new blocking methods
2018-08-13 15:01:35 -04:00
DL6ER
165affc39b
list.sh writes into blacklist.txt not black.list so does not need to account for a possibly changed list location
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 18:53:31 +02:00
DL6ER
f794018e0c
Acknowledge temporary file if disabled for "pihole -b" command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 18:17:14 +02:00
DL6ER
337cc5ca18
BLOCKING -> BLOCKING_ENABLED
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 17:22:10 +02:00
DL6ER
4e4d6b5d1f
Adjust "pihole status" command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 15:02:00 +02:00
DL6ER
b011adc453
Use new setupVars BLOCKING variable to determine which file to update via gravity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 14:19:59 +02:00
DL6ER
d8abc1d266
Storing BLOCKING=true/false in setupVars.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 13:49:47 +02:00
DL6ER
6cde066edd
Have gravity detect the presence of files like gravity.list.bck and update this file if present (assuming blocking is disabled)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-13 13:43:14 +02:00
WaLLy3K
d163e38380
Ensure regex-blocked lines are red
...
* Add `regex.list` to seds list
Signed-off-by: WaLLy3K <wally3k@pihole.net >
2018-08-13 14:56:38 +10:00
Realtbo
d9195970b7
Create adlist file while running unattended setup
...
Signed-off-by: Realtebo <mirkotebaldi@yahoo.it >
2018-08-12 23:21:01 +02:00
DL6ER
20b946eae5
Instead of changing the dnsmasq configuration, we replace gravity.list and black.list by empty files for disabling. When pihole-FTL receives SIGHUP, it will clear its cache and reload all configured lists. If the files are empty, blocking will be disabled as no content to be blocked will be imported.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-12 19:31:00 +02:00
DL6ER
c00357663b
Reload pihole-FTL instead of restart the entire service on "pihole enable/disable"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-12 19:17:20 +02:00
Gusher123
2feb5f22cc
Signed-off-by
...
This is my commit message
Signed-off-by: Gusher123 <t.siebeling@gmail.com >
2018-08-12 10:05:58 +02:00
Gusher123
f3aee056ad
Merge branch 'patch-1' of https://github.com/Gusher123/pi-hole into patch-1
2018-08-12 09:59:34 +02:00
Gusher123
91ff5ca0ca
Merge branch 'patch-1' of https://github.com/Gusher123/pi-hole into patch-1
...
Signed-off-by: Gusher123 <t.siebeling@gmail.com >
2018-08-12 09:58:45 +02:00
Gusher123
4238e36d7f
Merge branch 'patch-1' of https://github.com/Gusher123/pi-hole into patch-1
2018-08-12 03:07:07 +02:00
Gusher123
03a9d3bc5b
Not hardcoding dns and covering all blockingmodes
...
Using double brackets
Mode double brackets
2018-08-12 03:05:53 +02:00
Gusher123
fe46dee194
Mode double brackets
2018-08-12 02:06:32 +02:00
Gusher123
1c6c35f861
Using double brackets
2018-08-12 01:50:23 +02:00
Gusher123
926b25fd54
Not hardcoding dns and covering all blockingmodes
2018-08-12 01:15:42 +02:00
Gusher123
e58142b4ac
Added comments
2018-08-11 15:14:45 +02:00
Gusher123
3e5c6afaee
Don't let one blocklist, block an other
...
If a blocklist is blocked by an other and 'pihole -g' is run, update the blocked blocklist by useing an alternate dns server (in this case 1.1.1.1) to acquire the IP adres and download the blocklist using the 'curl --resolve' (https://curl.haxx.se/docs/manpage.html#--resolve )
2018-08-11 14:33:33 +02:00
WaLLy3K
a1bf9fad98
Fix colour tail for use with new blocking methods
...
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2018-08-11 12:55:18 +10:00
Mark Drobnak
afdc4219d0
Merge pull request #2343 from pi-hole/tweak/audit_log
...
Add facility to add multiple audit list entries at once and to nuke audit list
2018-08-10 18:06:23 -04:00
DL6ER
94e4ed6644
Add facility to add multiple audit list entries at once and to nuke audit list
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-10 18:22:55 +02:00
Mark Drobnak
ef8aaba014
Merge pull request #2320 from TronPaul/fix/no-tty
...
set noninteractive during unattended install
2018-08-08 19:28:12 -04:00
Mark Drobnak
d2ae07e69b
Merge pull request #2334 from pi-hole/fix/gravity-count-regex
...
Fix gravity's regex counting logic
2018-08-08 16:22:50 -04:00
DL6ER
760dd01b50
Use grep invert-match
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-07 18:36:06 +02:00
DL6ER
5bf90cb77d
Use alternative logic for counting regex file entries, skipping commented out lines
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-07 18:02:01 +02:00
DL6ER
f5c3dc5d9d
Improve download error message that is shown when downloading or verifying the binary failed
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-08-07 16:51:58 +02:00
DL6ER
f2b820079a
Merge pull request #2329 from pi-hole/tweak/remove-ppc
...
Remove PowerPC from FTL binaries
2018-08-07 16:02:11 +02:00
WaLLy3K
083024496a
Merge pull request #2327 from pi-hole/header-fix
...
Fix Chronometer heading
2018-08-07 12:29:45 +10:00
Mcat12
e01eea8ba8
Remove PowerPC from FTL binaries
...
It is no longer built, and may cause 404 errors if it attempts to
download the binary.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-08-06 21:15:16 -04:00
WaLLy3K
eef948d797
Fix header newlines
...
* Added \\n to each $xxx_ver_str, resolving issue #2325
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2018-08-07 10:45:30 +10:00
DL6ER
8017be7d09
Merge pull request #2322 from pi-hole/release/v4.0
...
Git Flow - Release/v4.0 merge back to development.
2018-08-06 09:57:28 +02:00
Dan Schaper
5b628a4c77
Merge branch 'development' into release/v4.0
2018-08-05 21:16:19 -07:00
Dan Schaper
ddbdb51d20
Merge pull request #2308 from pi-hole/release/v4.0
...
Release/v4.0
2018-08-05 10:40:22 -07:00
Mark McGuire
0081a7ca92
set noninteractive during unattended install
...
Signed-off-by: Mark McGuire <mark.b.mcg@gmail.com >
2018-08-05 10:12:43 -05:00
Dan Schaper
e80ae4906f
Merge pull request #2318 from pi-hole/tweak/wildcard-regex-format
...
Use simpler regex format for wildcards
2018-08-01 01:01:08 -07:00
Mcat12
e4e22fb58e
Fix permissive regex
...
The `\.?` is too permissive, letting in anything that ends in the domain
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-31 22:16:40 -04:00
Mcat12
7086a400e8
Use simpler regex format for wildcards
...
Use `\.?domain\.com$` instead of `((^)|(\.))domain\.com$`
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-31 21:36:29 -04:00
Mark Drobnak
a25a13fde0
Merge pull request #2317 from pi-hole/fix/parse_pihole-FTL.conf
...
Add empty pihole-FTL.conf file
2018-07-31 19:51:34 -04:00
Dan Schaper
993beab3b7
Changed wording.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-31 11:14:26 -07:00
Dan Schaper
06875f2cc9
Merge branch 'release/v4.0' into fix/parse_pihole-FTL.conf
2018-07-30 14:32:29 -07:00
Dan Schaper
448fc7231c
Installed to /etc/pihole as PI_HOLE_CONFIG_DIR variable.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-30 14:26:07 -07:00
Dan Schaper
d0d030bafc
Moved file creation to proper function. Included bash variables for file
...
location. Set to pihole:pihole ownership with 644 permissions.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-30 14:02:18 -07:00
Dan Schaper
833131e15f
Merge pull request #2315 from pi-hole/fix/regex-file-ownership
...
Allow PHP to edit the regex file if web is installed
2018-07-30 06:36:20 -07:00
Dan Schaper
fb2810557a
Allow web user group to access regex.list
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-29 16:09:03 -07:00
Dan Schaper
82a64db42b
Merge pull request #2313 from pi-hole/fix/pihole-man-usage
...
Fix wildcard/regex usage formatting
2018-07-29 15:43:19 -07:00
Mcat12
57af0ba0a4
Use install to make the regex file
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-29 18:26:00 -04:00
Dan Schaper
17c1e64f7e
Moved FTL configuration copy in to scripts copy function.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-29 09:06:51 -07:00
Dan Schaper
af13ceac24
Touch file as ${USER} instead of copying template.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-29 08:42:59 -07:00
Dan Schaper
af2ec61965
Convert [] to ()
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-29 08:17:57 -07:00
Mcat12
a55cc55338
Only touch the regex file if it doesn't already exist
...
The other permission calls will always be run so that the file is in the
expected state after install and repair.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-28 23:07:35 -04:00
Dan Schaper
b2fb3fd35a
Merge pull request #2310 from pi-hole/feature/pihole-FTL.conf
...
Include template pihole-FTL.conf
2018-07-28 20:04:39 -07:00
Dan Schaper
94b7c8eb59
Added header for file. Not using standard Pi-hole copyright header.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-28 19:58:23 -07:00
Dan Schaper
6d671007dd
Merge pull request #2314 from pi-hole/fix/ftl-install-error-output
...
Fix FTL install leaking error output
2018-07-28 19:53:04 -07:00
Mcat12
1a8d5fb4a9
Allow PHP to edit the regex file if installed
...
Fixes permissions error on the web interface when modifying the regex.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-28 21:57:39 -04:00
Dan Schaper
f90c412b35
nroff checked pihole.8 for formatting. nroff -man pihole.8
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-28 18:28:25 -07:00
Mcat12
c73b5456eb
Fix "which" error leaking
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-28 21:12:05 -04:00
Mcat12
3d87398721
Fix check_service_active leaking error output
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-28 20:50:04 -04:00
Mcat12
96681887b8
Fix wildcard/regex usage formatting
...
Fix whitespace issue and missing backslashes in the regex example.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-28 20:35:15 -04:00
Dan Schaper
f2c675cff6
Formatted pihole-FTL.conf for readability.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-28 16:16:16 -07:00
Dan Schaper
1844bf17a7
Merge pull request #2311 from pi-hole/fix/git-head-flag
...
Fix wrong git command flag
2018-07-28 10:48:29 -07:00
Mark Drobnak
47b56d6123
Fix wrong git command flag
...
I could not find documentation on a `--head` flag, but there is a `--heads` flag which does the same thing.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-27 23:27:44 -04:00
Mark Drobnak
814d5f6d6c
Merge pull request #2307 from borats/development
...
Change the word "folder" to "directory" since the pi-hole is intended…
2018-07-27 22:36:20 -04:00
Dan Schaper
512d2dd5f8
Source git repo and not /opt location.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-27 15:47:20 -07:00
Dan Schaper
ad20d5ac1c
Remove -t SOURCE and DIRECTORY reversal flag on install.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-27 15:39:37 -07:00
Dan Schaper
b79ff05e29
Move template files to own subdir. Include pihole-FTL.conf in templates.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-27 15:21:25 -07:00
Borats Nolan
32b50f8188
Change the word "folder" to "directory" since the pi-hole is intended to run on rpi with Linux on it.
...
Signed-off-by: Borats Nolan <borats@i.dont.use.email >
2018-07-28 02:35:39 +10:00
Dan Schaper
a44096a26d
Merge pull request #2303 from pi-hole/development
...
Update release/v4.0 with latest development changes
2018-07-26 22:30:51 -07:00
Dan Schaper
32cf94fc74
Merge pull request #2297 from pi-hole/bugfix/locales
...
Fixed locale issue, do not parse for string.
2018-07-26 16:44:52 -07:00
Dan Schaper
39e28cd80a
Merge pull request #2302 from pi-hole/revert/2282
...
Revert #2282
2018-07-26 16:38:44 -07:00
Adam Warner
9b1356ad01
Revert #2282
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-07-27 00:27:06 +01:00
Peter Robinson
45521b377a
Use ip route rather than old net-tools route in chronometer.sh
...
The only use of net-tools is the use of route in chronometer.sh so
instead use the same method as used in piholeDebug.sh to get the
default gateway so there's no need to depend on net-tools anylonger.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com >
2018-07-26 17:46:51 +01:00
Dan Schaper
46a366635c
Fixed locale issue, do not parse for string.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-26 05:30:05 -07:00
Dan Schaper
384b588a2d
Merge pull request #2291 from pi-hole/merge/FTLDNS-to-development
...
Fix merge conflict in #2276
2018-07-24 11:51:56 -07:00
Mcat12
03e5a78d8f
Merge remote-tracking branch 'origin/FTLDNS' into development
...
# Conflicts:
# advanced/Scripts/piholeDebug.sh
2018-07-22 15:18:26 -04:00
Dan Schaper
e32c76b059
Merge pull request #2289 from pi-hole/feature/space_tab
...
Adjusting spacing for utility scripts.
2018-07-20 19:23:50 -07:00
Dan Schaper
ba7782f867
Space/Tab piholeDebug.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 15:25:35 -07:00
Dan Schaper
c5091b0e49
Space/Tab wildcard_regex_converter.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 14:00:34 -07:00
Dan Schaper
b54e32f0ca
Space/Tab webpage.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:57:15 -07:00
Dan Schaper
328e7738d5
Space/Tab version.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:27:30 -07:00
Dan Schaper
aca359c2e2
Space/Tab updatecheck.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:24:05 -07:00
Dan Schaper
1cd40dc9e5
Space/Tab update.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:22:37 -07:00
Dan Schaper
dc9407281f
Space/Tab setupLCD.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:17:10 -07:00
Dan Schaper
8f727c1f35
Space/Tab query.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:13:42 -07:00
Dan Schaper
a08ea28feb
Space/Tab piholeLogFlush.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 13:07:54 -07:00
Dan Schaper
c5535dd9a0
Space/Tab piholeCheckout.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 12:54:24 -07:00
Dan Schaper
3519cc5e44
Space/Tab list.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 12:42:11 -07:00
Dan Schaper
d251bbbb05
Space/Tab chronometer.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 12:29:09 -07:00
Dan Schaper
1fc3ec9029
Merge pull request #2287 from pi-hole/feature/clean_comments
...
Remove empty comment lines in basic-install.sh
2018-07-20 11:37:15 -07:00
Dan Schaper
1877128fc4
Removes empty comment lines in basic-install.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-20 10:38:13 -07:00
Dan Schaper
76c5b4a06b
Merge pull request #2118 from pi-hole/fix/debug-shellcheck
...
fix some shellcheck/stickler compaints in debug script
2018-07-19 05:18:40 -07:00
Mark Drobnak
9cd674b528
Merge pull request #2282 from RamSet/tweak/Port53
...
Updated port 53 check #2
2018-07-18 22:56:33 -04:00
RamSet
5aea7eb860
corrected function indentation
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-07-17 20:46:18 -06:00
Mark Drobnak
ec30df2020
Merge pull request #2277 from bcambl/centos_fedora_fixes
...
Installer fixes for Fedora & CentOS
2018-07-17 22:06:25 -04:00
RamSet
bb33427c79
fixed parsing error
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-07-17 18:09:25 -06:00
RamSet
28a16cebda
Addressed lint errors.
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-07-17 18:06:32 -06:00
RamSet
49c79405bc
changed flag and variable name
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-07-17 18:04:50 -06:00
RamSet
3098f32a07
Fixed intentation and corrected comments.
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-07-17 17:56:13 -06:00
Dan Schaper
b1e9c05bee
Merge pull request #2284 from pi-hole/bugfix/source_webpage
...
Added missing `.` for sourced file.
2018-07-17 06:38:32 -07:00
Dan Schaper
69e06d89ff
Added missing for sourced file.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-07-16 22:36:58 -07:00
RamSet
56b04017e7
Port 53 check updated with 4 spaces.
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-07-16 11:29:12 -06:00
RamSet
3af61c031d
Merge pull request #1 from pi-hole/development
...
Development
2018-07-16 11:20:49 -06:00
Dan Schaper
f42a57088f
Merge pull request #2280 from rrobgill/development
...
Add regex option to autocomplete
2018-07-16 09:34:22 -07:00
WaLLy3K
4834452875
Merge pull request #2278 from pi-hole/fix/missing-wildlist-help-and-double-dash
...
Add back --wild list.sh help and use -- for long params like --regex
2018-07-16 14:55:05 +10:00
Rob Gill
c5b9d99b48
Add regex option to autocomplete
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-07-16 10:50:05 +10:00
Mcat12
f8d4c36f6d
Add back --wild list.sh help and use -- for long params like --regex
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-15 18:59:25 -04:00
bcambl
fa9ecbdb81
add php-json to Fedora web deps
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-15 15:41:04 -06:00
bcambl
2bf6b29b8f
trigger an install/upgrade of PHP after enabling the Remi repository
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-15 15:40:44 -06:00
Dan Schaper
25812f88f6
Merge pull request #2262 from bcambl/additional_tests
...
additonal test coverage for installer
2018-07-15 09:03:52 -07:00
Dan Schaper
037989b8e4
Merge pull request #2271 from pi-hole/feature/installer_spacing
...
Start changes to new code style for repository. Revise basic installer.sh spacing.
2018-07-14 19:55:13 -07:00
Dan Schaper
dbc82cfb6a
Merge pull request #2236 from pi-hole/new/regex-lists
...
Use regex lists instead of wildcards for blocking
2018-07-14 06:10:44 -07:00
Mcat12
941a766aa3
Replace -wild and -regex with --wild and --regex
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-12 21:38:43 -04:00
Mcat12
72be7ad5f0
Don't count commented out regex lines
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-12 21:21:06 -04:00
Mcat12
b2a36f71a0
Fix wildcard description in pihole man page
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-12 21:17:32 -04:00
Adam Hill
6b17620389
Update .travis.yml
2018-07-12 10:24:01 -05:00
Adam Hill
b04195041a
Update README.md
2018-07-12 10:22:50 -05:00
Adam Hill
8ca4c66e3c
make smarter assertions rathe than largestring not in string
...
Signed-off-by: Adam Hill <adam@diginc.us >
2018-07-12 00:03:25 -05:00
Adam Hill
449b7bf6e4
reduce the amount of strict not in checks
...
Signed-off-by: Adam Hill <adam@diginc.us >
2018-07-11 23:25:16 -05:00
Adam Hill
88e4b6390c
Tox!
...
Signed-off-by: Adam Hill <adam@diginc.us >
2018-07-11 23:24:28 -05:00
Dan Schaper
de92bd1884
Merge pull request #2268 from pi-hole/fix/add-back-conditional-forwarding
...
Add back conditional forwarding to webpage.sh
2018-07-09 18:27:09 -07:00
Mcat12
1b276a74fe
Display all lines of a list, even if there is no newline at the end
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 16:03:16 -04:00
bcambl
fff31558a0
assert REMI repository is not installed for Fedora
...
- fix whiptail mock comments to clarify continue vs cancel
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-08 14:02:31 -06:00
Mcat12
8084c4b2a3
Fix regex period substitution due to switching to bashism
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 15:56:15 -04:00
Mcat12
1ca852191f
Fix stickler complaints
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 15:50:05 -04:00
Mcat12
af5fc6547a
Fix echoing wrong domain when converting wildcard
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 15:47:18 -04:00
Mcat12
70f2b26c86
Escape periods in wildcard converted regex filters.
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 15:45:06 -04:00
Mcat12
cfd95dbe87
Fix incorrect variable usage
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 15:38:44 -04:00
Mcat12
c5bb404d6a
Emulate wildcard blacklisting via -wild and move regex to -regex
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-08 14:37:33 -04:00
bcambl
4c23964964
ensure images are build prior to running tests
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-07 18:43:11 -06:00
bcambl
e4a6dcd35c
update travis.yml to run tests in parallel
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-07 17:51:36 -06:00
bcambl
d4addd53ad
Add tests for Fedora/CentOS distro_check
...
- test to ensure installer behavior with unsupported CentOS releases
- test to ensure repository enablement
- test to ensure PHP upgrade opt-in/opt-out behavior
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-07 17:44:05 -06:00
Mcat12
d21298c156
Add back conditional forwarding to webpage.sh
...
This was accidentally removed in a previous PR.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-07-07 15:23:47 -04:00
Dan Schaper
9dba9fb366
Convert multiline echos to individual echo statements so they don't lead with different amounts of space.
...
Signed-off-by: Dan Schaper <dan.schaper@pihole.net >
2018-07-06 21:29:20 -07:00
bcambl
09d40679c0
add test for unsupported distro checking
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-06 10:07:43 -06:00
Dan Schaper
a323b126e5
Finished space conversion
...
Signed-off-by: Dan Schaper <dan.schaper@pihole.net >
2018-07-05 23:47:55 -07:00
bcambl
553aad6ed2
add Fedora container to test matrix
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-05 18:12:39 -06:00
bcambl
5ca2ad6148
move test globals & mock commands to conftest
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-05 18:10:43 -06:00
bcambl
40537e1522
python linting: missing whitespace after ',' (E231)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-03 00:43:24 -06:00
bcambl
064a75b21b
python linting: missing whitespace around operator (E225)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-03 00:43:18 -06:00
bcambl
1d3445bc0f
python linting: whitespace after '(' and before ')' (E201 & E202)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-03 00:43:09 -06:00
bcambl
79232d02c9
python linting: 'pytest' imported but unused (F401)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-03 00:30:00 -06:00
bcambl
9bd4986781
python linting: whitespace before ':' (E203)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-03 00:21:57 -06:00
bcambl
c3d443aaff
python linting: lines > 79 characters (E501)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-03 00:09:56 -06:00
WaLLy3K
b087888f94
Merge pull request #2261 from pi-hole/fix-no-protocol
...
Treat adlists URLs without a protocol as HTTP
2018-07-03 09:58:29 +10:00
bcambl
da3dfd0998
python linting: missing whitespace after ':' (E231)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-02 15:25:51 -06:00
bcambl
4468d81472
python linting: 2 lines prior to defs (E302)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-07-02 14:54:19 -06:00
WaLLy3K
7ddae8f2eb
Treat URLs without a protocol as HTTP
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2018-07-02 19:59:22 +10:00
Mark Drobnak
6b2851a671
Merge pull request #2257 from pi-hole/fix/query-process-wildcards
...
Move processWildcards to query.sh
2018-06-30 22:18:46 -04:00
Mcat12
4763969c8f
Move processWildcards to query.sh
...
Closes #2255
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-30 22:03:53 -04:00
Mark Drobnak
f9b75e486c
Merge pull request #2256 from pi-hole/fix/query-lists-variable-substitution
...
Fix incorrect variable string substitution
2018-06-30 15:56:22 -04:00
Mcat12
f868052062
Fix incorrect variable string substitution
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-30 15:50:43 -04:00
Mcat12
61f0cbe10a
Update pihole man page for regex
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-29 23:34:15 -04:00
Mcat12
0f4968d75c
Merge remote-tracking branch 'origin/development' into new/regex-lists
2018-06-29 23:12:34 -04:00
Mcat12
3077c22e4f
Change help strings from wildcard to regex blacklist
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-29 23:10:49 -04:00
Mcat12
0decc37b5a
Appease stickler
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-29 22:55:00 -04:00
Mcat12
4a953b66e0
Make removing regex domains work correctly
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-29 22:51:37 -04:00
Mcat12
8435eeed4d
Don't validate regex domains
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-28 23:31:50 -04:00
Mcat12
cffb4de83b
Use strict grep instead of regex for duplicates
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-28 23:01:27 -04:00
Mcat12
55175087c4
Set regex file permissions for web access
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-28 22:52:44 -04:00
Dan Schaper
0ddfa8ad10
Merge pull request #2254 from andrewjanke/patch-1
...
typo fix
2018-06-28 07:34:35 -07:00
Andrew Janke
b74fb3f179
typo fix
2018-06-29 00:28:43 +10:00
bcambl
9d3d33b6a2
add tests for selinux checking
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-06-26 00:09:30 -06:00
Dan Schaper
2abaa60c2e
Merge pull request #2249 from pi-hole/revert-2069-fix/nullbyte
...
Revert "Fix error: /opt/pihole/gravity.sh: 385: Warning: command substitution: ignored null byte in input"
2018-06-25 08:35:09 -07:00
Dan Schaper
d5547f5c7c
Revert "Fix error: /opt/pihole/gravity.sh: 385: Warning: command substitution: ignored null byte in input"
2018-06-24 16:06:55 -07:00
Mark Drobnak
061510098c
Merge pull request #2246 from pi-hole/fix/debug-simple-gravity-list
...
Update debug script for simple list format
2018-06-22 22:41:36 -04:00
Mark Drobnak
4fc3546887
Merge pull request #2069 from pi-hole/fix/nullbyte
...
Fix error: /opt/pihole/gravity.sh: 385: Warning: command substitution: ignored null byte in input
2018-06-20 20:42:24 -04:00
Mcat12
868948509a
Split declaration and assignment of random_url
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-20 20:30:42 -04:00
Mark Drobnak
e71492a2b3
Update debug script for simple list format
...
Gravity is now just a list of domains, not IP addresses and domains separated by a space.
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-06-20 20:29:32 -04:00
Mark Drobnak
c2055f3514
Merge pull request #2240 from pi-hole/tweak/warn_on_tail_if_log_disabled
...
pihole -t: Warn user if Pi-hole's logging is disabled
2018-06-17 11:23:27 -04:00
DL6ER
2809579dd7
Refine regex filter generation
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-06-17 14:59:21 +02:00
DL6ER
c7afe3e9a4
Please stickler by making clear that the variable regexFile is declared outside of this routine
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-06-17 14:46:26 +02:00
DL6ER
cd026cd865
Add comment where regexList is defined
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-06-17 14:43:33 +02:00
DL6ER
bc705aac03
Add automated wildcard list -> regex filter conversion
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-06-17 14:39:19 +02:00
DL6ER
a7c73036f0
pihole -t: Warn user if Pi-hole's logging is disabled
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-06-17 13:37:41 +02:00
Mark Drobnak
e80d27f273
Merge pull request #2234 from rrobgill/split-query-functions
...
Fix grep query leak & relocate query
2018-06-15 19:25:32 -04:00
Rob Gill
23adbf9540
remove quotes
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-15 14:45:27 +10:00
Rob Gill
a7347238e6
$adListsList replace filename in text
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-15 14:42:30 +10:00
Rob Gill
bf55666492
Appease stickler.
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 16:29:07 +10:00
Rob Gill
8ab0b0e460
colfile
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 16:25:43 +10:00
Rob Gill
b8e1849cec
wildcardlist
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 16:19:07 +10:00
Rob Gill
2255d05664
Remove scanlist(), now in query.sh
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 16:09:49 +10:00
Rob Gill
45a8eda49b
Stop grep leak in query
...
Fix grep error leak from #1805
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 16:08:21 +10:00
Rob Gill
b1207949ac
Call query.sh to replace queryFunc()
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 15:49:52 +10:00
Rob Gill
d61fd01d61
Split queryFunc() into query.sh
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-13 15:47:08 +10:00
Mark Drobnak
4d5d3108fb
Merge pull request #2231 from alexvy86/patch-1
...
Remove error text from message when next whitelist request succeeds
2018-06-11 19:41:48 -04:00
Alex Villarreal
e422f4154f
Clean error message on successful response
...
Signed-off-by: Alejandro Villarreal <alex@alexvy86.com >
2018-06-11 12:59:53 -05:00
Mark Drobnak
0651f1bcd4
Merge pull request #2220 from rrobgill/installedphpcheck
...
Bugfix - Check version of installed php
2018-06-08 23:31:40 -04:00
Rob Gill
11f0ade921
comments
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-09 13:18:36 +10:00
Mark Drobnak
5cab2e1c43
Merge pull request #2224 from rrobgill/bashcompletion
...
Bashcompletion
2018-06-08 21:45:03 -04:00
Rob Gill
6381bdbf33
don't use major.minor for PHP 5
...
Signed-off-by: <rrobgill@protonmail.com >
2018-06-09 11:35:30 +10:00
Mark Drobnak
c8bcd4af2d
Merge pull request #2004 from pi-hole/tweak/32bitOS_on_64bitCPU
...
Install 32bit FTL on 32bit OS (even if 64bit architecture is detected)
2018-06-08 20:56:36 -04:00
Rob Gill
cabb06230c
--json not --jason
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-09 10:30:04 +10:00
Mcat12
4a75566a3b
Merge remote-tracking branch 'origin/development' into tweak/32bitOS_on_64bitCPU
2018-06-08 20:20:57 -04:00
Mark Drobnak
d9c924b472
Merge pull request #2225 from rrobgill/ftlinstall-local-vars
...
remove duplicate declaration in ftlinstall()
2018-06-06 19:51:06 -04:00
Rob Gill
52aa52c3b1
remove duplicate declaration
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-07 08:19:26 +10:00
DL6ER
d254d6075a
First step from wildcards to regex lists for blocking
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-06-06 19:26:56 +02:00
Rob Gill
8004080643
Additional command-line completion
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-06 22:37:43 +10:00
Rob Gill
13878974a6
Merge pull request #4 from pi-hole/development
...
Development
2018-06-06 14:21:50 +10:00
Mark Drobnak
6689e00e6a
Merge pull request #2212 from rrobgill/man-pages
...
Man page for pilhole-FTL
2018-06-05 21:33:54 -04:00
Mark Drobnak
9b8a108f86
Merge pull request #2221 from pi-hole/tweak/statsnologs
...
Stats can still be generated without logging, no need for this sentence
2018-06-05 18:39:44 -04:00
Rob Gill
a3569d88c9
Version strings & bash.
...
Fixed up the version checking. Thanks for your help @dschaper.
No longer uses the version string as returned, but uses the major and minor version numbers extracted from it, against the minimum of 5.5.
Tested against real install of php 7.0, (and the version check logic separately tested against a variety of artificial version numbers, of multiple digits for both major and minor version. - Lesson learned, I'm never trusting bash again)
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 21:42:42 +10:00
Adam Warner
f2f6b6ede9
stickler complaints
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-06-05 09:29:03 +01:00
Adam Warner
7f81cfd45a
Stats can still be generated without logging, no need for this sentence
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-06-05 09:09:35 +01:00
Rob Gill
13b8e1a2ae
quotes.
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 15:09:07 +10:00
Rob Gill
36dbdf955d
Update basic-install.sh
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 14:48:24 +10:00
Rob Gill
714b6c98ef
codacy
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 14:45:01 +10:00
Rob Gill
7181d7ae6a
Left that fi
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 14:30:18 +10:00
Rob Gill
9422d57283
Check version of installed php
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 12:08:27 +10:00
Jacob Salmela
5724cec1e5
Merge pull request #2219 from pi-hole/tweak/readme
...
Add coverage, remove projects, add Patreon link
2018-06-04 20:12:18 -05:00
Jacob Salmela
35ca54d98f
add patreon and adjust affiliate links
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-06-04 20:00:26 -05:00
Jacob Salmela
7398a9ebf9
remove projects that are not compliant with our trademarks
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-06-04 19:59:23 -05:00
Rob Gill
4188fb536e
Privacy levels
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 10:25:51 +10:00
Rob Gill
a11e5e2deb
dnsmasq
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-05 10:23:23 +10:00
Mark Drobnak
5dd7e8c4d9
Merge pull request #2215 from rrobgill/web-console
...
Changes to --help text
2018-06-04 18:20:57 -04:00
Rob Gill
40bc390c3b
Admin Console -> "Web Interface"
...
User facing --help text changes
Admin Console --> Web Interface
and additional branch option
Signed-Off-By: Rob Gill <rrobgill@protonmail.com >
2018-06-04 13:34:42 +10:00
Rob Gill
8776348a80
Merge pull request #2 from pi-hole/development
...
Development
2018-06-04 10:05:58 +10:00
Rob Gill
49fb4421dd
Requested changes to manpages - now align with docs.pi-hole.net/ftldns. weird bolding issues fixed
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-04 09:54:53 +10:00
Mark Drobnak
d232f08933
Merge pull request #2208 from pi-hole/tweak/checkout
...
Don't run the installer when doing ftl checkout, instead just run the…
2018-06-03 14:35:35 -04:00
Dan Schaper
feba4da0b8
Merge pull request #2161 from pi-hole/centos_remi-php7
...
CentOS install re-worked to provide PHP7 via Remi Repository
2018-06-03 10:54:32 -07:00
Dan Schaper
928d7186b5
Merge pull request #2214 from pi-hole/fix/gravity-comment
...
Fix gravity_ParseFileIntoDomains Awk comment
2018-06-03 10:52:46 -07:00
Mark Drobnak
3149a95d6a
Fix gravity_ParseFileIntoDomains Awk comment
...
Signed-off-by: Mark Drobnak <newtoncat12@yahoo.com >
2018-06-03 13:33:33 -04:00
Rob Gill
ed7ebfd58d
man page for pihole-FTL
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-03 22:15:26 +10:00
Rob Gill
808e310799
Merge pull request #1 from pi-hole/development
...
Development
2018-06-03 20:54:03 +10:00
Mark Drobnak
23fbb3cf22
Merge pull request #2205 from rrobgill/manual-page
...
Manual page
2018-06-02 21:11:21 -04:00
Mark Drobnak
c11e643f13
Merge pull request #2207 from rrobgill/service-pihole-FTL-status-(sysV)
...
Fix service pihole-FTL status (sysV)
2018-06-02 11:23:38 -04:00
Adam Warner
f5541860bc
Don't run the installer when doing ftl checkout, instead just run the ftl install functions
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-06-02 09:56:08 +01:00
Rob Gill
83ff0055b6
Test and indicate status
...
This added function tests if pihole-FTL is running when the sysV.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 15:30:51 +10:00
Rob Gill
213f23aaf6
wildcard & space
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 14:46:45 +10:00
Rob Gill
9970f3786f
Requested change
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 14:14:55 +10:00
Rob Gill
d01a568b8b
Requested changes (also tabs -> spaces)
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 14:13:30 +10:00
Mark Drobnak
e397884e1e
Merge pull request #2206 from rrobgill/lighttpd-service-test-cleanup
...
Lighttpd service test
2018-06-01 22:08:53 -04:00
Rob Gill
ef65bac79b
change status from INFO to CROSS
...
Signed-Off-By: Rob Gill <rrobgill@protonmail.com >
2018-06-02 11:27:35 +10:00
Rob Gill
c0837c726f
blank space
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 11:18:13 +10:00
Rob Gill
ce5429aba7
stickler
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 11:02:06 +10:00
Rob Gill
aa191e9202
Update basic-install.sh
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 10:46:07 +10:00
Rob Gill
a8f0283e93
Update basic-install.sh
...
This hands checking of lighttpd's status over to the existing check_service_active() function.
All other checks of service status within the install script are handled by this function.
Use of existing function:
Avoids duplication of service detection logic.
Uses return code to determine status, thereby avoids parsing text to determine status, and reliance on English language locale to determine activity, (which may also be broken on some systems (# 2204)
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 10:11:11 +10:00
Rob Gill
999e47a26c
Remove manual page
...
Tests for presence of pihole man page.
If it is present, deletes it and runs man-db to rebuild manual database.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 09:50:52 +10:00
Rob Gill
a8103ca22d
Manual page install function
...
Function to install man page.
Verifies that man pages are installed, and correct directory for the pihole manpage is present.
Copies file, and runs man-db to update man page database.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 09:45:04 +10:00
Rob Gill
ef17f4913b
Create pihole.8
...
Linux man page for pihole
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-02 09:39:51 +10:00
Mark Drobnak
1a30043776
Merge pull request #1768 from Al2Klimov/bugfix/install-invalid-user
...
basic-install.sh: fix "install: invalid user ''"
2018-06-01 19:27:51 -04:00
Mark Drobnak
b7e8b91eec
Merge pull request #2196 from rrobgill/uninstall-formatting
...
Style: uninstall.sh (Tabs to spaces)
2018-06-01 17:27:58 -04:00
Alexander A. Klimov
3be1904653
basic-install.sh: fix "install: invalid user ''"
...
refs #1767
2018-06-01 10:20:40 +02:00
Rob Gill
cadd0e4244
move code back to correct location
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-01 14:03:13 +10:00
Rob Gill
f35ea9a3ca
replace code i missed during merge
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-06-01 11:57:59 +10:00
Rob Gill
0971630e01
Merge branch 'development' into uninstall-formatting
2018-06-01 07:17:02 +10:00
Rob Gill
b60a9fa371
merge ( #2 )
...
* remove package_check to avoid situations like #1760
Signed-off-by: Adam Warner <adamw@rner.email >
* Prevent redundant entries in to adlists.list
Grep ${args[3]} and only add if grep -c -eq 0
Signed-off-by: Ryan Knapper <ryanknapper@gmail.com >
* lan to local
Reduced differences.
Signed-off-by: Ryan Knapper <ryanknapper@gmail.com >
* Require exact match
Updated to require an exact match to reduce false-positives, as suggested by DL6ER.
Signed-off-by: Ryan Knapper <ryanknapper@gmail.com >
* fix empty ports on some systems
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
* debug user locale; improve function to parse variables and files
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
* Split declaration and population for stickler.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* implement dschapers suggestions--better command, less subshells, and finer formatting
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
* flip uninstall compatability check
Signed-off-by: bcambl <blayne@blaynecampbell.com >
* Update index.php
Avoiding calling empty() on a function allows this to work under PHP5. Making the check for blocklist generation in this way instead is compatible with both PHP5 and PHP7.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* Update index.php
thanks stickler-ci .......
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* changes as requested
changes as requested
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* oh stickler bot...
accidentally a space
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* linting: Double quote to prevent globbing and word splitting
Signed-off-by: bcambl <blayne@blaynecampbell.com >
* unbind resolved on ubuntu 18.04
Stop systemd-resolved from interfering with dnsmasq/ftl
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* restore resolvd.conf
If dnsmasq is removed, resolved will need to be restored.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* Update uninstall.sh
Signed-off-by: Rob Gill <rrobgill@protonmail.com >>
* Minor correction for double instance of the word "found".
Signed-off-by: RamSet <RamSet@gmail.com >
* message text
Signed-off-by: Rob Gill <rrobgill@protonmail.com >>
* relocate as function
The check for systemd-resolved DNSStubListener, and disabling as necessary is a new function, called just prior to start_service pihole-FTL.
The check for ubuntu bionic 18.04 specifically is removed.
The check if resolved is enabled is made with check_service_active()
An additional check that the dnsstublistener is enabled is made.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* Regex & case fix
grep & sed regexes match commented or uncommented
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* Update basic-install.sh
Force reloading of relsolved config where available
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* reload resloved
reload resolved config if possible, restart otherwise
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* user-facing messages
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
* move & clarify comments
2018-06-01 07:14:54 +10:00
Mark Drobnak
ab45360808
Merge pull request #1954 from ryanknapper/adlist.lists
...
Prevent redundant entries from being added to Adlists.list
2018-05-31 14:58:16 -04:00
Mark Drobnak
8523c0da32
Merge pull request #2180 from rrobgill/resolved/ubuntu-bionic
...
Disable SystemD's DNS Stub Resolver On Install
2018-05-31 09:32:49 -04:00
Rob Gill
f0dfa4d53d
Stickler-bot...
...
Signed-Off-By: Rob Gill <rrobgill@protonmail.com >
2018-05-31 13:43:49 +10:00
Rob Gill
f2bedddce4
Changes from #2167 converted to spaces
...
Signed-Off-By: Rob Gill <rrobgill@protonmail.com >
2018-05-31 13:37:52 +10:00
Rob Gill
552138e851
Appease stickler-bot.
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-31 13:24:09 +10:00
Rob Gill
ff71379a8e
Convert from two to four space indetation
...
Signed-Off-By: Rob Gill <rrobgill@protonmail.com >
2018-05-31 13:14:18 +10:00
Mark Drobnak
23a7feeb6e
Merge pull request #2167 from pi-hole/uninstall_compat_check
...
flip uninstall compatability check
2018-05-30 22:13:21 -04:00
Mcat12
34f5db9ed4
Merge branch 'development' into uninstall_compat_check
...
# Conflicts:
# automated install/uninstall.sh
2018-05-30 22:08:20 -04:00
Mark Drobnak
9fd70cbdf9
Merge pull request #2057 from pi-hole/fix/debug-empty-ports
...
debug script: fix empty ports on some systems
2018-05-30 21:48:53 -04:00
Mark Drobnak
87506852d1
Merge pull request #1761 from pi-hole/tweak/Uninstall
...
Tweak/uninstall
2018-05-30 21:19:59 -04:00
Rob Gill
e6893bc419
Update uninstall.sh
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-29 19:03:00 +10:00
Rob Gill
ebeab06710
Appease Stickler-bot
...
So... originally no changes were made to the code, but Stickler-bot was unimpressed, so I've followed its suggestions.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-29 18:59:55 +10:00
Rob Gill
1911c3690d
Style/Tabs to spaces
...
uninstall.sh contains a mix of tabs and spaces for indentation in different parts of the file.
Everywhere that used tabs has been converted to spaces, compatible with the indentation style used in basic_install.sh
No code has been altered, only the use of tabs and spaces in indention.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-29 17:59:39 +10:00
Mark Drobnak
3f3254a4df
Merge pull request #2176 from rrobgill/php5fix
...
Fix block page crash on PHP 5.4
2018-05-22 23:21:20 -04:00
Rob Gill
20ccb7b558
move & clarify comments
2018-05-21 08:16:53 +10:00
Rob Gill
8cfe89604a
user-facing messages
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-17 07:44:07 +10:00
Rob Gill
15f0ba839f
reload resloved
...
reload resolved config if possible, restart otherwise
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-16 07:35:22 +10:00
Rob Gill
c400b914e5
Update basic-install.sh
...
Force reloading of relsolved config where available
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-16 07:28:32 +10:00
Rob Gill
a431c829cb
Regex & case fix
...
grep & sed regexes match commented or uncommented
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-16 07:11:23 +10:00
Rob Gill
25d0e125e5
relocate as function
...
The check for systemd-resolved DNSStubListener, and disabling as necessary is a new function, called just prior to start_service pihole-FTL.
The check for ubuntu bionic 18.04 specifically is removed.
The check if resolved is enabled is made with check_service_active()
An additional check that the dnsstublistener is enabled is made.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-15 20:23:36 +10:00
Rob Gill
b89a78ce17
message text
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >>
2018-05-15 19:42:18 +10:00
Mark Drobnak
f568012b9d
Merge pull request #2070 from pi-hole/new/debug-locale
...
Get user locale when debugging
2018-05-14 16:43:05 -04:00
Adam Warner
328fb70e54
Merge pull request #2182 from RamSet/tweak/removeDoubleFound
...
Minor correction for double instance of the word "found".
2018-05-14 19:29:57 +01:00
RamSet
2f24e5ceb7
Minor correction for double instance of the word "found".
...
Signed-off-by: RamSet <RamSet@gmail.com >
2018-05-14 12:21:20 -06:00
Rob Gill
97809277df
Update uninstall.sh
...
Signed-off-by: Rob Gill <rrobgill@protonmail.com >>
2018-05-14 19:50:58 +10:00
Rob Gill
3d3e7a330c
restore resolvd.conf
...
If dnsmasq is removed, resolved will need to be restored.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-14 19:44:23 +10:00
Rob Gill
adf2275018
unbind resolved on ubuntu 18.04
...
Stop systemd-resolved from interfering with dnsmasq/ftl
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-14 19:38:12 +10:00
bcambl
c1ecfbfe63
linting: Double quote to prevent globbing and word splitting
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-05-12 19:39:17 -06:00
Adam Warner
a7e7680789
Merge pull request #2158 from pi-hole/development
...
Update FTLDNS from dev
2018-05-12 23:17:43 +01:00
Rob Gill
382c19024f
oh stickler bot...
...
accidentally a space
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-12 10:53:44 +10:00
Rob Gill
9379487942
changes as requested
...
changes as requested
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-12 10:49:01 +10:00
Rob Gill
5e99baf7b9
Update index.php
...
thanks stickler-ci .......
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-11 14:52:30 +10:00
Rob Gill
31951dae4c
Update index.php
...
Avoiding calling empty() on a function allows this to work under PHP5. Making the check for blocklist generation in this way instead is compatible with both PHP5 and PHP7.
Signed-off-by: Rob Gill <rrobgill@protonmail.com >
2018-05-11 14:31:42 +10:00
Adam Warner
b1ab7f46e0
Merge pull request #2169 from pi-hole/tweak/customportsDNS
...
Remove LOCAL_DNS_PORT support
2018-05-10 22:25:29 +01:00
Adam Warner
4e0c7ed5a6
Merge pull request #2163 from pi-hole/fix/supressDnsmasqWarning
...
Fix for an error message introduced in #2162
2018-05-07 20:44:39 +01:00
DL6ER
2ef76d5e31
Remove LOCAL_DNS_PORT support
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-05-04 22:19:39 +02:00
bcambl
d3dda443cd
flip uninstall compatability check
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-05-04 00:02:47 -06:00
bcambl
ec3802c180
add 'which' dependency (missing on Fedora minimal)
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-05-03 23:41:42 -06:00
Adam Warner
76654c7856
Actually check for dnsmasq's existence before attempting to interact with it's service
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-05-03 21:16:31 +01:00
Adam Warner
90239bb969
Merge pull request #2162 from pi-hole/fix/ifFtlExists
...
Don't attempt to download non-existent FTL Binary
2018-05-03 11:07:12 +01:00
Adam Warner
a6e4b0fea5
- Test for existence of remote non-master branch of FTL before attemtping to check for update
...
- Move some functions from checkout to basic-install
- provide helpful error message on downlaod not existing
Signed-off-by: Adam Warner <adamw@rner.email >
2018-05-01 23:15:26 +01:00
bcambl
8ad37af70e
CentOS install re-worked to include PHP7 via Remi repository
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-05-01 00:58:21 -06:00
Mark Drobnak
c102d359f8
Merge pull request #2159 from pi-hole/tweak/removeDnsmasqRefs
...
Tweak/remove dnsmasq refs
2018-04-30 19:26:59 -04:00
Adam Warner
a07891e3e6
0 is not 1!!
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-30 23:53:51 +01:00
Adam Warner
e946a35b18
Move dnsmasq check into FTLcheckUpdate
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-30 23:50:35 +01:00
Adam Warner
68d7337f98
switch up dnsmasq detection logic
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-30 23:42:41 +01:00
Adam Warner
8b4198fd8d
Merge pull request #1835 from Fauxsys/development
...
Fix for unattended installations #1767 #1768 #1834
2018-04-30 23:06:46 +01:00
Adam Warner
9c795fa40d
Merge pull request #2157 from pi-hole/fix/EmptyAdlist
...
Allow for empty/non existent adlist file
2018-04-30 22:02:34 +01:00
Adam Warner
5f2217a079
Fix for gravity.list not being emptied with an empty/missing adlist file.
...
Variable output depending on content of /existence of adlist
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-30 21:56:33 +01:00
Adam Warner
0cda4b7f23
Merge pull request #2123 from pi-hole/new/RemoveDefaultBlocklists
...
Remove default blocklists from install
2018-04-29 22:06:47 +01:00
Adam Warner
e17e69604c
Merge branch 'development' into new/RemoveDefaultBlocklists
2018-04-29 18:40:53 +01:00
Adam Warner
e1bf4d4344
Merge pull request #2155 from pi-hole/tweak/DontStopServices
...
No need to stop services
2018-04-29 18:38:34 +01:00
Adam Warner
0c8a32b9ae
No need to stop services
...
This causes issues on a `pihole -r reconfigure`
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-29 18:27:10 +01:00
Adam Warner
d8c60aaae7
Merge pull request #2142 from bcambl/fix_fedora_ip_check
...
Fix static IP checking on Fedora
2018-04-29 14:36:07 +01:00
Adam Warner
3216d65353
Merge branch 'development' into new/RemoveDefaultBlocklists
2018-04-29 13:39:17 +01:00
Mark Drobnak
0df8d0a4e2
Merge pull request #2153 from MichaIng/patch-1
...
"INSTALL_WEB" renamed to "INSTALL_WEB_INTERFACE" #2115
2018-04-28 20:17:18 -04:00
MichaIng
43f19034b9
"INSTALL_WEB" renamed to "INSTALL_WEB_INTERFACE" #2115
...
+ Small fix, as due to PR https://github.com/pi-hole/pi-hole/pull/2115 variable "INSTALL_WEB" was renamed into "INSTALL_WEB_INTERFACE".
2018-04-28 15:17:29 +02:00
Adam Warner
2e6a937240
Merge pull request #2151 from pi-hole/FTLDNS-gravity-simplelists
...
Update FTLDNS branch
2018-04-25 06:57:49 +01:00
Adam Warner
05d8a7f6be
Merge pull request #2147 from pi-hole/fix/borkedUpdate
...
Restore functionality to `pihole -up` broken in #2115
2018-04-23 21:14:26 +01:00
Adam Warner
ceaf4bc6bc
Some extra code made it's way into the dev branch. Not entirely sure how that happened... related to #2115
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-23 20:46:57 +01:00
Adam Warner
f2cc2f433c
Merge pull request #2140 from pi-hole/FTLDNS-gravity-simplelists
...
Use domain list format for black.list and gravity.list
2018-04-23 20:29:32 +01:00
Dan Schaper
858aa6255c
Merge pull request #2145 from pi-hole/fix/2115
...
Add missing `/` to line 1511
2018-04-23 07:19:14 -07:00
bcambl
1d8ea9e869
Fix static IP checking on Fedora
...
This bug was introduced by #1758 where the CIDR was removed from the static IP check.
The CIDR was acting as a boundary so we need to test for a boundary or a slash character.
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-04-23 06:42:36 -06:00
Adam Warner
8ead0b5483
@fourdee dropped this: /
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-23 11:59:39 +01:00
Fauxsys
72c081cfd6
Fix for unattended installations #1767 #1768 #1834
...
Removed updatePihole() function and updated if/then statements in installPihole() and main(). Corrected minor typos.
Signed-off-by: Fauxsys <fiber.cipher@gmail.com >
2018-04-23 04:53:57 -04:00
Mark Drobnak
1f701c94a7
Merge pull request #2115 from Fourdee/Install-Web-Server
...
--disable-install-webserver
2018-04-22 15:56:11 -04:00
Dan
acfc49fd41
Merge branch 'development' into Install-Web-Server
2018-04-22 09:23:11 +01:00
Adam Warner
9c29bd627e
fix user blacklisting
2018-04-21 23:55:33 +01:00
DL6ER
d24b141d8b
Get rid of numBlocked file, FTLDNS can now determine number of domains thanks to the new lists format
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-21 23:58:42 +02:00
DL6ER
bac9e005ae
Generate gravity.list and black.list in simple domain lists format for FTLDNS. Leave local.list in HOSTS format
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-21 23:27:36 +02:00
Daniel (Fourdee)
60bcca54eb
Minor
...
+ indentation
2018-04-21 08:29:21 +01:00
Daniel (Fourdee)
eccea8a911
Minor
...
+ Fix indentation
+ Stick with case, add "On" to provide INFO print out, although its not
technically required as INSTALL_WEB_SERVER=true is default value.
2018-04-21 08:27:31 +01:00
Mark Drobnak
0833d0d8d5
Merge pull request #2133 from mbologna/patch-1
...
Fix: add psmisc as dependency
2018-04-20 13:17:46 -04:00
Michele Bologna
55fce489bc
Fix: add psmisc as dependency
...
Debian 9.4 does not install `psmisc` by default and the following error will happen during installation:
```
[✗] /usr/local/bin/pihole: line 353: killall: command not found
/usr/local/bin/pihole: line 364: killall: command not found
```
This patch adds `psmisc` (that contains `killall`) as dependency
Signed-off-by: Michele Bologna <michele.bologna@gmail.com >
2018-04-19 23:41:23 +02:00
Adam Warner
2ce40c3c07
Merge pull request #2132 from rwky/development
...
Fixed typo in README
2018-04-19 19:49:29 +01:00
Rowan
255cfb7d62
Fixed typo in README
...
Signed-off-by: Rowan Wookey <admin@rwky.net >
2018-04-19 19:45:11 +01:00
Adam Warner
8a327be400
Merge pull request #2130 from pi-hole/FTLDNS
...
Internal FTLDNS -> dev
2018-04-18 22:09:31 +01:00
DL6ER
1cae76b443
Merge pull request #2126 from pi-hole/FTLDNS-recursive-resolver
...
Add backend changes for supporting a local DNS server
2018-04-18 22:01:43 +02:00
DL6ER
828e8d2ae4
Merge pull request #2040 from pi-hole/FTLDNS
...
FTLDNS Integration
2018-04-18 20:20:39 +02:00
DL6ER
ce35509a40
Change command to "pihole -a localdnsport X"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-18 17:30:51 +02:00
DL6ER
24b8b4e904
Add backend changes for supporting a local recursive DNS server
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-18 17:12:20 +02:00
Daniel (Fourdee)
c2c1dc7469
Ensuring bot pleasure
...
https://github.com/pi-hole/pi-hole/pull/2115#pullrequestreview-113066748
2018-04-18 04:38:07 +01:00
Daniel (Fourdee)
47c1071bb8
Minor
...
+ Add info in regards to disabling web server install:
https://github.com/pi-hole/pi-hole/pull/2115
2018-04-18 04:24:48 +01:00
Daniel (Fourdee)
e401651f09
Update https://github.com/pi-hole/pi-hole/pull/2115
...
+ Patch existing systems with the new variable changes using
'accountForRefactor'
+ Prompt user to install webserver
2018-04-18 04:11:32 +01:00
Mark Drobnak
1449def040
Merge pull request #2049 from pi-hole/tweak/readme
...
update donation and affiliate links. also link to trademark guideline…
2018-04-17 20:25:09 -04:00
Dan Schaper
d4d1ec2568
Merge pull request #2124 from pi-hole/development
...
Internal
2018-04-17 11:54:50 -07:00
Adam Warner
7455ac9bfb
Run chooseBlocklists on EVERY reconfigure, not only if the adlist file does not esist.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-17 19:46:36 +01:00
Adam Warner
b6b1dcb275
delete adlists.list if user cancels out of this dialog
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-17 19:35:46 +01:00
Adam Warner
2e4f49a223
Default all to on, change up wording. This commit can be rolled back, it's just an option!
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-17 17:10:53 +01:00
Adam Warner
88d4108f92
- Add new whipstail to choose from example blocklists on new install
...
- remove adlists.default
- do not copy non-existent adlists.default on run of gravity
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-17 10:33:06 +01:00
Dan Schaper
c9f3c02cb7
Merge pull request #2027 from ravron/ravron-urls-in-query-strings
...
Prevent inadvertent blocking of good domains appearing in query strings
2018-04-16 17:31:51 -07:00
Dan Schaper
557372b312
Merge pull request #2119 from pi-hole/new/sticklerCI-extras
...
add some more linters to stickler
2018-04-15 18:28:00 -07:00
Adam Warner
18b24535fe
Lets try the correct name for csslint
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 23:46:52 +01:00
Adam Warner
20e0bca71d
add some more linters to stickler
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 23:45:36 +01:00
Adam Warner
6977f655e3
fix a typo
...
comment out some unused variables, but not deleting them in case there is a plan for them in future...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 22:08:55 +01:00
Adam Warner
e6fc9dc75d
disable 2016 in two places and declare local variables
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 22:00:14 +01:00
Adam Warner
b57b3f4588
Disable SC2001 for generation of the_os
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 21:36:50 +01:00
Adam Warner
776ae92416
fix some shellcheck/stickler compaints in debug script
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 21:33:10 +01:00
Adam Warner
6ba53c1ac0
Merge branch 'development' into FTLDNS
2018-04-15 20:46:13 +01:00
Adam Warner
699d419c71
Merge pull request #2116 from pi-hole/FTLDNS_UpdateCheck
...
Check for new updates without actually updating
2018-04-15 20:42:29 +01:00
Mark Drobnak
d4870b3854
Merge pull request #2053 from pi-hole/tweak/debug-logs
...
Get head and tail of pihole-FTL.log during debug process
2018-04-15 14:23:25 -04:00
Adam Warner
e49a9096a5
accidentally a 'shift'
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 18:46:35 +01:00
Adam Warner
33148ba832
Add help text to pihole command to document new flag
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 18:30:13 +01:00
Adam Warner
bca23dd896
Allow passing of --check-only to update script.
...
Don't run installer for updating web files, it's handled by getGitFiles.
I think this works...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-15 18:25:35 +01:00
Daniel (Fourdee)
3a483a1b20
install_web_server
...
+ Splits web interface and server into two variables.
+ Option to disable forced install of Lighttpd.
2018-04-15 02:08:16 +01:00
Adam Warner
310d33b8ee
Merge dev > FTLDNS fix merge conflicts
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-13 17:01:54 +01:00
Adam Warner
8b5dcc3872
Match change made by 7edab27 to prevent merge conflict
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-13 16:53:57 +01:00
Adam Warner
36d9af10f0
Merge pull request #2108 from LudovicRousseau/fix_No_such_file_or_directory
...
Fix sed: can't read /etc/pihole/pihole-FTL.conf: No such file or directory
2018-04-13 16:47:59 +01:00
Dan Schaper
0c8fcbc684
Merge pull request #2105 from pi-hole/feature/self_dco
...
Do not require DCO for Pi-hole Org members with GPG signed commits.
2018-04-13 05:42:04 -07:00
Ludovic Rousseau
7edab27e53
Stylistic change to use an explicit if/then/fi
...
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2018-04-13 12:19:55 +02:00
Ludovic Rousseau
9b3531f634
Fix stylistic issue
...
Expand variable using ${FTLconf}
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2018-04-13 11:48:34 +02:00
Ludovic Rousseau
d8f85a8981
Avoid a "No such file or directory" error
...
Check the file /etc/pihole/pihole-FTL.conf exists before trying to use
it.
without the patch I get, each day, in my logs:
sed: can't read /etc/pihole/pihole-FTL.conf: No such file or directory
I use a variable FTLconf to not repeat the file name twice.
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2018-04-13 11:16:58 +02:00
Ludovic Rousseau
3b229489c2
Fix regex to find DBFILE= from configuration file
...
The regex ^\s^.DBFILE\s*=\s* does not work to match "DBFILE="
I don't know what the second '^' is used for.
With the change I now have the results:
DBFILE=/foo/bar
-> /foo/bar
DBFILE=/foo/bar
-> /foo/bar
# DBFILE=/foo/bar
-> /etc/pihole/pihole-FTL.db
xDBFILE=/foo/bar
-> /etc/pihole/pihole-FTL.db
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2018-04-13 11:16:50 +02:00
Mark Drobnak
c2fcbbb0c6
Merge pull request #2090 from Razvici/master
...
Update pihole locahost probe for DNS status
2018-04-12 11:17:33 -04:00
Jacob Salmela
8e82bf69d8
update wallet addresses
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-04-11 20:40:35 -05:00
Jacob Salmela
284f9e3f2f
implement mcats request. removed 'the'
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-04-11 20:38:56 -05:00
Jacob Salmela
5ffc3561ed
implement dschapers suggestions--better command, less subshells, and finer formatting
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-04-11 20:35:51 -05:00
Dan Schaper
952f1271b4
Do not require DCO for Pi-hole Org members with GPG signed commits.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-04-11 10:13:09 -07:00
Dan Schaper
250b445eee
Split declaration and population for stickler.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-04-10 21:37:04 -07:00
Mark Drobnak
331472b592
Merge pull request #1999 from pi-hole/tweak/RedundantInstallCode
...
adlists.default no longer used. No need to reference it.
2018-04-06 00:17:45 -04:00
DL6ER
82d5afe996
Silence error in log flush subroutine when no pihole-FTL.conf can be found
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-05 22:28:55 +02:00
Razvan Radu
7361d5d3ea
Update pihole lolcahost probe for DNS status
...
Signed-off-by: Razvan Radu <ramset@gmail.com >
2018-04-05 11:14:39 -06:00
DL6ER
6086614274
Add "-l, privacylevel" description to "pihole -a"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-04 18:10:23 +02:00
Adam Warner
6bb4780d32
Merge pull request #2077 from pi-hole/tweak/FTLDNSExperiments
...
FTLDNS tweaks
2018-04-04 17:00:03 +01:00
Adam Warner
631f5b4848
Change order of updatable components to match the end output
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-04 16:35:11 +01:00
DL6ER
0f17712f6c
Merge pull request #2085 from pi-hole/FTLDNS-privacylevels
...
Backend changes needed to be able to set the privacy level
2018-04-04 14:41:16 +02:00
DL6ER
4941e0f8ad
Backend changes needed to be able to set the privacy level
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-04-04 13:12:39 +02:00
Jacob Salmela
fbee18e24d
Merge pull request #2056 from pi-hole/release/v3.3.1
...
Pi-hole core v3.3.1
2018-04-02 19:29:39 -05:00
Adam Warner
f37b2bc7c1
move call to get_binary_name into FTLcheckUpdate() to avoid having to run that first
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-02 23:22:06 +01:00
Adam Warner
56278c6394
Fix shellcheck complaints
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-02 22:06:36 +01:00
Adam Warner
b1d6c03190
Break out binary name funtion to it's own function
...
Remove duplicate code. get_binary_name is now in the install script
Add some "version" checking to ftl download when using an alt branch, uses checksum
Greatly simplify update process. Source pihole-FTL version checker from basic-install.sh
Always run install script to finalise changes.
Install script now outputs versions after an update
(This is a Squash of previous work into one commit)
Signed-off-by: Adam Warner <adamw@rner.email >
2018-04-02 21:53:32 +01:00
Mark Drobnak
1200a77b22
Merge pull request #2075 from everettsouthwick/development
...
Add support for public Cloudflare DNS servers.
2018-04-02 00:03:50 -04:00
Mark Drobnak
bb9a18ef08
Merge pull request #1987 from ryanknapper/patch-1
...
Proper output for debug CPU detection
2018-04-02 00:00:14 -04:00
Everett Southwick
a8b493cb7d
Add support for public Cloudflare DNS servers.
...
Signed-off-by: Everett Southwick <everett@everettsouthwick.com >
2018-04-01 17:59:16 -05:00
Jacob Salmela
1a275ba184
debug user locale; improve function to parse variables and files
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-04-01 06:40:48 -05:00
Jacob Salmela
187848660c
try another fix for #2028
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-31 16:12:29 -05:00
Jacob Salmela
c3f391dc5a
maybe fixes #2028 by deleting null bytes
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-31 14:08:48 -05:00
Mark Drobnak
971e6f2664
Merge pull request #2064 from Perflyst/chronometer-1
...
Add RaspberryPi 3B+ to Chronometer
2018-03-30 17:42:50 -04:00
Mark Drobnak
a1d6ef04ec
Merge pull request #1758 from mettacrawler/fix-for-RHELish-ifcfg
...
basic-install.sh - no CIDR in ifcfg-*
2018-03-30 17:28:52 -04:00
DL6ER
ff47ab12fb
Save number of effectively blocked domains in /etc/pihole/numBlocked
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-03-30 21:01:51 +02:00
Dan Schaper
a97e361661
Merge pull request #2061 from dflamand/development
...
Remove dead link from CONTRIBUTING.md
2018-03-28 20:10:11 -07:00
Dan Schaper
34d84522dd
Merge pull request #2054 from theLMGN/patch-1
...
Link to the admin panel on the splash page.
2018-03-28 20:08:39 -07:00
Perflyst
3390fbf238
Add RaspberryPi 3B+
...
Signed-off-by: Perflyst <mail@perflyst.de >
2018-03-27 12:23:01 +02:00
Mark Drobnak
98ad1feaeb
Merge pull request #2060 from pi-hole/tweak/debug-xheader
...
add label to x-header so you know which one is being evaluated
2018-03-26 13:23:31 -04:00
Dillon Flamand
37e8a91d5b
Remove dead link from CONTRIBUTING.md
...
Removed a link to a github repo that no longer exists.
Signed-off-by: D. Flamand <dflamand@users.noreply.github.com >
2018-03-25 21:59:35 -07:00
Jacob Salmela
68c27eb2a1
add label to x-header so you know which one is being evaluated
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-25 21:27:40 -05:00
Jacob Salmela
143e75d213
fix empty ports on some systems
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-25 09:39:29 -05:00
DL6ER
295ac49f83
Add capability CAP_NET_RAW to allow pihole-FTL to use RAW sockets for being able to create an ICMPv6 socket for IPv6 handling in the DHCP service
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-03-25 09:58:22 +02:00
Mark Drobnak
d31a498e6c
Merge pull request #2031 from pi-hole/tweak/BegonePullApprove
...
Remove PA YAML file
2018-03-23 22:16:12 -04:00
Adam Warner
2fd88a1c6a
Merge branch 'FTLDNS' of github.com:pi-hole/pi-hole into FTLDNS
2018-03-23 22:47:13 +00:00
Adam Warner
fbab930cb1
Allow install script to install FTL instead of the checkout script. Utilises the /etc/pihole/ftlbranch file.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-23 22:46:41 +00:00
Leo MG Nesfield (LMGN)
bfcbd72e4b
Link to the admin panel on the splash page.
2018-03-23 16:17:31 +00:00
Jacob Salmela
d9d3caec22
new head tail function and get head tail of pihole-FTL.log instead of just head
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-23 06:56:40 -05:00
Adam Warner
238a56cac3
Remove CreateLogFile function, as this is handled by the FTL service
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-23 10:53:22 +00:00
Adam Warner
51765b1f65
chown pihole log to pihole:pihole, rather than pihole:root
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-23 10:15:40 +00:00
Jacob Salmela
7159ecb632
reduce ping times for faster script completion
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-23 00:11:21 -05:00
Jacob Salmela
11f3425876
update donation and affiliate links. also link to trademark guidelines. update an image. and add a project.
...
Signed-off-by: Jacob Salmela <jacob.salmela@pi-hole.net >
2018-03-22 23:51:12 -05:00
Mark Drobnak
e131395cce
Merge pull request #2037 from justinamcafee/master
...
Adds FamilyShield DNS server address to the "Choose DNS" screen in installer.
2018-03-21 17:47:24 -04:00
Adam Warner
d26ea2b948
remove trailing whitespace
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-18 00:38:34 +00:00
Adam Warner
5584a9ce5d
Merge branch 'development' into FTLDNS
2018-03-18 00:29:08 +00:00
Adam Warner
e2e8b733a8
tidy up function
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-18 00:13:10 +00:00
Adam Warner
f18bf35b20
use systemctl is-enabled to check enabled status of service
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-17 22:56:50 +00:00
Adam Warner
44d8cb77e3
Kill off mask_service function
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-17 22:48:11 +00:00
Adam Warner
fc10e3fcac
Merge pull request #2025 from pi-hole/FTLDNSremoveDnsmasq
...
Disable dnsmasq FTLDNS
2018-03-16 11:27:52 +00:00
Adam Warner
b92ccb2de4
Additionally mask the dnsmasq service on systems with systemctl
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-14 20:01:06 +00:00
justinamcafee
30af6e73be
added ;; to line 825
...
Misformated case. Updated correct case
2018-03-10 17:36:47 -06:00
justinamcafee
2895b9bfb7
Added support for FamilyShield from OpenDNS
...
With a very minor code change, individuals can now implement restrictions on dangers, disturbing, or otherwise adult oriented content without the need for managed restrictions.
This is a fairly non-invasive change and will benefit users who intend to use VPN for home or small business uses where access to such material may be undesirable.
2018-03-10 17:33:31 -06:00
Adam Warner
84bd86f1ee
- Test to see if dnsmasq service is enabled before stopping and disabling it.
...
- Some formatting tweaks to the `start_service` `stop_`service` `disable_service` and `enable_service` commands
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-07 23:31:28 +00:00
Adam Warner
7193f40b87
remove libnettle, missed a >/dev/null
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-07 22:23:05 +00:00
Adam Warner
acd69fa4b0
silence push/popd
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-07 22:21:09 +00:00
Adam Warner
71d8f5f96f
remove PA YAML file
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-07 22:00:14 +00:00
Adam Warner
856a2096eb
Merge pull request #2030 from pi-hole/new/StickFTLCheckoutBranch
...
Store checked out FTL branch in /etc/pihole/ftlbranch
2018-03-07 21:51:52 +00:00
Adam Warner
76cb129d3c
don't forget master and development branches!
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-07 21:48:09 +00:00
Adam Warner
246d5cd587
store checked out FTL branch in /etc/pihole/ftlbranch
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-07 21:41:00 +00:00
Riley Avron
f390671018
Improve scheme matching to avoid inadvertent blocking
...
Signed-off-by: Riley Avron <riley.avron@gmail.com >
2018-03-06 22:03:56 -08:00
Riley Avron
512ec7fb87
Remove unneeded ifs in awk
...
Signed-off-by: Riley Avron <riley.avron@gmail.com >
2018-03-06 22:03:43 -08:00
Adam Warner
24219422df
Merge branch 'development' into FTLDNSremoveDnsmasq
2018-03-06 20:43:27 +00:00
Adam Warner
aed20cf7c6
Merge pull request #2017 from pi-hole/fix/NoWhitelistGravity
...
Gravity falls over when there is no whitelist file
2018-03-06 20:39:32 +00:00
Adam Warner
6584933e92
fix stickler complaints
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-06 18:51:02 +00:00
Adam Warner
8cf8da4c78
- Check file /etc/pihole/ftlbranch for current FTL branch, download from github if master, or pi-hole.net if other
...
- Check if downloaded binary file can resolve queries, if so stop and disable dnsmasq
- Add service_disable function
- Add dependency libcap2-bin on debian to enable setcap. Need to check other distos
-Always download FTL binary if /etc/pihole/ftlbranch does not contain "master"
- Change some strings/variables that reference dnsmasq and change them to pihole/pihole-FTL
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-06 18:44:57 +00:00
Adam Warner
ad1f210528
As we no longer add source lists to the whitelist by default, gravity falls over on new installs.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-06 18:29:28 +00:00
Adam Warner
cadab61a21
Merge branch 'development' into FTLDNS
2018-03-05 21:33:53 +00:00
Adam Warner
0b87f489d5
Look for pihole-FTL, not dnsmasq!
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-03-03 15:59:56 +00:00
Mark Drobnak
e3e5e016d5
Merge pull request #2016 from pi-hole/bugfix/mktemp
...
Bugfix mktmp > mktemp
2018-03-02 16:03:11 -05:00
Dan Schaper
3425b9a82e
Fix mktmp > mktemp
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-03-02 12:28:53 -08:00
Ryan Knapper
5ecfc58e5f
Require exact match
...
Updated to require an exact match to reduce false-positives, as suggested by DL6ER.
Signed-off-by: Ryan Knapper <ryanknapper@gmail.com >
2018-02-28 13:06:07 -05:00
Dan Schaper
6011dd7372
Merge pull request #2000 from pi-hole/fix/FTL_Install
...
Use pushd/popd and create random temporary directory
2018-02-26 21:55:12 -08:00
DL6ER
7ed45d26c2
Remove " " at some places where they shouldn't be
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-26 17:26:51 +01:00
DL6ER
fcdc85eab8
Remove dnsmasq from dependencies
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-25 23:47:11 +01:00
DL6ER
56a2924a33
Unprivileged processes are subject to full permission checking based on the process's credentials, we have to explicitly allow pihole-FTL to bind to ports < 1024 (port 53 for DNS) and for various advanced network-related operations (to allow for handling DHCP requests)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-25 23:42:26 +01:00
DL6ER
09886a3f11
Add resolveconf config to pihole-FTL.service
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-25 10:11:11 +01:00
DL6ER
e8ec0dc701
Use pihole-FTL resolver in pihole and gravity
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-25 09:34:04 +01:00
Dan Schaper
41d9d57c84
Merge pull request #1996 from pi-hole/fix/AlternativeWhitelistFromWebFix
...
Specifty `LC_ALL=C` when dealing with sorted lists.
2018-02-24 07:22:44 -08:00
DL6ER
b87bcc8f5f
Modifications in pihole-FTL.service for FTLDNS
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-24 13:23:06 +01:00
DL6ER
0541d8f1c5
Try to determine if the user is running a 32bit OS on a 64bit system. If so, download the 32bit binary as we cannot expect the 64bit libraries to be present.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-24 11:13:33 +01:00
Dan Schaper
4606693e62
Use pushd/popd and create random temporary directory to prevent potential backdoor binary injection.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-02-22 20:13:38 -08:00
Adam Warner
e61d8e4fb8
adlists.default no longer used. No need to reference it.
...
Use --force switch of gravity to force the cache refresh
Signed-off-by: Adam Warner <adamw@rner.email >
2018-02-22 14:45:31 +00:00
Adam Warner
6b4685b333
much more elegant to export LC_ALL at the beginning of the script!
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-02-21 11:33:29 +00:00
Adam Warner
d4ac818a0b
Specifty LC_ALL=C when dealing with sorted lists.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-02-21 11:23:07 +00:00
Ryan Knapper
c17d95bfed
Proper output for debug CPU detection
...
Inserted "log_write" to properly output CPU detection lines.
Signed-off-by: Ryan Knapper (ryanknapper@gmail.com >
2018-02-19 10:22:28 -05:00
Mark Drobnak
f14184df30
Merge pull request #1982 from LudovicRousseau/master
...
Create blacklist.txt if not existant
2018-02-18 15:32:01 -05:00
Ludovic Rousseau
47bbea9ba7
Use " " to protect parameter substitution
...
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2018-02-18 21:20:04 +01:00
Mark Drobnak
7265935cd4
Merge pull request #1915 from ryanknapper/development
...
Add conditional forwarding options to webpage.sh
2018-02-18 12:51:46 -05:00
DL6ER
40bda4b3d1
Merge pull request #1981 from pi-hole/fix/always_repair_pihole-FTL.service
...
Always replace pihole-FTL.service
2018-02-18 17:26:17 +01:00
Ludovic Rousseau
b7891f92a5
Create blacklist.txt if not existant
...
Closes: https://github.com/pi-hole/pi-hole/issues/1888
Signed-off-by: Ludovic Rousseau <ludovic.rousseau@free.fr >
2018-02-18 14:19:49 +01:00
DL6ER
8b79017d0f
Always replace pihole-FTL.service
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-18 13:07:22 +01:00
DL6ER
5465ac9ba0
Merge pull request #1929 from pi-hole/fix/flushDB
...
pihole -f: Flush database
2018-02-17 17:45:15 +01:00
DL6ER
b8eaa9a527
Use double quotes to precent globbing and word splitting
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-17 13:01:00 +01:00
DL6ER
5d274008db
Use possibly user-defined database location when flushing
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-17 12:58:57 +01:00
DL6ER
220e755596
Merge pull request #1973 from pi-hole/tweak/stop-autowhitelisting
...
Don't auto-whitelist blocking list domains
2018-02-17 12:23:14 +01:00
DL6ER
fc5034696d
Don't auto-whitelist blocking list domains
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-02-16 19:42:33 +01:00
DL6ER
4a6f77bc59
Merge pull request #1967 from pi-hole/master
...
Git flow Pi-hole v3.3
2018-02-15 21:09:22 +01:00
Dan Schaper
1e87850952
Merge pull request #1943 from pi-hole/release/3.3
...
Pi-hole v3.3
2018-02-14 12:48:40 -08:00
Mark Drobnak
3472241289
Merge pull request #1962 from floek/master
...
Fixes https://github.com/pi-hole/pi-hole/issues/1772
2018-02-14 13:02:56 -05:00
Florian Freund
a944b6ff79
Fixes https://github.com/pi-hole/pi-hole/issues/1772
2018-02-12 21:28:43 +01:00
Mark Drobnak
6c4741bc61
Merge pull request #1730 from pi-hole/tweak/block-page-no-password
...
Disable password field on block page if no password is set
2018-02-11 22:15:20 -05:00
Mcat12
8a42ef431b
Fix Javascript warning when no password is set
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-02-11 21:49:12 -05:00
Mcat12
2cf1f0e8fc
Hide the password input when there is no password
...
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2018-02-11 14:07:02 -05:00
Mcat12
55e50eced6
Merge branch 'development' into tweak/block-page-no-password
2018-02-11 13:49:36 -05:00
Adam Warner
30a2923380
Merge pull request #1952 from smopucilowski/fixes
...
Trivial spelling mistakes in basic-install.sh comments
2018-02-11 10:43:33 +00:00
Ryan Knapper
f2b3752f3d
lan to local
...
Reduced differences.
Signed-off-by: Ryan Knapper <ryanknapper@gmail.com >
2018-02-07 17:08:55 -05:00
Ryan Knapper
36945a67d0
Prevent redundant entries in to adlists.list
...
Grep ${args[3]} and only add if grep -c -eq 0
Signed-off-by: Ryan Knapper <ryanknapper@gmail.com >
2018-02-07 17:04:10 -05:00
Sebastian Pucilowski
c5a2ca5c98
Trivial spelling mistakes in basic-install.sh comments
...
Signed-off-by: Sebastian Pucilowski <smopucilowski@gmail.com >
2018-02-07 16:56:21 +11:00
Dan Schaper
9f2ce0e296
Merge pull request #1910 from pi-hole/fix/BinaryFileLineInGravity
...
Potential fix for #1909
2018-01-28 03:23:19 -08:00
Adam Warner
55e10d8287
replace another grep -F as pointed out by @StarPicard
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-01-28 00:50:15 +00:00
Dan Schaper
94c772e1a8
Merge pull request #1936 from theel0ja/patch-fix-typo
...
Fixed a typo
2018-01-27 04:45:53 -08:00
Elias Ojala
2b6d9c34c9
Fixed a typo
...
Signed-off-by: Elias Ojala <ojala.s.elias@gmail.com >
2018-01-27 14:36:11 +02:00
Mcat12
1a5c86d32e
Revert "Hide password textbox if there is no password"
...
This reverts commit 009fa2f1b7 .
2018-01-23 20:28:43 -05:00
Mcat12
c7219fbdff
Merge remote-tracking branch 'origin/development' into tweak/block-page-no-password
2018-01-21 09:09:36 -05:00
DL6ER
4c249a1186
Flush most recent 24 hours from FTL's database
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-21 13:48:13 +01:00
DL6ER
158ea1d43b
Add sqlite3 dependency
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-21 11:54:49 +01:00
Mark Drobnak
535b8458d4
Merge pull request #1901 from bcambl/epel_check
...
Fix epel-release install for CentOS
2018-01-20 14:03:24 -05:00
Dan Schaper
49b3f82675
Merge pull request #1925 from pi-hole/feature/installtweaks
...
Install log security
2018-01-20 08:59:49 -08:00
Dan Schaper
9543203610
Echo the right location for the log.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-20 08:45:41 -08:00
Dan Schaper
cacfe4d387
Linting changes
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-20 07:39:11 -08:00
Dan Schaper
a7f0137e5f
Use more secure installation log process.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-20 05:55:48 -08:00
Dan Schaper
b2eb364a4b
Update header
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-20 05:36:28 -08:00
Dan Schaper
bb3b1bc6ba
Move ascii berry to after root check, stops the double berry for the sudo refire.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-20 05:13:55 -08:00
Dan Schaper
ae8eb3f177
Merge pull request #1920 from pi-hole/feature/pr_template
...
Internal - GitHub template edit.
2018-01-20 03:48:51 -08:00
DL6ER
27c7325174
Merge pull request #1918 from pi-hole/tweak/lan
...
Use "lan" as fallback TLD for DHCP generated domains
2018-01-20 10:29:11 +01:00
DL6ER
8ee3d810b0
Merge pull request #1922 from pi-hole/tweak/logging-noflush
...
Add "pihole logging off noflush" command
2018-01-20 10:21:23 +01:00
DL6ER
d7dde06552
Add "pihole logging off noflush" command
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-18 17:08:46 +01:00
Dan Schaper
448495a4a3
Remove references to issues.
...
Modify code blocks to italics and reformat the layout.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-16 14:56:15 -08:00
DL6ER
52cc8e2fcf
Use "lan" as fallback TLD for DHCP generated domains
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-16 22:10:27 +01:00
Dan Schaper
fb9cdea008
Merge pull request #1914 from deathbybandaid/development
...
Update README.md
2018-01-15 11:08:43 -08:00
Adam Warner
6c54bf036c
Merge pull request #1913 from pi-hole/tweak/GravityFunctionNames
...
proposed gravity function renames
2018-01-15 17:51:19 +00:00
Deathbybandaid
657bc4edcd
Update README.md
...
Signed-off-by: deathbybandaid
2018-01-15 08:05:43 -05:00
Deathbybandaid
b75dd5ff73
needed sign-off
...
Signed-off-by:
2018-01-15 08:04:27 -05:00
ryanknapper
607664c860
Update webpage.sh
...
Updated webpage.sh to include conditional forwarding options.
2018-01-14 21:01:08 -05:00
Deathbybandaid
094bd49f35
Update README.md
2018-01-14 20:29:20 -05:00
Adam Warner
18fbe60381
Merge pull request #1908 from pi-hole/tweak/RemoveCronPiholeUpdate
...
If this line is uncommented, it is re-commented on the next update an…
2018-01-14 20:58:58 +00:00
Adam Warner
f1956119fb
proposed gravity function renames
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-01-14 20:38:39 +00:00
Adam Warner
876170767c
Print actual domain instead of grep output of "Binary file /etc/pihole/list.preEventHorizon matches" when a domain with a unicode char is in a source list.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-01-13 16:43:20 +00:00
Dan Schaper
f4f77ec88b
Merge pull request #1900 from roots84/patch-1
...
Update README.md
2018-01-13 05:03:29 -08:00
Stefan
9ba2038702
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
...
Signed-off-by: Stefan <roots84@noreply.users.github.com >
2018-01-12 21:25:09 +01:00
Stefan
b176ba9e80
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
...
Signed-off-by: Stefan <roots84@noreply.users.github.com >
2018-01-12 21:24:39 +01:00
Stefan
cacb47ca7e
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
...
Signed-off-by: Stefan <roots84@noreply.users.github.com >
2018-01-12 21:23:36 +01:00
Stefan
500e424fee
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
...
Signed-off-by: Stefan <roots84@noreply.users.github.com >
2018-01-12 21:22:43 +01:00
Stefan
f1b02c0cab
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
2018-01-12 21:21:26 +01:00
Stefan
828302702b
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
...
Signed-off-by: Stefan <roots84@users.noreply.github.com >
2018-01-12 21:20:39 +01:00
Stefan
0827d4fe40
Merge branch 'patch-1' of https://github.com/roots84/pi-hole into patch-1
2018-01-12 21:18:30 +01:00
Stefan
ebff965414
Update README.md
...
Adding DNS-Swapper Project back after it was accidently removed
Signed-off-by: roots84 <stefan.bautz@gmail.com >
2018-01-12 21:17:10 +01:00
Dan Schaper
b45954c560
Merge pull request #1895 from pi-hole/feature/PR_templateDCO
...
Update PULL_REQUEST_TEMPLATE.md
2018-01-12 08:14:51 -08:00
Adam Warner
80307a3bcd
Remove update line from cron
...
Signed-off-by: Adam Warner <adamw@rner.email >
2018-01-12 15:43:15 +00:00
Adam Warner
e8acb5967b
Merge pull request #1904 from vgerak/patch-1
...
piholeDebug.sh: Correct typo mistake
2018-01-12 15:04:27 +00:00
Vasilis Gerakaris
939806f021
piholeDebug.sh: Correct typo mistake
...
Signed-off-by: Vasilis Gerakaris <vgerak@gmail.com >
**By submitting this pull request, I confirm the following:**
`{please fill any appropriate checkboxes, e.g: [X]}`
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md ), as well as this entire template.
- [x] I have made only one major change in my proposed changes.
- [] I have commented my proposed changes within the code.
- [] I have tested my proposed changes, and have included unit tests where possible.
- [] I am willing to help maintain this change if there are issues with it later.
- [x] I give this submission freely and claim no ownership.
- [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1 )
- [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html ))
2018-01-12 02:17:31 +02:00
bcambl
cc47bf8f6c
Fix epel-release install for CentOS
...
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2018-01-07 22:21:04 -06:00
Stefan
8b80aaebf5
Update README.md
...
Adding DNS-Swapper Project back after it was accidently removed
2018-01-07 22:54:53 +01:00
DL6ER
8f35ebc0c2
Merge pull request #1897 from pi-hole/fix/webpage.sh_interface_setting
...
Add fallback interface in DNS settings
2018-01-07 16:56:01 +01:00
DL6ER
793bdd9743
No need for cat | sed here as we source setupVars.conf, so we can use interface="${PIHOLE_INTERFACE}"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-07 14:36:03 +01:00
DL6ER
9d50f52bb2
Add fallback interface for DNS listening behavior in case PIHOLE_INTERFACE is not set in setupVars.conf
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-07 14:34:02 +01:00
Dan Schaper
db62afbb64
Update PULL_REQUEST_TEMPLATE.md
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-06 07:28:26 -08:00
DL6ER
3dc3e8e40e
Merge pull request #1885 from pi-hole/new/FTL_Usocket
...
Create directories /etc/{var,log}/pihole on startup of pihole-FTL
2018-01-04 14:05:18 +01:00
Dan Schaper
c79fc81292
Merge pull request #1891 from pi-hole/feature/DCO_doc
...
Link to DCO wiki entry.
2018-01-03 16:31:06 -08:00
Dan Schaper
62a6a878d4
Link to DCO wiki entry.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2018-01-03 16:20:57 -08:00
DL6ER
4efb533d2e
Create directories /etc/{var,log}/pihole on startup of pihole-FTL and set proper ownership
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2018-01-01 11:26:03 +01:00
Mark Drobnak
891473c7fc
Merge pull request #1882 from pi-hole/tweak/jetbrains_codestyle
...
Just ignore the whole .idea directory, execpt for the codeStyles
2017-12-30 15:32:19 -05:00
Dan Schaper
81e8ef5c40
Just ignore the whole .idea directory, execpt for the codeStyles and the
...
legacy codeStyelSettings.xml.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-12-30 12:23:46 -08:00
Mark Drobnak
e17885088b
Merge pull request #1881 from pi-hole/tweak/jetbrains_codestyle
...
Jetbrains has moved codestyle locations. Development Internal
2017-12-30 14:38:24 -05:00
Dan Schaper
494340fe67
Add other JetBrains stuff to ignore
2017-12-30 10:37:17 -08:00
Dan Schaper
01625dfd49
JetBrains new codestyle storage location
2017-12-30 10:33:41 -08:00
DL6ER
a154f1540f
Merge pull request #1778 from loganaden/development
...
Add secondary quad9 server
2017-12-30 18:19:55 +01:00
DL6ER
5254fc6efe
Merge pull request #1880 from pi-hole/fix/chronometer_localhost
...
Small improvement for Chronometer
2017-12-30 17:51:59 +01:00
DL6ER
afa2e9c2f7
Exchange hard-coded domain "localhost" by hard-coded address "127.0.0.1"
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-30 17:44:59 +01:00
DL6ER
a4c8f1a0a4
Merge pull request #1859 from pi-hole/new/extra-logging
...
Enable dnsmasq's extra logging feature
2017-12-28 22:49:43 +01:00
Mark Drobnak
d5a9a9a2d8
Merge pull request #1878 from pi-hole/tweak/run_updatechecker_after_install
...
Force update of update checker for new installs
2017-12-28 14:43:28 -05:00
DL6ER
3b8f8fb0ef
Merge pull request #1874 from pi-hole/uninitiate
...
Grammar change in debug script
2017-12-28 18:47:47 +01:00
DL6ER
677033afca
Force update of "remote" part in th update checker (may take up to 24hrs for new installs otherwise)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-28 18:41:22 +01:00
Adam Warner
8e0d76b63b
initiated -> initialized
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-24 13:26:32 +00:00
Adam Warner
64df41ed90
Merge pull request #1873 from pi-hole/fix/1871
...
Source setup vars before we attempt to do anything on an update/repair
2017-12-24 13:21:45 +00:00
Adam Warner
442a372142
Merge pull request #1870 from pi-hole/docs/gitsignoff
...
Add more informative link for Git Signoff
2017-12-24 13:16:37 +00:00
Adam Warner
95e5baa967
Source setup vars before we attempt to do anything on an update/repair
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-24 13:09:45 +00:00
Dan Schaper
b80edfb996
Add more informative link for Git Signoff
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-12-23 17:48:15 -08:00
Mark Drobnak
e06543bd17
Merge pull request #1866 from pi-hole/fix/FTL_branch_version_display
...
Store fourth entry in versions/branches files
2017-12-23 11:32:57 -05:00
DL6ER
cca8412921
Use "echo -n" to avoid haveing newlines in the files
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-23 11:52:27 +01:00
DL6ER
d15a5ad5c1
Add required documentation in the source code
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-23 00:46:51 +01:00
DL6ER
8ed75dd176
Add extra entry to the end of the saved branches and versions such that PHP's explode() subroutine can correctly disentangle the first three entries and does not get confused by the newline character at the end of the FTL version/branch...
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-23 00:42:41 +01:00
DL6ER
d43ad263ea
Merge pull request #1863 from pi-hole/master
...
Sync with development branch
2017-12-22 22:00:49 +01:00
Jacob Salmela
e602008459
Merge pull request #1856 from pi-hole/release/v3.2.1
...
Pi-hole core v3.2.1
2017-12-22 14:53:38 -06:00
Dan Schaper
322a18f0e6
Merge pull request #1861 from pi-hole/fix/DNSSEC_trustanchor
...
Merge `fix/DNSSEC_trustanchor` into `release/3.2.1` again
2017-12-21 11:03:05 -08:00
Dan Schaper
05eb749e66
Merge branch 'release/v3.2.1' into fix/DNSSEC_trustanchor
2017-12-21 11:00:21 -08:00
Dan Schaper
7e8d31a62c
Merge pull request #1860 from pi-hole/smarterNotHarder
...
Merge `smarterNotHarder` into `release/3.2.1` again
2017-12-21 10:59:55 -08:00
Dan Schaper
8ca0582afc
Merge branch 'release/v3.2.1' into fix/DNSSEC_trustanchor
2017-12-21 10:56:37 -08:00
Dan Schaper
b9f5fca546
Merge branch 'release/v3.2.1' into smarterNotHarder
2017-12-21 10:53:40 -08:00
DL6ER
5c2dcb5e74
Enable dnsmasq's extra logging feature
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-21 16:42:55 +01:00
DL6ER
3ef4af9326
Merge pull request #1857 from pi-hole/tweak/randomize_updatechecker
...
Randomize update checker time
2017-12-21 13:28:03 +01:00
DL6ER
f89f7ecd3e
Randomize GitHub API update check time
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-21 12:42:47 +01:00
DL6ER
be0c457445
Sleep 30 seconds after reboot to be sure that the system is ready
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-21 12:42:28 +01:00
DL6ER
3c04dbb4ed
Update remote version at 17:59 as well as on reboot
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-21 12:33:08 +01:00
DL6ER
cfca367eef
Quickly verified in dnsmasq's source code: It has to be "trust-anchor" (with "-")
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-18 21:45:24 -05:00
DL6ER
8a243c5872
Insert also old trust anchor
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-18 21:45:15 -05:00
DL6ER
b30b3f3aeb
Update DNSSEC trust anchor
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-18 21:44:34 -05:00
Adam Warner
2d3906450a
add back in str local var, and change ticks to info on whitelist lines
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-18 20:14:53 +00:00
Adam Warner
5ecc46d85b
Accidentally too many spaces
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-16 14:03:12 +00:00
Adam Warner
ddd6f3dbe5
Grammar changes. Lets not work out programmatically whether we need to pluralise a word. It's not needed.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-16 13:55:52 +00:00
Adam Warner
f5237db580
Merge pull request #1849 from pi-hole/fix/1826
...
Remove quotes from the uniqDomains array to actually whitelist the so…
2017-12-16 13:22:44 +00:00
Adam Warner
761fd13a70
Remove quotes from the uniqDomains array to actually whitelist the sources
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-16 13:15:26 +00:00
Mark Drobnak
e3fa06d7ff
Merge pull request #1829 from keithbentrup/development
...
Must send HTTP headers before html
2017-12-13 13:37:32 -05:00
Mark Drobnak
61a76f4493
Merge pull request #1836 from pi-hole/tweak/packageInstall
...
Change package install notification from CROSS to INFO.
2017-12-13 12:27:47 -05:00
Adam Warner
c5f46702c8
Merge pull request #1840 from pi-hole/revert/GravityParseMethod
...
Revert parsing method to that of 3.1.4. New Method is allowing illega…
2017-12-12 17:49:36 +00:00
Adam Warner
c24e5cd3f6
:codacy: :codacy2: :codacy3:
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-12 12:45:25 +00:00
Adam Warner
cc3035267f
Revert parsing method to that of 3.1.4. New Method is allowing illegal lists through, and that is causing issues such as blocking www.google.com. This method will just throw away invalid list entries.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-12 12:36:09 +00:00
Dan Schaper
29ee8250e9
Change package install notification from CROSS to TICK.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-12-11 09:45:30 -08:00
Dan Schaper
47ed0b7627
Merge pull request #1830 from pi-hole/ops/stickler
...
Create .stickler.yml
2017-12-09 18:18:50 -08:00
Dan Schaper
423280cee1
Merge pull request #1817 from jjssoftware/development
...
pihole.log permissions
2017-12-09 14:15:12 -08:00
Dan Schaper
8c0faa0b9a
Create .stickler.yml
...
Initial stickler yaml file.
2017-12-09 14:08:54 -08:00
Keith Bentrup
45ab2a3d7a
send HTTP headers before HTML
...
Signed-off-by: Keith Bentrup <keith@keithbentrup.com >
2017-12-09 17:03:20 -05:00
Dan Schaper
8804f5c423
Merge pull request #1825 from pi-hole/tweak/updatechecker
...
Tweak update checker
2017-12-09 13:58:16 -08:00
Dan Schaper
1078aa499c
Merge pull request #1812 from pi-hole/fix/resolvconf
...
Try dig +short if getent hosts fails when running gravity
2017-12-09 13:57:48 -08:00
DL6ER
05d015169c
Check for local version and branches every 10 minutes, check for remote versions only once a day
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-12-09 19:00:46 +01:00
Jacob Salmela
6c9e7586d5
Merge pull request #1818 from pi-hole/fix/debug
...
Use systemctl or service commands in debug script
2017-12-08 19:57:37 -06:00
Jacob Salmela
28bed0041e
remove comment
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-12-08 18:29:28 -06:00
Jacob Salmela
6f03e30151
fixes #1537 by checking if systemctl is found
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-12-08 18:23:55 -06:00
Joe
6085d6ffd1
Merge pull request #1 from jjssoftware/jjssoftware-patch-1
...
Jjssoftware patch 1
2017-12-08 22:38:22 +00:00
Joe
6ecd93d0c9
pihole.log permissions
...
This change makes pihole more friendly to the non-existence of the pihole.log file. This can help with systems that are configured to mount /var/log as a tmpfs volume. It may also help with systems where the pihole.log file is accidentally/unintentionally removed.
Further discussion around the details of this change are in https://github.com/pi-hole/pi-hole/issues/1798
2017-12-08 22:25:01 +00:00
Dan Schaper
863ea7294f
Merge pull request #1815 from pi-hole/release/3.2
...
Merge Release 3.2 in to development. GitFlow
2017-12-08 13:06:18 -08:00
Jacob Salmela
af59824819
Merge pull request #1811 from bcambl/nmcli_check
...
check NetworkManager status prior to using the cli (#1653 )
2017-12-08 06:38:42 -06:00
Jacob Salmela
80e17ab721
potentially fixes #1806 by falling back to dig if getent fails
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-12-07 22:38:47 -06:00
bcambl
f89d69b081
check NetworkManager status prior to using the cli ( #1653 )
...
Closes #1653
Signed-off-by: bcambl <blayne@blaynecampbell.com >
2017-12-07 21:43:14 -06:00
Jacob Salmela
5ba413569e
Merge pull request #1776 from pi-hole/release/3.2
...
Pi-hole core v3.2
2017-12-06 21:37:10 -06:00
Adam Warner
b3e969f000
Merge pull request #1797 from pi-hole/Ugh/Codacy
...
Ugh/codacy
2017-12-07 00:49:59 +00:00
Adam Warner
a9a40ca46c
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 23:27:40 +00:00
Adam Warner
79aada0b87
travis didn't like that
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 22:57:05 +00:00
Adam Warner
162a7b56fe
force mode is no longer referenced. Regression. Same with domToRemoveList
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 22:42:08 +00:00
Adam Warner
69dc22c10f
fix some codacy and intelliJ idea complaints
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 22:31:12 +00:00
Mcat12
9642cda949
Merge pull request #1792 from pi-hole/bugfix/lighttpdEnabled
...
Add in an extra check to enable lighttpd.
2017-12-06 16:31:26 -05:00
Adam Warner
dd6a9a0b84
supress output of which command on centos/fedora as per https://github.com/pi-hole/pi-hole/pull/1776#discussion_r155156819
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 15:28:58 +00:00
Adam Warner
945dcc6c2b
Indent two spaces as per https://github.com/pi-hole/pi-hole/pull/1776#discussion_r155157116
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 15:17:31 +00:00
Adam Warner
f60791ac7c
Add dependencies as per https://github.com/pi-hole/pi-hole/pull/1776#discussion_r155149349
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 14:42:01 +00:00
Adam Warner
b64155a165
Add in an extra check to enable lighttpd.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-12-06 14:32:39 +00:00
Mcat12
472f7725c7
Merge pull request #1779 from pi-hole/new/locallists
...
Add support for local blocking lists
2017-11-28 20:58:00 -05:00
Jacob Salmela
90f01b5fc4
Merge pull request #1780 from pi-hole/fix/spacepasswd
...
Allow passwords with spaces
2017-11-23 23:42:54 -06:00
Jacob Salmela
20a2daa114
Merge branch 'release/3.2' into fix/spacepasswd
2017-11-23 23:11:17 -06:00
Jacob Salmela
9b6a2c7068
Merge pull request #1769 from pi-hole/tweak/readme
...
Use GH Pages images & update wording
2017-11-23 23:07:16 -06:00
WaLLy3K
0a4d3ef6e6
Add "sudo bash" to installation instructions
...
* Running as sudo/root prevents script from being re-downloaded, unintentionally side-stepping manual code review by end user
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-11-23 13:35:51 +11:00
WaLLy3K
2dc1851892
Allow passwords with spaces
...
e.g: `pihole -a -p "foo bar"`
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-11-23 13:17:34 +11:00
Mcat12
8d721d086c
Modify indentation
2017-11-21 18:37:38 -05:00
DL6ER
6f0bb30def
Improve indentation
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-11-21 20:58:27 +01:00
DL6ER
c54f04ef4c
Repair username:password filtering
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-11-21 20:55:47 +01:00
DL6ER
eb83081a5c
Clarify error message: File could also have been of zero size
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-11-21 18:36:34 +01:00
DL6ER
8976930e20
Properly detect if local file was successfully downloaded
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-11-21 18:35:58 +01:00
DL6ER
164a81776e
Allow to add local lists to gravity using e.g. file:///path/to/my.list in adlists.list
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-11-21 18:30:40 +01:00
Loganaden Velvindron
9c8526db49
Add secondary quad9 server
2017-11-20 22:05:41 +04:00
WaLLy3K
d92f9b4dbd
Add separator between FAQ/Requests & Social Media
...
This is to add emphasis that the first three options should be considered before the social media outlets.
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-11-20 15:59:13 +11:00
Mcat12
1556163fb0
Merge pull request #1774 from mterron/patch-1
...
Add support for Quad9 secure dns server
2017-11-18 14:06:47 -05:00
Terror
616962200a
Update the list size to show all the options
2017-11-17 18:18:13 +13:00
Terror
eb9c44a347
Add support for Quad9 secure dns server
...
See www.quad9.net
2017-11-17 15:54:04 +13:00
WaLLy3K
f36ac48de0
Use GH Pages images & update wording
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-11-15 13:15:59 +11:00
Jacob Salmela
f63267a7f9
Merge pull request #1757 from Mausy5043/development
...
Various small fixes
2017-11-11 16:45:16 -06:00
Adam Warner
2c8dcd86e5
remove package_check to avoid situations like #1760
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-11-09 20:47:15 +00:00
Jacob Salmela
9631519eb1
Merge pull request #1752 from pi-hole/new/bashupdatechecker
...
Add bash / cron based update checker for Pi-hole
2017-11-08 20:38:40 -06:00
Jacob Salmela
557d076d2e
Merge pull request #1717 from pi-hole/tweak/readme
...
Update README.md
2017-11-08 20:07:58 -06:00
Jacob Salmela
8a40c91d1a
made above the fold focus on the logo and Pi-holes features. fixed typos. wordsmithed
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-11-08 20:03:18 -06:00
DL6ER
90efa3b610
Simplify git subroutines
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-11-08 19:11:41 +01:00
mettacrawler
35dc4800e0
basic-install.sh - no CIDR in ifcfg-*
...
Do not expect CIDR format IP addresses in /etc/sysconfig/network-scripts/ifcfg-* files as it is not a requirement.
Expect only:
IPADDR=10.10.10.10
Do not expect:
IPADDR=10.10.10.10/24
2017-11-05 15:28:44 -05:00
Mausy5043
ec4e4d3b72
fix indentation
2017-11-05 11:02:04 +01:00
Mausy5043
63312ac4b8
removed duplicate word
2017-11-05 10:18:39 +01:00
Mausy5043
d158a7d51e
spelling corrected
2017-11-05 10:16:56 +01:00
Mausy5043
209a2ab3ec
grammar corrected (double negative)
2017-11-05 10:05:25 +01:00
Mcat12
009fa2f1b7
Hide password textbox if there is no password
2017-11-01 21:30:14 -04:00
Adam Warner
5221767a70
Merge pull request #1735 from bcambl/debug_selinux
...
add SELinux checks to debug script
2017-10-30 13:07:36 +00:00
DL6ER
9492ff26c6
Merge pull request #1747 from pi-hole/tweak/gravity_update_time
...
Randomize gravity update time
2017-10-29 16:34:18 +01:00
DL6ER
06764d0f36
Randomize gravity update time between 03:01 - 04:58 (excluding 04:00)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-29 15:37:39 +01:00
DL6ER
0db76aada0
Silence errors when directory to be checked does not exist (system may have been installed without a web interface!)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-28 15:44:17 +02:00
DL6ER
7362416afb
Force an update of the updatechecker after update/install
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-28 15:40:48 +02:00
DL6ER
9be854031f
Don't store FTL branch until the next release of FTL which supports returning the branch in an easy way
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-28 13:41:24 +02:00
DL6ER
709851503f
Use "pihole-FTL branch" to get FTL's branch
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-28 13:27:12 +02:00
DL6ER
6ca47dc3b3
Add bash / cron based update checker for Pi-hole
2017-10-28 13:20:02 +02:00
DL6ER
d8774901ee
Merge pull request #1751 from pi-hole/tweak/FTL_SIGHUP
...
Send SIGHUP to pihole-FTL when restarting/reloading dnsmasq
2017-10-26 21:43:16 +02:00
Mcat12
8dba2a88e2
Move FTL re-parsing call after dnsmasq restart
2017-10-25 23:07:45 -04:00
DL6ER
2c33c64fae
Merge pull request #1750 from pi-hole/fix/chrono-ftl-dbb
...
Silence non-numeric domains_being_blocked output
2017-10-25 18:19:53 +02:00
DL6ER
b9ae01d819
Send SIGHUP to pihole-FTL when restarting/reloading dnsmasq
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-25 17:46:24 +02:00
WaLLy3K
2390b80359
Silence non-numeric domains_being_blocked output
...
* Round $cpu_mhz to 1 decimal place
* Remove ".0" from $cpu_freq
* Silence non-numeric domains_being_blocked output
* Use "Core" and "Web" as appropriate
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-25 21:04:43 +11:00
DL6ER
c34c3eb016
Shift randomized time interval from 00:00-01:59 to 02:00-03:59
2017-10-21 15:58:37 +02:00
DL6ER
85d159bdd1
Randomize gravity update time
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-21 15:52:53 +02:00
Adam Warner
da1d2b2c48
Merge pull request #1744 from bcambl/unignore_pullapprove
...
Unignore pullapprove
2017-10-21 01:02:52 +01:00
WaLLy3K
5f8b0b3c89
Merge pull request #1743 from pi-hole/fix/wildcardrestart
...
Fix for wildcard not restarting `dnsmasq`
2017-10-20 10:35:24 +00:00
bcambl
0f868f7649
remove un-used DONE variable
...
(still available via sourced COL_TABLE on line 29)
2017-10-19 22:57:07 -06:00
bcambl
8b0785996e
remove .pullapprove.yml from .gitignore
...
Closes #1535
2017-10-19 22:41:29 -06:00
WaLLy3K
645d8e0ebd
Fix issue where wildcarding didn't restart dnsmasq
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-19 17:51:20 +11:00
WaLLy3K
3a3c0befa7
Merge pull request #1734 from pi-hole/fix/query-options
...
Fix query option handling
2017-10-18 08:23:40 +00:00
WaLLy3K
80c40e6050
Prevent full stop being interpreted as regex
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-16 10:12:27 +11:00
bcambl
31730e7197
add missing colors to COL_TABLE fallback
2017-10-13 09:14:19 -06:00
bcambl
7d76db00ac
update 'SELinux not detected' message
2017-10-13 08:58:35 -06:00
bcambl
8aceb8bf53
replace deprecated colors in debug script
...
- COL_LIGHT_GREEN -> COL_GREEN
- COL_LIGHT_RED -> COL_RED
- COL_LIGHT_PURPLE -> COL_PURPLE
2017-10-12 23:33:28 -06:00
bcambl
a17d1be7a4
simplify selinux debug variables
2017-10-12 23:24:02 -06:00
bcambl
1e6cc63abe
add SELinux checking to debug script
2017-10-12 20:55:14 -06:00
WaLLy3K
3b300a4d6a
Fix query option handling
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-13 11:42:49 +11:00
WaLLy3K
3e727c5e5d
Merge pull request #1721 from pi-hole/fix/lightyconf
...
Add comment for include_shell feature
2017-10-11 01:55:05 +00:00
DL6ER
e0edac32c7
Merge pull request #1728 from pi-hole/new/nuke_lists
...
Add nuclear option to list.sh
2017-10-10 19:12:16 +02:00
WaLLy3K
e4b3bc4209
Minor spacing corrections
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-10 13:17:33 +11:00
WaLLy3K
51b09efceb
Fix minor typo
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-09 19:53:45 +11:00
WaLLy3K
2dabacd024
Fix minor typo
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-09 19:53:22 +11:00
WaLLy3K
0613dcc87b
Merge pull request #1692 from andofrjando/cors_mixed_content_fix
...
Fix for bug on block page (#1416 ) caused by CORS mixed content when behind reverse proxy using SSL
2017-10-09 07:53:33 +00:00
WaLLy3K
d59a2a4cfc
Merge pull request #1729 from pi-hole/fix/email-help-argument
...
Allow emails which include `-h` in them (Fix for #1691 )
2017-10-08 12:23:46 +11:00
WaLLy3K
2c091f3a3c
Merge branch 'development' into cors_mixed_content_fix
2017-10-08 12:22:14 +11:00
WaLLy3K
cfcdc53185
Merge pull request #1722 from pi-hole/fix/bpfqdn
...
Improve FQDN Authorized Hosts functionality (Fix for #1416 )
2017-10-08 12:19:11 +11:00
WaLLy3K
bd33018660
Shellcheck OR validation
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-08 12:16:05 +11:00
Mcat12
e7589945a2
Disable password field if no password is set
...
For someone to actually whitelist a domain without a password, more changes will
be needed on the PHP side.
2017-10-07 16:41:30 -04:00
Mcat12
67a5594909
Allow emails which include -h in them
...
For example, mcat12@pi-hole.net would previously spit out the help message
2017-10-07 16:06:16 -04:00
DL6ER
70ad656af0
Save backup as ".bck~" to prevent reading of the file by dnsmasq
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-07 22:04:14 +02:00
DL6ER
f22b83d379
Create a backup before emptying the list
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-07 17:46:40 +02:00
DL6ER
114f84c948
Add --nuke option to list.sh that can be used e.g. by Teleporter to empty out lists before importing new content
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-10-07 17:29:47 +02:00
WaLLy3K
7875df0d6b
Merge pull request #1723 from pi-hole/tweak/bpcss
...
Ensure Block Page (#1416 ) matches current style of Web Interface
2017-10-07 14:53:43 +11:00
WaLLy3K
0d286b99d5
Remove placeholder URL
2017-10-06 20:39:01 +11:00
WaLLy3K
e03d4f2de8
Condense features into three main sections
...
* Core shows a list of common commands, linking to the new Core Function Breakdown wiki article
* Core also now shows the ASCII Vortex
* Web has had its preview image size reduced
* FTL's functions are elaborated upon more
2017-10-06 20:35:54 +11:00
WaLLy3K
7fddce4a1f
Use updated vector logo
...
* Move Codacy/Build/BountySource badges underneath the H1 header
* Use updated vector logo (Matches the new Pi-hole stickers!)
* Tweak wording for Versatile
* Quote `cd` path instead of escaping string
* Order Projects and Coverage in order of publish date
* Use the current published title for Projects/Coverage links
* Change Projects/Coverage links to use HTTPS if the server supports TLS
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-06 18:11:05 +11:00
WaLLy3K
3cd8b7d882
Merge pull request #1724 from pi-hole/fix/removejs
...
Remove superseded index.js: #1696 #1416
2017-10-04 14:11:52 +11:00
DL6ER
3578a3e311
Merge pull request #1718 from pi-hole/tweak/VPNhostnames
...
Append ".vpn" TLD for OpenVPN host names
2017-10-03 21:32:36 +02:00
WaLLy3K
a9ad8d67aa
Remove superseded index.js
...
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-04 01:13:02 +11:00
WaLLy3K
43e1121618
Match current style of Web Interface
...
* Remove border from about menu
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-04 01:05:44 +11:00
WaLLy3K
97dd1b4cf3
Improve FQDN Authorized Hosts functionality
...
* Use inverse if statement, instead of IF/ELSE when checking setupVars.conf
* Remove $svFQDN
* Add or elaborate on more comments
* Add $serverName to $authorizedHosts if admin has specified `setenv.add-environment = ("fqdn" => "true")` within lighttpd's external.conf
* e.g: `$HTTP["host"] == "pihole.domain.com" { setenv.add-environment = ("fqdn" => "true") }`
* Move "No exact results" check to top of exception handling
* Remove unnecessary IF/ELSE when handling $queryAds error
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-10-04 00:46:51 +11:00
WaLLy3K
288635abc9
Add comment for include_shell feature
...
* Capitalise first letter for Lighttpd
* Fix spacing
* Add comment for include_shell feature
2017-10-03 22:05:06 +11:00
Mcat12
7884423e05
Merge pull request #1719 from 19wolf/patch-1
...
Update basic-install.sh
2017-10-01 12:51:20 -04:00
Eric Wolf
1615fa63e3
Update basic-install.sh
...
Fixed comment line 40
2017-09-30 16:34:38 -04:00
DL6ER
39ab1e1ea7
When using the Pi-hole DHCP server, local host names are called "something.local". Thir PR ensures that clients that are connected via VPN are augmented by a similar suffix like "someother.vpn".
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-09-30 13:03:49 +02:00
WaLLy3K
10c048d84a
Use "Web Interface" verbiage throughout document
...
* Also implement other reviewed suggestions
2017-09-30 13:21:29 +10:00
WaLLy3K
a458482e51
Update README.md
...
* Create consistent style and formatting
* Simplify and/or tweak wording
2017-09-30 00:20:41 +10:00
WaLLy3K
de46dbd56f
Ensure domains are consolidated to lower case
...
* Fix regression caused by #1631
2017-09-27 01:55:17 +10:00
spacedingo
60365ad36a
Update gravity.sh
2017-09-26 09:25:47 +04:00
spacedingo
466e6d9b30
Redo pull #1687
...
Fix for case sensitive duplicate domains
The change (https://github.com/pi-hole/pi-hole/pull/1687 ) was recently undone.
2017-09-26 05:53:07 +04:00
WaLLy3K
11d48554e3
Merge pull request #1708 from pi-hole/fix/gravityErrors
...
Place errors on newline
2017-09-25 15:39:26 +10:00
WaLLy3K
b9bcfe36ff
Place errors on newline
2017-09-24 11:57:15 +10:00
WaLLy3K
05faa7bdf2
Merge pull request #1707 from pi-hole/fix/tailFunc
...
Correctly retrieve IPv4/6 addresses for tailFunc()
2017-09-24 10:28:36 +10:00
WaLLy3K
88b1f0ca7f
Merge pull request #1702 from pi-hole/fix/activeDomains
...
Ensure domains files are not deleted upon w/blist
2017-09-24 08:02:47 +10:00
WaLLy3K
f0f7bda2f3
Merge pull request #1704 from celly/lighttpd-hide-files
...
Exclude files from Web Admin that should not be accessible.
2017-09-23 11:36:03 +10:00
WaLLy3K
664d0ea023
Correctly retrieve IPv4/6 addresses for tailFunc()
...
* Add comments for readability
* Use `sed -E` for readability
* Move `date` into `sed`
* Use updated colour codes
2017-09-23 11:27:40 +10:00
WaLLy3K
cd7c00ef8e
Fix Ctrl-C inadvertently deleting domains files
2017-09-23 10:32:56 +10:00
Celly
3f20981aab
Update access rules to block all root '.' files
2017-09-22 09:29:00 -04:00
Celly
f54a812ad5
Update access rules to block all root '.' files
2017-09-22 09:27:43 -04:00
WaLLy3K
aa1d67a4de
Merge pull request #1703 from pi-hole/fix/lighttpdEnabled
...
Fix `LIGHTTPD_ENABLED` dupes in `setupVars.conf`
2017-09-22 19:21:50 +10:00
WaLLy3K
feb2150d9b
Fix LIGHTTPD_ENABLED dupes in setupVars.conf
...
* Fix issue merged [here](fdf2649f2f (diff-689793e68cde6270d074695b71c969afL1488) )
2017-09-22 19:14:11 +10:00
WaLLy3K
3aa525b0c0
Ensure domains files are not deleted upon w/blist
2017-09-22 14:17:56 +10:00
andofrjando
6323d5afed
Use PHP short echo tag to avoid Codacy expecting an escaping function
2017-09-22 07:15:03 +08:00
Celly
e3e3b4da58
Add in some exclusions form some leaky files in the admin
2017-09-21 17:47:37 -04:00
Adam Warner
a0bd517380
Merge pull request #1694 from pi-hole/fix/qf-opt
...
Slow query fix & queryFunc optimisation
2017-09-21 20:05:42 +01:00
Adam Warner
4316b15ae2
Merge pull request #1700 from pi-hole/fix/start-ftl
...
Start and enable FTL prior to running Gravity
2017-09-21 20:00:08 +01:00
Adam Warner
ef1ce7d4d6
Merge pull request #1631 from pi-hole/tweak/gravity
...
Clean up and optimise Gravity
2017-09-21 19:58:38 +01:00
Adam Warner
a643f40cce
Merge pull request #1663 from pi-hole/new/UninstallCleanup
...
Cleanup uninstall script
2017-09-21 19:56:12 +01:00
WaLLy3K
47099e2855
Ensure resolver test occurs each second
...
* Ensure that gravity will run the second the resolver is available
* Increase timeout to 120s
2017-09-22 03:56:53 +10:00
WaLLy3K
2deb2bf03f
Fix broken whitelist functionality
2017-09-22 02:23:43 +10:00
WaLLy3K
3bb05edb52
Merge pull request #1701 from pi-hole/fix/local-ttl
...
Decrease `local-ttl` to 2
2017-09-22 01:29:50 +10:00
DL6ER
ee2169dd13
Merge branch 'development' into tweak/gravity
2017-09-21 17:05:30 +02:00
WaLLy3K
11282aaca3
Decrease local-ttl to 2
...
* Decreasing value should benefit clients when whitelisting blocked sites, [as per this discussion](https://github.com/pi-hole/pi-hole/pull/1698#issuecomment-331134576 ).
2017-09-21 23:11:44 +10:00
WaLLy3K
909bc92c01
Tweak wording to fit on 80 character screen
...
* Also move colour after $INFO
2017-09-21 00:22:47 +10:00
WaLLy3K
a6f9272d4b
Fix gravity from only parsing one adlist URL
...
* Redirect `grep` correctly to $sources (instead of using `awk`)
* Redirect $sourceDomains correctly
* Replace use of ${COL_LIGHT_BLUE}
* Add numeric count informing user of unique source domains being whitelisted
2017-09-20 22:25:33 +10:00
WaLLy3K
911596daf8
Start and enable FTL prior to running Gravity
2017-09-20 17:29:11 +10:00
Adam Warner
8d8482d60b
<<<$() back to < <()
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-09-19 19:02:50 +01:00
WaLLy3K
f3cc8c71c4
Merge pull request #1691 from pi-hole/new/adminemail
...
Add `pihole -a email` functionality for Block Page contact email
2017-09-19 18:39:37 +10:00
WaLLy3K
f6b3c62b06
Merge pull request #1696 from pi-hole/tweak/removeindexjs
...
Delete index.js
2017-09-19 18:00:48 +10:00
WaLLy3K
26afe04926
Remove index.js test
2017-09-19 01:04:04 +10:00
WaLLy3K
500a755250
Delete superseded file
...
* Functionality is reproduced from within the Block Page
2017-09-19 01:03:24 +10:00
WaLLy3K
d02bf258af
Improve non-standard list parsing
...
* Add 504 status (Gateway connection timed out)
* Add text for non-standard list parsing
* Improve adblock parsing
* Ensure adblock exception rules are removed from file
* Ensure "www." is not treated as a URL-format list
* Corrected typo
* Ensure script does not fail if "-f" is used when there are no blocklists generated
Signed off by WaLLy3K <wally3k@pi-hole.net >
2017-09-18 17:36:03 +10:00
WaLLy3K
56990618e9
Prevent Block Page issue
...
* Block Page expects to see a full stop, otherwise it will throw an unhandled error
2017-09-18 01:12:19 +10:00
WaLLy3K
54a85d3a63
Fix invalid option case
...
* Ensure `pihole -q doubleclick.com asd` exits with error
2017-09-18 00:58:56 +10:00
WaLLy3K
d56beedd7a
Add idn2 dependency
2017-09-18 00:41:53 +10:00
WaLLy3K
c2d3e99ddd
Slow query fix & queryFunc optimisation
...
* Validate modified code using Shellcheck & Strict Bash
* Added and/or elaborated more comments
* scanlist() should exit if /etc/pihole is not available
* Add `export LC_CTYPE=C` to prevent extreme grep slowdown
* Consider "domain.com#comment" an exact match
* Add specialised wildcard searching grep
* Optimise and simplify queryFunc() for readability
* Replace IDN `python` parsing with `idn2`, as `python` is not guaranteed to be available
* Use ${COL_BOLD} when printing filenames
2017-09-18 00:41:26 +10:00
andofrjando
5e48b3f7f7
Fix one mistake where $proto would not be created if $_SERVER['HTTPS'] exists but is not set to on
2017-09-16 11:24:38 +08:00
andofrjando
00d62b3423
This fixes the following bug:
...
If Pi-Hole is behind a reverse proxy that uses SSL, then the block page will not load resources such as `blockingpage.css` and `jquery.min.js` as the insecure `http://` is hard coded. Browsers will block attempts to load insecure resources if the page is loaded of SSL.
The fix is acheived by checking `$_SERVER['HTTPS']` and setting the variable `$proto` to either `http` or `https`. The harcoded `http` is replaced by the contents of this variable.
2017-09-16 10:24:37 +08:00
WaLLy3K
c957124fad
Optimised parsing of domains on IPv6 servers
...
* Remove WHITELIST_COMMAND
* Place IPv4/IPv6 availability test underneath setupVars.conf source
* Improved clarity on comments
* Define default lookupDomain on local line
* Use `getent hosts` instead of nslookup (faster)
* Make gravity_DNSLookup() function more readable
* Use bold on "Neutrino emissions detected"
* Swap conditionals around on adlists file handling
* Add comments to both gravity_Collapse() `awk`s
* Removed unnecessary "${str}" from gravity_Pull()
* Merge function variables into local line
* Place .phgbp suffice on mktemp, so patternbuffers can be cleaned up all at once in gravity_Cleanup()
* Removed success="false" from $httpCode case, placed empty success var in local
* Reordered $httpCode case numerically because I can
* Provide error if Dnsmasq format list is being parsed
* Remove IPv4 check when determining URL list (too slow on large lists)
* Check ${#sources[@]} to ensure we're checking the number of entries and not the character count
* Define empty plural in local line, removing unnecessary plural=;
* Optimised readability of gravity_Whitelist()
* Removed uninformative "Nothing to blacklist"/"No wildcards used" text
* Optimised parsing of domains into hosts format on IPv6 enabled servers
* Ensure /etc/hostname is non-zero
* Use `: >` instead of `rm` as consistent with the rest of the script
* Ensured that gravity_Cleanup() removes ${localList}.tmp
* Optimised readability of gravity_ParseUserDomains()
* Moved dnsRestart to ${var} case statement, renaming it to dnsRestartType for readability
* Set default $listType to ensure script passes "bash strict mode"
2017-09-15 22:39:17 +10:00
WaLLy3K
28063aa7f7
Add administrative contact address functionality
...
* Disable shellcheck for SC1090
2017-09-15 00:24:29 +10:00
WaLLy3K
c458e4a93b
Merge pull request #1420 from WaLLy3K/new/https
...
Disable Let's Encrypt HTTPS & shift functions to block page
2017-09-14 20:40:20 +10:00
WaLLy3K
e7ae62ba76
Merge pull request #1416 from WaLLy3K/blockpage2
...
Block Page 2.0
2017-09-14 20:39:45 +10:00
WaLLy3K
ff5411a93a
Add 'Connection Refused' for 000 status
...
* Shift default dnsRestart value into unset default parameter expansion value
* Change nslookup timeout to 5 seconds
* Use &> instead of >
* Standardise plural code
* Update some comments
* Add "000" when connection is refused
* Condense adblock detection logic
* Add Dnsmasq format detection and parsing logic
* Removed unnecessary echo
* Add dnsWasOffline variable to ensure that if DNS service has been stopped, that it doesn't start and also get reloaded
2017-09-14 20:23:49 +10:00
WaLLy3K
d3073e5e23
Fix array of unique $sourceDomains
2017-09-14 17:09:52 +10:00
WaLLy3K
34ae4844fa
Merge branch 'development' into tweak/gravity
2017-09-14 16:44:14 +10:00
WaLLy3K
8191ec01e5
Gravity Bugfixes
...
* Merge development OpenVPN code
* Determine which domain to resolve depending on existence of $localList
* Re-add code to remove $localList, preventing duplicate local entries
* Minor shellcheck validation fix
2017-09-14 16:39:30 +10:00
WaLLy3K
4d39ab9753
Allow force-reload to be used when restarting DNS
...
* Remove duplicate coltable variable definition and source
* Minor comment modifications
* Add "$2" to restartdns
2017-09-14 16:39:25 +10:00
Adam Warner
7a1df15724
Merge pull request #1688 from pi-hole/tweak/customBlockPage
...
Allow for Custom block page
2017-09-13 18:22:38 +01:00
Adam Warner
42b5574f9b
remove no longer needed tests
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-09-09 19:41:05 +01:00
Adam Warner
5f4be0de35
adjust lighttpd config depending on whether or not custom.php exists
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-09-09 19:30:53 +01:00
Adam Warner
6c605f55f9
always overwrite default blockpage, so that changes can be rolled out
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-09-09 19:07:48 +01:00
Adam Warner
774c6e8ac0
Merge branch 'development' into new/UninstallCleanup
...
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# automated install/uninstall.sh
2017-09-09 18:56:17 +01:00
DL6ER
17be6b860e
Merge pull request #1682 from pi-hole/tweak/VPN_hostnames
...
Add VPN host names to local.list
2017-09-08 22:42:58 +02:00
Adam Warner
474ac4a15d
Merge pull request #1581 from pi-hole/sqlite-dependency
...
Add "php5-sqlite" to dependencies
2017-09-08 21:28:16 +01:00
DL6ER
b8fedf76cd
Merge pull request #1572 from pi-hole/gedetil-development
...
Add web frontend shutdown command
2017-09-08 20:21:20 +02:00
DL6ER
ca88c59d4e
Merge pull request #1687 from spacedingo/patch-2
...
Add ignore-case switch to sort (domains)
2017-09-08 20:17:38 +02:00
Mcat12
d69e62589a
Merge branch 'development' into sqlite-dependency
2017-09-08 13:43:26 -04:00
DL6ER
c9d4995900
Update to comply with current development code
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-09-08 19:35:05 +02:00
DL6ER
279e809aaf
Use poweroff instead of halt
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-09-08 19:33:06 +02:00
Mcat12
d61857efae
Merge branch 'development' into patch-2
2017-09-08 13:32:51 -04:00
DL6ER
0d037e96fb
Merge branch 'development' into gedetil-development
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
Conflicts:
advanced/Scripts/webpage.sh
2017-09-08 19:32:38 +02:00
Mcat12
6376f9aef4
Merge pull request #1680 from pi-hole/colour-consistency
...
Colour output consistency
2017-09-08 13:29:55 -04:00
spacedingo
f5a1fa21f7
Add ignore-case switch to sort (domains)
...
Domains with caps pass off as unique. It is necessary for proper duplicate removal.
Example:
::: /etc/pihole/list.preEventHorizon (2 results)
adsatt.abcnews.starwave.com
Adsatt.ABCNews.starwave.com
2017-09-08 20:36:14 +04:00
DL6ER
4a90dac68e
Simplify awk code as the format of ipp.txt is actually fixed (only one entry per line is allowed)
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-09-07 19:42:00 +02:00
DL6ER
2624e56de5
Parse /etc/openvpn/ipp.txt (if existing) and add entries to local.list.
...
Signed-off-by: DL6ER <dl6er@dl6er.de >
2017-09-06 16:54:41 +02:00
Adam Warner
aef54d6694
Merge branch 'development' into new/UninstallCleanup
2017-09-05 20:41:13 +01:00
Adam Warner
e839a7784c
Merge branch 'development' into sqlite-dependency
2017-09-05 20:39:45 +01:00
WaLLy3K
bea99abd8d
Ensure colour consistency between terminal themes
...
* Comment file for review-ability
* Add BOLD and UNDERLINE options
* Select most readable colours out of LIGHT/DARK options
* Provide empty variables for `set -u`
* Deprecate unnecessary variables
* Correct colours for TICK/CROSS/DONE
* Escape r twice and add ESC to OVER
2017-09-05 23:28:33 +10:00
WaLLy3K
a5c4ae955a
Merge branch 'development' into tweak/gravity
2017-09-03 15:28:41 +10:00
Dan Schaper
d7d53849a3
Merge pull request #1628 from pi-hole/fix/issue-template
...
Update Issue/PR Template text
2017-09-02 04:55:56 -07:00
WaLLy3K
b354f722be
Add link for EUPL
...
* Also formatted `git rebase` text to be consistent with `git commit --signoff`
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-09-02 21:52:54 +10:00
WaLLy3K
ea1aad9774
Add review suggestions to template
2017-09-01 10:17:08 +10:00
WaLLy3K
817d644795
Merge branch 'development' into fix/issue-template
2017-09-01 10:16:03 +10:00
WaLLy3K
56b8c4bfdb
Merge branch 'development' into tweak/gravity
2017-09-01 10:01:41 +10:00
Adam Warner
c65c26b463
Merge branch 'development' into new/UninstallCleanup
2017-08-31 15:36:47 +01:00
WaLLy3K
bf059e5ee8
Merge pull request #1676 from pi-hole/remove-netstat
...
Replace superseded netstat command
2017-08-31 21:16:11 +10:00
WaLLy3K
15a5f425bf
Replace nc with psuedo-device
...
* Also fix minor conditional style issue
2017-08-31 20:32:02 +10:00
WaLLy3K
3125d24ded
Replace superseded netstat command
...
* Make colfile readonly, and use path of PI_HOLE_SCRIPT_DIR
* Rename piholeStatus function to statusFunc for function name consistency
* Replace superseded netstat command with nc
* Perform addn-hosts check using a single grep subshell
2017-08-31 17:39:41 +10:00
Adam Warner
6b6d105c2f
Merge branch 'development' into sqlite-dependency
2017-08-28 10:17:33 +01:00
WaLLy3K
bab44c52ae
Merge branch 'development' into blockpage2
2017-08-28 13:30:57 +10:00
WaLLy3K
2f19605750
Merge branch 'development' into fix/issue-template
2017-08-28 13:29:18 +10:00
WaLLy3K
7311db3a63
Change wording to support feature PR's
...
* Also clarify template suggestion text
* Remove stray '
2017-08-28 13:28:23 +10:00
WaLLy3K
0a00936e99
Update resolver test & added more comments
...
* Add/update code comments
* Change resolver check to test for pi.hole
* Make resolver check timeout after 10 seconds
* Use > instead of &> where appropriate
* Make resolver check sleep for 30 seconds (effectively waiting up to 50s for dnsmasq to be resolvable)
* Provide confirmation upon success of resolver check availability
* Quotes and Braced remaining variables as appropriate
* Removed duplicate local
2017-08-28 11:36:02 +10:00
WaLLy3K
7cac207c00
Merge branch 'development' into tweak/gravity
2017-08-28 03:11:38 +10:00
WaLLy3K
feb412b02a
Merge pull request #1671 from pi-hole/release/3.2
...
Update development from release/3.2
2017-08-28 03:04:46 +10:00
Adam Warner
199de9ebc0
Merge branch 'development' into new/https
2017-08-27 11:38:30 +01:00
Adam Warner
504ae0193f
Merge branch 'development' into blockpage2
2017-08-27 11:23:21 +01:00
WaLLy3K
1ae403b742
Merge pull request #1667 from pi-hole/install-space
...
Remove erroneous space
2017-08-24 14:00:20 +10:00
Adam Warner
939c99cdbf
accidentally an entire group of letters.
2017-08-23 11:48:11 +01:00
WaLLy3K
2f36acae49
Remove errornous space
2017-08-23 11:51:16 +10:00
Adam Warner
e938132c53
accidentally a space
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 21:02:10 +01:00
Adam Warner
1b34286264
verbiage
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 20:33:53 +01:00
Adam Warner
54f4f6d2d7
Add "${INSTALLER_DEPS[@]}" to package array
...
add `-f` to rm commands so that `set -e` is not kicked
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 20:23:07 +01:00
Adam Warner
07e5e8e67a
need to include PH_TEST="true" so that the install script isn't run when sourcing it.. doh
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 20:03:19 +01:00
Adam Warner
3c25094495
No need to declare PKG_MANAGER, as it's already declared in basic-install
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 19:56:36 +01:00
Adam Warner
95e3a5944d
Initial overhaul of uninstall script sourcing distro_check() from basic-install.sh Totally untested as yet...
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 19:53:43 +01:00
Adam Warner
64f29120c8
indent nested function in basic-install.sh
...
fix dependency in uninstall.sh
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-17 19:43:07 +01:00
Adam Warner
d92434b1e9
Merge branch 'development' into sqlite-dependency
...
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# automated install/basic-install.sh
2017-08-16 16:31:47 +01:00
Adam Warner
01cd056bcc
Work out correct SQLITE version for php-sqlite
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-16 16:27:50 +01:00
Adam Warner
56f2ea3ec2
Add Fedora/Centos dependency
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-08-16 15:56:39 +01:00
Adam Warner
d45695a088
Merge pull request #1643 from pi-hole/tweak/PiholeCheckout
...
Small tweaks to output of `pihole checkout`
2017-08-04 00:19:46 +01:00
Adam Warner
2ceeac41fe
Merge pull request #1648 from pi-hole/branding/DOReadme.md
...
Branding/DO readme.md
2017-08-02 11:29:31 +01:00
WaLLy3K
cc4ada99d8
Use SIGHUP instead of force-reload
2017-08-01 20:48:43 +10:00
Adam Warner
16d67f55b3
Merge branch 'development' into fix/issue-template
2017-07-29 17:18:16 +01:00
Adam Warner
18b41adbf6
Merge branch 'development' into tweak/gravity
2017-07-29 17:14:39 +01:00
Mcat12
898fdf7a60
Merge pull request #1602 from molikuner/development
...
Fix URL extension parsing
2017-07-29 11:49:24 -04:00
Adam Warner
78143c2ff4
Merge branch 'development' into blockpage2
2017-07-29 16:44:28 +01:00
Adam Warner
7b1524ad01
Merge branch 'development' into new/https
2017-07-29 16:44:20 +01:00
Adam Warner
5799485b0f
Merge branch 'development' into development
2017-07-29 16:29:57 +01:00
Mcat12
9cddb6ca39
Merge branch 'release/3.2' into branding/DOReadme.md
2017-07-29 11:04:10 -04:00
Dan Schaper
defc17ba46
Remove DO from README.md
...
Preparation for futher infrastructure changes. Will remove the DO slug from README and adjust some wording.
2017-07-28 20:24:27 -07:00
Adam Warner
106d5afba1
Merge pull request #1646 from pi-hole/bugfix/DoubleH
...
Stop an extra `h` being added to leasetime of DHCP server.
2017-07-28 23:09:00 +01:00
Adam Warner
0a9965292c
Additional check to fix any existing cases of "24h" in setupVars.conf automatically.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-28 19:40:13 +01:00
Adam Warner
4fb66e632f
The other h
2017-07-28 16:30:03 +01:00
Adam Warner
5787895794
stop an extra h being added to leasetime of DHCP server. We already storethe h in setupVars.conf
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-28 16:10:13 +01:00
Adam Warner
d90489b31d
Include branch we're switching from
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-27 22:21:25 +01:00
Adam Warner
f38912a0c9
- Correctly overwrite ${INFO} boxes with ${CROSS} etc
...
- Notify user that branch has been changed
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-27 21:33:41 +01:00
WaLLy3K
f24ab8508e
WIP cleanup
...
* Changed supernova/eventHorizon variables to match their purpose
* Add gravity_DNSLookup() function
* Ensure all comments are clear and relevant
* Use && instead of || in gravity_Collapse()
* Renamed existing functions, and placed them in order of script execution
* Use \t instead of literal tab in gravity_ParseFileIntoDomains()
* Replace instances of "truncate" with : > (e.g: gravity_Schwarzschild())
* Ensure correct variables are local'd
* Use phrase "Cleaning up stray matter" when gravity_Cleanup() is called
* Add black/white/wildcard switches for list.sh
* Ensure necessary functions are called when modifying black/white/wildcards
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-27 12:34:35 +10:00
WaLLy3K
2d8fff099f
Pass correct options to gravity.sh
...
* Optimise $validDomain function by using bashism and `grep`
* Add black/white/wildcard variables to pass to Reload()
* Revert reload variable behaviour
* Ensure Reload() function passes correct options to gravity.sh
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-27 12:34:26 +10:00
Adam Warner
dce36d8ded
Merge branch 'master' into release/3.2
2017-07-26 19:49:57 +01:00
Mcat12
18d0278279
Merge pull request #1638 from pi-hole/hotfix/CIDR
...
CIDR hotfix > development
2017-07-26 14:41:03 -04:00
Adam Warner
4e525040f3
Merge branch 'development' into hotfix/CIDR
2017-07-26 18:23:02 +01:00
WaLLy3K
fdf2649f2f
Clean up known remaining colour output issues ( #1613 )
...
* Print newline on error message
* Output last three lines of error if update fails
* Consistent error messages & housekeeping
* Add shellcheck directive to ignore COL_TABLE
* Quoted and braced variables for codebase consistency
* Escaped newlines correctly
* Made error messages consistent (indenting and wording)
* Removed consecutive echos
* Conditional formatting consistency
* Braced, quoted and used [[ on conditionals
* Fix specific ShellCheck issues
* Fixed issues that could be safely changed without extensive testing
* Update SELinux whiptail behaviour & more
* Colourised some strings
* Fixed multiple line string indenting
* Made output consistent with existing codebase
* Removed sequential echos
* Make SELinux whiptail use "--defaultno", and change text wording
* Add help text for hostrecord, and colourise output
* this should fix the tests...
Signed-off-by: Adam Warner <adamw@rner.email >
* revert changes to `update_package_cache()` to prove tests
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-26 18:00:08 +01:00
Mcat12
b09c660833
Always process DNS and DHCP settings in installer ( #1630 )
...
* Always process DNS and DHCP settings in installer
* Make sure dnsmasq config exists before modifying it
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
* Make sure the dnsmasq config directory exists
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
* Only remove the DHCP config if it exists (fixes tests, hopefully)
Signed-off-by: Mcat12 <newtoncat12@yahoo.com >
2017-07-26 17:15:23 +01:00
Adam Warner
c02a24cf71
Fix/unbreak development ( #1635 )
...
* Always process DNS and DHCP settings in installer
* change where finalExports is called and where LIGHTTPD_ENABLED is set.
Signed-off-by: Adam Warner <adamw@rner.email >
* this may or may not work. If it does, can be functionised to reduce code duping
Signed-off-by: Adam Warner <adamw@rner.email >
* This will fix the tests, but break the patch
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-26 14:34:40 +01:00
Mcat12
a77136bd1d
Merge pull request #1600 from pi-hole/tweak/OnlyDownloadFTLNew
...
Only download FTL if a newer version than currently installed is detected (or if no version is detected)
2017-07-25 22:11:31 -04:00
WaLLy3K
e0eb5eb2b1
Fix queryFunc if adlists URLs have been removed ( #1618 )
...
* Fix queryFunc if adlists URLs have been removed
* Allow for -adlists command line switch (where the "s" is a typo)
* Add error message when unable to find associated adlists URL
* Provide PR fix on current dev version
* Add blResult variable for white/black match
* Supporting Block Page queryFunc fixes
* Re-add unmerged lines
2017-07-25 23:07:06 +01:00
WaLLy3K
714fd93292
Provide correct FTL stats ( #1619 )
...
* Provide correct FTL stats
* Use the correct lines in the array when displaying FTL stats
* Treat ads_blocked_today/dns_queries_today as currency, like domains_being_blocked is on large screens
* Chronometer Shellcheck validation
* Remove unnecessary \ from CPU usage readout
2017-07-25 23:03:23 +01:00
Adam Warner
a293b5a371
prevent ./automated install/basic-install.sh: line 1886: /usr/bin/pihole-FTL: No such file or directory on new install, or if pihole-FTL is missing for whatever reason.
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-25 22:49:06 +01:00
Adam Warner
1c93868ae1
Adjust wording of echos
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-24 23:22:04 +01:00
WaLLy3K
61ff0452e1
Remove duplicate code
...
* Make RestartDNS() use `pihole restartdns`
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-24 21:27:12 +10:00
WaLLy3K
406098e55a
Speed up refresh time
...
* Add "--blacklist-only" to only run essential gravity functions
* Pass "--wildcard" option to `gravity.sh` to ensure dnsmasq is restarted
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-24 21:26:39 +10:00
WaLLy3K
a2825be819
Add dnsmasq "force-reload" option
...
* Made use of $PI_HOLE_SCRIPT_DIR
* Fix #1610 & #1624
* Add "$2" to restartDNS options
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-24 21:25:04 +10:00
WaLLy3K
6830b08723
Clean up and optimise Gravity
...
* Shellcheck validation
* Made variable names, function names, comments and output clearer to understand
* Quoted and braced variables and conditionals
* Fix adlists.list handling logic, and remove any CR line endings
* Make CP/MV/RM provide user-friendly output upon failure
* Change adlists.list retrieval logic
* Moved and fixed adlists.list domain parsing logic
* Create gravity_ParseFileAsDomains() function to handle parsing of source files
* If no changes to a list is detected, print no output
* Ensure each source blocklist has a final newline
* Format number output as currency
* Make array of adlists domain sources unique to prevent redundant whitelisting
* Merged bash IPv4/IPv6 hosts formatting IF statement into an awk one-liner
* Trap Ctrl-C cancellations and run gravity_Cleanup()
* Use new gravity_Cleanup() function on errors and script completion
* Ensure that dnsmasq uses force-reload when gravity is invoked
* Add --wildcard option to ensure dnsmasq is restarted upon b/wlisting of a wildcard
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-24 21:24:34 +10:00
WaLLy3K
eead2f059b
Add review suggestions to Issue Template
...
* Use a more relevant link when explaining debug
* Re-add feature request note
2017-07-23 11:06:43 +10:00
WaLLy3K
291c111ce8
Update PR Template text
...
Signed-off-by: WaLLy3K <wally3k@pi-hole.net >
2017-07-22 15:29:36 +10:00
WaLLy3K
2ccf063dfe
Update Issue Template text
2017-07-22 15:15:39 +10:00
WaLLy3K
49aee8b931
Fixed development branch check
2017-07-19 12:26:00 +10:00
WaLLy3K
f2a3b557c8
Updated Block Page to work with queryFunc output
2017-07-19 00:15:59 +10:00
Adam Warner
b0eceddcec
Merge pull request #1617 from pi-hole/hotfix/CIDR
...
Hotfix/cidr (Pi-hole 3.1.1)
2017-07-18 09:39:20 +01:00
Adam Warner
0a062d26e6
Merge pull request #1611 from pi-hole/developmentNew
...
Sort out Merge conflicts with master
2017-07-17 14:49:55 +01:00
Adam Warner
20b2dd6b19
Merge pull request #1567 from pi-hole/tweak/checkout_FTL
...
Add pihole checkout ftl
2017-07-17 14:38:30 +01:00
Adam Warner
83592a5e70
Put '"'s in the right place
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-17 11:18:03 +01:00
Adam Warner
70fb733fea
col_table does not exist yet, will break the install if pushed as hotfix.
...
Not sure why these additional "'s were put in, they break the update command, too.
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-17 10:53:49 +01:00
Adam Warner
eb8333c772
Merge branch 'development' into developmentNew
2017-07-16 16:45:33 +01:00
WaLLy3K
c9a98b68c8
Avoid reactivating a deactivated lighttpd service ( #1485 )
...
* Do not activate disabled lighttpd upon update
* Fixes #1362
* Use systemctl when available
* Move `finalexports` to the very end of the install script
set value of LIGHTTPD_ENABLED to 1 or 0 depending on whether or not lighttpd is enabled or disabled.
actually save LIGHTTPD_ENABLED value to setupvars.conf
Signed-off-by: Adam Warner <adamw@rner.email >
* add [[ -z "${LIGHTTPD_ENABLED}" ]] back in!
Signed-off-by: Adam Warner <adamw@rner.email >
* Ensure "Loaded:" is the line being checked
* Colourise disabled lighttpd message
* Prevent disabled lighttpd triggering error
* change of plan, don't need that [[ -z "${LIGHTTPD_ENABLED}" ]]
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-16 16:44:14 +01:00
Adam Warner
247d3ed729
list availible branches for FTL
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-16 13:54:23 +01:00
Adam Warner
031c6428d5
Merge branch 'tweak/checkout_FTL' of https://github.com/pi-hole/pi-hole into tweak/checkout_FTL
...
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# advanced/Scripts/piholeCheckout.sh
2017-07-16 13:34:20 +01:00
Adam Warner
f2e9d585f7
* Add helptext for pihole checkout ftl
...
* Only attempt to install FTL if branch was found
* ~~corebranches~~ webbranches (web branches now actually listed)
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-16 13:33:00 +01:00
WaLLy3K
8af9853b9a
Fixed minor formatting issues
...
* Removed useless echo
* Quoted and braced conditionals
* Explicit escaping of newline
* Fixed arrays implicitly concatenating (SC2199)
* Fixed incorrect variable used in checkout web
2017-07-16 22:32:34 +10:00
Adam Warner
783f50657b
Merge branch 'development' into tweak/checkout_FTL
...
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# advanced/Scripts/piholeCheckout.sh
2017-07-16 12:25:27 +01:00
WaLLy3K
3a50b91722
User-friendly queryFunc() output ( #1483 )
...
* User-friendly queryFunc() output
* Silence grep errors
* Provide 'pihole -q -h' help output
* Rewrite option handling
* Loop through grep stdout to make query output user friendly
* Add -adlist option to show block list URL instead of internal file name
* Limit general searches to 10 matches per block list
* Add -all option to override 10 match limit
* Fixed 'pihole -h' wording
* Further query optimisations
* Optimised scanList() output by switching folder
* Re-added processWildcards() function
* Added "-bp" exact matching option for use with block page
* Standardised query output
* Separated wildcard search from blacklist/whitelist search
* Optimised sorting by sorting glob output and not scanList() output
* Fixed result skipping
* Add text for wildcard result on exact query
* Fix wildcard result output
* Multiple wildcard matches on exact query could cause unexpected output
* Remove unnecessary replacement
* Make grep only output matching text
* HOSTS format lists will also output the IP address
* That substitution was necessary
* Remove IP address from HOSTS format lists
* Filter unwanted content
* Add /dev/null to grep, to always print file name (even when searching only one block list)
* Use three seds to remove unwanted content from block lists
* Merge with development
* Simplify queryFunc code
2017-07-15 11:56:40 +01:00
WaLLy3K
3631d1349e
Prevent Web Admin from printing restartdns colour codes ( #1575 )
...
* Prevent Web Admin from printing unnecessary msgs
* Make DNS restart behaviour consistent
2017-07-15 11:11:06 +01:00
Dan Schaper
05c8687041
Integrate DL's update.sh fixes.
...
`shellcheck -x` for following files.
Do not test for included files SC1091
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# advanced/Scripts/update.sh
2017-07-14 22:40:34 +01:00
Dan Schaper
66f32b7601
Remove testing for debug as this is getting a re-write by Jacob.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-07-14 22:39:13 +01:00
Dan Schaper
9101916719
Test exclusion for sourced files SC1090.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-07-14 22:39:04 +01:00
Adam Warner
edb594461d
Remove CIDR from IPv6 address when detecting it in the install script
...
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# automated install/basic-install.sh
2017-07-14 22:31:43 +01:00
Mcat12
9464b71a6e
Remove /* from IPv6 as well as IPv4
...
Fixes Discourse issue: https://discourse.pi-hole.net/t/ipv6-aaaa-dns-issue/3830
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# gravity.sh
2017-07-14 22:29:16 +01:00
Adam Warner
7d56e2a937
FTL has an L in it, innit?
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-14 20:54:41 +01:00
Adam Warner
218aa03f05
Merge branch 'developmentNew' of https://github.com/pi-hole/pi-hole into developmentNew
2017-07-14 20:50:52 +01:00
Adam Warner
1db03a10d7
Merge branch 'master' into developmentNew
2017-07-14 20:47:49 +01:00
Jacob Salmela
e1f818ffb7
Tweak/debug improvements ( #1585 )
...
* check for CIDR notation when comparing IPv6 address to that found in setupVars.conf
* highlight bad address entries in pihole.log and reference a corresponding FAQ
* show header output if Pi-holes x-header does not match
* fix automated mode when running from the dashboard. It would previously not automatically upload and generate a token.
* show disclaimer message
* undocumented feature for now: obfuscate domains in pihole.log so they are not visible when sent to the Pi-hole developers. We need to make an additonal flag for this in the pihole command. if the variable OBFUSCATE has a value, it will replace the domain in the log with a placeholder value
* fix small typo in the disclaimer
2017-07-14 16:53:45 +01:00
Molikuner
9934f505a5
Fix URL extension parsing
...
when there is a querystring Pi-hole sometimes parsed a wrong extension
2017-07-13 23:18:40 +02:00
Dan Schaper
8c2b8f7241
Merge pull request #1599 from pi-hole/tweak/readme
...
Fix extentions of the JPG images
2017-07-12 17:40:56 -07:00
Adam Warner
bf70c2c660
initial changes to tests to take into account changes to strings
...
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-12 22:57:57 +01:00
Adam Warner
74b912a0b7
Check if FTL is already installed, do not download if it is detected, and the sha1sum matches the remote
...
This will probably break some tests. I'll work that out in a bit
Signed-off-by: Adam Warner <adamw@rner.email >
Signed-off-by: Adam Warner <adamw@rner.email >
2017-07-12 22:37:51 +01:00
Dan Schaper
93d40b083e
Fix extentions of the JPG images
...
Some images are jpg and not png.
2017-07-12 11:40:18 -07:00
Jacob Salmela
162ee28d0c
Merge pull request #1597 from pi-hole/tweak/readme-trademarks-and-more
...
Update README with ® and several other improvements to better describe v3.2
2017-07-12 08:25:49 -05:00
Jacob Salmela
d328d17d03
Merge pull request #1586 from pi-hole/enhance/comments-in-installer
...
Install Script: Add comments for nearly every line of code
2017-07-12 07:49:35 -05:00
Dan Schaper
2778d88e8a
Fix missing then clause
2017-07-12 00:12:54 -07:00
Jacob Salmela
b5c6178644
Merge remote-tracking branch 'origin/development' into enhance/comments-in-installer
...
merge in development
2017-07-12 01:38:49 -05:00
Jacob Salmela
ea8927e1da
add facebook page to contact info
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-12 01:21:47 -05:00
Jacob Salmela
bc1065a7fc
reorganize sections. install instructions first. also added more wordsmithing and links to interesting pi-hole.net articles
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-12 01:18:50 -05:00
Jacob Salmela
f4c7d389e5
more wordsmithing and updating links
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-12 01:03:09 -05:00
Jacob Salmela
03387391de
wordsmith DHCP server section, API section, and chronometer2 section. Also add more images
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-12 00:53:14 -05:00
Jacob Salmela
24df5f5208
describe settings page in the order they appear on the dashboard--also add screenshots
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-12 00:36:12 -05:00
Jacob Salmela
9348a8ab15
move technical details to the bottom of the page in light of showing off Pi-holes features first.
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-11 23:36:40 -05:00
Jacob Salmela
fbd55dd740
tweaks to donation verbiage
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-11 23:33:49 -05:00
Jacob Salmela
e5e26413e9
new executive summary above the fold
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-11 23:28:47 -05:00
Jacob Salmela
527fe2f5e1
wordsmithing using Pi-hole as your DNS server, gravity, and additional blocklists.
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-11 23:06:42 -05:00
Jacob Salmela
38d213ee6c
add section about additional ways to support us
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-11 22:55:50 -05:00
Jacob Salmela
613f2d3b86
Pi-hole is now a registered trademark: replace ™ with ®
...
Signed-off-by: Jacob Salmela <github@decoy.email >
2017-07-11 22:51:20 -05:00
Jacob Salmela
e7ad972783
fix thre spelling errors
2017-07-10 14:12:30 -05:00
Jacob Salmela
2f939d8c56
fix two spelling errors
2017-07-07 09:05:19 -05:00
Jacob Salmela
7ef751f96d
Merge pull request #1587 from pi-hole/fix/1430
...
Show text typed when pressing Ctrl+C after using pihole -a -p
2017-07-06 20:59:41 -05:00
Jacob Salmela
fb66fb12c5
put "no password will be set" on a newline.
2017-07-06 20:54:09 -05:00
Jacob Salmela
042dcf795c
fixes #1430
2017-07-06 20:44:40 -05:00
Jacob Salmela
aad39c5ffc
add comments for nearly every line of code.
2017-07-06 19:25:56 -05:00
Dan Schaper
c3ed710e31
Merge pull request #1565 from pi-hole/revamp/debug
...
Revamp of debug script with logic and colours
2017-07-05 15:12:36 -07:00
Jacob Salmela
cb65907e60
Merge branch 'development' of https://github.com/pi-hole/pi-hole into revamp/debug
...
merge in development to avoid shellcheck from travis
2017-07-05 16:55:34 -05:00
DL6ER
bb8a263d70
ShellCheck
2017-07-05 19:34:20 +02:00
DL6ER
70fd94edb3
Edit message when requested branch of FTL is not available
2017-07-05 19:30:05 +02:00
WaLLy3K
d0492898eb
Add "php5-sqlite" to uninstall dependencies
2017-07-05 17:21:17 +10:00
WaLLy3K
c6ba03802f
Add "php5-sqlite" to dependencies
2017-07-05 17:18:21 +10:00
WaLLy3K
1bebcef265
Make Chronometer usable on smaller screens ( #1518 )
2017-07-04 13:52:51 +10:00
WaLLy3K
209fbf82c4
Colourise tailFunc ( #1550 )
...
* Colourise tailFunc
* Strip month, day number and dnsmasq[PID]
* Blocked domains show as light red
* Queries show as standard colour
* Everything else as dark gray
* Change tailFunc highlighted lines
* Highlight Blocked/Blacklist/Wildcard lines as red
* Make DHCP lines default colour
* Make sure tailFunc doesn't match on domain names
2017-07-02 15:21:00 +02:00
DL6ER
6ce79ae1d0
Fix git commands ( #1577 )
2017-07-01 23:52:10 +02:00
Adam Warner
b3eb5c4f0e
Colour Tweaks ( #1549 )
2017-07-01 22:08:17 +10:00
DL6ER
ec4e9780ed
Accept underscores when validating domain names ( #1571 )
2017-06-30 22:52:33 +10:00
Adam Warner
22abbffbb7
Merge branch 'development' of https://github.com/gedetil/pi-hole into gedetil-development
...
Signed-off-by: Adam Warner <adamw@rner.email >
# Conflicts:
# advanced/Scripts/webpage.sh
2017-06-29 19:47:32 +01:00
Jacob Salmela
05a724afae
codacy appeasement: remove useless cats
2017-06-29 11:49:28 -05:00
Jacob Salmela
1957b002bc
add comments about X-Headers and further explain the file descriptor cod.
2017-06-29 11:37:58 -05:00
Jacob Salmela
04cef25add
remove color character codes before uploading so the log is more readable on our plaintext tricorder server
2017-06-29 11:17:19 -05:00
Adam Warner
ab1a6d8829
Fix install script using IPv6 CIDR notation ( #1570 )
2017-06-29 11:18:52 +10:00
DL6ER
98afb0e998
pihole checkout ftl
2017-06-27 14:28:05 +02:00
DL6ER
e9d81fc883
Backend additions for aufit log feature ( #1399 )
2017-06-27 10:53:24 +02:00
Jacob Salmela
22fac5e1e0
additional shellcheck fixes
2017-06-26 22:03:45 -05:00
Jacob Salmela
b6a2a4ad5a
more shellcheck fixes
2017-06-26 21:51:41 -05:00
Jacob Salmela
5f00347019
appease shellcheck by removing two unneccesary functions and making some if/else blocks
2017-06-26 21:34:39 -05:00
Mcat12
89a22ded54
Merge pull request #1564 from pi-hole/fix/ipv6-cidr
...
Fix gravity generation when IPv6 CIDR is present
2017-06-26 10:04:06 -04:00
Mcat12
1e31fa89aa
Remove /* from IPv6 as well as IPv4
...
Fixes Discourse issue: https://discourse.pi-hole.net/t/ipv6-aaaa-dns-issue/3830
2017-06-26 09:51:21 -04:00
Dan Schaper
b477b7f777
Merge pull request #1539 from mterron/patch-1
...
Add support for PowerPC architecture
2017-06-25 19:37:23 -07:00
Mcat12
0de15f7a97
Merge branch 'development' into patch-1
2017-06-25 18:15:33 -04:00
Mcat12
35ecf40259
Merge pull request #1545 from pi-hole/dschaper-patch-1
...
Update PULL_REQUEST_TEMPLATE.md
2017-06-25 18:13:30 -04:00
Mcat12
009363a7bb
Merge pull request #1560 from pi-hole/fix/ad-domain-hostname
...
Move local.list after the ad blocking lists
2017-06-25 18:11:48 -04:00
Mcat12
a3758612ec
Merge pull request #1556 from pi-hole/fix/invalid-ipv6-wildcard
...
Fix wildcarding with IPv6
2017-06-25 18:09:26 -04:00
Mcat12
8dc94e014f
Merge branch 'development' into fix/invalid-ipv6-wildcard
2017-06-25 18:04:38 -04:00
Dan Schaper
ad886ac164
Merge branch 'development' of github.com:pi-hole/pi-hole into dschaper-patch-1
2017-06-25 15:03:56 -07:00
Mcat12
78e7c8b8e9
Merge branch 'development' into fix/ad-domain-hostname
2017-06-25 18:03:16 -04:00
Dan Schaper
3779085051
Merge pull request #1562 from pi-hole/tweak/shellcheck
...
Tweak ShellCheck Tests
2017-06-25 14:45:45 -07:00
Dan Schaper
c29c4ceb0f
Integrate DL's update.sh fixes.
...
`shellcheck -x` for following files.
Do not test for included files SC1091
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-06-25 14:39:09 -07:00
Dan Schaper
07fc047dd8
Remove testing for debug as this is getting a re-write by Jacob.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-06-25 12:26:16 -07:00
Mcat12
bc46694ea7
Move local.list after the ad blocking lists
...
Fixes the bug found by [Reddit](https://www.reddit.com/r/pihole/comments/6j3az9/urls_in_my_blacklist_are_showing_up_as_my_default/ )
2017-06-25 12:18:09 -04:00
Dan Schaper
0c2827e130
Test exclusion for sourced files SC1090.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-06-24 15:49:16 -07:00
Mcat12
cb09e0bc9a
Strip /* from the end of the IPv6 address
...
Fixes #1536
2017-06-24 11:14:23 -04:00
Dan Schaper
06d5ea9d51
Grammar and signoff instructions.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-06-22 12:59:07 -07:00
Dan Schaper
a4650c6226
Update PULL_REQUEST_TEMPLATE.md
2017-06-21 08:26:59 -07:00
Dan Schaper
c85a603491
Update PULL_REQUEST_TEMPLATE.md
2017-06-21 08:19:19 -07:00
Adam Warner
536585b846
Colourise Core Output Text ( #1471 )
...
* Define colours within COL_TABLE
* Do not output colours for non-terminal instances
* Removed ":::"
* Fixed indenting & spacing
* Made output consistent throughout project
* Reworded text to fit on standard 80 char wide Terminal screen
* Made 'sudo raspi-config' warning (insufficient disk space) only show on RPi
* Make "Installation/Update Complete" the final msg
* Remove redundant messages
* Simplify update available message
* Confirm user would like to begin uninstall
* If "git pull" string says "Already up-to-date.", place [i] before it
* Colour Temp/Interface output
* Made `pihole disable 5z` invalid
* Added error fallback if invalid argument (not s/m) is detected
* Quoted "$2" for consistency
* Updated help text
* L185/286: Replaced echo with redirect
* User agents for adblock.mahakala.is/adaway.org unnecessary
* Print newline on confirmation of repository reset
* Add output to admin-related dnsmasq restarts
* Return error message for "pihole -q"
* Imply default checkout behaviour with y/N
* Fix uninstall failing to remove pihole user
* Print checkout 'git remote show origin' STDERR on new line
* Replaced checkout "AdminLTE" wording with "Web Admin"
2017-06-21 21:49:05 +10:00
Adam Warner
ecde222512
[Staging] 3.1 ( #1502 )
...
* Fix handling of wildcard help text
* Rewrite help text for better handling of params
* Replace misleading letter variable
* stash changes on branch switch, else it fails if any changes have been made.
* Make changes according to comment in #1384
* Update queryFunc()
* Allow scanList() to search files using a wildcard by removing quotes wrapped around `${list}`
* scanList() will not provide a domain ouput on each string if exact is specified (`grep -l`)
* Remove unused processWildcards() function
* Return a message if no domain is specified
* IDN domains are converted to punycode when running a `pihole -q` search if the `python` package is available, otherwise will revert to current behaviour
* Scan Blacklist & Wildcards first, exiting from search if a match is found (Fixes #1330 )
* Use one `grep` subshell to search for all "*.domains" lists at once (opposed to looping to get every matching file name, and then spawning a `grep` instance for every matching file)
* queryFunc() will not return "(0 results)" output from files where no match is found
* Sort results based off list number
* Return a message if no results are found
* Update basic-install.sh
* Update block page. Allow for setupVars setting of CUSTOMBLOCKPAGE (bool) to prevent it being overwritten
* simplify
* further simplify
* fix inteliJ IDEA complaints
* even further simplify
* tidy up output
* revert line, looks tidyer
* clarify
* Revert "Ensure any changes to blocking page are updated."
* We test for dpkg lock on line 830 directly, no need for the check also
in the template section.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* Display FTL version & version.sh rewrite
While testing to make sure `pihole -v` would output `pihole-FTL version`, I noticed some options didn't work how I expected them to. For example, if I use `pihole -v -p`, I would expect to see the version output of Pi-hole Core. Instead, I'm informed that it's an invalid option.
I've had the following things in mind while rewriting this:
* I'm operating under the assumption that FTL is only installed if the Admin Console is (Line 113 exit 0)
* I have modified the help text to only output with `pihole -v --help`
* I have modified all output to be more similar to the output style of `grep` and `curl` (Ditching ":::")
Testing output:
```
w3k@MCT:~$ pihole -v
Pi-hole version is v3.0.1-14-ga928cd3 (Latest: v3.0.1)
Admin Console version is v3.0-9-g3760482 (Latest: v3.0.1)
FTL version is v2.6.2 (Latest: v2.6.2)
w3k@MCT:~$ pihole -v -c
Current Pi-hole version is v3.0.1-14-ga928cd3
Current Admin Console version is v3.0-9-g3760482
Current FTL version is v2.6.2
w3k@MCT:~$ pihole -v -l
Latest Pi-hole version is v3.0.1
Latest Admin Console version is v3.0.1
Latest FTL version is v2.6.2
w3k@MCT:~$ pihole -v -p --hash
Current Pi-hole hash is a928cd3
w3k@MCT:~$ pihole -v -a --hash
Current Admin Console hash is 3760482
w3k@MCT:~$ pihole -v --help
Usage: pihole -v [REPO | OPTION] [OPTION]
Show Pi-hole, Web Admin & FTL versions
<Shows all Repositories and Options>
w3k@MCT:~$ pihole -v -foo
Invalid Option!
```
* Update -h to work as --hash
Also provide error output as per https://github.com/pi-hole/pi-hole/pull/1447#issuecomment-300600093
* Perform EXACT searches on HOSTS lists correctly
`\s` on the end may be overkill, but it is the existing scanList() behaviour.
* Fixed indentation
* Minimise string duplication & other minor changes
Instead of duplicating output strings, rewrite core/web/ftlOutput() into one neat versionOutput().
* Modified syntax to be valid for Shellcheck
* Log and echo gateway responses
* Update queryFunc() to search Whitelist
If there is a match in Whitelist/Blacklist/Wildcards, `[ ! -t 1 ]` will cause the search to end if the terminal is closed when the script is called. This has the intended effect of allowing a user to search for a W/B/W domain (as well as all the adlists it's found in) using `pihole -q` via Terminal, but the script will stop searching after a W/B/W match when called by the block page.
* Wrap in double brackets
* Provide remote hashes for version.sh
* Provide remote hashes for comparison
* Use double braces for all conditions (for consistency)
* Suppress potential "cd" error output
* Provide "not applicable" output upon any hash request for FTL
* whitelist on website blocked doesnt work (#1452 )
Since Pi-hole redirects ad domains to itself, accessing the script via de.ign.com is the same as pi.hole in this case. The fix should be as simple as adding a / before admin on this line.
* Solve piholeLogFlush.sh having to be issued 2 x to clear logs (#1460 )
Simplified the command -v syntax, and added a sleep 3 timer to the first execution of the log rotation. The second execution was being issued while the first was still running, thus it would fail and you would have to issue the "Flush Logs" command a second time.
* Use `echo "ABC" | pihole tricorder` to upload to Pi-hole's medical tricorder. Uses SSL if available.
* Update list.sh
I believe this has feature parity with `sed /foo/ Id` but also supports busybox, and my alpine docker ;)
* Document `sed` substitution for user readability
Comment the oneliner with explanations of what each step does.
* Update Help Output (#1467 )
* File consistency
* Tabs to 2 spaces
* Corrected indenting
* Double braced conditionals
* Quoted variables within conditionals
* Standardise core help text
* Added help text for disable command
* Added help text for logging command
* Clean up
* Fixed certain new lines and spaces
* Sync with development branch
* Formatting consistency
* Tabs to 2 spaces
* Corrected indenting
* Double braced conditionals
* Quoted variables within conditionals
* Fixed certain newlines and spaces
* Admin help text
* Added help text for interface command
* Sync with development branch
* Formatting consistency
* Tabs to 2 spaces
* Fixed some wording
* Fixed certain spaces
* Formatting consistency
* Minor wording changes
* Tabs to 2 spaces
* Corrected indenting
* Double braced conditionals
* Quoted variables within conditionals
* Fixed certain newlines and spaces
* Blacklist help text
* Formatting consistency
* Tabs to 2 spaces
* Corrected indenting
* Cronometer help text
* Formatting consistency
* Fixed certain newlines and spaces
* Corrected indenting
* Checkout warning alteration
* Add checkout help text
* Corrected help output
* Show help for "pihole -a -i --help"
* Fix "pihole disable --help" and "pihole -l --help"
* Show help for "pihole -v -h"
* Indent output text
* Minor help text change
* Show help for "pihole checkout --help"
* Tricorder: Insecure Opt-out
* Check to see if Tricorder is being called directly
* Provide opt-out for insecure transmission of debug log
* Remove mention of internal function from help menu
* 🌮 is the new :shipit: squirrel
* Wording changes and bug fix
* Fix wildcard help text
* -wild is not a valid option since we're already using -wild
* Fix logrotation: manual flushing should be done twice, but automated rotation at midnight should only be done *once*!
* Print echos only when manual flushing is requested
* Add "quiet" mode + update comments in the cron file
* Confirm Tricorder is online
* Scan port 9998 to confirm the availability of "tricorder.pi-hole.net"
* Exit codes for upload process
* Formatting consistency
* Add link to Windows DNS Swapper
See #1400
* Install loopback firewall rules for FTL (#1419 )
* Install loopback firewall rules for FTL
* FirewallD FTL ports
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* Remove firewallD FTL local rules.
Local rules should not be blocked in firewallD, not requred for internal service FTD>
* Reinstate https rules, and delete FTL rules
Fixes earlier commit.
* Retrieve local repos on repair (#1481 )
* Retrieve local repos on repair
* Change conditional to check for repair
* Change wording of Update/Reconfigure message
* Fixed indenting
* Perform "git reset --hard" on reconfigure
* Change directory before trying to reset repository. Fixes #1489
* No need to `cd $PWD` as it doesn't affect flow of caller script.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* Refine output of password status in basic-install.sh:displayFinalMessage(). Fixes #1488 (#1490 )
* Rewrite Chronometer to output more stats
* Fix output IPv4 addr when removing CIDR notation (#1498 )
* Move wildcards file if blocking is disabled (#1495 )
* Move wildcards file if blocking is diabled
* Delete newline
* Roll back merge #1417 (#1494 )
* Update ISSUE_TEMPLATE.md
* Remove Question option
* Prefer ULA over GUA addresses [IPv6] (#1508 )
* On installs with GUA and ULA's we should prefer ULA's as it's been demonstrated that GUA's can and often are rotated by ISPs. Fixes #1473
* Add test for link-local address detection
* Add ULA-only and GUA-only tests
* Add test_IPv6_GUA_ULA_test and test_IPv6_ULA_GUA_test
* Add ""
* Add mock_command_2 command that can mock a command with more than one argument (as "ip -6 address") and result multiple lines of results
* Make mock_command_2 more similar to the original mock_command
* Correct comments
* Fixed remaining comments
* Fixed one last comment...
* Fixed a comment...
* Add weekly logrotation of FTL's log (#1509 )
* Update LICENSE of the project to EUPL v1.2
* Make clear that NO is the default if the user just hits return (#1514 )
* Add tricorderFunc back as usable function (#1515 )
As per #1464
* Don't update FTL when there is a core update (as this will update FTL a second time). Fixes #1516
* Add FTL tests to the test suite (#1510 )
* Add first version of FTL tests
* Wait one second to allow FTL to start up and analyze our mock log
* Add test_FTL_telnet_statistics
* Added test_FTL_telnet_top_clients
* Add test_FTL_telnet_top_domains
* Revert "Add FTL tests to the test suite (#1510 )" (#1519 )
This reverts commit cf6a1ac9ad .
* Trim version output when update is successful (#1527 )
* Change ownership of /etc/pihole to user/group pihole. Fixes #1529 (#1530 )
* Delete temporary files after installing the FTL binary. Fixes #1525
* Change from admin to approvers teams
* Introduce new file black.list for blacklist content
* Add "pihole -g -b" to *only* update black.list (saves a bunch of time when adding/changing only blacklisted files - won'tdownload lal lists, but only processes the blacklist and restars dnsmasq)
* Remove useless cat
* Improve displayed messages and overall logic
* Disable black.list on "pihole disable"
* cp + rm === mv (well, almost)
2017-06-20 22:17:41 +01:00
Terror
5b472ff67c
Add support for PowerPC architecture
...
Related to https://github.com/pi-hole/FTL/pull/88
2017-06-20 08:28:04 +12:00
Mcat12
6f2ec22894
Merge pull request #1534 from pi-hole/new/black.list
...
Introducing black.list
2017-06-19 14:26:08 -04:00
DL6ER
05798fe07a
cp + rm === mv (well, almost)
2017-06-19 20:22:03 +02:00
Mcat12
8ab5ffd876
Merge pull request #1533 from pi-hole/dschaper-patch-1
...
Change from admin to approvers teams
2017-06-17 12:23:04 -04:00
Mcat12
2b6709d83f
Merge pull request #1532 from pi-hole/fix/tempfiles
...
Delete temporary files after installing the FTL binary. Fixes #1525
2017-06-17 12:07:00 -04:00
DL6ER
e4cc5b3847
Disable black.list on "pihole disable"
2017-06-17 14:49:02 +02:00
DL6ER
8bad56e897
Improve displayed messages and overall logic
2017-06-17 14:24:30 +02:00
DL6ER
92e691408f
Remove useless cat
2017-06-17 14:14:07 +02:00
DL6ER
0a9c234127
Add "pihole -g -b" to *only* update black.list (saves a bunch of time when adding/changing only blacklisted files - won'tdownload lal lists, but only processes the blacklist and restars dnsmasq)
2017-06-17 13:57:27 +02:00
DL6ER
0283a1ab74
Introduce new file black.list for blacklist content
2017-06-17 13:50:10 +02:00
Dan Schaper
b32096b16e
Change from admin to approvers teams
2017-06-17 03:59:27 -07:00
DL6ER
3d7582faec
Delete temporary files after installing the FTL binary. Fixes #1525
2017-06-17 08:54:26 +02:00
DL6ER
54a88ab5ab
Change ownership of /etc/pihole to user/group pihole. Fixes #1529 ( #1530 )
2017-06-17 08:43:05 +02:00
WaLLy3K
aff5ff08d5
Trim version output when update is successful ( #1527 )
2017-06-15 09:50:05 +02:00
Jacob Salmela
fc0440546f
add functions to parse head and tails of gravity.list and pihole.log
2017-06-10 23:20:27 -05:00
Jacob Salmela
172b8d2427
parse ftl log
2017-06-10 22:18:33 -05:00
Jacob Salmela
6d10a498a5
implement a limit on how many lines of a file we want to view
2017-06-10 21:57:17 -05:00
Jacob Salmela
881819ed5f
ignore big files we dont need to know about; also fix diagnosing pihole processes
2017-06-10 18:37:28 -05:00
Jacob Salmela
3275c5f710
more comments to help understand the script
2017-06-10 15:54:27 -05:00
Jacob Salmela
b0cc1a38c3
adjust minor formatting for better readability
2017-06-10 15:28:04 -05:00
Mcat12
e8025dbc81
Merge pull request #1513 from pi-hole/EUPLv1.2
...
Update LICENSE of the project to EUPL v1.2
2017-06-10 14:10:25 -04:00
Jacob Salmela
e10182c839
only parse files required by Pi-hole
2017-06-10 12:27:05 -05:00
Jacob Salmela
b4f1fe08f0
variablize all files and directories. also put required files and folders into an arry so we can compare them in later functions by parsing through them
2017-06-09 23:22:37 -05:00
Jacob Salmela
64171fa2a1
small color and formatting changes
2017-06-09 15:42:54 -05:00
Jacob Salmela
048eacd305
parse array in correct location
2017-06-07 12:31:08 -05:00
Jacob Salmela
24aa72c19d
condense repetative code into functions; parse the content of each file
2017-06-07 12:25:00 -05:00
Jacob Salmela
92b5fe4be4
check arch compatibility and add gateway faq url
2017-06-05 14:55:58 -05:00
DL6ER
939055f19c
Revert "Add FTL tests to the test suite ( #1510 )" ( #1519 )
...
This reverts commit cf6a1ac9ad .
2017-06-05 13:51:13 +02:00
Mcat12
c47f3e3307
Merge pull request #1517 from pi-hole/tweak/update_core_and_FTL
...
Don't update FTL when there is a core update
2017-06-04 08:42:59 -04:00
DL6ER
cf6a1ac9ad
Add FTL tests to the test suite ( #1510 )
...
* Add first version of FTL tests
* Wait one second to allow FTL to start up and analyze our mock log
* Add test_FTL_telnet_statistics
* Added test_FTL_telnet_top_clients
* Add test_FTL_telnet_top_domains
2017-06-04 13:23:56 +02:00
DL6ER
f1146a3443
Don't update FTL when there is a core update (as this will update FTL a second time). Fixes #1516
2017-06-04 12:41:44 +02:00
WaLLy3K
6823a62644
Add tricorderFunc back as usable function ( #1515 )
...
As per #1464
2017-06-03 19:13:40 +02:00
DL6ER
2516a1e298
Make clear that NO is the default if the user just hits return ( #1514 )
2017-06-03 17:23:47 +02:00
DL6ER
288f93c5dd
Update LICENSE of the project to EUPL v1.2
2017-06-03 15:06:00 +02:00
DL6ER
8ef64dbe74
Add weekly logrotation of FTL's log ( #1509 )
2017-06-03 14:51:35 +02:00
DL6ER
01e091fd17
Prefer ULA over GUA addresses [IPv6] ( #1508 )
...
* On installs with GUA and ULA's we should prefer ULA's as it's been demonstrated that GUA's can and often are rotated by ISPs. Fixes #1473
* Add test for link-local address detection
* Add ULA-only and GUA-only tests
* Add test_IPv6_GUA_ULA_test and test_IPv6_ULA_GUA_test
* Add ""
* Add mock_command_2 command that can mock a command with more than one argument (as "ip -6 address") and result multiple lines of results
* Make mock_command_2 more similar to the original mock_command
* Correct comments
* Fixed remaining comments
* Fixed one last comment...
* Fixed a comment...
2017-06-02 23:01:48 +02:00
Jacob Salmela
8b4c0b456b
exclude webpassword from being uploaded. also check that the IP addresses detected match those defined in setupVars.conf
2017-06-01 01:15:11 -05:00
Jacob Salmela
02a601deff
comment out dir checks for lighttpd, cronm and http as they have a lot of other files that need parsing through. May need to increase the logic there if this is information we really need to know.
2017-06-01 00:19:15 -05:00
Jacob Salmela
b207fadc04
check if os is supported based on pretty name
2017-06-01 00:18:06 -05:00
Mcat12
bf3883ed46
Merge pull request #1506 from pi-hole/tweak/github_issues
...
Update ISSUE_TEMPLATE.md to remove Feature Request choice.
2017-05-31 19:14:36 -04:00
Dan Schaper
3a58e9d33a
Remove Question option
2017-05-31 00:02:57 -07:00
Dan Schaper
570c54002f
Update ISSUE_TEMPLATE.md
2017-05-30 23:51:22 -07:00
Jacob Salmela
d51c067e1b
change some verbiage; new function to compare the ports in use to the services assigned to them.
2017-05-27 21:21:18 -05:00
Jacob Salmela
2fea5d428d
condense repetitive code into functions
2017-05-27 15:47:15 -05:00
WaLLy3K
2b8a8b03a8
Roll back merge #1417 ( #1494 )
2017-05-27 22:42:44 +02:00
Jacob Salmela
d51e0c49b1
remove comments and blank lines when parsing files
2017-05-27 13:44:33 -05:00
DL6ER
d913534793
Move wildcards file if blocking is disabled ( #1495 )
...
* Move wildcards file if blocking is diabled
* Delete newline
2017-05-27 17:51:41 +02:00
Jacob Salmela
36907edd50
parse contents of each file in each dir, several log_writes
2017-05-27 00:04:42 -05:00
Jacob Salmela
7ec169ab10
more comments, fixed automated tricorder, variablizing echos, verify FTL version
2017-05-26 22:05:50 -05:00
Jacob Salmela
7873da1ae5
more colors. shortened dig timeouts
2017-05-26 15:17:26 -05:00
Jacob Salmela
ef5a6e7880
add faq urls to some functions, added more colors, also use a static url for remote digs
2017-05-26 14:26:02 -05:00
Jacob Salmela
96f01e670f
add functions to write to console and log at the same time
2017-05-26 12:16:22 -05:00
WaLLy3K
10139241f5
Fix output IPv4 addr when removing CIDR notation ( #1498 )
2017-05-26 09:57:27 +02:00
Jacob Salmela
5902be2a49
comments for every line
2017-05-24 22:07:15 -05:00
Jacob Salmela
cc946ce068
upload to tricorder functions
2017-05-24 21:11:15 -05:00
Jacob Salmela
1102fdc44b
append everything the user sees to the pihole_debug.log file
2017-05-24 20:24:23 -05:00
Jacob Salmela
c995c81fff
adjust some spacing
2017-05-24 19:36:06 -05:00
Jacob Salmela
6684af9938
add lighttpd list function and gravity analysis
2017-05-24 18:31:55 -05:00
Jacob Salmela
8bafd12f95
fix resolver functions and add x-header function
2017-05-24 16:10:14 -05:00
Jacob Salmela
76266cf31b
add resolver functions and check directory content functions
2017-05-24 15:29:31 -05:00
WaLLy3K
4ad0cdf5d4
Rewrite Chronometer to output more stats
2017-05-25 01:03:13 +10:00
Jacob Salmela
1a87d3a659
add process check function
2017-05-23 22:57:22 -05:00
Jacob Salmela
085f2c6ca0
add port check function
2017-05-23 22:32:30 -05:00
WaLLy3K
98fdb95645
Merge pull request #1491 from pi-hole/fix/ResetInRepoDir
...
Change directory before trying to reset repository
2017-05-23 19:02:03 +10:00
DL6ER
3035c9a366
Refine output of password status in basic-install.sh:displayFinalMessage(). Fixes #1488 ( #1490 )
2017-05-23 10:44:11 +02:00
Dan Schaper
5004cf331a
No need to cd $PWD as it doesn't affect flow of caller script.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-05-22 15:36:51 -07:00
DL6ER
74eb8c8622
Change directory before trying to reset repository. Fixes #1489
2017-05-22 23:43:52 +02:00
Jacob Salmela
b74300f67c
add ping internet function and fix some spacing issues
2017-05-22 12:57:55 -05:00
Jacob Salmela
107babe8f4
add ping gateway function
2017-05-22 12:35:57 -05:00
Jacob Salmela
8fd9a22d18
add detect IP function
2017-05-22 12:05:42 -05:00
Jacob Salmela
8c5c1316dd
add php version and processor check functions
2017-05-22 08:48:56 -05:00
Jacob Salmela
daff5d8b5a
add critical dependencies version check functions
2017-05-22 03:05:51 -05:00
Jacob Salmela
6c4a7b626e
add pihole version check functions
2017-05-22 02:39:00 -05:00
Jacob Salmela
1aa5943e67
add if directory exists function
2017-05-22 01:06:15 -05:00
Jacob Salmela
69fe889f92
comments for all lines and small formatting changes
2017-05-21 23:25:53 -05:00
WaLLy3K
2ef87ad110
Retrieve local repos on repair ( #1481 )
...
* Retrieve local repos on repair
* Change conditional to check for repair
* Change wording of Update/Reconfigure message
* Fixed indenting
* Perform "git reset --hard" on reconfigure
2017-05-21 22:47:25 +02:00
DL6ER
c655e6ea73
Install loopback firewall rules for FTL ( #1419 )
...
* Install loopback firewall rules for FTL
* FirewallD FTL ports
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
* Remove firewallD FTL local rules.
Local rules should not be blocked in firewallD, not requred for internal service FTD>
* Reinstate https rules, and delete FTL rules
Fixes earlier commit.
2017-05-20 15:47:51 +02:00
Jacob Salmela
5d7ef9281f
get just the OS pretty name for Dan
2017-05-20 02:01:56 -05:00
Jacob Salmela
6fa00e7cc8
first functions with pretty colors. check OS, setupVars, and contents of .d dirs
2017-05-20 01:34:13 -05:00
WaLLy3K
2f2825f15e
Tricorder: Insecure Opt-out
2017-05-20 10:45:26 +10:00
Mcat12
e377fe5503
Merge pull request #1486 from pi-hole/readme/win-dns-swapper
...
Add link to Windows DNS Swapper
2017-05-19 11:26:51 -04:00
Mcat12
69b41dd72e
Add link to Windows DNS Swapper
...
See #1400
2017-05-19 11:16:34 -04:00
WaLLy3K
69fa9874dd
Use HTTP_HOST instead of SERVER_NAME
...
* Fixes https://github.com/pi-hole/pi-hole/issues/1479
2017-05-18 18:54:26 +10:00
WaLLy3K
a620a5c430
Formatting consistency
2017-05-18 12:53:32 +10:00
WaLLy3K
1f3db8b602
Confirm Tricorder is online
...
* Scan port 9998 to confirm the availability of "tricorder.pi-hole.net"
* Exit codes for upload process
2017-05-18 12:43:17 +10:00
WaLLy3K
f6732a484e
Merge pull request #1317 from r0ckarong/development
...
Fixed handling of `pihole -wild` help text
2017-05-18 11:16:25 +10:00
DL6ER
4015122d33
Merge pull request #1476 from pi-hole/fix/midnightflushing
...
Fix midnight logrotation
2017-05-18 01:23:32 +02:00
DL6ER
42eb811910
Add "quiet" mode + update comments in the cron file
2017-05-17 12:54:43 +02:00
DL6ER
c9042ffedd
Print echos only when manual flushing is requested
2017-05-17 12:51:04 +02:00
DL6ER
4e2c6a7b8e
Fix logrotation: manual flushing should be done twice, but automated rotation at midnight should only be done *once*!
2017-05-17 12:44:35 +02:00
WaLLy3K
7453bf2ee6
Fix wildcard help text
...
* -wild is not a valid option since we're already using -wild
2017-05-16 10:23:53 +10:00
WaLLy3K
7d17c652f3
Merge branch 'development' into development
2017-05-16 10:18:32 +10:00
WaLLy3K
075f00cecd
Merge branch 'development' into tc-insecure-optout
2017-05-16 09:49:42 +10:00
WaLLy3K
b9f2ba0717
Wording changes and bug fix
2017-05-16 09:48:46 +10:00
Adam Warner
ed04be5faa
Merge pull request #1468 from pi-hole/tweak/help-output
...
New Help Output
2017-05-14 16:46:58 +01:00
Adam Warner
90119c75d5
more merge conflicts!
2017-05-14 16:43:20 +01:00
Dan Schaper
d30056026b
Merge pull request #1466 from pi-hole/doclist_remove_sed
...
Document `sed` substitution for user readability
2017-05-14 08:28:10 -07:00
Adam Warner
bc8a5916d8
fix merge conflicts
2017-05-14 16:17:04 +01:00
Dan Schaper
f202602f99
Merge pull request #1470 from pi-hole/tweak/taco
...
Update PullApprove rules
2017-05-14 07:41:07 -07:00
DL6ER
69f361a3a1
🌮 is the new :shipit: squirrel
2017-05-14 16:28:35 +02:00
WaLLy3K
da9ff0cc66
Tricorder: Insecure Opt-out
...
* Check to see if Tricorder is being called directly
* Provide opt-out for insecure transmission of debug log
* Remove mention of internal function from help menu
2017-05-14 19:27:14 +10:00
WaLLy3K
703ff09a91
Merge pull request #1464 from pi-hole/new/tricorder_option
...
Tricorder debug logs are now uploaded using SSL when `openssl` is available
2017-05-14 15:37:25 +10:00
WaLLy3K
30035ce1c2
Merge branch 'development' into tweak/help-output
2017-05-14 13:03:33 +10:00
WaLLy3K
39b74ebfd4
Show help for "pihole checkout --help"
2017-05-14 12:22:19 +10:00
WaLLy3K
3bd677c102
Show help for "pihole -v -h"
...
* Indent output text
* Minor help text change
2017-05-14 11:57:46 +10:00
WaLLy3K
4eb7d2868c
Fix "pihole disable --help" and "pihole -l --help"
2017-05-14 11:53:40 +10:00
WaLLy3K
0e4473685b
Show help for "pihole -a -i --help"
2017-05-14 11:47:56 +10:00
WaLLy3K
b721ed49ab
Update Help Output ( #1467 )
...
* File consistency
* Tabs to 2 spaces
* Corrected indenting
* Double braced conditionals
* Quoted variables within conditionals
* Standardise core help text
* Added help text for disable command
* Added help text for logging command
* Clean up
* Fixed certain new lines and spaces
* Sync with development branch
* Formatting consistency
* Tabs to 2 spaces
* Corrected indenting
* Double braced conditionals
* Quoted variables within conditionals
* Fixed certain newlines and spaces
* Admin help text
* Added help text for interface command
* Sync with development branch
* Formatting consistency
* Tabs to 2 spaces
* Fixed some wording
* Fixed certain spaces
* Formatting consistency
* Minor wording changes
* Tabs to 2 spaces
* Corrected indenting
* Double braced conditionals
* Quoted variables within conditionals
* Fixed certain newlines and spaces
* Blacklist help text
* Formatting consistency
* Tabs to 2 spaces
* Corrected indenting
* Cronometer help text
* Formatting consistency
* Fixed certain newlines and spaces
* Corrected indenting
* Checkout warning alteration
* Add checkout help text
* Corrected help output
2017-05-14 11:11:44 +10:00
Dan Schaper
25601b9fcc
Document sed substitution for user readability
...
Comment the oneliner with explanations of what each step does.
2017-05-13 17:49:58 -07:00
Dan Schaper
db10c8ab46
Merge pull request #1465 from pi-hole/busybox_sed_support
...
Update list.sh for busybox compatibility
2017-05-13 17:40:27 -07:00
Adam Hill
55f78e3b64
Update list.sh
...
I believe this has feature parity with `sed /foo/ Id` but also supports busybox, and my alpine docker ;)
2017-05-13 18:44:41 -05:00
DL6ER
7abf349730
Use echo "ABC" | pihole tricorder to upload to Pi-hole's medical tricorder. Uses SSL if available.
2017-05-13 21:08:21 +02:00
WaLLy3K
f9d41caeb6
Merge branch 'development' into blockpage2
2017-05-13 23:29:44 +10:00
Hans Geiblinger
b166410cbf
Solve piholeLogFlush.sh having to be issued 2 x to clear logs ( #1460 )
...
Simplified the command -v syntax, and added a sleep 3 timer to the first execution of the log rotation. The second execution was being issued while the first was still running, thus it would fail and you would have to issue the "Flush Logs" command a second time.
2017-05-12 22:39:55 +02:00
0412465564
31d5a7ae9e
whitelist on website blocked doesnt work ( #1452 )
...
Since Pi-hole redirects ad domains to itself, accessing the script via de.ign.com is the same as pi.hole in this case. The fix should be as simple as adding a / before admin on this line.
2017-05-12 22:29:07 +02:00
Dan Schaper
5bb91759b4
Merge pull request #1459 from WaLLy3K/patch-2
...
Provide remote hashes for version.sh
2017-05-12 12:38:13 -07:00
Dan Schaper
80c4b7c9bb
Merge pull request #1455 from pi-hole/tweak/logecho_gateway
...
Debug: Log and echo gateway responses
2017-05-12 12:02:21 -07:00
WaLLy3K
ea0a9ceb37
Provide remote hashes for version.sh
...
* Provide remote hashes for comparison
* Use double braces for all conditions (for consistency)
* Suppress potential "cd" error output
* Provide "not applicable" output upon any hash request for FTL
2017-05-12 15:25:01 +10:00
Dan Schaper
68dd2a6b91
Merge pull request #1447 from WaLLy3K/patch-1
...
Display FTL version & version.sh rewrite
2017-05-11 14:23:59 -07:00
WaLLy3K
f875976268
Replacing superseded file with dummy content
2017-05-11 21:02:04 +10:00
Dan Schaper
e23c6899e0
Merge pull request #1456 from WaLLy3K/patch-3
...
Update queryFunc() to search Whitelist
2017-05-11 03:45:40 -07:00
WaLLy3K
c35c7b2cea
Wrap in double brackets
2017-05-11 20:21:23 +10:00
WaLLy3K
1c2aa44d46
Provide notice message for whitelisted sites
2017-05-11 20:10:40 +10:00
WaLLy3K
3b44a0da32
Provide error message if not found in any list
2017-05-11 20:09:00 +10:00
WaLLy3K
58353e2839
Update queryFunc() to search Whitelist
...
If there is a match in Whitelist/Blacklist/Wildcards, `[ ! -t 1 ]` will cause the search to end if the terminal is closed when the script is called. This has the intended effect of allowing a user to search for a W/B/W domain (as well as all the adlists it's found in) using `pihole -q` via Terminal, but the script will stop searching after a W/B/W match when called by the block page.
2017-05-11 19:58:35 +10:00
Adam Warner
5e0572637e
Merge pull request #1417 from WaLLy3K/tweak/queryFunc
...
QueryFunc() rewrite
2017-05-11 09:07:00 +01:00
Dan Schaper
501b26decd
Log and echo gateway responses
2017-05-10 22:08:06 -07:00
WaLLy3K
c6596f2c54
Modified syntax to be valid for Shellcheck
2017-05-11 14:19:13 +10:00
WaLLy3K
2863308090
Minimise string duplication & other minor changes
...
Instead of duplicating output strings, rewrite core/web/ftlOutput() into one neat versionOutput().
2017-05-11 13:34:58 +10:00
WaLLy3K
7fef1fdc83
Fixed indentation
2017-05-11 10:11:04 +10:00
WaLLy3K
3081c151bd
Perform EXACT searches on HOSTS lists correctly
...
`\s` on the end may be overkill, but it is the existing scanList() behaviour.
2017-05-11 09:13:32 +10:00
Dan Schaper
c793295be0
Merge pull request #1446 from pi-hole/tweak/install_lockcheck
...
Clarify error message on apt failures.
2017-05-10 15:40:13 -07:00
WaLLy3K
fe0a35cc7a
Update -h to work as --hash
...
Also provide error output as per https://github.com/pi-hole/pi-hole/pull/1447#issuecomment-300600093
2017-05-11 08:30:49 +10:00
Dan Schaper
0b67eebaec
Merge pull request #1440 from pi-hole/revert-1437-blockPage
...
Revert "Ensure any changes to blocking page are updated."
2017-05-10 15:26:29 -07:00
WaLLy3K
03201e2f20
Display FTL version & version.sh rewrite
...
While testing to make sure `pihole -v` would output `pihole-FTL version`, I noticed some options didn't work how I expected them to. For example, if I use `pihole -v -p`, I would expect to see the version output of Pi-hole Core. Instead, I'm informed that it's an invalid option.
I've had the following things in mind while rewriting this:
* I'm operating under the assumption that FTL is only installed if the Admin Console is (Line 113 exit 0)
* I have modified the help text to only output with `pihole -v --help`
* I have modified all output to be more similar to the output style of `grep` and `curl` (Ditching ":::")
Testing output:
```
w3k@MCT:~$ pihole -v
Pi-hole version is v3.0.1-14-ga928cd3 (Latest: v3.0.1)
Admin Console version is v3.0-9-g3760482 (Latest: v3.0.1)
FTL version is v2.6.2 (Latest: v2.6.2)
w3k@MCT:~$ pihole -v -c
Current Pi-hole version is v3.0.1-14-ga928cd3
Current Admin Console version is v3.0-9-g3760482
Current FTL version is v2.6.2
w3k@MCT:~$ pihole -v -l
Latest Pi-hole version is v3.0.1
Latest Admin Console version is v3.0.1
Latest FTL version is v2.6.2
w3k@MCT:~$ pihole -v -p --hash
Current Pi-hole hash is a928cd3
w3k@MCT:~$ pihole -v -a --hash
Current Admin Console hash is 3760482
w3k@MCT:~$ pihole -v --help
Usage: pihole -v [REPO | OPTION] [OPTION]
Show Pi-hole, Web Admin & FTL versions
<Shows all Repositories and Options>
w3k@MCT:~$ pihole -v -foo
Invalid Option!
```
2017-05-10 13:07:56 +10:00
Dan Schaper
dfc32b26a6
We test for dpkg lock on line 830 directly, no need for the check also
...
in the template section.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-05-09 13:11:28 -07:00
WaLLy3K
173ad339bb
Update CSS location
2017-05-08 19:33:45 +10:00
Adam Warner
89fd962615
Revert "Ensure any changes to blocking page are updated."
2017-05-06 11:45:31 +01:00
Adam Warner
a928cd3fa1
Merge pull request #1437 from pi-hole/blockPage
...
Ensure any changes to blocking page are updated.
2017-05-06 01:06:22 +01:00
Dan Schaper
f190a6ebc5
Merge pull request #1436 from pi-hole/fix/dhcpcd-localhostNS
...
Update basic-install.sh dhcpcd.conf nameserver
2017-05-05 15:25:12 -07:00
Adam Warner
9beb9fd941
Merge pull request #1384 from pi-hole/checkoutImprovements
...
Stash changes when switching branches
2017-05-05 23:22:54 +01:00
Adam Warner
525a1228c3
clarify
2017-05-05 22:43:37 +01:00
Adam Warner
19fd25c7cd
revert line, looks tidyer
2017-05-05 22:40:10 +01:00
Adam Warner
5b0927ca4b
tidy up output
2017-05-05 22:32:27 +01:00
Adam Warner
324d4433c3
even further simplify
2017-05-05 22:31:31 +01:00
Adam Warner
615ca56ea3
fix inteliJ IDEA complaints
2017-05-05 22:27:58 +01:00
Adam Warner
41dd163453
further simplify
2017-05-05 22:27:33 +01:00
Adam Warner
5cd2c77d98
simplify
2017-05-05 22:24:40 +01:00
Adam Warner
f270f7430c
Update block page. Allow for setupVars setting of CUSTOMBLOCKPAGE (bool) to prevent it being overwritten
2017-05-05 22:10:24 +01:00
Dan Schaper
99b23627d0
Update basic-install.sh
2017-05-05 12:03:51 -07:00
Adam Warner
26fcb1b2a0
Merge pull request #1429 from pi-hole/development
...
Release v3.0.1
2017-05-04 15:12:26 +01:00
DL6ER
e9c4e8123c
Merge branch 'master' into development
2017-05-04 12:12:44 +02:00
Dan Schaper
a290e01bdf
Merge pull request #1421 from pi-hole/fix/accidental-password-reset
...
Add option to enter new password as command arg
2017-05-04 03:11:54 -07:00
DL6ER
9cc392fa02
Update Marks PR after the Promo code has been merged
2017-05-04 11:43:48 +02:00
Dan Schaper
7c2046cce7
Merge pull request #1423 from pi-hole/promoLearnsToCode
...
Double hash the password directly in the install script
2017-05-03 12:07:38 -07:00
WaLLy3K
4d731ca30b
Updated landing page location
...
During development, I had the location of `/pihole/index.php` as just `/index.php`. Just correcting some changes!
2017-05-03 15:33:50 +10:00
WaLLy3K
f2016f26d7
Updated splash page CSS href
2017-05-03 15:29:43 +10:00
Adam Warner
b13171cc45
$1 is not $pw. Seriously, who let me onto this project
2017-05-02 22:37:38 +01:00
Adam Warner
9c645e2010
Seriously.
2017-05-02 22:30:02 +01:00
Adam Warner
bb6f409e89
dropped a "
2017-05-02 22:28:32 +01:00
Adam Warner
61ec7723f6
use function in install script
2017-05-02 22:25:47 +01:00
Adam Warner
9c136a5579
functionise Hashing
2017-05-02 22:24:37 +01:00
Adam Warner
a5733508ae
Double hash the password directly in the install script
2017-05-02 21:36:08 +01:00
WaLLy3K
a8818c16d8
Fixed unnecessary usage of !important
2017-05-02 19:51:13 +10:00
DL6ER
c8e1e6dc8a
Merge pull request #1418 from pi-hole/tweak/debug/FTL_log
...
Include pihole-FTL.log in debug report
2017-05-02 09:41:35 +02:00
WaLLy3K
7bcea98d0c
Do not activate letsencrypt.conf if found
2017-05-02 17:28:51 +10:00
WaLLy3K
74b15d10d9
Update lighttpd.conf.fedora
...
Mirror changes found in `lighttpd.conf.debian`
2017-05-02 17:24:55 +10:00
WaLLy3K
356c70cdae
Update lighttpd.conf.debian
...
* Disable `include-conf-enabled.pl`, as blindly enabling HTTPS (as Let's Encrypt does by having a file in that folder) creates Block Page inefficiencies
* Make Block page handle JS request rewrite, allowing users to better utilise their `lighttpd` service
* Make Block page handle debugging Pi-hole header
* Make Block page redirect users from `pi.hole` to `http://pi.hole/admin `
2017-05-02 17:24:07 +10:00
WaLLy3K
dfb5c37d98
Delete index.js
2017-05-02 17:21:40 +10:00
DL6ER
30dcf6ff47
Include pihole-FTL.log in debug report
2017-05-02 09:18:58 +02:00
WaLLy3K
a0603ad3b7
Update queryFunc()
...
* Allow scanList() to search files using a wildcard by removing quotes wrapped around `${list}`
* scanList() will not provide a domain ouput on each string if exact is specified (`grep -l`)
* Remove unused processWildcards() function
* Return a message if no domain is specified
* IDN domains are converted to punycode when running a `pihole -q` search if the `python` package is available, otherwise will revert to current behaviour
* Scan Blacklist & Wildcards first, exiting from search if a match is found (Fixes #1330 )
* Use one `grep` subshell to search for all "*.domains" lists at once (opposed to looping to get every matching file name, and then spawning a `grep` instance for every matching file)
* queryFunc() will not return "(0 results)" output from files where no match is found
* Sort results based off list number
* Return a message if no results are found
2017-05-02 17:13:55 +10:00
WaLLy3K
551add5f44
Update index.php
...
* An "About Pi-hole" link on the block page provides an ELI5 explanation to those not familiar with Pi-hole
* An email contact link on the block page provides users of your Pi-hole with a means to easily get in touch with you
* Browsing to your Pi-hole's address will show a simple "landing page", which can be replaced by adding "landing.php" within "/var/www/html"
* Users manually browsing to file/image based content (i.e: non HTML based content) on blocked sites will be greeted with a small "Blocked by Pi-hole" image
* Sites that are manually blacklisted will display a notice of this on the block page
* Sites that aren't directly blocked, but have a CNAME record, will show a notification on the block page (e.g: If raw.githubusercontent.com is not blocked, but github.map.fastly.net is)
* On the block page, "Back to Safety" now directs the user to "about:home" if Javascript is disabled
* Whitelisting is disabled for installs without a password, or if a client does not have Javascript
* Known issues:
* Admin Console needs a text field under "Web User Interface" where the admin can enter a preferred contact email when a site needs to be whitelisted, to be saved to setupVars.conf with the key "ADMIN_EMAIL"
* Admin Console needs a text field under "Networking" where the admin can enter their Pi-hole's externally contactable FQDN, allowing access to their landing page when browsing to mypi.duckdns.org, to be saved to setupVars.conf with the key "FQDN"
* I am not aware of expected output of `$_SERVER["VIRTUAL_HOST"]`, so I have assumed it should be filtered as if it's a domain
2017-05-02 17:06:31 +10:00
WaLLy3K
88944a31ec
Update blockingpage.css
...
* Block page UI overhaul to replicate the style of the Admin Console
* Block page UI is now mobile friendly
* Users can safely customise text in order to make the block page more friendly for their household
2017-05-02 17:05:24 +10:00
DL6ER
3473ebc0fe
Merge pull request #1408 from pi-hole/tweak/localise-queries
...
Add localise-queries flag to dnsmasq's config
2017-05-02 08:56:47 +02:00
Dan Schaper
8c657910ae
Merge pull request #1280 from technicalpyro/development
...
fixes missing dialog package from some distros
2017-05-01 16:07:32 -07:00
Dan Schaper
1886c44579
Merge pull request #1406 from pi-hole/update/UA
...
Update default User Agent to modern browser.
2017-05-01 14:35:55 -07:00
Adam Warner
1dcc1871fb
Merge pull request #1404 from pi-hole/development
...
3.0
2017-05-01 22:03:54 +01:00
DL6ER
19e688effb
Add localise-queries flag to 01-pihole.conf
2017-04-30 13:47:07 +02:00
Dan Schaper
6a2b885988
Update default User Agent to modern browser.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-04-27 11:41:08 -07:00
Dan Schaper
bfc4775b34
Merge pull request #1297 from raincoats/development
...
Redirect to admin panel when accessing 'http://pi.hole/ '
2017-04-26 12:35:19 -07:00
Adam Warner
981004606b
Merge branch 'master' into development
2017-04-26 20:12:34 +01:00
Adam Warner
9d40fd1eda
Merge branch 'development' Resolved conflicts
...
# Conflicts:
# advanced/Scripts/piholeCheckout.sh
2017-04-26 20:12:16 +01:00
DL6ER
db1e5f10ea
Make changes according to comment in #1384
2017-04-21 17:08:15 +02:00
DL6ER
fbb6b56d99
Merge pull request #1397 from pi-hole/fix/ipv4ipv6error
...
Bugfix: Blocking page
2017-04-20 16:18:50 +02:00
DL6ER
f1f70133dc
Populate $ipv4 and $ipv6 + fix small error that prevented blocking page from coming up at all. Fixes #1396
2017-04-20 13:53:27 +02:00
DL6ER
d0f55e5125
Merge pull request #1394 from pi-hole/fix/remove-temp-gravity-files
...
Delete the temp files created by gravity
2017-04-19 08:46:01 +02:00
Mcat12
5e308dbd51
Delete the temp files created by gravity
2017-04-18 20:35:06 -04:00
Mcat12
c3c554f4d6
Merge pull request #1391 from pi-hole/tweak/flush
...
Flush twice to move data out-of-sight of FTL
2017-04-17 20:10:03 -04:00
DL6ER
320c06e0a4
Flush twice to move data out-of-sight of FTL
2017-04-17 21:25:15 +02:00
Adam Warner
2e398c5da4
stash changes on branch switch, else it fails if any changes have been made.
2017-04-14 17:20:13 +01:00
DL6ER
b1484104bd
Merge pull request #1379 from pi-hole/tweak/FTLinit.d
...
Tweaks for `FTL`'s init file
2017-04-13 12:53:37 +02:00
Mcat12
c738a9a044
Merge pull request #1381 from technicalpyro/development
...
Grammar Fix
2017-04-12 21:29:39 -04:00
Technicalpyro
519cb71022
Grammar Fix
...
]
2017-04-12 16:05:21 -04:00
DL6ER
fcd92d27f7
Don't use PID file but rather "pidof pihole-FTL" for detecting if another process is already running
2017-04-12 15:12:09 +02:00
DL6ER
3eacfa9831
Improve FTL's service script
2017-04-12 14:13:18 +02:00
gedetil
ff6df76e36
Update webpage.sh
...
Implement "Halt system" button, next to "Restart system" button, on
admin/settings page. Useful for doing clean shutdown before powering off.
(This affects 4 files, 3 for the web content, 1 for backend script.)
Gilbert Detillieux <gedetil> 2017-04-11
2017-04-11 12:04:44 -05:00
Mcat12
1d64b614c7
Merge pull request #1349 from pi-hole/internal/editorconfig
...
Add .editorconfig
2017-04-06 18:05:56 -04:00
Dan Schaper
a832dd7f67
Update .editorconfig
...
Set path for JS source.
2017-04-06 14:55:21 -07:00
Mcat12
a96b4d28e1
Merge pull request #1365 from pi-hole/adlistImprovements
...
Adlist improvements
2017-04-06 16:15:50 -04:00
Mcat12
57e8b7f924
Merge pull request #1355 from pmo3/development
...
Mask password input when changing password
2017-04-03 20:23:19 -04:00
Patrick O'Brien
263eb856d5
remove vagrant from gitignore
2017-04-03 15:15:44 -04:00
DL6ER
5a4f088b24
Merge pull request #1341 from pi-hole/tweak/readme-tm
...
Update logo and Pi-hole™ name with a trademark symbol.
2017-04-03 17:35:58 +02:00
DL6ER
c1913bfa7d
Merge pull request #1366 from pi-hole/fix/adaway-list-agent
...
Use correct agent when downloading adaway.org list
2017-04-03 17:32:44 +02:00
DL6ER
474881e4c7
Merge pull request #1346 from pi-hole/varChanges
...
Clean up previous PR
2017-04-03 17:32:02 +02:00
Flo
7e0aa822b6
Match the Pi-hole brand ( #1358 )
...
* Update README.md
* Update index.php
* Update basic-install.sh
* Update piholeCheckout.sh
* Update update.sh
* Update CONTRIBUTING.md
* Update the Pi-hole brand tip in CONTRIBUTING.md
Use a better formulation.
* Update README.md 2
2017-04-03 17:29:57 +02:00
DL6ER
940d780a4c
Merge pull request #1361 from pi-hole/new/error404page
...
Improve Error 404 page behavior
2017-04-03 17:25:46 +02:00
DL6ER
ad9575ce18
Recognize more host names
2017-04-03 16:28:18 +02:00
Mcat12
ce86205df0
Use correct agent when downloading adaway.org list
...
See https://discourse.pi-hole.net/t/2278
2017-04-02 12:44:00 -04:00
Adam Warner
3cf9942465
spacing fixed
2017-03-31 23:00:56 +01:00
Adam Warner
153031482f
Add delete mode to adlist command. Might be abetter way to do this
2017-03-31 22:51:10 +01:00
Adam Warner
1f74b1e2fd
newline
2017-03-31 21:12:17 +01:00
Adam Warner
42393123a0
add newline to adlists.default
2017-03-31 20:15:13 +01:00
Adam Warner
af2cff5177
remove call to user list
2017-03-31 20:13:04 +01:00
Adam Warner
5435b93df2
remove spaces
2017-03-31 20:05:45 +01:00
Adam Warner
3a3dde6298
add adlist argument redirector
2017-03-31 20:03:56 +01:00
Adam Warner
b4bc90fb85
add in CustomizeAdlists function
2017-03-31 19:35:52 +01:00
Adam Warner
02040cd25d
We no longer need to do this, either
2017-03-31 19:23:26 +01:00
Adam Warner
bdc6bd4135
Don't need this comment anymore
2017-03-31 19:18:28 +01:00
Adam Warner
e720de401d
One file to rule them all, same functionality (made changes and want to go back to default? Delete your adlists.list)
2017-03-31 19:16:09 +01:00
Adam Warner
ce97896ffd
account for new adlists.custom file
2017-03-31 19:00:04 +01:00
Adam Warner
86fa4e9ee8
trim down default adlist
2017-03-31 18:55:07 +01:00
DL6ER
f09c166350
Improve Error 404 page behavior
2017-03-28 14:02:00 +02:00
Patrick O'Brien
24868fdb2b
Merge remote-tracking branch 'upstream/development' into development
2017-03-27 13:38:19 -04:00
Patrick O'Brien
a463250ecf
don't hash an empty password
2017-03-27 13:37:19 -04:00
Mcat12
d38e034e92
Merge pull request #1354 from flokX/patch-4
...
Complete blocking page
2017-03-26 13:12:42 -04:00
Flo
6eb9192cd1
Complete site
...
The start <html>-tag was missing.
2017-03-25 16:11:37 +01:00
Patrick O'Brien
94f15f1b3c
Merge remote-tracking branch 'upstream/development' into development
2017-03-23 18:47:50 -04:00
Patrick O'Brien
ee296f36c1
mask password input on command line
2017-03-23 18:47:30 -04:00
Dan Schaper
598a7b3cc0
Add .editorconfig
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-22 13:44:04 -07:00
Mcat12
52baf26d7d
Merge pull request #1348 from pi-hole/fix/update-without-web
...
Source setupVars in the updater before attempting to use it
2017-03-21 18:18:03 -04:00
Mcat12
fb3e6ee35c
Source setupVars before attempting to use it
...
Fixes #1347
2017-03-21 18:01:51 -04:00
Dan Schaper
af1d1bd9c2
One more change
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-21 05:04:58 -07:00
Dan Schaper
f32ad7699d
Merge pull request #1320 from georou/development
...
Use Firewalld --add-service instead of port
2017-03-21 04:49:59 -07:00
Dan Schaper
79294bb6ca
Merge pull request #1332 from pi-hole/varChanges
...
replace instances of "/etc/.pihole" with ${PI_HOLE_LOCAL_REPO}
2017-03-21 04:49:10 -07:00
Jacob Salmela
1cd4710718
replace logo with TM logo
2017-03-19 15:41:16 -05:00
Jacob Salmela
48c19ade8e
add trademarks to Pi-hole name in signifigant places
2017-03-19 15:36:22 -05:00
Adam Warner
0acf70f836
Merge pull request #1340 from AnthonyGiorgio/development
...
Formatting cleanup.
2017-03-19 18:40:50 +00:00
Anthony Giorgio
fd584dd03b
Formatting cleanup.
...
Convert backticks to quotes to fix error message.
Make Pi-hole capitalization consistent.
Make Pi-hole capitalization consistent.
2017-03-18 20:47:13 -04:00
Dan Schaper
2740c68a63
Merge pull request #1335 from pi-hole/tweak/debug_templog
...
Debugging tweaks for temporary logfiles
2017-03-16 23:35:15 -07:00
Mcat12
62a242a894
Merge pull request #1334 from pi-hole/tweak/interface_detect
...
Let `ip` determine which links are candidates.
2017-03-16 21:36:13 -04:00
DL6ER
8b060e9699
Merge pull request #1333 from Wandmalfarbe/development
...
Fixed minor spelling mistakes in README.md
2017-03-16 18:02:40 +01:00
Dan Schaper
b1f769b671
Output cleaning, IP stack check headers.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-15 23:50:29 -07:00
Dan Schaper
77378da70a
Cat out temp files to final log.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-15 23:43:41 -07:00
Dan Schaper
160030b75f
Quiet systemctl output to just the current daemon status.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-15 23:27:18 -07:00
Dan Schaper
0a0c3a2fb7
Copy working temp to final location.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-15 23:20:12 -07:00
Dan Schaper
e9f1ca338f
Create temp files for working storage, log to working storage temps.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-15 22:49:47 -07:00
Dan Schaper
073c7e54df
Merge pull request #1331 from pi-hole/RemovePasswordFromDebugLogBecauseSomePeopleFeelItUnderminesSecurity-TheyProbablyHaveAPoint
...
add check on file_parse to not include WEBPASSWORD= in the debug log
2017-03-15 22:08:48 -07:00
Dan Schaper
2834f2ccc2
Let ip determine which links are candidates.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-15 22:05:48 -07:00
georou
6c56665403
updated travis for new firewalld add service
2017-03-16 10:26:51 +11:00
georou
0d794226ab
Removed unsupported POSIX brace expansion
2017-03-16 09:29:33 +11:00
Wandmalfarbe
ab2af11775
Fixed minor spelling mistakes in README.md
2017-03-15 20:58:41 +01:00
Adam Warner
83662c9e50
additional requested changes
2017-03-15 19:50:22 +00:00
Adam Warner
6c1d52199f
Merge branch 'master' of https://github.com/jftuga/pi-hole into jftuga-master
2017-03-15 19:47:31 +00:00
Adam Warner
cfaf1ac67c
add check on file_parse to not include WEBPASSWORD= in the debug log
2017-03-15 18:59:41 +00:00
Mcat12
a6caa0e680
Merge pull request #1327 from pi-hole/fix/pihole-help-text
...
Fix help text bug
2017-03-14 15:00:25 -04:00
Mcat12
c4b43f92ce
Fix help text bug
...
Fixes #1325
2017-03-14 13:19:43 -04:00
DL6ER
3d1ccd9625
Merge pull request #1312 from pi-hole/pihole-backports
...
Pi-hole Core v2.13.2
2017-03-14 11:32:34 +01:00
John Taylor
76bd53ef1f
replace instances of "/etc/.pihole" with ${PI_HOLE_LOCAL_REPO}
2017-03-13 20:24:04 -04:00
Mcat12
8fa209f0df
Merge pull request #1322 from pi-hole/FixWildCardBlacklisting
...
Only remove from wildcard list if domain is being added to whitelist …
2017-03-13 17:52:28 -04:00
Mcat12
88835512dd
Merge pull request #1322 from pi-hole/FixWildCardBlacklisting
...
Only remove from wildcard list if domain is being added to whitelist …
2017-03-13 17:50:18 -04:00
Adam Warner
6b862dd9e9
Only remove from wildcard list if domain is being added to whitelist or blacklist
2017-03-13 20:38:34 +00:00
DL6ER
be0b76c954
Merge pull request #1319 from pi-hole/fix/gravitypath
...
Use absolute path for pihole command in gravity.sh
2017-03-13 21:16:31 +01:00
georou
e45559da20
Use Firewalld services instead of ports
2017-03-14 01:13:23 +11:00
DL6ER
d7b5870ba6
Use absolute path for pihole command in gravity.sh. Fixes #1318
2017-03-12 23:15:23 +01:00
Markus Napp
bb7a7d94ef
Replace misleading letter variable
2017-03-12 16:16:45 +01:00
Markus Napp
9a475cc010
Rewrite help text for better handling of params
2017-03-12 15:50:48 +01:00
Markus Napp
ae30c285a2
Fix handling of wildcard help text
2017-03-12 15:45:11 +01:00
Dan Schaper
df18c7cd59
Merge pull request #1313 from pi-hole/new/piholecheckout
...
Checkout adjustments
2017-03-11 22:54:57 +01:00
Dan Schaper
2e74219ff9
Merge pull request #1313 from pi-hole/new/piholecheckout
...
Checkout adjustments
2017-03-11 13:01:11 -08:00
Dan Schaper
b0ae954f1e
Only update when update flag is set to "true"
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-11 12:37:36 -08:00
Dan Schaper
a2404f104a
Just some style and linting. And a cd in fetch_checkout_pull_branch
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-11 12:21:15 -08:00
DL6ER
38547ced7a
Can only diff once upstream branch is tracked
2017-03-11 16:55:37 +01:00
DL6ER
9a9d9007cd
Add missing "== true"
2017-03-11 16:49:47 +01:00
DL6ER
bd2d81f691
source setupVars.conf to see if INSTALL_WEB is true or not
2017-03-11 16:46:52 +01:00
DL6ER
1b9e7fbf2e
Test if branch is locally available is not reliable because of possible ambiguities
2017-03-11 16:40:10 +01:00
DL6ER
d4a49d192f
Correct variable name
2017-03-11 16:38:28 +01:00
DL6ER
8cb66544d2
Remove "\ "
2017-03-11 16:36:54 +01:00
DL6ER
140ac192aa
The web repo might actually be missing and this is n error (not installed because the user didn't want it)
2017-03-11 16:30:58 +01:00
DL6ER
b961b13d60
Small bugfix
2017-03-11 16:27:00 +01:00
DL6ER
febdb4a190
Use git diff to determine if code has changed (no need to run the installer if it hasn't changed at all)
2017-03-11 16:24:13 +01:00
DL6ER
1d60b62e7a
Testing alternative way of fetching/checking out of a single branch
2017-03-11 16:11:23 +01:00
Dan Schaper
41e1e4cb68
Rearrange pull logic, some optimization.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-10 11:25:35 -08:00
Dan Schaper
d5b88e0df8
Get the right name for the options.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-10 11:07:58 -08:00
Dan Schaper
20fd61468d
Require branch to check out
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-10 11:04:37 -08:00
Dan Schaper
0a0d25dff4
Script runs in subshell, no need to cd back to pwd.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-10 10:57:46 -08:00
DL6ER
38ba079baa
Merge pull request #1307 from pi-hole/fix/versionwithoutwebinterface
...
Don't try to obtain version of web interface it it is not installed
2017-03-10 14:33:12 +01:00
Dan Schaper
33f7979359
Merge pull request #1293 from pi-hole/fix/version
...
Account for hash in versioning
2017-03-10 14:32:52 +01:00
Dan Schaper
8460b2544b
Merge pull request #1295 from pi-hole/tweak/pullapprove
...
Require 4 approvals instead of five for merging into master
2017-03-10 14:31:53 +01:00
Dan Schaper
bc514ea955
Merge pull request #1296 from pi-hole/fix/debugVersion
...
Debug version detection improvements
2017-03-10 14:30:50 +01:00
DL6ER
6f8893d950
Merge pull request #1301 from pi-hole/fix/removewildcard
...
Remove wildcard entry when adding the very same domain either the white- or blacklist
2017-03-10 14:29:38 +01:00
DL6ER
de6aaf18ab
Merge pull request #1302 from pi-hole/fix/nowildcardlistfile
...
Check for existence of wildcard blocking list (query adlists)
2017-03-10 14:29:13 +01:00
DL6ER
0fe64cf5cc
Merge pull request #1300 from pi-hole/fix/deletehostrecord
...
Bugfix for when deleting host-record
2017-03-10 14:28:52 +01:00
DL6ER
9a95531fb9
Merge pull request #1310 from pi-hole/new/piholecheckout
...
Pi-hole checkout feature
2017-03-10 14:24:15 +01:00
Mcat12
9df6a8dd06
Merge pull request #1311 from pi-hole/tweak/ascii-berry
...
add ascii berry to beginning of installer
2017-03-09 13:40:57 -05:00
raincoats
1590a179fa
Change 302 redirect to 301
...
Change "302 Found" response to "301 Moved Permanently", as "302 Found" is meant for temporary redirects.
Was asked to do so in this comment: https://github.com/pi-hole/pi-hole/pull/1297#issuecomment-284335421
2017-03-09 17:38:56 +11:00
Jacob Salmela
5e16487ef6
add ascii berry to beginning of installer
2017-03-08 21:14:21 -06:00
DL6ER
2b3afbfef8
Merge pull request #1310 from pi-hole/new/piholecheckout
...
Pi-hole checkout feature
2017-03-09 00:43:35 +01:00
Dan Schaper
c3c7dcc9f5
Merge remote-tracking branch 'origin/new/piholecheckout' into new/piholecheckout
2017-03-08 15:32:14 -08:00
Dan Schaper
273728b481
One more argument to shift.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 15:32:06 -08:00
DL6ER
81a1057cac
Fix something Dan has overlooked
2017-03-09 00:30:36 +01:00
DL6ER
fd310c6445
Back to how we had it before, because --unshallow does not work at all
2017-03-09 00:28:02 +01:00
Dan Schaper
a9b52518bf
Shift numbers for argument identifiers, functions are called after shift
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 14:29:51 -08:00
Dan Schaper
87da40068c
Always exited with value 1, now exits with proper value.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 14:18:08 -08:00
Dan Schaper
b8f1eadb7f
Shift off checkout from being passed to script from pihole
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 14:17:56 -08:00
Dan Schaper
b522d8eaf6
Source and reuse existing variables, centralize code.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 13:41:11 -08:00
Dan Schaper
89ff99322d
Don't need to remember pwd inside a function, calling function doesn't change directories.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 13:30:08 -08:00
Dan Schaper
56e17d1010
Source functions and variables from basic-install.sh
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-08 13:28:24 -08:00
DL6ER
708067e875
Merge pull request #1309 from pi-hole/new/FTLChronometer
...
Remove duplicated line
2017-03-08 13:27:11 +01:00
DL6ER
d2ab0694b7
Add "master" shortcut
2017-03-08 13:18:34 +01:00
DL6ER
8a14a63d5d
Pi-hole checkout feature
2017-03-08 13:16:40 +01:00
DL6ER
8235b18854
Remove duplicated line
2017-03-08 12:09:34 +01:00
DL6ER
e0e9ebbe74
Merge pull request #1307 from pi-hole/fix/versionwithoutwebinterface
...
Don't try to obtain version of web interface it it is not installed
2017-03-07 23:54:32 +01:00
DL6ER
6e6259975e
Merge pull request #1308 from pi-hole/new/FTLChronometer
...
Let Chronometer query all data from FTL directly
2017-03-07 19:41:23 +01:00
DL6ER
10bc8414b9
Move FTL querying before clearing the terminal to avoid flashing on Pi B+
2017-03-07 18:10:05 +01:00
DL6ER
4e25e0dc5c
Add missing } to JSON output
2017-03-07 17:57:57 +01:00
DL6ER
b1a9793d94
Let Chronometer query all data from FTL (no need for having the API). Fixes #1305
2017-03-07 17:54:11 +01:00
DL6ER
6dea00668e
Don't try to obtain version of web interface it it is not installed. Fixes #1303
2017-03-07 13:08:01 +01:00
DL6ER
ae9182c92e
Merge pull request #1301 from pi-hole/fix/removewildcard
...
Remove wildcard entry when adding the very same domain either the white- or blacklist
2017-03-06 23:53:06 +01:00
DL6ER
af17355fe7
Merge pull request #1302 from pi-hole/fix/nowildcardlistfile
...
Check for existence of wildcard blocking list (query adlists)
2017-03-06 17:03:34 +01:00
DL6ER
dce3e50a00
Check for existence of wildcard blocking list before trying to acces it
2017-03-06 16:44:56 +01:00
DL6ER
cf31561267
Remove wildcard entry when adding the very same domain either the white- or blacklist
2017-03-06 16:25:35 +01:00
DL6ER
a97f0b1298
Merge pull request #1300 from pi-hole/fix/deletehostrecord
...
Bugfix for when deleting host-record
2017-03-06 16:16:42 +01:00
Dan Schaper
d1e0f3ae18
Merge pull request #1294 from pi-hole/tweak/debugDNS
...
Tweak DNS debugging
2017-03-06 05:50:37 -08:00
DL6ER
47a6786e8f
Use proper test syntax
2017-03-06 14:02:56 +01:00
DL6ER
a69fcbb91e
Bugfix for when deleting host-record
2017-03-06 13:44:13 +01:00
Dan Schaper
8e2b51b391
Merge pull request #1296 from pi-hole/fix/debugVersion
...
Debug version detection improvements
2017-03-05 07:13:41 -08:00
Dan Schaper
560af43204
Merge pull request #1293 from pi-hole/fix/version
...
Account for hash in versioning
2017-03-05 07:10:18 -08:00
DL6ER
9c119f919e
Merge pull request #1298 from pi-hole/new/teleporter
...
Add CLI Teleporter feature
2017-03-05 15:05:07 +01:00
DL6ER
baefec86f2
Add CLI teleporter feature
2017-03-05 14:08:44 +01:00
raincoats
eb763d2dc2
Redirect to admin panel when accessing ' http://pi.hole/ '
...
If someone tries to access 'http://pi.hole/ ', it will take them to the "Website blocked" page. Very confusing if you don't know to go to 'http://pi.hole/admin/ '. This just redirects them to the admin panel.
2017-03-05 16:58:21 +11:00
Dan Schaper
512c650441
Shellchecking.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 19:07:55 -08:00
Dan Schaper
dc44fc9e27
Version check amalgamation and removal of && || logic.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 17:54:38 -08:00
Dan Schaper
05640f9a6b
Merge pull request #1295 from pi-hole/tweak/pullapprove
...
Require 4 approvals instead of five for merging into master
2017-03-04 15:17:25 -08:00
Dan Schaper
6f2fb57c08
Protocol specific records checks.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 15:16:33 -08:00
Dan Schaper
2547cc4c8d
Only run IPv6 if enabled, split out Chaos TXT checks.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 15:06:34 -08:00
DL6ER
112ddb3c77
Require 4 approvals instead of five for merging into master
2017-03-04 22:57:37 +01:00
DL6ER
9f4ef66f41
Add IPv6 resolver test
2017-03-04 22:38:52 +01:00
DL6ER
086f0790fc
Add Google's IPv6 address for potential IPv6 resolver tests
2017-03-04 22:31:18 +01:00
Dan Schaper
709b44f736
IPv4 DNS tests
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 12:16:43 -08:00
Dan Schaper
6cd4ff6d68
Organize functions and function calls.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 12:16:32 -08:00
Dan Schaper
abd3e828de
Optimize normalOutput
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-04 07:46:00 -08:00
DL6ER
b85af50d14
Generate only the information that is actually asked for
2017-03-04 14:08:11 +01:00
Dan Schaper
0e8fd49669
Function...
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 23:30:57 -08:00
Dan Schaper
945e22874e
Collapse duplicate functions, and take out argument loops.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 23:12:28 -08:00
Dan Schaper
77ab47a984
Awk for perl
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 22:34:55 -08:00
Dan Schaper
ed8088f203
Functions for Core/Web version and hash. And only check first argument in each section.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 22:10:32 -08:00
Dan Schaper
8831b22fc8
Prototype function for getting version of local repo
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 21:36:38 -08:00
Dan Schaper
0341bd1758
Optimize code, undoc flag for current hash.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 20:32:26 -08:00
Dan Schaper
9bb4a5fb25
Factor out variables from display.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 20:16:53 -08:00
Dan Schaper
ebfffea5dc
Always show something, even if it's just the short hash of the latest commit.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 20:04:55 -08:00
Dan Schaper
81939ab265
Get short hash of local and remote
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-03 19:14:30 -08:00
DL6ER
f2fe84c9d3
Merge pull request #1292 from pi-hole/master
...
Merge patches back into devel
2017-03-03 23:45:29 +01:00
DL6ER
051f463350
Merge pull request #1291 from pi-hole/fix/defaultlisteningbehavior
...
Fix default listening behavior of dnsmasq
2017-03-03 23:33:44 +01:00
DL6ER
f626406685
Revert #1273
2017-03-03 23:14:12 +01:00
DL6ER
dd971b6ee5
Default behavior is old behavir (listen on gravity interface (e.g. eth0), permit all origins)
2017-03-03 22:58:41 +01:00
Dan Schaper
8776b822db
Merge pull request #1287 from pi-hole/fix/update_fail
...
Exit script immediately if we can't update package cache.
2017-03-03 12:20:29 -08:00
DL6ER
fc76b1a6a3
Merge pull request #1244 from pi-hole/new/FTL-binary
...
FTL
2017-03-03 13:41:27 +01:00
DL6ER
9183200b6f
Merge pull request #1286 from pi-hole/tweak/dpkg_lock
...
Test for dpkg lock before using apt-get
2017-03-03 13:39:40 +01:00
DL6ER
f1b8abf503
Merge pull request #1146 from pi-hole/tweak/chronometer_recentlyblocked
...
[FTL] Show most recently blocked domain in chronometer
2017-03-03 12:20:43 +01:00
DL6ER
9502356980
Move test_dpkg_lock to initial UPDATE_PKG_CACHE. There was unpredictable interference with debconf-apt-progress
2017-03-03 11:55:15 +01:00
DL6ER
a535ca9db4
Some tweaks to the new dpkg lock detector
2017-03-03 11:55:13 +01:00
DL6ER
2c762899de
Add loop to wait if package manager is blocked externally
2017-03-03 11:55:10 +01:00
Dan Schaper
24fd23493d
Exit script immediately if we can't update package cache.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-03-02 15:54:58 -08:00
Dan Schaper
6f1ed28d0a
Merge pull request #1274 from pi-hole/development
...
Pi-hole Core v2.13
2017-03-02 14:34:43 -08:00
DL6ER
66b7d04b82
Merge branch 'development' into new/FTL-binary
2017-03-01 12:42:48 +01:00
DL6ER
044afa838c
Merge pull request #1284 from pi-hole/new/dnsmasqListeningBehavior
...
Setup interface listening behavior of dnsmasq
2017-03-01 12:20:59 +01:00
DL6ER
7ba47f504c
Add special "except-interface" line in case of listening on all interfaces
2017-03-01 12:15:04 +01:00
DL6ER
0be1717ff4
Fix config error
2017-03-01 11:46:48 +01:00
DL6ER
189a4e0078
Add option to skip restarting of dnsmasq
2017-03-01 11:26:06 +01:00
DL6ER
3adf8785d8
Move "all" down in help text to not suggest that it is the default
2017-03-01 11:07:05 +01:00
DL6ER
b74862bfc5
Actually apply new setting by restarting dnsmasq
2017-03-01 11:02:08 +01:00
DL6ER
01273124ea
Change to -i, interface
2017-03-01 10:59:55 +01:00
DL6ER
721ada7e16
Fix typo
2017-03-01 10:52:21 +01:00
DL6ER
bd9dc91396
Add response for users manually setting this up via CLI
2017-03-01 10:50:13 +01:00
DL6ER
de6c43a8d3
Setup interface listening behavior of dnsmasq
2017-03-01 10:46:20 +01:00
Technicalpyro
93dea7b942
Moved to installers dependencies
2017-02-27 15:21:59 -05:00
Dan Schaper
f6fc6a5e56
Merge pull request #1281 from pi-hole/tweak/web_debug
...
Back end changes for Web based debug calls.
2017-02-27 12:21:33 -08:00
Dan Schaper
ca24f7c143
Merge pull request #1273 from pi-hole/new/no_fixed_interface
...
Don't save `interface=` line to `dnsmasq`s config file
2017-02-27 11:50:28 -08:00
Dan Schaper
17b0db6515
Fix for calling -w without -a.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-27 11:40:20 -08:00
Dan Schaper
83b0600863
Carriage return or newline based webcalls.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-27 11:03:57 -08:00
Dan Schaper
38961fb31b
Help text clarification and addition of the automated debuggin flag.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-27 10:49:25 -08:00
Dan Schaper
6c130b7960
Vebiage and highligh the token, also :::
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-27 10:27:11 -08:00
Dan Schaper
7244d44a1d
Notify user that log is being uploaded.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-27 10:02:00 -08:00
Dan Schaper
9b060aab34
Debug auto mode engaged
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-26 18:22:06 -08:00
Dan Schaper
ba5bbf3523
Modify pihole for -d -a arguments.
2017-02-26 15:36:53 -08:00
Technicalpyro
697b0295f3
fixes missing dialog package from some ditros
2017-02-26 14:24:08 -06:00
Mcat12
66d7ebd6c3
Merge pull request #1276 from pi-hole/fix/INSTALL_WEB
...
Bugfix: Delete INSTALL_WEB line before adding new one
2017-02-25 10:50:09 -05:00
DL6ER
ae24f1255f
Bugfix: Delete INSTALL_WEB line before adding new one
2017-02-25 11:29:12 +01:00
DL6ER
ec7e75a6e3
Don't save interface= line to dnsmasqs config file
2017-02-24 16:02:24 +01:00
DL6ER
aee106ae69
Merge pull request #1272 from flokX/patch-1
...
Update old install command to new
2017-02-24 13:32:20 +01:00
Flo
2a881a90ac
Update old install command to new
2017-02-24 11:29:19 +01:00
DL6ER
ce6c465942
Merge pull request #1266 from pi-hole/new/host-record
...
Add host-record option
2017-02-23 17:32:10 +01:00
Jacob Salmela
3748a0ed33
Merge pull request #1267 from pi-hole/tweak/license
...
update license to EUPL on core files
2017-02-22 15:51:54 -06:00
Jacob Salmela
7a1a2dec67
update license to EUPL on core files
2017-02-22 11:55:20 -06:00
DL6ER
7ed1bbad49
Add host-record option
2017-02-22 14:43:07 +01:00
DL6ER
078cc7660e
Improved updater logic
2017-02-22 11:00:45 +01:00
DL6ER
af2893d2ce
Updater implementation for FTL
2017-02-22 10:43:13 +01:00
Jacob Salmela
0fe5efba76
Merge pull request #1265 from ProtoFoo/ProtoFoo-redirect
...
Redirect pi.hole to pi.hole/admin/
2017-02-21 15:49:19 -06:00
ProtoFoo
fb6631d317
Removed a line that did nothing.
2017-02-21 22:22:30 +01:00
ProtoFoo
cd0b8927c5
Removed a line that did nothing.
2017-02-21 22:22:03 +01:00
ProtoFoo
3fab34687c
Redirect pi.hole to pi.hole/admin/
2017-02-21 20:38:09 +01:00
ProtoFoo
b2d78edae9
Redirect pi.hole to pi.hole/admin/
2017-02-21 20:36:59 +01:00
ProtoFoo
412cacac49
Merge pull request #1 from pi-hole/development
...
Development
2017-02-21 19:10:47 +01:00
Dan Schaper
dcb9797f35
Tests changed to reflect uname calls.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-21 09:24:00 -08:00
Dan Schaper
4dcee5cd84
arch is not portable.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-21 09:14:49 -08:00
DL6ER
a64211123f
Some debug additions
2017-02-21 16:46:54 +01:00
DL6ER
1645677c3a
Cosmetics
2017-02-21 16:42:52 +01:00
DL6ER
4f85ace525
Force pihole user to use sh-shell (instead of nologin)
2017-02-21 14:46:53 +01:00
DL6ER
e8fde702a0
Also chown the other files
2017-02-21 11:52:07 +01:00
DL6ER
e339f3852c
Change ownership of FTL log to pihole user
2017-02-21 11:50:08 +01:00
DL6ER
032f94afc0
Don't suppress su's output
2017-02-21 11:46:31 +01:00
DL6ER
e9b50442fa
Remove test_FTL_support_files_installed as we create them using the init.d script as of now
2017-02-21 11:25:18 +01:00
DL6ER
77b3764481
Remove resundant code (FTL will later be enabled by enable_service)
2017-02-21 11:23:01 +01:00
DL6ER
90ccbef431
pihole-FTL init.d script
2017-02-21 11:18:47 +01:00
Dan Schaper
02ea9b9abc
Check file path and permissions in one go.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 18:15:40 -08:00
Dan Schaper
4cd598ae10
Check support files installed and permissions.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 18:12:51 -08:00
Dan Schaper
8eeb8ad779
Check binary installed and functional.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 17:15:04 -08:00
Dan Schaper
2ffb103acb
Move binary to final home.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 15:44:33 -08:00
Dan Schaper
a0c17368ed
cd to directory to sha1sum
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 15:27:24 -08:00
Dan Schaper
d76e761d0b
Merge remote-tracking branch 'origin/new/FTL-binary' into new/FTL-binary
...
# Conflicts:
# automated install/basic-install.sh
2017-02-20 15:22:55 -08:00
Dan Schaper
6023984703
Silence sha check
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 15:13:54 -08:00
Dan Schaper
cde7b53de3
Check sha1 of transferred file.
...
Sha1sum file in temp directory.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 15:13:26 -08:00
Dan Schaper
b36a44a954
Check sha1 of transferred file.
2017-02-20 14:44:34 -08:00
Adam Warner
fcc3d5450d
Merge pull request #1263 from pi-hole/idea
...
accidentally the idea file
2017-02-20 22:16:50 +00:00
Dan Schaper
057cecb3e0
Replace ignored file.
2017-02-20 14:12:45 -08:00
Adam Warner
86c6e0e826
accidentally the idea file
2017-02-20 21:36:27 +00:00
Adam Warner
5c223b5f4e
Merge pull request #1262 from pi-hole/gitAttributes
...
linux style line endings enforced
2017-02-20 21:28:16 +00:00
Dan Schaper
883aa30aca
Revert reversion.
2017-02-20 13:25:28 -08:00
Adam Warner
763b51fe22
linux style line endings enforced
2017-02-20 21:12:04 +00:00
Dan Schaper
dd1aa9163c
Fix IDEA ignoring pullapprove.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 12:01:38 -08:00
Dan Schaper
e087797edc
Test for format of tag version.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 11:49:20 -08:00
Dan Schaper
5e6f8489a9
Find 404 errors and relay message.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 11:45:58 -08:00
Dan Schaper
48351fed79
Remove trailing newline from curl'd variable.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 11:33:55 -08:00
Dan Schaper
875a5d309d
Check downloaded file for binary or text.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 11:28:36 -08:00
Dan Schaper
70e876ee13
Download tests.
...
Make sure we download a binary and not just get the GitHub page.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 11:11:16 -08:00
Dan Schaper
7a269e757e
Debian buildpack image for docker (Need curl for testing, using scm version to add curl and git.)
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 09:24:47 -08:00
Dan Schaper
87edbeaf58
Factor out downloader from detector function.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 08:40:17 -08:00
Dan Schaper
339f95b00c
Change from uname -m to straight arch
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 08:13:46 -08:00
Dan Schaper
e480c761cd
Merge remote-tracking branch 'origin/new/FTL-binary' into new/FTL-binary
...
# Conflicts:
# test/test_automated_install.py
2017-02-20 07:25:34 -08:00
Dan Schaper
26c628f8a5
Mock ldd command response.
...
Test aarch64 detection
Arm v6/v7 little endian.
x86_64 native
Test aarch64 detection
Unknown platform detection.
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 07:22:25 -08:00
Dan Schaper
59d6907d71
Test aarch64 detection
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 06:34:57 -08:00
Dan Schaper
b4450a3918
Mock ldd command response.
...
Test aarch64 detection
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 06:34:54 -08:00
Dan Schaper
7032be6049
Template for FTL engine type tests.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net >
2017-02-20 06:34:40 -08:00
DL6ER
70a6a79b8c
Detect library differently
2017-02-20 13:40:32 +01:00
DL6ER
f24f77c5bd
Detect if architecture is *aarch* + use hf binary only if ARMv7+ is detected
2017-02-20 11:14:23 +01:00
DL6ER
66ae79f9b8
Merge pull request #1259 from friimaind/patch-1
...
Added my personal project Pi-hole Droid to the Projects's list
2017-02-20 10:49:00 +01:00
DL6ER
378338c684
Install pihole-FTL to /usr/bin instead of /usr/local/bin
2017-02-20 10:42:07 +01:00
Massimiliano Monaro
7da076df18
Added my personal project Pi-hole Droid to the Projects's list
...
Pi-hole Droid is an unofficial client that connects to your Pi-hole to show charts and statistics.
2017-02-20 10:04:14 +01:00
Adam Warner
45fbadbb26
Merge pull request #1257 from pi-hole/revert-1241-feature/redirect-pi-hole-to-admin
...
Revert "redirect pi.hole to pi.hole/admin"
2017-02-20 02:10:13 +00:00
Adam Warner
a7def771c8
Revert "redirect pi.hole to pi.hole/admin"
2017-02-19 20:12:32 +00:00
Adam Warner
543f1243e2
Merge pull request #1241 from pi-hole/feature/redirect-pi-hole-to-admin
...
redirect pi.hole to pi.hole/admin
2017-02-18 20:59:03 +00:00
Adam Warner
a001443ad7
Merge pull request #1252 from pi-hole/tweak/debug_IP
...
Debug IP stack fixes
2017-02-18 19:33:54 +00:00
Adam Warner
36166c129a
Merge pull request #1253 from Skittels0/even_more_dns
...
Adds DNS.WATCH to default dns servers
2017-02-18 19:12:32 +00:00
Skittels
4e7a485e23
Update basic-install.sh
2017-02-18 13:42:13 +01:00
Skittels
9e5795bf55
Added DNS.WATCH to default dns servers
2017-02-18 13:03:40 +01:00
Dan Schaper
053b38e0bd
Set up for IP matching in detection.
2017-02-16 19:45:44 -08:00
Dan Schaper
2aa3a109a0
Ping gateways and Internet.
2017-02-16 18:38:05 -08:00
Dan Schaper
472708376d
Split out IP checks.
2017-02-16 18:30:15 -08:00
Dan Schaper
cfed3d59e9
Begin fixing IP detection functions.
2017-02-16 16:49:14 -08:00
Adam Warner
95fd9d4863
Merge pull request #1248 from IanOliver/patch-3
...
Update malwaredomains.com and mahakala.is URLs to HTTPS
2017-02-16 08:07:18 +00:00
Ian Oliver
c89bca6ec8
Update malwaredomains.com and mahakala.is URLs to HTTPS
2017-02-15 21:31:42 +00:00
Dan Schaper
ee262c30c2
Merge pull request #1245 from pi-hole/readme/magic-mirror-project
...
add magic mirror project link to readme
2017-02-14 19:21:27 -08:00
Jacob Salmela
6b8240d4de
add magic mirror project link to readme
2017-02-14 20:25:11 -06:00
DL6ER
4035c933df
Moved echo to else block
2017-02-13 16:50:48 +01:00
DL6ER
abd44dd284
Add 32bit message
2017-02-13 16:33:22 +01:00
DL6ER
95d7fe76b5
Make comments more pretty
2017-02-13 14:50:25 +01:00
DL6ER
a052f397fe
Be more verbose during install
2017-02-13 14:47:06 +01:00
DL6ER
09d6e73b0a
Don't print error message on 32bit platforms
2017-02-13 14:42:11 +01:00
DL6ER
7fb6b71d52
Fix install path
2017-02-13 14:40:31 +01:00
DL6ER
07e37d7fc3
Proper error handling
2017-02-13 11:33:09 +01:00
DL6ER
fbe3dc0dcd
Have to get latest tag via GitHub API for downloading the binaries
2017-02-13 11:27:52 +01:00
DL6ER
6018c0c2fc
Add FTLinstall()
2017-02-13 11:07:29 +01:00
DL6ER
52a2f166fd
Add FTLdownload() subroutine
2017-02-13 10:29:27 +01:00
Jacob Salmela
26cb6a1929
redirect pi.hole to pi.hole/admin
2017-02-11 20:46:27 -06:00
Jacob Salmela
7c63bbfe44
Merge pull request #1233 from ProtoFoo/patch-1
...
Add manual edit warnings to lighttpd.conf.* files
2017-02-11 08:10:35 -06:00
Adam Warner
109026222e
Merge pull request #1237 from IanOliver/patch-1
...
Spelling corrections in adlists.default comments
2017-02-10 23:43:11 +00:00
DL6ER
af8e629df4
Merge pull request #1239 from pi-hole/tweak/debug48h
...
Change description as we want to save the debug log for 48h instead of only 24h
2017-02-10 20:46:12 +01:00
DL6ER
f7f1daa69f
Merge pull request #1238 from pi-hole/tweak/debugLogdnsmasq
...
Scan whole dnsmasq.d directory for cofigurations files
2017-02-10 20:46:01 +01:00
DL6ER
01f980d49c
Change description as we want to save the debug log for 48h instead of only 24h
2017-02-10 17:45:20 +01:00
DL6ER
99fab7e52a
Scan whole dnsmasq.d directory for cofigurations files
2017-02-10 17:42:37 +01:00
Ian Oliver
692292b1d4
Spelling corrections in comments
2017-02-10 11:22:14 +00:00
Mcat12
cd608d9d5b
Merge pull request #1182 from pi-hole/adminPageAsOption
...
Give user the choice to install web admin or not
2017-02-09 20:20:08 -05:00
Mcat12
ba67144e34
Merge branch 'development' into adminPageAsOption
2017-02-09 16:27:07 -05:00
ProtoFoo
162d9d7d57
Add manual edit warning
...
Added text block from 01-pihole.conf to warn user that manual changes to lighttpd config will be overwritten.
Slight cosmetic adjustments (tabs -> spaces).
2017-02-09 17:00:52 +01:00
ProtoFoo
357f5a2cfd
Add manual edit warning
...
Added text block from dns config file to warn user that manual changes to lighttpd config will be overwritten.
Slight cosmetic adjustments (tabs -> spaces).
2017-02-09 16:46:55 +01:00
Mcat12
d1ca32b0a5
Merge pull request #1231 from pi-hole/fix/iproute_deps
...
Update basic-install.sh
2017-02-09 10:12:05 -05:00
Dan Schaper
34f326c559
Update basic-install.sh
2017-02-08 14:13:49 -08:00
DL6ER
7785dac50e
Merge pull request #1228 from r0ckarong/development
...
Justify and improve help texts, add missing wildcard description
2017-02-08 14:05:53 +01:00
Markus Napp
01f643e5eb
fixup! Fix spacing for wildcard help in list script
2017-02-08 12:56:28 +01:00
Markus Napp
8037f3e332
Fix spacing for wildcard help in list script
2017-02-08 12:55:14 +01:00
Markus Napp
19e30b829a
Add wildcard description to help text, improve other help texts
2017-02-08 12:42:14 +01:00
Markus Napp
afe5176e01
Justify help output to match main script
2017-02-08 12:41:53 +01:00
Mcat12
a48317883d
Fix indentation
2017-02-07 18:14:41 -05:00
DL6ER
5ac92ae4eb
Merge pull request #1222 from pi-hole/fix/installer
...
Remove double echos
2017-02-07 09:21:22 +01:00
DL6ER
8fb6ba19a1
Remove double echos
2017-02-06 12:06:38 +01:00
Dan Schaper
314f7e7889
Merge pull request #1183 from pi-hole/tweak/update_cache_trap
...
Trap for package cache update failures.
2017-02-05 16:04:19 -08:00
Promofaux
4fcf8fd23f
Merge in development branch - resolve conflict in update.sh
2017-02-05 19:39:02 +00:00
Promofaux
10a30344e5
No need to source setupVars, as basic-install.sh is sourced, which sources setupVars itself. Sourception.
2017-02-05 19:29:56 +00:00
Promofaux
1206dda347
testing putting runGravity at a different part of the script
2017-02-05 19:23:04 +00:00
Promofaux
b764d17c64
comment
2017-02-05 19:18:27 +00:00
Promofaux
ba0abdb88d
wrap update logic in admin_installed bool check
2017-02-05 19:12:09 +00:00
Promofaux
1428b58dde
source setupVars and only check admin repo if it is enabled
2017-02-05 19:07:04 +00:00
Promofaux
e57425df5f
0.0.0.0 instead of pi-holes IP address for redirect purposes
2017-02-04 15:25:11 +00:00
Jacob Salmela
5e7dfaf220
Merge pull request #1214 from pi-hole/tweak/readme-updates
...
Update README with latest version screenshots and remove Raspberry references
2017-02-03 15:43:31 -06:00
Jacob Salmela
ad5c011b6c
Add new screenshots from latest version
2017-02-03 15:33:44 -06:00
Jacob Salmela
fcdd33b585
Update and remove old FAQ links
2017-02-03 15:21:42 -06:00
Jacob Salmela
f767f066ad
Update outdated text and describe features from recent versions
2017-02-03 15:18:28 -06:00
Dan Schaper
b8d0e5e5a1
Merge pull request #1210 from pi-hole/fix/dhcpcd_int
...
Remove comment leaders from DHCPCD interface
2017-02-02 12:48:29 -08:00
Dan Schaper
26ad23f01e
Remove comment leaders from DHCPCD interface
...
We need to set the interface in DHCPCD, comments were inadvertently added a while ago.
2017-02-01 18:33:42 -08:00
DL6ER
21d771e171
Merge pull request #1207 from r0ckarong/master
...
Fix output for wildcards in gravity.sh
2017-02-01 20:13:47 +01:00
Markus Napp
66616eb0f0
Rename missing plurals check
2017-02-01 19:55:33 +01:00
Mcat12
18eb8a2159
Merge pull request #1185 from pi-hole/cleanup/git_functions
...
Move git functions to one script
2017-01-31 19:05:53 -05:00
Markus Napp
72a1fc3f64
Fix output for wildcards in gravity.sh
2017-02-01 00:07:47 +01:00
Dan Schaper
96eea32a9d
Merge pull request #1205 from pi-hole/master
...
Sync master and development
2017-01-31 12:35:08 -08:00
DL6ER
3239c7023a
Merge pull request #1170 from pi-hole/new/DHCPstaticleases
...
Backend changes for static DHCP leases
2017-01-31 21:07:36 +01:00
Dan Schaper
3d9d13222b
Use constants for leading paths.
2017-01-28 17:42:55 -08:00
Dan Schaper
745adabb05
Path to source basic-install.sh
2017-01-28 17:38:14 -08:00
Dan Schaper
3861b57dc6
Start moving reused utility functions to one script.
2017-01-28 17:32:42 -08:00
Dan Schaper
439999cb62
Last rule check.
2017-01-28 16:47:53 -08:00
Dan Schaper
7291aa07ca
Silenc cache updater.
2017-01-28 16:46:37 -08:00
Dan Schaper
9181e2652e
Merge remote-tracking branch 'dschaper/tweak/update_cache_trap' into tweak/update_cache_trap
2017-01-28 16:43:28 -08:00
Dan Schaper
409f76aa34
Error check.
2017-01-28 16:37:31 -08:00
Dan Schaper
54e2c6181a
Populate all required variables with a distro check.
2017-01-28 16:37:28 -08:00
Dan Schaper
a281d87315
Eval variable. (Not a fan.)
2017-01-28 16:37:26 -08:00
Dan Schaper
2a5587f236
Test for failure.
2017-01-28 16:37:17 -08:00
Dan Schaper
2d18b2d784
Start test templates.
2017-01-28 16:37:04 -08:00
Dan Schaper
585f842206
Error check.
2017-01-28 16:33:40 -08:00
Dan Schaper
737819b56e
Populate all required variables with a distro check.
2017-01-28 16:08:43 -08:00
Dan Schaper
a7130e6530
Eval variable. (Not a fan.)
2017-01-28 16:03:48 -08:00
Dan Schaper
f9cfed5aff
Test for failure.
2017-01-28 15:56:43 -08:00
Dan Schaper
f65a9dbfd2
Test for failure.
2017-01-28 15:49:28 -08:00
Dan Schaper
96c59fada4
Spelling check.
2017-01-28 15:47:27 -08:00
Dan Schaper
153a9d8ac7
Start test templates.
2017-01-28 15:45:25 -08:00
Dan Schaper
297d4eec57
Start test templates.
2017-01-28 15:44:31 -08:00
Promofaux
c31b4383e6
add back in code to stop dnsmasq and lighttpd during install.
2017-01-28 21:37:21 +00:00
Promofaux
35828f9cea
Source setupvars earlier in update/repair process
2017-01-28 19:05:55 +00:00
Promofaux
90af12fdb8
Remember the [@]
2017-01-28 18:41:37 +00:00
Promofaux
5fede23cf7
trying another tactic
2017-01-28 18:39:15 +00:00
Promofaux
bc4762f270
no need to stop dnsmasq/lighttpt if we're going to reload them at the end anyway.
2017-01-28 16:27:02 +00:00
Promofaux
01429d59bd
more web checks
2017-01-28 15:45:14 +00:00
Promofaux
731d15f9b5
don't display web admin info in final dialog if it's not selected
2017-01-28 15:43:33 +00:00
Promofaux
f0bd7fae5c
) not }
2017-01-28 15:32:07 +00:00
Promofaux
f8322cc2d4
use the web install flag. Could be optimised
2017-01-28 15:25:02 +00:00
Promofaux
dfdb9e393b
move repo clone to function
2017-01-28 15:15:42 +00:00
Promofaux
bd07d7f32e
Only install web dependenices if flag is true
2017-01-28 15:11:39 +00:00
Promofaux
f588c6f93c
introduce web toggle flag
2017-01-28 14:40:47 +00:00
Promofaux
d9ec3d2c22
spelling
2017-01-28 14:28:18 +00:00
Promofaux
e2b87759d8
split out web dependencies
2017-01-28 14:27:08 +00:00
DL6ER
dad18dc5de
Changed keywords
2017-01-25 10:35:45 +01:00
DL6ER
5c95c4074b
Remove static leases from DHCP static leases file
2017-01-25 10:35:03 +01:00
DL6ER
4301b9a12a
Add static DHCP leases to new file
2017-01-25 10:33:25 +01:00
Mcat12
58f3ff69d8
Align comment with referenced line
2017-01-16 18:51:13 -05:00
DL6ER
72d8d10e64
Show most recently blocked domain in chronometer (using FTL). Fixes #717
2017-01-16 22:39:58 +01:00