use-bats-experiment #14

Closed

ainur wants to merge 2 commits from use-bats-experiment into master

pull from: use-bats-experiment

merge into: ainur:master

ainur:master

ainur:tweak/32bitARM

ainur:fix/etag

ainur:fix/gravity_permission_check

ainur:unsupported/binary

ainur:tweak/6380

ainur:tweak/gravity_curl_error

ainur:fix/declaration

ainur:fix/migration_test

Conversation 0 Commits 2 Files Changed 31 +748 -968

ainur commented 2026-03-18 14:10:29 +00:00

Owner

Copy Link

No description provided.

ainur added 20 commits 2026-03-18 14:10:29 +00:00

Bump tox from 4.35.0 to 4.44.0 in /test in the python-dependencies group ... c8ff8b747f

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).


Updates `tox` from 4.35.0 to 4.44.0
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.35.0...4.44.0)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.44.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump the github-actions-dependencies group with 2 updates ... f2af7c8970

Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [actions/stale](https://github.com/actions/stale).


Updates `github/codeql-action` from 4.32.3 to 4.32.4
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](9e907b5e64...89a39a4e59)

Updates `actions/stale` from 10.1.1 to 10.2.0
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](997185467f...b5d41d4e1d)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.32.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-dependencies
- dependency-name: actions/stale
  dependency-version: 10.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump the github-actions-dependencies group with 2 updates (#6547) 2acb7098d8

Remove additional ':' from debug log system time output ... f28233729c

Signed-off-by: Christian König <github@yubiuser.dev>

Bump tox from 4.35.0 to 4.44.0 in /test in the python-dependencies group (#6546) 08365b3795

Remove additional ':' from debug log system time output (#6551) cda392ac97

Bump tox from 4.44.0 to 4.46.3 in /test in the python-dependencies group ... 6dc67a48e9

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).


Updates `tox` from 4.44.0 to 4.46.3
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.44.0...4.46.3)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.46.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tox from 4.44.0 to 4.46.3 in /test in the python-dependencies group (#6552) ec0ce92aaa

Remove readonly from piholeNetworkFlush.sh to avoid error message ... 36601eef3a

This is a quick fix to avoid the error when api.sh tries to set the
variable again.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Remove readonly from piholeNetworkFlush.sh to avoid error message (#6554) 3d3be66685

Bump tox from 4.46.3 to 4.49.0 in /test in the python-dependencies group ... 752273f400

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).


Updates `tox` from 4.46.3 to 4.49.0
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.46.3...4.49.0)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.49.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump the github-actions-dependencies group with 2 updates ... 8834b49fd3

Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [psf/black](https://github.com/psf/black).


Updates `github/codeql-action` from 4.32.4 to 4.32.6
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](89a39a4e59...0d579ffd05)

Updates `psf/black` from 26.1.0 to 26.3.0
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](6305bf1ae6...35ea67920b)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.32.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-dependencies
- dependency-name: psf/black
  dependency-version: 26.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump the github-actions-dependencies group with 2 updates (#6561) 2d99a95dfb

Bump tox from 4.46.3 to 4.49.0 in /test in the python-dependencies group (#6560) bdeb05b941

Bump psf/black in the github-actions-dependencies group ... ed3f72958b

Bumps the github-actions-dependencies group with 1 update: [psf/black](https://github.com/psf/black).


Updates `psf/black` from 26.3.0 to 26.3.1
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](35ea67920b...c6755bb741)

---
updated-dependencies:
- dependency-name: psf/black
  dependency-version: 26.3.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tox from 4.49.0 to 4.49.1 in /test in the python-dependencies group ... 47de7d5913

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).


Updates `tox` from 4.49.0 to 4.49.1
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.49.0...4.49.1)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.49.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tox from 4.49.0 to 4.49.1 in /test in the python-dependencies group (#6567) c7eff386e5

Bump psf/black from 26.3.0 to 26.3.1 in the github-actions-dependencies group (#6566) cf7139bad8

Replace pytest/tox test suite with BATS ... e1c38e10a7

The Python-based test infrastructure (pytest, tox, testinfra) is replaced
with BATS (Bash Automated Testing System), matching the approach already
used in FTL

Changes:
- Add test/run.sh — single entry point replacing all 15 tox.*.ini files;
  accepts DISTRO env var, builds the test image, installs BATS on demand,
  and selects test files based on distro family (debian/alpine/rhel)
- Add test/helpers/mocks.bash — bash equivalents of conftest.py's
  mock_command*, mock_command_2, and mock_command_passthrough helpers;
  uses base64 transfer to write mock scripts into containers safely
- Add test/test_automated_install.bats — replaces test_any_automated_install.py
- Add test/test_utils.bats — replaces test_any_utils.py
- Add test/test_selinux.bats — replaces test_centos_fedora_common_support.py;
  only run on CentOS/Fedora (rhel family)
- Remove conftest.py, requirements.txt, setup.py, __init__.py
- Remove all 15 tox.*.ini files
- Remove all three Python test files
- Update .github/workflows/test.yml: drop Python setup, tox invocation,
  and black formatting check; distro-test job now runs bash test/run.sh
- Update .gitignore: remove Python-specific entries, add test/libs/

Signed-off-by: PromoFaux <PromoFaux@users.noreply.github.com>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>

Split BATS test suite across files for parallel execution ... 7052d0da65

test_automated_install.bats was a single 372-line file running 18 tests
serially, which doubled wall-clock CI time compared to the old pytest
suite (which used pytest-xdist -n auto for parallelism).

Split into three focused files:
- test_automated_install.bats — core installer: package manager
  detection, SELinux config check, fresh install, package cache
  update (success/failure), dependency installation, meta-package
  uninstall (7 tests)
- test_ftl.bats — FTL architecture detection for all supported arches
  plus binary installation and version check (9 tests)
- test_network.bats — IPv6 address detection (link-local/ULA/GUA
  precedence) and IP address validation (6 tests)

Update run.sh to include the new files and to pass --jobs $(nproc) to
BATS when GNU parallel is available, running all files concurrently.
This restores the degree of parallelism previously provided by
pytest-xdist and brings CI duration back in line with the old suite.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

ainur closed this pull request 2026-03-18 14:10:44 +00:00

Some checks are pending

Hide all checks

CodeQL / Analyze (pull_request) Waiting to run

Details

Test Supported Distributions / smoke-tests (pull_request) Waiting to run

Details

Test Supported Distributions / distro-test (alpine_3_21) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (alpine_3_22) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (alpine_3_23) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (centos_10) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (centos_9) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (debian_11) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (debian_12) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (debian_13) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (fedora_40) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (fedora_41) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (fedora_42) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (fedora_43) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (ubuntu_20) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (ubuntu_22) (pull_request) Blocked by required conditions

Details

Test Supported Distributions / distro-test (ubuntu_24) (pull_request) Blocked by required conditions

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ainur

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ainur/pi-hole#14